From 000e00cf919805fbac87e7295e66bb1029ef35d3 Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Tue, 19 Feb 2019 15:27:25 +0100 Subject: [PATCH] pagers: Fix and add missing @param documentation Sometimes the code expects a specific subclass as it calls a specific method that only exists in this subclass. If this is not the case, all the code needs to know is that it got some special page. Some of these constructors should be changed to expect a IContextSource instead of a special page. But this is for another patch. Here in this patch I intentionally touch documentation only. Change-Id: I33bae9641a8871f359edccacf88f09cfe8e83139 --- includes/specials/pagers/NewPagesPager.php | 10 ++++++++-- includes/specials/pagers/ProtectedPagesPager.php | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/includes/specials/pagers/NewPagesPager.php b/includes/specials/pagers/NewPagesPager.php index 2b094b1d40..d03401db63 100644 --- a/includes/specials/pagers/NewPagesPager.php +++ b/includes/specials/pagers/NewPagesPager.php @@ -24,14 +24,20 @@ */ class NewPagesPager extends ReverseChronologicalPager { - // Stored opts + /** + * @var FormOptions + */ protected $opts; /** - * @var HTMLForm + * @var SpecialNewpages */ protected $mForm; + /** + * @param SpecialNewpages $form + * @param FormOptions $opts + */ public function __construct( $form, FormOptions $opts ) { parent::__construct( $form->getContext() ); $this->mForm = $form; diff --git a/includes/specials/pagers/ProtectedPagesPager.php b/includes/specials/pagers/ProtectedPagesPager.php index f457d2f1e5..fbe69c4549 100644 --- a/includes/specials/pagers/ProtectedPagesPager.php +++ b/includes/specials/pagers/ProtectedPagesPager.php @@ -32,7 +32,7 @@ class ProtectedPagesPager extends TablePager { private $linkRenderer; /** - * @param SpecialProtectedpages $form + * @param SpecialPage $form * @param array $conds * @param string $type * @param string $level -- 2.20.1