resourceloader: Remove use of object registering in test suites
authorTimo Tijhof <krinklemail@gmail.com>
Thu, 11 Jul 2019 19:48:57 +0000 (20:48 +0100)
committerAaron Schulz <aschulz@wikimedia.org>
Fri, 12 Jul 2019 01:17:44 +0000 (01:17 +0000)
commitd6dd6e4d7220a7b34d0256acf50cbeee8b7f22c0
tree0bf416ec0b80b9c26d75906e44884cee4df2248f
parent34427e7d7bfeec0a5f333d5a6fdc2fb2476dd4a1
resourceloader: Remove use of object registering in test suites

This was done as a "clever" shortcut to make sure tests a little
but shorter, but also made them less consistent with normal code.

Remove this in favour of 'class' or 'factory' options as needed.
Also remove a bunch of unneeded register() calls.

The tests cover everything affected by this change.

Side fix - isFileModule should reject modules with 'factory'
the same way it rejected raw objects and non-FileModule 'class'
cases already. This is now covered by tests as well.

Bug: T222637
Change-Id: I3996317dbcd780cc6e0f82c84e769c08a3fc42bb
includes/resourceloader/ResourceLoader.php
tests/phpunit/ResourceLoaderTestCase.php
tests/phpunit/includes/resourceloader/MessageBlobStoreTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderClientHtmlTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderWikiModuleTest.php