Stop stubbing StubUserLang
authorChad Horohoe <chadh@wikimedia.org>
Tue, 3 Oct 2017 21:26:18 +0000 (14:26 -0700)
committerChad <chadh@wikimedia.org>
Tue, 3 Oct 2017 21:54:34 +0000 (21:54 +0000)
commit7ab57ba290f670847f981d5fc2c79339f1d4844e
treec30ee2b795c251b733496d2eff2ab83cb8f382c2
parentf58546ef6e55342ff2d54bdf9e421102aed7aa76
Stop stubbing StubUserLang

Stub objects are confusing as heck and are a performance optimization
that really aren't fit for the modern era. They were designed to avoid
loading the actual code from the disk back in the days when bytecode
caching wasn't always gonna be there.

It's 2017. If you're using HHVM, you've got a bytecode cache. If you're
using any reasonably recent version of PHP then you've got the opcode
caching enabled by default in basically every distro-related build.

Nothing actually relies on this object being a stub (that'd be silly),
so only references are basically things force unstubbing (also kind of
silly) the object. Once remaining code referencing this in extensions
are all cleaned up then we can remove the class itself.

Change-Id: I15df24aeeb729e8e764792daa933377f35042fab
includes/Message.php
includes/Setup.php
includes/Status.php
includes/parser/CoreParserFunctions.php