Improve hidden field validation
authorBrad Jorsch <bjorsch@wikimedia.org>
Thu, 31 Jul 2014 18:04:00 +0000 (14:04 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Thu, 31 Jul 2014 18:04:00 +0000 (14:04 -0400)
commit788526c2d1a4a9e32722c0a26b4a5027f00aa9bb
tree0df3fc77c9ec8e16fca7654973b47948650e3335
parent4169b4f42502ca1956f7a7253b5f54e1901e7821
Improve hidden field validation

Hidden fields are supposed to be ignored during validation; more
completely ensure this by checking in HTMLForm::trySubmit before calling
validate.

Also, more properly handle HTMLCheckFields in the isHidden check by
casting their booleans to strings.

Bug: 68132
Change-Id: I84f8239c299727b773015643048eed4684417733
includes/htmlform/HTMLForm.php
includes/htmlform/HTMLFormField.php