mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start
authorTimo Tijhof <krinklemail@gmail.com>
Tue, 11 Jul 2017 19:56:35 +0000 (12:56 -0700)
committerKrinkle <krinklemail@gmail.com>
Thu, 13 Jul 2017 04:44:43 +0000 (04:44 +0000)
commit6418c54c4ad9a49643ba61a6567b2c8359926c5f
tree0ff08dbb9be575309647d823a3b371a84e7bff11
parentdcae3733c98cff011e3170bb4eb8748a31f70496
mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start

Deprecated since QUnit 1.16, removed in QUnit 2.0. (We're on 1.23 currently.)

Migrate to assert.async().

This is a fairly atypical use of QUnit.start(), because it functions here
as a cross-script callback, where lexical scope cannot be used to share
the async() callback directly.

Other mw.loader tests already solved this by using a static callback instead
which inherits the lexical scope from the test to call done(). The old
'qunitOkCall' script is no longer used after this and thus removed.

Change-Id: I430df14b35a69c71df8685494d1379e22af0d6df
tests/qunit/data/callMwLoaderTestCallback.js [deleted file]
tests/qunit/data/mwLoaderTestCallback.js [new file with mode: 0644]
tests/qunit/data/qunitOkCall.js [deleted file]
tests/qunit/suites/resources/mediawiki/mediawiki.loader.test.js