Fix WatchedItemStore last-seen stashing logic
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 14 Mar 2019 19:50:52 +0000 (12:50 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 14 Mar 2019 21:52:29 +0000 (14:52 -0700)
commit588a4646825236502270b08ff05c53434abbaebc
tree2d4b579171d9ede3b35f583879f5b3b621667fef
parentba69994b3a7c554db64d8e6389cc1d225035f603
Fix WatchedItemStore last-seen stashing logic

This should be the "last revision seen" timestamp, which is
different than the "first revision not seen" timestamp in the DB.

Also make sure that SpecialWatchlist accounts for the stash values.

Relatedly, better document the callback usage in BagOStuff::merge().

Change-Id: I98b03a5cd40fec5b4a2633d499ff77079d264e3c
includes/libs/objectcache/BagOStuff.php
includes/specials/SpecialWatchlist.php
includes/watcheditem/WatchedItemStore.php
tests/phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php