mail: Always quote uncoded names in MailAddress
authorAlexia E. Smith <washuu@gmail.com>
Tue, 10 Apr 2018 22:10:33 +0000 (17:10 -0500)
committerKrinkle <krinklemail@gmail.com>
Tue, 24 Apr 2018 21:29:25 +0000 (21:29 +0000)
commit2b28a56d8ac9a2393924a0b201cc39bd86fc4d15
tree023c2010e29b2737f9ce3aaba0eb22daed8be935
parent0898ab0a5d99c0d92c83d26d8b8b090f76e023de
mail: Always quote uncoded names in MailAddress

Otherwise, names that contain whitespace (but no special characters
that need Q-encoding) will be sent as-is in an email header. While
that's valid by RFC 1036, RFC 5322 and others, some mail programs
fail to correctly process spaces. Avoid these problems by simply
quoting the name always - except for cases which are Q-encoded,
which must remain unquoted to be valid (and also cannot contain
spaces, thus unaffected).

Before:
> From: Foo Bar <fb@example.org>

After:
> From "Foo Bar" <fb@example.org>

Update test to work with the new criteria.

Bug: T191931
Change-Id: I4b2a0a80e8b43ecc943939fc5ebaa356a4f840e0
includes/mail/MailAddress.php
tests/phpunit/includes/mail/MailAddressTest.php