lhc/web/wiklou.git
4 years agoYet another attempt to fix the populateIpChanges script
MusikAnimal [Tue, 19 Sep 2017 23:51:34 +0000 (19:51 -0400)]
Yet another attempt to fix the populateIpChanges script

It would seem we'd need to update $blockStart if there are no results
for a given block, and more importantly, continue and not break!

Bug: T175962
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b954e064

4 years agoDon't attempt to copy to ip_changes in PageArchive class.
MusikAnimal [Tue, 19 Sep 2017 22:11:28 +0000 (18:11 -0400)]
Don't attempt to copy to ip_changes in PageArchive class.

This actually happens in Revision::insertOn, so the code is redundant,
but also shouldn't ever execute because it erroneously was checking
for ar_rev_id=0 and not ar_user=0.

This is sometimes causing errors in production, in the rare cases
where ar_rev_id is NULL, and hence (int)ar_rev_id evaluates to 0.

Change-Id: I35a7310f600a9db683d7dc0e730da8ff31e337a2

4 years agoMerge "CSSMin: Mangle whitespace in embedded SVGs"
jenkins-bot [Tue, 19 Sep 2017 21:27:31 +0000 (21:27 +0000)]
Merge "CSSMin: Mangle whitespace in embedded SVGs"

4 years agoMerge "Attempt to fix populateIpChanges maintenance script"
jenkins-bot [Tue, 19 Sep 2017 20:40:28 +0000 (20:40 +0000)]
Merge "Attempt to fix populateIpChanges maintenance script"

4 years agoMerge "ContribsPager: Check if target is an IP range outside foreach loop"
jenkins-bot [Tue, 19 Sep 2017 20:31:15 +0000 (20:31 +0000)]
Merge "ContribsPager: Check if target is an IP range outside foreach loop"

4 years agoAttempt to fix populateIpChanges maintenance script
MusikAnimal [Mon, 18 Sep 2017 20:57:26 +0000 (16:57 -0400)]
Attempt to fix populateIpChanges maintenance script

With the previous edition, some IP revisions failed to copy,
e.g. rev_id 1507693 on enwikivoyage. This change first fixes to go
by mBatchSize, and removes other redundant clauses in the query.

Bug: T175962
Change-Id: Ia5f3e275d8bef120090b4c60e6aec4c204d55d53

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 19 Sep 2017 20:14:03 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I7b3144ed162fda4b58dd1df58e7c0b7310f2a087

4 years agoMerge "CSSMin: Improve encoding of quotes in embedded SVGs"
jenkins-bot [Tue, 19 Sep 2017 19:01:18 +0000 (19:01 +0000)]
Merge "CSSMin: Improve encoding of quotes in embedded SVGs"

4 years agoCSSMin: Mangle whitespace in embedded SVGs
Roan Kattouw [Thu, 14 Sep 2017 18:32:07 +0000 (11:32 -0700)]
CSSMin: Mangle whitespace in embedded SVGs

Convert newlines and tabs to spaces (which can be unencoded),
and consolidate runs of multiple spaces into a single space.
Also remove any leading and trailing spaces that might result
(most files end in a newline, for example).

Bug: T175318
Change-Id: Ic66c6acb37079cae84dd80ab2d5f2c829cf2df96

4 years agoMerge "Update signature of UserGroupsChanged to match documentation"
jenkins-bot [Tue, 19 Sep 2017 18:51:53 +0000 (18:51 +0000)]
Merge "Update signature of UserGroupsChanged to match documentation"

4 years agoMerge "SpecialRecentchangeslinked: Unconditionally join on the page table"
jenkins-bot [Tue, 19 Sep 2017 18:07:12 +0000 (18:07 +0000)]
Merge "SpecialRecentchangeslinked: Unconditionally join on the page table"

4 years agoCSSMin: Improve encoding of quotes in embedded SVGs
Roan Kattouw [Wed, 13 Sep 2017 19:27:15 +0000 (12:27 -0700)]
CSSMin: Improve encoding of quotes in embedded SVGs

When a URL (data: or otherwise) contains quotes, don't wrap it in
double quotes (") but in single quotes ('). This then allows
us to unencode double quotes (") in the data URI embedding of SVGs.

Bug: T175318
Change-Id: I3e7eab64e1c3e82066014fb594f82d786983ce90

4 years agoDumpFilter is autoloaded. No need to require in maintenance script
Reedy [Sun, 17 Sep 2017 18:59:46 +0000 (19:59 +0100)]
DumpFilter is autoloaded. No need to require in maintenance script

Change-Id: Ib5c5e9a5144eb5454d1e498bf6f18d9e5829a52f

4 years agoUpdate signature of UserGroupsChanged to match documentation
Umherirrender [Sun, 17 Sep 2017 09:09:53 +0000 (11:09 +0200)]
Update signature of UserGroupsChanged to match documentation

UserGroupsChanged is called in Special:UserRights with seven args
The caller in User.php only has five

Change-Id: I221da323c79bb8da0113533d01b429249d15e7de

4 years agoMerge "Remove unused variables from closures"
jenkins-bot [Tue, 19 Sep 2017 17:27:52 +0000 (17:27 +0000)]
Merge "Remove unused variables from closures"

4 years agoSpecialRecentchangeslinked: Unconditionally join on the page table
Roan Kattouw [Tue, 19 Sep 2017 17:22:47 +0000 (10:22 -0700)]
SpecialRecentchangeslinked: Unconditionally join on the page table

As we do on SpecialRecentchanges and SpecialWatchlist already,
because the last revision filter needs it.

Bug: T176228
Change-Id: I65f0f971df24853999ca445f968dd49fb0640066

4 years agoMerge "Fix link prefix/suffixes around Category and Language links (take 2)."
jenkins-bot [Tue, 19 Sep 2017 16:59:58 +0000 (16:59 +0000)]
Merge "Fix link prefix/suffixes around Category and Language links (take 2)."

4 years agoMerge "Remove return bool from MysqlUpdater::doInterwikiUpdate"
jenkins-bot [Tue, 19 Sep 2017 16:41:31 +0000 (16:41 +0000)]
Merge "Remove return bool from MysqlUpdater::doInterwikiUpdate"

4 years agoMerge "Remove use of implicitGroupby() in WikiPage"
jenkins-bot [Tue, 19 Sep 2017 16:37:46 +0000 (16:37 +0000)]
Merge "Remove use of implicitGroupby() in WikiPage"

4 years agoMerge "Remove contentSub from layout when empty"
jenkins-bot [Tue, 19 Sep 2017 16:12:00 +0000 (16:12 +0000)]
Merge "Remove contentSub from layout when empty"

4 years agoMerge "Hooks: Introduce Hooks::runWithoutAbort() alongside Hooks::run()"
jenkins-bot [Tue, 19 Sep 2017 10:04:49 +0000 (10:04 +0000)]
Merge "Hooks: Introduce Hooks::runWithoutAbort() alongside Hooks::run()"

4 years agoRemove use of implicitGroupby() in WikiPage
Aaron Schulz [Sat, 9 Sep 2017 20:57:35 +0000 (13:57 -0700)]
Remove use of implicitGroupby() in WikiPage

Change-Id: I17cc3ae5a6e90ba49978606e9ca6a1cdcdb57c03

4 years agoRemove unused variables from closures
Fomafix [Tue, 19 Sep 2017 03:42:26 +0000 (05:42 +0200)]
Remove unused variables from closures

Change-Id: I5d2e0cd423a4080677f8517bcf3dcee10bf44799

4 years agoWLFilters: Handle (un)seen (un)filled bullets on grouped RC
Matthew Flaschen [Tue, 19 Sep 2017 02:32:01 +0000 (22:32 -0400)]
WLFilters: Handle (un)seen (un)filled bullets on grouped RC

Bug: T176191
Change-Id: I9892f607eebe01d2b74f9eb7f20daf3bf6876398

4 years agoSECURITY: Fix handling of CommentStore and insertSelect
Brad Jorsch [Mon, 18 Sep 2017 14:14:02 +0000 (10:14 -0400)]
SECURITY: Fix handling of CommentStore and insertSelect

CommentStore->insert() takes the raw comment, not quoted, and returns
fields appropriate for passing as $a to IDatabase->insert() or $values
to ->update(). Such fields need to be passed through
IDatabase->addQuotes() to be appropriate for passing in $varMap to
IDatabase->insertSelect().

Change-Id: Ie64b279ee7cf9c8c396af385e46c826e0597ab1e

4 years agoMerge "mw.loader: Use Object.create() instead of $.extend() where possible"
jenkins-bot [Mon, 18 Sep 2017 22:17:14 +0000 (22:17 +0000)]
Merge "mw.loader: Use Object.create() instead of $.extend() where possible"

4 years agoMerge "Deprecate IDatabase::implicitGroupby()"
jenkins-bot [Mon, 18 Sep 2017 21:45:59 +0000 (21:45 +0000)]
Merge "Deprecate IDatabase::implicitGroupby()"

4 years agoMerge "Remove use of implicitGroupBy() in ActiveUsersPager"
jenkins-bot [Mon, 18 Sep 2017 21:43:50 +0000 (21:43 +0000)]
Merge "Remove use of implicitGroupBy() in ActiveUsersPager"

4 years agoMerge "Remove implicitGroupby() use in ImageListPager"
jenkins-bot [Mon, 18 Sep 2017 21:39:09 +0000 (21:39 +0000)]
Merge "Remove implicitGroupby() use in ImageListPager"

4 years agoMerge "Cleanup form for history"
jenkins-bot [Mon, 18 Sep 2017 21:06:42 +0000 (21:06 +0000)]
Merge "Cleanup form for history"

4 years agoMerge "Revert "Tweak UI for main filtering entry point""
jenkins-bot [Mon, 18 Sep 2017 20:58:40 +0000 (20:58 +0000)]
Merge "Revert "Tweak UI for main filtering entry point""

4 years agoMerge "WLFilters: always create a balanced fieldset"
jenkins-bot [Mon, 18 Sep 2017 20:54:10 +0000 (20:54 +0000)]
Merge "WLFilters: always create a balanced fieldset"

4 years agoRevert "Tweak UI for main filtering entry point"
Mooeypoo [Mon, 18 Sep 2017 20:47:04 +0000 (20:47 +0000)]
Revert "Tweak UI for main filtering entry point"

This reverts commit feefb51581574f3144786d7f935f34ccc947efed.

Change-Id: I37dcaf5cd0c0fa63a53da06f06827731fb87de20

4 years agoMerge "RCFilters: Actually check whether defaults are empty and update state"
jenkins-bot [Mon, 18 Sep 2017 20:42:42 +0000 (20:42 +0000)]
Merge "RCFilters: Actually check whether defaults are empty and update state"

4 years agoMerge "Follow-up 4107d1d4: avoid JS errors when trying to call mw.track() from jquery...
jenkins-bot [Mon, 18 Sep 2017 20:37:02 +0000 (20:37 +0000)]
Merge "Follow-up 4107d1d4: avoid JS errors when trying to call mw.track() from jquery.migrate"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 18 Sep 2017 20:19:11 +0000 (22:19 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia5f3e275d8bef120090b4c60e6aec4c204d55d52

4 years agoRCFilters: Actually check whether defaults are empty and update state
Moriel Schottlender [Mon, 18 Sep 2017 18:05:50 +0000 (11:05 -0700)]
RCFilters: Actually check whether defaults are empty and update state

Defaults come from either the backend or the saved queries, and that can
also change during the session. Allow the system to update itself properly
over whether defaults are empty at any given state, and hide/show the
proper button at the correct state.

Bug: T172387
Change-Id: I173c72a391886b41e899ac64621b504c5eb55b0c

4 years agoMerge "Tweak UI for main filtering entry point"
jenkins-bot [Mon, 18 Sep 2017 19:28:40 +0000 (19:28 +0000)]
Merge "Tweak UI for main filtering entry point"

4 years agoFollow-up 4107d1d4: avoid JS errors when trying to call mw.track() from jquery.migrate
Roan Kattouw [Mon, 18 Sep 2017 19:24:43 +0000 (12:24 -0700)]
Follow-up 4107d1d4: avoid JS errors when trying to call mw.track() from jquery.migrate

Some migrateWarn() calls (like the one for compatMode) happen before
mw is created. Don't crash on trying to call mw.track() in that case.

Change-Id: I9e33af2865bb10adc0473045f714fe4f9f699861

4 years agoWLFilters: always create a balanced fieldset
Stephane Bisson [Mon, 18 Sep 2017 19:07:55 +0000 (15:07 -0400)]
WLFilters: always create a balanced fieldset

Don't count on Xml::fieldset creating only the opening tag.

Bug: T176155
Change-Id: Idc4e450c9fa03fc78a012fb5eefa60174bb1245a

4 years agoMerge "API: Pass revid when parsing text"
jenkins-bot [Mon, 18 Sep 2017 18:52:18 +0000 (18:52 +0000)]
Merge "API: Pass revid when parsing text"

4 years agoMerge "Move New Filters opt-out preference to own section"
jenkins-bot [Mon, 18 Sep 2017 18:44:25 +0000 (18:44 +0000)]
Merge "Move New Filters opt-out preference to own section"

4 years agoAPI: Pass revid when parsing text
Arlo Breault [Thu, 14 Sep 2017 01:13:15 +0000 (21:13 -0400)]
API: Pass revid when parsing text

 * Provides consistency with expandtemplates
 * Necessary for properly rendering `text` with {{REVISIONID}}

Change-Id: I310d0778d74c46f15385cd411d2462b541ed339a

4 years agoCleanup form for history
Amir Sarabadani [Sun, 17 Sep 2017 13:20:34 +0000 (17:20 +0400)]
Cleanup form for history

Also fixing regression caused by Ie119c92aa4936e2f8982163d4b00d08949f49264

Change-Id: I59f623d2dc43f83cfca3ff31ef79fed0230f68af

4 years agoMerge "Revert "Xml: Fix Xml::fieldset() when $content is not given""
jenkins-bot [Mon, 18 Sep 2017 18:13:40 +0000 (18:13 +0000)]
Merge "Revert "Xml: Fix Xml::fieldset() when $content is not given""

4 years agoMerge "Wrap fieldset in SpecialNewpages using HTMLForm"
jenkins-bot [Mon, 18 Sep 2017 17:31:34 +0000 (17:31 +0000)]
Merge "Wrap fieldset in SpecialNewpages using HTMLForm"

4 years agomw.loader: Use Object.create() instead of $.extend() where possible
Timo Tijhof [Thu, 14 Sep 2017 17:41:36 +0000 (19:41 +0200)]
mw.loader: Use Object.create() instead of $.extend() where possible

For cases where we want a variation of an object with some keys added
or changed, use native Object.create() to create a plain object that
inherits from the other object (without needing to loop and copy each
key/value separately).

This optimisation only works, of course, if the original object
by-reference does not change later.

Also remove hasOwn filter from sortQuery, because it must now consider
inherited keys as well. This filter was already obsolete given mw.loader
already has many unfiltered for-in loops in other places, and just in
general doesn't support environments that extend Object.prototype.

Change-Id: Ib405e32d4598dfb94629c2596ea0804d1c13e7c0

4 years agoMerge "ResourceLoaderImageModule: Use CSSMin::buildUrlValue() where needed"
jenkins-bot [Mon, 18 Sep 2017 16:39:16 +0000 (16:39 +0000)]
Merge "ResourceLoaderImageModule: Use CSSMin::buildUrlValue() where needed"

4 years agoMerge "Improve encoding of embedded SVGs"
jenkins-bot [Mon, 18 Sep 2017 16:29:48 +0000 (16:29 +0000)]
Merge "Improve encoding of embedded SVGs"

4 years agoMerge "Run strval() over the File description"
jenkins-bot [Mon, 18 Sep 2017 16:08:25 +0000 (16:08 +0000)]
Merge "Run strval() over the File description"

4 years agoSpeed up populateIpChanges maintenance script.
MusikAnimal [Sat, 16 Sep 2017 21:05:07 +0000 (17:05 -0400)]
Speed up populateIpChanges maintenance script.

Use BETWEEN in populateIpChanges maintenance script, which will make it
more efficient when copying revisions with a high rev_id. Also adding a
'max-rev-id' option to prevent the script from looping through IP
changes that have already been copied since the core patch was deployed.

Bug: T175962
Change-Id: I1df10c9b7237ad5002f76f9d354c36ce879d9d9f

4 years agoMerge "Don't unconditionally run patch-editsummary-length.sql"
jenkins-bot [Mon, 18 Sep 2017 15:51:17 +0000 (15:51 +0000)]
Merge "Don't unconditionally run patch-editsummary-length.sql"

4 years agoMerge "Split mediawiki.special.preferences into separate file for each function"
jenkins-bot [Mon, 18 Sep 2017 15:18:10 +0000 (15:18 +0000)]
Merge "Split mediawiki.special.preferences into separate file for each function"

4 years agoMerge "Return description fields for unprefixed image cache rows"
jenkins-bot [Mon, 18 Sep 2017 14:59:59 +0000 (14:59 +0000)]
Merge "Return description fields for unprefixed image cache rows"

4 years agoMerge "phpunit.php: omit --quiet in help"
jenkins-bot [Mon, 18 Sep 2017 14:45:31 +0000 (14:45 +0000)]
Merge "phpunit.php: omit --quiet in help"

4 years agoDon't unconditionally run patch-editsummary-length.sql
Reedy [Sun, 17 Sep 2017 22:56:51 +0000 (23:56 +0100)]
Don't unconditionally run patch-editsummary-length.sql

Bug: T176041
Change-Id: I165ee4fa1c0cfadf5f8f400a0ea9db220ed7dbbb

4 years agoMove New Filters opt-out preference to own section
petarpetkovic [Mon, 18 Sep 2017 14:23:25 +0000 (16:23 +0200)]
Move New Filters opt-out preference to own section

- Add a new section to preference page with the following title:
"Opt out of improvements".
- Move the opt-out option and explanatory text to this new section.

Bug: T175765
Change-Id: Iaf77df2eec714777f54b95b58eb617b5e35bef75

4 years agoReturn description fields for unprefixed image cache rows
Reedy [Mon, 18 Sep 2017 00:58:18 +0000 (01:58 +0100)]
Return description fields for unprefixed image cache rows

Bug: T175444
Change-Id: I5560187d3850253095b695dc7a3cfc954fba9318

4 years agoTweak UI for main filtering entry point
petarpetkovic [Mon, 18 Sep 2017 13:20:39 +0000 (15:20 +0200)]
Tweak UI for main filtering entry point

- Change the hamburger icon to plus sign.
- Change the search bar input placeholder text to "Main filter menu".
- Adjust the font style of main entry point placeholder.
- Adjust the font style of the advanced filters label.

Bug: T175217
Change-Id: I24742b68ef8bfeb9f3f71d5dc8818464412ab3f2

4 years agoMerge "Fix findHooks.php"
jenkins-bot [Mon, 18 Sep 2017 09:17:06 +0000 (09:17 +0000)]
Merge "Fix findHooks.php"

4 years agoRun strval() over the File description
Reedy [Mon, 18 Sep 2017 00:00:07 +0000 (01:00 +0100)]
Run strval() over the File description

Bug: T176090
Change-Id: I8488666c221a1bd4e4e063291e74819a07a4a20f

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 17 Sep 2017 19:54:28 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I8c413069268400a1a0f6ab9808c713666652271f

4 years agoRevert "Xml: Fix Xml::fieldset() when $content is not given"
Bartosz Dziewoński [Sun, 17 Sep 2017 17:05:40 +0000 (17:05 +0000)]
Revert "Xml: Fix Xml::fieldset() when $content is not given"

Apparently that is intentional and documented. Huh. Whoops.

This reverts commit 0f1cc3bb6e7c3be9b86d2c8736f7458cd40588f2.

Also add test cases for this bizarre function.

Change-Id: I0311f7c85cd575f2a66d50589ec364072be486fb

4 years agoMerge "Do not run CollationFaTest if 'intl' is not loaded"
jenkins-bot [Sun, 17 Sep 2017 17:05:34 +0000 (17:05 +0000)]
Merge "Do not run CollationFaTest if 'intl' is not loaded"

4 years agoWrap fieldset in SpecialNewpages using HTMLForm
Amir Sarabadani [Sun, 17 Sep 2017 15:23:43 +0000 (19:23 +0400)]
Wrap fieldset in SpecialNewpages using HTMLForm

That's cleaner and fixes Ie119c92aa4936e2f8982163d4b00d08949f49264

Change-Id: I8721ae5db79d287a49c2ab8070f8838174a8d687

4 years agoMerge "mediawiki.action.edit.preview: Apply mw.language.bcp47 to lang"
jenkins-bot [Sun, 17 Sep 2017 09:39:16 +0000 (09:39 +0000)]
Merge "mediawiki.action.edit.preview: Apply mw.language.bcp47 to lang"

4 years agoFix findHooks.php
Umherirrender [Sun, 17 Sep 2017 08:54:49 +0000 (10:54 +0200)]
Fix findHooks.php

Add the test entry point, because it contains documented hooks.
Filter out empty args, coming from trailing commas

Removed empty lines from hooks.txt, because a hook must be one block
without newlines between.

Change-Id: I71e0625da96cad03f5e38a000fa61d1d2bdac8ef

4 years agophpunit.php: omit --quiet in help
Gergő Tisza [Sun, 17 Sep 2017 05:03:50 +0000 (05:03 +0000)]
phpunit.php: omit --quiet in help

Bug: T176060
Change-Id: Iee7a0df6ba9fadf92d8e2d9f170cdfc66244d3d5

4 years agoRemove return bool from MysqlUpdater::doInterwikiUpdate
Umherirrender [Sat, 9 Sep 2017 23:52:25 +0000 (01:52 +0200)]
Remove return bool from MysqlUpdater::doInterwikiUpdate

All return values unequal to false are treated as "update done",
so return void is okay.

Change-Id: I553f6acb450a5fe1708aec641181f9a07da1ac39

4 years agoDo not run CollationFaTest if 'intl' is not loaded
Huji Lee [Sat, 16 Sep 2017 20:30:18 +0000 (16:30 -0400)]
Do not run CollationFaTest if 'intl' is not loaded

Bug: T176040
Change-Id: I6b19bf1123d4dca5a1c8e002c0de65bab2138180

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 16 Sep 2017 20:16:12 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I40f96fd439726f95b0dc467cf2f2802f1a3144d7

4 years agoMerge "Fix return in Preprocessor::cacheSetTree"
jenkins-bot [Sat, 16 Sep 2017 20:07:56 +0000 (20:07 +0000)]
Merge "Fix return in Preprocessor::cacheSetTree"

4 years agoMerge "Fix return of Interwiki::invalidateCache"
jenkins-bot [Sat, 16 Sep 2017 20:04:05 +0000 (20:04 +0000)]
Merge "Fix return of Interwiki::invalidateCache"

4 years agoMerge "Fix return in HttpStatus::header"
jenkins-bot [Sat, 16 Sep 2017 20:02:50 +0000 (20:02 +0000)]
Merge "Fix return in HttpStatus::header"

4 years agoMerge "mediawiki.special.preferences: Allow linking to subsections"
jenkins-bot [Sat, 16 Sep 2017 16:27:56 +0000 (16:27 +0000)]
Merge "mediawiki.special.preferences: Allow linking to subsections"

4 years agoMerge "Preferences: Do not set non-breaking space as a label"
jenkins-bot [Sat, 16 Sep 2017 16:27:53 +0000 (16:27 +0000)]
Merge "Preferences: Do not set non-breaking space as a label"

4 years agoMerge "Xml: Fix Xml::fieldset() when $content is not given"
jenkins-bot [Sat, 16 Sep 2017 13:58:37 +0000 (13:58 +0000)]
Merge "Xml: Fix Xml::fieldset() when $content is not given"

4 years agoSplit mediawiki.special.preferences into separate file for each function
Bartosz Dziewoński [Fri, 15 Sep 2017 18:45:24 +0000 (20:45 +0200)]
Split mediawiki.special.preferences into separate file for each function

This JavaScript code does four things:
* Convert a simple form into one with tab navigation
* Convert a simple message box into pretty notifications
* Prevent browser window from being closed with unsaved changes to preferences
* Add some enhancements to the timezone field

I will be making some large changes here for T117781 and having
everything mixed in one file was making that difficult. I avoided
making any cleanup changes to make it easier to review this change.

Change-Id: I5e31a661177002e40708614011c1f7e08ec4f44d

4 years agomediawiki.special.preferences: Allow linking to subsections
Bartosz Dziewoński [Fri, 15 Sep 2017 20:35:46 +0000 (22:35 +0200)]
mediawiki.special.preferences: Allow linking to subsections

The fix for T54469 allowed linking to individual fields, but not to
subsections.

The subsections have an id prefixed with 'mw-prefsection', like the
main sections, so the 'else' case was never triggered and they were
never handled. Fix the 'if' case condition to not match them.

Also, do not rely on the 'prefsection' class, which is (according to
the comment at the top of this file) only "for backwards compatibility
with older skins".

Change-Id: Ie7b4e3afbbe723a4e3b01aac95476b073a7213cd

4 years agoXml: Fix Xml::fieldset() when $content is not given
Bartosz Dziewoński [Fri, 15 Sep 2017 18:06:45 +0000 (20:06 +0200)]
Xml: Fix Xml::fieldset() when $content is not given

A function in the Xml class could generate unbalanced tags. How
ironic. Why do we even have this instead of just the Html class?

Change-Id: Ie119c92aa4936e2f8982163d4b00d08949f49264

4 years agoPreferences: Do not set non-breaking space as a label
Bartosz Dziewoński [Fri, 15 Sep 2017 22:58:55 +0000 (00:58 +0200)]
Preferences: Do not set non-breaking space as a label

If there's no label, there's just no label. No need to pretend.

Change-Id: I6b7065a23ba6532641989682d802613e0545f7e8

4 years agomediawiki.action.edit.preview: Apply mw.language.bcp47 to lang
Fomafix [Sat, 16 Sep 2017 10:31:02 +0000 (12:31 +0200)]
mediawiki.action.edit.preview: Apply mw.language.bcp47 to lang

Apply mw.language.bcp47 to the language codes before using as values
for the HTML attributes lang and hreflang.

Change-Id: I4321d32f3b3a9729650060d59450701710b8c8f2

4 years agoEditPage: Don't use $wgUser
Kunal Mehta [Fri, 15 Sep 2017 21:09:37 +0000 (14:09 -0700)]
EditPage: Don't use $wgUser

Bug: T144366
Change-Id: Ia8b7ae5ec73241478d51c57aca376e5bb50ef874

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 15 Sep 2017 19:59:13 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I584dcdcb53c62280a20242101d8b3bf3248e3e4b

4 years agoMerge "Fix a few minor mistakes in PHPDoc tags"
jenkins-bot [Fri, 15 Sep 2017 19:18:17 +0000 (19:18 +0000)]
Merge "Fix a few minor mistakes in PHPDoc tags"

4 years agoMerge "RCFilters: Only selectively scroll to popup when it's focused"
jenkins-bot [Fri, 15 Sep 2017 13:05:06 +0000 (13:05 +0000)]
Merge "RCFilters: Only selectively scroll to popup when it's focused"

4 years agoMerge "RCFilters: Allow empty saved query"
jenkins-bot [Fri, 15 Sep 2017 13:00:07 +0000 (13:00 +0000)]
Merge "RCFilters: Allow empty saved query"

4 years agoMerge "Fix $wgUpdateRowsPerJob default in docs/deferred.txt"
jenkins-bot [Fri, 15 Sep 2017 10:13:11 +0000 (10:13 +0000)]
Merge "Fix $wgUpdateRowsPerJob default in docs/deferred.txt"

4 years agoMerge "replacing "images" by "files" in listfiles-show-all for consistency"
jenkins-bot [Fri, 15 Sep 2017 09:54:47 +0000 (09:54 +0000)]
Merge "replacing "images" by "files" in listfiles-show-all for consistency"

4 years agoFix $wgUpdateRowsPerJob default in docs/deferred.txt
Thiemo Mättig [Fri, 15 Sep 2017 09:18:22 +0000 (11:18 +0200)]
Fix $wgUpdateRowsPerJob default in docs/deferred.txt

Change-Id: I0fdca6ac9d58286cf5f1ad9f55531e4643fa4fc5

4 years agoFix a few minor mistakes in PHPDoc tags
Thiemo Mättig [Fri, 15 Sep 2017 09:17:17 +0000 (11:17 +0200)]
Fix a few minor mistakes in PHPDoc tags

Change-Id: I2d5f876c9945ba21f8748562230170e3c7ea2ff2

4 years agoRCFilters: Only selectively scroll to popup when it's focused
Moriel Schottlender [Wed, 13 Sep 2017 22:29:36 +0000 (15:29 -0700)]
RCFilters: Only selectively scroll to popup when it's focused

Bug: T175697
Change-Id: Id8f42332c661cf341953eb6af43e49a422181cc8

4 years agoRCFilters: Don't cast days default to an integer
Moriel Schottlender [Thu, 14 Sep 2017 21:11:44 +0000 (14:11 -0700)]
RCFilters: Don't cast days default to an integer

Values can be floats, like 1.5 days, etc. Cast instead to a float.

Bug: T175965
Change-Id: I14ba792f1cd435f89b2e09067b0a0e894a0a2557

4 years agoRCFilters: Allow empty saved query
Moriel Schottlender [Thu, 14 Sep 2017 00:13:26 +0000 (17:13 -0700)]
RCFilters: Allow empty saved query

For this, we also need to check for saved query visibility on the
saved query model initialization, because since the model starts
its life all-empty, if the saved query is also all-empty, it will
not trigger any item updates on the main model.

Bonus: Actually check whether defaults are empty; there was a
typo and problem with the original test.

Bug: T172387
Change-Id: Ibc536b577e4c3abcc04fa229f9978b651b2f9e61

4 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Thu, 14 Sep 2017 20:04:33 +0000 (20:04 +0000)]
Merge "Localisation updates from https://translatewiki.net."

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 14 Sep 2017 20:04:16 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I64d648923f684e73152ad4ea9fe8267cda9e5d39

4 years agoApiFeedWatchlist: Fix copy-paste error
Brad Jorsch [Thu, 14 Sep 2017 19:53:22 +0000 (15:53 -0400)]
ApiFeedWatchlist: Fix copy-paste error

Change-Id: Ibea5bd881c746d7c27c97fc470ee1e3ac9d4b699

4 years agoMerge "Instruct stashed upload failures to reupload file"
jenkins-bot [Thu, 14 Sep 2017 19:46:49 +0000 (19:46 +0000)]
Merge "Instruct stashed upload failures to reupload file"

4 years agoMerge "Make chunkedUpload match upload behavior"
jenkins-bot [Thu, 14 Sep 2017 19:45:14 +0000 (19:45 +0000)]
Merge "Make chunkedUpload match upload behavior"

4 years agoResourceLoaderImageModule: Use CSSMin::buildUrlValue() where needed
Roan Kattouw [Wed, 13 Sep 2017 19:26:05 +0000 (12:26 -0700)]
ResourceLoaderImageModule: Use CSSMin::buildUrlValue() where needed

We can't just assume that the URLs that we generate are safe to use
in url() without quotes. There's already a function that automatically
uses quotes where necessary, so use that.

Change-Id: I6663e49b82592eb45b8854fcff56ac966b39f8ce