lhc/web/wiklou.git
5 years agoMerge "resources: Deprecate the 'jquery.badge' module"
jenkins-bot [Mon, 23 Oct 2017 17:43:26 +0000 (17:43 +0000)]
Merge "resources: Deprecate the 'jquery.badge' module"

5 years agoAdd missing @throws documentation to Language::factory
Thiemo Mättig [Mon, 23 Oct 2017 09:33:38 +0000 (11:33 +0200)]
Add missing @throws documentation to Language::factory

Change-Id: Id5ff9d438864e2d39a10441c43aba4188191f623

5 years agoLocalFile: Fix copy-paste error
Brad Jorsch [Mon, 23 Oct 2017 16:20:50 +0000 (12:20 -0400)]
LocalFile: Fix copy-paste error

No idea how that got through.

Change-Id: Ic7eebe624434005ff962f19eaa85cdf40e131284

5 years agoMerge "SpecialEmailUser: Don't increment pingLimiter() just for opening the page"
jenkins-bot [Mon, 23 Oct 2017 13:54:06 +0000 (13:54 +0000)]
Merge "SpecialEmailUser: Don't increment pingLimiter() just for opening the page"

5 years agoSpecialEmailUser: Don't increment pingLimiter() just for opening the page
Kunal Mehta [Fri, 6 Oct 2017 07:36:07 +0000 (00:36 -0700)]
SpecialEmailUser: Don't increment pingLimiter() just for opening the page

When checking whether the user can even send am email, don't increment
the rate limits since they haven't sent an email yet. Only increment it
once we're fairly sure that the email will actually get sent.

Bug: T177575
Change-Id: I3f832accd6259c040438ebee4c94847faa108ea6

5 years agoMerge "RCFilters: Truncate saved query menu item"
jenkins-bot [Mon, 23 Oct 2017 11:53:25 +0000 (11:53 +0000)]
Merge "RCFilters: Truncate saved query menu item"

5 years agoMerge "Fix changes list misaligned arrow"
jenkins-bot [Mon, 23 Oct 2017 11:24:37 +0000 (11:24 +0000)]
Merge "Fix changes list misaligned arrow"

5 years agoMerge "Remove @codingStandardsIgnore from long lines"
jenkins-bot [Mon, 23 Oct 2017 02:07:48 +0000 (02:07 +0000)]
Merge "Remove @codingStandardsIgnore from long lines"

5 years agoMerge "Remove @codingStandardsIgnore after upstream fix"
jenkins-bot [Mon, 23 Oct 2017 02:06:31 +0000 (02:06 +0000)]
Merge "Remove @codingStandardsIgnore after upstream fix"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 22 Oct 2017 19:54:23 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I639918d677a9ca7cfe9115fa0223c1abbf1884c8

5 years agoRemove @codingStandardsIgnore from long lines
Umherirrender [Sun, 22 Oct 2017 14:44:04 +0000 (16:44 +0200)]
Remove @codingStandardsIgnore from long lines

Breaks some line where the ignore is not needed.

The sniff was changed upstream to be okay
with long unbreakable lines in comments

Change-Id: I2bbe2be7cedd4d3c0ce8dc3e62d0e268bc171876

5 years agoRemove @codingStandardsIgnore after upstream fix
Umherirrender [Sun, 22 Oct 2017 14:25:00 +0000 (16:25 +0200)]
Remove @codingStandardsIgnore after upstream fix

Issue #1604 was fixed -
https://github.com/squizlabs/PHP_CodeSniffer/issues/1604

Change-Id: Id81cb820e42123007ae8696422bebf588e274437

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 21 Oct 2017 22:09:46 +0000 (00:09 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I8e1401909269c4d0375ad61c77cc29993f02a2ce

5 years agoMerge "Use LogFormatter::getLinkRenderer in LogFormatter extensions"
jenkins-bot [Sat, 21 Oct 2017 17:13:44 +0000 (17:13 +0000)]
Merge "Use LogFormatter::getLinkRenderer in LogFormatter extensions"

5 years agobuild: Updating mediawiki/mediawiki-codesniffer to 14.1.0
Paladox [Sat, 21 Oct 2017 02:18:40 +0000 (02:18 +0000)]
build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: Idaa1fe006a528c25ce34abd0a857c657c26e8b0f

5 years agoMerge "Switch DifferenceEngine to the new shell framework"
jenkins-bot [Sat, 21 Oct 2017 00:23:47 +0000 (00:23 +0000)]
Merge "Switch DifferenceEngine to the new shell framework"

5 years agoMerge "Check minimum database server version when running update.php"
jenkins-bot [Fri, 20 Oct 2017 23:57:51 +0000 (23:57 +0000)]
Merge "Check minimum database server version when running update.php"

5 years agoresources: Deprecate the 'jquery.badge' module
James D. Forrester [Fri, 20 Oct 2017 23:31:18 +0000 (16:31 -0700)]
resources: Deprecate the 'jquery.badge' module

Only used in the PageTriage extension, which can provide it itself:

https://github.com/search?utf8=%E2%9C%93&q=%22jquery.badge%22+%40wikimedia+-repo%3Awikimedia%2Fjquery.badge+-repo%3Awikimedia%2Fmediawiki-debian&type=Code

Bug: T178450
Change-Id: Ibe4ff6a1f39fc554dcf4fc20cc214521d854f1ec

5 years agoSwitch DifferenceEngine to the new shell framework
Max Semenik [Tue, 17 Oct 2017 06:53:50 +0000 (23:53 -0700)]
Switch DifferenceEngine to the new shell framework

Change-Id: Iad8718e5f54ed829efded8efbb0f3496c119e6ad

5 years agoMerge "Hard deprecate Title::escapeFragmentForURL()"
jenkins-bot [Fri, 20 Oct 2017 22:12:56 +0000 (22:12 +0000)]
Merge "Hard deprecate Title::escapeFragmentForURL()"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 20 Oct 2017 19:57:30 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I40093d586318b7bceddbe982bb0c71dfeb76dc79

5 years agoMerge "objectcache: Split off some code in WANObjectCache::getWithSetCallback"
jenkins-bot [Fri, 20 Oct 2017 17:18:39 +0000 (17:18 +0000)]
Merge "objectcache: Split off some code in WANObjectCache::getWithSetCallback"

5 years agoobjectcache: Split off some code in WANObjectCache::getWithSetCallback
Aaron Schulz [Thu, 19 Oct 2017 04:00:29 +0000 (21:00 -0700)]
objectcache: Split off some code in WANObjectCache::getWithSetCallback

This makes it a bit easier to follow

Change-Id: I67968814ab046473eb8eca4086a8600c77417b82

5 years agoMerge "Set getDeduplicationInfo() for HTMLCacheUpdateJob"
jenkins-bot [Fri, 20 Oct 2017 05:56:19 +0000 (05:56 +0000)]
Merge "Set getDeduplicationInfo() for HTMLCacheUpdateJob"

5 years agoSet getDeduplicationInfo() for HTMLCacheUpdateJob
Aaron Schulz [Thu, 19 Oct 2017 19:39:56 +0000 (12:39 -0700)]
Set getDeduplicationInfo() for HTMLCacheUpdateJob

This allows de-duplication of single page jobs for the
same page due to edits to different templates. This is
the same logic that RefreshLinksJob already has.

Also fix a bug in that method in RefreshLinksJob.

Change-Id: I2f79031c945eb3d195f9dbda949077bbc3e67918

5 years agoMerge "objectcache: Mention colons in BagOStuff key generation"
jenkins-bot [Fri, 20 Oct 2017 03:32:02 +0000 (03:32 +0000)]
Merge "objectcache: Mention colons in BagOStuff key generation"

5 years agoobjectcache: Mention colons in BagOStuff key generation
Aaron Schulz [Wed, 18 Oct 2017 21:25:23 +0000 (14:25 -0700)]
objectcache: Mention colons in BagOStuff key generation

Change-Id: I76967245c32aac4eea8d6672e4fc1fac5e5f3d07

5 years agoMerge "Shell\Command: Move code that builds final shell command into separate method"
jenkins-bot [Fri, 20 Oct 2017 03:08:54 +0000 (03:08 +0000)]
Merge "Shell\Command: Move code that builds final shell command into separate method"

5 years agoShell\Command: Move code that builds final shell command into separate method
Kunal Mehta [Wed, 18 Oct 2017 04:49:46 +0000 (21:49 -0700)]
Shell\Command: Move code that builds final shell command into separate method

Change-Id: I6aae209fd0b20057b5f7f7129db92c184ec945f8

5 years agoMerge "RCFilters: Actually toggle the collapsed class for toplinks"
jenkins-bot [Thu, 19 Oct 2017 23:11:58 +0000 (23:11 +0000)]
Merge "RCFilters: Actually toggle the collapsed class for toplinks"

5 years agoRCFilters: Actually toggle the collapsed class for toplinks
Moriel Schottlender [Thu, 19 Oct 2017 18:58:16 +0000 (11:58 -0700)]
RCFilters: Actually toggle the collapsed class for toplinks

Bug: T178396
Change-Id: I2206816540342012296669f8dd24ab44762f4788

5 years agoFix changes list misaligned arrow
petarpetkovic [Thu, 19 Oct 2017 20:54:45 +0000 (22:54 +0200)]
Fix changes list misaligned arrow

- Revert td alignment from middle to top.
- Add top padding to fix misalignment.

Bug: T178595
Change-Id: I1211b7afe1c29b0a33c051c07921eed7eb9704e3

5 years agoRCFilters: Truncate saved query menu item
Moriel Schottlender [Thu, 19 Oct 2017 19:08:27 +0000 (12:08 -0700)]
RCFilters: Truncate saved query menu item

Bug: T178610
Change-Id: I787237beb2f08a01bd9c6885c75401bacfcc6f9b

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 19 Oct 2017 20:02:48 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If6a368d96b689c022f5a0f4b835628ddef0a2b41

5 years agoMerge "RCFilters: refactor highlight state"
jenkins-bot [Thu, 19 Oct 2017 19:39:04 +0000 (19:39 +0000)]
Merge "RCFilters: refactor highlight state"

5 years agoRCFilters: refactor highlight state
Stephane Bisson [Thu, 5 Oct 2017 20:10:42 +0000 (16:10 -0400)]
RCFilters: refactor highlight state

* Consider highlight to be enabled when applying
  parameters that contain highlight colors.

* Don't store 'highlight=0|1' in the URL or
  saved query.

Bug: T177009
Change-Id: I8f3a1c609cef89bc08077776d453ced6f2d0f5e2

5 years agoMerge "resourceloader: Introduce metric for backend response timing"
jenkins-bot [Thu, 19 Oct 2017 17:17:12 +0000 (17:17 +0000)]
Merge "resourceloader: Introduce metric for backend response timing"

5 years agoMerge "jquery.badge: Align with Echo notifications style and WikimediaUI palette"
jenkins-bot [Wed, 18 Oct 2017 23:19:31 +0000 (23:19 +0000)]
Merge "jquery.badge: Align with Echo notifications style and WikimediaUI palette"

5 years agoMerge "Make $wgExperimentalHtmlIds fall back on modern HTML5 mode"
jenkins-bot [Wed, 18 Oct 2017 22:06:06 +0000 (22:06 +0000)]
Merge "Make $wgExperimentalHtmlIds fall back on modern HTML5 mode"

5 years agomediawiki.ui: Remove remainder `text-shadow`
Volker E [Wed, 18 Oct 2017 20:45:11 +0000 (13:45 -0700)]
mediawiki.ui: Remove remainder `text-shadow`

The `text-shadow` property on primary buttons was probably introduced
for a fake 3D effect and also because the colors were lighter in
order to set the white text apart. None of this is true with our
WikimediaUI color palette any more so let's remove this remainder.

Change-Id: I25e5ce7e6fafc19d8b925b6918c98dd61b423d64

5 years agoMerge "RCFilters: rephrase newcomers description"
jenkins-bot [Wed, 18 Oct 2017 20:04:58 +0000 (20:04 +0000)]
Merge "RCFilters: rephrase newcomers description"

5 years agoMerge "RCFilters: define consistent interface in ChangesListFilterGroup"
jenkins-bot [Wed, 18 Oct 2017 20:04:55 +0000 (20:04 +0000)]
Merge "RCFilters: define consistent interface in ChangesListFilterGroup"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 18 Oct 2017 19:55:10 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic1284de8147baa9a8436621bc2e3d1de4037a920

5 years agoRCFilters: define consistent interface in ChangesListFilterGroup
Stephane Bisson [Wed, 18 Oct 2017 10:28:43 +0000 (06:28 -0400)]
RCFilters: define consistent interface in ChangesListFilterGroup

Get rid of isPerGroupRequestParameter and define a consistent
interface that all filter groups can implement.

Change-Id: Ib904bcdc697c65722a0041ac611d1e00c577389f

5 years agoMerge "jQuery: Remove jQuery 1 legacy option"
jenkins-bot [Wed, 18 Oct 2017 19:32:35 +0000 (19:32 +0000)]
Merge "jQuery: Remove jQuery 1 legacy option"

5 years agoMerge "Revision tests, make test for constructFromRowArray a unit test"
jenkins-bot [Wed, 18 Oct 2017 18:06:45 +0000 (18:06 +0000)]
Merge "Revision tests, make test for constructFromRowArray a unit test"

5 years agoMerge "RevisionIntegrationTest more newFromArchiveRow tests"
jenkins-bot [Wed, 18 Oct 2017 18:06:42 +0000 (18:06 +0000)]
Merge "RevisionIntegrationTest more newFromArchiveRow tests"

5 years agoMerge "RevisionUnitTest::testConstructFromArray @covers tags"
jenkins-bot [Wed, 18 Oct 2017 18:06:38 +0000 (18:06 +0000)]
Merge "RevisionUnitTest::testConstructFromArray @covers tags"

5 years agoMerge "Update the translation for MessagesKo.php"
jenkins-bot [Wed, 18 Oct 2017 17:14:02 +0000 (17:14 +0000)]
Merge "Update the translation for MessagesKo.php"

5 years agoRCFilters: fix stylelint error
Stephane Bisson [Wed, 18 Oct 2017 15:15:57 +0000 (11:15 -0400)]
RCFilters: fix stylelint error

Not sure how this got merged but it's reported as an error
locally.

Change-Id: I7cd1a9442ea07cf6e4595ff4a3611a0b682a4e6e

5 years agoMerge "Fix missingcommenttext message to be more useful in different page layouts"
jenkins-bot [Wed, 18 Oct 2017 14:24:26 +0000 (14:24 +0000)]
Merge "Fix missingcommenttext message to be more useful in different page layouts"

5 years agoFix missingcommenttext message to be more useful in different page layouts
Deskana [Wed, 18 Oct 2017 14:11:58 +0000 (15:11 +0100)]
Fix missingcommenttext message to be more useful in different page layouts

This missingcommenttext message makes reference to a specific page layout,
which it shouldn't given the UI can be skinned in a variety of different
ways. This patch removes the specific reference to "below", which wasn't
particularly helpful anyway.

Bug: T158262
Change-Id: Ieb81db162bee6010e85b17355059e18ad447751e

5 years agoRCFilters: rephrase newcomers description
Stephane Bisson [Wed, 18 Oct 2017 12:27:29 +0000 (08:27 -0400)]
RCFilters: rephrase newcomers description

Bug: T178334
Change-Id: I76a805acae4b7c6efa3707fa6c203e72c2e29ea2

5 years agoReplace deprecated edit review params
petarpetkovic [Tue, 17 Oct 2017 13:22:46 +0000 (15:22 +0200)]
Replace deprecated edit review params

- Replace old options 'hideanons' or 'hideliu' with structured UI equivalent.
- Update tests to take this new behavior into account.

Bug: T176172
Change-Id: I6ad050f7864bf51db05c3db957ac3533358cd3ac

5 years agoMerge "Database: Support parenthesized JOINs"
jenkins-bot [Wed, 18 Oct 2017 08:30:02 +0000 (08:30 +0000)]
Merge "Database: Support parenthesized JOINs"

5 years agoMerge "Replace more uses of "SELECT *""
jenkins-bot [Wed, 18 Oct 2017 06:34:46 +0000 (06:34 +0000)]
Merge "Replace more uses of "SELECT *""

5 years agoHard deprecate Title::escapeFragmentForURL()
Max Semenik [Wed, 18 Oct 2017 06:29:15 +0000 (23:29 -0700)]
Hard deprecate Title::escapeFragmentForURL()

No usages in core and only one outside of core, being
fixed in If1191817ee2db84d8fd3b91aa13e6257faf10a41.

Change-Id: I91ca289e989a4dc32de083b9cc002c9c9d75a3e1

5 years agojquery.badge: Align with Echo notifications style and WikimediaUI palette
Volker E [Wed, 18 Oct 2017 05:10:15 +0000 (22:10 -0700)]
jquery.badge: Align with Echo notifications style and WikimediaUI palette

Aligning badge style to Echo notifications, ensuring WCAG level AA conformance
and also to WikimediaUI color palette.

Bug: T152025
Change-Id: I279a607f3c1b13ea6e21e59df0c6d21e525f587e

5 years agoIntroduce Shell\CommandFactory
Max Semenik [Sat, 7 Oct 2017 02:26:52 +0000 (19:26 -0700)]
Introduce Shell\CommandFactory

Bug: T177038
Change-Id: Id875e68ea1fa72b44a463f977ab52270fe1e7088

5 years agoDon't trigger PHP errors for unused Shell\Command
Max Semenik [Wed, 18 Oct 2017 01:54:17 +0000 (18:54 -0700)]
Don't trigger PHP errors for unused Shell\Command

Change-Id: Id29da4f21a44ccb18d8a2ae11348d69ca3233aa5

5 years agoCommand: Avoid using wfDebug()
Kunal Mehta [Wed, 18 Oct 2017 01:22:42 +0000 (18:22 -0700)]
Command: Avoid using wfDebug()

Change-Id: I92ea55d7a5b6a71a6f6b944f377215c08ea3b096

5 years agoUpdate OOjs UI to v0.24.0
Volker E [Wed, 18 Oct 2017 00:13:34 +0000 (17:13 -0700)]
Update OOjs UI to v0.24.0

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.0

Depends-on: Iad57bf4f6306086cb775629f2d9f2fcf2dbcf5fd
Change-Id: Idf2bed0a1719f8a30bcc66211cbeedd2bb31ec4b

5 years agoMerge "Add a few schemas to SQLite tests"
jenkins-bot [Tue, 17 Oct 2017 22:37:31 +0000 (22:37 +0000)]
Merge "Add a few schemas to SQLite tests"

5 years agoRevision tests, make test for constructFromRowArray a unit test
addshore [Tue, 17 Oct 2017 12:09:08 +0000 (13:09 +0100)]
Revision tests, make test for constructFromRowArray a unit test

Change-Id: I52aa62a442011b612966bb294015730a05702cd3

5 years agoRevisionIntegrationTest more newFromArchiveRow tests
addshore [Tue, 17 Oct 2017 11:35:28 +0000 (12:35 +0100)]
RevisionIntegrationTest more newFromArchiveRow tests

There were a couple of code paths that were not tested before
for different combinations of selected fields, these are now
covered.

Change-Id: Ifd438e5c97a5f32a1744c58bd4cf0303ddb32cfc

5 years agoRevisionUnitTest::testConstructFromArray @covers tags
addshore [Tue, 17 Oct 2017 11:10:19 +0000 (12:10 +0100)]
RevisionUnitTest::testConstructFromArray @covers tags

Change-Id: I3d4b54531ecdb2c29f4669685d9824b6a5e36e4e

5 years agoMerge "Fix login button label to accept RawMessage."
jenkins-bot [Tue, 17 Oct 2017 22:06:25 +0000 (22:06 +0000)]
Merge "Fix login button label to accept RawMessage."

5 years agojQuery: Remove jQuery 1 legacy option
James D. Forrester [Thu, 5 Oct 2017 18:25:51 +0000 (11:25 -0700)]
jQuery: Remove jQuery 1 legacy option

Deprecated since MediaWiki 1.29, no longer used in Wikimedia production.

Bug: T124742
Change-Id: Id2a94e9fa7dd8b6951d735c1d31d20498fe11a3a

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 17 Oct 2017 20:08:59 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I46a1a40150d9eda7a34d2a02e17f0aef1bf6d9a7

5 years agoMerge "RCFilters: Move parameter operations to ViewModel"
jenkins-bot [Tue, 17 Oct 2017 19:22:57 +0000 (19:22 +0000)]
Merge "RCFilters: Move parameter operations to ViewModel"

5 years agoMerge "RCFilters: Don't let new params filter out old page"
jenkins-bot [Tue, 17 Oct 2017 19:03:06 +0000 (19:03 +0000)]
Merge "RCFilters: Don't let new params filter out old page"

5 years agoFix login button label to accept RawMessage.
Cicalese [Tue, 17 Oct 2017 17:58:28 +0000 (17:58 +0000)]
Fix login button label to accept RawMessage.

The label is already a Message at this point. For Messages that
are not RawMessages, the call to wfMessage() does not do any harm.
However, for RawMessages, it causes the label to appear in <>.
Removing the call to wfMessage() does not harm regular Messages
and fixes the problem for RawMessages.

Change-Id: I943628e2a1fbf6fff579dd52c1058ca2ef125d34

5 years agoUpdate the translation for MessagesKo.php
Yongmin Hong [Tue, 11 Jul 2017 01:57:08 +0000 (10:57 +0900)]
Update the translation for MessagesKo.php

* Reversed the order for unlockdb, createprotect
* Added a new translation text for __NEWSECTIONLINK__ and
__NONEWSECTIONLINK__, which translation I added is used by kowiki
and more accurate to the original meaning.
* Fixed link for aladdin.co.kr. which has changed their domain since
then and currently using aladin.co.kr. Sticking with http since they
have no plan to move to HTTPS by default.

Change-Id: Ia30b256b23aa70f46ff37439b6b74d4bb25cdf66

5 years agoMerge "Remove mention of IE9 support"
jenkins-bot [Tue, 17 Oct 2017 14:09:23 +0000 (14:09 +0000)]
Merge "Remove mention of IE9 support"

5 years agoMerge "Add primary keys to site_stats"
jenkins-bot [Tue, 17 Oct 2017 14:01:11 +0000 (14:01 +0000)]
Merge "Add primary keys to site_stats"

5 years agoUpdating native language name for Northern Sami
jhsoby [Tue, 17 Oct 2017 12:51:38 +0000 (14:51 +0200)]
Updating native language name for Northern Sami

Bug: T156589
Change-Id: Iec69f8654d6eabb7b644726fd63f00edb01dc1e9

5 years agoAdd primary keys to site_stats
Eddie Greiner-Petter [Sat, 15 Jul 2017 20:57:06 +0000 (22:57 +0200)]
Add primary keys to site_stats

As discussed in I7d42aae434852a56b6f8dd559d8a5f3bce416021 primary keys
are needed to perform various schema changes on  the site_stats table.
This patch aims to introduce primary keys for all supported dbms.

The respective *.sql patch files were tested locally against Postgres
and SQL Server 2016. Please note that neither the patch file for Oracle
DB nor the mediawiki upgrade through update.php was tested.

Bug: T56888
Change-Id: Id10e221f0dc120bc09afc22596fd1dbecbf6a61d

5 years agoMerge "Add option to hide missing pages while searching"
jenkins-bot [Tue, 17 Oct 2017 11:33:18 +0000 (11:33 +0000)]
Merge "Add option to hide missing pages while searching"

5 years agoRemove mention of IE9 support
Ed Sanders [Tue, 17 Oct 2017 11:27:22 +0000 (12:27 +0100)]
Remove mention of IE9 support

Change-Id: I68a31292efa501b83ca9d5ebfbaa5e2c46120d34

5 years agoMerge "Align diff context colors to WikimediaUI color palette"
jenkins-bot [Tue, 17 Oct 2017 10:55:52 +0000 (10:55 +0000)]
Merge "Align diff context colors to WikimediaUI color palette"

5 years agoMerge "Convert GitInfo to the new shell framework"
jenkins-bot [Tue, 17 Oct 2017 03:51:42 +0000 (03:51 +0000)]
Merge "Convert GitInfo to the new shell framework"

5 years agoMerge "Shell\Command: Better walltime fallback"
jenkins-bot [Tue, 17 Oct 2017 03:51:38 +0000 (03:51 +0000)]
Merge "Shell\Command: Better walltime fallback"

5 years agoConvert GitInfo to the new shell framework
Max Semenik [Tue, 17 Oct 2017 03:29:58 +0000 (20:29 -0700)]
Convert GitInfo to the new shell framework

Change-Id: I2fdebe8748708412c59a9de4028cc2e280c8d0c8

5 years agoShell\Command: Better walltime fallback
Max Semenik [Mon, 16 Oct 2017 22:30:49 +0000 (15:30 -0700)]
Shell\Command: Better walltime fallback

Previously, it assumed that the only way times could be overridden is to
reduce the limits - which isn't the case for video transcoding.

Bug: T178314
Change-Id: I492a44f280a36ee666e9963788caac2bbc6bc6f3

5 years agoresourceloader: Introduce metric for backend response timing
Timo Tijhof [Tue, 17 Oct 2017 01:48:54 +0000 (02:48 +0100)]
resourceloader: Introduce metric for backend response timing

We currently have several counts and timings of individual pieces
of ResourceLoader backend logic (minification, module building, ..)
but no measure of the response overall.

This responseTime metric will effectively provide both a timing
measure as well as a backend request count.

Bug: T178350
Change-Id: I625a5eb90f5a4ea90aebf9292dfda0f1c5ae4f2e

5 years agoRevisionUnitTest for fetchFromConds
addshore [Sat, 14 Oct 2017 16:27:42 +0000 (17:27 +0100)]
RevisionUnitTest for fetchFromConds

Change-Id: Ie151123d703933474a52c73beacb0ac70161c241

5 years agoRevisionUnitTest for various getters and setters
addshore [Sat, 14 Oct 2017 13:07:22 +0000 (14:07 +0100)]
RevisionUnitTest for various getters and setters

getId
setId
setUserIdAndName
getTextId
getParentId

Change-Id: I1890122c0eae16947a4782bc14baa8c3b9ce1391

5 years agoRevisionUnittest for select*Fields methods
addshore [Sat, 14 Oct 2017 12:35:05 +0000 (13:35 +0100)]
RevisionUnittest for select*Fields methods

Change-Id: I8ec1d35bb5e4706e5cfe72684bcac73c9f3d63cc

5 years agoRevisionUnitTest for userJoinCond and pageJoinCond
addshore [Sat, 14 Oct 2017 10:43:58 +0000 (11:43 +0100)]
RevisionUnitTest for userJoinCond and pageJoinCond

Change-Id: I4deb6192e56c6b6eb9c60d0ae3cd3aa472a84af6

5 years agoRevisionIntegrationTest for loadFromTimestamp
addshore [Sat, 14 Oct 2017 10:40:56 +0000 (11:40 +0100)]
RevisionIntegrationTest for loadFromTimestamp

Change-Id: I65f4f7b44c476baaaaa9e185c7d506573b22b080

5 years agoRevisionIntegrationTest for loadFromTitle
addshore [Sat, 14 Oct 2017 10:38:38 +0000 (11:38 +0100)]
RevisionIntegrationTest for loadFromTitle

Change-Id: I963dcd20cd01e99de3b1a22de43f9e2892abe9cc

5 years agoRevisionIntegrationTest for loadFromId & loadFromPageId
addshore [Sat, 14 Oct 2017 10:35:11 +0000 (11:35 +0100)]
RevisionIntegrationTest for loadFromId & loadFromPageId

Change-Id: I31431267d761b5d97d7e298c3451341358d54bba

5 years agoRevisionIntegrationTest for newFromArchiveRow with ContentHandlerUseDB
addshore [Sat, 14 Oct 2017 10:25:28 +0000 (11:25 +0100)]
RevisionIntegrationTest for newFromArchiveRow with ContentHandlerUseDB

Change-Id: I6edea4f1de69f5df33f6389f9d7a5be2717c0bb2

5 years agoRevisionIntegrationTest for newFromPageId
addshore [Sat, 14 Oct 2017 10:17:39 +0000 (11:17 +0100)]
RevisionIntegrationTest for newFromPageId

Change-Id: I09cf5fcbacab662e30acda1687ebcfe6b29f1900

5 years agoMerge "Cleanup page creation in RevisionIntegrationTest"
jenkins-bot [Tue, 17 Oct 2017 00:50:43 +0000 (00:50 +0000)]
Merge "Cleanup page creation in RevisionIntegrationTest"

5 years agoMerge "Split Revision tests into Unit & Integration classes"
jenkins-bot [Tue, 17 Oct 2017 00:48:50 +0000 (00:48 +0000)]
Merge "Split Revision tests into Unit & Integration classes"

5 years agoRCFilters: Move parameter operations to ViewModel
Moriel Schottlender [Tue, 3 Oct 2017 23:17:30 +0000 (16:17 -0700)]
RCFilters: Move parameter operations to ViewModel

Refactor the operation of the model to work with parameters. Since we
work with parameters, there's no need to display and store the entire
state but rather only the active parameters -- which is the same operation
that the URL is displaying.

* Make sure that all controllers (Controller and UriProcessor) adhere to
  FiltersModel operation of minimization.
* Allow the FiltersViewModel to accept a parameter state to update itself.
* Simplify the operation of getting defaults and checking whether defaults
  are empty.
* Make sure that the storage construct (split to params/highlights) does
  not leak out of the saved queries model, the only place where it is
  relevant.
* Add unit tests and correct existing unit tests.

Change-Id: Icec513c94630314e7873f9ffe27779cd39150713

5 years agoHard deprecate wfRunHooks()
Max Semenik [Sat, 9 Sep 2017 01:28:05 +0000 (18:28 -0700)]
Hard deprecate wfRunHooks()

Deprecated since 1.25, very few callers. Having to grep for 2
ways of calling a hook is harmful not only because it wastes developers'
time, but also because it makes it possible to forget to search for the
old way, resulting in mistakes. Better get rid of this.

Change-Id: Iab28bd5758475b780c2016847881757d64973862

5 years agoMerge "Fix tabindex applied twice on RC top section"
jenkins-bot [Mon, 16 Oct 2017 22:06:59 +0000 (22:06 +0000)]
Merge "Fix tabindex applied twice on RC top section"

5 years agoMerge "Fix changes list misaligned arrow"
jenkins-bot [Mon, 16 Oct 2017 20:25:50 +0000 (20:25 +0000)]
Merge "Fix changes list misaligned arrow"