lhc/web/wiklou.git
7 years agoMerge "Reduce WikiPage::getContentModel() queries via caching"
jenkins-bot [Wed, 14 Sep 2016 19:18:32 +0000 (19:18 +0000)]
Merge "Reduce WikiPage::getContentModel() queries via caching"

7 years agoMerge "Add caching to Title::loadRestrictions()"
jenkins-bot [Wed, 14 Sep 2016 19:14:40 +0000 (19:14 +0000)]
Merge "Add caching to Title::loadRestrictions()"

7 years agoParserOptions: Remove setters for magic links options
Kunal Mehta [Wed, 14 Sep 2016 18:12:14 +0000 (11:12 -0700)]
ParserOptions: Remove setters for magic links options

This will allow clients to assume that the global configuration state
($wgEnableMagicLinks) is the same as the state in ParserOptions, fixing
some consistency issues in wfEscapeWikiText() and Scribunto. The
abstraction for the ParserOptions getters is still useful because it
keeps the global state out of the Parser.

Change-Id: Ic2c447443963eb336c786cacf9dfd041a2df3b77

7 years agoMerge "API: Deprecate use of ApiPurge via GET"
jenkins-bot [Wed, 14 Sep 2016 16:36:59 +0000 (16:36 +0000)]
Merge "API: Deprecate use of ApiPurge via GET"

7 years agoMerge "API: Expose $wgEnableMagicLinks in meta=siteinfo"
jenkins-bot [Wed, 14 Sep 2016 15:58:36 +0000 (15:58 +0000)]
Merge "API: Expose $wgEnableMagicLinks in meta=siteinfo"

7 years agoMerge "Fix login API for users with @ in their usernames"
jenkins-bot [Wed, 14 Sep 2016 15:33:07 +0000 (15:33 +0000)]
Merge "Fix login API for users with @ in their usernames"

7 years agoAPI: Deprecate use of ApiPurge via GET
Brad Jorsch [Wed, 14 Sep 2016 15:04:33 +0000 (11:04 -0400)]
API: Deprecate use of ApiPurge via GET

This emits a warning and logs feature usage, and also pretends that POST
is required in the help and paraminfo output.

Bug: T145649
Change-Id: Ied8d47a947662158fddab383c764bf70c5ab0112

7 years agoMerge "Move LoadMonitor classes to libs/rdbms/loadmonitor"
jenkins-bot [Wed, 14 Sep 2016 11:08:17 +0000 (11:08 +0000)]
Merge "Move LoadMonitor classes to libs/rdbms/loadmonitor"

7 years agoMove LoadMonitor classes to libs/rdbms/loadmonitor
Aaron Schulz [Wed, 14 Sep 2016 07:10:11 +0000 (00:10 -0700)]
Move LoadMonitor classes to libs/rdbms/loadmonitor

Change-Id: Ib18108f24ff8b9d05dc324bad132f597b3e2ddef

7 years agoMerge "Replace some MWExceptions with natives ones in /db"
jenkins-bot [Wed, 14 Sep 2016 10:43:40 +0000 (10:43 +0000)]
Merge "Replace some MWExceptions with natives ones in /db"

7 years agoMerge "Special:ChangeContentModel: Run EditFilterMergedContent hook"
jenkins-bot [Wed, 14 Sep 2016 10:39:43 +0000 (10:39 +0000)]
Merge "Special:ChangeContentModel: Run EditFilterMergedContent hook"

7 years agoReduce CategoryMembershipChangeJob lock timeout
Aaron Schulz [Wed, 14 Sep 2016 10:21:53 +0000 (03:21 -0700)]
Reduce CategoryMembershipChangeJob lock timeout

Bug: T133801
Change-Id: Ic5db3983a8b67b9138b602188a52d60dd95fcb59

7 years agoReplace some MWExceptions with natives ones in /db
Aaron Schulz [Wed, 14 Sep 2016 02:38:19 +0000 (19:38 -0700)]
Replace some MWExceptions with natives ones in /db

Change-Id: I94532d09216926d401e94c61acd60fdc6241a2a0

7 years agoMerge "refreshLinks: Add --namespace option"
jenkins-bot [Wed, 14 Sep 2016 08:41:04 +0000 (08:41 +0000)]
Merge "refreshLinks: Add --namespace option"

7 years agorefreshLinks: Add --namespace option
Kunal Mehta [Tue, 13 Sep 2016 01:13:45 +0000 (18:13 -0700)]
refreshLinks: Add --namespace option

This allows limiting refreshing data to pages in a single namespace.

Change-Id: I309058df98b638beb32adb1d663455a0c4aa1cec

7 years agoSet cpPosTime cookie for the non-redirect case as well
Aaron Schulz [Wed, 14 Sep 2016 06:52:05 +0000 (23:52 -0700)]
Set cpPosTime cookie for the non-redirect case as well

This is useful if the ChronologyProtector store cannot sync
among datacenters and waitForReplication() is DC-local.
It only applies if the user stays on the domain, however.

Change-Id: I800cade7b87a0f02d6a429e70924c54189a4a7af

7 years agoUse cpPosTime cookie for same-domain redirects on DB change
Aaron Schulz [Wed, 14 Sep 2016 05:49:10 +0000 (22:49 -0700)]
Use cpPosTime cookie for same-domain redirects on DB change

This follows-up a3dacac90f to show the URL parameter in less cases.

Change-Id: Ibe015352962fb3ee14d5aa322f0e748ef4cba5c1

7 years agoAdd ILoadBalancer interface
Aaron Schulz [Wed, 14 Sep 2016 01:18:37 +0000 (18:18 -0700)]
Add ILoadBalancer interface

Remove redundant LoadBalancer docs (those without @since).

Change-Id: I981177b6854cfdbea4a51b6db7e365dac0da258a

7 years agoMerge "Convert LoadBalancer/Database class logging to PSR"
jenkins-bot [Wed, 14 Sep 2016 02:34:10 +0000 (02:34 +0000)]
Merge "Convert LoadBalancer/Database class logging to PSR"

7 years agoConvert LoadBalancer/Database class logging to PSR
Aaron Schulz [Mon, 12 Sep 2016 22:10:16 +0000 (15:10 -0700)]
Convert LoadBalancer/Database class logging to PSR

Reorder DatabaseBase constructor/factory to the top.

Change-Id: I2ffff950b9170d6ff15dcd46b64dd366f1e441a8

7 years agoMerge "Partially reverting I8e684f06 to restore some legacy behavior"
jenkins-bot [Wed, 14 Sep 2016 01:48:39 +0000 (01:48 +0000)]
Merge "Partially reverting I8e684f06 to restore some legacy behavior"

7 years agoFix login API for users with @ in their usernames
Gergő Tisza [Tue, 13 Sep 2016 23:25:49 +0000 (23:25 +0000)]
Fix login API for users with @ in their usernames

An @ in the username caused the password to be treated as a bot password,
but apparently some real usernames still contain it. Try both logins
instead. Security considerations are the same as for the other bot
password syntax: the length check makes sure we do not provide any
information on a timing side channel about the password unless it is
extremely long.

Change-Id: I58f42544a08c3208c41f54cfae932632d9c5affa

7 years agoMerge "Move PECL memcached class to /libs"
jenkins-bot [Wed, 14 Sep 2016 01:45:02 +0000 (01:45 +0000)]
Merge "Move PECL memcached class to /libs"

7 years agoPartially reverting I8e684f06 to restore some legacy behavior
Kaldari [Wed, 14 Sep 2016 01:24:55 +0000 (18:24 -0700)]
Partially reverting I8e684f06 to restore some legacy behavior

Apparently some calls to getDateCond() expect it to not set an offset.
Also, removing some of the new tests that no longer work since they
don't pass all the required parameters. (Before I8e684f06, the year
and month were both required parameters.)

Bug: T145597
Change-Id: I3a90b3da48e49ec9723b7100a7d92146154f74e3

7 years agoMerge "Various dependency injection cleanups to LoadBalancer"
jenkins-bot [Wed, 14 Sep 2016 01:05:58 +0000 (01:05 +0000)]
Merge "Various dependency injection cleanups to LoadBalancer"

7 years agoParserTests: Make sure WikiPage::doEditContent() succeeds
Kunal Mehta [Wed, 14 Sep 2016 00:22:44 +0000 (17:22 -0700)]
ParserTests: Make sure WikiPage::doEditContent() succeeds

If a parser test tries to create a page with invalid content (rejected
by Content::prepareSave() or Content::isValid()), throw an exception
instead of silently failing.

Change-Id: I89642604216699f27884120b3c297a0b277c47a6

7 years agoMerge "Make sure emails from RecentChange::save() are for comitted rows"
jenkins-bot [Wed, 14 Sep 2016 00:22:15 +0000 (00:22 +0000)]
Merge "Make sure emails from RecentChange::save() are for comitted rows"

7 years agoSpecial:ChangeContentModel: Run EditFilterMergedContent hook
Kunal Mehta [Tue, 13 Sep 2016 08:10:35 +0000 (01:10 -0700)]
Special:ChangeContentModel: Run EditFilterMergedContent hook

This will allow tools like AbuseFilter to filter changes made through
the special page, and matches the EditPage behavior that already runs
this hook.

Bug: T145489
Change-Id: I3204e3a228af2cdd4e2ab4e8c760cc126a8e1947

7 years agoVarious dependency injection cleanups to LoadBalancer
Aaron Schulz [Sun, 11 Sep 2016 21:57:09 +0000 (14:57 -0700)]
Various dependency injection cleanups to LoadBalancer

* Inject wfWikiID() and MWExceptionHandler into LoadBalancer.
* Factor out LBFactory duplication into baseLoadBalancerParams().
* Remove $wgDBtype hack. Presumably, sites with others DBs would
  not have multiple servers configured if does not work anyway.
* Make use of injected TransactionProfiler rather than calling
  Profiler::instance()->getTransactionProfiler().
* Avoid use of trivial wfSplitWikiID() function.
* Make DBConnRef enforce its arguments more strongly and
  optimize getWiki() to avoid causing a connection attempt.
* Avoid deprecated method call in LBFactory::destroyInstance().

Change-Id: If134b62d4f48cd68cb48ccbe149e72f12aa26819

7 years agoAPI: Expose $wgEnableMagicLinks in meta=siteinfo
Kunal Mehta [Tue, 13 Sep 2016 22:19:24 +0000 (15:19 -0700)]
API: Expose $wgEnableMagicLinks in meta=siteinfo

So Parsoid can use it.

Bug: T145590
Change-Id: Id792e07dc6fffec6d02b34168220b3a4e24b222b

7 years agoMerge "Remove pointless double exception logging from JobRunner"
jenkins-bot [Tue, 13 Sep 2016 22:26:26 +0000 (22:26 +0000)]
Merge "Remove pointless double exception logging from JobRunner"

7 years agoMerge "momentjs: Hack around bug in node/browser compat wrapper in locale files"
jenkins-bot [Tue, 13 Sep 2016 21:58:58 +0000 (21:58 +0000)]
Merge "momentjs: Hack around bug in node/browser compat wrapper in locale files"

7 years agoAvoid warnings when unable to parse the URL given to us
Chad Horohoe [Tue, 13 Sep 2016 21:07:32 +0000 (14:07 -0700)]
Avoid warnings when unable to parse the URL given to us

Change-Id: I56f1f36a3a54c6c23579f011d65dc75f30cb6dcf

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 13 Sep 2016 20:14:01 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I1c1a5601f4e102c7c8ac32908c91f5f3cff25eaa

7 years agoUpdate OOjs UI to v0.17.9
James D. Forrester [Tue, 13 Sep 2016 18:48:04 +0000 (11:48 -0700)]
Update OOjs UI to v0.17.9

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.17.9

Change-Id: Ibe5ba723888646f48ab4be9b88bc7a16ee0ae054

7 years agoMerge "Fix some PhpStorm warnings in AuthManager"
jenkins-bot [Tue, 13 Sep 2016 16:06:00 +0000 (16:06 +0000)]
Merge "Fix some PhpStorm warnings in AuthManager"

7 years agoRemove jquery.arrowSteps module
Paladox [Sun, 11 Sep 2016 17:26:36 +0000 (18:26 +0100)]
Remove jquery.arrowSteps module

It was unused by any other extension
https://github.com/search?q=user%3Awikimedia+jquery.arrowSteps&ref=searchresults&type=Code&utf8=%E2%9C%93

and only used for UploadWizard so it was merged into there with
I054674c7025ad37a8592ca82ce7ce0efd41d393f

Depends-On: I054674c7025ad37a8592ca82ce7ce0efd41d393f

Bug: T144974
Change-Id: Id9b6af1f1774bc33ceb024126030eefdc43beba0

7 years agoChangeTags: Rename "extension" to "software"
Kunal Mehta [Tue, 13 Sep 2016 10:44:08 +0000 (03:44 -0700)]
ChangeTags: Rename "extension" to "software"

Most end users don't care about whether a tag comes from MediaWiki core
or an extension. Since we now have tags that are added by core, let's
rename all of the "extension" terminology to the more generic
"software".

Not renamed in this patch is the i18n message "tags-source-extension",
which will be done in a separate patch to coordinate with TWN, and the
"source" output of the API, to avoid a breaking change.

Change-Id: Ic7b32b3e4bef0c0153a7cf302eef4aa07c52c9f2

7 years agoMerge "Add a change tag for edits that change the content model of a page"
jenkins-bot [Tue, 13 Sep 2016 11:42:44 +0000 (11:42 +0000)]
Merge "Add a change tag for edits that change the content model of a page"

7 years agoMerge "ChangeTags: Skip caching if some hooks aren't registered"
jenkins-bot [Tue, 13 Sep 2016 11:41:59 +0000 (11:41 +0000)]
Merge "ChangeTags: Skip caching if some hooks aren't registered"

7 years agoAdd a change tag for edits that change the content model of a page
Kunal Mehta [Tue, 13 Sep 2016 07:10:08 +0000 (00:10 -0700)]
Add a change tag for edits that change the content model of a page

And adjust the 'tags-source-extension' message to indicate that tags are
not just defined by extensions, but the software in general. The
extension related functions will be renamed in a follow-up patchset.

Bug: T145344
Change-Id: Id4391bc100287b8e469636949eaf7845bbd1d67c

7 years agoFix typo in "editpage-invalidcontentmodel-text" message
Kunal Mehta [Tue, 13 Sep 2016 09:18:08 +0000 (02:18 -0700)]
Fix typo in "editpage-invalidcontentmodel-text" message

Bug: T145491
Change-Id: I1814a84d49f6cf837f18a1e6e5b3db9602e1f55c

7 years agoMerge "Add day to date filter for ReverseChronologicalPager"
jenkins-bot [Tue, 13 Sep 2016 08:05:18 +0000 (08:05 +0000)]
Merge "Add day to date filter for ReverseChronologicalPager"

7 years agoChangeTags: Skip caching if some hooks aren't registered
Kunal Mehta [Tue, 13 Sep 2016 06:32:06 +0000 (23:32 -0700)]
ChangeTags: Skip caching if some hooks aren't registered

There is caching around the ChangeTagsListActive and ListDefinedTags
hooks that can be skipped if no callers are registered for them.

Change-Id: I0c8fccc358f80536fff7ad0bda1cab09181bca41

7 years agoMerge "Avoid page_touched update for HTTP GET action=purge requests"
jenkins-bot [Tue, 13 Sep 2016 06:40:52 +0000 (06:40 +0000)]
Merge "Avoid page_touched update for HTTP GET action=purge requests"

7 years agoMerge "Make DeferredUpdates call setTransactionTicket() on all DataUpdate tasks"
jenkins-bot [Tue, 13 Sep 2016 05:43:09 +0000 (05:43 +0000)]
Merge "Make DeferredUpdates call setTransactionTicket() on all DataUpdate tasks"

7 years agoMerge "Parser: Allow disabling magic link functionality"
jenkins-bot [Tue, 13 Sep 2016 05:31:47 +0000 (05:31 +0000)]
Merge "Parser: Allow disabling magic link functionality"

7 years agoMerge "SkinTemplate: Improve remote content handling in content navigation URLs"
jenkins-bot [Tue, 13 Sep 2016 05:30:13 +0000 (05:30 +0000)]
Merge "SkinTemplate: Improve remote content handling in content navigation URLs"

7 years agoAvoid page_touched update for HTTP GET action=purge requests
Aaron Schulz [Sun, 11 Sep 2016 18:49:42 +0000 (11:49 -0700)]
Avoid page_touched update for HTTP GET action=purge requests

This will still clear the local DC parser cache and the CDN cache
in all DCs. Therefore, the next page views served by the local
DC will reflect the refreshed content, as will further GET/HEAD
requests by the client that issued the purge using GET/HEAD.

If the problem was imply a stale CDN cache entry, then all
DCs will be up-to-date. If the problem is stale parser cache,
then a proper POST purge request is required to refresh all DCs.

Bug: T92357
Change-Id: I9af12ca8cfff73298f404fd3e2dd4f546621c546

7 years agoMerge "Add WikiPage::isLocal()"
jenkins-bot [Tue, 13 Sep 2016 05:23:28 +0000 (05:23 +0000)]
Merge "Add WikiPage::isLocal()"

7 years agoMerge "LocalIdLookup: Use DBAccessObjectUtils"
jenkins-bot [Tue, 13 Sep 2016 05:21:04 +0000 (05:21 +0000)]
Merge "LocalIdLookup: Use DBAccessObjectUtils"

7 years agoMerge "CentralIdLookup: Fix documentation of self::$instances"
jenkins-bot [Tue, 13 Sep 2016 05:16:30 +0000 (05:16 +0000)]
Merge "CentralIdLookup: Fix documentation of self::$instances"

7 years agoMerge "session: Fix phpdoc in Token::toStringAtTimestamp()"
jenkins-bot [Tue, 13 Sep 2016 05:12:13 +0000 (05:12 +0000)]
Merge "session: Fix phpdoc in Token::toStringAtTimestamp()"

7 years agoMerge "WikiPage: Use Title::isKnown() in hasViewableContent()"
jenkins-bot [Tue, 13 Sep 2016 05:06:23 +0000 (05:06 +0000)]
Merge "WikiPage: Use Title::isKnown() in hasViewableContent()"

7 years agoSkinTemplate: Improve remote content handling in content navigation URLs
Kunal Mehta [Tue, 13 Sep 2016 04:43:56 +0000 (21:43 -0700)]
SkinTemplate: Improve remote content handling in content navigation URLs

Use Title::isKnown() to determine whether to display the "view" view link
instead of checking $isForeignFile, since that includes all remote
content. This allows us to remove the GlobalUserPage hook that made the
tab look as if it existed.

Change-Id: Ibee7b64511fba8c2934da3c7a3bdd52090dcb58c

7 years agoMerge "Use late static binding in Article::newFromID()"
jenkins-bot [Tue, 13 Sep 2016 05:02:22 +0000 (05:02 +0000)]
Merge "Use late static binding in Article::newFromID()"

7 years agoParser: Allow disabling magic link functionality
Kunal Mehta [Fri, 9 Sep 2016 07:28:49 +0000 (00:28 -0700)]
Parser: Allow disabling magic link functionality

The magic link functionality is "old backwards-compatibility baggage"
that we probably want to get rid of eventually. The first step to doing
so would be making it configurable and allowing it to be turned off on
wikis that don't use it.

This adds each of the 3 magic link types as individual parser options,
which can be controlled by the $wgEnableMagicLinks setting.

Additionally, wfEscapeWikiText() was updated to only escape enabled
magic link types.

Bug: T47942
Change-Id: If63965f31d17da4b864510146e0018da1cae188c

7 years agoMerge "MapCacheLRU: Support null values in getWithSetCallback()"
jenkins-bot [Tue, 13 Sep 2016 04:58:02 +0000 (04:58 +0000)]
Merge "MapCacheLRU: Support null values in getWithSetCallback()"

7 years agoAdd WikiPage::isLocal()
Kunal Mehta [Tue, 13 Sep 2016 04:32:53 +0000 (21:32 -0700)]
Add WikiPage::isLocal()

WikiFilePage has a isLocal() function which indicates whether the file
is local or not. To better support other remote content, add this method
to the base WikiPage class. It only returns true currently, since all
content represented by WikiPage is local.

Change-Id: Ia39c405af4d131d919a57512e72a112bd65cc461

7 years agoMake DeferredUpdates call setTransactionTicket() on all DataUpdate tasks
Aaron Schulz [Tue, 13 Sep 2016 04:48:51 +0000 (21:48 -0700)]
Make DeferredUpdates call setTransactionTicket() on all DataUpdate tasks

This assues that things like LinksUpdate/LinksDeletionUpdate will
have a proper ticket for commitAndWaitForReplication()

Change-Id: I8234510efb706394c39c4027ddf54ace76983aa9

7 years agoLocalIdLookup: Use DBAccessObjectUtils
Kunal Mehta [Tue, 13 Sep 2016 04:29:41 +0000 (21:29 -0700)]
LocalIdLookup: Use DBAccessObjectUtils

This simplies some code that was re-implementing
DBAccessObjectUtils::getDBOptions().

Change-Id: Ib446f43149abdf23f07f209ccd9698923f0a2c22

7 years agoCentralIdLookup: Fix documentation of self::$instances
Kunal Mehta [Tue, 13 Sep 2016 04:29:09 +0000 (21:29 -0700)]
CentralIdLookup: Fix documentation of self::$instances

Change-Id: I9fd86c174832e130647e74f4fdeb9fdc7c90702e

7 years agosession: Fix phpdoc in Token::toStringAtTimestamp()
Kunal Mehta [Tue, 13 Sep 2016 04:27:50 +0000 (21:27 -0700)]
session: Fix phpdoc in Token::toStringAtTimestamp()

Change-Id: I35664eb9e89ffb945eb35bf3af58e1efdea0a8ff

7 years agoWikiPage: Use Title::isKnown() in hasViewableContent()
Kunal Mehta [Tue, 13 Sep 2016 04:27:25 +0000 (21:27 -0700)]
WikiPage: Use Title::isKnown() in hasViewableContent()

The current implementation of hasViewableContent() is basically the same
as Title::isKnown(), except that it switched the order of
isAlwaysKnown() and exists(). (Also it used WikiPage::exists() instead
of Title::exists(), but they're functionality equivalent).

This will make refactoring Title::isAlwaysKnown() easier in the future
as there is one less caller.

Change-Id: I698f08fb0f3e6c3bc702ec7d523d7eda063e18ca

7 years agoUse late static binding in Article::newFromID()
Kunal Mehta [Tue, 13 Sep 2016 04:24:50 +0000 (21:24 -0700)]
Use late static binding in Article::newFromID()

Address the FIXME and remove subclass implementations by using late
static binding.

Change-Id: I4f1793c87dfe08f768a283128d14ee2226a9e275

7 years agoMapCacheLRU: Support null values in getWithSetCallback()
Kunal Mehta [Tue, 13 Sep 2016 04:23:09 +0000 (21:23 -0700)]
MapCacheLRU: Support null values in getWithSetCallback()

The rest of this class supports having a key with a null value by using
array_key_exists() instead of isset(). So Use $this->has() in
getWithSetCallback() so a null value is still identified as set.

Change-Id: Ida74a6f7e284e98f9a7d76d97312ebe2ee343f10

7 years agoMerge "Reorganize RefreshLinksJob code slightly and avoid deprecated functions"
jenkins-bot [Tue, 13 Sep 2016 04:39:50 +0000 (04:39 +0000)]
Merge "Reorganize RefreshLinksJob code slightly and avoid deprecated functions"

7 years agoMerge "Tweak $wgTrxProfilerLimits to lower noise a bit"
jenkins-bot [Tue, 13 Sep 2016 04:38:38 +0000 (04:38 +0000)]
Merge "Tweak $wgTrxProfilerLimits to lower noise a bit"

7 years agoRemove pointless double exception logging from JobRunner
Aaron Schulz [Tue, 13 Sep 2016 03:31:05 +0000 (20:31 -0700)]
Remove pointless double exception logging from JobRunner

Change-Id: I12a2e6db326af25a3a276a477fbff505feac87b6

7 years agoMerge "Make safeWaitForMasterPos() use mWaitTimeout instead of hard-coded value"
jenkins-bot [Tue, 13 Sep 2016 04:33:26 +0000 (04:33 +0000)]
Merge "Make safeWaitForMasterPos() use mWaitTimeout instead of hard-coded value"

7 years agoMerge "Avoid using deprecated methods in JobQueueDB"
jenkins-bot [Tue, 13 Sep 2016 04:27:03 +0000 (04:27 +0000)]
Merge "Avoid using deprecated methods in JobQueueDB"

7 years agoMerge "Remove pointless getTransactionProfiler() method"
jenkins-bot [Tue, 13 Sep 2016 04:25:29 +0000 (04:25 +0000)]
Merge "Remove pointless getTransactionProfiler() method"

7 years agoMake DeferredUpdates::execute() protected
Aaron Schulz [Sun, 11 Sep 2016 12:19:57 +0000 (05:19 -0700)]
Make DeferredUpdates::execute() protected

Update the only caller, which is a deprecated wrapper method.
Locking down this internal method makes it secure against
misuse with regards to recursion checks.

Change-Id: I3ed52dbe4c0ad52c7b5de92e81bfdc98a1737bcf

7 years agoReorganize RefreshLinksJob code slightly and avoid deprecated functions
Aaron Schulz [Tue, 13 Sep 2016 04:11:11 +0000 (21:11 -0700)]
Reorganize RefreshLinksJob code slightly and avoid deprecated functions

Change-Id: I6ff4bec61b37bfbffc1e96eac61d692dd7feb31a

7 years agoSimplify LBFactory ticket code in CategoryMembershipChangeJob
Aaron Schulz [Tue, 13 Sep 2016 03:44:19 +0000 (20:44 -0700)]
Simplify LBFactory ticket code in CategoryMembershipChangeJob

Change-Id: I5800bbf6fa718604ffa12d8cde1aa3675fced6fd

7 years agoMerge "Update Bugzilla references to Phabricator references"
jenkins-bot [Tue, 13 Sep 2016 03:24:34 +0000 (03:24 +0000)]
Merge "Update Bugzilla references to Phabricator references"

7 years agoAvoid using deprecated methods in JobQueueDB
Aaron Schulz [Tue, 13 Sep 2016 02:56:37 +0000 (19:56 -0700)]
Avoid using deprecated methods in JobQueueDB

Change-Id: Ib35b8792e3e4902b52c3e708d8c6e756f35986bd

7 years agoRemove pointless getTransactionProfiler() method
Aaron Schulz [Tue, 13 Sep 2016 02:56:09 +0000 (19:56 -0700)]
Remove pointless getTransactionProfiler() method

Change-Id: Ib019e8317568105b95138cfdc0962b06a55154b9

7 years agoTweak $wgTrxProfilerLimits to lower noise a bit
Aaron Schulz [Tue, 13 Sep 2016 02:13:38 +0000 (19:13 -0700)]
Tweak $wgTrxProfilerLimits to lower noise a bit

Change-Id: I22ae7a5c2ba5f39007019e47ea0dff17a4cc971a

7 years agoMerge "Make LBFactory::waitForReplication() mask wait latency with callbacks"
jenkins-bot [Tue, 13 Sep 2016 01:31:28 +0000 (01:31 +0000)]
Merge "Make LBFactory::waitForReplication() mask wait latency with callbacks"

7 years agoMerge "Avoid creating DB replication lag in clearAllNotifications()"
jenkins-bot [Tue, 13 Sep 2016 01:27:59 +0000 (01:27 +0000)]
Merge "Avoid creating DB replication lag in clearAllNotifications()"

7 years agoMerge "EditPage: Don't throw exceptions for invalid content models"
jenkins-bot [Tue, 13 Sep 2016 00:46:42 +0000 (00:46 +0000)]
Merge "EditPage: Don't throw exceptions for invalid content models"

7 years agoMerge "Allow putting the app ID in the password for bot passwords"
jenkins-bot [Tue, 13 Sep 2016 00:38:14 +0000 (00:38 +0000)]
Merge "Allow putting the app ID in the password for bot passwords"

7 years agoSupport masking the WRITE_SYNC latency from ChronologyProtector
Aaron Schulz [Wed, 24 Aug 2016 21:22:11 +0000 (14:22 -0700)]
Support masking the WRITE_SYNC latency from ChronologyProtector

* Use OutputPage::output() as the method to mask latency, since it
  takes a good while to run. By the time it runs, cache replication
  should have caught up, so the reap call will likely not block.
* For redirects emitted after changes in POST, instead of masking
  with OutputPage, add a parameter to the redirect and block on
  the positions appearing. This uses the redirection RTT to mask
  the replication latency.

Change-Id: Ib23690c302e8033610fef9a0ef451dafe8a5803e

7 years agoMake LBFactory::waitForReplication() mask wait latency with callbacks
Aaron Schulz [Mon, 12 Sep 2016 23:46:02 +0000 (16:46 -0700)]
Make LBFactory::waitForReplication() mask wait latency with callbacks

This simply moves the call order down a bit.

Change-Id: I78559f769133d5addb590a65af7d535604de8407

7 years agoFix some PhpStorm warnings in AuthManager
Gergő Tisza [Thu, 8 Sep 2016 22:10:19 +0000 (22:10 +0000)]
Fix some PhpStorm warnings in AuthManager

Change-Id: Ib5fab7a54a6572897d9b679d6470d830cbb3cea9

7 years agoMerge "WebRequest: Use getRawVal instead of getGPCVal where possible"
jenkins-bot [Mon, 12 Sep 2016 22:21:50 +0000 (22:21 +0000)]
Merge "WebRequest: Use getRawVal instead of getGPCVal where possible"

7 years agoMerge "Make JobQueueGroup::push() update the queuesHaveJobs() cache"
jenkins-bot [Mon, 12 Sep 2016 22:20:20 +0000 (22:20 +0000)]
Merge "Make JobQueueGroup::push() update the queuesHaveJobs() cache"

7 years agoMerge "Add structure test for ContentHandler::makeEmptyContent()"
jenkins-bot [Mon, 12 Sep 2016 22:11:14 +0000 (22:11 +0000)]
Merge "Add structure test for ContentHandler::makeEmptyContent()"

7 years agoEditPage: Don't throw exceptions for invalid content models
Kunal Mehta [Mon, 12 Sep 2016 09:52:51 +0000 (02:52 -0700)]
EditPage: Don't throw exceptions for invalid content models

If a user tries to use an unrecognized content model using the "model"
request parameter, show a nice, localized error instead of an exception.

Bug: T145367
Change-Id: I50e7d332727c9afc22c1658d32c981db4305185b

7 years agoMake sure emails from RecentChange::save() are for comitted rows
Aaron Schulz [Mon, 12 Sep 2016 21:23:14 +0000 (14:23 -0700)]
Make sure emails from RecentChange::save() are for comitted rows

Change-Id: I9086a70348d2f0843527e3805e9f6aef3356ee03

7 years agoMake safeWaitForMasterPos() use mWaitTimeout instead of hard-coded value
Aaron Schulz [Mon, 12 Sep 2016 20:57:22 +0000 (13:57 -0700)]
Make safeWaitForMasterPos() use mWaitTimeout instead of hard-coded value

Change-Id: Idd5db66f5e7cea9fc3f3a4f47bd38e08e42559f6

7 years agoFollow-up dfd0464: Remove LICENSE.txt for deleted library 'phpjs-sha1'
Ed Sanders [Mon, 12 Sep 2016 20:50:46 +0000 (13:50 -0700)]
Follow-up dfd0464: Remove LICENSE.txt for deleted library 'phpjs-sha1'

Change-Id: Ia4bbd23c2e78eea9277dc8b1ade8bd3345559c9a

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 12 Sep 2016 20:18:47 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I634a673bf12cc66b2fbffb9a3abd2a2a0237ebe4

7 years agomomentjs: Hack around bug in node/browser compat wrapper in locale files
Roan Kattouw [Mon, 12 Sep 2016 18:50:34 +0000 (11:50 -0700)]
momentjs: Hack around bug in node/browser compat wrapper in locale files

If there is an element with id="global" on the page,
typeof global !== 'undefined' is true, but global.moment will
still be undefined and shouldn't be used.

For now, comment out the wrapper and just use 'this'.
We should look into upgrading to momentjs 2.14 where this bug is fixed.

Bug: T145382
Change-Id: Ia6e3b46e42248a5ee3c61c5fcda7d020d012e89e

7 years agoMerge "mw.special.movePage: Don't fail if no "Move associated talk page" checkbox"
jenkins-bot [Mon, 12 Sep 2016 15:39:48 +0000 (15:39 +0000)]
Merge "mw.special.movePage: Don't fail if no "Move associated talk page" checkbox"

7 years agoMerge "Add missing dependency to 'mediawiki.Upload.BookletLayout' module"
jenkins-bot [Mon, 12 Sep 2016 15:33:10 +0000 (15:33 +0000)]
Merge "Add missing dependency to 'mediawiki.Upload.BookletLayout' module"

7 years agoMerge "Sync up with Parsoid parserTests."
jenkins-bot [Mon, 12 Sep 2016 15:30:23 +0000 (15:30 +0000)]
Merge "Sync up with Parsoid parserTests."

7 years agoMerge "Change file namespace name & and specialpages titles in Urdu"
jenkins-bot [Mon, 12 Sep 2016 15:26:34 +0000 (15:26 +0000)]
Merge "Change file namespace name & and specialpages titles in Urdu"

7 years agoSync up with Parsoid parserTests.
Subramanya Sastry [Mon, 12 Sep 2016 14:06:04 +0000 (09:06 -0500)]
Sync up with Parsoid parserTests.

This now aligns with Parsoid commit 94316242479f272b51db431a0f8fb6d77bd8f639

Change-Id: I411e3b733f4f1e5da5fa2500354575af77e09c88