lhc/web/wiklou.git
3 years agoWatchedItemStore::countVisitingWatchersMultiple() shouldn't query all titles when...
Brad Jorsch [Tue, 18 Sep 2018 16:01:32 +0000 (12:01 -0400)]
WatchedItemStore::countVisitingWatchersMultiple() shouldn't query all titles when asked for none

If a caller gives an empty array for $targetsWithVisitThresholds, per
the documentation it should be expecting an empty array in return, not a
count of watchers for every title in the database.

Bug: T204729
Change-Id: I0f25fae301450d077bb30597281aaef0fba209d4

3 years agoMerge "Allow edit.php to modify different slots."
jenkins-bot [Tue, 18 Sep 2018 15:52:02 +0000 (15:52 +0000)]
Merge "Allow edit.php to modify different slots."

3 years agoMerge "mediawiki.Title: Add isTalkPage/getTalkPage methods to mw.Title.js"
jenkins-bot [Tue, 18 Sep 2018 15:00:30 +0000 (15:00 +0000)]
Merge "mediawiki.Title: Add isTalkPage/getTalkPage methods to mw.Title.js"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 18 Sep 2018 07:14:02 +0000 (09:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If4369a94a3165a063ccc3061a6f3a5e6e6487ad5

3 years agoMerge "Article: Fix reference to view() in documentation comment"
jenkins-bot [Tue, 18 Sep 2018 02:26:10 +0000 (02:26 +0000)]
Merge "Article: Fix reference to view() in documentation comment"

3 years agoArticle: Fix reference to view() in documentation comment
Roan Kattouw [Tue, 18 Sep 2018 01:29:55 +0000 (21:29 -0400)]
Article: Fix reference to view() in documentation comment

WikiPage::view() doesn't exist; Article::view() does.

Change-Id: I3fbffa15be4cff6cb3f5c7dc5cc178102472f25b

3 years agoMerge "Handle invalid input to Special:FilePath?file="
jenkins-bot [Mon, 17 Sep 2018 21:03:36 +0000 (21:03 +0000)]
Merge "Handle invalid input to Special:FilePath?file="

3 years agomediawiki.Title: Add isTalkPage/getTalkPage methods to mw.Title.js
Ed Sanders [Thu, 13 Sep 2018 18:21:30 +0000 (19:21 +0100)]
mediawiki.Title: Add isTalkPage/getTalkPage methods to mw.Title.js

These are identical to methods in Title.php

Change-Id: Ie57243bac1aa5e23bc8b1c027bcb1b83090ee433

3 years agoMerge "resourceloader: Remove unused makeCustomLoaderScript() method"
jenkins-bot [Mon, 17 Sep 2018 18:44:42 +0000 (18:44 +0000)]
Merge "resourceloader: Remove unused makeCustomLoaderScript() method"

3 years agoMerge "resources: Strip '$' and 'mw' from file closures"
jenkins-bot [Mon, 17 Sep 2018 18:41:32 +0000 (18:41 +0000)]
Merge "resources: Strip '$' and 'mw' from file closures"

3 years agoMerge "ApiQueryInfo: fix query limits for testactions"
jenkins-bot [Mon, 17 Sep 2018 14:06:26 +0000 (14:06 +0000)]
Merge "ApiQueryInfo: fix query limits for testactions"

3 years agoMerge "Introduce ContentHandler::getSecondaryDataUpdates."
jenkins-bot [Mon, 17 Sep 2018 14:06:19 +0000 (14:06 +0000)]
Merge "Introduce ContentHandler::getSecondaryDataUpdates."

3 years agoApiQueryInfo: fix query limits for testactions
Bartek Łukawski [Mon, 17 Sep 2018 11:23:36 +0000 (13:23 +0200)]
ApiQueryInfo: fix query limits for testactions

ApiBase::LIMIT_SML2 actually belongs to apihighlimits.

Change-Id: Iaa50c6be417c9681563087b80928dc49a3bbd141

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 17 Sep 2018 07:42:12 +0000 (09:42 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4c16ddd26f216b8394faf2fdec0a0efe10d1e6bd

3 years agoHandle invalid input to Special:FilePath?file=
Umherirrender [Sat, 18 Aug 2018 00:39:36 +0000 (02:39 +0200)]
Handle invalid input to Special:FilePath?file=

Bug: T175301
Change-Id: I38a05416db10de88f3bc529f5fad9697d7d6e1c2

3 years agoMerge "Give more specific error messages on Special:Redirect"
jenkins-bot [Sun, 16 Sep 2018 19:40:32 +0000 (19:40 +0000)]
Merge "Give more specific error messages on Special:Redirect"

3 years agoGive more specific error messages on Special:Redirect
Umherirrender [Sat, 18 Aug 2018 02:37:59 +0000 (04:37 +0200)]
Give more specific error messages on Special:Redirect

Added some basic tests

Bug: T202183
Change-Id: Ib0dd50ff5575a2b2093a57afce79e9f8623fa24d

3 years agoMerge "build: Updating mediawiki/mediawiki-codesniffer to 22.0.0"
jenkins-bot [Sun, 16 Sep 2018 16:13:55 +0000 (16:13 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 22.0.0"

3 years agoMerge "Ensure database is setup in MediaWikiTestCase::insertPage"
jenkins-bot [Sun, 16 Sep 2018 15:53:28 +0000 (15:53 +0000)]
Merge "Ensure database is setup in MediaWikiTestCase::insertPage"

3 years agobuild: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Umherirrender [Fri, 7 Sep 2018 17:01:32 +0000 (19:01 +0200)]
build: Updating mediawiki/mediawiki-codesniffer to 22.0.0

Added spaces around .
Removed empty return statement which are not required
Removed return after phpunit markTestIncomplete,
which is throwing to exit the test, no need for a return

Change-Id: I2c80b965ee52ba09949e70ea9e7adfc58a1d89ce

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 16 Sep 2018 07:58:34 +0000 (09:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic31e0d5aef1fc08989f8d39b32a858257f43c2ef

3 years agoresourceloader: Remove unused makeCustomLoaderScript() method
Timo Tijhof [Sat, 15 Sep 2018 21:13:37 +0000 (22:13 +0100)]
resourceloader: Remove unused makeCustomLoaderScript() method

Follows-up a0809dfa5 (2015) which removed the feature for which
this would be used. No callers in MediaWiki core, Wikimedia Git,
or elsewhere indexed by Codesearch.

Bug: T65240
Change-Id: I56af8df3d072cd76a38595254812af6be268b134

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 15 Sep 2018 07:28:35 +0000 (09:28 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I13ddf57c93ab420c882f38e353898715f5770e60

3 years agoMerge "remove outdated design.txt."
jenkins-bot [Sat, 15 Sep 2018 00:30:41 +0000 (00:30 +0000)]
Merge "remove outdated design.txt."

3 years agoMerge "Release notes for MCR baseline"
jenkins-bot [Fri, 14 Sep 2018 21:30:07 +0000 (21:30 +0000)]
Merge "Release notes for MCR baseline"

3 years agoEnsure database is setup in MediaWikiTestCase::insertPage
Umherirrender [Fri, 14 Sep 2018 18:30:30 +0000 (20:30 +0200)]
Ensure database is setup in MediaWikiTestCase::insertPage

Also in editPage
Add missing @group Database

Depends-On: Id81425fff0a41c651c1967698124246befcdb032
Depends-On: If97d9e6e525465ca3879003e71dd5e67fc0afdfd
Change-Id: I3bfd478769e0907913834c9639af4375223638cc

3 years agoMerge "Give search results a consistent css class to select"
jenkins-bot [Fri, 14 Sep 2018 19:40:07 +0000 (19:40 +0000)]
Merge "Give search results a consistent css class to select"

3 years agoRelease notes for MCR baseline
daniel [Fri, 14 Sep 2018 13:43:18 +0000 (15:43 +0200)]
Release notes for MCR baseline

Change-Id: I6a9ae5642f6a39c5f35cab8c49d6636311288eb9

3 years agoIntroduce ContentHandler::getSecondaryDataUpdates.
daniel [Fri, 9 Mar 2018 22:05:47 +0000 (23:05 +0100)]
Introduce ContentHandler::getSecondaryDataUpdates.

This adds getSecondaryDataUpdates and getDeletionUpdates
to ContentHandler, and updates WikiPage and DerivedPageDataUpdates
to handle DataUpdates from all slots.

Bug: T194038
Bug: T194037
Change-Id: I75c96318f58a5cdda48484f7040ae41e6f42392a

3 years agoremove outdated design.txt.
daniel [Fri, 14 Sep 2018 14:08:02 +0000 (16:08 +0200)]
remove outdated design.txt.

While having an overview of the overall design of MediaWiki in the
code repository is a good thing, having an outdated design overview
that has not been substantially updated in 15 years is not helpful.

This is a fun historical document though, so I have put it up at
<https://www.mediawiki.org/wiki/Architecture/design.txt>.

Change-Id: I85be15a68f4ab9ac77766112e6484f2007da4eec

3 years agoAllow edit.php to modify different slots.
daniel [Fri, 14 Sep 2018 09:20:12 +0000 (11:20 +0200)]
Allow edit.php to modify different slots.

This adds --slot and --remove options to the edit.php maintenance script,
to allow content of different slots to be edited, alots to be added, and
slots to be removed.

This is needed to help with testing MCR functionality, since EditPage
does not yet support MCR.

Bug: T189220
Change-Id: I985fb5afcd5d469fc31b32d2a927f425c40fc290

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 14 Sep 2018 07:22:43 +0000 (09:22 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I0d24aaefa10d74d6ed44ac77e3fe92003b4d766d

3 years agoMerge "Drop wfUseMW, deprecated in 1.26"
jenkins-bot [Fri, 14 Sep 2018 01:53:07 +0000 (01:53 +0000)]
Merge "Drop wfUseMW, deprecated in 1.26"

3 years agoMerge "mediawiki.language: Use the 'mw' global"
jenkins-bot [Fri, 14 Sep 2018 01:40:56 +0000 (01:40 +0000)]
Merge "mediawiki.language: Use the 'mw' global"

3 years agoDrop wfUseMW, deprecated in 1.26
James D. Forrester [Thu, 13 Sep 2018 19:58:58 +0000 (12:58 -0700)]
Drop wfUseMW, deprecated in 1.26

Change-Id: I291d6eace1913a651c5e7136f3f2e0216d89fac5

3 years agoMerge "mediawiki.language: Remove unused private method 'procPLURAL'"
jenkins-bot [Fri, 14 Sep 2018 00:34:05 +0000 (00:34 +0000)]
Merge "mediawiki.language: Remove unused private method 'procPLURAL'"

3 years agoresources: Strip '$' and 'mw' from file closures
Timo Tijhof [Wed, 29 Aug 2018 04:46:30 +0000 (05:46 +0100)]
resources: Strip '$' and 'mw' from file closures

Follows-up Id6d13bbea6:
- '$': mw.loader.implement does this already.
- 'mw': Use the canonical name directly.

This replaces the following patterns:

File closures (common):
- `( function ( $, mw ) {`     => `( function () {`
- `( function ( $ ) {`         => `( function () {`
- `( function ( mw ) {`        => `( function () {`
- `( function ( mw, $ ) {`     => `( function () {`

File closures (rare):
- `( function ( mw, $, OO ) {`    => `( function () {`
- `( function ( mw, OO, $ ) {`    => `( function () {`
- `( function ( mw, document ) {` => `( function () {`

Combined dom-ready and file closure (rare):
- `jQuery( function ( $ ) {` => `$( function () {
- `jQuery( function () {` => `$( function () {

Remaining references in files without a closure, as found by
the new ESLint setting (rare):
- `jQuery`    => `$`
- `mediaWiki` => `mw`

Change-Id: I7cf2426cde597259e8c6f3f6f615a1a81a0ca82b

3 years agomediawiki.language: Use the 'mw' global
Timo Tijhof [Thu, 13 Sep 2018 23:48:42 +0000 (00:48 +0100)]
mediawiki.language: Use the 'mw' global

Follows-up Id6d13bbea6.

Change-Id: I16de5ef6190aa4bb322b03416d51bbf28ff15dc9

3 years agoMerge "resourceloader: Optimise and simplify state propagation logic"
jenkins-bot [Thu, 13 Sep 2018 23:40:28 +0000 (23:40 +0000)]
Merge "resourceloader: Optimise and simplify state propagation logic"

3 years agoresourceloader: Optimise and simplify state propagation logic
Timo Tijhof [Sat, 8 Sep 2018 20:04:17 +0000 (21:04 +0100)]
resourceloader: Optimise and simplify state propagation logic

aka "handlePending 2.0",
aka "don't recurse 300x before executing a module",
aka "don't break DevTools flame graphs".

== Impact

Comparison based on viewing the default Main page on Chrome stable.
The local MediaWiki has a few extensions installed (EventLogging,
ULS, Navigation Timing).

Measured by alternating between before/after and logging 'mediaWikiLoadEnd'
from ext.navigationTiming.js, and evaluating the following on the console:
```
({ responseStart: performance.timing.responseStart - performance.timing.navigationStart,
   domInteractive: performance.timing.domInteractive - performance.timing.navigationStart,
   domComplete: performance.timing.domComplete - performance.timing.navigationStart,
   loadEventEnd: performance.timing.loadEventEnd - performance.timing.navigationStart });
```

This was repeated five times, and I picked three results based on similar
responseStart values. This provides a fairer comparison by avoiding bias of
fluctuation from the network/server. The actual values ended up slightly
favouring the older code.

| -------------- | ---------------- | ---------------- | -------- |
|                | Before           | After            | Avg diff |
| -------------- | ---------------- | ---------------- | -------- |
| responseStart  | 1044, 1001, 1016 | 1025, 1023, 1024 | +3ms     |
| domInteractive | 2080, 2069, 2059 | 1872, 2101, 2050 | -61ms    |
| domComplete    | 4361, 4239, 3927 | 3691, 4023, 3981 | -227ms   |
| loadEventEnd   | 4366, 4244, 3932 | 3691, 4023, 3982 | -282ms   |
| mwLoadEnd      | 4524, 4416, 4113 | 3994, 4320, 4297 | -147ms   |
| -------------- | ---------------- | ---------------- | -------- |

== Implementation

While technically a single logical change, this commit does
resolve multiple long-standing issues and inefficiencies.

* handlePending (now called doPropagation) was called way more
  often than needed. When a load.php response arrived with calls
  to mw.loader.implement(), each one could execute and immediately
  call handlePending().
  Now, the first implementation in a batch schedule one call
  doPropagation(), and the later ones ride along that one call.

* Most calls to handlePending were only able to execute one
  pending module, which in turn created its own handlePending
  call that started all over again. This meant that by the time
  control returned to an outer call, there was nothing left to
  do, except it still needed to continue its iteration over the
  whole registry before knowing there was nothing left to dos.

* Due to recursive calls to handlePending() from execute(), and
  due to immediate execution from implement() - as called from
  load.php or asyncEval - the stack was often already 100s of
  level deep before *starting* the execution of a module.
  Such deep stacks caused:
  - a larger memory footprint (for the stacks themselves).
  - confusing flame graphs. It was impossible to analyze
    performance of module initialisation, I typically could only
    look at code from dom-ready handlers or other events.
    The stacks were so big, they actually caused rendering
    bugs inside Chrome where higher parts of the stack would be
    trimmed, and thus related code would no longer be visually
    grouped by the same parent.
  - confusing error messages (long stack traces).

* The eager execution from mw.loader.implement() calls meant
  that it was not possible to separate the parsing/loading of
  code (by load.php and asyncEval), from the execution of code.
  Now, this is separated by a 1ms yield (in practice it's
  larger than 1ms, but it has high priority). This means that the
  batch of localStorage eval() and the batch response from
  load.php can now first do one type of work (allocating of functions
  and objects, stashing them in the registry), and then later the
  other type of work (execution of the module code) - with some
  breathing room allowed for rendering.

Bug: T127328
Bug: T202703
Change-Id: I499ae3f095545abcc03e8989f54422b1997738d3

3 years agoresources: Register easy-deflate as foreign resource
Timo Tijhof [Tue, 11 Sep 2018 02:41:19 +0000 (03:41 +0100)]
resources: Register easy-deflate as foreign resource

Change-Id: Ifc8f5a4b9346da30b0bf3b3dc25c04ce3e2778d5

3 years agoReplace 'help' with better fitting 'helpNotice' icon on tags panel
Volker E [Wed, 12 Sep 2018 21:08:50 +0000 (14:08 -0700)]
Replace 'help' with better fitting 'helpNotice' icon on tags panel

Bug: T204165
Change-Id: I90a9619c976ff37c8b7d4a9bb03a3573e00bd19d

3 years agoGive search results a consistent css class to select
Erik Bernhardson [Thu, 13 Sep 2018 18:49:59 +0000 (11:49 -0700)]
Give search results a consistent css class to select

Results with and without thumbnails only share an li, and that li
cannot be specifically targeted. Add a class to the li so anything
that wants to deal with individual results can target them.

Bug: T189242
Change-Id: I9b19c5e3d7d72d4be3a5ffdf280bf07b870ff3c0

3 years agoMerge "build: Update eslint-config-wikimedia"
jenkins-bot [Thu, 13 Sep 2018 12:27:49 +0000 (12:27 +0000)]
Merge "build: Update eslint-config-wikimedia"

3 years agoMerge "HTMLForm: Drop this never-used backwards-compatibility"
jenkins-bot [Thu, 13 Sep 2018 12:27:43 +0000 (12:27 +0000)]
Merge "HTMLForm: Drop this never-used backwards-compatibility"

3 years agoMerge "Remove unused MediaWikiTestCase::prepareConnectionForTesting"
jenkins-bot [Thu, 13 Sep 2018 09:40:18 +0000 (09:40 +0000)]
Merge "Remove unused MediaWikiTestCase::prepareConnectionForTesting"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 13 Sep 2018 07:36:06 +0000 (09:36 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie5096f881b1aab8b24a3bafde2adabd1e7405e36

3 years agoMerge "Introduce constants for fetchLanguageName(s)"
jenkins-bot [Thu, 13 Sep 2018 06:24:09 +0000 (06:24 +0000)]
Merge "Introduce constants for fetchLanguageName(s)"

3 years agoMerge "Fix html <title> for exceptions during message parsing."
jenkins-bot [Thu, 13 Sep 2018 03:34:52 +0000 (03:34 +0000)]
Merge "Fix html <title> for exceptions during message parsing."

3 years agoMerge "hooks: Drop Special{Watchlist|RecentChanges}Filters, deprecated in 1.23"
jenkins-bot [Thu, 13 Sep 2018 00:56:17 +0000 (00:56 +0000)]
Merge "hooks: Drop Special{Watchlist|RecentChanges}Filters, deprecated in 1.23"

3 years agoMerge "Use improvements of jQuery 3.3"
jenkins-bot [Thu, 13 Sep 2018 00:11:32 +0000 (00:11 +0000)]
Merge "Use improvements of jQuery 3.3"

3 years agoMerge "HTMLTextField: Pass extra parameters in OOUI mode"
jenkins-bot [Wed, 12 Sep 2018 22:10:08 +0000 (22:10 +0000)]
Merge "HTMLTextField: Pass extra parameters in OOUI mode"

3 years agoHTMLTextField: Pass extra parameters in OOUI mode
Bartosz Dziewoński [Wed, 12 Sep 2018 20:09:47 +0000 (22:09 +0200)]
HTMLTextField: Pass extra parameters in OOUI mode

Some additional parameters that are passed through as attributes in
HTML mode were not being passed through as config options in OOUI mode:
* 'min'
* 'max'
* 'step'
* 'title'

Some have no equivalent in OOUI:
* 'pattern'
* 'list'
* 'multiple'

Also note that we support some OOUI config options that have no
equivalent in HTML:
* 'autosize'
* 'flags'
* 'indicator'

I originally noticed the problem with the 'min' and 'max' params,
which are clearly missing in OOUI preferences for RC and watchlist.
I don't know if anything anywhere actually uses the other ones.

Bug: T181844
Change-Id: I2d22ef3b08b7f0b4283b644d80bd74906177d089

3 years agoHTMLForm: Drop this never-used backwards-compatibility
James D. Forrester [Wed, 12 Sep 2018 20:14:18 +0000 (13:14 -0700)]
HTMLForm: Drop this never-used backwards-compatibility

Change-Id: I6864d3a1207de44d465491baad87cb9c00714255

3 years agohooks: Drop Special{Watchlist|RecentChanges}Filters, deprecated in 1.23
James D. Forrester [Wed, 12 Sep 2018 19:43:01 +0000 (12:43 -0700)]
hooks: Drop Special{Watchlist|RecentChanges}Filters, deprecated in 1.23

Neither SpecialWatchlistFilters nor SpecialRecentChangesFilters are used in any
code known to Wikimedia code search. The related code to use these hooks was
only ever used within the MediaWiki repo.

Change-Id: Ib631d49d7b5835c665171dbad3e8a646b80827ef

3 years agoMerge "Add part to update ctd_user_defined in populateChangeTagDef"
jenkins-bot [Wed, 12 Sep 2018 19:32:00 +0000 (19:32 +0000)]
Merge "Add part to update ctd_user_defined in populateChangeTagDef"

3 years agoMerge "Set MCR migration stage to write-both/read-new AGAIN."
jenkins-bot [Wed, 12 Sep 2018 18:27:12 +0000 (18:27 +0000)]
Merge "Set MCR migration stage to write-both/read-new AGAIN."

3 years agoMerge "Reset services in ParserTestTopLevelSuite."
jenkins-bot [Wed, 12 Sep 2018 18:26:00 +0000 (18:26 +0000)]
Merge "Reset services in ParserTestTopLevelSuite."

3 years agoMerge "foreign-resources.yaml: Fix some documentation typos"
jenkins-bot [Wed, 12 Sep 2018 17:59:54 +0000 (17:59 +0000)]
Merge "foreign-resources.yaml: Fix some documentation typos"

3 years agoMerge "Make the spelling and pluralization of "Active filters" consistent"
jenkins-bot [Wed, 12 Sep 2018 17:58:18 +0000 (17:58 +0000)]
Merge "Make the spelling and pluralization of "Active filters" consistent"

3 years agoSet MCR migration stage to write-both/read-new AGAIN.
daniel [Tue, 11 Sep 2018 17:58:00 +0000 (19:58 +0200)]
Set MCR migration stage to write-both/read-new AGAIN.

This is a re-submit of the config change at the heart of I15989adae2b5
which got reverted in I5426b5efd0 dues to T204065.

Bug: T198561
Change-Id: I7a85d0c4d8288df061841c9144d895af1318dc45

3 years agoReset services in ParserTestTopLevelSuite.
daniel [Tue, 11 Sep 2018 17:01:08 +0000 (19:01 +0200)]
Reset services in ParserTestTopLevelSuite.

This is intended to isolate parser tests from other tests
by resetting the service locator between test runs, just like
MediaWikiTestCase does.

NOTE: this has no effect on parser tests run via parserTest.php,
it's only for tests run via PHPUnit.

Bug: T204065
Bug: T204072
Change-Id: I772b3b4a2d4d98948a249603b1cdb0933427b01c

3 years agoMerge "RCFilters: Replace deprecated 'advanced' by renamed to 'settings' icon"
jenkins-bot [Wed, 12 Sep 2018 16:49:20 +0000 (16:49 +0000)]
Merge "RCFilters: Replace deprecated 'advanced' by renamed to 'settings' icon"

3 years agoforeign-resources.yaml: Fix some documentation typos
Bartosz Dziewoński [Wed, 12 Sep 2018 16:13:53 +0000 (18:13 +0200)]
foreign-resources.yaml: Fix some documentation typos

Change-Id: I89281ddaeec5d0bc778ca6829dc2d7a531fb5320

3 years agoMerge "Use NumberInputWidget in HTMLFloatField"
jenkins-bot [Wed, 12 Sep 2018 16:08:48 +0000 (16:08 +0000)]
Merge "Use NumberInputWidget in HTMLFloatField"

3 years agoRemove unused MediaWikiTestCase::prepareConnectionForTesting
addshore [Fri, 24 Aug 2018 16:18:55 +0000 (17:18 +0100)]
Remove unused MediaWikiTestCase::prepareConnectionForTesting

This method is redundant to setupDatabaseWithTestPrefix.

Change-Id: Ic6baa13c51948a3ea838fe827acea58dc740bafc

3 years agoFix --user option in DeleteLocalPasswords
Amir Sarabadani [Wed, 12 Sep 2018 11:31:59 +0000 (13:31 +0200)]
Fix --user option in DeleteLocalPasswords

Bug: T201009
Change-Id: I69c14741f578b59cd73e5c8c5576f8c250825a30

3 years agoMerge "resourceloader: Improve mw.loader tests"
jenkins-bot [Wed, 12 Sep 2018 10:54:58 +0000 (10:54 +0000)]
Merge "resourceloader: Improve mw.loader tests"

3 years agoMerge "resourceloader: Configure eslint to disallow $ and require inside startup"
jenkins-bot [Wed, 12 Sep 2018 10:54:52 +0000 (10:54 +0000)]
Merge "resourceloader: Configure eslint to disallow $ and require inside startup"

3 years agoMerge "resourceloader: Optimise mw.now() definition"
jenkins-bot [Wed, 12 Sep 2018 10:29:32 +0000 (10:29 +0000)]
Merge "resourceloader: Optimise mw.now() definition"

3 years agoUse NumberInputWidget in HTMLFloatField
mainframe98 [Thu, 6 Sep 2018 12:21:46 +0000 (14:21 +0200)]
Use NumberInputWidget in HTMLFloatField

The PHP variant of this widget was introduced in 0.27.0.
Using NumberInputWidget has the advantage that HTMLFloatField and
HTMLIntField can now be infused as a JavaScript NumberInputWidget.

Bug: T203656
Change-Id: I5d6a913de38d12a21c9bfb1ce9790574d98a5a1b

3 years agoMerge "Improve page display title handling for category pages"
jenkins-bot [Wed, 12 Sep 2018 07:25:46 +0000 (07:25 +0000)]
Merge "Improve page display title handling for category pages"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 12 Sep 2018 06:20:43 +0000 (08:20 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4138398bcaf37ff156f075f01ef2efc719d2dc40

3 years agoMerge "Go search to consider fragment only title invalid"
jenkins-bot [Wed, 12 Sep 2018 05:18:09 +0000 (05:18 +0000)]
Merge "Go search to consider fragment only title invalid"

3 years agoUpdate OOUI to v0.28.2
Volker E [Wed, 12 Sep 2018 00:30:16 +0000 (17:30 -0700)]
Update OOUI to v0.28.2

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.28.2

Bug: T190581
Bug: T202477
Bug: T203766
Bug: T203813
Depends-on: I8af1bfd86322f9dce8a5e406f0b41e5dbcd9686a
Change-Id: Ice05fc7b2b4fae1741c3211c5909ba64bbbf28c4

3 years agoMerge "ContribsPager: Factor revision check out of formatRow"
jenkins-bot [Tue, 11 Sep 2018 22:56:49 +0000 (22:56 +0000)]
Merge "ContribsPager: Factor revision check out of formatRow"

3 years agoContribsPager: Factor revision check out of formatRow
jdlrobson [Thu, 26 Jul 2018 08:51:58 +0000 (16:51 +0800)]
ContribsPager: Factor revision check out of formatRow

This is needed by MobileFrontend. Also helps with readability
and understanding what is going on inside the larger formatRow
method.

Bug: T199066
Change-Id: I679f4bf4305ca5b0fd523e844a01f06b4bd38b5c

3 years agobuild: Update eslint-config-wikimedia
Ed Sanders [Tue, 11 Sep 2018 22:25:26 +0000 (23:25 +0100)]
build: Update eslint-config-wikimedia

Change-Id: I5a8768e1a7e3960d2c822c5f842c0ffa29e2f08b

3 years agoMerge "Lazy-infuse OOUI widgets by tab"
jenkins-bot [Tue, 11 Sep 2018 22:21:03 +0000 (22:21 +0000)]
Merge "Lazy-infuse OOUI widgets by tab"

3 years agoMerge "test: disable hook when testing default preferences"
jenkins-bot [Tue, 11 Sep 2018 20:50:06 +0000 (20:50 +0000)]
Merge "test: disable hook when testing default preferences"

3 years agoMerge "Fix missing comma on sql file"
jenkins-bot [Tue, 11 Sep 2018 20:47:27 +0000 (20:47 +0000)]
Merge "Fix missing comma on sql file"

3 years agoLazy-infuse OOUI widgets by tab
Ed Sanders [Fri, 7 Sep 2018 18:58:41 +0000 (19:58 +0100)]
Lazy-infuse OOUI widgets by tab

Bug: T203838
Change-Id: I43241e0563c62e009c1ad5409bf598b62661483e

3 years agoMerge "tests: Throw when tests run that "need a db" but miss Database group"
jenkins-bot [Tue, 11 Sep 2018 20:24:19 +0000 (20:24 +0000)]
Merge "tests: Throw when tests run that "need a db" but miss Database group"

3 years agoGo search to consider fragment only title invalid
Erik Bernhardson [Mon, 10 Sep 2018 20:29:08 +0000 (13:29 -0700)]
Go search to consider fragment only title invalid

When submiting using the 'go' feature of Special:Search (standard
usecase for autocomplete) a nearby title can be selected.
Unfortunately a fragment only title is considered valid, which
sends the user to Main_Page#searchterm.

Instead don't allow a search starting with # to trigger the go
feature.

Bug: T182452
Change-Id: I8ce3ce8633e23db41ae6eafb9996ca7294f8445a

3 years agoFix missing comma on sql file
Dayllan Maza [Tue, 11 Sep 2018 19:50:42 +0000 (15:50 -0400)]
Fix missing comma on sql file

Bug: T197144
Change-Id: I9e1562fd0ce94aaa44e932a608065a7340492746

3 years agoMerge "Add release notes for removed collations"
jenkins-bot [Tue, 11 Sep 2018 19:06:08 +0000 (19:06 +0000)]
Merge "Add release notes for removed collations"

3 years agotests: Throw when tests run that "need a db" but miss Database group
addshore [Tue, 11 Sep 2018 17:16:26 +0000 (18:16 +0100)]
tests: Throw when tests run that "need a db" but miss Database group

Depends-On: I5cfea2dc4e56ed4639126e35c0f8aa370852f056
Depends-On: Ic472eb073290793c432812ae8b47ab2b41e74a26
Change-Id: I4cdc8130032340726c5d18d795cd2d6b6b58b307

3 years agoUse improvements of jQuery 3.3
Fomafix [Tue, 11 Sep 2018 16:08:09 +0000 (18:08 +0200)]
Use improvements of jQuery 3.3

Since jQuery 3.3 .addClass() supports arrays. [1]

Replace
  .addClass( classes.join( ' ' ) )
by
  .addClass( classes )

[1] https://blog.jquery.com/2018/01/19/jquery-3-3-0-a-fragrant-bouquet-of-deprecations-and-is-that-a-new-feature/

Change-Id: I5dbac90c8021963840f36798ed01b31dce063c50

3 years agoAdd release notes for removed collations
Bartosz Dziewoński [Tue, 11 Sep 2018 18:10:49 +0000 (20:10 +0200)]
Add release notes for removed collations

* 'uppercase-se' - removed in 3469713f4e36f9fb7e9babe0f2fd165d6e59b2e2
* 'xx-uca-et' - removed in 9c46871d60f02a033c6082836f9b6a18b3a10ec1
* 'xx-uca-fa' - removed in 5a21de8abb7f03e72a07d8578babc1835dff4a64

Change-Id: I28a20fdf86af527a209d826fb12fb0ee28c83a66

3 years agoMerge "Revert MCR migration stage to write-both/read-old"
jenkins-bot [Tue, 11 Sep 2018 18:18:17 +0000 (18:18 +0000)]
Merge "Revert MCR migration stage to write-both/read-old"

3 years agoMerge "Remove xx-uca-et collation workaround"
jenkins-bot [Tue, 11 Sep 2018 18:13:00 +0000 (18:13 +0000)]
Merge "Remove xx-uca-et collation workaround"

3 years agoRevert MCR migration stage to write-both/read-old
Lucas Werkmeister [Tue, 11 Sep 2018 16:07:43 +0000 (18:07 +0200)]
Revert MCR migration stage to write-both/read-old

This partially reverts commit 9bd162dce2 (change I15989adae2).

Bug: T204065
Change-Id: I5426b5efd09dd1253883e405ec5db6d0ebac779e

3 years agoUse RevisionRenderer for rendering ParserOutput
daniel [Tue, 14 Aug 2018 16:37:30 +0000 (18:37 +0200)]
Use RevisionRenderer for rendering ParserOutput

Bug: T174035
Bug: T174036
Change-Id: I1085b05d635dd954c143c8a398fae909632ba0a9

3 years agoCover incomplete revision case in RenderedRevision.
daniel [Mon, 3 Sep 2018 13:34:12 +0000 (15:34 +0200)]
Cover incomplete revision case in RenderedRevision.

This introduces a check that allows magic words like {{REVISIONUSER}}
to still work even when an incomplete fake RevisonRecord is provided to
RevisionRenderer. In such a case, the revision is loaded from the database
if needed. This lets old code that only has access to a Content object for
rendering use that Content object in a fake RevisionRecord, instead of
having to load the full revision from the database in all cases.

Bug: T174035
Change-Id: I658eab97a8282b8943baf7968f3256da35789ec1

3 years agoMerge "Introduce RevisionRecord::isReadForInsertion"
jenkins-bot [Tue, 11 Sep 2018 15:14:17 +0000 (15:14 +0000)]
Merge "Introduce RevisionRecord::isReadForInsertion"

3 years agoMerge "[MCR] Set MCR migration stage to write-both/read-new."
jenkins-bot [Tue, 11 Sep 2018 13:59:46 +0000 (13:59 +0000)]
Merge "[MCR] Set MCR migration stage to write-both/read-new."

3 years agoRemove xx-uca-et collation workaround
Pikne [Tue, 11 Sep 2018 13:30:06 +0000 (13:30 +0000)]
Remove xx-uca-et collation workaround

Remove workaround introduced in I3e8031b9. No longer needed.

Bug: T202977
Change-Id: I39921ef83cddc33535b99bd9c0b75f8afb52ea9a

3 years agoIntroduce RevisionRecord::isReadForInsertion
daniel [Mon, 10 Sep 2018 19:34:31 +0000 (21:34 +0200)]
Introduce RevisionRecord::isReadForInsertion

RevisionRecord::isReadForInsertion provides a concise way to check
whether a revision is complete enough to be inserted into the database.

Change-Id: I0c79f55c0b935bce9943163ed4c2cc8b5f9c82d5

3 years ago[MCR] Set MCR migration stage to write-both/read-new.
daniel [Wed, 4 Jul 2018 13:39:24 +0000 (15:39 +0200)]
[MCR] Set MCR migration stage to write-both/read-new.

This patch exists to see if CI passes with
$wgMultiContentRevisionSchemaMigrationStage set to
SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW.

NOTE: verify that $wgMultiContentRevisionSchemaMigrationStage
is explicitly set toSCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD
in production config (T197816) before merging this.

Bug: T198561
Depends-On: Ib718868d2c768b6ea851355eef047bc0e6593495
Change-Id: I15989adae2b5916577d164c50d7da88774e49324

3 years agoMerge "Add hooks to MediaWikiPHPUnitTestListener start/endTest"
jenkins-bot [Tue, 11 Sep 2018 09:48:47 +0000 (09:48 +0000)]
Merge "Add hooks to MediaWikiPHPUnitTestListener start/endTest"