lhc/web/wiklou.git
3 years agoAdd ICU mapping for versions 62 and 63
Reedy [Thu, 18 Oct 2018 19:03:59 +0000 (20:03 +0100)]
Add ICU mapping for versions 62 and 63

Change-Id: I5e1238e856d4149c30806e6b2cb3619c0c9c1dbf

3 years agoMerge "Fix jqueryMsg breaking when passed an undefined param"
jenkins-bot [Thu, 18 Oct 2018 17:36:13 +0000 (17:36 +0000)]
Merge "Fix jqueryMsg breaking when passed an undefined param"

3 years agoMerge "Revert "Introduce Special:RedirectExternal""
jenkins-bot [Thu, 18 Oct 2018 17:05:10 +0000 (17:05 +0000)]
Merge "Revert "Introduce Special:RedirectExternal""

3 years agoFix jqueryMsg breaking when passed an undefined param
Jakob Warkotsch [Thu, 18 Oct 2018 16:02:12 +0000 (18:02 +0200)]
Fix jqueryMsg breaking when passed an undefined param

This restores the behavior for undefined params as it was before
I445f9194bb8b2ed35baafbda30d1d0d008b64e2c

Bug: T207397
Change-Id: I751f01a9b3cd8bb87d7d7def98c918a87ddf81cd

3 years agoRevert "Introduce Special:RedirectExternal"
Kosta Harlan [Thu, 18 Oct 2018 16:15:21 +0000 (16:15 +0000)]
Revert "Introduce Special:RedirectExternal"

This reverts commit b83cf88837d589ae82a41fffb68dd82855aff2e5.

Reason for revert: Security concerns, needs some more nuance.

Change-Id: I5823c3da77accca9839f9632611315223e05351b

3 years agoMerge "ImagePage: Inherit parent's handling for action=render"
jenkins-bot [Thu, 18 Oct 2018 15:34:41 +0000 (15:34 +0000)]
Merge "ImagePage: Inherit parent's handling for action=render"

3 years agoMerge "Reword 'prefixindex-strip' to "Hide the prefix in results""
jenkins-bot [Thu, 18 Oct 2018 08:26:57 +0000 (08:26 +0000)]
Merge "Reword 'prefixindex-strip' to "Hide the prefix in results""

3 years agoImagePage: Inherit parent's handling for action=render
Bartosz Dziewoński [Thu, 18 Oct 2018 03:06:23 +0000 (05:06 +0200)]
ImagePage: Inherit parent's handling for action=render

ImagePage::render() was calling parent::view() instead of
parent::render(), thus skipping Article::render() entirely.
Therefore the logic to disable section edit links (and also,
to add an 'X-Robots-Tag: noindex' header) was not being used.
This fixes T65891 and T21415 for pages in 'File:' namespace.

Bug: T206546
Change-Id: I36ae716c9a363ae29b7a785cc41430301250baba

3 years agoNew hook ApiOptions
Max Semenik [Tue, 24 Jul 2018 22:05:22 +0000 (15:05 -0700)]
New hook ApiOptions

We need it to inform API clients they're changing globally overridden
preferences.

Bug: T198913
Change-Id: I692a1fb42b73d72814f31bfe9bd400c65f59d83c

3 years agoReword 'prefixindex-strip' to "Hide the prefix in results"
Bartosz Dziewoński [Thu, 18 Oct 2018 00:21:05 +0000 (02:21 +0200)]
Reword 'prefixindex-strip' to "Hide the prefix in results"

"Strip" is a very jargony term for removing something.

Translations of this message to the languages I can vaguely understand
all use the equivalents of "hide", "remove", or "display without".
Several translations to small languages I don't understand include the
word "strip" verbatim, which is almost certainly a mistake.

Bug: T76972
Change-Id: I6bf690773bfb2e5c6c35b3101733d1cd3e936e70

3 years agoDatabase: Allow selectFieldValues() to accept SQL fragments
Brad Jorsch [Wed, 17 Oct 2018 15:26:51 +0000 (11:26 -0400)]
Database: Allow selectFieldValues() to accept SQL fragments

The documentation says "This must be a valid SQL fragment", but as
written it breaks if given anything other than a field name. It's easy
enough to fix by adding an alias to the internal select() call.

Bug: T201781
Change-Id: I76428af6d3aadc266254fdb24109a0ac2db3761f

3 years agoMerge "Introduce Special:RedirectExternal"
jenkins-bot [Wed, 17 Oct 2018 22:12:52 +0000 (22:12 +0000)]
Merge "Introduce Special:RedirectExternal"

3 years agoMerge "mw.feedback: Remove a hack with passing message parameters"
jenkins-bot [Wed, 17 Oct 2018 21:54:12 +0000 (21:54 +0000)]
Merge "mw.feedback: Remove a hack with passing message parameters"

3 years agoIntroduce Special:RedirectExternal
Kosta Harlan [Wed, 17 Oct 2018 17:35:57 +0000 (13:35 -0400)]
Introduce Special:RedirectExternal

Special:RedirectExternal is an unlisted special page that accepts a URL as
the first argument, and redirects the user to that page.
Example: Special:RedirectExternal/https://mediawiki.org

At the moment, this is intended to be used by the GrowthExperiments project in
order to track outbound visits to certain external links. But it could be
extended in the future to provide parameters for showing a message to the user
before redirecting, or explicitly requiring a user to click on the link, which
could help improve security when users follow on-wiki links to off-wiki sites.

Bug: T207115
Change-Id: I822af14a84569aab22249e2f16a662a60e60f76a

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 17 Oct 2018 21:13:10 +0000 (23:13 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If357bae8816570dbccf5bbb42b040ad6de159e72

3 years agomw.feedback: Remove a hack with passing message parameters
Bartosz Dziewoński [Wed, 17 Oct 2018 20:33:54 +0000 (22:33 +0200)]
mw.feedback: Remove a hack with passing message parameters

I'm not sure what bug this is trying to work around. It mentions
T49395 but that doesn't look very relevant. Maybe the real problem was
confusion and bugs related to passing "raw params" (T33260#4675605).
Regardless, it's no longer needed now, because this code also works.

Change-Id: I580d46a5e4b7ff58989cb5fd6b7770e781fb5319

3 years agoMerge "jqueryMsg: Don't fall back to simple parser when jQuery params passed"
jenkins-bot [Wed, 17 Oct 2018 20:11:16 +0000 (20:11 +0000)]
Merge "jqueryMsg: Don't fall back to simple parser when jQuery params passed"

3 years agoMerge "rdbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries"
jenkins-bot [Wed, 17 Oct 2018 16:40:16 +0000 (16:40 +0000)]
Merge "rdbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries"

3 years agoMerge "Allow getRevisionText to function without the text table."
jenkins-bot [Wed, 17 Oct 2018 15:16:06 +0000 (15:16 +0000)]
Merge "Allow getRevisionText to function without the text table."

3 years agoAllow getRevisionText to function without the text table.
daniel [Sun, 30 Sep 2018 21:34:59 +0000 (23:34 +0200)]
Allow getRevisionText to function without the text table.

Without this patch, getRevisionText would fail silently (by
returning false) when the text table no longer gets joined,
due to the switch to the new MCR schema.

Bug: T205808
Change-Id: Iffc25c82a5d2b865c28070c76156d39d390cc675

3 years agoMerge "Inject Config into Parser instead of using globals"
jenkins-bot [Wed, 17 Oct 2018 14:34:31 +0000 (14:34 +0000)]
Merge "Inject Config into Parser instead of using globals"

3 years agoMerge "Force type Language for $lang of doEditSectionLink"
jenkins-bot [Wed, 17 Oct 2018 14:34:26 +0000 (14:34 +0000)]
Merge "Force type Language for $lang of doEditSectionLink"

3 years agoMerge "Force type Language for $lang of DifferenceEngine::setTextLanguage"
jenkins-bot [Wed, 17 Oct 2018 14:30:48 +0000 (14:30 +0000)]
Merge "Force type Language for $lang of DifferenceEngine::setTextLanguage"

3 years agordbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries
Aaron Schulz [Wed, 17 Oct 2018 05:36:06 +0000 (22:36 -0700)]
rdbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries

Change-Id: Ib5d15d90260f30d08f3641a7fb36d82d363b012c

3 years agoMerge "Add OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext"
jenkins-bot [Wed, 17 Oct 2018 05:00:54 +0000 (05:00 +0000)]
Merge "Add OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext"

3 years agoForce type Language for $lang of doEditSectionLink
Fomafix [Mon, 23 Jul 2018 19:50:14 +0000 (21:50 +0200)]
Force type Language for $lang of doEditSectionLink

Also make the parameter $tooltip mandatory to ensure that a mandatory
parameter does follow an optional parameter. ParserOutput always fill
all parameters of doEditSectionLink.

The call of wfGetLangObj( $lang ) is not necessary anymore.

This change is a follow-up to Id49201957e716ef8a2ea930b3616ca4fe6e35633.

Change-Id: Ic49d76c7d9357f99b462471696f7e1eb86e70e3d

3 years agoForce type Language for $lang of DifferenceEngine::setTextLanguage
Fomafix [Tue, 19 Jun 2018 19:48:40 +0000 (21:48 +0200)]
Force type Language for $lang of DifferenceEngine::setTextLanguage

Change-Id: I77e7116f81072fa42f580552e7b94323cfe31856

3 years agoAdd OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext
C. Scott Ananian [Thu, 27 Sep 2018 15:04:45 +0000 (11:04 -0400)]
Add OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext

This patch introduces a new method,
OutputPage::wrapWikiTextAsInterface(), which wraps the result of
OutputPage::addWikiTextAsInterface() in a tidy and robust way that
won't break if the wrapped message contains double newlines, extra
</div>, or other nasties.

This replaces a common unsafe pattern:
  $output->addWikiText( '<div class="..."' .... '</div>' );

Bug: T205624
Change-Id: I1040c7cf0ec1f5c4bef7c06d4486f50d85f2dc0f

3 years agoMerge "INSTALL, UPGRADE: Re-wrap to 80 chars and enforce"
jenkins-bot [Wed, 17 Oct 2018 03:17:56 +0000 (03:17 +0000)]
Merge "INSTALL, UPGRADE: Re-wrap to 80 chars and enforce"

3 years agoMerge "RELEASE-NOTES-1.32: Add entries for all changes to DefaultSettings.php"
jenkins-bot [Wed, 17 Oct 2018 02:46:00 +0000 (02:46 +0000)]
Merge "RELEASE-NOTES-1.32: Add entries for all changes to DefaultSettings.php"

3 years agoINSTALL, UPGRADE: Re-wrap to 80 chars and enforce
James D. Forrester [Wed, 13 Jun 2018 19:04:51 +0000 (12:04 -0700)]
INSTALL, UPGRADE: Re-wrap to 80 chars and enforce

Change-Id: Idabcc4db7a0b25448e7ad30641763e2b3e1a3160

3 years agoMerge "Prepare for REL1_32 cut, labelling master as 1.33-alpha"
jenkins-bot [Wed, 17 Oct 2018 01:52:30 +0000 (01:52 +0000)]
Merge "Prepare for REL1_32 cut, labelling master as 1.33-alpha"

3 years agoMerge "Follow-up 3481e3b2: Drop disablability of ExpiryInputWidget before 1.32 is...
jenkins-bot [Wed, 17 Oct 2018 01:46:31 +0000 (01:46 +0000)]
Merge "Follow-up 3481e3b2: Drop disablability of ExpiryInputWidget before 1.32 is cut"

3 years agoChange to “LESS” as it's the official name (again)
Volker E [Wed, 17 Oct 2018 00:42:05 +0000 (17:42 -0700)]
Change to “LESS” as it's the official name (again)

Make it unified with comments below.

Change-Id: I05e7a4269ed88a497a0072c5838a99fd15167f5d

3 years agoMerge "rdbms: re-add DB domain sanity checks to LoadBalancer"
jenkins-bot [Tue, 16 Oct 2018 23:54:38 +0000 (23:54 +0000)]
Merge "rdbms: re-add DB domain sanity checks to LoadBalancer"

3 years agordbms: re-add DB domain sanity checks to LoadBalancer
Aaron Schulz [Sat, 13 Oct 2018 16:14:20 +0000 (16:14 +0000)]
rdbms: re-add DB domain sanity checks to LoadBalancer

Also clean up empty schema handling in DatabaseDomain

This reverts commit f23ac02f4fcf156767df66a5df2fa407310fe1d2.

Bug: T193565
Change-Id: I95fde5c069f180ca888a023fade25ec81b846d44

3 years agoMerge "Selenium: record video of every test"
jenkins-bot [Tue, 16 Oct 2018 22:23:36 +0000 (22:23 +0000)]
Merge "Selenium: record video of every test"

3 years agoSelenium: record video of every test
Željko Filipin [Fri, 30 Mar 2018 16:42:04 +0000 (18:42 +0200)]
Selenium: record video of every test

In addition to two existing modes (headless and visible), this patch
introcues another mode, headless recording.

If DISPLAY environment variable is not set, Chrome will run in it's
built-in headless mode.
If it is set, and the value starts with colon (`:`), Chrome will
run in headless mode using Xvfb and record video of every test using FFmpeg.
If the value does not start with colon, Chrome will be visible.

Bug: T179188
Change-Id: Ic1723c5f2d57a28201caf6ba7056cb73fb74a957

3 years agomessagecache: check overridable message array in getMsgFromNamespace()
Aaron Schulz [Mon, 15 Oct 2018 15:08:24 +0000 (08:08 -0700)]
messagecache: check overridable message array in getMsgFromNamespace()

Follow up to a3d6c1411dad.

This avoids extra queries for messages that have a software defined value.

Bug: T193271
Change-Id: I25aa0e27200a0b417721cf1fbd34a82095405b89

3 years agoMerge "[Korean] Add 2 additional bookstoreList"
jenkins-bot [Tue, 16 Oct 2018 20:03:48 +0000 (20:03 +0000)]
Merge "[Korean] Add 2 additional bookstoreList"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 16 Oct 2018 19:55:58 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I44bc61d6e2147602329eeface6892e78db0388b2

3 years agoMerge "API: Allow prop=info intestactions to return reasons"
jenkins-bot [Tue, 16 Oct 2018 19:37:22 +0000 (19:37 +0000)]
Merge "API: Allow prop=info intestactions to return reasons"

3 years agoMerge "Migrate some wfWikiId() callers to getLocalDomainID()"
jenkins-bot [Tue, 16 Oct 2018 19:37:18 +0000 (19:37 +0000)]
Merge "Migrate some wfWikiId() callers to getLocalDomainID()"

3 years agoFollow-up 3481e3b2: Drop disablability of ExpiryInputWidget before 1.32 is cut
James D. Forrester [Thu, 4 Oct 2018 00:45:29 +0000 (17:45 -0700)]
Follow-up 3481e3b2: Drop disablability of ExpiryInputWidget before 1.32 is cut

No longer used anywhere(?); we'd rather not have to explain the temporary
variable in the MediaWiki 1.32.0 release notes if we can instead just not ship
it.

Bug: T192620
Change-Id: Icfb82f228512ed45f1a27ce3e565fbc5fc09f39c

3 years agojqueryMsg: Don't fall back to simple parser when jQuery params passed
Roan Kattouw [Mon, 15 Oct 2018 18:53:32 +0000 (11:53 -0700)]
jqueryMsg: Don't fall back to simple parser when jQuery params passed

jqueryMsg parsing is required when the message body contains wikitext,
but it is also required when one of the parameters is a jQuery object.

Without this change, the following doesn't work:
mw.messages.set( 'foo', 'Hello $1' );
mw.message( 'foo', $( '<a>' ).text( 'World' ) ).parse();

(But if the message contained e.g. {{PLURAL:}} syntax, it did work.)

Change-Id: I445f9194bb8b2ed35baafbda30d1d0d008b64e2c

3 years agoRELEASE-NOTES-1.32: Add entries for all changes to DefaultSettings.php
James D. Forrester [Thu, 4 Oct 2018 00:51:15 +0000 (17:51 -0700)]
RELEASE-NOTES-1.32: Add entries for all changes to DefaultSettings.php

Change-Id: Iae1122ef69940ca208d30dcd9554af8b7f60ac74

3 years agoAPI: Allow prop=info intestactions to return reasons
Brad Jorsch [Thu, 27 Sep 2018 15:04:24 +0000 (11:04 -0400)]
API: Allow prop=info intestactions to return reasons

T194585 raises a use case for callers to be able to know why an action
is not allowed. We can make that possible easily enough. The default
remains to return only a boolean.

This also deprecates inprop=readable in favor of intestactions=read,
since they both just return `$title->userCan( 'read', $user )`.

(ApiQueryInfoTest added by David Barratt)

Bug: T194585
Change-Id: Ib880f0605880eac776d816ea04e0c7ab9cfbaab1
Co-Authored-By: David Barratt <dbarratt@wikimedia.org>
3 years agoMerge "Update ImportableUploadRevisionImporter for interwiki usernames"
jenkins-bot [Tue, 16 Oct 2018 16:17:59 +0000 (16:17 +0000)]
Merge "Update ImportableUploadRevisionImporter for interwiki usernames"

3 years agoMerge "Have maintenance/updateExtensionJsonSchema.php copy documentation"
jenkins-bot [Tue, 16 Oct 2018 16:10:24 +0000 (16:10 +0000)]
Merge "Have maintenance/updateExtensionJsonSchema.php copy documentation"

3 years agoHave maintenance/updateExtensionJsonSchema.php copy documentation
Brad Jorsch [Tue, 16 Oct 2018 15:12:43 +0000 (11:12 -0400)]
Have maintenance/updateExtensionJsonSchema.php copy documentation

It already skips version-1 style documentation keys that begin with "@".
It should also copy them into the "description" metadata key for
version 2.

Change-Id: I460568f074b9c0256eb6bbbcd0b046b16e0d8790

3 years agoUpdate ImportableUploadRevisionImporter for interwiki usernames
Brad Jorsch [Tue, 16 Oct 2018 14:47:44 +0000 (10:47 -0400)]
Update ImportableUploadRevisionImporter for interwiki usernames

This was somehow missed in I5401941c.

Bug: T206013
Change-Id: Ia618b05329e6cbfca7c95d9161f12ba4150705c8

3 years agoAdd session_write_close() calls to SessionManager tests
Brad Jorsch [Tue, 16 Oct 2018 14:22:33 +0000 (10:22 -0400)]
Add session_write_close() calls to SessionManager tests

PHP 7.3 doesn't like it if session_id() is called when the session has
been started, so we need to be sure to close it first in a few tests.

Bug: T207112
Change-Id: Ief36c1bb7b5c9066f158b5bb0d6d785a7f7ddd3c

3 years agoAvoid fatals when the filter tags is empty
Amir Sarabadani [Tue, 16 Oct 2018 11:02:45 +0000 (13:02 +0200)]
Avoid fatals when the filter tags is empty

Bug: T194164
Change-Id: I418cbe2259e7c1622a58a4a310a3cd56873f16c3

3 years agoMigrate some wfWikiId() callers to getLocalDomainID()
Aaron Schulz [Mon, 15 Oct 2018 22:20:50 +0000 (15:20 -0700)]
Migrate some wfWikiId() callers to getLocalDomainID()

Change-Id: I33fe222b7ca66babd61610febaebcf52d3806a7d

3 years agoMerge "Simplify `list-style` property"
jenkins-bot [Tue, 16 Oct 2018 05:28:33 +0000 (05:28 +0000)]
Merge "Simplify `list-style` property"

3 years agoMerge "Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang"
jenkins-bot [Tue, 16 Oct 2018 03:04:06 +0000 (03:04 +0000)]
Merge "Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang"

3 years agoMerge "API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()"
jenkins-bot [Mon, 15 Oct 2018 23:07:47 +0000 (23:07 +0000)]
Merge "API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()"

3 years agoMerge "LocalisationCache: Avoid use of compact()"
jenkins-bot [Mon, 15 Oct 2018 22:34:25 +0000 (22:34 +0000)]
Merge "LocalisationCache: Avoid use of compact()"

3 years agoMerge "API: Remove long-deprecated methods (and one class)"
jenkins-bot [Mon, 15 Oct 2018 22:34:20 +0000 (22:34 +0000)]
Merge "API: Remove long-deprecated methods (and one class)"

3 years agoPrepare for REL1_32 cut, labelling master as 1.33-alpha
James D. Forrester [Mon, 15 Oct 2018 21:58:59 +0000 (14:58 -0700)]
Prepare for REL1_32 cut, labelling master as 1.33-alpha

Change-Id: I41c19a63d20dc4e734430ad4fe989fa5a9e18d62

3 years agoMerge "CREDITS: Bump for 1.32.0 release"
jenkins-bot [Mon, 15 Oct 2018 21:48:29 +0000 (21:48 +0000)]
Merge "CREDITS: Bump for 1.32.0 release"

3 years agoAPI: Remove long-deprecated methods (and one class)
Brad Jorsch [Wed, 10 Oct 2018 17:55:09 +0000 (13:55 -0400)]
API: Remove long-deprecated methods (and one class)

* ApiBase::profileIn() (deprecated in 1.25)
* ApiBase::profileOut() (deprecated in 1.25)
* ApiBase::safeProfileOut() (deprecated in 1.25)
* ApiBase::profileDBIn() (deprecated in 1.25)
* ApiBase::profileDBOut() (deprecated in 1.25)
* ApiBase::dieUsage() (deprecated in 1.29)
* ApiBase::dieUsageMsg() (deprecated in 1.29)
* ApiBase::dieUsageMsgOrDebug() (deprecated in 1.29)
* ApiBase::getErrorFromStatus() (deprecated in 1.29)
* ApiBase::parseMsg() (deprecated in 1.29)
* ApiBase::setWarning() (deprecated in 1.29)
* ApiPageSet::getInvalidTitles() (deprecated in 1.26)
* ApiQueryLogEvents::addLogParams() (deprecated in 1.25)
* ApiUsageException::getCodeString() (deprecated in 1.29)
* ApiUsageException::getMessageArray() (deprecated in 1.29)
* UsageException (deprecated in 1.29)

Change-Id: Iabb2589a29cc3b46624d31358f3a6bf7b3ccbd57

3 years agoLocalisationCache: Avoid use of compact()
Kunal Mehta [Mon, 15 Oct 2018 07:17:38 +0000 (00:17 -0700)]
LocalisationCache: Avoid use of compact()

In PHP 7.3, compact() now raises notices if the variable is undefined, which
is something that we expect. So we can check whether the key exists instead
of bothering with compat() and suppressing warnings.

Bug: T206979
Change-Id: I612049db4debd850a2e6d10bc631d31aa17be898

3 years agoFix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang
Edward Chernenko [Mon, 15 Oct 2018 01:39:29 +0000 (04:39 +0300)]
Fix warning in doEditSectionLink() caused by not-yet-unstubbed $wgLang

In ParserOutput::getText(), $wgLang can be a StubUserLang object,
which causes a typecheck warning in doEditSectionLink().

Solution is to replace $wgLang with $context->getLanguage(),
which is always a Language object.

Change-Id: I9945e1615c3f1b7ed5c7897b9f67d7ca0450ee50

3 years agoSimplify `list-style` property
Volker E [Mon, 15 Oct 2018 20:03:13 +0000 (13:03 -0700)]
Simplify `list-style` property

Using `none none` value is also working on older IEs, which had
issues with shorthand only `list-style: none`.

Change-Id: I7d4b075ac90fd902e0c0fbc3e11449faf71fe9b2

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 15 Oct 2018 19:57:04 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4b631605549ac3599ca01d59fa69e35fad6c879e

3 years agoCREDITS: Bump for 1.32.0 release
James D. Forrester [Fri, 12 Oct 2018 17:31:55 +0000 (10:31 -0700)]
CREDITS: Bump for 1.32.0 release

Change-Id: I2187346003a53874c559fcfe23ee94d822829794

3 years agoUse "break" instead of "continue" inside a switch
RazeSoldier [Mon, 15 Oct 2018 15:58:26 +0000 (23:58 +0800)]
Use "break" instead of "continue" inside a switch

"continue" statements in a switch are equivalent to "break". In PHP 7.3, will generate a warning.

Bug: T206974
Change-Id: I54bcec013ff52ab81bff09f8f7ef02f3944a5b7d

3 years agoAPI: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()
Brad Jorsch [Mon, 15 Oct 2018 15:21:44 +0000 (11:21 -0400)]
API: Ignore expired blocks in ApiQueryBase::showHiddenUsersAddBlockInfo()

This probably went unnoticed for so long because expired blocks are
regularly cleared as long as new blocks continue being issued, so people
found that the problem "fixed" itself.

Bug: T206944
Change-Id: I6559e1ec23f4469d19684b4d931913acbccb56d4

3 years agoMerge "EmailNotification: Add newline before minor edit text"
jenkins-bot [Mon, 15 Oct 2018 14:19:43 +0000 (14:19 +0000)]
Merge "EmailNotification: Add newline before minor edit text"

3 years agoMerge "resources: Register jquery.client as foreign resource and update to v2.0.1"
jenkins-bot [Mon, 15 Oct 2018 14:07:14 +0000 (14:07 +0000)]
Merge "resources: Register jquery.client as foreign resource and update to v2.0.1"

3 years agoMerge "Add MessagesShn.php"
jenkins-bot [Mon, 15 Oct 2018 13:48:07 +0000 (13:48 +0000)]
Merge "Add MessagesShn.php"

3 years agoAdd MessagesShn.php
Martin Urbanec [Sun, 14 Oct 2018 18:02:26 +0000 (20:02 +0200)]
Add MessagesShn.php

This localizes:
* namespaces
* special page names

Bug: T206917
Bug: T206921
Change-Id: I0d27746aca56849056098ffffa866954d97f133d

3 years agoresources: Register jquery.client as foreign resource and update to v2.0.1
Timo Tijhof [Mon, 15 Oct 2018 02:27:41 +0000 (03:27 +0100)]
resources: Register jquery.client as foreign resource and update to v2.0.1

Change-Id: Iec6414a1675dec4aeb5d9b66635d28670f094e42

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 14 Oct 2018 19:54:50 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I27647ca9376c400143ba52074322c4b50960db53

3 years agodocs: Remove outdated information from globals.txt
MGChecker [Sun, 14 Oct 2018 18:28:54 +0000 (20:28 +0200)]
docs: Remove outdated information from globals.txt

design.txt doesn't exist anymore.

Bug: T111283
Change-Id: Ibb67fb721060b325114e571ba3e470a607d98884

3 years agoMerge "jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()"
jenkins-bot [Sat, 13 Oct 2018 23:59:35 +0000 (23:59 +0000)]
Merge "jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 13 Oct 2018 07:49:22 +0000 (09:49 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5958a3381bd070c1cb7d79e6819b638418b87165

3 years agojobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()
Aaron Schulz [Sat, 13 Oct 2018 07:14:38 +0000 (00:14 -0700)]
jobqueue: clean up JobQueueDB::getCacheKey() to use makeGlobalKey()

Change-Id: I341720fda0d242c7822f78048cb49f63538d08bc

3 years agotravis: Remove PHP 7.2 from allowed failures
Kunal Mehta [Sat, 13 Oct 2018 06:47:42 +0000 (23:47 -0700)]
travis: Remove PHP 7.2 from allowed failures

It's now passing!

Bug: T204884
Change-Id: Idb17630cff54b803ca5fa942b2fcf17a775edd0d

3 years agoMerge "Output only to stderr in unit tests"
jenkins-bot [Sat, 13 Oct 2018 06:29:17 +0000 (06:29 +0000)]
Merge "Output only to stderr in unit tests"

3 years agoMerge "SlotDiffRenderer: add utility method for parameter type checks"
jenkins-bot [Sat, 13 Oct 2018 05:27:16 +0000 (05:27 +0000)]
Merge "SlotDiffRenderer: add utility method for parameter type checks"

3 years agoMerge "Linker: Document parseComment() as returning HTML"
jenkins-bot [Sat, 13 Oct 2018 05:23:43 +0000 (05:23 +0000)]
Merge "Linker: Document parseComment() as returning HTML"

3 years agoMerge "Log startAtomic()/endAtomic() to the query logger"
jenkins-bot [Sat, 13 Oct 2018 01:45:09 +0000 (01:45 +0000)]
Merge "Log startAtomic()/endAtomic() to the query logger"

3 years agoLog startAtomic()/endAtomic() to the query logger
Tim Starling [Wed, 10 Oct 2018 04:03:21 +0000 (15:03 +1100)]
Log startAtomic()/endAtomic() to the query logger

Change-Id: Ife7e292ef42946ec1c5e9121b7be6a90301b3903

3 years agoMerge "exception: Correct label "Notice" for E_USER_NOTICE, not "Warning""
jenkins-bot [Sat, 13 Oct 2018 00:58:16 +0000 (00:58 +0000)]
Merge "exception: Correct label "Notice" for E_USER_NOTICE, not "Warning""

3 years agoMerge "Revert "rdbms: add domain sanity checks to LoadBalancer connection methods""
jenkins-bot [Sat, 13 Oct 2018 00:58:11 +0000 (00:58 +0000)]
Merge "Revert "rdbms: add domain sanity checks to LoadBalancer connection methods""

3 years agoRevert "rdbms: add domain sanity checks to LoadBalancer connection methods"
Krinkle [Sat, 13 Oct 2018 00:35:55 +0000 (00:35 +0000)]
Revert "rdbms: add domain sanity checks to LoadBalancer connection methods"

This reverts commit b416e166a3eba1dcfc2e912e37e443981d7f60ef.

Fails on Travis CI / PHP 7.1 / Postgres:

> Creating administrator user account
>
> UnexpectedValueException:
> Got connection to 'traviswiki-mediawiki', but expected 'traviswiki'.
>
> Backtrace:
> #0 includes/libs/rdbms/loadbalancer/LoadBalancer.php(887): Wikimedia\Rdbms\LoadBalancer->openForeignConnection(integer, string, integer)
> #1 includes/libs/rdbms/loadbalancer/LoadBalancer.php(766): Wikimedia\Rdbms\LoadBalancer->openConnection(integer, string, integer)
> #2 includes/libs/rdbms/loadbalancer/LoadBalancer.php(851): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer)
> #3 includes/jobqueue/JobQueueDB.php(780): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer, array, string, integer)
> #4 includes/jobqueue/JobQueueDB.php(761): JobQueueDB->getDB(integer)
> #5 includes/jobqueue/JobQueueDB.php(187): JobQueueDB->getMasterDB()
> #6 includes/jobqueue/JobQueue.php(332): JobQueueDB->doBatchPush(array, integer)
> #7 includes/jobqueue/JobQueue.php(302): JobQueue->batchPush(array, integer)
> #8 includes/jobqueue/JobQueueGroup.php(154): JobQueue->push(array)
> #9 includes/user/UserGroupMembership.php(162): JobQueueGroup->push(array)
> #10 includes/user/User.php(3733): UserGroupMembership->insert(boolean)
> #11 includes/installer/Installer.php(1680): User->addGroup(string)
> #12 includes/installer/Installer.php(1601): Installer->createSysop(PostgresInstaller)
> #13 includes/installer/CliInstaller.php(176): Installer->performInstallation(array, array)

Change-Id: I269df89d47cc5a183af630447cd1642d3d4a3deb

3 years agoMerge "rdbms: add domain sanity checks to LoadBalancer connection methods"
Krinkle [Sat, 13 Oct 2018 00:08:28 +0000 (00:08 +0000)]
Merge "rdbms: add domain sanity checks to LoadBalancer connection methods"

3 years agoMerge "Avoid global $wgUpdateRowsPerQuery in WatchedItemStore"
jenkins-bot [Fri, 12 Oct 2018 22:35:49 +0000 (22:35 +0000)]
Merge "Avoid global $wgUpdateRowsPerQuery in WatchedItemStore"

3 years agoMerge "Add OOUI for HTMLFormFieldCloner"
jenkins-bot [Fri, 12 Oct 2018 22:30:59 +0000 (22:30 +0000)]
Merge "Add OOUI for HTMLFormFieldCloner"

3 years agoLinker: Document parseComment() as returning HTML
Roan Kattouw [Fri, 12 Oct 2018 22:18:03 +0000 (15:18 -0700)]
Linker: Document parseComment() as returning HTML

It's not entirely clear from the documentation whether this method
returns wikitext or HTML, so make it explicit.

Change-Id: I094e370e921c43dd8c5dc4376b3dddd803665d90

3 years agoMerge "Pass LBFactory to WatchedItemStore"
jenkins-bot [Fri, 12 Oct 2018 21:48:54 +0000 (21:48 +0000)]
Merge "Pass LBFactory to WatchedItemStore"

3 years agoMerge "HtmlTest: Perform multilingual tests"
jenkins-bot [Fri, 12 Oct 2018 18:59:28 +0000 (18:59 +0000)]
Merge "HtmlTest: Perform multilingual tests"

3 years agoMerge "Use a ScopedCallback to silence transaction profiler in SqlBagOStuff"
jenkins-bot [Fri, 12 Oct 2018 18:34:02 +0000 (18:34 +0000)]
Merge "Use a ScopedCallback to silence transaction profiler in SqlBagOStuff"

3 years agoHtmlTest: Perform multilingual tests
Erik Bernhardson [Fri, 12 Oct 2018 18:23:02 +0000 (11:23 -0700)]
HtmlTest: Perform multilingual tests

The tests here were only testing when user and content language
are the same, but the way things are rendered when they differ
is perhaps more interesting as it allows ensuring the two are used
in the correct places.

Change-Id: I357f50b082882fee485a95323d3a0a7cadb9a63c

3 years agoUse a ScopedCallback to silence transaction profiler in SqlBagOStuff
Umherirrender [Sat, 22 Sep 2018 12:38:02 +0000 (14:38 +0200)]
Use a ScopedCallback to silence transaction profiler in SqlBagOStuff

This affects most LCStoreDB which is the default cache
and spamming the log.

Bug: T154424
Bug: T97693
Change-Id: I68af177c7d0d88ab266eb3fefb4336eff86d861c

3 years agoDeprecate $wgUseKeyHeader and OutputPage::getKeyHeader()
C. Scott Ananian [Fri, 12 Oct 2018 15:50:14 +0000 (11:50 -0400)]
Deprecate $wgUseKeyHeader and OutputPage::getKeyHeader()

The `Key` header was a draft IETF specification which expired without
becoming a standard.  It does not appear to be in active use anywhere.

Change-Id: I3924a1b5ff428b107573d2827c40e4af8adaaeb1

3 years agoAvoid global $wgUpdateRowsPerQuery in WatchedItemStore
Umherirrender [Thu, 11 Oct 2018 19:13:35 +0000 (21:13 +0200)]
Avoid global $wgUpdateRowsPerQuery in WatchedItemStore

Change-Id: Ibff69d16919a595c3edb8e2b431aa42d84a2777a

3 years agoPass LBFactory to WatchedItemStore
Umherirrender [Thu, 11 Oct 2018 19:11:43 +0000 (21:11 +0200)]
Pass LBFactory to WatchedItemStore

Instead of passing the LoadBalancer and than get the LBFactory from the
service,
store the LBFactory on creation

Bug: T206601
Change-Id: I4c0d3712da591b2c5ddf2a65855d2cc9142417d2