4 years agoTest for Revision::newKnownCurrent
addshore [Fri, 10 Nov 2017 14:37:44 +0000 (14:37 +0000)]
Test for Revision::newKnownCurrent

Bug: T180210
Change-Id: I2cc83cbc91583b4631f4798dd14612c49024eeb4

4 years agoTests for Revision::decompressRevisionText
addshore [Fri, 10 Nov 2017 13:14:13 +0000 (13:14 +0000)]
Tests for Revision::decompressRevisionText

Bug: T180210
Change-Id: I21f6bb02757bcf59ce483e7d61685d372f134048

4 years agoRun RevisionIntegrationTest for both ContentHandlerUseDB settings
addshore [Tue, 24 Oct 2017 13:41:21 +0000 (14:41 +0100)]
Run RevisionIntegrationTest for both ContentHandlerUseDB settings

core used to have a test case that ran various Revision tests
with and without ContentHandlerUseDB set, however it did not
run due to the class / file having a bad name.

This patch reintroduces the running on Revision tests for both
ContentHandlerUseDB settings.

The global has to be set in setup / before the page used for
testing is created, else this page will be created with the
wrong values in the DB for use in the tests.

Change-Id: Ied1023e22eeac413fa86ea6946aa31619fd66319

4 years agoMake Revision::testIsUnpatrolled more reliable
addshore [Fri, 10 Nov 2017 13:46:44 +0000 (13:46 +0000)]
Make Revision::testIsUnpatrolled more reliable

Bug: T180210
Change-Id: Ib88c39527fafefdaafdb05c944716b5a1449cf1b

4 years agoMerge "Rewrite userOptions.php"
jenkins-bot [Fri, 10 Nov 2017 06:24:33 +0000 (06:24 +0000)]
Merge "Rewrite userOptions.php"

4 years agoMerge "Setup: Include StartProfiler before others"
jenkins-bot [Fri, 10 Nov 2017 04:23:41 +0000 (04:23 +0000)]
Merge "Setup: Include StartProfiler before others"

4 years agoMerge "Merge ProfilerFunctions into GlobalFunctions"
jenkins-bot [Fri, 10 Nov 2017 04:23:38 +0000 (04:23 +0000)]
Merge "Merge ProfilerFunctions into GlobalFunctions"

4 years agoMerge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Fri, 10 Nov 2017 01:07:59 +0000 (01:07 +0000)]
Merge "Sync up with Parsoid parserTests.txt"

4 years agoSetup: Include StartProfiler before others
Timo Tijhof [Fri, 10 Nov 2017 00:35:19 +0000 (16:35 -0800)]
Setup: Include StartProfiler before others

Bug: T180183
Change-Id: Ibcf78d094cf4dcf09bc919a5f8168f45ae225ebc

4 years agoMerge ProfilerFunctions into GlobalFunctions
Timo Tijhof [Fri, 10 Nov 2017 00:31:55 +0000 (16:31 -0800)]
Merge ProfilerFunctions into GlobalFunctions

Even if people use these (deprecated) functions in the earliest hooks or in
LocalSettings.php, it will keep working because GlobalFunctions is loaded
between DefaultSettings.php and LocalSettings.php.

The only places affected would be files in core: AutoLoader.php, Defines.php,
and DefaultSettings.php, which don't use these functions.

Change-Id: If4c0e8cbe1ea918283df22d72f792a3806569216

4 years agoUse the main stash for LBFactory "memStash" parameter
Aaron Schulz [Thu, 17 Aug 2017 03:13:35 +0000 (20:13 -0700)]
Use the main stash for LBFactory "memStash" parameter

This store is used for ChronologyProtector positions.
It should be cross-DC since the sticky DC cookie may not work
for rapid cross-wiki farm activity, causing some request go to
the non-primary DC.

NOTE: this change should be deployed on all farm wikis at once

Change-Id: Ife126592aacace696e43912b9461164a9ea98bc1

4 years agoSync up with Parsoid parserTests.txt
Arlo Breault [Fri, 10 Nov 2017 00:29:48 +0000 (19:29 -0500)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit 1d6c39d8f6f5972e72974f8d64e7a0a5c2288bf2

Change-Id: I38d9d47c9cd74257b9bedc892baad90146885ef4

4 years agoMerge "Add action/user tracking to html cache purge jobs"
jenkins-bot [Thu, 9 Nov 2017 22:33:48 +0000 (22:33 +0000)]
Merge "Add action/user tracking to html cache purge jobs"

4 years agoPopulateRecentChangesSource: remove unused variable
Max Semenik [Wed, 8 Nov 2017 03:23:29 +0000 (19:23 -0800)]
PopulateRecentChangesSource: remove unused variable

Change-Id: I0c1fb623ad508d604c0e7760c2133920ec9a81f8

4 years agoMerge "widgets.DateInputWidget: Enhance desktop UX cursor handling"
jenkins-bot [Thu, 9 Nov 2017 21:40:07 +0000 (21:40 +0000)]
Merge "widgets.DateInputWidget: Enhance desktop UX cursor handling"

4 years agoMerge "widgets.DateInputWidget Align design with WikimediaUI"
jenkins-bot [Thu, 9 Nov 2017 21:40:02 +0000 (21:40 +0000)]
Merge "widgets.DateInputWidget Align design with WikimediaUI"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 9 Nov 2017 21:38:25 +0000 (22:38 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic3b7173db986c1984b910f00fd95c6fcb761a296

4 years agowidgets.DateInputWidget: Enhance desktop UX cursor handling
Volker E [Wed, 23 Aug 2017 22:27:26 +0000 (15:27 -0700)]
widgets.DateInputWidget: Enhance desktop UX cursor handling

Enhance desktop experience with better cursor handling.

Bug: T169034
Depends-on: I4e0ca6c472e2d6ddbe64eb783acf8c38c5beacc4
Change-Id: Ie4c847caf727051ed5bbcf9937863b007e62d3c7

4 years agoMerge "Escape single quotes in attributes"
jenkins-bot [Thu, 9 Nov 2017 18:28:09 +0000 (18:28 +0000)]
Merge "Escape single quotes in attributes"

4 years agoAdd tests for various simple Revision get and is methods
addshore [Thu, 9 Nov 2017 11:45:51 +0000 (11:45 +0000)]
Add tests for various simple Revision get and is methods

These tests dont cover all code paths for these methods
in some cases but it does ensure that tests actually call
them / test basical functionality.

Some of these methods are touched in
hence adding some test coverage now.

Change-Id: I7eb67cb5876f89034238591c0a98f4ec6d890a40

4 years agoAdd tests for Revision::getTitle
addshore [Thu, 9 Nov 2017 10:36:22 +0000 (10:36 +0000)]
Add tests for Revision::getTitle

This method is touched in I4f24e7fbb683cb51f3fd8b250732bae9c7541ba2
hence adding some test coverage now.

Change-Id: Ie39a294546d84413bfb716efb27fd2c0321b349b

4 years agoAdd tests for Revision::getParentLengths
addshore [Thu, 9 Nov 2017 10:20:49 +0000 (10:20 +0000)]
Add tests for Revision::getParentLengths

This method name is quite missleading as it doesnt
get the parent lengths at all, it gets the lengths of
the rev ids that you ask for......

This method is touched in I4f24e7fbb683cb51f3fd8b250732bae9c7541ba2
hence adding some test coverage now.

Change-Id: Ic837bd60a34341860c4d2287a1b999f40d4f95f1

4 years agowidgets.DateInputWidget Align design with WikimediaUI
Volker E [Mon, 21 Aug 2017 02:58:04 +0000 (19:58 -0700)]
widgets.DateInputWidget Align design with WikimediaUI

Aligning DateInputWidget with WikimediaUI theme widgets by:
- using “Red50” color `#d33` from color palette,
- using standard dialog `box-shadow` value,
- ensure handle appearance is similar to standard TextInputWidget,
- align variable name,
- introduce similar variables from WikimediaUI theme, and also
- removing unnecessary properties.
Adding a `max-height` to address vendor specific UI elements for
`type=date` in Chrome.

Bug: T180094
Change-Id: I4e0ca6c472e2d6ddbe64eb783acf8c38c5beacc4

4 years agoRCFilters: some more highlight cleanup
Stephane Bisson [Thu, 9 Nov 2017 00:46:45 +0000 (19:46 -0500)]
RCFilters: some more highlight cleanup

Change-Id: I81eb3bf86f786c79a94e99d51602d904504f918f

4 years agoMerge "RCFilters: Don't reload the list if the change was highlights-only"
jenkins-bot [Thu, 9 Nov 2017 00:35:01 +0000 (00:35 +0000)]
Merge "RCFilters: Don't reload the list if the change was highlights-only"

4 years agoEscape single quotes in attributes
Max Semenik [Wed, 8 Nov 2017 01:45:56 +0000 (17:45 -0800)]
Escape single quotes in attributes

Replaces a long excuse in Html class not to call
Sanitizer::encodeAttribute() with a call to it.
In anything security related, excuses are a sign that you're doing
something wrong:)

Change-Id: Icf7f60d8cd6ea757d8f1999d638b82733001f68a

4 years agoRCFilters: Don't reload the list if the change was highlights-only
Moriel Schottlender [Thu, 12 Oct 2017 18:28:36 +0000 (11:28 -0700)]
RCFilters: Don't reload the list if the change was highlights-only

Bug: T164131
Change-Id: I9952467d0acef84a6445d970977c1265a3ebff95

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 8 Nov 2017 20:54:54 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I4f1007bfb2661ea9f18dc00e6795f102ed29c918

4 years agoMerge "Group messages in WANObjectCache by key"
jenkins-bot [Wed, 8 Nov 2017 20:28:23 +0000 (20:28 +0000)]
Merge "Group messages in WANObjectCache by key"

4 years agoGroup messages in WANObjectCache by key
Chad Horohoe [Wed, 8 Nov 2017 18:24:43 +0000 (10:24 -0800)]
Group messages in WANObjectCache by key

Change-Id: I31c570a095735c9157332660e9f1f542e679410f

4 years agoRemove trailing newline and period from message
Matthias Mullie [Wed, 8 Nov 2017 09:48:45 +0000 (10:48 +0100)]
Remove trailing newline and period from message

Change-Id: I3247edd22d12ea390cd969d8d89f84fa7b1dfdba

4 years agoMerge "Fix wrong variable in ShowSearchHit call."
jenkins-bot [Wed, 8 Nov 2017 09:22:25 +0000 (09:22 +0000)]
Merge "Fix wrong variable in ShowSearchHit call."

4 years agoFinish migration to Maintenance::getBatchSize()
Max Semenik [Wed, 8 Nov 2017 03:35:11 +0000 (19:35 -0800)]
Finish migration to Maintenance::getBatchSize()

Change-Id: I02d89f71d820e4d00a39e86a30397b614bbdb432

4 years agoRCFilters: Remove redundant replaceUpdatedUrl method
Moriel Schottlender [Thu, 2 Nov 2017 23:48:45 +0000 (16:48 -0700)]
RCFilters: Remove redundant replaceUpdatedUrl method

The method should call updateURL anyways. If it's initializing, the
comparison to the original URL will still be false and the system
will apply replaceState on the URL.

Change-Id: Ibfa104ed2aba94a5c17ed8ce3580a089d60e4d97

4 years agoFix wrong variable in ShowSearchHit call.
Stanislav Malyshev [Wed, 8 Nov 2017 00:33:38 +0000 (16:33 -0800)]
Fix wrong variable in ShowSearchHit call.

The code uses $size, which does not exist and never used otherwise.
The actual size HTML is stored in $desc.

Change-Id: Ida5e69c81acea6bdec75810cf7b192f9dc7cf327

4 years agoMerge "Timeout autoHide notifications based on visible time"
jenkins-bot [Tue, 7 Nov 2017 23:46:41 +0000 (23:46 +0000)]
Merge "Timeout autoHide notifications based on visible time"

4 years agoMerge "Update OOjs UI to v0.24.2"
jenkins-bot [Tue, 7 Nov 2017 23:29:16 +0000 (23:29 +0000)]
Merge "Update OOjs UI to v0.24.2"

4 years agoTimeout autoHide notifications based on visible time
Erik Bernhardson [Thu, 21 Sep 2017 16:13:01 +0000 (09:13 -0700)]
Timeout autoHide notifications based on visible time

On supported browsers handle the auto hide timeout with a
count of cumulative time the page has been visible to the
user. Old functionality can still be accessed, if desired,
by setting the visibleTimeout notification option to false.
On browsers without support for this visibilitychange event
wall clock time (the old behaviour) is used.

Adds a library function functionally similar to setTimeout that
only considers time when the page is visible. This is useful
both for analytics purposes, and when you want to temporarily
put something on screen and be reasonably certain it doesn't
go away until a user has seen it.

Bug: T42322
Change-Id: I7d8ea85602cae9cfc72e0155bc3092049ecafd43

4 years agoMerge "mw.special.apisandbox: Use a real button for "Auto-fill the token""
jenkins-bot [Tue, 7 Nov 2017 23:03:10 +0000 (23:03 +0000)]
Merge "mw.special.apisandbox: Use a real button for "Auto-fill the token""

4 years agoUpdate OOjs UI to v0.24.2
James D. Forrester [Tue, 7 Nov 2017 22:55:44 +0000 (14:55 -0800)]
Update OOjs UI to v0.24.2

Release notes:

Depends-On: I0e9d3f690349f9f01fb6424f9cb8468ebb21455a
Change-Id: I0e9d3f690349f9f01fb6424f9cb8468ebb21455b

4 years agoUpdate for Phan 0.10.1
Max Semenik [Sat, 4 Nov 2017 22:45:58 +0000 (15:45 -0700)]
Update for Phan 0.10.1

Change-Id: Id292944b80eb0c81956b203ce95bb0def3b4b0a3

4 years agomw.special.apisandbox: Use a real button for "Auto-fill the token"
Bartosz Dziewoński [Fri, 3 Mar 2017 20:03:39 +0000 (21:03 +0100)]
mw.special.apisandbox: Use a real button for "Auto-fill the token"

I've never liked this interface. It is not obvious what the little
triangle does. Let's just use words.

Change-Id: Ica477713adf67a6e1909629eae6b6ee8b35a48f6

4 years agoMerge "upload: Simplify UploadStashTest by using getNewTempFile()"
jenkins-bot [Tue, 7 Nov 2017 21:36:11 +0000 (21:36 +0000)]
Merge "upload: Simplify UploadStashTest by using getNewTempFile()"

4 years agoRewrite userOptions.php
Max Semenik [Fri, 6 Oct 2017 01:53:57 +0000 (18:53 -0700)]
Rewrite userOptions.php

* Convert to use Maintenance
* Clean up
* I want to use the class name UserOptions for something else
  so rename it.

Change-Id: Ic441087702376b1ca0e70554c71cdf7ecad908af

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 7 Nov 2017 21:02:28 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic0bf3eb6356c270bfa90bd0ade9a08af77de0c94

4 years agoMerge "RCFilters: Remove excluded params from URL"
jenkins-bot [Tue, 7 Nov 2017 20:44:24 +0000 (20:44 +0000)]
Merge "RCFilters: Remove excluded params from URL"

4 years agoRCFilters: Remove excluded params from URL
Moriel Schottlender [Thu, 2 Nov 2017 23:13:43 +0000 (16:13 -0700)]
RCFilters: Remove excluded params from URL

This was gone unnoticed in the previous upgrade of the UriProcessor
but should be reimplemented: excluded parameters (sticky) should be
excluded from the URL. They should be merged into the uri values so
that their **values** are passing through, but the eventual result
of the URI query itself should not have them.

Change-Id: I06bf2f4da54297e2ec6962dcadb7a4924351cc35

4 years agoMerge "Fix mergeMessageFileList.php --extensions-dir extensions:skins"
jenkins-bot [Tue, 7 Nov 2017 18:53:03 +0000 (18:53 +0000)]
Merge "Fix mergeMessageFileList.php --extensions-dir extensions:skins"

4 years agoMerge "Remove nbsp and similar characters from section IDs"
jenkins-bot [Tue, 7 Nov 2017 18:43:48 +0000 (18:43 +0000)]
Merge "Remove nbsp and similar characters from section IDs"

4 years agoMerge "Add render moved paragraphs marker in diff view"
jenkins-bot [Tue, 7 Nov 2017 18:12:44 +0000 (18:12 +0000)]
Merge "Add render moved paragraphs marker in diff view"

4 years agoFix mergeMessageFileList.php --extensions-dir extensions:skins
Niklas Laxström [Tue, 7 Nov 2017 17:45:17 +0000 (18:45 +0100)]
Fix mergeMessageFileList.php --extensions-dir extensions:skins

Only last directory of multiple was being used.

Follows up e74bc3b32effac7e0bbf9e314f4a6f15eedf7bff

Change-Id: I30190a30c387f1c34a41f9bbc033d421be631756

4 years agoMerge "Make it possible to override SpecialPreferences::showResetForm()"
jenkins-bot [Tue, 7 Nov 2017 17:36:44 +0000 (17:36 +0000)]
Merge "Make it possible to override SpecialPreferences::showResetForm()"

4 years agoMerge "Capitalise URL in uploadstash-file-not-found-no-remote-thumb"
jenkins-bot [Tue, 7 Nov 2017 16:54:05 +0000 (16:54 +0000)]
Merge "Capitalise URL in uploadstash-file-not-found-no-remote-thumb"

4 years agoRCFilters:Make bookmark icon gray when unavailable
petarpetkovic [Tue, 7 Nov 2017 11:28:05 +0000 (12:28 +0100)]
RCFilters:Make bookmark icon gray when unavailable

- Make bookmark icon gray out when unavailable instead of disappearing.
- Include a tooltip in the grayed out state only to say:
"These filters are already saved."

Bug: T179743
Change-Id: I3e4d711f9b8f2b0a2c1195c9d7632de417e6d0d5

4 years agoMake it possible to override SpecialPreferences::showResetForm()
Sam Wilson [Tue, 7 Nov 2017 03:15:24 +0000 (11:15 +0800)]
Make it possible to override SpecialPreferences::showResetForm()

Change-Id: I390e9d46fd2b8d4d8a1f9fd250c964a696b48244

4 years agoMerge "jquery3.js -> jquery.js"
jenkins-bot [Tue, 7 Nov 2017 07:11:56 +0000 (07:11 +0000)]
Merge "jquery3.js -> jquery.js"

4 years agoupload: Simplify UploadStashTest by using getNewTempFile()
Timo Tijhof [Tue, 7 Nov 2017 06:45:34 +0000 (22:45 -0800)]
upload: Simplify UploadStashTest by using getNewTempFile()

The parent class has a built-in list that tracks these files and
deletes them in a teardown.

I was unable to reproduce a case where $path + '.' is created by
MediaWiki. As far as I can tell, no current code exists in core
that would do this. If it does exist, we can keep the tearDown()
override with just that second case, but I'm removing it for now,
given it doesn't appear to be used.

Change-Id: I5847b7b266f1393d983aeb4b115bc0ae000e3547

4 years agojquery3.js -> jquery.js
Zach [Tue, 7 Nov 2017 05:06:28 +0000 (20:06 -0900)]
jquery3.js -> jquery.js

Per Krinkle's comment.

Change-Id: Ib8c78b47b6a700dcf753a7a1fd90d05d649f52d2

4 years agoMerge "Introduce Maintenance::getBatchSize()"
jenkins-bot [Tue, 7 Nov 2017 06:07:25 +0000 (06:07 +0000)]
Merge "Introduce Maintenance::getBatchSize()"

4 years agoMove edit font styles to separate module
Ed Sanders [Tue, 24 Oct 2017 15:29:26 +0000 (16:29 +0100)]
Move edit font styles to separate module

This allows pages that don't load mediawiki.legacy.shared
(e.g. MobileFrontend) to still have access to edit fonts.

Change-Id: Ifff40f756558e30f6551f29a945a31f0eef4cfed

4 years agoCapitalise URL in uploadstash-file-not-found-no-remote-thumb
Reedy [Mon, 6 Nov 2017 22:01:52 +0000 (22:01 +0000)]
Capitalise URL in uploadstash-file-not-found-no-remote-thumb

Bug: T179872
Change-Id: Ib32ffedd20fac4c79c333b9be8b96e6ace80ab65

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 6 Nov 2017 21:20:33 +0000 (22:20 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9153b70314bacb5fb0e6e979d9a3274d60f6bd29

4 years agoMerge "Ensure WCAG level AA contrast"
jenkins-bot [Mon, 6 Nov 2017 19:30:54 +0000 (19:30 +0000)]
Merge "Ensure WCAG level AA contrast"

4 years agoAdd missing @throws in doc
WMDE-Fisch [Mon, 6 Nov 2017 15:40:48 +0000 (16:40 +0100)]
Add missing @throws in doc

Change-Id: I978369a727d557db8650b32ec155a6b490c4c866

4 years agoi18n UploadStash exception messages
Matthias Mullie [Mon, 16 Oct 2017 15:29:37 +0000 (17:29 +0200)]
i18n UploadStash exception messages

In some cases, the error messages have changed slightly, mostly because
of capitalisation & punctuation.
In a few other cases (mainly UploadStashNotLoggedInException), the content
has also slightly changed (removed mention of the __METHOD__ it occurred in)

Bug: T178291
Change-Id: I184067f2d7fe0a0a2df1114d2525fd9ab95b6c86

4 years agoRework Upload*Exception classes to implement ILocalizedException
Cormac Parle [Mon, 9 Oct 2017 14:26:46 +0000 (15:26 +0100)]
Rework Upload*Exception classes to implement ILocalizedException

Bug: T154781
Change-Id: Ia64295d7ea502014586b8b8e3e3f34272b72443c

4 years agoMerge "Use Maintenance::setBatchSize() everywhere"
jenkins-bot [Mon, 6 Nov 2017 09:09:36 +0000 (09:09 +0000)]
Merge "Use Maintenance::setBatchSize() everywhere"

4 years agoMerge "Specify a blocker for all UserTest blocks"
jenkins-bot [Mon, 6 Nov 2017 02:48:57 +0000 (02:48 +0000)]
Merge "Specify a blocker for all UserTest blocks"

4 years agoIntroduce Maintenance::getBatchSize()
Max Semenik [Sun, 5 Nov 2017 08:09:51 +0000 (01:09 -0700)]
Introduce Maintenance::getBatchSize()

Just to isolate the internals. Fix most of usages in the core.

Change-Id: I8b3e9ca1f42b7c49ee57f17b88ca2fc7b404f342

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 5 Nov 2017 20:54:36 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib78fbd243c028637110c05371ec0d8b935e760a1

4 years agoSpecify a blocker for all UserTest blocks
Huji Lee [Mon, 18 Sep 2017 18:57:17 +0000 (14:57 -0400)]
Specify a blocker for all UserTest blocks

Also, un-register the PerofmrRetroactiveAutoblock hook from CheckUser
as it will assume an IP address for the user which is not specified in
UserTest. This will keep the unit tests focused on unit testing, as
opposed to integration.

Change-Id: I3a090f7bae5ba266c3cd4500ecf83338fb8503bb

4 years agoLanguage: Update git.wikimedia.org URLs to point to Phabricator
Zach [Sun, 5 Nov 2017 05:11:41 +0000 (21:11 -0800)]
Language: Update git.wikimedia.org URLs to point to Phabricator

Bug: T139089
Change-Id: I38492e0c8e90f3418bcb831f086fbe6ea2b319b5

4 years agoEnsure WCAG level AA contrast
Volker E [Sun, 5 Nov 2017 03:55:36 +0000 (20:55 -0700)]
Ensure WCAG level AA contrast

Increasing contrast on span.stats slightly to meet
WCAG level AA contrast minimum requirement on possible
background color `#f9f9f9`.
Also bringing selector in correct parent > child order.

Change-Id: If033cd61bd81dbd5773810b1a944f20a9bf2e58d

4 years agoUpdate the installphp.sh script to use a supported PHP version
mainframe98 [Wed, 26 Jul 2017 11:24:48 +0000 (13:24 +0200)]
Update the installphp.sh script to use a supported PHP version

It has been stuck on 5.4 since it was added to the repository
in 9e25a8e32e6d. It also contained some typos and updating
the version required multiple changes, so that has been fixed.

Bug: T165079
Change-Id: I30b4d6d0701dc60651d3c07fd364312a78a45800

4 years agoUse Maintenance::setBatchSize() everywhere
Max Semenik [Sat, 4 Nov 2017 23:10:06 +0000 (16:10 -0700)]
Use Maintenance::setBatchSize() everywhere

Change-Id: Id48b95c547ddd8ea02fb1c577203f17056f38402

4 years agoMerge "NamespaceInputWidget: Fix type documentation"
jenkins-bot [Sat, 4 Nov 2017 22:55:26 +0000 (22:55 +0000)]
Merge "NamespaceInputWidget: Fix type documentation"

4 years agoNamespaceInputWidget: Fix type documentation
Max Semenik [Sat, 4 Nov 2017 22:02:59 +0000 (15:02 -0700)]
NamespaceInputWidget: Fix type documentation

Change-Id: Ifc8e8be7bb7423d581f62427a4e48d70d73c714b

4 years agoRevert #contentSub and #jump-to-nav margin changes
Bartosz Dziewoński [Sat, 4 Nov 2017 22:27:36 +0000 (23:27 +0100)]
Revert #contentSub and #jump-to-nav margin changes

The reduced space between the subtitle and the article content
is apparently not desirable.

* Revert "Remove contentSub from layout when empty"
  This reverts commit 09e3ac0c3a816b77d041c249ccd5b8bb88ba8ef5.
* Revert "Fix margin of #jump-to-nav"
  This reverts commit 29b9ee20207b887006f38c85464f6019dae85b69.

Bug: T178626
Change-Id: I84c890511113752ab2dc3595b114cf7970860467

4 years agoMerge "Remove use of a nonexistent variable"
jenkins-bot [Sat, 4 Nov 2017 21:07:49 +0000 (21:07 +0000)]
Merge "Remove use of a nonexistent variable"

4 years agoMerge "Fix function annotiation"
jenkins-bot [Sat, 4 Nov 2017 21:07:46 +0000 (21:07 +0000)]
Merge "Fix function annotiation"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 4 Nov 2017 20:55:31 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I0bc816f03d3fb2909d9cebcef8c493eb10381865

4 years agoMerge "Align PNG fallbacks to WikimediaUI color palette"
jenkins-bot [Sat, 4 Nov 2017 11:53:06 +0000 (11:53 +0000)]
Merge "Align PNG fallbacks to WikimediaUI color palette"

4 years agoMerge "Optimize SVGs and align colors to WikimediaUI palette"
jenkins-bot [Sat, 4 Nov 2017 11:49:01 +0000 (11:49 +0000)]
Merge "Optimize SVGs and align colors to WikimediaUI palette"

4 years agoRemove use of a nonexistent variable
Max Semenik [Sat, 4 Nov 2017 07:47:29 +0000 (00:47 -0700)]
Remove use of a nonexistent variable

Was gone since I4c22666fb98 year and a half ago.

Change-Id: I7e2fb015310ea2541cd4a92133627b748507ef78

4 years agoFix function annotiation
Max Semenik [Sat, 4 Nov 2017 07:35:39 +0000 (00:35 -0700)]
Fix function annotiation

Change-Id: I4dfc62c8ef2226b46aa1eed508816377f6599ab2

4 years agoMerge "WikiPage::doModify: Reuse old revision while null-editing"
jenkins-bot [Sat, 4 Nov 2017 03:31:46 +0000 (03:31 +0000)]
Merge "WikiPage::doModify: Reuse old revision while null-editing"

4 years agoWikiPage::doModify: Reuse old revision while null-editing
Zhuyifei1999 [Sun, 5 Feb 2017 15:20:25 +0000 (15:20 +0000)]
WikiPage::doModify: Reuse old revision while null-editing

The expected behavior for a null-edit is that the cache gets fully
purged as if another edit has happened, without actually inserting
a new revision into the database. Old implementation was to create
a new Revision instance, copy some of the private instance properties
from the old Revision instance, and skip database insertion. This
method is, unfortunately, prone to errors, as hooks and parsers
expect the given revision data to be equal to whatever the latest
revision is in the database, including timestamp and edit summary.

An alternative solution would be to maintain a method that copies
all the needed data from one revision to another; however, the extra
maintenance cost would be that it would be annoying to maintain it.
This implementation simply reuses the old Revision instance given
by the caller (WikiPage::doEditContent), as it is the latest
revision that hooks and parsers expect.

This patch fixes the error where, after null-editing, the
revision-related magic words, such as {{REVISIONDAY}}, are changed
to the values given by the null edit, instead of the latest revision.
Old behavior was caused by the parser parsing with incorrect
revision data.

Deprecate Revision::setUserIdAndName. It was a hack added in
147f79e for the same bug, addressing {{REVISIONUSER}}, but failed
to address the other magic words, including {{REVISIONDAY}}. I
failed to find any other usage of this instance method.

Bug: T135261
Change-Id: Ifce6a753effb98123574bff45ff59b5c9780f0c2

4 years agoAlign PNG fallbacks to WikimediaUI color palette
Volker E [Sat, 4 Nov 2017 00:49:51 +0000 (17:49 -0700)]
Align PNG fallbacks to WikimediaUI color palette

Follow-up to Ia693b2092bbb730

Change-Id: If81043a7205c348a98fadbc6834e1789bf8a7926

4 years agoFix grouping for remaining logger calls in SwiftFileBackend
Chad Horohoe [Fri, 3 Nov 2017 17:55:09 +0000 (10:55 -0700)]
Fix grouping for remaining logger calls in SwiftFileBackend

Change-Id: I80ad8424de3e2a6a0c4b5e69537012a8f775cd68

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 3 Nov 2017 20:55:08 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I0b488756abb4de41488959c0fa581913c333da13

4 years agoGroup lock failed messages in mysql db driver
Chad Horohoe [Fri, 3 Nov 2017 16:05:59 +0000 (09:05 -0700)]
Group lock failed messages in mysql db driver

Change-Id: Ia8c993a3c405c37200c6c1a0dbe6b12726def7c1

4 years agoRemove nbsp and similar characters from section IDs
Max Semenik [Fri, 3 Nov 2017 02:35:11 +0000 (19:35 -0700)]
Remove nbsp and similar characters from section IDs

Bug: T90902
Change-Id: I71bdb7dd43c3e532287290e3c691d9739da45475

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 2 Nov 2017 21:16:21 +0000 (22:16 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Id10c52b19c7d9ceb49ac8c30856ace0f868f4894

4 years agoOutputPage: Hard-deprecate setSquidMaxage, renamed since 1.27
James D. Forrester [Thu, 2 Nov 2017 18:48:15 +0000 (11:48 -0700)]
OutputPage: Hard-deprecate setSquidMaxage, renamed since 1.27

Renamed and deprecated in MediaWiki in f606fd8d since 1.27.

Only six uses in Wikimedia-hosted git repositories, marked as
dependencies. Also one use snuck back into MediaWiki itself,
fixed in this patch.

Depends-On: Ie8c13a6b1dc1b7861f6c27bbba996099375f066b
Depends-On: Ic2ea90343efda6533c06ca1325bc85d9aa776078
Depends-On: Ibba2f486f0ecb684ded7efb09f9942f5e0f5fd7a
Depends-On: Id27a48e10fd127e00f68e1020e8f40e30ba9a251
Depends-On: Ifd6db7910a71bb700484d6b588327424f11c00e0
Depends-On: I6523059941eb5f86274e364a8d5cc74b849655a4
Change-Id: I2cdfcd60fc7934830e3e6ec132958aa2aa1fe486

4 years agoMerge "Make filter area togglable"
jenkins-bot [Thu, 2 Nov 2017 10:46:51 +0000 (10:46 +0000)]
Merge "Make filter area togglable"

4 years agoMerge "More specific warning when RC page fails to load"
jenkins-bot [Thu, 2 Nov 2017 10:26:50 +0000 (10:26 +0000)]
Merge "More specific warning when RC page fails to load"

4 years agoMerge "DifferenceEngine: Add debug text for native PHP diffs"
jenkins-bot [Thu, 2 Nov 2017 06:54:36 +0000 (06:54 +0000)]
Merge "DifferenceEngine: Add debug text for native PHP diffs"

4 years agoDifferenceEngine: Add debug text for native PHP diffs
Kunal Mehta [Thu, 2 Nov 2017 06:36:11 +0000 (23:36 -0700)]
DifferenceEngine: Add debug text for native PHP diffs

Change-Id: I004844989dfd98083f4b1f8722f6a142d47928e9

4 years agoMerge "Add attributes parameter to ShowSearchHitTitle"
jenkins-bot [Thu, 2 Nov 2017 05:40:05 +0000 (05:40 +0000)]
Merge "Add attributes parameter to ShowSearchHitTitle"

4 years agoMerge "Clean up "bad parameter" error messages in Message handler"
jenkins-bot [Wed, 1 Nov 2017 22:34:36 +0000 (22:34 +0000)]
Merge "Clean up "bad parameter" error messages in Message handler"