lhc/web/wiklou.git
7 years agoMove atj in RELEASE-NOTES-1.29 to language section
Reedy [Sun, 2 Apr 2017 23:47:44 +0000 (00:47 +0100)]
Move atj in RELEASE-NOTES-1.29 to language section

Change-Id: I5ca54f5c749d2c65435647f1e8737fa139e641a9

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 2 Apr 2017 19:53:56 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4e9b249b425cdd6cd5ccda7d63a4d61748c387c5

7 years agoTweak Parsoid CSS for images with borders
Subramanya Sastry [Sun, 2 Apr 2017 04:00:20 +0000 (23:00 -0500)]
Tweak Parsoid CSS for images with borders

* This fixes rendering diffs seen in visual diff testing.

Change-Id: I15f469b580d5d05d764a22d88b06237ce3571b62

7 years agoRelease notes for CACHE_ANYTHING being CACHE_NONE (c5a0fa5bed4c)
Brian Wolff [Sat, 1 Apr 2017 21:45:13 +0000 (21:45 +0000)]
Release notes for CACHE_ANYTHING being CACHE_NONE (c5a0fa5bed4c)

Change-Id: I88d967b73e623d25249a14c286eee7a9a98bd3f3

7 years agoRelease notes for no <html> in system messages (1c7889446)
Brian Wolff [Sat, 1 Apr 2017 20:39:06 +0000 (20:39 +0000)]
Release notes for no <html> in system messages (1c7889446)

Change-Id: I501d00974c6a5c00b36d070ca3d0495971529ed7

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 1 Apr 2017 19:54:23 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib10af896efdc2a9e354ca77776b17bb546357518

7 years agoMerge "mw.widgets.TitleOptionWidget: Apply styles for redirects/disambiguation links"
jenkins-bot [Sat, 1 Apr 2017 15:37:50 +0000 (15:37 +0000)]
Merge "mw.widgets.TitleOptionWidget: Apply styles for redirects/disambiguation links"

7 years agomediawiki.libs.jpegmeta.js: Map mediaWiki to mw in closure
Fomafix [Sat, 1 Apr 2017 07:28:28 +0000 (09:28 +0200)]
mediawiki.libs.jpegmeta.js: Map mediaWiki to mw in closure

Change-Id: I938b4a36058a9549ceedf5785eb1494247227a70

7 years agoMerge "ObjectFactory: Complete code coverage for ObjectFactoryTest"
jenkins-bot [Sat, 1 Apr 2017 02:59:01 +0000 (02:59 +0000)]
Merge "ObjectFactory: Complete code coverage for ObjectFactoryTest"

7 years agoMerge "objectcache: Complete code coverage for HashBagOStuff"
jenkins-bot [Sat, 1 Apr 2017 02:57:18 +0000 (02:57 +0000)]
Merge "objectcache: Complete code coverage for HashBagOStuff"

7 years agoMerge "resourceloader: Complete code coverage for MessageBlobStore"
jenkins-bot [Sat, 1 Apr 2017 02:56:46 +0000 (02:56 +0000)]
Merge "resourceloader: Complete code coverage for MessageBlobStore"

7 years agoMerge "phpunit: Remove unused assertNotTag() and assertTag() overrides"
jenkins-bot [Sat, 1 Apr 2017 02:51:00 +0000 (02:51 +0000)]
Merge "phpunit: Remove unused assertNotTag() and assertTag() overrides"

7 years agoMerge "changes: Remove assertTag from RCCacheEntryFactoryTest"
jenkins-bot [Sat, 1 Apr 2017 02:48:40 +0000 (02:48 +0000)]
Merge "changes: Remove assertTag from RCCacheEntryFactoryTest"

7 years agoMerge "resourceloader: Improve code coverage for WikiModuleTest"
jenkins-bot [Sat, 1 Apr 2017 02:46:50 +0000 (02:46 +0000)]
Merge "resourceloader: Improve code coverage for WikiModuleTest"

7 years agoMerge "FauxRequest: Complete code coverage for FauxRequestTest"
jenkins-bot [Sat, 1 Apr 2017 02:43:37 +0000 (02:43 +0000)]
Merge "FauxRequest: Complete code coverage for FauxRequestTest"

7 years agoresourceloader: Improve code coverage for WikiModuleTest
Timo Tijhof [Sat, 1 Apr 2017 01:35:09 +0000 (18:35 -0700)]
resourceloader: Improve code coverage for WikiModuleTest

preloadTitleInfo:
* Add missing case for empty $moduleNames.
* Add missing case for invalid page names.

getContent:
* Add missing case for bad title
* Add missing case for dead redirect.
* Add missing case for no content found.

Change-Id: I44dde13cb0db19d91c4ff15a5abefd17353cad90

7 years agoFauxRequest: Complete code coverage for FauxRequestTest
Timo Tijhof [Sat, 1 Apr 2017 01:22:58 +0000 (18:22 -0700)]
FauxRequest: Complete code coverage for FauxRequestTest

Follows-up d18d030d57b88.

* Add missing case of session being a Session object.

Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e

7 years agoHtml: Add a few @covers for HtmlTest
Timo Tijhof [Sat, 1 Apr 2017 01:13:09 +0000 (18:13 -0700)]
Html: Add a few @covers for HtmlTest

Change-Id: I0804e87ebc732d7adf082915af6d137f82f310b6

7 years agoObjectFactory: Complete code coverage for ObjectFactoryTest
Timo Tijhof [Sat, 1 Apr 2017 01:07:59 +0000 (18:07 -0700)]
ObjectFactory: Complete code coverage for ObjectFactoryTest

Cover missing case of expandClosures() where the array contains
both a closure and a non-closure.

Change-Id: I30ea8cf3fb909a499a95bf9bd24792f4dd6b5c64

7 years agoobjectcache: Complete code coverage for HashBagOStuff
Timo Tijhof [Sat, 1 Apr 2017 01:03:17 +0000 (18:03 -0700)]
objectcache: Complete code coverage for HashBagOStuff

Change-Id: I06cb9778df8239706bf82c0c39cccb419eade4b2

7 years agoresourceloader: Complete code coverage for MessageBlobStore
Timo Tijhof [Sat, 1 Apr 2017 00:58:43 +0000 (17:58 -0700)]
resourceloader: Complete code coverage for MessageBlobStore

Change-Id: I6269843ed51c67bf2d300eb58a613122ffdae740

7 years agoMerge "objectcache: Never use CACHE_NONE for CACHE_ANYTHING"
jenkins-bot [Sat, 1 Apr 2017 00:33:56 +0000 (00:33 +0000)]
Merge "objectcache: Never use CACHE_NONE for CACHE_ANYTHING"

7 years agoMerge "ResourceLoaderModuleTest: Exchange expected and actual parameter"
jenkins-bot [Sat, 1 Apr 2017 00:31:46 +0000 (00:31 +0000)]
Merge "ResourceLoaderModuleTest: Exchange expected and actual parameter"

7 years agophpunit: Remove unused assertNotTag() and assertTag() overrides
Timo Tijhof [Fri, 31 Mar 2017 23:32:24 +0000 (16:32 -0700)]
phpunit: Remove unused assertNotTag() and assertTag() overrides

Deprecated since PHPUnit 4.2, we use PHPUnit 4.8 and would like
to be compatible with PHPUnit 5 which no longer has this method.

The current hack was only enough to avoid the deprecation warning,
the underlying logic in Xml::findNodes() was also removed in PHPUnit 5.

Follows-up 23ec64745cdba0522f70, T71505.

* assertNotTag() is not used anywhere in Wikimedia Git.
* assertTag() was used in 1 test in core, fixed in the parent commit.
  Match in mediawiki/skins/chameleon is unrelated.

Change-Id: I56b8f1f88124d69190938fc522ea75419e96c49c

7 years agochanges: Remove assertTag from RCCacheEntryFactoryTest
Timo Tijhof [Fri, 31 Mar 2017 23:57:05 +0000 (16:57 -0700)]
changes: Remove assertTag from RCCacheEntryFactoryTest

Use PHPUnit's Xml::load() to validate that all tags and attributes
are balanced.

Use simple assertEquals or assertRegexp for the specific parts.

Change-Id: I25796954a3bb9903e88256b8345ef751c767d7d5

7 years agoMerge "API: Allow returning parse warnings for action=parse"
jenkins-bot [Fri, 31 Mar 2017 22:01:28 +0000 (22:01 +0000)]
Merge "API: Allow returning parse warnings for action=parse"

7 years agomw.widgets.TitleOptionWidget: Apply styles for redirects/disambiguation links
Bartosz Dziewoński [Fri, 31 Mar 2017 20:33:34 +0000 (22:33 +0200)]
mw.widgets.TitleOptionWidget: Apply styles for redirects/disambiguation links

Bug: T63072
Change-Id: I3e0b67b021c6ad42f131a5c9d3d0d5053d4316a0

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 31 Mar 2017 20:34:04 +0000 (22:34 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Idfecf37225dbcb6d02fcb7988263437dbb01af16

7 years agoResourceLoaderModuleTest: Exchange expected and actual parameter
Fomafix [Fri, 31 Mar 2017 13:24:14 +0000 (15:24 +0200)]
ResourceLoaderModuleTest: Exchange expected and actual parameter

For assertEquals of PHPUnit the first parameter is $expected and the second
parameter is $actual.
https://phpunit.de/manual/current/en/appendixes.assertions.html#appendixes.assertions.assertEquals

Change-Id: Iad4b37ee74a03aa00f2dc14d3c474796b3191b51

7 years agoAPI: Allow returning parse warnings for action=parse
Baha [Fri, 31 Mar 2017 18:59:35 +0000 (11:59 -0700)]
API: Allow returning parse warnings for action=parse

Passing in the 'parsewarnings' property will return warnings related
to parsing content.

Bug: T92634
Change-Id: I7e54765ee9a24ffb78e7763f73a520151023baf6

7 years agoMerge "RCFilters: Remove isAllowedCallable and isAllowed"
jenkins-bot [Fri, 31 Mar 2017 18:24:57 +0000 (18:24 +0000)]
Merge "RCFilters: Remove isAllowedCallable and isAllowed"

7 years agoRCFilters: Remove isAllowedCallable and isAllowed
Matthew Flaschen [Fri, 31 Mar 2017 05:07:31 +0000 (01:07 -0400)]
RCFilters: Remove isAllowedCallable and isAllowed

This is pretty fragile; it's easy to accidentally miss one of the
checks (as has already happened in e.g. parseParameters).

Although I don't yet know of any bugs as a result of this, it's
cleaner to do it at registration time.

There are no extensions using this feature.

Change-Id: I8547ea6432cae73e1bc272dbe959f2415b8a6d21

7 years agoMerge "SECURITY: Disable <html> tag on system messages despite $wgRawHtml = true;"
jenkins-bot [Fri, 31 Mar 2017 05:10:22 +0000 (05:10 +0000)]
Merge "SECURITY: Disable <html> tag on system messages despite $wgRawHtml = true;"

7 years agomediawiki.util: Add module export to support require()
jdlrobson [Thu, 24 Dec 2015 00:10:46 +0000 (16:10 -0800)]
mediawiki.util: Add module export to support require()

This allows mediawiki.util to be used with require() and
to bring attention to an alternative code pattern
that other developers may wish to adopt.

Bug: T140384
Change-Id: I8a4323bd56476caccb559b15ca543d64c5281f7c

7 years agoUpdate OOjs UI to v0.20.2
Volker E [Thu, 30 Mar 2017 21:40:55 +0000 (14:40 -0700)]
Update OOjs UI to v0.20.2

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.20.2

Change-Id: Ib79bda91982de97425b6a025b18299ec8693255d

7 years agoMerge "Use consistent spaces at start and end of comments"
jenkins-bot [Thu, 30 Mar 2017 21:22:09 +0000 (21:22 +0000)]
Merge "Use consistent spaces at start and end of comments"

7 years agoMerge "Add closure around moment-locale-overrides.js"
jenkins-bot [Thu, 30 Mar 2017 20:36:38 +0000 (20:36 +0000)]
Merge "Add closure around moment-locale-overrides.js"

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 30 Mar 2017 20:16:21 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia2c8ceda86ed0cfcc66d5be2c9b7653931379245

7 years agoUse consistent spaces at start and end of comments
Fomafix [Thu, 30 Mar 2017 19:53:50 +0000 (21:53 +0200)]
Use consistent spaces at start and end of comments

Change-Id: Idbb09b69aa1ef4e46433319aaea62f34f0dbc038

7 years agoAdd closure around moment-locale-overrides.js
Fomafix [Thu, 30 Mar 2017 19:30:14 +0000 (21:30 +0200)]
Add closure around moment-locale-overrides.js

Change-Id: I262d53479ab7971323db12d345fc0cd343b1df5e

7 years agoMerge "Implement WikiPage::getOldestRevision() in terms of Title::getFirstRevision()"
jenkins-bot [Thu, 30 Mar 2017 18:36:33 +0000 (18:36 +0000)]
Merge "Implement WikiPage::getOldestRevision() in terms of Title::getFirstRevision()"

7 years agoMerge "build: Bump grunt-banana-checker from 0.5.0 to 0.6.0"
jenkins-bot [Thu, 30 Mar 2017 18:16:18 +0000 (18:16 +0000)]
Merge "build: Bump grunt-banana-checker from 0.5.0 to 0.6.0"

7 years agoSync up with Parsoid parserTests.txt
Arlo Breault [Thu, 30 Mar 2017 14:23:17 +0000 (10:23 -0400)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit b1b271460c341e844e21641b5307794cf4dd7feb

Change-Id: I792787b38c464efcb8c68b66b52a4dc9a0b41c36

7 years agoMerge "Follow-up If0588439: Fix color of active & visited selflinks"
jenkins-bot [Thu, 30 Mar 2017 13:23:03 +0000 (13:23 +0000)]
Merge "Follow-up If0588439: Fix color of active & visited selflinks"

7 years agoMerge "Avoid database access in ImportTitleFactory tests dataProviders"
jenkins-bot [Thu, 30 Mar 2017 12:35:31 +0000 (12:35 +0000)]
Merge "Avoid database access in ImportTitleFactory tests dataProviders"

7 years agoMerge "Don't create user in AuthManagerTest dataProvider"
jenkins-bot [Thu, 30 Mar 2017 12:33:14 +0000 (12:33 +0000)]
Merge "Don't create user in AuthManagerTest dataProvider"

7 years agoFollow-up If0588439: Fix color of active & visited selflinks
Ed Sanders [Thu, 30 Mar 2017 10:54:49 +0000 (11:54 +0100)]
Follow-up If0588439: Fix color of active & visited selflinks

Bug: T160480
Change-Id: I3efb0705ad2365f676df41b0166403b8f43f19a5

7 years agoMerge "Revert "Remove old remapping hacks from Database::indexName()""
jenkins-bot [Thu, 30 Mar 2017 02:32:53 +0000 (02:32 +0000)]
Merge "Revert "Remove old remapping hacks from Database::indexName()""

7 years agoMerge "Update psy/psysh 0.8.1 -> 0.8.3"
jenkins-bot [Thu, 30 Mar 2017 02:06:16 +0000 (02:06 +0000)]
Merge "Update psy/psysh 0.8.1 -> 0.8.3"

7 years agoMerge "Update phpunit 4.8.31 -> 4.8.35"
jenkins-bot [Thu, 30 Mar 2017 01:53:05 +0000 (01:53 +0000)]
Merge "Update phpunit 4.8.31 -> 4.8.35"

7 years agoobjectcache: Never use CACHE_NONE for CACHE_ANYTHING
Brian Wolff [Wed, 15 Mar 2017 22:51:13 +0000 (22:51 +0000)]
objectcache: Never use CACHE_NONE for CACHE_ANYTHING

If $wgMainCacheType = CACHE_ACCEL, but there is no APC, then its
possible that CACHE_ANYTHING will default to CACHE_NONE because
that's what CACHE_ACCEL would do.

Possibly also T147161

Bug: T160519
Change-Id: I9ac2d071437b35a0f9cd3678e2279628f7b1931e

7 years agoUpdate phpunit 4.8.31 -> 4.8.35
Reedy [Thu, 30 Mar 2017 01:11:56 +0000 (02:11 +0100)]
Update phpunit 4.8.31 -> 4.8.35

Change-Id: I909466567b9f66dc391258ca7f7bac12ce98b23c

7 years agoUpdate psy/psysh 0.8.1 -> 0.8.3
Reedy [Thu, 30 Mar 2017 01:09:15 +0000 (02:09 +0100)]
Update psy/psysh 0.8.1 -> 0.8.3

https://github.com/bobthecow/psysh/releases/tag/v0.8.2
https://github.com/bobthecow/psysh/releases/tag/v0.8.3

https://github.com/bobthecow/psysh/compare/v0.8.1...v0.8.3

Change-Id: Ief2e0444d6e79df4433172d00d2db2b137bc2bb2

7 years agoLinker: Render selflinks as href-less classed <a>s, not <strong>s
James D. Forrester [Thu, 16 Mar 2017 22:19:36 +0000 (15:19 -0700)]
Linker: Render selflinks as href-less classed <a>s, not <strong>s

Self-links are still semantically links, and representing them as <strong>s
is inelegant and more important a real pain to work with, especially in
contexts where they may change state (like inside an editor).

Instead, render them as <a>, with no href to avoid user agent style over-
rides and with a class to style them as before, named 'mw-selflink' to go
with 'mw-redirect'. This allows much easier adjustment later. The old CSS
class 'selflink' is retained for backwards compatibility, but deprecated.

Bug: T160480
Change-Id: If058843924c3b30c116df2520aef93a004d98a5d

7 years agoMerge "Update OOjs UI to v0.20.1"
jenkins-bot [Wed, 29 Mar 2017 20:48:46 +0000 (20:48 +0000)]
Merge "Update OOjs UI to v0.20.1"

7 years agoMerge "EditPage: Refactor getCheckboxes() to allow changing the format"
jenkins-bot [Wed, 29 Mar 2017 20:39:07 +0000 (20:39 +0000)]
Merge "EditPage: Refactor getCheckboxes() to allow changing the format"

7 years agoMerge "ResourceLoaderImage: Correctly ignore 'deprecated' key"
jenkins-bot [Wed, 29 Mar 2017 20:06:58 +0000 (20:06 +0000)]
Merge "ResourceLoaderImage: Correctly ignore 'deprecated' key"

7 years agoMerge "Special:RecentChangesLinked show "no results" message"
jenkins-bot [Wed, 29 Mar 2017 20:06:03 +0000 (20:06 +0000)]
Merge "Special:RecentChangesLinked show "no results" message"

7 years agoEditPage: Refactor getCheckboxes() to allow changing the format
Bartosz Dziewoński [Sat, 25 Mar 2017 20:41:03 +0000 (21:41 +0100)]
EditPage: Refactor getCheckboxes() to allow changing the format

getCheckboxes() directly generated the HTML for the
"This is a minor edit" and "Watch this page" checkboxes,
and allowed extensions to add more HTML checkboxes (and
modify existing ones) using the 'EditPageBeforeEditChecks'
hook. This prevents us from ever changing the format of
the HTML (e.g. to use OOUI checkboxes).

Introduce new method getCheckboxesDefinition(), which
generates the checkboxes in a machine-readable format,
with a new hook 'EditPageGetCheckboxesDefinition'.
Rewrite getCheckboxes() in terms of that. The old hook
'EditPageBeforeEditChecks' is now deprecated.

Change-Id: I3dbe973dcac6cba0c3a1ac5d983cafcfb49d833c

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 29 Mar 2017 19:57:26 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I18df74d64336e8539b7ac85fc6a456759d283e9c

7 years agoUpdate OOjs UI to v0.20.1
Volker E [Tue, 28 Mar 2017 23:25:58 +0000 (16:25 -0700)]
Update OOjs UI to v0.20.1

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.20.1

Depends-On: I9b50eee459085eaa00819cbabe340ac442a332bd
Change-Id: I9b50eee459085eaa00819cbabe340ac442a332db

7 years agoMerge "mw.widgets.Complex*: Add setDisabled"
jenkins-bot [Wed, 29 Mar 2017 19:39:18 +0000 (19:39 +0000)]
Merge "mw.widgets.Complex*: Add setDisabled"

7 years agoResourceLoaderImage: Correctly ignore 'deprecated' key
Roan Kattouw [Wed, 29 Mar 2017 18:44:22 +0000 (14:44 -0400)]
ResourceLoaderImage: Correctly ignore 'deprecated' key

It turns out that 'resources/lib/oojs-ui/themes/mediawiki/Moved since v0.20.1, use from the 'interactions' pack instead.'
is not usually an existing file, and doesn't have the extension '.svg'.
Not sure why this didn't break earlier.

Bonus: Add module name to exceptions to make these errors easier
to track down.

Bonus #2: Use the post-expansion, not pre-expansion, definition everywhere
to avoid confusion when debugging.

Change-Id: I0325d4dab5658fd29c3c33fd3e762834b53d1b5d

7 years agoMerge "Move DBConnRef/MaintainableDBConnRef to Rdbms namespace"
jenkins-bot [Wed, 29 Mar 2017 18:29:11 +0000 (18:29 +0000)]
Merge "Move DBConnRef/MaintainableDBConnRef to Rdbms namespace"

7 years agoMove DBConnRef/MaintainableDBConnRef to Rdbms namespace
Aaron Schulz [Wed, 29 Mar 2017 16:15:50 +0000 (09:15 -0700)]
Move DBConnRef/MaintainableDBConnRef to Rdbms namespace

Change-Id: I7ca6b40f973b2aae83747de92e280ded222c87e3

7 years agoSpecial:RecentChangesLinked show "no results" message
Stephane Bisson [Wed, 29 Mar 2017 16:36:49 +0000 (12:36 -0400)]
Special:RecentChangesLinked show "no results" message

Bug: T160482
Change-Id: I26743928b359ad052ff53bde281f0479cbe68a99

7 years agoMerge "Make Title::getFirstRevision() ignore the rev_timestamp index"
jenkins-bot [Wed, 29 Mar 2017 16:23:38 +0000 (16:23 +0000)]
Merge "Make Title::getFirstRevision() ignore the rev_timestamp index"

7 years agoImplement WikiPage::getOldestRevision() in terms of Title::getFirstRevision()
Roan Kattouw [Wed, 29 Mar 2017 15:53:08 +0000 (11:53 -0400)]
Implement WikiPage::getOldestRevision() in terms of Title::getFirstRevision()

They were both doing the same thing, except that getOldestRevision()
checks the master if the revision is missing on the replica.

Change-Id: I21a118c6cd5c98fb846a0a2765574c0dbdbf7220

7 years agoMake Title::getFirstRevision() ignore the rev_timestamp index
Roan Kattouw [Tue, 28 Mar 2017 15:34:56 +0000 (11:34 -0400)]
Make Title::getFirstRevision() ignore the rev_timestamp index

We want the page_timestamp index to be used in this case, but sometimes
the rev_timestamp is chosen which leads to bad performance.

Also update WikiPage::getOldestRevision() which uses the exact same query.
I'll implement one in terms of the other in a follow-up commit.

Bug: T159319
Change-Id: I7c5c0a9b1af99ce2b5f4bdcc99710d8400ca8bcf

7 years agoMerge "Allow filtering by username on Special:NewFiles"
jenkins-bot [Wed, 29 Mar 2017 14:11:40 +0000 (14:11 +0000)]
Merge "Allow filtering by username on Special:NewFiles"

7 years agoMerge "HttpFunctions: Increase code coverage"
jenkins-bot [Wed, 29 Mar 2017 06:44:49 +0000 (06:44 +0000)]
Merge "HttpFunctions: Increase code coverage"

7 years agoMerge "Move IDatabase/IMaintainableDatabase to Rdbms namespace"
jenkins-bot [Wed, 29 Mar 2017 00:46:59 +0000 (00:46 +0000)]
Merge "Move IDatabase/IMaintainableDatabase to Rdbms namespace"

7 years agoMerge "Defer calling ChronologyProtector::initLB() until connecting"
jenkins-bot [Wed, 29 Mar 2017 00:46:52 +0000 (00:46 +0000)]
Merge "Defer calling ChronologyProtector::initLB() until connecting"

7 years agoHttpFunctions: Increase code coverage
Timo Tijhof [Wed, 29 Mar 2017 00:21:15 +0000 (17:21 -0700)]
HttpFunctions: Increase code coverage

* Complete coverage for Http::getProxy().
* Remove bogus @covers tag on data provider, and add the
  relevant MWHttpRequest::getFinalUrl to the test instead.
* Convert test to use dataProvider and add missing test cases
  to increase getFinalUrl() test coverage to 100%.
* Minor clean up in getFinalUrl to consistently use early-return
  for all cases, not just for relative 'domain' and 'isset-host'
  cases. Without this coverage actually couldn't reach 100% due
  to the remainder of the empty else branch never being reached
  (CRAP: "Redundant 'else' after 'return'")

Change-Id: I775d95965dc23a1e6c4c62ed84f9da64b6c72135

7 years agoDefer calling ChronologyProtector::initLB() until connecting
Aaron Schulz [Fri, 24 Mar 2017 00:30:29 +0000 (17:30 -0700)]
Defer calling ChronologyProtector::initLB() until connecting

Bug: T160678
Change-Id: Id51c2854f38d9e4697e52776168b16996e9152e4

7 years agoMerge "Deprecate "Avoid page_touched update for HTTP GET action=purge requests""
jenkins-bot [Tue, 28 Mar 2017 23:32:06 +0000 (23:32 +0000)]
Merge "Deprecate "Avoid page_touched update for HTTP GET action=purge requests""

7 years agoMove IDatabase/IMaintainableDatabase to Rdbms namespace
Aaron Schulz [Fri, 10 Feb 2017 18:09:05 +0000 (10:09 -0800)]
Move IDatabase/IMaintainableDatabase to Rdbms namespace

Change-Id: If7e8a8ff574661fd827de8bcec11d2c39a687300

7 years agoSECURITY: Disable <html> tag on system messages despite $wgRawHtml = true;
Brian Wolff [Mon, 6 Feb 2017 03:00:39 +0000 (03:00 +0000)]
SECURITY: Disable <html> tag on system messages despite $wgRawHtml = true;

System messages may take parameters from untrusted sources. This
may include taking parameters from urls given by unauthenticated
users even if the wiki is a read-only wiki. Allowing <html> tags
in such a context seems like an accident waiting to happen.

Bug: T156184
Change-Id: I661f482986d319cf41da1d3e7b20a0f028a42e90

7 years agoresourceloader: Avoid deprecated getModifiedHash() in SkinModule
Timo Tijhof [Tue, 28 Mar 2017 21:34:18 +0000 (14:34 -0700)]
resourceloader: Avoid deprecated getModifiedHash() in SkinModule

Use getDefinitionSummary instead, which uses a single serialisation
pass instead of requiring every stage to be a string. This way
we don't need to call json_encode and md5() multiple times.

getModifiedHash() was deprecated in MediaWiki 1.26.

Change-Id: If9e9caa3d12976c99543ad53ab280355b70acb17

7 years agoMerge "Catch errors in more cases inside MediaWiki::triggerJobs()"
jenkins-bot [Tue, 28 Mar 2017 21:24:42 +0000 (21:24 +0000)]
Merge "Catch errors in more cases inside MediaWiki::triggerJobs()"

7 years agoMerge "ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget"
jenkins-bot [Tue, 28 Mar 2017 21:16:57 +0000 (21:16 +0000)]
Merge "ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget"

7 years agoMerge "Rename CategorySelector to CategoryMultiselectWidget"
jenkins-bot [Tue, 28 Mar 2017 21:16:52 +0000 (21:16 +0000)]
Merge "Rename CategorySelector to CategoryMultiselectWidget"

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 28 Mar 2017 19:58:48 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie34e238728bbf19d934f98e3a6d8e847f9be60a5

7 years agoMerge "hidemyself/hidebyothers: Use rc_user_text since there is an index"
jenkins-bot [Tue, 28 Mar 2017 19:56:34 +0000 (19:56 +0000)]
Merge "hidemyself/hidebyothers: Use rc_user_text since there is an index"

7 years agohidemyself/hidebyothers: Use rc_user_text since there is an index
Matthew Flaschen [Mon, 27 Mar 2017 21:06:01 +0000 (17:06 -0400)]
hidemyself/hidebyothers: Use rc_user_text since there is an index

hidebyothers was extremely slow (on large data sets) due to the
lack of an index on rc_user.  To fix this, changed to use rc_user_text.

hidemyself seems to be fine (assuming normal usage patterns), but
to avoid edge cases and ensure full coverage, it's been changed as
well.

I'll inquire about adding an index for this.

Bug: T161557
Change-Id: I61efe11de12e8ab6c01e8d913cdeda471132a6ee

7 years agobuild: Bump grunt-banana-checker from 0.5.0 to 0.6.0
James D. Forrester [Tue, 28 Mar 2017 19:08:05 +0000 (15:08 -0400)]
build: Bump grunt-banana-checker from 0.5.0 to 0.6.0

Change-Id: I64d4267d20716b893237f7f13729343593c8d382

7 years agoMerge "Change Title::getPreviousRevisionID (and next) to ignore PRIMARY"
jenkins-bot [Tue, 28 Mar 2017 15:09:28 +0000 (15:09 +0000)]
Merge "Change Title::getPreviousRevisionID (and next) to ignore PRIMARY"

7 years agoMerge "MWHttpRequest: optionally add original request data"
jenkins-bot [Tue, 28 Mar 2017 14:19:21 +0000 (14:19 +0000)]
Merge "MWHttpRequest: optionally add original request data"

7 years agoForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget
Prateek Saxena [Fri, 24 Mar 2017 10:25:56 +0000 (15:55 +0530)]
ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget

...instead of CategorySelector

Bug: T161285
Change-Id: Icd9bb162caa63c5a43f90e31818fc1432c6d66be

7 years agoRename CategorySelector to CategoryMultiselectWidget
Prateek Saxena [Fri, 24 Mar 2017 09:55:37 +0000 (15:25 +0530)]
Rename CategorySelector to CategoryMultiselectWidget

For consistency.

Bug: T161285
Change-Id: I7c9e0089ba6b77f4bc73e14b989630487f6f3174

7 years agoMerge "Add tests for CSSMin::getMimeType"
jenkins-bot [Tue, 28 Mar 2017 08:04:18 +0000 (08:04 +0000)]
Merge "Add tests for CSSMin::getMimeType"

7 years agoMerge "resourceloader: Optimise getMimeType() for common case"
jenkins-bot [Tue, 28 Mar 2017 07:59:45 +0000 (07:59 +0000)]
Merge "resourceloader: Optimise getMimeType() for common case"

7 years agobuild: Make Travis CI 'Postgres' build non-voting
Timo Tijhof [Sat, 25 Mar 2017 19:38:09 +0000 (12:38 -0700)]
build: Make Travis CI 'Postgres' build non-voting

This will make it easier to detect regressions by not making all
builds marked as fail, but only if one of the other three fails.

Mute the known failure from Postgres by adding it to an allow_failures
section. It'll still run every commit, but is non-voting.
To be re-enabled once T75174 is fixed.

Bug: T75176
Change-Id: I2ea415edd308f2a012ef240d562c0073f15b9118

7 years agoMerge "RCFilters UI: Only show full coverage message if item isn't highlighted"
jenkins-bot [Mon, 27 Mar 2017 22:18:00 +0000 (22:18 +0000)]
Merge "RCFilters UI: Only show full coverage message if item isn't highlighted"

7 years agoCatch errors in more cases inside MediaWiki::triggerJobs()
Aaron Schulz [Mon, 27 Mar 2017 20:26:13 +0000 (13:26 -0700)]
Catch errors in more cases inside MediaWiki::triggerJobs()

This catches things like "DB is read-only" when doing pop()/ack() from the
job table with sqlite.

Also spun off some code to new trigger*Jobs() methods for readability.

Bug: T88312
Change-Id: I2a09248e40867684d48e6739da5e4a90581fa6ce

7 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 27 Mar 2017 20:56:37 +0000 (22:56 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9a519432d6d8d818987818a6d7c07d1fdebe2f81

7 years agoMerge "rcfilters: Avoid $.type()"
jenkins-bot [Mon, 27 Mar 2017 20:41:37 +0000 (20:41 +0000)]
Merge "rcfilters: Avoid $.type()"

7 years agorcfilters: Avoid $.type()
Stephane Bisson [Mon, 27 Mar 2017 19:34:39 +0000 (15:34 -0400)]
rcfilters: Avoid $.type()

Followup to I9a0c5e40b813e075ec33eea882b625dc43a15df6

Replace $.type() with typeof or Array.isArray

Change-Id: I4f0f717c345ab1279b626b158b0ed6ada056bbc1

7 years agoMWHttpRequest: optionally add original request data
Gergő Tisza [Sat, 25 Mar 2017 23:05:44 +0000 (23:05 +0000)]
MWHttpRequest: optionally add original request data

Bug: T161029
Change-Id: I16a2eec46ae9e0e242fe740be20e39a2422dc867

7 years agoMerge "Add array typehint to 2 DatabaseUpdater methods"
jenkins-bot [Mon, 27 Mar 2017 19:16:48 +0000 (19:16 +0000)]
Merge "Add array typehint to 2 DatabaseUpdater methods"