lhc/web/wiklou.git
2 years agoRemove RELEASE-NOTES-1.33
Reedy [Sat, 8 Jun 2019 12:22:12 +0000 (13:22 +0100)]
Remove RELEASE-NOTES-1.33

1.33.0-rc.0 is out, so probably not any more features being backported

It's already divered from the one in the REL1_33 branch, so has
little benefit staying in master

Change-Id: I21fa200e1c817099afa83062a357014b5481a18e

2 years agoMerge "Pass options as array to IDatabase::insert"
jenkins-bot [Sat, 8 Jun 2019 08:28:30 +0000 (08:28 +0000)]
Merge "Pass options as array to IDatabase::insert"

2 years agoMerge "Relax HTML sniffing checks on image upload"
jenkins-bot [Fri, 7 Jun 2019 21:53:31 +0000 (21:53 +0000)]
Merge "Relax HTML sniffing checks on image upload"

2 years agoRelax HTML sniffing checks on image upload
Brion Vibber [Thu, 6 Jun 2019 21:54:29 +0000 (14:54 -0700)]
Relax HTML sniffing checks on image upload

Allows uploaded files to include some HTML tag strings that were
previously forbidden in the first 1k or so of the file:
* <a href
* <img
* <pre
* <table
* <title

They are now allowed as long as the IE MIME type detection heuristic
would not change their types. This should reduce the number of false
positive checks in JPEGs with EXIF data with links.

Also deprecates $wgAllowTitlesInSVG and allows it by default.

This should still protect against malformed PNG attacks on old IE
versions, though false positive checks are conceivable on PNG files
containing comments very close to the beginning of the file.

Adds $wgVerifyMimeTypeIE config var to allow disabling the IE checks
entirely, if desired, but leaves it in place by default. These are
more conservative than the checks that were removed.

Added test cases for the old IE5/6 bug and the particular sort of
JPEG metadata that struck false positives previously.

Bug: T27707
Change-Id: I66642a74fce1a1894cad67d62b0da61020db469a

2 years agoAPI: Apply miser-mode namespace check for generator=redirects
Brad Jorsch [Fri, 24 May 2019 13:19:49 +0000 (09:19 -0400)]
API: Apply miser-mode namespace check for generator=redirects

Bug: T224246
Change-Id: Icad65fcc14ad91d302c8285e08d6a7ea299a90c6

2 years agoPass options as array to IDatabase::insert
Umherirrender [Fri, 7 Jun 2019 17:12:35 +0000 (19:12 +0200)]
Pass options as array to IDatabase::insert

The documentation only allows arrays there

Change-Id: I00c6e47a817a70bed9a443aebc675ef4c3d6b1e5

2 years agoChange array type on ApiQueryBase::addTables
Umherirrender [Fri, 7 Jun 2019 15:19:48 +0000 (17:19 +0200)]
Change array type on ApiQueryBase::addTables

This function results in passing its value to IDatabase::select as first
parameter $table.
The first parameter is documented as string|array, because it can take
more complex arrays:
 * Joins using parentheses for grouping (since MediaWiki 1.31) may be
 * constructed using nested arrays. For example,
 *
 *    [ 'tableA', 'nestedB' => [ 'tableB', 'b2' => 'tableB2' ] ]

Update the type to allow also passing such complex arrays to this
function
ApiQueryBase::showHiddenUsersAddBlockInfo() is using this format

Change-Id: I8038243545bc1c79a1106ccc3bec7738e63c2e2e

2 years agoMerge "Add missing Title::newFromLinkTarget to api module compare"
jenkins-bot [Fri, 7 Jun 2019 08:11:27 +0000 (08:11 +0000)]
Merge "Add missing Title::newFromLinkTarget to api module compare"

2 years agoMerge "Fix ServiceOptions type in constructor documentation"
jenkins-bot [Fri, 7 Jun 2019 08:05:54 +0000 (08:05 +0000)]
Merge "Fix ServiceOptions type in constructor documentation"

2 years agoMerge "WatchedItemStore::getWatchedItem returns a WatchedItem"
jenkins-bot [Fri, 7 Jun 2019 08:05:03 +0000 (08:05 +0000)]
Merge "WatchedItemStore::getWatchedItem returns a WatchedItem"

2 years agoAdd 1.27.7 to HISTORY
Reedy [Fri, 7 Jun 2019 01:31:44 +0000 (02:31 +0100)]
Add 1.27.7 to HISTORY

Change-Id: If41890454e3487b6b7803a1671915041c53f9561

2 years agoBring in HISTORY for 1.27.6/1.30.2/1.31.2/1.32.2
Reedy [Fri, 7 Jun 2019 00:08:20 +0000 (01:08 +0100)]
Bring in HISTORY for 1.27.6/1.30.2/1.31.2/1.32.2

Bug: T205046
Change-Id: Ib4819bf71c22873a4b16c55b7e22d0f33aa07148

2 years agoFix spelling error in test function name
Thalia [Thu, 6 Jun 2019 21:29:02 +0000 (17:29 -0400)]
Fix spelling error in test function name

Change-Id: Ib9b83f6936a3ba86dbb7537d9cef7810c8bc36db

2 years agoMerge "SECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358"
jenkins-bot [Thu, 6 Jun 2019 20:37:15 +0000 (20:37 +0000)]
Merge "SECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358"

2 years agoMerge "SECURITY: Add permission check for user is permitted to view the log type"
jenkins-bot [Thu, 6 Jun 2019 20:37:09 +0000 (20:37 +0000)]
Merge "SECURITY: Add permission check for user is permitted to view the log type"

2 years agoMerge "SECURITY: Add permission check for user is permitted to view the log type"
jenkins-bot [Thu, 6 Jun 2019 20:36:18 +0000 (20:36 +0000)]
Merge "SECURITY: Add permission check for user is permitted to view the log type"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 6 Jun 2019 20:14:43 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I33e9fe577fee1d6203e2f91d143c25b1d2291bd5

2 years agoAdd missing Title::newFromLinkTarget to api module compare
Umherirrender [Thu, 6 Jun 2019 20:10:57 +0000 (22:10 +0200)]
Add missing Title::newFromLinkTarget to api module compare

The function getArticleID is not implemented by a LinkTarget as returned
by getPageAsLinkTarget, so this needs a wrapper to create a Title
object.
ApiQueryBase::addTitleInfo also needs a Title object to call
getPrefixedText

Change-Id: I8d1b4a77da8b3ce4eaf9e7e5100a3243669f2d3e

2 years agoFix ServiceOptions type in constructor documentation
Umherirrender [Thu, 6 Jun 2019 19:59:27 +0000 (21:59 +0200)]
Fix ServiceOptions type in constructor documentation

Change-Id: I3fcde4e484ddd6d86e4ca12dcf5977051e7f4cf2

2 years agoMerge "Log headers sent errors more usefully in thumb.php"
jenkins-bot [Thu, 6 Jun 2019 19:34:22 +0000 (19:34 +0000)]
Merge "Log headers sent errors more usefully in thumb.php"

2 years agoMerge "SECURITY: Fix cache mode for (un)patrolled recent changes query"
jenkins-bot [Thu, 6 Jun 2019 19:15:19 +0000 (19:15 +0000)]
Merge "SECURITY: Fix cache mode for (un)patrolled recent changes query"

2 years agoSECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358
James D. Forrester [Thu, 25 Apr 2019 21:12:52 +0000 (16:12 -0500)]
SECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358

Patch taken from https://github.com/DanielRuf/snyk-js-jquery-174006?files=1
and left in-repo. Note that this will break the foreign resources check,
which is not currently a unit test but was planned to become such soon.

Bug: T221739
Change-Id: I99c2be81c74a8f1d35c421f0ee43c75efb30a7d0

2 years agoSECURITY: Add permission check for user is permitted to view the log type
rxy [Sun, 28 Apr 2019 20:14:18 +0000 (05:14 +0900)]
SECURITY: Add permission check for user is permitted to view the log type

Bug: T222038
Change-Id: I92ec2adfd9c514b3be1c07b7d22b9f9722d24a82

2 years agoSECURITY: Add permission check for user is permitted to view the log type
rxy [Sun, 28 Apr 2019 20:04:01 +0000 (05:04 +0900)]
SECURITY: Add permission check for user is permitted to view the log type

Bug: T222036
Change-Id: I7584ee8db23a8834bbab21e355cab9857a293f72

2 years agoMerge "SECURITY: API: Respect $wgBlockCIDRLimit in action=block"
jenkins-bot [Thu, 6 Jun 2019 18:59:45 +0000 (18:59 +0000)]
Merge "SECURITY: API: Respect $wgBlockCIDRLimit in action=block"

2 years agoMerge "SECURITY: rate-limit and prevent blocked users from changing email"
jenkins-bot [Thu, 6 Jun 2019 18:59:38 +0000 (18:59 +0000)]
Merge "SECURITY: rate-limit and prevent blocked users from changing email"

2 years agoMerge "SECURITY: blacklist CSS var()"
jenkins-bot [Thu, 6 Jun 2019 18:59:30 +0000 (18:59 +0000)]
Merge "SECURITY: blacklist CSS var()"

2 years agoMerge "SECURITY: Fix reauth in Special:ChangeEmail"
jenkins-bot [Thu, 6 Jun 2019 18:26:01 +0000 (18:26 +0000)]
Merge "SECURITY: Fix reauth in Special:ChangeEmail"

2 years agoSECURITY: Fix cache mode for (un)patrolled recent changes query
Lucas Werkmeister [Mon, 17 Dec 2018 13:02:39 +0000 (14:02 +0100)]
SECURITY: Fix cache mode for (un)patrolled recent changes query

Restricting the list of recent changes to patrolled, not patrolled,
autopatrolled, not autopatrolled, or unpatrolled recent changes requires
special permissions (as does displaying that status in the properties of
returned entries), but we only set the cache mode to private in the
first two cases.

Bug: T212118
Change-Id: I4c3fe6e47f80ebf97fa37875c704328d08772d26

2 years agoSECURITY: API: Respect $wgBlockCIDRLimit in action=block
Kunal Mehta [Fri, 13 Jul 2018 15:07:51 +0000 (08:07 -0700)]
SECURITY: API: Respect $wgBlockCIDRLimit in action=block

$wgBlockCIDRLimit states how large rangeblocks are allowed to be for IPv4
and IPv6. The API now calls SpecialBlock::validateTarget() to perform
that validation step.

As a minor thing, SpecialBlock::checkUnblockSelf() is now called twice by
the API, but that can probably be cleaned up at another time.

Tests included.

Bug: T199540
Change-Id: Ic7d60240d9ebd9580c0eb3b41e4befceab69bd81

2 years agoSECURITY: rate-limit and prevent blocked users from changing email
Brian Wolff [Wed, 21 Nov 2018 16:15:28 +0000 (16:15 +0000)]
SECURITY: rate-limit and prevent blocked users from changing email

This is to counter spam where people use Special:ChangeEmail to
spam people with the confirmation email and using the username
to promote their thing

Bug: T209794
Change-Id: I8b2bd0f60c66f44c91dc78e3512a73e4237df2f3

2 years agoSECURITY: blacklist CSS var()
Max Semenik [Wed, 7 Nov 2018 02:38:22 +0000 (18:38 -0800)]
SECURITY: blacklist CSS var()

Bug: T208881
Change-Id: I9a4ced2bc47eb5f96cf35e693bf5261c48acb126

2 years agoSECURITY: Fix reauth in Special:ChangeEmail
Brian Wolff [Fri, 15 Jun 2018 08:19:49 +0000 (08:19 +0000)]
SECURITY: Fix reauth in Special:ChangeEmail

Previously you could bypass reauthentication by directly
POSTing to Special:ChangeEmail.

Bug: T197279
Change-Id: I674557351e0e91a8105c12ddf6cd30283aac9f7a

2 years agoAdd some @since tags to HeaderCallback
Reedy [Thu, 6 Jun 2019 15:14:58 +0000 (16:14 +0100)]
Add some @since tags to HeaderCallback

Change-Id: I28053418d107f4a101aa7d8a2203c6864acd311f

2 years agoLog headers sent errors more usefully in thumb.php
Gergő Tisza [Thu, 6 Jun 2019 14:21:21 +0000 (16:21 +0200)]
Log headers sent errors more usefully in thumb.php

Bug: T225197
Change-Id: Ifcb02b3d5794061f27c005b32164ac014f926357

2 years agoMerge "Improve return types in class MagicWordArray"
jenkins-bot [Thu, 6 Jun 2019 14:27:28 +0000 (14:27 +0000)]
Merge "Improve return types in class MagicWordArray"

2 years agoMerge "Document $rows on hook ChangesListInitRows as IResultWrapper"
jenkins-bot [Thu, 6 Jun 2019 14:10:35 +0000 (14:10 +0000)]
Merge "Document $rows on hook ChangesListInitRows as IResultWrapper"

2 years agoMerge "Fix type hint for properties holding MapCacheLRU"
jenkins-bot [Thu, 6 Jun 2019 14:10:29 +0000 (14:10 +0000)]
Merge "Fix type hint for properties holding MapCacheLRU"

2 years agoWatchedItemStore::getWatchedItem returns a WatchedItem
Umherirrender [Tue, 4 Jun 2019 19:37:54 +0000 (21:37 +0200)]
WatchedItemStore::getWatchedItem returns a WatchedItem

Follow-Up: I31e983d7ac287158101b18ad95779d83537302a2
Change-Id: I4819d6e9f919467d46b3704331a54068a50c2cfa

2 years agoCorrect name of the recommended function
Adam Wight [Thu, 6 Jun 2019 10:51:03 +0000 (12:51 +0200)]
Correct name of the recommended function

Change-Id: I6b79b6a9e3d17eafdb92fd940d64e9108ff5c293

2 years agoMerge "Refactor buildPrevNextNavigation"
jenkins-bot [Thu, 6 Jun 2019 09:04:26 +0000 (09:04 +0000)]
Merge "Refactor buildPrevNextNavigation"

2 years agoMerge "Improve type hints to special page related classes"
jenkins-bot [Thu, 6 Jun 2019 04:20:49 +0000 (04:20 +0000)]
Merge "Improve type hints to special page related classes"

2 years agoMerge "Remove DatabaseSqliteMock unit test class in favor of mocking"
jenkins-bot [Thu, 6 Jun 2019 02:02:29 +0000 (02:02 +0000)]
Merge "Remove DatabaseSqliteMock unit test class in favor of mocking"

2 years agoMerge "Improve @var on User class"
jenkins-bot [Thu, 6 Jun 2019 01:46:42 +0000 (01:46 +0000)]
Merge "Improve @var on User class"

2 years agoMerge "Update OOUI to v0.32.1"
jenkins-bot [Thu, 6 Jun 2019 00:07:23 +0000 (00:07 +0000)]
Merge "Update OOUI to v0.32.1"

2 years agoRefactor buildPrevNextNavigation
clarakosi [Wed, 29 May 2019 23:08:11 +0000 (19:08 -0400)]
Refactor buildPrevNextNavigation

Refactored buildPrevNextNavigation() into standalone helper class,
PrevNextNavigationRenderer, to be used by both SpecialPages and Pagers.

Bug:T207977
Change-Id: Ic49837a451f795ec203e867961ec1c69075cc91a

2 years agoRemove DatabaseSqliteMock unit test class in favor of mocking
Aaron Schulz [Wed, 5 Jun 2019 21:25:46 +0000 (22:25 +0100)]
Remove DatabaseSqliteMock unit test class in favor of mocking

Change-Id: Id22233359df25920c335e4945e606c6c3283f2a1

2 years agoMerge "Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad"
jenkins-bot [Wed, 5 Jun 2019 20:51:04 +0000 (20:51 +0000)]
Merge "Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 5 Jun 2019 19:58:20 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5ff3c17b7b9ee534e3efa6cdb7ce4b7b40a54d16

2 years agoFix type hint for properties holding MapCacheLRU
Umherirrender [Wed, 5 Jun 2019 18:32:05 +0000 (20:32 +0200)]
Fix type hint for properties holding MapCacheLRU

Change-Id: Ia22b1dbcde3b96b3f437a213da95b3556fa42d70

2 years agoImprove @var on User class
Umherirrender [Wed, 5 Jun 2019 17:19:22 +0000 (19:19 +0200)]
Improve @var on User class

Add missing @var tags with types or add missing types to @var

Change-Id: I34eb4c26d34da072465f1b162fb2d0291610f564

2 years agoUpdate OOUI to v0.32.1
James D. Forrester [Wed, 5 Jun 2019 16:32:46 +0000 (09:32 -0700)]
Update OOUI to v0.32.1

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.1

Bug: T223841
Bug: T224739
Bug: T224885
Depends-On: I1e6ed138cbab66c94cd45289799302d88d22cad9
Change-Id: I72278024790829841c15dd7b3eb09fe1a98cac9c

2 years agoMerge "HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory"
jenkins-bot [Wed, 5 Jun 2019 15:42:04 +0000 (15:42 +0000)]
Merge "HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory"

2 years agoDecouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad
Thalia [Fri, 24 May 2019 13:02:32 +0000 (14:02 +0100)]
Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad

Before this, DatabaseBlock:newFromTarget initialises a new block and
calls DatabaseBlock::newLoad on that instance, passing through the
target and type via that instance. However, newLoad returns a brand
new block instance. This patch makes newLoad into a static method,
with the target and type passed as method parameters.

It also separates the block-choosing logic in newLoad into a separate
method, DatabaseBlock::chooseMostSpecificBlock. Doing this (1) makes
it more transparent that Block uses two different ways to choose a
block (see also Block::chooseBlock), and (2) makes it possible to
re-use newLoad to get multiple blocks.

Also, filter out any duplicate autoblocks that are found by newLoad.

Bug: T206163
Change-Id: Iefa3aaadf2954c3b86f5c691096af31de40fae6c

2 years agoMake userLink() not fail too hard on false and null.
daniel [Wed, 22 May 2019 20:12:11 +0000 (22:12 +0200)]
Make userLink() not fail too hard on false and null.

This works around an issue in Flow, which sometimes passes false
for a user name.

Bug: T224095
Change-Id: I14dc52f7199012dc35605f3170b06eb1719165a7

2 years agoMerge "Fix return type of UploadBase::check* functions"
jenkins-bot [Wed, 5 Jun 2019 09:10:26 +0000 (09:10 +0000)]
Merge "Fix return type of UploadBase::check* functions"

2 years agoMerge "Allow int as return type of MediaHandler::isMetadataValid"
jenkins-bot [Wed, 5 Jun 2019 08:57:05 +0000 (08:57 +0000)]
Merge "Allow int as return type of MediaHandler::isMetadataValid"

2 years agoMerge "Fix type to callable on FileRepo::getErrorCleanupFunction"
jenkins-bot [Wed, 5 Jun 2019 08:56:34 +0000 (08:56 +0000)]
Merge "Fix type to callable on FileRepo::getErrorCleanupFunction"

2 years agoHTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory
Kunal Mehta [Tue, 4 Jun 2019 19:45:38 +0000 (15:45 -0400)]
HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory

Change-Id: I3fddf30f1b0fc2cce79f652cb71efba119439a9f

2 years agoMerge "Add action=query&meta=languageinfo API module"
jenkins-bot [Tue, 4 Jun 2019 20:03:38 +0000 (20:03 +0000)]
Merge "Add action=query&meta=languageinfo API module"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 4 Jun 2019 19:57:17 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I98b20ec1bd615860212c254729a20ed998a76ba1

2 years agoFix return type of UploadBase::check* functions
Umherirrender [Tue, 4 Jun 2019 19:44:51 +0000 (21:44 +0200)]
Fix return type of UploadBase::check* functions

Change-Id: I37964663fc8cb63575c1e0be9c5ced489d69136e

2 years agoAllow int as return type of MediaHandler::isMetadataValid
Umherirrender [Tue, 4 Jun 2019 19:33:37 +0000 (21:33 +0200)]
Allow int as return type of MediaHandler::isMetadataValid

MediaHandler::METADATA_COMPATIBLE is a int,
which is a possible return value here

Change-Id: Ia84139ee8e09839e1f46a6d34738612dfd365415

2 years agoFix type to callable on FileRepo::getErrorCleanupFunction
Umherirrender [Tue, 4 Jun 2019 19:28:25 +0000 (21:28 +0200)]
Fix type to callable on FileRepo::getErrorCleanupFunction

Change-Id: Idb07fb2d6ade9eb3619ecea5516d7e9815b7bb54

2 years agoHard-deprecate SkinFactory::getDefaultInstance()
Kunal Mehta [Mon, 3 Jun 2019 00:56:10 +0000 (20:56 -0400)]
Hard-deprecate SkinFactory::getDefaultInstance()

Was soft-deprecated in 1.27.

Change-Id: I5f4afefc6c439c7e8d173a844c76ccd693f9bbf1

2 years agoMerge "selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4"
jenkins-bot [Mon, 3 Jun 2019 20:38:46 +0000 (20:38 +0000)]
Merge "selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4"

2 years agoMerge "Set content language for test to en to ensure it passes"
jenkins-bot [Mon, 3 Jun 2019 20:23:35 +0000 (20:23 +0000)]
Merge "Set content language for test to en to ensure it passes"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 3 Jun 2019 19:59:29 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Iebfb3ccd127a9dab6dac283fe6d6f3427422c004

2 years agoselenium: Re-add all tests and wdio-mocha-framework, now v0.6.4
James D. Forrester [Mon, 3 Jun 2019 17:58:18 +0000 (10:58 -0700)]
selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4

This reverts commit c3878c08b5275123972354ba5479d3315c4fefb4.

Now that we're running on node10, this will fail until we fix
things.

Bug: T213268
Bug: T222406
Change-Id: I5935fc5d5bc23978e50275d3c99ac870b3b82f49

2 years agoDocument $rows on hook ChangesListInitRows as IResultWrapper
Umherirrender [Mon, 3 Jun 2019 19:29:56 +0000 (21:29 +0200)]
Document $rows on hook ChangesListInitRows as IResultWrapper

Change-Id: I243b460c4788a2bee095cb76b76106577f06b96f

2 years agoImprove type hints to special page related classes
Umherirrender [Mon, 3 Jun 2019 19:11:10 +0000 (21:11 +0200)]
Improve type hints to special page related classes

Change-Id: I96e2ff2fbd6f69e83212b22cf107417014b665e1

2 years agoSet content language for test to en to ensure it passes
Thalia [Mon, 3 Jun 2019 17:44:11 +0000 (13:44 -0400)]
Set content language for test to en to ensure it passes

Change-Id: I5bff92e304795ac4f76fd07f12f3598fbf816f39

2 years agoMerge "HTMLForm: Remove deprecated unused getErrors() method"
jenkins-bot [Mon, 3 Jun 2019 17:37:47 +0000 (17:37 +0000)]
Merge "HTMLForm: Remove deprecated unused getErrors() method"

2 years agoMerge "make sure revision uids are 0 in the xml if missing/0 in the db"
jenkins-bot [Mon, 3 Jun 2019 17:26:05 +0000 (17:26 +0000)]
Merge "make sure revision uids are 0 in the xml if missing/0 in the db"

2 years agoMerge "selenium: Temporarily drop all tests and wdio-mocha-framework"
jenkins-bot [Mon, 3 Jun 2019 16:47:14 +0000 (16:47 +0000)]
Merge "selenium: Temporarily drop all tests and wdio-mocha-framework"

2 years agoMerge "Add missing newline between <?php and namespace/use section"
jenkins-bot [Mon, 3 Jun 2019 16:32:03 +0000 (16:32 +0000)]
Merge "Add missing newline between <?php and namespace/use section"

2 years agoImprove return types in class MagicWordArray
Umherirrender [Mon, 3 Jun 2019 15:52:47 +0000 (17:52 +0200)]
Improve return types in class MagicWordArray

Change-Id: I63ff4f52d8459ab19dd774ef1dee8435f1eb5cae

2 years agomake sure revision uids are 0 in the xml if missing/0 in the db
Ariel T. Glenn [Mon, 27 May 2019 13:03:29 +0000 (16:03 +0300)]
make sure revision uids are 0 in the xml if missing/0 in the db

Bug: T224221
Change-Id: Id9861866fd9e4d2fe8d151c9631403aa24b9a779

2 years agoMerge "Use ExtensionRegistry::setAttributeForTest() instead of Reflection"
jenkins-bot [Mon, 3 Jun 2019 15:00:12 +0000 (15:00 +0000)]
Merge "Use ExtensionRegistry::setAttributeForTest() instead of Reflection"

2 years agoselenium: Temporarily drop all tests and wdio-mocha-framework
James D. Forrester [Tue, 7 May 2019 19:43:54 +0000 (12:43 -0700)]
selenium: Temporarily drop all tests and wdio-mocha-framework

This is so that we can migrate to node 10 in CI. It should only land
for an hour or so, and is to be reverted as soon as we get CI up to
node 10 and working, lest our suites of selenium tests become
subject to bitrot.

Bug: T222406
Change-Id: I9473e0213c070a0e963913fd81062c6bbf9ec2f2

2 years agoMerge "Remove usage of deprecated SkinFactory::getDefaultInstance()"
jenkins-bot [Mon, 3 Jun 2019 14:27:37 +0000 (14:27 +0000)]
Merge "Remove usage of deprecated SkinFactory::getDefaultInstance()"

2 years agoHTMLForm: Remove deprecated unused getErrors() method
Derick Alangi [Mon, 3 Jun 2019 14:16:38 +0000 (15:16 +0100)]
HTMLForm: Remove deprecated unused getErrors() method

Was deprecated in 1.28 and no longer used, see usage below;

Usage
=====

https://codesearch.wmflabs.org/search/?q=%5CbgetErrors%5C(%20(.*%3F)%20%5C)&i=nope&files=&repos=

Bug: T220656
Change-Id: I542df4f1f7f4180d42282eaf2e069ab0bc9e8614

2 years agoMerge "Add a "help" button for action=info"
jenkins-bot [Mon, 3 Jun 2019 13:55:03 +0000 (13:55 +0000)]
Merge "Add a "help" button for action=info"

2 years agoAdd missing newline between <?php and namespace/use section
Thiemo Kreuz [Tue, 28 May 2019 14:04:23 +0000 (16:04 +0200)]
Add missing newline between <?php and namespace/use section

The rest of the codebase is using this code formatting standard.

Change-Id: I4d2ba61757a7e28d40096d9dc5915005c340d4f2

2 years agoAdd action=query&meta=languageinfo API module
Lucas Werkmeister [Thu, 16 May 2019 09:42:05 +0000 (11:42 +0200)]
Add action=query&meta=languageinfo API module

This API module can be used to get information about all the languages
supported by this MediaWiki installation. Since parts of this
information, such as the fallback chain, are expensive to retrieve if
the localization cache is not populated, we apply continuation if the
request is taking too long (suggested by Anomie in T217239#4994301); we
don’t expect this to happen in Wikimedia production, though.

Bug: T74153
Bug: T220415
Change-Id: Ic66991cd85ed4439a47bfb1412dbe24c23bd9819

2 years agoMerge "API: Migrate Title::userCan() calls to PermissionManager"
jenkins-bot [Mon, 3 Jun 2019 08:55:58 +0000 (08:55 +0000)]
Merge "API: Migrate Title::userCan() calls to PermissionManager"

2 years agoMerge "always order by page_id for dumps of current revisions"
jenkins-bot [Mon, 3 Jun 2019 08:55:50 +0000 (08:55 +0000)]
Merge "always order by page_id for dumps of current revisions"

2 years agoMerge "Wording"
jenkins-bot [Mon, 3 Jun 2019 04:31:44 +0000 (04:31 +0000)]
Merge "Wording"

2 years agoAdd a "help" button for action=info
DannyS712 [Mon, 3 Jun 2019 02:42:30 +0000 (02:42 +0000)]
Add a "help" button for action=info

Bug: T224848
Change-Id: Id72fb9134ce889b9610ca088e53799804580903e

2 years agoUse ExtensionRegistry::setAttributeForTest() instead of Reflection
Kunal Mehta [Mon, 3 Jun 2019 00:58:58 +0000 (20:58 -0400)]
Use ExtensionRegistry::setAttributeForTest() instead of Reflection

Change-Id: If29e8825f1734f8c0efa21aa77f6354fa3468248

2 years agoRemove usage of deprecated SkinFactory::getDefaultInstance()
Kunal Mehta [Mon, 3 Jun 2019 00:55:00 +0000 (20:55 -0400)]
Remove usage of deprecated SkinFactory::getDefaultInstance()

Change-Id: I3bd50f8ca5baabd34dbc0e3bbc2f97e94650a17a

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 2 Jun 2019 19:57:51 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia730eebb70ecece0daca1d97c3d541a767777ecc

2 years agoWording
Seb35 [Sat, 1 Jun 2019 12:16:00 +0000 (14:16 +0200)]
Wording

In GitInfo, the debug sentence "Computed cacheFile" could imply that some
file is written, but in reality "computed" refers to the name. Change to
"Candidate cacheFile".

Bug: T215722
Change-Id: I19448e5790a0f2fcb5202170ca03ab0f5e16d24e

2 years agoAdd a "help" link for Special:PermanentLink
DannyS712 [Sat, 1 Jun 2019 02:15:40 +0000 (02:15 +0000)]
Add a "help" link for Special:PermanentLink

Bug: T224793
Change-Id: I4099b1a794df8477842d5f018d63304cef99d372

2 years agoMerge "Improve changePassword.php error handling"
jenkins-bot [Sat, 1 Jun 2019 00:35:12 +0000 (00:35 +0000)]
Merge "Improve changePassword.php error handling"

2 years agoMerge "Allow $conds of IDatabase::selectRow to be a string"
jenkins-bot [Fri, 31 May 2019 22:00:28 +0000 (22:00 +0000)]
Merge "Allow $conds of IDatabase::selectRow to be a string"

2 years agoMerge "Fix typos in DefaultSettings"
jenkins-bot [Fri, 31 May 2019 20:33:29 +0000 (20:33 +0000)]
Merge "Fix typos in DefaultSettings"

2 years agoMerge "Inline trivial …_internal() methods in Title/UserArray classes"
jenkins-bot [Fri, 31 May 2019 20:33:21 +0000 (20:33 +0000)]
Merge "Inline trivial …_internal() methods in Title/UserArray classes"

2 years agoAllow $conds of IDatabase::selectRow to be a string
Umherirrender [Fri, 31 May 2019 19:47:55 +0000 (21:47 +0200)]
Allow $conds of IDatabase::selectRow to be a string

When not having a condition you can pass a empty string or '*'

Change-Id: Id1bb6cf6e6bd89ad2df492e7441253d06fcf2a2d

2 years agoMerge "rdbms: cleanup code for read-only propagation for master connections"
jenkins-bot [Fri, 31 May 2019 15:51:16 +0000 (15:51 +0000)]
Merge "rdbms: cleanup code for read-only propagation for master connections"