2 years agoFix 'expliciit' typo at resources/Resources.php
zoranzoki21 [Sun, 17 Feb 2019 22:45:10 +0000 (23:45 +0100)]
Fix 'expliciit' typo at resources/Resources.php

Bug: T201491
Change-Id: Ic6c60aad037df3599572f7248093d7dc1509819d

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 17 Feb 2019 20:55:23 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I2316460e88bc758daa875638518105524f97ea1d

2 years agoMerge "Escape messages ipb-sitewide and ipb-partial."
jenkins-bot [Sun, 17 Feb 2019 14:58:29 +0000 (14:58 +0000)]
Merge "Escape messages ipb-sitewide and ipb-partial."

2 years agoEscape messages ipb-sitewide and ipb-partial.
Brian Wolff [Sun, 17 Feb 2019 12:49:03 +0000 (12:49 +0000)]
Escape messages ipb-sitewide and ipb-partial.

Radio button htmlform treats options as being raw html

Change-Id: Ia25ed5b88e937414ea7993a1cf29fe44ed8e22d4

2 years agoAvoid rawParams() in Special:Emailuser
Brian Wolff [Wed, 26 Sep 2018 01:00:25 +0000 (01:00 +0000)]
Avoid rawParams() in Special:Emailuser

Bug: T216348
Change-Id: I6b543c508260f5889f1236dd43022a6a0fe963a9

2 years agoresources: Document why mw.user has two seemingly unused deps
Fomafix [Fri, 7 Dec 2018 09:55:03 +0000 (10:55 +0100)]
resources: Document why mw.user has two seemingly unused deps

The code in the module 'mediawiki.user' does not depend on the modules
'user.options' and 'user.tokens' so the ResourceLoader dependency is
not necessary.

Change-Id: I22b9175f7623dbdf1c08826904b76dee5d56ea40

2 years agoMerge "widgets: Remove redundant equality check in SelectWithInputWidget"
jenkins-bot [Sun, 17 Feb 2019 00:35:34 +0000 (00:35 +0000)]
Merge "widgets: Remove redundant equality check in SelectWithInputWidget"

2 years agoMerge "objectcache: remove EventRelayer dependency from WANObjectCache"
jenkins-bot [Sat, 16 Feb 2019 19:49:22 +0000 (19:49 +0000)]
Merge "objectcache: remove EventRelayer dependency from WANObjectCache"

2 years agoMerge "Fix documentation for Revision::getComment and WikiPage::getComment"
jenkins-bot [Sat, 16 Feb 2019 10:59:48 +0000 (10:59 +0000)]
Merge "Fix documentation for Revision::getComment and WikiPage::getComment"

2 years agoobjectcache: remove EventRelayer dependency from WANObjectCache
Aaron Schulz [Sat, 16 Feb 2019 07:17:23 +0000 (23:17 -0800)]
objectcache: remove EventRelayer dependency from WANObjectCache

The use of that class for WAN cache by third parties is extremely unlikely
and the approach was abandoned at WMF in favor of mcrouter (dynomite was
also considered preferable).

Change-Id: I328eb74f21c23db80acc5178bc3c9cf9f823da13

2 years agoChangeTags: Deprecate ChangeTags::purgeTagUsageCache()
Roan Kattouw [Sat, 16 Feb 2019 01:00:49 +0000 (17:00 -0800)]
ChangeTags: Deprecate ChangeTags::purgeTagUsageCache()

The cache key that it purges is no longer used anywhere.

Change-Id: I2c255936451cde09579594cc4524c8fe38cf3e7c

2 years agoMerge "Improve documentation for different block types"
jenkins-bot [Fri, 15 Feb 2019 22:23:54 +0000 (22:23 +0000)]
Merge "Improve documentation for different block types"

2 years agoMerge "Remove double check of $oldRevision"
jenkins-bot [Fri, 15 Feb 2019 20:15:47 +0000 (20:15 +0000)]
Merge "Remove double check of $oldRevision"

2 years agoImprove documentation for different block types
Thalia [Fri, 15 Feb 2019 19:24:58 +0000 (19:24 +0000)]
Improve documentation for different block types

Clarify the purposes of Block::type and Block::getType

Change-Id: I64a2695f430c7718c504edb1fa6531a529c115cf

2 years agoPrevent PHP notice on SpecialDeletedContributions
Matěj Suchánek [Thu, 14 Feb 2019 09:47:54 +0000 (10:47 +0100)]
Prevent PHP notice on SpecialDeletedContributions

Bug: T208544
Change-Id: Ie8d5c3d7257134857713853eec8e0eb42890366a

2 years agoRefactor calls to deprecated function Content::getNativeData()
Bill Pirkle [Thu, 7 Feb 2019 00:14:23 +0000 (18:14 -0600)]
Refactor calls to deprecated function Content::getNativeData()

Function Content::getNativeData() was deprecated.  Replace with
calls to new function TextContent::getText() in most places.

Bug: T155582
Change-Id: I2bd508c72aac4faf474ba45ab1f92e2e8d2eb9be

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 14 Feb 2019 21:05:27 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic40eaf0cedbbf6a81585f4f0d686f4aa3ae7d160

2 years agoMerge "objectcache: refactor and simplify some WANObjectCache code"
jenkins-bot [Thu, 14 Feb 2019 20:58:56 +0000 (20:58 +0000)]
Merge "objectcache: refactor and simplify some WANObjectCache code"

2 years agoMerge "Update required PHP version to 7.0.13"
jenkins-bot [Thu, 14 Feb 2019 20:40:35 +0000 (20:40 +0000)]
Merge "Update required PHP version to 7.0.13"

2 years agoMerge "Use "try-catch" block instead of "if" block to prevent interruption of new...
jenkins-bot [Thu, 14 Feb 2019 19:31:57 +0000 (19:31 +0000)]
Merge "Use "try-catch" block instead of "if" block to prevent interruption of new installation"

2 years agoUpdate required PHP version to 7.0.13
James D. Forrester [Thu, 14 Feb 2019 19:29:48 +0000 (11:29 -0800)]
Update required PHP version to 7.0.13

Bug: T209423
Change-Id: I66e563adb062bc132a1092d78bfd06e2210f382e

2 years agoMerge "jquery.makeCollapsible.styles: Avoid FOUC for collapse button"
jenkins-bot [Thu, 14 Feb 2019 13:26:12 +0000 (13:26 +0000)]
Merge "jquery.makeCollapsible.styles: Avoid FOUC for collapse button"

2 years agoMerge "EnhancedChangesList: Load style module via addModuleStyles()"
jenkins-bot [Thu, 14 Feb 2019 13:24:55 +0000 (13:24 +0000)]
Merge "EnhancedChangesList: Load style module via addModuleStyles()"

2 years agoMerge "Add missing dependency on module 'mediawiki.notify'"
jenkins-bot [Thu, 14 Feb 2019 13:17:55 +0000 (13:17 +0000)]
Merge "Add missing dependency on module 'mediawiki.notify'"

2 years agoMerge "mediawiki.special.changeslist.enhanced: Convert CSS to LESS"
jenkins-bot [Thu, 14 Feb 2019 13:09:13 +0000 (13:09 +0000)]
Merge "mediawiki.special.changeslist.enhanced: Convert CSS to LESS"

2 years agoAdd missing dependency on module 'mediawiki.notify'
Fomafix [Thu, 14 Feb 2019 08:59:23 +0000 (09:59 +0100)]
Add missing dependency on module 'mediawiki.notify'

watchlist.js uses mw.notify.

Change-Id: Iff59e01d96f3d8ffddd9ddaf9d3b4463c8cac8d1

2 years agoMerge "registration: Allow @-prefixed keys in manifest_version 2"
jenkins-bot [Thu, 14 Feb 2019 06:38:04 +0000 (06:38 +0000)]
Merge "registration: Allow @-prefixed keys in manifest_version 2"

2 years agoMerge "Update AtEase calls to use Wikimedia namespace"
jenkins-bot [Thu, 14 Feb 2019 06:18:57 +0000 (06:18 +0000)]
Merge "Update AtEase calls to use Wikimedia namespace"

2 years agoobjectcache: refactor and simplify some WANObjectCache code
Aaron Schulz [Wed, 13 Feb 2019 20:24:27 +0000 (12:24 -0800)]
objectcache: refactor and simplify some WANObjectCache code

* Move $value === false checks to isValid()
* Rename $isTombstone variable to avoid confusion with the new value
* Reorganize conditionals around set() calls in doGetWithSetCallback()
* Skip getInterimValue() check when there is no reason to assume anything
  might even be there (e.g. the key is not tombstoned)
* Fold the tombstone case for $useMutex into the ternary

Change-Id: I257110097cffe7fe87c6a9896e875f09d5c936d9

2 years agoMerge "objectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()"
jenkins-bot [Thu, 14 Feb 2019 01:25:11 +0000 (01:25 +0000)]
Merge "objectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()"

2 years agoMerge "resourceloader: Restore the comment about <script> vs XHR loading"
jenkins-bot [Thu, 14 Feb 2019 00:49:21 +0000 (00:49 +0000)]
Merge "resourceloader: Restore the comment about <script> vs XHR loading"

2 years agoresourceloader: Restore the comment about <script> vs XHR loading
Bartosz Dziewoński [Wed, 13 Feb 2019 13:21:04 +0000 (14:21 +0100)]
resourceloader: Restore the comment about <script> vs XHR loading

Removed in 42956b99b558294e5aa8c6c0e2a8f18513478022.

I think it's useful to know this rationale (even more so because
the arguments about caching seem no longer correct these days).

Also, add the line about loading progress not being known when
using this method.

(Slightly related to T216034)

Change-Id: I81fa90483c0c85fecc5cb620196521ce8bdd33a7

2 years agoobjectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()
Aaron Schulz [Wed, 13 Feb 2019 18:54:39 +0000 (10:54 -0800)]
objectcache: cleanup tombstone/mutex logic in doGetWithSetCallback()

This largely follows-up 6b2f13b055c84d.

* Make the comments and use of temporary variables easier to follow.
* Simplified some conditionals by remove redundant checks.
* Bypass the final set() call if $isTombstone is true. It will almost
  always be rejected due to the tombstone still being there anyway, so
  there is no point in the roundtrips. Also, the most likely case where
  it would succeed is due to the callback taking a long time to run, in
  which case data from the replication lag uncertainty period that the
  tombstone represents would be getting saved to cache with the full
  nominal TTL, which is wrong.

Change-Id: Ic28e15b24f39e128bd72ad4d905edb852bc907aa

2 years agomediawiki.special.changeslist.enhanced: Convert CSS to LESS
Fomafix [Wed, 13 Feb 2019 13:07:26 +0000 (14:07 +0100)]
mediawiki.special.changeslist.enhanced: Convert CSS to LESS

Change-Id: Ic71a6bce99fd6417f90b5abdd52dcfa10e62029d

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 13 Feb 2019 21:01:42 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I377eb66bceaf7e946bbcdb51cf767d96be3e24c9

2 years agoMerge "Add missing documentation to ProtectedTitlesPager"
jenkins-bot [Wed, 13 Feb 2019 20:36:32 +0000 (20:36 +0000)]
Merge "Add missing documentation to ProtectedTitlesPager"

2 years agoMerge "rdbms: Use more narrow type hints in LBFactoryTest"
jenkins-bot [Wed, 13 Feb 2019 18:47:02 +0000 (18:47 +0000)]
Merge "rdbms: Use more narrow type hints in LBFactoryTest"

2 years agordbms: Use more narrow type hints in LBFactoryTest
Thiemo Kreuz [Tue, 12 Feb 2019 12:01:26 +0000 (13:01 +0100)]
rdbms: Use more narrow type hints in LBFactoryTest

Originally I wanted to fix the broken type hint for the `Database`
class. But I ended limiting the scope as much as possible and only
type hint at the interfaces that contain the methods the code actually

Change-Id: I450a55e80612f6e676f7c803dc904b4b653426d8

2 years agomediawiki.special.changeslist.legend: Convert CSS to LESS
Fomafix [Wed, 13 Feb 2019 11:27:20 +0000 (12:27 +0100)]
mediawiki.special.changeslist.legend: Convert CSS to LESS

Change-Id: I543cb50958689af6b32d3cd462a8f77f31724a03

2 years agoMerge "rdbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged"
jenkins-bot [Wed, 13 Feb 2019 17:52:30 +0000 (17:52 +0000)]
Merge "rdbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged"

2 years agoFix CommentStoreComment RawMessage construction
Lucas Werkmeister [Wed, 13 Feb 2019 10:44:06 +0000 (11:44 +0100)]
Fix CommentStoreComment RawMessage construction

If a CommentStoreComment is constructed without a Message argument, then
the RawMessage it uses instead should specify the comment text as a
plain-text parameter, not as a regular parameter: we don’t want any
syntax in the text to be interpreted at the Message level.

Change-Id: If14debde2bceae695c8955604ee96bd5005d8b66

2 years agoMerge "resourceloader: Ignore warnings in JSMinPlus parser"
jenkins-bot [Wed, 13 Feb 2019 05:36:11 +0000 (05:36 +0000)]
Merge "resourceloader: Ignore warnings in JSMinPlus parser"

2 years agoregistration: Allow @-prefixed keys in manifest_version 2
Stanislav Malyshev [Fri, 8 Feb 2019 20:13:49 +0000 (12:13 -0800)]
registration: Allow @-prefixed keys in manifest_version 2

As specified in

Bug: T215650
Change-Id: I2ff523828389fbec39cdf7c55046e7da901a2ecb

2 years agoresourceloader: Ignore warnings in JSMinPlus parser
Timo Tijhof [Wed, 13 Feb 2019 01:45:56 +0000 (01:45 +0000)]
resourceloader: Ignore warnings in JSMinPlus parser

It's old and unmaintained. The only thing we care about is if it
was able to parse the script and if not, what its error is. Its
return value or broken inner workings are insignificant at this
point and only cause noise.

Bug: T77169
Change-Id: Ie357ccfcc6141f894b452eb3996e168c1526990f

2 years agoUpdate AtEase calls to use Wikimedia namespace
Reedy [Tue, 12 Feb 2019 23:48:31 +0000 (23:48 +0000)]
Update AtEase calls to use Wikimedia namespace

Helps ease migration (stops vendor patch failing)

Change-Id: I9a985b341e1c3664c4ced6f793b19149067a580a

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 12 Feb 2019 20:54:12 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia27cd1dfe1e1fecdff6431841c9e26a2daf3a865

2 years agordbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged
Aaron Schulz [Tue, 12 Feb 2019 18:52:31 +0000 (10:52 -0800)]
rdbms: avoid duplicate spammy logging in LoadBalancer::getRandomNonLagged

This is already logged in LoadMonitor in getServerStates() in a less spammy way
(due to APC caching of server states).

Bug: T215611
Change-Id: Id70fdfa62eff9cb6446deea5e197f4c0af4928aa

2 years agoMerge "Prevent fatal PHP errors when PageRestriction::getTitle() returns null."
jenkins-bot [Tue, 12 Feb 2019 16:27:04 +0000 (16:27 +0000)]
Merge "Prevent fatal PHP errors when PageRestriction::getTitle() returns null."

2 years agoUpdate @deprecated comment for the DB_SLAVE constant
Thiemo Kreuz [Tue, 12 Feb 2019 12:03:38 +0000 (13:03 +0100)]
Update @deprecated comment for the DB_SLAVE constant

I keep searching for the proper replacement for this deprecated
constant. It's much easier to find when the @deprecated comment
just mentions it.

Change-Id: I199b876ecfb6e146848b395bc7bfad80742f000d

2 years agoAdd missing documentation to ProtectedTitlesPager
Thiemo Kreuz [Tue, 12 Feb 2019 11:57:05 +0000 (12:57 +0100)]
Add missing documentation to ProtectedTitlesPager

This was discussed in I2b5c95d. The reason no IDE was able to find this
usage of the deprecated SpecialPage::getTitle method was the missing
type hinting.

* A lot of properties this class uses are not declared.
* A lot of stuff in here must be private, but is public at the moment.
But this is for later patches.

Change-Id: I12fd6e517e5bd3507032ee3aafcb1de96733985b

2 years agoUse "try-catch" block instead of "if" block to prevent interruption of new installation
RazeSoldier [Mon, 11 Feb 2019 11:49:38 +0000 (19:49 +0800)]
Use "try-catch" block instead of "if" block to prevent interruption of new installation

New installation blocked when checking if the DB exists,
because when select DB, if it fails, it will throw an exception.

So I modify the checking logic to determine if there is an exception
thrown instead of detecting the return value.

Bug: T215566
Change-Id: I6817997434df7adc79fbc1b224b77c0daa8cc11d

2 years agowidgets: Remove redundant equality check in SelectWithInputWidget
Derick Alangi [Mon, 11 Feb 2019 14:59:36 +0000 (15:59 +0100)]
widgets: Remove redundant equality check in SelectWithInputWidget

The check `if ( $config['disabled'] == true )` is the same as the
check `if ( $config['disabled'] )`. Was this intentional or was it
supposed to be a test for equality and type (===)? If not, then I
think this patch removes the irrelevancy.

Clearly, if the $config['disabled'] is set to false, the isset()
check will return true but the second check will fail even with
this patch as it does the same thing.

Change-Id: Ibbe5b4949590f8ac954f613236056dd2e6dd18ba

2 years agoUpdate wikimedia/xmp-reader from 0.6.1 to 0.6.2
Reedy [Tue, 12 Feb 2019 01:24:17 +0000 (01:24 +0000)]
Update wikimedia/xmp-reader from 0.6.1 to 0.6.2

Change-Id: Ie396666aae2122dc552f6f1a7f6fe6ff96387fd1
Depends-On: Ia5dcf97548ed1c1f17cce9701df5cf13eea814dd

2 years agoUpdate wikimedia/php-session-serializer from v1.0.6 to v1.0.7
Reedy [Tue, 12 Feb 2019 00:40:12 +0000 (00:40 +0000)]
Update wikimedia/php-session-serializer from v1.0.6 to v1.0.7

Change-Id: Id30bb862bec42e508b3551d39f5980d900ade206
Depends-On: Ia19d237198fd2a0a15db467ec9dd97e98a857e33

2 years agojquery.makeCollapsible.styles: Avoid FOUC for collapse button
Fomafix [Tue, 12 Feb 2019 01:22:47 +0000 (02:22 +0100)]
jquery.makeCollapsible.styles: Avoid FOUC for collapse button

The expand button on a <div> element has already a pseudo-class with the
expand text as content. For the collapse button this pseudo-class is

This change adds the missing pseudo-class for the collapse button to
prevent a missing button while loading.

The missing collapse button while loading is visible on
Special:RecentChanges. The expand button is always there.

Change-Id: I7fa80238d54ac43a96bf1d70bd42a0cccf90a73a

2 years agoMerge "Revert "RCFilters: Export config vars in the RL modules where possible""
jenkins-bot [Tue, 12 Feb 2019 01:16:50 +0000 (01:16 +0000)]
Merge "Revert "RCFilters: Export config vars in the RL modules where possible""

2 years agoRevert "RCFilters: Export config vars in the RL modules where possible"
Catrope [Tue, 12 Feb 2019 00:54:39 +0000 (00:54 +0000)]
Revert "RCFilters: Export config vars in the RL modules where possible"

This reverts commit bf4f9d0313495dd67a53b9925edf9a3cc6ef36fe.

Reason for revert: causes issues with OAuth extension

The OAuth extension uses a hook to override certain tag messages, and
that hook uses RequestContext::getMain()->msg(), which tries to load
the current user. That's not allowed in load.php requests, so we get a
"Sessions are disabled for this entry point" error.

Change-Id: If58b7edfca116cd7a11f38556f74bed82609d96a

2 years agoEnhancedChangesList: Load style module via addModuleStyles()
Fomafix [Sun, 10 Feb 2019 15:04:57 +0000 (16:04 +0100)]
EnhancedChangesList: Load style module via addModuleStyles()

This change avoids a flash of missing collapsible toggle icons while

Change-Id: I090b1622868f2e5a01ca783dfce3be16b7d6b525

2 years agoUpdate wikimedia/ip-set 2.0.0 to 2.0.1
Reedy [Tue, 12 Feb 2019 00:28:49 +0000 (00:28 +0000)]
Update wikimedia/ip-set 2.0.0 to 2.0.1

Change-Id: I154a677bac28a451be4f203ff05ea4620260b54e
Depends-On: I1090817a5ff1e406cf51596a8b1558c7bd3ca7d7

2 years agoMerge "ChangesList: Remove spaces from <td> in EnhancedChangesListGroup.mustache"
jenkins-bot [Tue, 12 Feb 2019 00:26:42 +0000 (00:26 +0000)]
Merge "ChangesList: Remove spaces from <td> in EnhancedChangesListGroup.mustache"

2 years agoMerge "ProtectionForm: Move JS config var to RL packageFiles"
jenkins-bot [Tue, 12 Feb 2019 00:14:25 +0000 (00:14 +0000)]
Merge "ProtectionForm: Move JS config var to RL packageFiles"

2 years agoChangesList: Remove spaces from <td> in EnhancedChangesListGroup.mustache
Fomafix [Sun, 10 Feb 2019 20:01:25 +0000 (21:01 +0100)]
ChangesList: Remove spaces from <td> in EnhancedChangesListGroup.mustache

The special page RecentChanges can included in wiki content via


In this case the generated content is parsed by a wikitext parser. The
wikitext parser converts


to the HTML


But the wikitext


is converted to the HTML


The module 'jquery.makeCollapsible' supports custom collapsible toggle
buttons but only when they are a direct child of the <td> element. When
the module does not find a custom collapsible toggle button it adds the
default button [Expand].

Because of the additional <p> element when including the recent changes
the module 'jquery.makeCollapsible' adds a default collapsible toggle

This change removes the spaces between <td> and <span> to prevent the
<p> elements when including the recent changes.

Bug: T215737
Change-Id: Ida46956fc7f9ab923c542751ac13411380c02ab0

2 years agoMerge "Job::factory should throw an InvalidArgumentException, not MWException"
jenkins-bot [Mon, 11 Feb 2019 23:50:13 +0000 (23:50 +0000)]
Merge "Job::factory should throw an InvalidArgumentException, not MWException"

2 years agoJob::factory should throw an InvalidArgumentException, not MWException
Derick Alangi [Wed, 30 Jan 2019 19:40:46 +0000 (20:40 +0100)]
Job::factory should throw an InvalidArgumentException, not MWException

Change-Id: I9a85562b205db604d2746ec5db0e72dacdb93c6d

2 years agoMerge "mw.widgets: Use CSS grid for the calendar in supporting browsers"
jenkins-bot [Mon, 11 Feb 2019 22:21:45 +0000 (22:21 +0000)]
Merge "mw.widgets: Use CSS grid for the calendar in supporting browsers"

2 years agomw.widgets: Use CSS grid for the calendar in supporting browsers
Bartosz Dziewoński [Wed, 30 Jan 2019 23:54:42 +0000 (15:54 -0800)]
mw.widgets: Use CSS grid for the calendar in supporting browsers

Bug: T214997
Change-Id: I05dca01585f3de86580e7ae94ceeae1716f56ba3

2 years agoMerge "parser: Add new pcache metrics, split by page content model"
jenkins-bot [Mon, 11 Feb 2019 21:05:48 +0000 (21:05 +0000)]
Merge "parser: Add new pcache metrics, split by page content model"

2 years agoMerge "registration: Define packageFiles for v1 extension schema"
jenkins-bot [Mon, 11 Feb 2019 21:05:42 +0000 (21:05 +0000)]
Merge "registration: Define packageFiles for v1 extension schema"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 11 Feb 2019 20:54:25 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Id809e80a46547f7bf042eb6073efd7a519666ce7

2 years agoparser: Add new pcache metrics, split by page content model
addshore [Thu, 24 Jan 2019 16:58:04 +0000 (17:58 +0100)]
parser: Add new pcache metrics, split by page content model

Change-Id: I31c3c5b863309ffcc4424c43891b577b3fb7a753

2 years agoregistration: Define packageFiles for v1 extension schema
Gilles Dubuc [Mon, 11 Feb 2019 20:39:41 +0000 (21:39 +0100)]
registration: Define packageFiles for v1 extension schema

Follows 56fa42d4332c.

Bug: T215756
Change-Id: Icbf433b6b147f53cf99533a7272fc83392a8999d

2 years agoMerge "Add ability to define packageFiles in extension.json"
jenkins-bot [Mon, 11 Feb 2019 18:27:04 +0000 (18:27 +0000)]
Merge "Add ability to define packageFiles in extension.json"

2 years agoMerge "Change `.forEach()` to `for ()` loop with break"
jenkins-bot [Mon, 11 Feb 2019 18:10:02 +0000 (18:10 +0000)]
Merge "Change `.forEach()` to `for ()` loop with break"

2 years agoMerge "mw.widgets: Make TitleSearchWidget read-only-able"
jenkins-bot [Mon, 11 Feb 2019 17:42:37 +0000 (17:42 +0000)]
Merge "mw.widgets: Make TitleSearchWidget read-only-able"

2 years agoChange `.forEach()` to `for ()` loop with break
Fomafix [Thu, 13 Sep 2018 18:38:09 +0000 (20:38 +0200)]
Change `.forEach()` to `for ()` loop with break

Follow-up to change 1edba8029, which replaced:
  $.each( array, function ( index, value ) { ... } )
  array.forEach( function ( value, index ) { ... } )

`jQuery.each` makes a break of the loop on a `return false`.
`Array.prototype.forEach` ignores the return value and there
is no way to stop or break a `forEach()` loop other than by
throwing an exception. [1]

A `$.each` with a `return false` could be replaced by
`Array.prototype.find`, but `find()` is not part of ES5. [2]

  return this.getItems().find( function ( filterItem ) {
    return filterItem.isSelected() && filterItem.isConflicted();
  } );

So a simple `for ()` loop with a `break` or a `return` is
used in these cases.

Also explicitly specify `undefined` as possible return value
in FiltersViewModel.prototype.getFirstConflictedItem.

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach
[2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

Change-Id: I0af89d39ed789f49e06b25cac14ecd995ba58cbd

2 years agoMerge "Exception is never thrown in the getConnection() method"
jenkins-bot [Mon, 11 Feb 2019 15:07:41 +0000 (15:07 +0000)]
Merge "Exception is never thrown in the getConnection() method"

2 years agomw.widgets: Make TitleSearchWidget read-only-able
Ed Sanders [Mon, 11 Feb 2019 13:52:39 +0000 (13:52 +0000)]
mw.widgets: Make TitleSearchWidget read-only-able

Change-Id: I3eed52438c1e416d4dcdedb564bb9df3745d0f77

2 years agoRemove unused @throws anotation from PHPDoc comment
Derick Alangi [Mon, 11 Feb 2019 12:01:11 +0000 (13:01 +0100)]
Remove unused @throws anotation from PHPDoc comment

Change-Id: If60ad5c12edbf4ea96c5c337f0c05cf0a8d5e43d

2 years agoProtectionForm: Move JS config var to RL packageFiles
Fomafix [Mon, 17 Sep 2018 20:14:53 +0000 (22:14 +0200)]
ProtectionForm: Move JS config var to RL packageFiles

The check for type Array of the JavaScript config variable is obsolete.

Change-Id: I4a38cfc211360c831958ce8ca88584cdf56a727c

2 years agoAdd ability to define packageFiles in extension.json
Gilles Dubuc [Mon, 11 Feb 2019 09:53:09 +0000 (10:53 +0100)]
Add ability to define packageFiles in extension.json

Bug: T215756
Change-Id: I97c3ccc13c54b424952ce15509b98a217b2670b1

2 years agoMerge "Add jakub-onderka/php-console-highlighter 0.3.2 explicitly"
jenkins-bot [Mon, 11 Feb 2019 03:54:58 +0000 (03:54 +0000)]
Merge "Add jakub-onderka/php-console-highlighter 0.3.2 explicitly"

2 years agoAdd jakub-onderka/php-console-highlighter 0.3.2 explicitly
Reedy [Mon, 11 Feb 2019 03:27:55 +0000 (03:27 +0000)]
Add jakub-onderka/php-console-highlighter 0.3.2 explicitly

We pin it in various libraries, might aswell in core for completenes

Change-Id: I659c880c9e16e4eab7050874f75c9eb5c9fa958c

2 years agoUpdate cssjanus from 1.2.0 to 1.2.1
Reedy [Mon, 11 Feb 2019 02:02:04 +0000 (02:02 +0000)]
Update cssjanus from 1.2.0 to 1.2.1

Change-Id: I99f11a24ff0a8b02b1c0103ad8cb8faeb165c84e
Depends-On: Iee4c24b6b5dd92493160caafa4764b6d6e427147

2 years agoMerge "Updated pear/net_smtp from 1.8.0 to 1.8.1"
jenkins-bot [Mon, 11 Feb 2019 00:58:25 +0000 (00:58 +0000)]
Merge "Updated pear/net_smtp from 1.8.0 to 1.8.1"

2 years agoMerge "ParserTestPrinter: use Shell class"
jenkins-bot [Mon, 11 Feb 2019 00:53:07 +0000 (00:53 +0000)]
Merge "ParserTestPrinter: use Shell class"

2 years agoMerge "JpegPixelFormatTest: use Shell class"
jenkins-bot [Mon, 11 Feb 2019 00:51:56 +0000 (00:51 +0000)]
Merge "JpegPixelFormatTest: use Shell class"

2 years agoMerge "Linker: Remove some else statements, and unnecessary temporary variables"
jenkins-bot [Mon, 11 Feb 2019 00:43:31 +0000 (00:43 +0000)]
Merge "Linker: Remove some else statements, and unnecessary temporary variables"

2 years agoMerge "Make attachLatest.php wait for DB replica lag"
jenkins-bot [Mon, 11 Feb 2019 00:37:59 +0000 (00:37 +0000)]
Merge "Make attachLatest.php wait for DB replica lag"

2 years agoUpdated pear/net_smtp from 1.8.0 to 1.8.1
Reedy [Sun, 10 Feb 2019 23:00:06 +0000 (23:00 +0000)]
Updated pear/net_smtp from 1.8.0 to 1.8.1

Depends-On: I6543ac3e6482da197ce2d644823861d1db4624d8
Change-Id: I91b3c2864536a53fcc829a1e10a3bc0d4638db2b

2 years agoLinker: Remove some else statements, and unnecessary temporary variables
Reedy [Sat, 9 Feb 2019 07:25:57 +0000 (07:25 +0000)]
Linker: Remove some else statements, and unnecessary temporary variables

Change-Id: I9b9383459edf06280135d9709da889fc5a688c98

2 years agoUpdate dev dependancies
Reedy [Sun, 10 Feb 2019 22:37:29 +0000 (22:37 +0000)]
Update dev dependancies

* Updated psy/psysh from 0.9.6 to 0.9.9 (dev-only).
* Updated nikic/php-parser from 3.1.3 to 3.1.5 (dev-only).

Change-Id: I05e45327e93d3bc733db73c0efe573b3223cc902
Depends-On: I896ac6c5afa8221ceca726eb7895e05d87d7e6f3

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 10 Feb 2019 20:56:24 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I26dda2663489848ffc75fc54b766fb827eeff4de

2 years agoMake attachLatest.php wait for DB replica lag
Reedy [Sat, 9 Feb 2019 23:27:14 +0000 (23:27 +0000)]
Make attachLatest.php wait for DB replica lag

Change-Id: I4f402ba772d0b0dda8360eaacf11e318f659efc0

2 years agobuild: Use headless Chrome and Firefox for QUnit testing
Timo Tijhof [Wed, 23 Jan 2019 23:51:49 +0000 (15:51 -0800)]
build: Use headless Chrome and Firefox for QUnit testing


* Remove "watch" task from Gruntfile.
  This wasn't exposed via npm-run and afaik rarely if ever used.
  It seems mostly obsoleted by modern editors which perform
  linting and style guidance as-you-type and on-save.

* Remove "chromium" target from karma config, the default
  target supports both Chromium and Chrome.

* Remove unused "default" alias in Gruntfile. Was only
  accessible if developers installed grunt-cli globally, which
  we don't require and shouldn't encourage. The new minify task
  is now exposed as "npm run build".

* Remove "test" alias in Gruntfile. Was only used by "npm run test",
  which now uses "grunt lint" directly, which makes it more clear
  that these are only linters, and not unit tests.

This references T211784 because ensuring no headed browsers are used
(which would need Xvfb to start), is a prerequisite for the new Node 10
images. We may still need to provide a slower Xvfb-wrapped variant for
some repos, but would be nice of mw-core wasn't one of them.

Bug: T211784
Change-Id: I270a16d2b4f799ac7c9f84e9e2ee23806bdbc57e

2 years agoParserTestPrinter: use Shell class
Max Semenik [Sun, 10 Feb 2019 06:25:57 +0000 (22:25 -0800)]
ParserTestPrinter: use Shell class

Change-Id: I9e2eb3b01a9907d72e3edaa6660a4057d513942e

2 years agoJpegPixelFormatTest: use Shell class
Max Semenik [Sun, 10 Feb 2019 06:20:25 +0000 (22:20 -0800)]
JpegPixelFormatTest: use Shell class

Change-Id: I53099827dc2b2b26b7f3cbc9f0e12030868fdafd

2 years agoMerge "build: Update karma to 3.1.4"
jenkins-bot [Sun, 10 Feb 2019 06:19:28 +0000 (06:19 +0000)]
Merge "build: Update karma to 3.1.4"

2 years agoMerge "Hard deprecate Language::setCode"
jenkins-bot [Sun, 10 Feb 2019 06:03:08 +0000 (06:03 +0000)]
Merge "Hard deprecate Language::setCode"

2 years agobuild: Update karma to 3.1.4
Timo Tijhof [Sun, 10 Feb 2019 04:00:38 +0000 (04:00 +0000)]
build: Update karma to 3.1.4

This fixes the bug where HeadlessChrome was always shown as
version 0.0.0 in the console output, which makes it rather
difficult to debug which Chrome version is installed.

Upstream https://github.com/karma-runner/karma/issues/2762,
which updates the ua-parser library to a version that fixes
that bug.

Change-Id: I0b7fe7f8a90649592c4d31fb3055cdc9e8d34814

2 years agoRCFilters: Export config vars in the RL modules where possible
Roan Kattouw [Sat, 9 Feb 2019 22:59:10 +0000 (14:59 -0800)]
RCFilters: Export config vars in the RL modules where possible

Right now there are only a few settings that don't depend on the request
context, but we can at least export those. The tag data in
particular can get pretty big.

Downgrade the type hint for ChangeTags::tagDescription() and
tagLongDescriptionMessage() from IContextSource to MessageLocalizer, so
we can pass a ResourceLoaderContext to these functions. (Since
IContextSource extends MessageLocalizer, this won't break any callers.)

truncateTagDescription() can't be downgraded to MessageLocalizer because
it needs a Language object, so hack up a fake RequestContext when
calling it. It would be nice if this weren't necessary; perhaps we can
move getLanguage() from IContextSource up into MessageLocalizer?

Bug: T201574
Change-Id: I9b66e35de826a07aa9551ba285e64e4852293229