lhc/web/wiklou.git
2 years agoAdd ability to override mb_strtoupper in Language::ucfirst
Giuseppe Lavagetto [Tue, 9 Apr 2019 17:02:03 +0000 (19:02 +0200)]
Add ability to override mb_strtoupper in Language::ucfirst

Different PHP versions treat unicode differently, and specifically some
wiki resources become unreachable if mb_strtoupper's behavior has changed.
This patch allows to introduce an override table that allows to smooth
the transition period.

It also provides maintenance scripts to generate such an override table.

Bug: T219279
Change-Id: I0503ff4207fded4648c58c7b50e67c55422a4849

2 years agoUpdate OOUI to v0.31.4
James D. Forrester [Tue, 16 Apr 2019 23:22:32 +0000 (16:22 -0700)]
Update OOUI to v0.31.4

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.4

Bug: T163142
Bug: T208547
Bug: T220041
Bug: T220204
Bug: T220227
Bug: T220248
Bug: T220840
Change-Id: Ic94a2f6790334baad7bc9c3055e990f7d3917e17
Depends-On: I0a2e152e61700e723a9ad7cd061682efaa9faf4d

2 years agoMerge "api: Remove 'recenteditcount' set for BC to be removed in 1.25"
jenkins-bot [Tue, 16 Apr 2019 21:13:58 +0000 (21:13 +0000)]
Merge "api: Remove 'recenteditcount' set for BC to be removed in 1.25"

2 years agoMerge "Remove usages of 'text' flag in revision-related getQueryInfo() calls"
jenkins-bot [Tue, 16 Apr 2019 21:13:47 +0000 (21:13 +0000)]
Merge "Remove usages of 'text' flag in revision-related getQueryInfo() calls"

2 years agoapi: Remove 'recenteditcount' set for BC to be removed in 1.25
Derick Alangi [Mon, 1 Apr 2019 00:15:10 +0000 (01:15 +0100)]
api: Remove 'recenteditcount' set for BC to be removed in 1.25

This was a TODO that needed cleanup in mediawiki version 1.25 but
code was still hanging around. Removing it as we're in .34

Change-Id: I0d996362612495b3c523aed5af3a0e30ee4ed79c

2 years agoRemove usages of 'text' flag in revision-related getQueryInfo() calls
Bill Pirkle [Tue, 16 Apr 2019 16:46:38 +0000 (11:46 -0500)]
Remove usages of 'text' flag in revision-related getQueryInfo() calls

Field rev_text_id will no longer be populated once the legacy
schema is disabled, so joins against it will not work.
Remove all usages of the 'text' flag in calls to both
Revision::getQueryInfo() and RevisionStore::getQueryInfo()
so that these joins are no longer attempted.

Bug: T198342
Change-Id: I9be6a544c6f68555d4ea856f949f0040d05eac0f

2 years agoMerge "changetags: $param type should be string and not array"
jenkins-bot [Tue, 16 Apr 2019 20:16:47 +0000 (20:16 +0000)]
Merge "changetags: $param type should be string and not array"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 16 Apr 2019 20:09:22 +0000 (22:09 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ief398fcf2575c4ff49e6db20f7f4c3a64b7209d8

2 years agochangetags: $param type should be string and not array
Derick Alangi [Mon, 15 Apr 2019 20:33:18 +0000 (21:33 +0100)]
changetags: $param type should be string and not array

Per the call to updateTagsWithChecks(), $params should be a string
and not an array as soft type hinted. The previous calls updateTags()
which uses $param as a string or null.

Change-Id: I87fa39682d91b7cb3b0844d0aabbfaea0cb6f206

2 years agoMerge "context: Replace deprecated use of SkinFactory::getDefaultInstance()"
jenkins-bot [Tue, 16 Apr 2019 19:11:18 +0000 (19:11 +0000)]
Merge "context: Replace deprecated use of SkinFactory::getDefaultInstance()"

2 years agoMerge "diff: Wrap condition around brackets for more readability"
jenkins-bot [Tue, 16 Apr 2019 18:46:20 +0000 (18:46 +0000)]
Merge "diff: Wrap condition around brackets for more readability"

2 years agoMerge "resourceloader: Remove 'wgMainPageTitle' mw.config key"
jenkins-bot [Tue, 16 Apr 2019 09:40:24 +0000 (09:40 +0000)]
Merge "resourceloader: Remove 'wgMainPageTitle' mw.config key"

2 years agoMerge "clientpool: Remove unused parameter from constructor header"
jenkins-bot [Tue, 16 Apr 2019 04:52:09 +0000 (04:52 +0000)]
Merge "clientpool: Remove unused parameter from constructor header"

2 years agoMerge "resources: Rename a few local 'filterFn' vars to 'filterFunction'"
jenkins-bot [Mon, 15 Apr 2019 23:23:46 +0000 (23:23 +0000)]
Merge "resources: Rename a few local 'filterFn' vars to 'filterFunction'"

2 years agoresources: Rename a few local 'filterFn' vars to 'filterFunction'
Lucas Werkmeister [Fri, 22 Mar 2019 18:40:53 +0000 (19:40 +0100)]
resources: Rename a few local 'filterFn' vars to 'filterFunction'

Abbreviations are discouraged, so let’s use the full word.

Change-Id: I31fb4cca32d766559005d1291d6d22da3d74b5e6

2 years agoMerge "Allow fragment-only TitleValues"
jenkins-bot [Mon, 15 Apr 2019 22:15:06 +0000 (22:15 +0000)]
Merge "Allow fragment-only TitleValues"

2 years agoMerge "Normalize input to TitleParser::parseTitle()"
jenkins-bot [Mon, 15 Apr 2019 22:14:59 +0000 (22:14 +0000)]
Merge "Normalize input to TitleParser::parseTitle()"

2 years agoMerge "New Title::castFromLinkTarget/TitleValue"
jenkins-bot [Mon, 15 Apr 2019 22:13:38 +0000 (22:13 +0000)]
Merge "New Title::castFromLinkTarget/TitleValue"

2 years agoMerge "Update MediaWikiTitleCodec to use NamespaceInfo"
jenkins-bot [Mon, 15 Apr 2019 21:40:16 +0000 (21:40 +0000)]
Merge "Update MediaWikiTitleCodec to use NamespaceInfo"

2 years agoMerge "Rename un-prefixed rcfilters selectors"
jenkins-bot [Mon, 15 Apr 2019 21:38:35 +0000 (21:38 +0000)]
Merge "Rename un-prefixed rcfilters selectors"

2 years agoMerge "Tweak margins for collapsible OOUI HTMLForms some more"
jenkins-bot [Mon, 15 Apr 2019 20:54:19 +0000 (20:54 +0000)]
Merge "Tweak margins for collapsible OOUI HTMLForms some more"

2 years agoMerge "JsonContent: Remove never-used caption styles"
jenkins-bot [Mon, 15 Apr 2019 20:28:22 +0000 (20:28 +0000)]
Merge "JsonContent: Remove never-used caption styles"

2 years agoMerge "resourceloader: Use 'fallback' as default for ResourceLoaderTestCase"
jenkins-bot [Mon, 15 Apr 2019 20:28:15 +0000 (20:28 +0000)]
Merge "resourceloader: Use 'fallback' as default for ResourceLoaderTestCase"

2 years agoMerge "resourceloader: Declare ResourceLoaderImage fields explicitly"
jenkins-bot [Mon, 15 Apr 2019 20:22:21 +0000 (20:22 +0000)]
Merge "resourceloader: Declare ResourceLoaderImage fields explicitly"

2 years agoMerge "Remove obsolete `color` property from horizontal rule"
jenkins-bot [Mon, 15 Apr 2019 20:19:05 +0000 (20:19 +0000)]
Merge "Remove obsolete `color` property from horizontal rule"

2 years agoMerge "Set global config for test to avoid failure"
jenkins-bot [Mon, 15 Apr 2019 20:17:30 +0000 (20:17 +0000)]
Merge "Set global config for test to avoid failure"

2 years agoclientpool: Remove unused parameter from constructor header
Derick Alangi [Mon, 15 Apr 2019 20:14:05 +0000 (21:14 +0100)]
clientpool: Remove unused parameter from constructor header

Per https://codesearch.wmflabs.org/search/?q=SquidPurgeClient&i=nope&files=&repos=,
constructing an SquidPargeClient requires only the $server argument and
doesn't make use of $options yet. Maybe this was a WIP but for now, it's
never used, so cleaning it up.

Change-Id: I2d86ac6b17ac8dce85c05887de8eee4bb3dd28a5

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 15 Apr 2019 20:11:57 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ida17cce17aa1b580a88aa9c767362e739364d1e3

2 years agoTweak margins for collapsible OOUI HTMLForms some more
Bartosz Dziewoński [Mon, 15 Apr 2019 19:52:13 +0000 (21:52 +0200)]
Tweak margins for collapsible OOUI HTMLForms some more

* Move the code from mediawiki.action.history.styles, as it's
  theoretically applicable to other similar forms
* Fix it so that it actually only applies when JS is available
* Make top and bottom margins/paddings even

Follow-up to 32bca54dc94b1befcf21483d9f08017a91ad73eb.

Change-Id: Ifde2303f78f971f1e82418c9bd5feddbd6f1f25d

2 years agoMerge "specials: Add $subpage param to RedirectSpecialPage::getRedirectQuery"
jenkins-bot [Mon, 15 Apr 2019 19:34:24 +0000 (19:34 +0000)]
Merge "specials: Add $subpage param to RedirectSpecialPage::getRedirectQuery"

2 years agoMerge "db: Use $fname instead of __METHOD__ magic constant"
jenkins-bot [Mon, 15 Apr 2019 19:31:17 +0000 (19:31 +0000)]
Merge "db: Use $fname instead of __METHOD__ magic constant"

2 years agocontext: Replace deprecated use of SkinFactory::getDefaultInstance()
Derick Alangi [Mon, 15 Apr 2019 19:21:21 +0000 (20:21 +0100)]
context: Replace deprecated use of SkinFactory::getDefaultInstance()

Replace with MediaWikiServices::getInstance()->getSkinFactory()

Change-Id: I2cf7afad249e52e13a56fbe92b1665dfebec793f

2 years agoresourceloader: Use 'fallback' as default for ResourceLoaderTestCase
Timo Tijhof [Mon, 15 Apr 2019 19:21:00 +0000 (20:21 +0100)]
resourceloader: Use 'fallback' as default for ResourceLoaderTestCase

Follows-up fa05976f5f. This broke the Travis CI tests because
the Vector skin is not installed there (unlike in Wikimedia CI).

Make the test no longer reliant on that detail.

* Fix ResourceLoaderTestCase to use a default that actually
  works in plain core (previously 'vector' would be rejected
  as being an unknown skin, but then be re-normalised back to
  'vector' thanks to wgDefaultSkin. This was fixed in fa05976f5f,
  and the unknown skin now produces 'fallback' which is better.

* Update ResourceLoaderOOUIImageModuleTest to match this
  new default and also fix the test message while at it
  to mention 'skin', not 'image'.

Change-Id: I5fb69a6a38a42b1a5f325c0134e01ad880f65087

2 years agoMerge "specials: Remove invalid return from RedirectSpecialPage::execute"
jenkins-bot [Mon, 15 Apr 2019 19:19:40 +0000 (19:19 +0000)]
Merge "specials: Remove invalid return from RedirectSpecialPage::execute"

2 years agoMerge "Fix calls to Title::getUserPermissionsErrors on SpecialImport"
jenkins-bot [Mon, 15 Apr 2019 19:13:58 +0000 (19:13 +0000)]
Merge "Fix calls to Title::getUserPermissionsErrors on SpecialImport"

2 years agoMerge "resourceloader: Remove needless MW-specific fallback"
jenkins-bot [Mon, 15 Apr 2019 18:58:25 +0000 (18:58 +0000)]
Merge "resourceloader: Remove needless MW-specific fallback"

2 years agoMerge "parser: use "-" for revision ID for non-preview edit filter parse during save"
jenkins-bot [Mon, 15 Apr 2019 18:42:22 +0000 (18:42 +0000)]
Merge "parser: use "-" for revision ID for non-preview edit filter parse during save"

2 years agoRemove obsolete `color` property from horizontal rule
Volker E [Mon, 15 Apr 2019 18:04:16 +0000 (11:04 -0700)]
Remove obsolete `color` property from horizontal rule

Removing `color` property definition, which dates back to IE 5/Mac
support times.
`background-color` is sufficient in any of our basic supported
browsers.

Change-Id: I013b9c5bc614299c94bb733fc724148e5c7b1343

2 years agoresourceloader: Remove 'wgMainPageTitle' mw.config key
Timo Tijhof [Mon, 15 Apr 2019 18:02:55 +0000 (19:02 +0100)]
resourceloader: Remove 'wgMainPageTitle' mw.config key

This was added in 2009 with cf75bdf4ba (r54384) and moved to the
startup module in 2010 with a99f9ec28b9 (r72772).

It is no longer used by any extension in Wikimedia Git, nor
elsewhere indexed by MediaWiki Codesearch. It also no longer has
any uses in mwgrep from public WMF wikis.

Bug: T220926
Depends-On: Ifdedccb513f5dd4636a37badc329ac5f1c4dd943
Change-Id: Id2729653cd450d31c1d903358ccf5e4fac564228

2 years agoresourceloader: Remove needless MW-specific fallback
Timo Tijhof [Thu, 11 Apr 2019 22:17:00 +0000 (23:17 +0100)]
resourceloader: Remove needless MW-specific fallback

This is never used by the mw.loader client code. For any
manually crafted requests or fringe usage where the load.php
might be used to fetch some raw JS code that doesn't vary by
language or skin, proceed with qqx/fallback.

In the future load.php might deny these requests and then we
could make this a constructor parameter to ResourceLoaderContext.

Bug: T32956
Change-Id: I4e4ee758cd22278cea9592d4745b4f7fc00e0add

2 years agoMerge "selenium: Replace regex matching with includes()"
jenkins-bot [Mon, 15 Apr 2019 17:30:47 +0000 (17:30 +0000)]
Merge "selenium: Replace regex matching with includes()"

2 years agoMerge "ContibsPager: Fix slow query with actor migration read-new mode"
jenkins-bot [Mon, 15 Apr 2019 17:28:52 +0000 (17:28 +0000)]
Merge "ContibsPager: Fix slow query with actor migration read-new mode"

2 years agoselenium: Replace regex matching with includes()
Cormac Parle [Fri, 12 Apr 2019 09:57:46 +0000 (10:57 +0100)]
selenium: Replace regex matching with includes()

Bug: T217544
Change-Id: Iedcbb1f7e21fc768069346ac346c2e499a689556

2 years agoContibsPager: Fix slow query with actor migration read-new mode
Brad Jorsch [Mon, 15 Apr 2019 14:41:03 +0000 (10:41 -0400)]
ContibsPager: Fix slow query with actor migration read-new mode

The change in I1678f7ec broke the workaround in I992aa50f by adding
the rev_id column to the ORDER BY clause. We need to extend the aliasing
to rev_id => revactor_rev to re-fix it.

Bug: T220991
Change-Id: I62dc3803621da982e526d7402ab8e7b08f8336bc

2 years agoresourceloader: Declare ResourceLoaderImage fields explicitly
Timo Tijhof [Mon, 15 Apr 2019 16:45:26 +0000 (17:45 +0100)]
resourceloader: Declare ResourceLoaderImage fields explicitly

Change-Id: I4153cbf6080dabd29f6fbe1fb546dc10957d780e

2 years agoMerge "resourceloader: Re-use internal addLink() for mw.loader.load()"
jenkins-bot [Mon, 15 Apr 2019 16:08:53 +0000 (16:08 +0000)]
Merge "resourceloader: Re-use internal addLink() for mw.loader.load()"

2 years agoRename un-prefixed rcfilters selectors
Ed Sanders [Fri, 12 Apr 2019 20:25:42 +0000 (21:25 +0100)]
Rename un-prefixed rcfilters selectors

Only -head and -container have on-wiki usage, so
keep deprecated aliases for those.

Bug: T220852
Change-Id: I67b120d67fbbdf108da98ddfc7eae24e668bfe11

2 years agoMerge "JsonContent: Add missing prefix to selector"
jenkins-bot [Mon, 15 Apr 2019 15:25:52 +0000 (15:25 +0000)]
Merge "JsonContent: Add missing prefix to selector"

2 years agodb: Use $fname instead of __METHOD__ magic constant
Derick Alangi [Mon, 15 Apr 2019 15:05:31 +0000 (16:05 +0100)]
db: Use $fname instead of __METHOD__ magic constant

The insert() method calls insertOneRow() method on line 391. It then
passes $fname which defaults to __METHOD__ in its function header and
not using $fname instead of __METHOD__ in insertOneRow() method makes
this parameter unused which of course should be used.

Change-Id: Ic5f5ee878e4f919a96900ba88755641ac85929df

2 years agospecials: Remove invalid return from RedirectSpecialPage::execute
Timo Tijhof [Sat, 6 Apr 2019 00:34:56 +0000 (01:34 +0100)]
specials: Remove invalid return from RedirectSpecialPage::execute

Follows-up f739a8f368a, and 22c9aa5ec07.

The execute() method here should generally be void, with the
exception of includable special pages, where the return value
is a string of HTML.

This was likely left-over early iteration of commit f739a8f368a,
which ended up returning from getRedirect() instead.

Change-Id: I68715910114e19a0421625e814fd8881068f6406

2 years agospecials: Add $subpage param to RedirectSpecialPage::getRedirectQuery
Timo Tijhof [Sat, 6 Apr 2019 00:50:55 +0000 (01:50 +0100)]
specials: Add $subpage param to RedirectSpecialPage::getRedirectQuery

This will make it easier to create redirects where $subpage is the title,
e.g. "Special:Example/Foo?x=y" to "index.php?title=Foo&x=y".

To do that conveniently, getRedirectQuery() needs access to $subpage.
The alternative is to do Title-parsing inside getRedirect(), which then
complicates this significantly as one has to deal with absence of a title
(null) and invalid titles (illegal chars etc.).

By using it plainly as query parameter (defaulting to null/omitted), this
is all deferred to index.php, which seems like a better separation of
concerns.

Motivated by SpecialMobileHistory in MobileFrontend (Ic0aea7ee340a).

Change-Id: I9fe78f479053fb55952ba78850d2fc281a039fe3

2 years agoFix calls to Title::getUserPermissionsErrors on SpecialImport
Amir Sarabadani [Mon, 15 Apr 2019 14:42:21 +0000 (16:42 +0200)]
Fix calls to Title::getUserPermissionsErrors on SpecialImport

Right now, it uses a deprecated way to set rigor causing it to read from
master on GET, giving out errors

Change-Id: I89bbe20080998bde2156680c631700b52f4e4712

2 years agoAllow fragment-only TitleValues
Aryeh Gregor [Mon, 15 Apr 2019 12:44:07 +0000 (15:44 +0300)]
Allow fragment-only TitleValues

This matches behavior of Title, and is meaningful for creating links.
However, in other contexts such a TitleValue doesn't make sense, so
perhaps we want to write special cases in linking code instead.

Change-Id: I812ad9090463766f38ef677de318c006912b4cca

2 years agoNormalize input to TitleParser::parseTitle()
Aryeh Gregor [Mon, 15 Apr 2019 12:42:03 +0000 (15:42 +0300)]
Normalize input to TitleParser::parseTitle()

This matches behavior of Title::newFromText(), which assists porting old
code to TitleParser.

Change-Id: I50e9af09df843ea575250e276c7cfce660c00efd

2 years agoNew Title::castFromLinkTarget/TitleValue
Aryeh Gregor [Sun, 14 Apr 2019 08:59:59 +0000 (11:59 +0300)]
New Title::castFromLinkTarget/TitleValue

These behave the same as newFromLinkTarget/TitleValue, but accept null
as well (and then just return null). This makes things much easier when
converting code from using Title to LinkTarget, because you can wrap in
castFromLinkTarget without adding null checks.

Change-Id: Id61f91d40b81ad226532917c43e51f0b69af712c

2 years agofilebackend: move more files to subdirectories
Aaron Schulz [Mon, 15 Apr 2019 09:30:24 +0000 (02:30 -0700)]
filebackend: move more files to subdirectories

Change-Id: If965323809c5bfc9cb73ed0f357233d9325d3353

2 years agoMerge "Cache: Make APCUBagOStuff::set return a useful value"
jenkins-bot [Mon, 15 Apr 2019 03:20:28 +0000 (03:20 +0000)]
Merge "Cache: Make APCUBagOStuff::set return a useful value"

2 years agoMerge "Split DairikiDiff to class per file"
jenkins-bot [Mon, 15 Apr 2019 03:01:00 +0000 (03:01 +0000)]
Merge "Split DairikiDiff to class per file"

2 years agoJsonContent: Add missing prefix to selector
Ed Sanders [Fri, 12 Apr 2019 19:45:35 +0000 (20:45 +0100)]
JsonContent: Add missing prefix to selector

Change-Id: I977f6c565b93949a310d1207411f893cf83af996

2 years agoMerge "selenium: Disable flaky wdio rollback tests that rely on pauses"
jenkins-bot [Sun, 14 Apr 2019 22:54:05 +0000 (22:54 +0000)]
Merge "selenium: Disable flaky wdio rollback tests that rely on pauses"

2 years agoMerge "Restore func_get_args in HTMLFormField"
jenkins-bot [Sun, 14 Apr 2019 22:47:28 +0000 (22:47 +0000)]
Merge "Restore func_get_args in HTMLFormField"

2 years agoSplit DairikiDiff to class per file
Reedy [Sun, 14 Apr 2019 22:13:01 +0000 (23:13 +0100)]
Split DairikiDiff to class per file

Change-Id: Ica426312ec69707b9a99dfe2a7deee945c38ba35

2 years agoMerge "Split filebackend files to class per file"
jenkins-bot [Sun, 14 Apr 2019 22:24:56 +0000 (22:24 +0000)]
Merge "Split filebackend files to class per file"

2 years agoselenium: Disable flaky wdio rollback tests that rely on pauses
Timo Tijhof [Sun, 14 Apr 2019 22:12:53 +0000 (23:12 +0100)]
selenium: Disable flaky wdio rollback tests that rely on pauses

Wait for an actual state to be reached, whether a JavaScript
expression to become true, or a certain state in the DOM.

Using pauses is an anti-pattern and inherently unstable.

Bug: T219440
Change-Id: Ibb2bd335f12442ab8ec2973031454cb58733211d

2 years agoRename PhpBugTests -> PhpXMLBugTester
Reedy [Sun, 14 Apr 2019 21:10:40 +0000 (22:10 +0100)]
Rename PhpBugTests -> PhpXMLBugTester

Only contains one class (probably should be removed when we bump to PHP 7 fully)

Change-Id: Iab2bb837e2ed5d5556bd49f4236030b43aba29f1

2 years agoSplit filebackend files to class per file
Reedy [Sun, 14 Apr 2019 02:35:00 +0000 (03:35 +0100)]
Split filebackend files to class per file

Change-Id: Idf9f4177fb9a523ce41227bda2af923bf418396b

2 years agoMerge "Split HTMLFormElement.php into class per file"
jenkins-bot [Sun, 14 Apr 2019 21:59:45 +0000 (21:59 +0000)]
Merge "Split HTMLFormElement.php into class per file"

2 years agoMerge "Move ClassCollector to its own file"
jenkins-bot [Sun, 14 Apr 2019 21:54:10 +0000 (21:54 +0000)]
Merge "Move ClassCollector to its own file"

2 years agoMerge "Move SectionProfileCallback to its own file"
jenkins-bot [Sun, 14 Apr 2019 21:53:00 +0000 (21:53 +0000)]
Merge "Move SectionProfileCallback to its own file"

2 years agoMerge "DevelopmentSettings: Remove unused globals & declare $wgSQLMode"
jenkins-bot [Sun, 14 Apr 2019 21:40:23 +0000 (21:40 +0000)]
Merge "DevelopmentSettings: Remove unused globals & declare $wgSQLMode"

2 years agoMerge "Remove XMPReader back compat"
jenkins-bot [Sun, 14 Apr 2019 21:25:47 +0000 (21:25 +0000)]
Merge "Remove XMPReader back compat"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 14 Apr 2019 20:01:17 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If213bbbe7552c4a6e747ca618ac0be22177d70b9

2 years agoMove ClassCollector to its own file
Reedy [Sun, 14 Apr 2019 15:04:32 +0000 (16:04 +0100)]
Move ClassCollector to its own file

Change-Id: I881f1ccc4aaf8babc40ad534a2a91f1ccf3baad4

2 years agoMove SectionProfileCallback to its own file
Reedy [Sun, 14 Apr 2019 15:02:53 +0000 (16:02 +0100)]
Move SectionProfileCallback to its own file

Change-Id: Iccb2048eed6631caa4f20639f55866e76f9fabf0

2 years agoMerge "Fix casing of Special Pages to match class name"
jenkins-bot [Sun, 14 Apr 2019 19:25:29 +0000 (19:25 +0000)]
Merge "Fix casing of Special Pages to match class name"

2 years agoMerge "Remove HWLDFWordAccumulator, deprecated in 1.28"
jenkins-bot [Sun, 14 Apr 2019 19:21:26 +0000 (19:21 +0000)]
Merge "Remove HWLDFWordAccumulator, deprecated in 1.28"

2 years agoMerge "Remove ObjectFactory"
jenkins-bot [Sun, 14 Apr 2019 19:21:21 +0000 (19:21 +0000)]
Merge "Remove ObjectFactory"

2 years agoRemove XMPReader back compat
Reedy [Sun, 14 Apr 2019 13:55:23 +0000 (14:55 +0100)]
Remove XMPReader back compat

Change-Id: I4e3ecbf6c13a7e7cfed88253eb6820e78e49e9c3

2 years agoCache: Make APCUBagOStuff::set return a useful value
Daimona Eaytoy [Sun, 14 Apr 2019 17:13:48 +0000 (19:13 +0200)]
Cache: Make APCUBagOStuff::set return a useful value

It took me lots of time to debug a CI failure in
I9b3bc36b552901bc6ca7609ee51e80be2979a9c4. I was deceived by
$cache->set returning true, which according to the docs means that the
store was successful. But instead, this function just returns true, even
in case of failure. Make it return the result of apcu_store, which is
already in the format true = success, false = failure.

Change-Id: I2619845c12460e1acb5af696d2c11a5a4dee1bd3

2 years agoSplit StubObject.php to have one class in one file
Zoranzoki21 [Sun, 14 Apr 2019 10:15:06 +0000 (12:15 +0200)]
Split StubObject.php to have one class in one file

Change-Id: If00625b700962a1c6d6412c6de30c28fa3df9f81

2 years agoRemove HWLDFWordAccumulator, deprecated in 1.28
Reedy [Sun, 14 Apr 2019 13:52:41 +0000 (14:52 +0100)]
Remove HWLDFWordAccumulator, deprecated in 1.28

Change-Id: I1eb6ba3c4b8b4cbabf26033a27728e42ebcddb23

2 years agoRemove ObjectFactory
Reedy [Sun, 14 Apr 2019 13:48:08 +0000 (14:48 +0100)]
Remove ObjectFactory

Change-Id: Ibfdb55101c893a6724e1f999eba85f2f8eabb79b

2 years agoSet global config for test to avoid failure
Thalia [Sun, 14 Apr 2019 13:28:06 +0000 (14:28 +0100)]
Set global config for test to avoid failure

Change-Id: I4f883b0ecec5378e29625a8940a0c247967f3e71

2 years agoRestore func_get_args in HTMLFormField
Umherirrender [Sun, 14 Apr 2019 13:01:20 +0000 (15:01 +0200)]
Restore func_get_args in HTMLFormField

Mocking variadic arguments does not work in hhvm

Follow-Up: I066ec95a7beb7c0665146195a08e7cce1222c788
Change-Id: Ic3b689d003a4659abdc4c9344ffd83f24f448912

2 years agoFix casing of Special Pages to match class name
Reedy [Sun, 14 Apr 2019 12:32:59 +0000 (13:32 +0100)]
Fix casing of Special Pages to match class name

Change-Id: Ifc9e827202493e8f055a21875c54ff827a38d1f7

2 years agoSplit HTMLFormElement.php into class per file
Reedy [Sun, 14 Apr 2019 02:40:03 +0000 (03:40 +0100)]
Split HTMLFormElement.php into class per file

Change-Id: Ia8a35056fa6df5b81cda3e5bfcaac91d0b898d51

2 years agoUpdate MediaWikiTitleCodec to use NamespaceInfo
Aryeh Gregor [Sun, 5 Aug 2018 13:00:56 +0000 (16:00 +0300)]
Update MediaWikiTitleCodec to use NamespaceInfo

Depends-On: I759cde50e42020699138d32431c27428737f700f
Change-Id: I57d77754288449ec54b039802adae05d56fa5563

2 years agoSplit LocalFile.php to have one class in one file
Umherirrender [Sat, 6 Apr 2019 10:02:26 +0000 (12:02 +0200)]
Split LocalFile.php to have one class in one file

Change-Id: Ic8e5220f2a1832dfc39f00720001235429ed2cab

2 years agoMerge "resourceloader: Switch params for private addLink() function"
jenkins-bot [Sun, 14 Apr 2019 07:57:41 +0000 (07:57 +0000)]
Merge "resourceloader: Switch params for private addLink() function"

2 years agoMerge "Move UploadStashFile to its own file"
jenkins-bot [Sun, 14 Apr 2019 06:44:33 +0000 (06:44 +0000)]
Merge "Move UploadStashFile to its own file"

2 years agoMerge "Fix return type of UploadStashFile::remove()"
jenkins-bot [Sun, 14 Apr 2019 06:44:05 +0000 (06:44 +0000)]
Merge "Fix return type of UploadStashFile::remove()"

2 years agoMerge "title: Allow passing MessageLocalizer to newMainPage()"
jenkins-bot [Sun, 14 Apr 2019 02:52:22 +0000 (02:52 +0000)]
Merge "title: Allow passing MessageLocalizer to newMainPage()"

2 years agoMove UploadStashFile to its own file
Reedy [Sun, 14 Apr 2019 02:50:59 +0000 (03:50 +0100)]
Move UploadStashFile to its own file

Change-Id: I557bcd8369014bf2ea43c5eb8336562cb6295890

2 years agoFix return type of UploadStashFile::remove()
Reedy [Sun, 14 Apr 2019 02:48:43 +0000 (03:48 +0100)]
Fix return type of UploadStashFile::remove()

Change-Id: Ib9da5827671a34798b58f7d736e4b663ac2c442d

2 years agoMerge "Split logging classes to individual files"
jenkins-bot [Sun, 14 Apr 2019 02:26:45 +0000 (02:26 +0000)]
Merge "Split logging classes to individual files"

2 years agotitle: Allow passing MessageLocalizer to newMainPage()
Timo Tijhof [Sat, 13 Apr 2019 03:27:31 +0000 (04:27 +0100)]
title: Allow passing MessageLocalizer to newMainPage()

The method could not be used in session-less endpoints. This was
worked around once in the Startup module.

I plan to use this method in an extension module as well,
and would prefer not to duplicate core's logic for determining
the main page, outside this repository.

As general dependency-injection pattern, it seems desirable
to allow injecting a MessageLocalizer here.

Change-Id: I76cd02b2f489882e9404b93270f76aad9f0a4d9d

2 years agoMerge "Remove PreferencesFormLegacy.php"
jenkins-bot [Sun, 14 Apr 2019 02:22:08 +0000 (02:22 +0000)]
Merge "Remove PreferencesFormLegacy.php"

2 years agoMerge "Avoid extra parse/save delay for users with non-canonical parser options"
jenkins-bot [Sun, 14 Apr 2019 02:13:54 +0000 (02:13 +0000)]
Merge "Avoid extra parse/save delay for users with non-canonical parser options"

2 years agoSplit logging classes to individual files
Reedy [Sun, 14 Apr 2019 01:05:34 +0000 (02:05 +0100)]
Split logging classes to individual files

Change-Id: I3eaaf23612fe1aed65e49c06a9e5e565399af9ce

2 years agoRemove PreferencesFormLegacy.php
Reedy [Sun, 14 Apr 2019 01:24:20 +0000 (02:24 +0100)]
Remove PreferencesFormLegacy.php

Now unused, deprecated in 1.32

Change-Id: I4fc4bdf36b3832786c0266786cff57d512140d8e