4 years agoMerge "Use the phan exit code directly"
jenkins-bot [Fri, 9 Dec 2016 00:51:52 +0000 (00:51 +0000)]
Merge "Use the phan exit code directly"

4 years agoMerge "Use 1 processes instead of 4 for phan"
jenkins-bot [Fri, 9 Dec 2016 00:49:05 +0000 (00:49 +0000)]
Merge "Use 1 processes instead of 4 for phan"

4 years agoUse the phan exit code directly
Erik Bernhardson [Thu, 8 Dec 2016 22:41:32 +0000 (14:41 -0800)]
Use the phan exit code directly

Change-Id: Ic99e334576e350d11c57ac4b74085c99313401c4

4 years agoUse 1 processes instead of 4 for phan
Erik Bernhardson [Thu, 8 Dec 2016 22:12:38 +0000 (14:12 -0800)]
Use 1 processes instead of 4 for phan

Running against mediawiki core phan needs around 1GB of memory
per process. >4GB is too excessive for a default setting. Instead
set the default to 1 process and add the ability for users to
select more processes on the command line.

Bug: T132636
Change-Id: I3d9fa462916fba519fe6d7f1916f881eefb6a942

4 years agoMerge "API: More i18n cleanup"
jenkins-bot [Thu, 8 Dec 2016 22:09:02 +0000 (22:09 +0000)]
Merge "API: More i18n cleanup"

4 years agoMerge "HtmlArmor: Document that null is an acceptable value"
jenkins-bot [Thu, 8 Dec 2016 21:31:58 +0000 (21:31 +0000)]
Merge "HtmlArmor: Document that null is an acceptable value"

4 years agoAPI: More i18n cleanup
Brad Jorsch [Thu, 8 Dec 2016 17:56:37 +0000 (12:56 -0500)]
API: More i18n cleanup

* Use errorformat for action=login Failed responses in non-BC mode.
* We removed 'messageHtml' from action=rollback's response on error, but
  left it for success. Remove it there too, it's even less useful.
* We changed action=watch's reporting of errors, but left the
  mostly-pointless reporting of "success" UI messages. These should be
  handled on the client side.

Change-Id: Ia6c402a4254fbacf4c2c3f125ce8bf0bcc71e509

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 8 Dec 2016 21:05:13 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iba22019e88d103bf2c7b98309e57e24be3328dff

4 years agoHtmlArmor: Document that null is an acceptable value
Kunal Mehta [Wed, 7 Dec 2016 05:25:56 +0000 (21:25 -0800)]
HtmlArmor: Document that null is an acceptable value

And that you'll get null back.

Change-Id: Ibd74e6af16b51796b46c2e23b7442740f5f69a0f

4 years agoMerge "Let mw.Api recognize errorformat!=bc"
jenkins-bot [Thu, 8 Dec 2016 19:51:51 +0000 (19:51 +0000)]
Merge "Let mw.Api recognize errorformat!=bc"

4 years agoLet mw.Api recognize errorformat!=bc
Matthias Mullie [Thu, 8 Dec 2016 17:05:23 +0000 (18:05 +0100)]
Let mw.Api recognize errorformat!=bc

Iae0e2ce3bd42dd4776a9779664086119ac188412 introduced a new
API error format where, in case of error, there is no
'error' property in the response, but an 'errors'.
mw.Api doesn't recognize those as errors and just resolves
the deferred, instead of rejecting it.

Change-Id: I4c05ef7d7574e2ca538170609fab85d8463b7b68

4 years agoMerge "Replace Linker::link() usage with LinkRenderer"
jenkins-bot [Thu, 8 Dec 2016 18:34:27 +0000 (18:34 +0000)]
Merge "Replace Linker::link() usage with LinkRenderer"

4 years agoMerge "Special:Userrights should set isself on page view, not just on submit"
jenkins-bot [Thu, 8 Dec 2016 17:56:53 +0000 (17:56 +0000)]
Merge "Special:Userrights should set isself on page view, not just on submit"

4 years agoProvide context to ChangeTags::buildTagFilterSelector
Matěj Suchánek [Wed, 19 Oct 2016 19:06:14 +0000 (19:06 +0000)]
Provide context to ChangeTags::buildTagFilterSelector

Bug: T105649
Change-Id: I5f44f4c054010c865ddb51e7d69107bdf2e88c00

4 years agoMerge "Add configuration for running etsy/phan against core"
jenkins-bot [Thu, 8 Dec 2016 10:03:53 +0000 (10:03 +0000)]
Merge "Add configuration for running etsy/phan against core"

4 years agoMerge "Chinese Conversion Table Update 2016-7"
jenkins-bot [Thu, 8 Dec 2016 07:26:08 +0000 (07:26 +0000)]
Merge "Chinese Conversion Table Update 2016-7"

4 years agoAdd configuration for running etsy/phan against core
Erik Bernhardson [Fri, 1 Jul 2016 00:11:52 +0000 (17:11 -0700)]
Add configuration for running etsy/phan against core

Adds the necessary configuration and stubs for phan static analysis to
run against mediawiki core. A variety of fixes have been applied to core
recently such with this current configuration we are completely passing,
except for one issue with a bug in Phan (https://github.com/etsy/phan/issues/286)

In it's current configuration Phan will detect fatal errors trying to
access non existant classes, undefined method calls, and other errors.
The analysis can be expanded as we cleanup more of the codebase.  This
is in preparation for working on getting the CI to run phan as part of
the review process. I have found phan to be usefull in CirrusSearch
(although with stricter config) for catching bugs and I think it could
help in core as well.

We arn't too far from being able to disable `null_casts_as_any_type`,
there are only a few classes that need adjusting. Lots more work needs
to be done to reduce `minimum_severity` from 10 to 5 (normal) or
0 (low).

Change-Id: Iafd55b1380f37d7b0d195eed081f8042166690e8

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 7 Dec 2016 21:40:46 +0000 (22:40 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic36aaa135b8702f13e4dd4400878d8d9cc2146ce

4 years agoSpecial:Userrights should set isself on page view, not just on submit
Huji Lee [Wed, 7 Dec 2016 19:15:52 +0000 (14:15 -0500)]
Special:Userrights should set isself on page view, not just on submit

Partially reverts I57e9ca4f20fe557e4024c4f5a4865170f02ebb45

Bringing back lines that were incorrectly removed

Bug: T152600
Change-Id: I5e1171be4cb75a6d7cce5f99b9d31dc0cb5d8db3

4 years agoReplace Linker::link() usage with LinkRenderer
Phantom42 [Mon, 5 Dec 2016 19:02:51 +0000 (21:02 +0200)]
Replace Linker::link() usage with LinkRenderer

Linker::link() replaced with LinkRenderer in some pages in includes/specials

Bug: T149346
Change-Id: I937bdc99d1342e73f20b8437a9b55dffb04161c5

4 years agoMerge "ApiRevisionDelete: Use standard formatting for errors and warnings"
jenkins-bot [Wed, 7 Dec 2016 08:58:41 +0000 (08:58 +0000)]
Merge "ApiRevisionDelete: Use standard formatting for errors and warnings"

4 years agoMerge "Replace Linker::link() & Linker::linkKnown() with LinkRenderer"
jenkins-bot [Wed, 7 Dec 2016 06:55:33 +0000 (06:55 +0000)]
Merge "Replace Linker::link() & Linker::linkKnown() with LinkRenderer"

4 years agoReplace Linker::link() & Linker::linkKnown() with LinkRenderer
Yifei He [Mon, 5 Dec 2016 06:47:27 +0000 (14:47 +0800)]
Replace Linker::link() & Linker::linkKnown() with LinkRenderer

Change-Id: I1350819165095d9be79aea8d9189760a4dbddd40

4 years agoMerge "Replace Linker::link() with LinkRenderer in all revisiondelete pages"
jenkins-bot [Wed, 7 Dec 2016 05:51:21 +0000 (05:51 +0000)]
Merge "Replace Linker::link() with LinkRenderer in all revisiondelete pages"

4 years agoSpecial:RC filter: hideunpatrolled
Stephane Bisson [Thu, 1 Dec 2016 19:58:18 +0000 (14:58 -0500)]
Special:RC filter: hideunpatrolled

Allows hiding edits that have not been patrolled.
In other words, showing only edits that have been patrolled.

Will be used by the new Special:RC filters (ERI project).

Bug: T152061
Change-Id: I3cd896812c5af87bc4be53d493055c37298c712f

4 years agoSpecial:RC filter: hidehumans
Stephane Bisson [Mon, 14 Nov 2016 18:51:48 +0000 (13:51 -0500)]
Special:RC filter: hidehumans

Allows showing only bot edits

Will be used by the ERI project.

Bug: T149862
Change-Id: I748eb3c614abd7b8b228efe3da5e9cb569a8618f

4 years agoSpecial:RC filters: hide page edits, new pages, log entries
Stephane Bisson [Mon, 14 Nov 2016 19:17:42 +0000 (14:17 -0500)]
Special:RC filters: hide page edits, new pages, log entries

New RC filters for ERI project:

Bug: T150060
Change-Id: I6fe852fb0f5386c3385ada5189ceaf0d9bbc979d

4 years agoMerge "RC/Watchlist: Filter out parameters that cannot be displayed"
jenkins-bot [Wed, 7 Dec 2016 01:07:58 +0000 (01:07 +0000)]
Merge "RC/Watchlist: Filter out parameters that cannot be displayed"

4 years agoMerge "Cleanup static analysis errors"
jenkins-bot [Wed, 7 Dec 2016 00:39:16 +0000 (00:39 +0000)]
Merge "Cleanup static analysis errors"

4 years agoMerge "Update OOjs UI to v0.18.2"
jenkins-bot [Wed, 7 Dec 2016 00:24:18 +0000 (00:24 +0000)]
Merge "Update OOjs UI to v0.18.2"

4 years agoCleanup static analysis errors
Erik Bernhardson [Wed, 7 Dec 2016 00:06:39 +0000 (16:06 -0800)]
Cleanup static analysis errors

While prepping the code base for using etsy/phan i found a few problems.
A couple are real problems, while others are just places etsy couldn't
figure out the types.

* AuthPlugin referenced UserLoginTemplate which doesn't exist. Tracing
  back usages this accepts classes that extend from BaseTemplate.
* DatabaseSqlite had an invalid @var annotation.
* LoadBalancer had some missing or under-defined annotations. Make them
  more specific where possible.
* SqlBagOStuff didn't have the appropriate use statement for
  WaitConditionLoop and probably doesn't work. Also updated annotations
  that point to non-existent DatabaseBase to use IDatabase.

Change-Id: Iff2270b418ad2f8f97cfdb6df646c435d3283536

4 years agoMerge "profiler: Support tideways for PHP7 profiling"
jenkins-bot [Tue, 6 Dec 2016 23:52:47 +0000 (23:52 +0000)]
Merge "profiler: Support tideways for PHP7 profiling"

4 years agoUpdate OOjs UI to v0.18.2
Volker E [Tue, 6 Dec 2016 23:42:12 +0000 (15:42 -0800)]
Update OOjs UI to v0.18.2

Release notes:

Change-Id: Id08147e9015fc68a882733268a2bf860dd1ccb27

4 years agoprofiler: Support tideways for PHP7 profiling
Kunal Mehta [Sun, 4 Dec 2016 03:31:37 +0000 (19:31 -0800)]
profiler: Support tideways for PHP7 profiling

xhprof does not support PHP7, and it doesn't seem like upstream will be
working on that any time soon.

Tideways is a profiler that is basically a drop-in replacement for
xhprof with functions renamed. So Xhprof::enable() and Xhprof::disable()
will now try to use tideways if that is installed and xhprof is not.

Bug: T152186
Change-Id: I0d7d2de56ac638ca2851c662f527049bd620c0e9

4 years agoMake remote content skin tabs non-File specific
Kunal Mehta [Fri, 16 Sep 2016 01:22:36 +0000 (18:22 -0700)]
Make remote content skin tabs non-File specific

This is one of the steps for implementing shadow namespaces -
generalizing foreign file specific code to be usable for any namespace.
This allows us to no-longer special case WikiFilePage in SkinTemplate
when building content_navigation, and will let GlobalUserPage to add
similar tabs just by overriding the same functions.

The new WikiPage::getWikiDisplayName() and WikiPage::getSourceURL()
functions will return expected values for both local and remote content.

Change-Id: Ib3d7dcbefe95da351872e63f306799eef83e00a7

4 years agoMerge "Special:RC tests: ignore order when asserting conditions"
jenkins-bot [Tue, 6 Dec 2016 21:57:32 +0000 (21:57 +0000)]
Merge "Special:RC tests: ignore order when asserting conditions"

4 years agoMerge "MapCacheLRU: Properly handle bogus cache keys"
jenkins-bot [Tue, 6 Dec 2016 21:41:18 +0000 (21:41 +0000)]
Merge "MapCacheLRU: Properly handle bogus cache keys"

4 years agoRevert "Localisation updates from https://translatewiki.net."
Raimond Spekking [Tue, 6 Dec 2016 21:28:31 +0000 (21:28 +0000)]
Revert "Localisation updates from https://translatewiki.net."

includes/api/i18n/qqq.json looks insane, probably conflict with https://gerrit.wikimedia.org/r/#/c/321406/

This reverts commit 50135c64ca83c5903ddbc04a9af8638321dc25e0.

Change-Id: I63d88b6ef11eb796ff80e83763a2b0c99363b7f9

4 years agoApiRevisionDelete: Use standard formatting for errors and warnings
Brad Jorsch [Tue, 6 Dec 2016 21:17:23 +0000 (16:17 -0500)]
ApiRevisionDelete: Use standard formatting for errors and warnings

Change-Id: I8e88c356ac81572d866fbdd8f15e7a8dd4384c06

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 6 Dec 2016 21:13:44 +0000 (22:13 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I57e6697462f86b9ef684d82e739781b04dbfa250

4 years agoMapCacheLRU: Properly handle bogus cache keys
Chad Horohoe [Tue, 6 Dec 2016 20:42:49 +0000 (12:42 -0800)]
MapCacheLRU: Properly handle bogus cache keys

They can only be strings or integers. Anything else is wrong. We
should be throwing exceptions here so developers find this early
when running tests and manual testing.

Exceptions (instead of warnings) allow us to get a full useful

Change-Id: I823ce33523283509c14a05f816f261d6b400e243

4 years agoAPI: Fix i18n for apihelp-main-param-errorformat
Brad Jorsch [Tue, 6 Dec 2016 20:20:39 +0000 (15:20 -0500)]
API: Fix i18n for apihelp-main-param-errorformat

Renamed the parameter at some point, but forgot to update this message.

Change-Id: I84fb44e7419bd7aee28f4dfd2bd37c51384330cc

4 years agoMerge "API: i18n for warnings and errors"
jenkins-bot [Tue, 6 Dec 2016 19:57:45 +0000 (19:57 +0000)]
Merge "API: i18n for warnings and errors"

4 years agoReplace Linker::link() with LinkRenderer in all revisiondelete pages
divadsn [Mon, 5 Dec 2016 19:23:28 +0000 (19:23 +0000)]
Replace Linker::link() with LinkRenderer in all revisiondelete pages

* RevDelArchiveItem
* RevDelArchivedFileItem
* RevDelFileItem
* RevDelLogItem
* RevDelRevisionItem

Bug: T149346
Change-Id: I96f83d06b4d3ccf3f76ccfca843a6aaf76d89063

4 years agoMerge "registration: Provide credits information to callbacks"
jenkins-bot [Tue, 6 Dec 2016 19:07:01 +0000 (19:07 +0000)]
Merge "registration: Provide credits information to callbacks"

4 years agoMerge "registration: Refactor validation logic to avoid duplication"
jenkins-bot [Tue, 6 Dec 2016 19:06:57 +0000 (19:06 +0000)]
Merge "registration: Refactor validation logic to avoid duplication"

4 years agoMerge "Convert Special:DeletedContributions to use OOUI."
jenkins-bot [Tue, 6 Dec 2016 18:14:41 +0000 (18:14 +0000)]
Merge "Convert Special:DeletedContributions to use OOUI."

4 years agoMerge "registration: Don't let extensions load late"
jenkins-bot [Tue, 6 Dec 2016 18:09:31 +0000 (18:09 +0000)]
Merge "registration: Don't let extensions load late"

4 years agoobjectcache: Remove broken apcu_set() calls
Aaron Schulz [Tue, 6 Dec 2016 06:03:21 +0000 (01:03 -0500)]
objectcache: Remove broken apcu_set() calls

The method call was misnamed (should be apcu_store) and not needed anyway,
since the other BagOStuff classes fail if no key is present.

Change-Id: I726965e665c2d0c5843d8dd33504810d130b9e98

4 years agoAPI: i18n for warnings and errors
Brad Jorsch [Wed, 19 Oct 2016 16:54:25 +0000 (12:54 -0400)]
API: i18n for warnings and errors

API warnings and error messages are currently hard-coded English
strings. This patch changes that.

With a few exceptions, this patch should be compatible with non-updated
* The change to ApiBase::$messageMap will blow up anything trying to
  mess with it.
* The changes to the 'ApiCheckCanExecute' hook will cause a wrong
  (probably unparsed) error message to be emitted for extensions not
  already using an ApiMessage. Unless they're currently broken like

Bug: T37074
Bug: T47843
Depends-On: Ia2b66b57cd4eaddc30b3ffdd7b97d6ca3e02d898
Depends-On: I2e1bb975bb0045476c03ebe6cdec00259bae22ec
Depends-On: I53987bf87c48f6c00deec17a8e957d24fcc3eaa6
Depends-On: Ibf93a459eb62d30f7c70d20e91ec9faeb80d10ed
Depends-On: I3cf889811f44a15935e454dd42f081164d4a098c
Depends-On: Ieae527de86735ddcba34724730e8730fb277b99b
Depends-On: I535344c29d51521147c2a26c341dae38cec3e931
Change-Id: Iae0e2ce3bd42dd4776a9779664086119ac188412

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 5 Dec 2016 21:19:57 +0000 (22:19 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I74a8995410784d438e0168919c5216aacadfc723

4 years agoMerge "phpunit: Make getResourceLoaderContext() more extendable"
jenkins-bot [Mon, 5 Dec 2016 19:57:21 +0000 (19:57 +0000)]
Merge "phpunit: Make getResourceLoaderContext() more extendable"

4 years agoMisleading messages on Special:Userrights
Huji Lee [Mon, 5 Dec 2016 19:03:50 +0000 (14:03 -0500)]
Misleading messages on Special:Userrights

Corrects what is not addressed by I57e9ca4f20fe557e4024c4f5a4865170f02ebb45

Bug: T152428
Change-Id: I105be73acc5a2bc088b557ccafbdf9db726480da

4 years agoMerge "OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85"
jenkins-bot [Mon, 5 Dec 2016 16:45:21 +0000 (16:45 +0000)]
Merge "OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85"

4 years agoUse single quotes
Niklas Laxström [Mon, 5 Dec 2016 13:02:00 +0000 (14:02 +0100)]
Use single quotes

Follow-up to Icc9bc096

Change-Id: I4863e0e7946fd59022846198e86302f556fee617

4 years agoOOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85
Bartosz Dziewoński [Mon, 5 Dec 2016 00:58:03 +0000 (01:58 +0100)]
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85

Bug: T151061
Change-Id: I715d2ac077c5a6f9de420d90f19ef4b631168f26

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 4 Dec 2016 20:53:04 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Idc4a0a2896c29601b3f099c3bb2a622e995cfc4e

4 years agoRemoved deprecated class RevisiondeleteAction
rlot [Sun, 4 Dec 2016 15:05:49 +0000 (16:05 +0100)]
Removed deprecated class RevisiondeleteAction

RevisiondeleteAction was deprecated in release 1.25

Bug: T61113
Change-Id: I9238d0558b21fccde70e7e23a169e114362f793e

4 years agoregistration: Don't let extensions load late
Florian Schmidt [Sat, 3 Dec 2016 17:46:48 +0000 (18:46 +0100)]
registration: Don't let extensions load late

We want all extensions to be queued together and load at the same time
so in the future we can properly evaluate dependencies as a whole. If
extensions load late, they would bypass this, potentially causing

Bug: T117277
Change-Id: I09b306bd6f6ccf4210f36be0118e7f17f2c3d264

4 years agoMerge "Add integration test for MWHttpRequest user/pass options"
jenkins-bot [Sun, 4 Dec 2016 06:31:50 +0000 (06:31 +0000)]
Merge "Add integration test for MWHttpRequest user/pass options"

4 years agoMerge "Replaced Linker::link() usage with LinkRenderer in some special pages"
jenkins-bot [Sun, 4 Dec 2016 06:19:39 +0000 (06:19 +0000)]
Merge "Replaced Linker::link() usage with LinkRenderer in some special pages"

4 years agoReplaced Linker::link() usage with LinkRenderer in some special pages
Subin Siby [Sat, 3 Dec 2016 08:01:49 +0000 (13:31 +0530)]
Replaced Linker::link() usage with LinkRenderer in some special pages

Bug: T149346
Change-Id: I73c2b7402012a49e4419b6214f1d03f2e819220b

4 years agoregistration: Provide credits information to callbacks
Kunal Mehta [Thu, 1 Dec 2016 07:19:37 +0000 (23:19 -0800)]
registration: Provide credits information to callbacks

Registration callbacks now provide basic credits information (name,
path, type, authors, license-name, version, etc.) as the first argument.
The main use case right now for this is to support extension VERSION
constants for backwards-compatibility.

In addition, callbacks now run *after* attributes are exposed, so
callbacks could use data from them if they wanted to.

Bug: T151136
Change-Id: Ic5965dd4e259e1f46222ac92b8e78750e67b51d6

4 years agoMerge "Add $magicWords translation for Bengali (bn)"
jenkins-bot [Sun, 4 Dec 2016 01:27:18 +0000 (01:27 +0000)]
Merge "Add $magicWords translation for Bengali (bn)"

4 years agoAdd integration test for MWHttpRequest user/pass options
Gergő Tisza [Sat, 3 Dec 2016 23:36:09 +0000 (23:36 +0000)]
Add integration test for MWHttpRequest user/pass options

Change-Id: I5bcb263a725e8042ee51109080d2075744fe7001

4 years agoMerge "Clarify in emailuserfooter that by responding one reveals their email address"
jenkins-bot [Sat, 3 Dec 2016 22:56:05 +0000 (22:56 +0000)]
Merge "Clarify in emailuserfooter that by responding one reveals their email address"

4 years agoClarify in emailuserfooter that by responding one reveals their email address
Huji Lee [Fri, 2 Dec 2016 21:25:23 +0000 (16:25 -0500)]
Clarify in emailuserfooter that by responding one reveals their email address

Bug: T152242
Change-Id: I686f7bb8dd1d225620266ac9cbecadcf06bd7705

4 years agoAdd $magicWords translation for Bengali (bn)
Pmlineditor [Mon, 21 Nov 2016 07:35:41 +0000 (13:05 +0530)]
Add $magicWords translation for Bengali (bn)

Bug: T151134
Change-Id: I81ce473668e3712ea575dc38f5eb76abb45498ac

5 years agoArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed
Reedy [Thu, 1 Dec 2016 13:12:55 +0000 (13:12 +0000)]
ArticleViewCustom, EditPageGetDiffText and ShowRawCssJs were removed

Bug: T145728
Change-Id: Iddf29005abbaceaa1e3cc2c79e4becfb46294414

5 years agoArticle::getAutosummary() and WikiPage::getAutosummary() were removed
Reedy [Thu, 1 Dec 2016 12:45:36 +0000 (12:45 +0000)]
Article::getAutosummary() and WikiPage::getAutosummary() were removed

Bug: T145728
Change-Id: I233571658b902c93a148a992ea99eb159551e732

5 years agoRemove ContentHandler functions with no usages at all
Reedy [Thu, 1 Dec 2016 12:40:05 +0000 (12:40 +0000)]
Remove ContentHandler functions with no usages at all

Bug: T145728
Change-Id: Ia0d7a5eb7e79b586c3b30688c80bb8b4b723fff6

5 years agophpunit: Make getResourceLoaderContext() more extendable
Timo Tijhof [Sat, 3 Dec 2016 00:46:53 +0000 (16:46 -0800)]
phpunit: Make getResourceLoaderContext() more extendable

This makes it easier to add other options in the future,
such as setting 'modules' in the context to something else.

Change-Id: I53c25fa7ad705cc34e44f95e4f87eb53612d800e

5 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Fri, 2 Dec 2016 20:56:05 +0000 (20:56 +0000)]
Merge "Localisation updates from https://translatewiki.net."

5 years agoMerge "Avoid use of DatabaseBase in /includes"
jenkins-bot [Fri, 2 Dec 2016 20:54:26 +0000 (20:54 +0000)]
Merge "Avoid use of DatabaseBase in /includes"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 2 Dec 2016 20:53:57 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ifb9f00278f2dc7589efa501dd4ee8fba3087ea60

5 years agoAvoid use of DatabaseBase in /includes
Aaron Schulz [Fri, 2 Dec 2016 19:18:27 +0000 (11:18 -0800)]
Avoid use of DatabaseBase in /includes

Change-Id: Ia3b7f9cb7d40f4ec9f19c924904e8a096880ec6a

5 years agoMerge "Ignore query cache in LoadMonitorMySQL"
jenkins-bot [Fri, 2 Dec 2016 19:59:21 +0000 (19:59 +0000)]
Merge "Ignore query cache in LoadMonitorMySQL"

5 years agoMerge "Set token properly when creating in User::newSystemUser()"
jenkins-bot [Fri, 2 Dec 2016 19:47:47 +0000 (19:47 +0000)]
Merge "Set token properly when creating in User::newSystemUser()"

5 years agoMove link-underline user preference rule to body class
Ed Sanders [Wed, 7 Sep 2016 22:51:48 +0000 (15:51 -0700)]
Move link-underline user preference rule to body class

ResourceLoaderUserCSSPrefsModule is now empty and can be removed.

Change-Id: I806e117131765b859e990c14735bb9494db9a37e

5 years agoReplace Linker::link() usage with LinkRenderer
rlot [Fri, 2 Dec 2016 15:43:12 +0000 (16:43 +0100)]
Replace Linker::link() usage with LinkRenderer

Replaced deprecated Linker:link() with LinkRenderer

Bug: T149346
Change-Id: Iab158d49b186835a14c357c91a1c5c4f78986238

5 years agoSet token properly when creating in User::newSystemUser()
Brad Jorsch [Sat, 19 Nov 2016 00:54:58 +0000 (19:54 -0500)]
Set token properly when creating in User::newSystemUser()

Otherwise callers that don't use 'steal' is going to break because it'll
think it needs to steal the user.

If such a user exists on a wiki, it can be fixed by setting the token to
the invalid token. The easiest way is probably to just call
User::newSystemUser( $name, [ 'steal' => true ] ) with eval.php.

Note there's no way for anyone to use these users unless they steal the
token from the DB, since they still don't have a password, email, or any
other method of authentication or account recovery set up.

Change-Id: I9efd2d2f5fffb4e4411a894f9514cdf2c66663a9

5 years agoMerge "mediawiki.notification: Improve scroll performance"
jenkins-bot [Fri, 2 Dec 2016 13:00:22 +0000 (13:00 +0000)]
Merge "mediawiki.notification: Improve scroll performance"

5 years agoslave -> replica in SessionConsistentConnectionManager
Amir Sarabadani [Fri, 2 Dec 2016 10:42:40 +0000 (14:12 +0330)]
slave -> replica in SessionConsistentConnectionManager

Change-Id: Ie59c90fa5f4b18d4321f7924a4facd7ea9049f4a

5 years agoIgnore query cache in LoadMonitorMySQL
Aaron Schulz [Fri, 2 Dec 2016 09:09:44 +0000 (01:09 -0800)]
Ignore query cache in LoadMonitorMySQL

Change-Id: I0b3c27ca6d2f8805297d91557cc40bd4bbc1a677

5 years agoRemoved Xml::escapeJsString()
Reedy [Wed, 30 Nov 2016 00:38:00 +0000 (00:38 +0000)]
Removed Xml::escapeJsString()

Change-Id: Iead8385a72a79632a90594a8828080a6d572e039

5 years agoUser::edits() was removed
Reedy [Wed, 30 Nov 2016 00:41:47 +0000 (00:41 +0000)]
User::edits() was removed

Change-Id: I3ebe2cceb94a0d61a9e0ab5bb0599e8a03146046

5 years agoMerge "SpecialActiveUsers: escape group names"
jenkins-bot [Fri, 2 Dec 2016 06:09:37 +0000 (06:09 +0000)]
Merge "SpecialActiveUsers: escape group names"

5 years agoMerge "Remove Atomic methods from ConnectionManagers"
jenkins-bot [Fri, 2 Dec 2016 05:07:53 +0000 (05:07 +0000)]
Merge "Remove Atomic methods from ConnectionManagers"

5 years agoRemove Atomic methods from ConnectionManagers
addshore [Thu, 1 Dec 2016 00:13:16 +0000 (00:13 +0000)]
Remove Atomic methods from ConnectionManagers

Change-Id: I697f63f45975b13af52bc22fced6e4d07e35115f
Depends-On: I4341a1b4ff6a67e4c1770faae38e9b126f1bf0bf

5 years agoresourceloader: Add test coverage for ResourceLoaderContext::msg()
Timo Tijhof [Fri, 2 Dec 2016 04:47:05 +0000 (20:47 -0800)]
resourceloader: Add test coverage for ResourceLoaderContext::msg()

Brings ResourceLoaderContext coverage to 100%.

Change-Id: I3ccc6aa87c89f69158b8d8684be565403afb4036

5 years agoDon't hard fail when we couldn't find an entry point for an extension
Chad Horohoe [Mon, 28 Nov 2016 22:53:40 +0000 (14:53 -0800)]
Don't hard fail when we couldn't find an entry point for an extension

It doesn't make a ton of sense, it's just pointing out that we have
a weird extension for which we cannot detect a standard entry point
for. These (unfortunately) exist, but they're easily worked around
using --list-file

Removing the hard failure allows you to use the two options in
tandem... --extension-dir for the initial pass and then --list-file
for the weirdo outstanding ones

Change-Id: I3d9cf1d614dacaa91fb2092019ccf1d14d61ccab

5 years agoMerge "SpecialFewestrevisions: Allow pages with only 1 revision to be shown"
jenkins-bot [Fri, 2 Dec 2016 00:10:26 +0000 (00:10 +0000)]
Merge "SpecialFewestrevisions: Allow pages with only 1 revision to be shown"

5 years agoRemove $purpose parameter from password validity check
Brad Jorsch [Thu, 1 Dec 2016 23:30:23 +0000 (18:30 -0500)]
Remove $purpose parameter from password validity check

This was added in I56b6600 in an attempt to work around a bug in
CentralAuth, but the bug has since been fixed in a better way. No hook
functions in Gerrit use the parameter (or ever have, as far as I can
tell), and anything that was passing a value other than the default
'login' has since been removed. So let's just get rid of it instead of
keeping it around doing nothing.

Change-Id: Ie604e03d268706221161ac93eb866f477e466fb4

5 years agoinstaller: Restore link text in default main page content
Kunal Mehta [Thu, 1 Dec 2016 22:55:49 +0000 (14:55 -0800)]
installer: Restore link text in default main page content

Accidentally got dropped in b85a17b7543.

Change-Id: I30b7a8d42877a54749792e97e49670087a85ca2b

5 years agoMerge "ApiSandbox: Better handling of parsed messages"
jenkins-bot [Thu, 1 Dec 2016 22:17:02 +0000 (22:17 +0000)]
Merge "ApiSandbox: Better handling of parsed messages"

5 years agoIDatabase::delete() table name parameter should be a string
Reedy [Thu, 1 Dec 2016 21:32:09 +0000 (21:32 +0000)]
IDatabase::delete() table name parameter should be a string

Change-Id: I7ba2cdb6cdddf04819ff80e27814f704f41d15f1

5 years agoMerge "Replace Linker::link() usage with LinkRenderer"
jenkins-bot [Thu, 1 Dec 2016 20:24:51 +0000 (20:24 +0000)]
Merge "Replace Linker::link() usage with LinkRenderer"

5 years agoMerge "http: Support HTTP Basic Authentication"
jenkins-bot [Thu, 1 Dec 2016 20:09:02 +0000 (20:09 +0000)]
Merge "http: Support HTTP Basic Authentication"

5 years agoReplace Linker::link() usage with LinkRenderer
Haikal Izzuddin [Wed, 30 Nov 2016 01:07:37 +0000 (09:07 +0800)]
Replace Linker::link() usage with LinkRenderer

Bug: T149346
Change-Id: Ie384566617f18ad6c3bf836b39702365d59f714d

5 years agoMerge "Replace Linker::link() with LinkRenderer in some special pages"
jenkins-bot [Thu, 1 Dec 2016 19:56:18 +0000 (19:56 +0000)]
Merge "Replace Linker::link() with LinkRenderer in some special pages"