lhc/web/wiklou.git
5 years agoRemove pear/mail_mime-decode
Reedy [Wed, 10 Oct 2018 17:41:00 +0000 (18:41 +0100)]
Remove pear/mail_mime-decode

Bug: T109121
Change-Id: I540b8a59dbe88c27f49b3c4cd8740872afd5d8bf

5 years agoHard deprecate unused OutputPage::addWikiText* methods
C. Scott Ananian [Fri, 21 Sep 2018 17:16:42 +0000 (13:16 -0400)]
Hard deprecate unused OutputPage::addWikiText* methods

Codesearch shows no users of `OutputPage::addWikiTextWithTitle()`,
and no users of `OutputPage::addWikiTextTitle()` (other than the
implicit uses by the other `OutputPage::addWikiText*()` methods).

These methods produce untidy output, which future parsers won't
support.

Bug: T198214
Change-Id: Id5ee3bdfa6c464e3a92af82af7bc7317ca9d07a9

5 years agoUpdate users of deprecated OutputPage::addWikiText*Tidy() methods
C. Scott Ananian [Wed, 26 Sep 2018 17:17:14 +0000 (13:17 -0400)]
Update users of deprecated OutputPage::addWikiText*Tidy() methods

This is a follow-up to Ia58910164baaca608cea3b24333b7d13ed773339 which
added new & improved names for the addWikiText*Tidy() methods.

Bug: T198214
Depends-On: I42d198e6d03afd5b976da741f235c175bfe9f767
Change-Id: I1993c2009e861fdb45c9b1bd42eab1e28a776d9a

5 years agoDeprecate and rename OutputPage::addWikiText* methods
C. Scott Ananian [Fri, 21 Sep 2018 16:24:57 +0000 (12:24 -0400)]
Deprecate and rename OutputPage::addWikiText* methods

Tidy will always be enabled with our future parsers, and it is fast
and pure PHP now with the Remex implementation, so deprecate all the
untidy variants of 'OutputPage::addWikiText*()' and add new methods
which tidy by default.  Clarify the content language/interface
language distinction while we're at it by adding 'AsInterface' to the
name of methods which use the "interface language" by default,
and renaming the 'addWikiText*Tidy' methods to
'addWikiTextAsContent'.

The 'OutputPage::addWikiTextTitle' method has been deprecated, but it
is still used internally as the implementation for the newly-added
methods.  It is expected that the shared implementation will move in
the future to a new private method.  Setting the `$tidy` parameter of
`OutputPage::addWikiTextTitle` to false is independently deprecated;
for backwards-compatibility with old MW releases you may wish to
continue to invoke OutputPage::addWikiTextTitle() but set $tidy=true;
this will result in the same tidied output that the newly added
methods would produce.

Bug: T198214
Change-Id: Ia58910164baaca608cea3b24333b7d13ed773339

5 years agoAdd pear/Net_SMTP 1.8.0 to composer dependencies
Mark A. Hershberger [Tue, 24 Jul 2018 16:36:46 +0000 (12:36 -0400)]
Add pear/Net_SMTP 1.8.0 to composer dependencies

Bug: T200254
Change-Id: I231759a1e0bd5b8750939acaad85ed327d052b79

5 years agoMerge "ChangeTagsTest: Mark tables as "used" to avoid ID reuse"
jenkins-bot [Wed, 10 Oct 2018 17:37:17 +0000 (17:37 +0000)]
Merge "ChangeTagsTest: Mark tables as "used" to avoid ID reuse"

5 years agoMerge "Use non-deprecated login in ApiLoginTest"
jenkins-bot [Wed, 10 Oct 2018 15:49:04 +0000 (15:49 +0000)]
Merge "Use non-deprecated login in ApiLoginTest"

5 years agoMerge "Improve ApiLogin test coverage"
jenkins-bot [Wed, 10 Oct 2018 15:48:59 +0000 (15:48 +0000)]
Merge "Improve ApiLogin test coverage"

5 years agoMerge "resources: Update CLDRPluralRuleParser to v1.3.2-pre"
Nikerabbit [Wed, 10 Oct 2018 14:55:05 +0000 (14:55 +0000)]
Merge "resources: Update CLDRPluralRuleParser to v1.3.2-pre"

5 years agoUse non-deprecated login in ApiLoginTest
Aryeh Gregor [Tue, 9 Oct 2018 18:32:01 +0000 (21:32 +0300)]
Use non-deprecated login in ApiLoginTest

Change-Id: I62c7bfce88aeda7ec1429493e733f868887976a9

5 years agoImprove ApiLogin test coverage
Aryeh Gregor [Mon, 8 Oct 2018 13:30:13 +0000 (16:30 +0300)]
Improve ApiLogin test coverage

Coverage is 100% except for one session-related bit that seems a bit
involved to test right now.  It looks like it will be easier once
SessionManager becomes a service.

I removed the third parameter from the return value of
canonicalizeLoginData, since af37a4c7 made it always return true.

I also removed three lines of dead code from ApiLogin.php.

Change-Id: Ia0073eddd27c82827518e0031e3c313f83cfd7cc

5 years agoMerge "Hard-deprecate authentication-related hooks deprecated by AuthManager"
jenkins-bot [Wed, 10 Oct 2018 05:54:03 +0000 (05:54 +0000)]
Merge "Hard-deprecate authentication-related hooks deprecated by AuthManager"

5 years agoMerge "Re-namespace RevisionStore and RevisionRecord classes"
jenkins-bot [Wed, 10 Oct 2018 05:16:45 +0000 (05:16 +0000)]
Merge "Re-namespace RevisionStore and RevisionRecord classes"

5 years agoMerge "Use job queue for deletion of pages with many revisions"
jenkins-bot [Wed, 10 Oct 2018 04:55:53 +0000 (04:55 +0000)]
Merge "Use job queue for deletion of pages with many revisions"

5 years agoMerge "Tests: Simplify badaccess group check for patrol action"
jenkins-bot [Wed, 10 Oct 2018 04:24:33 +0000 (04:24 +0000)]
Merge "Tests: Simplify badaccess group check for patrol action"

5 years agoMerge "Revert "Replace Media namespace redirects with File namespace""
jenkins-bot [Wed, 10 Oct 2018 04:00:42 +0000 (04:00 +0000)]
Merge "Revert "Replace Media namespace redirects with File namespace""

5 years agoTests: Simplify badaccess group check for patrol action
Kosta Harlan [Thu, 4 Oct 2018 13:52:41 +0000 (09:52 -0400)]
Tests: Simplify badaccess group check for patrol action

The important part of the assertion is badaccess-groups, so we can drop the
other components and simplify the test code, plus also work around database
name issues that caused Travis CI to fail.

Bug: T206130
Change-Id: I137be892a611cd1f2d61baa77ad9528659587adf

5 years agoMerge "Remove ugly function existence check"
jenkins-bot [Wed, 10 Oct 2018 01:52:53 +0000 (01:52 +0000)]
Merge "Remove ugly function existence check"

5 years agoMerge "Fix index name in comment to "PHP_INFO""
jenkins-bot [Wed, 10 Oct 2018 01:43:48 +0000 (01:43 +0000)]
Merge "Fix index name in comment to "PHP_INFO""

5 years agoHard-deprecate authentication-related hooks deprecated by AuthManager
Gergő Tisza [Wed, 19 Sep 2018 22:19:59 +0000 (15:19 -0700)]
Hard-deprecate authentication-related hooks deprecated by AuthManager

Hard-deprecates AbortAutoAccount, AbortNewAccount, AbortLogin,
LoginUserMigrated, UserCreateForm, and UserLoginForm.

Change-Id: Ibb267def9c295997ef71d820ff482e1e6a816873

5 years agosinonjs: Update from 1.17.3 to 1.17.7
Timo Tijhof [Mon, 24 Sep 2018 01:47:47 +0000 (02:47 +0100)]
sinonjs: Update from 1.17.3 to 1.17.7

Upstream Sinon.JS no longer supports the pre-2.x v1.17 branch
anymore but there have been a few post-2.0 releases to address
bugs in v1.17 that we can still benefit from.

https://github.com/sinonjs/sinon/blob/v1.17.7/Changelog.txt

Notable changes include:

* Fix Blob feature test to support running tests on Safari 9.
* Avoid calls to object-local 'hasOwnProperty'.
* Improve error messages and stricter signature/type checks so
  that debugging code is easier when things go wrong.
* Fix various gaps in the XHR mock.
* Misc fixes for Node.js support.

Also remove outdated comment about ie-hacks from Sinon 1.15.

Change-Id: I66d1b461465b92798ad7eb2efcf4df2731cc78a4

5 years agoMerge "RCFilters: Override frameless button opacity to show real highlight color"
jenkins-bot [Tue, 9 Oct 2018 21:55:55 +0000 (21:55 +0000)]
Merge "RCFilters: Override frameless button opacity to show real highlight color"

5 years agoMerge "Use <div> wrappers instead of <p> in ProtectionForm"
jenkins-bot [Tue, 9 Oct 2018 20:38:31 +0000 (20:38 +0000)]
Merge "Use <div> wrappers instead of <p> in ProtectionForm"

5 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 9 Oct 2018 19:56:22 +0000 (19:56 +0000)]
Merge "Localisation updates from https://translatewiki.net."

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 9 Oct 2018 19:54:03 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia87e35c10f78bea2f7107605bb1adcc00acccbd6

5 years agoMerge "RCFilters: Apply `pointer` cursor on Hamburger menu"
jenkins-bot [Tue, 9 Oct 2018 19:52:34 +0000 (19:52 +0000)]
Merge "RCFilters: Apply `pointer` cursor on Hamburger menu"

5 years agoChangeTagsTest: Mark tables as "used" to avoid ID reuse
Brad Jorsch [Tue, 9 Oct 2018 19:41:25 +0000 (15:41 -0400)]
ChangeTagsTest: Mark tables as "used" to avoid ID reuse

If ChangeTags::updateTags() isn't passed all three of $rc_id, $rev_id,
and $log_id, it attempts to look up proper values from the subset that
is passed.

Some of the tests in ChangeTagsTest blindly use certain IDs, expecting
them to either not exist in the relevant tables or at least to be sane
(e.g. the same log_id isn't used on multiple rc_id rows). Depending on
the exact behavior of previous tests, this expectation may not hold.

The simple fix is to just mark the relevant tables as "used" by
ChangeTagsTest so MediaWikiTestCase will truncate them.

Change-Id: Ie60092b8a6e50f6f8a5cfdaaf4cac8ddb4fc6f53

5 years agoMerge "Clean up ApiLoginTest"
jenkins-bot [Tue, 9 Oct 2018 19:17:20 +0000 (19:17 +0000)]
Merge "Clean up ApiLoginTest"

5 years agoMerge "Improve exception message in DatabaseDomain"
jenkins-bot [Tue, 9 Oct 2018 18:21:55 +0000 (18:21 +0000)]
Merge "Improve exception message in DatabaseDomain"

5 years agoMerge "Make unclosed transaction errors more useful"
jenkins-bot [Tue, 9 Oct 2018 18:12:21 +0000 (18:12 +0000)]
Merge "Make unclosed transaction errors more useful"

5 years agoMerge "maintenance: Detect "unknown module name" error in manageForeignResources"
jenkins-bot [Tue, 9 Oct 2018 18:03:01 +0000 (18:03 +0000)]
Merge "maintenance: Detect "unknown module name" error in manageForeignResources"

5 years agoMake unclosed transaction errors more useful
Gergő Tisza [Tue, 9 Oct 2018 02:04:59 +0000 (19:04 -0700)]
Make unclosed transaction errors more useful

Move unclosed transaction error reporting to Database so it can
include information about the caller that started the transaction.

Change-Id: I834d957f172c03005de522f3029bb634b3c7220e

5 years agoImprove exception message in DatabaseDomain
Aaron Schulz [Tue, 9 Oct 2018 00:34:22 +0000 (17:34 -0700)]
Improve exception message in DatabaseDomain

Change-Id: Ib45497388d07b0531cfe1c06349105e47b9fad08

5 years agoClean up ApiLoginTest
Aryeh Gregor [Mon, 8 Oct 2018 11:29:47 +0000 (14:29 +0300)]
Clean up ApiLoginTest

Change-Id: Icd77f8a5ee0c26cfbd3cc8f220412cfa1bf49d60

5 years agoSync up with Parsoid parserTests.txt
C. Scott Ananian [Tue, 9 Oct 2018 15:57:03 +0000 (11:57 -0400)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit f6c64caaf1becc5b5780c871d495a3d9f5aac7a8

Change-Id: I0d2722c100b522c68a8e35a8701d5bf7ef80dccb

5 years agoRe-namespace RevisionStore and RevisionRecord classes
Brad Jorsch [Thu, 20 Sep 2018 17:29:04 +0000 (13:29 -0400)]
Re-namespace RevisionStore and RevisionRecord classes

During development a lot of classes were placed in MediaWiki\Storage\.
The precedent set would mean that every class relating to something
stored in a database table, plus all related value classes and such,
would go into that namespace.

Let's put them into MediaWiki\Revision\ instead. Then future classes
related to the 'page' table can go into MediaWiki\Page\, future classes
related to the 'user' table can go into MediaWiki\User\, and so on.

Note I didn't move DerivedPageDataUpdater, PageUpdateException,
PageUpdater, or RevisionSlotsUpdate in this patch. If these are kept
long-term, they probably belong in MediaWiki\Page\ or MediaWiki\Edit\
instead.

Bug: T204158
Change-Id: I16bea8927566a3c73c07e4f4afb3537e05aa04a5

5 years agoRCFilters: Apply `pointer` cursor on Hamburger menu
Volker E [Tue, 9 Oct 2018 04:01:19 +0000 (21:01 -0700)]
RCFilters: Apply `pointer` cursor on Hamburger menu

Bug: T196900
Change-Id: I53310b54616622b214a0a30f3bf826f48d05c7b1

5 years agoMerge "Update OOUI to v0.29.2"
jenkins-bot [Tue, 9 Oct 2018 02:32:14 +0000 (02:32 +0000)]
Merge "Update OOUI to v0.29.2"

5 years agoMerge "Make RefreshLinksJob MCR compliant."
jenkins-bot [Tue, 9 Oct 2018 02:28:04 +0000 (02:28 +0000)]
Merge "Make RefreshLinksJob MCR compliant."

5 years agoFix index name in comment to "PHP_INFO"
Alangi Derick [Sun, 30 Sep 2018 13:34:16 +0000 (14:34 +0100)]
Fix index name in comment to "PHP_INFO"

Change-Id: If006e96f5bae20791c1d388faad685203a061f22

5 years agoMerge "Revert "Re-enable tests from TitlePermissionTest""
jenkins-bot [Tue, 9 Oct 2018 01:44:03 +0000 (01:44 +0000)]
Merge "Revert "Re-enable tests from TitlePermissionTest""

5 years agoRevert "Re-enable tests from TitlePermissionTest"
Krinkle [Tue, 9 Oct 2018 01:21:00 +0000 (01:21 +0000)]
Revert "Re-enable tests from TitlePermissionTest"

It's still broken, and 4 days passed with broken Travis CI builds.
Re-reverting for now.

This reverts commit 589741b5417adbf0e3b0d72640ff6ff297e50141.

Change-Id: I85a0b02d3f32303a90118e2705a7b2afc721cb57

5 years agoRevert "Replace Media namespace redirects with File namespace"
Krinkle [Tue, 9 Oct 2018 01:19:02 +0000 (01:19 +0000)]
Revert "Replace Media namespace redirects with File namespace"

Per T203942.

This reverts commit 613e269920a7d268b012d61fec24fc4d04b1cd7a.

Change-Id: I4febbe9c650894976a580e584d0a7c11de12ff37

5 years agoUpdate OOUI to v0.29.2
Bartosz Dziewoński [Mon, 8 Oct 2018 23:50:33 +0000 (01:50 +0200)]
Update OOUI to v0.29.2

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.2

Bug: T206344
Depends-On: I607825c7df3d843f80f8d151c5c79c39cd629c17
Change-Id: I6db8fbb28ae1c190b1d9e2b4d4defdb20579a169

5 years agoFix parser test failure due to changed translation
Bartosz Dziewoński [Tue, 9 Oct 2018 00:00:50 +0000 (02:00 +0200)]
Fix parser test failure due to changed translation

The 'sr-ec' translation of 'editsectionhint' message was changed
in dff3fa2d4bf2c68b2020ffbf965459fb2e71c50f.

Change-Id: Ibb6ad22e3926406a3e8267b87ffd39ab51663e63

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 8 Oct 2018 20:53:21 +0000 (22:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I787568a8746dd03db3f5c2d1c75e248c5c4ce809

5 years agoMerge "Make SpecialPageTestBase always call parent::tearDown"
jenkins-bot [Mon, 8 Oct 2018 19:17:39 +0000 (19:17 +0000)]
Merge "Make SpecialPageTestBase always call parent::tearDown"

5 years agoMerge "Fix guarding of MySQL's numRows()"
jenkins-bot [Mon, 8 Oct 2018 19:17:33 +0000 (19:17 +0000)]
Merge "Fix guarding of MySQL's numRows()"

5 years agoMerge "Suppress "Headers already sent" in PHP 7.2 too"
jenkins-bot [Mon, 8 Oct 2018 18:17:44 +0000 (18:17 +0000)]
Merge "Suppress "Headers already sent" in PHP 7.2 too"

5 years agoMake RefreshLinksJob MCR compliant.
daniel [Mon, 8 Oct 2018 12:32:03 +0000 (14:32 +0200)]
Make RefreshLinksJob MCR compliant.

So far, RefreshLinksJob re-generated the ParserOutput ba calling
Content::getParserOutput. This only works for the main slot. It
needs to instead get the parser output for all slots combiend,
by using RevisionRenderer and RenderedRevision.

Bug: T174035
Change-Id: I253dda26bfa5aefa15f8b1dcc59e69fc7e9d0cb7

5 years agoSuppress "Headers already sent" in PHP 7.2 too
Aryeh Gregor [Mon, 8 Oct 2018 17:10:36 +0000 (20:10 +0300)]
Suppress "Headers already sent" in PHP 7.2 too

The "h" is now capitalized, so we need to update the regex.

Change-Id: I1111e1228868ec66d930c7a3b0d7972e5c6356b9

5 years agoMake SpecialPageTestBase always call parent::tearDown
Aryeh Gregor [Mon, 8 Oct 2018 16:54:32 +0000 (19:54 +0300)]
Make SpecialPageTestBase always call parent::tearDown

Change-Id: Ifc244d5117e7da4bf46cdf273eca9fc4ae5c3a42

5 years agoRCFilters: Override frameless button opacity to show real highlight color
Volker E [Mon, 8 Oct 2018 16:16:16 +0000 (09:16 -0700)]
RCFilters: Override frameless button opacity to show real highlight color

Overriding OOUI's frameless button opacity, which is targeted in this
place for icons to show real highlight color.

Bug: T190980
Change-Id: Id3355ecad8ff01ef8159375eaa04f7d284fc598b

5 years agoMerge "Improve ApiFormatJson test coverage"
jenkins-bot [Mon, 8 Oct 2018 16:03:07 +0000 (16:03 +0000)]
Merge "Improve ApiFormatJson test coverage"

5 years agoMerge "Deprecate MediaWikiTestCase::stashMwGlobals"
jenkins-bot [Mon, 8 Oct 2018 16:03:02 +0000 (16:03 +0000)]
Merge "Deprecate MediaWikiTestCase::stashMwGlobals"

5 years agoImprove ApiFormatJson test coverage
Aryeh Gregor [Mon, 8 Oct 2018 10:42:20 +0000 (13:42 +0300)]
Improve ApiFormatJson test coverage

The only thing missing is tests for the rawfm paths, which I don't
understand well enough to test easily.

Change-Id: I08779391798b9d2d5eeb7e19ec4764059336069c

5 years agoFix guarding of MySQL's numRows()
Tim Starling [Mon, 8 Oct 2018 03:46:37 +0000 (14:46 +1100)]
Fix guarding of MySQL's numRows()

It can be true for successful write queries, not just false.

f3a197e49b785 introduced a caller which calls numRows() on the return
value of CREATE TEMPORARY TABLE queries, and it improved guarding of
numRows() in the PostgreSQL and SQLite cases accordingly, but it
neglected MySQL.

Bug: T201900
Change-Id: I8ae754a2518d9e47b093c31c20d98daaba913513

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 7 Oct 2018 19:55:00 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I37d7b1dfa4bbe393b32d62f8f8ac564ebb24d149

5 years agoDeprecate MediaWikiTestCase::stashMwGlobals
Aryeh Gregor [Sun, 7 Oct 2018 12:26:18 +0000 (15:26 +0300)]
Deprecate MediaWikiTestCase::stashMwGlobals

This method encourages directly editing configuration variables.  It's a
better idea to use setMwGlobals() (or other set wrappers) so that we can
be intelligent in the future, for instance resetting services after the
config change.  Plus, a lot of the callers come out cleaner this way
anyway.

Depends-On: I8a1e81acc5c42a8d7f30938a72cface0acea4a70
Depends-On: I4105dbcf9c5399fe7239478c460ec57c015a98d4
Depends-On: I1b220996acf2f66cf7b0f092b341584663df32f9
Depends-On: Ie2d1ea65c0cb334bbde1666d00781474b7ac4dab
Change-Id: I23d77398e401f4986b1d5bd1c9e11a8a40da16f8

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 6 Oct 2018 19:54:18 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib87a638392b5f4d20ce69a0af2895692f11197d4

5 years agoFix numerals for Saraiki
jhsoby [Mon, 27 Aug 2018 21:53:46 +0000 (23:53 +0200)]
Fix numerals for Saraiki

Change numerals from Persian numerals to
Eastern Arabic numerals.

Bug: T202943
Change-Id: I9ef7c18d40b9aa3f1c3b3db7407d3f61feb7fd1d

5 years agoMerge "messagecache: use MergeableUpdate for the deferred replace() update"
jenkins-bot [Sat, 6 Oct 2018 03:21:47 +0000 (03:21 +0000)]
Merge "messagecache: use MergeableUpdate for the deferred replace() update"

5 years agomaintenance: Detect "unknown module name" error in manageForeignResources
Timo Tijhof [Sat, 6 Oct 2018 03:05:38 +0000 (04:05 +0100)]
maintenance: Detect "unknown module name" error in manageForeignResources

Previously, `manageForeignResources.php update foo` would output
"Done!", which is very similar to "... updating foo\nDone!".

The module argument is now validated, just like how the
action argument was validated already.

Change-Id: Ia7c87de5d86b9d1a411485cac43b1529fe88a59f

5 years agoMerge "Add link to protect log to action=info"
jenkins-bot [Sat, 6 Oct 2018 00:09:41 +0000 (00:09 +0000)]
Merge "Add link to protect log to action=info"

5 years agoMerge "Remove trailing spaces from IP addr in Special:DeletedContributions"
jenkins-bot [Fri, 5 Oct 2018 23:26:26 +0000 (23:26 +0000)]
Merge "Remove trailing spaces from IP addr in Special:DeletedContributions"

5 years agoReplace Media namespace redirects with File namespace
Alex Ezell [Fri, 5 Oct 2018 21:32:00 +0000 (17:32 -0400)]
Replace Media namespace redirects with File namespace

If a user creates a redirect that goes to a [[Media:example.jpg]]
page, then an exception is thrown because NS_MEDIA is a virtual
namespace. This change catches this case and changes the namespace
to an NS_FILE namespace and the redirect works correctly. This
change only happens when we are dealing with a redirect so other
uses of the NS_MEDIA namespace shouldn't be affected.

Bug: T203942
Change-Id: Ia744059650e16510732a65d51b138b11cbd43eb4

5 years agomessagecache: use MergeableUpdate for the deferred replace() update
Aaron Schulz [Thu, 4 Oct 2018 20:14:32 +0000 (13:14 -0700)]
messagecache: use MergeableUpdate for the deferred replace() update

This combines the load loop for multiple messages for a language code.

Bug: T203925
Bug: T193271
Change-Id: Ie5e1e83d6740344b7ca641c99fb3bd4ad5718492

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 5 Oct 2018 19:56:02 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I16181fad87c2d0afe3c43188c9f7807b6a953698

5 years agoMerge "UIDGenerator: Remove the clock skew problem"
jenkins-bot [Fri, 5 Oct 2018 19:29:40 +0000 (19:29 +0000)]
Merge "UIDGenerator: Remove the clock skew problem"

5 years agoMerge "Write Latin and other scripts with captial letter"
jenkins-bot [Fri, 5 Oct 2018 19:28:48 +0000 (19:28 +0000)]
Merge "Write Latin and other scripts with captial letter"

5 years agoMerge "search: Fix DYM typos in widget"
jenkins-bot [Fri, 5 Oct 2018 19:03:26 +0000 (19:03 +0000)]
Merge "search: Fix DYM typos in widget"

5 years agoWrite Latin and other scripts with captial letter
Fomafix [Fri, 5 Oct 2018 16:37:53 +0000 (18:37 +0200)]
Write Latin and other scripts with captial letter

Change-Id: I16c660e54191b63cd6eb3407cb00504665930c4e

5 years agoRemove trailing spaces from IP addr in Special:DeletedContributions
Alangi Derick [Fri, 5 Oct 2018 14:22:15 +0000 (15:22 +0100)]
Remove trailing spaces from IP addr in Special:DeletedContributions

* Trim "target" to remove trailing spaces from IP address in
  Special:DeletedContributions that triggers MW internal error.

Bug: T187619
Change-Id: Ic6b0d8020553ecce4dcf97f9c78487d3174444d8

5 years agoMerge "wdio-mediawiki: Add 'fragment' parameter to Page"
jenkins-bot [Fri, 5 Oct 2018 08:04:08 +0000 (08:04 +0000)]
Merge "wdio-mediawiki: Add 'fragment' parameter to Page"

5 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Fri, 5 Oct 2018 06:59:36 +0000 (06:59 +0000)]
Merge "Localisation updates from https://translatewiki.net."

5 years agoMerge "Test ApiUnblock"
jenkins-bot [Fri, 5 Oct 2018 00:43:56 +0000 (00:43 +0000)]
Merge "Test ApiUnblock"

5 years agoMerge "Fix List* in MessagesKo.php"
jenkins-bot [Fri, 5 Oct 2018 00:29:50 +0000 (00:29 +0000)]
Merge "Fix List* in MessagesKo.php"

5 years agoTest ApiUnblock
Aryeh Gregor [Thu, 4 Oct 2018 12:57:10 +0000 (15:57 +0300)]
Test ApiUnblock

Full coverage (except for the examples/help URL).

Change-Id: I4c618506b5446680f06fa9b605d3babe7194de94

5 years agoMerge "filebackend: Add normalization for stat errors"
jenkins-bot [Thu, 4 Oct 2018 23:22:13 +0000 (23:22 +0000)]
Merge "filebackend: Add normalization for stat errors"

5 years agofilebackend: Add normalization for stat errors
Timo Tijhof [Thu, 4 Oct 2018 18:54:36 +0000 (19:54 +0100)]
filebackend: Add normalization for stat errors

Bug: T205567
Change-Id: I75f1eb6dc2cbff0ea0dc0706cca0ad79c54fc612

5 years agoMerge "Enforce no-session constraint in opensearch_desc.php and profileinfo.php"
jenkins-bot [Thu, 4 Oct 2018 21:37:00 +0000 (21:37 +0000)]
Merge "Enforce no-session constraint in opensearch_desc.php and profileinfo.php"

5 years agoresources: Update CLDRPluralRuleParser to v1.3.2-pre
Timo Tijhof [Thu, 4 Oct 2018 21:17:30 +0000 (22:17 +0100)]
resources: Update CLDRPluralRuleParser to v1.3.2-pre

Not yet tagged as release, but updating ahead of that for the
performance improvement that landed with
https://github.com/santhoshtr/CLDRPluralRuleParser/commit/a7782ca.

This is particularly impactful on calls to mw.msg() during the
critical path, due to this library being called by jqueryMsg,
which is used by mw.Message#text, which mw.msg() calls by default.

Particularly seen in the startup code from ULS modules.

Bug: T127328
Change-Id: Ic865e7077d1053c65f7ae1633c60bf52104731b7

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 4 Oct 2018 20:03:30 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Idf339b32a190b7a770c0465e4545948861ab979d

5 years agoMerge "Clean up UIDGenerator field comments"
jenkins-bot [Thu, 4 Oct 2018 19:53:45 +0000 (19:53 +0000)]
Merge "Clean up UIDGenerator field comments"

5 years agoUIDGenerator: Remove the clock skew problem
Timo Tijhof [Thu, 4 Oct 2018 00:38:45 +0000 (01:38 +0100)]
UIDGenerator: Remove the clock skew problem

In a nutshell:

This commmit removes the use of drifting microtime()
in favour of non-drifting time(). Then, we increase the size of
the counter by x1000, and consider every 1000 increments as 1ms
for the purposes of UUID.

Why:

This means we eliminate the whole code that can produce a fatal
exception when the clock drifts by more than we can wait for,
which puts us in a logical conundrum we can't get out of, hence
it previously fatalled.

Not aborting random end-user requests and jobs is good.

This also means we avoid the vast majority of cases where
MediaWiki would busy-loop for upto 10ms in a likely-to-fail
attempt to sync the clock. This means the method runs faster,
which is a nice win, albeit not the main objective.

Bug: T94522
Change-Id: Ia8a847078ec76d633854db6823a20f0961c80f80

5 years agoAdd link to protect log to action=info
Martin Urbanec [Sat, 29 Sep 2018 17:03:12 +0000 (19:03 +0200)]
Add link to protect log to action=info

Bug: T52190
Change-Id: Id983d4585a253ebe34e07f07472548f6d1d20bce

5 years agoMerge "Update OOUI to v0.29.1"
jenkins-bot [Thu, 4 Oct 2018 18:31:32 +0000 (18:31 +0000)]
Merge "Update OOUI to v0.29.1"

5 years agoMerge "Avoid fatal when finding no base revision for a null revision."
jenkins-bot [Thu, 4 Oct 2018 18:11:58 +0000 (18:11 +0000)]
Merge "Avoid fatal when finding no base revision for a null revision."

5 years agoAvoid fatal when finding no base revision for a null revision.
daniel [Thu, 4 Oct 2018 10:49:50 +0000 (12:49 +0200)]
Avoid fatal when finding no base revision for a null revision.

Bug: T205675
Change-Id: Iae67649a1be9597086033ad34d9d00556ba35730

5 years agoUpdate OOUI to v0.29.1
James D. Forrester [Thu, 4 Oct 2018 17:12:39 +0000 (10:12 -0700)]
Update OOUI to v0.29.1

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.1

Local fix to rcfilters for renamed parent method.

Bug: T130434
Bug: T165650
Bug: T183299
Bug: T196756
Bug: T205472
Bug: T205692
Bug: T205979
Bug: T206153
Bug: T206155
Depends-On: Ie847465af6762fd0322a5be4adf601cabda2d458
Change-Id: I704e3197e86d484be3ab91b9282d6ac1b7db2251

5 years agoMerge "ParserOutput::getCacheTime should stay the same after the first call."
jenkins-bot [Thu, 4 Oct 2018 16:58:00 +0000 (16:58 +0000)]
Merge "ParserOutput::getCacheTime should stay the same after the first call."

5 years agoMerge "Ensure OutputPageTest works when Translate extension is loaded"
jenkins-bot [Thu, 4 Oct 2018 16:53:20 +0000 (16:53 +0000)]
Merge "Ensure OutputPageTest works when Translate extension is loaded"

5 years agoMerge "Use Remex for TextContentTest subclasses"
jenkins-bot [Thu, 4 Oct 2018 16:38:46 +0000 (16:38 +0000)]
Merge "Use Remex for TextContentTest subclasses"

5 years agoMerge "Disallow overriding services that were set"
jenkins-bot [Thu, 4 Oct 2018 16:20:25 +0000 (16:20 +0000)]
Merge "Disallow overriding services that were set"

5 years agoMerge "tests: Allow string to be passed to getTestUser() etc."
jenkins-bot [Thu, 4 Oct 2018 15:54:57 +0000 (15:54 +0000)]
Merge "tests: Allow string to be passed to getTestUser() etc."

5 years agoMerge "Minor cleanup in ApiBlockTest"
jenkins-bot [Thu, 4 Oct 2018 15:50:51 +0000 (15:50 +0000)]
Merge "Minor cleanup in ApiBlockTest"

5 years agoMerge "Only use "*Test.php" for actual PHPUnit tests"
jenkins-bot [Thu, 4 Oct 2018 15:43:12 +0000 (15:43 +0000)]
Merge "Only use "*Test.php" for actual PHPUnit tests"

5 years agoMerge "Re-enable tests from TitlePermissionTest"
jenkins-bot [Thu, 4 Oct 2018 15:40:48 +0000 (15:40 +0000)]
Merge "Re-enable tests from TitlePermissionTest"

5 years agoMerge "registration: Let extensions add PHP extension requirements"
jenkins-bot [Thu, 4 Oct 2018 15:38:58 +0000 (15:38 +0000)]
Merge "registration: Let extensions add PHP extension requirements"

5 years agosearch: Fix DYM typos in widget
Erik Bernhardson [Thu, 4 Oct 2018 14:44:09 +0000 (07:44 -0700)]
search: Fix DYM typos in widget

* DYM link was triggering the 'go' feature due to fulltext misspelled
* all ids are of the form mw-search-*, except one. Make it the same
  (WikimediaEvents code was expecting everything to be mw-search-*)

Bug: T206232
Change-Id: Ib91ccf28879b8af2a8c0f2a40b9fe3ec4259a730