lhc/web/wiklou.git
4 years agoUse RemexHtml as the tidy implementation for parser tests
Kunal Mehta [Fri, 9 Feb 2018 20:10:07 +0000 (12:10 -0800)]
Use RemexHtml as the tidy implementation for parser tests

* RemexHtml is the future of "tidy" in MediaWiki,
  so run our parser tests using it.

* This is a necessary step before we can make it
  the default in MediaWiki (T185753).

* Cleaned up a bunch of tests:
  (a) where html/php+tidy and html/parsoid match up,
      retained a html+tidy section and removed the others.
  (b) where html/php and html/php+tidy match up,
      retained the html/php section and removed the
      html/php+tidy section.

* Annotating tests with explanations where Parsoid & Remex
  output differ. This is usually because of two reasons:
  (a) Parsoid has Tidy-emulation code in some cases (which
      we can consider stripping away separately).
  (b) Parsoid does a bunch of cleanup on the DOM (which was
      probably done to emulate Tidy output, but which could
      probably be retained). Since Parsoid (in some form)
      will be default parser in the future, no reason to try
      to port this cleanup (in broken markup scenarios) into
      Remex.

* Left a bunch of FIXMEs for later followup.

Unrelated cleanup:
* Renamed a few tests since the functionality in Parsoid
  was fixed up. There is no more "implicit <td>" support.
  Those all now lead to fostered content.
* Fixed some clearly broken output in html/parsoid sections
  for some tests.

Co-Authored-by: Kunal Mehta <legoktm@member.fsf.org>
Co-Authored-by: Subramanya Sastry <ssastry@wikimedia.org>
Bug: T188167
Depends-On: I646dbabb3c2ed28c1ea72c5bd8f7f92d03f57c75
Change-Id: Ic7c34d57a300dbd36a37f03fbfe33391b2950b44

4 years agoMerge "mw.Title: Use $.trimByteLength from jquery.byteLimit module"
jenkins-bot [Tue, 20 Feb 2018 22:15:50 +0000 (22:15 +0000)]
Merge "mw.Title: Use $.trimByteLength from jquery.byteLimit module"

4 years agoMerge "tests: Remove dead code in jquery.byteLimit tests"
jenkins-bot [Tue, 20 Feb 2018 22:15:47 +0000 (22:15 +0000)]
Merge "tests: Remove dead code in jquery.byteLimit tests"

4 years agoMerge "Switch the sidebar cache to using checkKeys"
jenkins-bot [Tue, 20 Feb 2018 22:09:50 +0000 (22:09 +0000)]
Merge "Switch the sidebar cache to using checkKeys"

4 years agomw.Title: Use $.trimByteLength from jquery.byteLimit module
Bartosz Dziewoński [Mon, 19 Feb 2018 19:53:11 +0000 (20:53 +0100)]
mw.Title: Use $.trimByteLength from jquery.byteLimit module

Change-Id: I39ebd559a72ce72743cbe3bb86abe679d108d94a

4 years agotests: Remove dead code in jquery.byteLimit tests
Bartosz Dziewoński [Mon, 19 Feb 2018 20:56:08 +0000 (21:56 +0100)]
tests: Remove dead code in jquery.byteLimit tests

These options do nothing.

Change-Id: I15cc91b9208e8cfd3f3f42bb0a9c91514d6532e3

4 years agoMerge "parser: Deprecate string type for $lang arg in DateFormatter::getInstance"
jenkins-bot [Tue, 20 Feb 2018 21:16:34 +0000 (21:16 +0000)]
Merge "parser: Deprecate string type for $lang arg in DateFormatter::getInstance"

4 years agoMerge "jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming"
jenkins-bot [Tue, 20 Feb 2018 21:14:51 +0000 (21:14 +0000)]
Merge "jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming"

4 years agoparser: Deprecate string type for $lang arg in DateFormatter::getInstance
Fomafix [Wed, 13 Sep 2017 12:57:44 +0000 (14:57 +0200)]
parser: Deprecate string type for $lang arg in DateFormatter::getInstance

The parameter $lang is not used with type string in the Git repository:
https://codesearch.wmflabs.org/search/?q=DateFormatter%3A%3AgetInstance
This function is only used with type Language and without parameter.

The support for the language as string will be removed with Change-ID
I677ab561d67b63f0c86f65fadf9319e41444a22a.

The removal of the support for the type string simplifies the code.

Change-Id: I0c0ab46ffc0fab6b68672940e979ad7e5754a7d1

4 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Tue, 20 Feb 2018 21:02:55 +0000 (21:02 +0000)]
Merge "Localisation updates from https://translatewiki.net."

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 20 Feb 2018 21:02:45 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iea6405478e926c0bce200213a211bb66da7efbf3

4 years agoMerge "mediawiki.cldr: Use require() for pluralruleparser"
jenkins-bot [Tue, 20 Feb 2018 20:59:55 +0000 (20:59 +0000)]
Merge "mediawiki.cldr: Use require() for pluralruleparser"

4 years agoFix for Ia97b750b
MarcoAurelio [Tue, 20 Feb 2018 19:19:28 +0000 (19:19 +0000)]
Fix for Ia97b750b

Change-Id: I2eb5ba754334864f65dede92b138f9a81a210e70

4 years agoMerge "Add support for 'es-formal'"
jenkins-bot [Tue, 20 Feb 2018 19:05:24 +0000 (19:05 +0000)]
Merge "Add support for 'es-formal'"

4 years agoMerge "mw.loader: Document mw.loader.require() as private"
jenkins-bot [Tue, 20 Feb 2018 17:07:51 +0000 (17:07 +0000)]
Merge "mw.loader: Document mw.loader.require() as private"

4 years agomediawiki.cldr: Use require() for pluralruleparser
Fomafix [Fri, 16 Feb 2018 15:18:10 +0000 (16:18 +0100)]
mediawiki.cldr: Use require() for pluralruleparser

Use require( 'mediawiki.libs.pluralruleparser' ) instead of
mw.libs.pluralRuleParser. (Added in 1.27, with bc4e07b6f63b0)

Change-Id: I7388cf631068458596250b8da82edec3f7cbd98b

4 years agomw.loader: Document mw.loader.require() as private
Timo Tijhof [Tue, 20 Feb 2018 04:47:39 +0000 (20:47 -0800)]
mw.loader: Document mw.loader.require() as private

Only public for debugging purposes.

Change-Id: Icc44e11ec6874d7f74ed527e87a80dd06b4edb3a

4 years agoMerge "Cleanup IDEA warnings in MessageCache"
jenkins-bot [Tue, 20 Feb 2018 04:33:22 +0000 (04:33 +0000)]
Merge "Cleanup IDEA warnings in MessageCache"

4 years agoGD zero filesize error
Dan Mattern [Mon, 19 Feb 2018 22:59:17 +0000 (17:59 -0500)]
GD zero filesize error

Checking if the filesize is zero before passing to GD. This can result
in a fatal error.

Bug: T182387
Change-Id: I26a24286f3035f233de682caed21a8e8c2d5aaad

4 years agoMerge "Pass change tags to NewRevisionFromEditComplete hook"
jenkins-bot [Mon, 19 Feb 2018 22:55:53 +0000 (22:55 +0000)]
Merge "Pass change tags to NewRevisionFromEditComplete hook"

4 years agoMerge "rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()"
jenkins-bot [Mon, 19 Feb 2018 22:55:51 +0000 (22:55 +0000)]
Merge "rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()"

4 years agoMerge "tests: Remove verbose logging settings from DevelopmentSettings.php"
jenkins-bot [Mon, 19 Feb 2018 22:27:45 +0000 (22:27 +0000)]
Merge "tests: Remove verbose logging settings from DevelopmentSettings.php"

4 years agotests: Remove verbose logging settings from DevelopmentSettings.php
Timo Tijhof [Mon, 19 Feb 2018 22:17:11 +0000 (14:17 -0800)]
tests: Remove verbose logging settings from DevelopmentSettings.php

Follows-up fdb7d36903. It seems these make unit tests on Travis CI
fail, per T187581. And when we briefly enabled DevelopmentSettings.php
in our Jenkins setup, the PHPUnit tests also failed.

Remove these from DevelopmentSettings.php to confirm that the
tests pass that way. Then, once our own Jenkins setup has switched
back to using DevelopmentSettings.php, we can re-consider adding
these in a way that is verified by Gerrit/Jenkins before merging.

Bug: T187581
Change-Id: Ib81c5909849598bdad02955f6414d68c038742c5

4 years agojquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming
Bartosz Dziewoński [Mon, 5 Feb 2018 18:38:10 +0000 (19:38 +0100)]
jquery.byteLimit: Handle characters outside BMP (surrogate pairs) when trimming

Bug: T186364
Change-Id: I6282d97bcd637ae8e86d70996adb468582c8f02f

4 years agoAdd support for 'es-formal'
MarcoAurelio [Mon, 19 Feb 2018 21:19:13 +0000 (22:19 +0100)]
Add support for 'es-formal'

Spanish formal address. First exported on Id132ebc6.

Bug: T187750
Change-Id: Ia97b750bde01ceee7db0ea826e4f87bb9a2f0a93

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 19 Feb 2018 20:56:27 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I11bbae1702de3352fd8b59efa3abe3ad47b49acc

4 years agoMerge "Update links in comments to developer.mozilla.org"
jenkins-bot [Mon, 19 Feb 2018 19:08:10 +0000 (19:08 +0000)]
Merge "Update links in comments to developer.mozilla.org"

4 years agoMerge "build: Updating mediawiki/mediawiki-codesniffer to 16.0.0"
jenkins-bot [Mon, 19 Feb 2018 19:07:12 +0000 (19:07 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 16.0.0"

4 years agoSwitch the sidebar cache to using checkKeys
Aaron Schulz [Mon, 19 Feb 2018 11:50:29 +0000 (03:50 -0800)]
Switch the sidebar cache to using checkKeys

The avoids the long delete() loop in MessageCache::replace()
and has better separation of concern.

Change-Id: I0acb0119058fa92fcafb52a5850f5dad4aaa94d2

4 years agoCleanup IDEA warnings in MessageCache
Aaron Schulz [Mon, 19 Feb 2018 11:21:24 +0000 (03:21 -0800)]
Cleanup IDEA warnings in MessageCache

Change-Id: I0ced7c7289918f78bb6f3682ae974fe0c04a1e04

4 years agoUpdate links in comments to developer.mozilla.org
Fomafix [Mon, 19 Feb 2018 08:54:25 +0000 (09:54 +0100)]
Update links in comments to developer.mozilla.org

Change-Id: I2310cf73ab494375655067833cea11b18483a396

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 18 Feb 2018 20:57:57 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I613493a91cd01032529bd161947b9231819b99cb

4 years agordbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()
Aaron Schulz [Fri, 16 Feb 2018 21:50:08 +0000 (13:50 -0800)]
rdbms: tweak var names in LoadMonitor::scaleLoads()/getLagTimes()

Also mark the methods as "final" due to their delegation

Change-Id: Ie32f53445f749d9a00e77fce43d75830e260c039

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 17 Feb 2018 20:59:21 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Idc8c6ef5a94c61cac176895e089f9624428dc2af

4 years agobuild: Updating mediawiki/mediawiki-codesniffer to 16.0.0
Umherirrender [Sat, 17 Feb 2018 12:29:13 +0000 (13:29 +0100)]
build: Updating mediawiki/mediawiki-codesniffer to 16.0.0

Change-Id: I59b59f79bbf3ce4feff3b3a20c1c31bc16370531

4 years agoMerge "rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs"
jenkins-bot [Sat, 17 Feb 2018 04:11:53 +0000 (04:11 +0000)]
Merge "rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs"

4 years agordbms: remove "m" member prefix from various classes
Aaron Schulz [Fri, 16 Feb 2018 19:16:10 +0000 (11:16 -0800)]
rdbms: remove "m" member prefix from various classes

Change-Id: Iade8e8f70bb1307b96683d979d7e3650f4107515

4 years agoMerge "rdbms: remove "m" member prefix from DatabaseMssql"
jenkins-bot [Fri, 16 Feb 2018 23:37:08 +0000 (23:37 +0000)]
Merge "rdbms: remove "m" member prefix from DatabaseMssql"

4 years agoMerge "objectcache: add IExpiringStore::TTL_SECOND constant"
jenkins-bot [Fri, 16 Feb 2018 23:37:05 +0000 (23:37 +0000)]
Merge "objectcache: add IExpiringStore::TTL_SECOND constant"

4 years agoMerge "Soft deprecate DeferredStringifier class"
jenkins-bot [Fri, 16 Feb 2018 23:15:37 +0000 (23:15 +0000)]
Merge "Soft deprecate DeferredStringifier class"

4 years agoSoft deprecate DeferredStringifier class
星耀晨曦 [Wed, 14 Feb 2018 10:27:44 +0000 (10:27 +0000)]
Soft deprecate DeferredStringifier class

As of 3041b5c, the DeferredStringifier class is no longer used in MediaWiki core or any Gerrit-hosted extensions.

Bug: T187290
Change-Id: Ic363daf0847c0371a6b4c4041f9ea394377185f3

4 years agoMerge "RCLFilters: make sticky filters default and current value equal"
jenkins-bot [Fri, 16 Feb 2018 22:39:55 +0000 (22:39 +0000)]
Merge "RCLFilters: make sticky filters default and current value equal"

4 years agoobjectcache: add IExpiringStore::TTL_SECOND constant
Aaron Schulz [Fri, 16 Feb 2018 22:23:49 +0000 (14:23 -0800)]
objectcache: add IExpiringStore::TTL_SECOND constant

Change-Id: Iec59ce72f3dbb0de68c8f6704d86f1522f86827e

4 years agoMerge "site_stats: Unbreak counting newly created pages"
jenkins-bot [Fri, 16 Feb 2018 21:36:35 +0000 (21:36 +0000)]
Merge "site_stats: Unbreak counting newly created pages"

4 years agosite_stats: Unbreak counting newly created pages
Eddie Greiner-Petter [Fri, 16 Feb 2018 21:18:48 +0000 (22:18 +0100)]
site_stats: Unbreak counting newly created pages

Fixes a bug introduced on 331c9f9e2e that stopped newly created pages
from incrementing the counter of ss_total_pages in site_stats. The array
accepted by SiteStatsUpdate::factory is not meant to take a value with
the key 'total'. What's meant here is 'pages'. Let's change the variable
name as well to avoid confusion in the future.

Change-Id: I9c82d926206d9b46f333c6f6cb9d3c7d41db3a53

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 16 Feb 2018 21:03:24 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib373192166d7f9d43bbd15df341f8ad770353685

4 years agordbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs
Aaron Schulz [Fri, 9 Feb 2018 23:01:40 +0000 (15:01 -0800)]
rdbms: make DatabaseMysql::masterPosWait() handle inactive GTIDs

Change-Id: I543deef24f6cbf99094a4f3bee7cabe768fa221a

4 years agordbms: remove "m" member prefix from DatabaseMssql
Aaron Schulz [Fri, 16 Feb 2018 19:23:30 +0000 (11:23 -0800)]
rdbms: remove "m" member prefix from DatabaseMssql

Change-Id: I270cd4f4048e0ae751ea1c078d31d45c9db59690

4 years agoMerge "Follow-up I0bb4ed7f7: Use correct 'this'"
jenkins-bot [Fri, 16 Feb 2018 12:26:17 +0000 (12:26 +0000)]
Merge "Follow-up I0bb4ed7f7: Use correct 'this'"

4 years agoFollow-up I0bb4ed7f7: Use correct 'this'
Ed Sanders [Fri, 16 Feb 2018 11:55:00 +0000 (11:55 +0000)]
Follow-up I0bb4ed7f7: Use correct 'this'

Bug: T187523
Change-Id: I7ced05b239d3ce0da1bcd6acdb3a30f65872645c

4 years agoDon't write exceptions to STDERR from BadTitleErrorTest or ThrottledErrorTest
Brad Jorsch [Wed, 14 Feb 2018 18:01:19 +0000 (13:01 -0500)]
Don't write exceptions to STDERR from BadTitleErrorTest or ThrottledErrorTest

It's annoying and pointless. Instead, have MWException write them to
standard output where we can catch them with ob_start().

Bug: T170028
Bug: T170029
Change-Id: Icd99c1c39d4a30d78c511d33948ef639e1b92455

4 years agoMerge "rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()"
jenkins-bot [Fri, 16 Feb 2018 00:50:54 +0000 (00:50 +0000)]
Merge "rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()"

4 years agoUpdate wikimedia/php-session-serializer from 1.0.4 to 1.0.5
Reedy [Sun, 11 Feb 2018 15:39:45 +0000 (15:39 +0000)]
Update wikimedia/php-session-serializer from 1.0.4 to 1.0.5

https://github.com/wikimedia/php-session-serializer/releases/tag/v1.0.5
https://github.com/wikimedia/php-session-serializer/compare/v1.0.4...v1.0.5

Change-Id: Ib9f301f8f86031faed698beca65a56407859a1aa
Depends-On: I0f85f206fdd5566641784037132d2a6046de2c2d

4 years agordbms: do not bother making DBO_TRX transactions in IDatabase::lock()
Aaron Schulz [Wed, 14 Feb 2018 08:27:14 +0000 (00:27 -0800)]
rdbms: do not bother making DBO_TRX transactions in IDatabase::lock()

Named locks are session-level constructs and this transaction agnostic.
Also make lockIsFree() a bit more consistent when the thread has the
lock itself.

Change-Id: Ief51196161bbc50c798740f3c738fd0e39880508

4 years agoMerge "rdbms: remove "m" prefix from Database fields"
jenkins-bot [Fri, 16 Feb 2018 00:15:04 +0000 (00:15 +0000)]
Merge "rdbms: remove "m" prefix from Database fields"

4 years agoMerge "rdbms: make MySQLMasterPos handle inactive GTIDs"
jenkins-bot [Fri, 16 Feb 2018 00:11:48 +0000 (00:11 +0000)]
Merge "rdbms: make MySQLMasterPos handle inactive GTIDs"

4 years agoMerge "tests: Commit initial version of DevelopmentSettings.php"
jenkins-bot [Thu, 15 Feb 2018 23:52:26 +0000 (23:52 +0000)]
Merge "tests: Commit initial version of DevelopmentSettings.php"

4 years agordbms: remove "m" prefix from Database fields
Aaron Schulz [Tue, 13 Feb 2018 06:58:57 +0000 (22:58 -0800)]
rdbms: remove "m" prefix from Database fields

Done using the PhpStorm refactor->rename tool.

Also move "defaultBigSelects" declaration to DatabaseMysqlBase
as no other classes uses that.

Change-Id: I424a2d9815de3a5d4cca2522f3db23a5efe6b592

4 years agoMerge "rdbms: improve ILoadBalancer comments about reuseConnection()"
jenkins-bot [Thu, 15 Feb 2018 23:07:08 +0000 (23:07 +0000)]
Merge "rdbms: improve ILoadBalancer comments about reuseConnection()"

4 years agoMerge "rdbms: remove leading table name space hack in Database"
jenkins-bot [Thu, 15 Feb 2018 23:05:07 +0000 (23:05 +0000)]
Merge "rdbms: remove leading table name space hack in Database"

4 years agoMerge "Salvage site_stats row with negative values in miser mode"
jenkins-bot [Thu, 15 Feb 2018 23:02:11 +0000 (23:02 +0000)]
Merge "Salvage site_stats row with negative values in miser mode"

4 years agoMerge "rdbms: remove "m" prefix from LoadBalancer fields"
jenkins-bot [Thu, 15 Feb 2018 23:02:08 +0000 (23:02 +0000)]
Merge "rdbms: remove "m" prefix from LoadBalancer fields"

4 years agordbms: make MySQLMasterPos handle inactive GTIDs
Aaron Schulz [Fri, 9 Feb 2018 22:12:44 +0000 (14:12 -0800)]
rdbms: make MySQLMasterPos handle inactive GTIDs

Change-Id: I328142a9fe10bccb2717a0a392e0c50d0c070390

4 years agordbms: remove leading table name space hack in Database
Aaron Schulz [Thu, 15 Feb 2018 10:30:12 +0000 (02:30 -0800)]
rdbms: remove leading table name space hack in Database

This was added in r19879 (3de6fd8c8) with no provided use case.
There also appears to be nothing exploiting this.

Change-Id: I1641d4ed16d612ab6f08ee1eeca1580af73888bf

4 years agordbms: remove "m" prefix from LoadBalancer fields
Aaron Schulz [Wed, 14 Feb 2018 10:03:45 +0000 (02:03 -0800)]
rdbms: remove "m" prefix from LoadBalancer fields

Change-Id: I68fc74859bd58ef0c7591beef1c21411198d45e9

4 years agoUse `lock(,,0)` instead of `lockIsFree && lock(,,1)` for non-blocking locks
Timo Tijhof [Thu, 15 Feb 2018 22:30:26 +0000 (14:30 -0800)]
Use `lock(,,0)` instead of `lockIsFree && lock(,,1)` for non-blocking locks

This pattern is already used elsewhere and seems like a more efficient
way to acquire locks in a non-blocking way.

Change-Id: Idb369e7cb03b793d5f8295e956fecd8d1f849e17

4 years agordbms: improve ILoadBalancer comments about reuseConnection()
Aaron Schulz [Thu, 15 Feb 2018 21:28:58 +0000 (13:28 -0800)]
rdbms: improve ILoadBalancer comments about reuseConnection()

Change-Id: I94f8e95f5ed9c3357d118e9bc66c55b389061e7f

4 years agoMerge "Drop the 'CategorizedRecentChanges' feature"
jenkins-bot [Thu, 15 Feb 2018 21:12:23 +0000 (21:12 +0000)]
Merge "Drop the 'CategorizedRecentChanges' feature"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 15 Feb 2018 21:05:09 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I820327da7a4aa07879b4fa23f8187783bf35befa

4 years agoMerge "objectcache: improve WANObjectCache reap method comments"
jenkins-bot [Thu, 15 Feb 2018 20:51:06 +0000 (20:51 +0000)]
Merge "objectcache: improve WANObjectCache reap method comments"

4 years agoobjectcache: improve WANObjectCache reap method comments
Aaron Schulz [Thu, 15 Feb 2018 19:48:48 +0000 (11:48 -0800)]
objectcache: improve WANObjectCache reap method comments

Change-Id: Icec0846b0e66229af39bb819d75144734fd111bf

4 years agoMerge "Be more db-friendly when purging expired userrights"
jenkins-bot [Thu, 15 Feb 2018 19:47:47 +0000 (19:47 +0000)]
Merge "Be more db-friendly when purging expired userrights"

4 years agoMerge "build: Add grunt target for 'karma:firefox'"
jenkins-bot [Thu, 15 Feb 2018 18:46:32 +0000 (18:46 +0000)]
Merge "build: Add grunt target for 'karma:firefox'"

4 years agoDrop the 'CategorizedRecentChanges' feature
James D. Forrester [Sat, 18 Mar 2017 01:17:17 +0000 (18:17 -0700)]
Drop the 'CategorizedRecentChanges' feature

It is off by default, it's very rarely used (GitHub finds four config
users setting it true), it has over time had fatals going unnoticed or
fixed for years. Let's just kill it.

Change-Id: Idac2341ed7ecf053ee84069df657e424e50b896c

4 years agoRevisionStore logging use wfBacktrace instead of wfDebugBacktrace
addshore [Thu, 15 Feb 2018 14:15:45 +0000 (14:15 +0000)]
RevisionStore logging use wfBacktrace instead of wfDebugBacktrace

wfDebugBacktrace doesn't work very will with logstash.
The whole message ends up being too long and the log ends
up in the 'jsonTruncated' channel.
Instead use wfBacktrace which will be smaller as it just gives
us a string.

Change-Id: I5309ac2ad4592fb6dbb1474526d382893fb7e6c1

4 years agoMerge "EditPage::getBaseRevision can return null. (fix phpdoc)"
jenkins-bot [Thu, 15 Feb 2018 11:03:16 +0000 (11:03 +0000)]
Merge "EditPage::getBaseRevision can return null. (fix phpdoc)"

4 years agoEditPage::getBaseRevision can return null. (fix phpdoc)
addshore [Thu, 15 Feb 2018 10:08:20 +0000 (10:08 +0000)]
EditPage::getBaseRevision can return null. (fix phpdoc)

If !$this->mBaseRevision then the code to populte $this->mBaseRevision
is run.
This code either calls Revision::newFromId or Revision::loadFromTimestamp
both of which are documented as being able to return null.
As a result EditPage::getBaseRevision can alos return null.

Bug: T187378
Change-Id: I60ad9ddcfbe6e1060cab1ad6aa2194c1a3406cbf

4 years agoMerge "Hard-deprecate ParserOutput stateful transform methods"
jenkins-bot [Thu, 15 Feb 2018 02:14:07 +0000 (02:14 +0000)]
Merge "Hard-deprecate ParserOutput stateful transform methods"

4 years agoMerge "resourceloader: Fix comment on Mobile Safari requirement"
jenkins-bot [Thu, 15 Feb 2018 00:37:22 +0000 (00:37 +0000)]
Merge "resourceloader: Fix comment on Mobile Safari requirement"

4 years agoresourceloader: Fix comment on Mobile Safari requirement
Ed Sanders [Tue, 13 Feb 2018 11:03:07 +0000 (11:03 +0000)]
resourceloader: Fix comment on Mobile Safari requirement

Mobile Safari 5.1 doesn't support Function#bind.

Change-Id: Ifdbd593352ab6d682a37010b17a13370f3c96176

4 years agoresourceloader: Remove ResourceLoaderModule::getPosition
Umherirrender [Mon, 12 Feb 2018 21:06:05 +0000 (22:06 +0100)]
resourceloader: Remove ResourceLoaderModule::getPosition

@deprecated since 1.29

Bug: T184257
Change-Id: I1a59a1f0a5fbedfea9f0b28bee8c298710557a8d

4 years agoMerge "RCFilters: Add missing jQueryMsg dependency"
jenkins-bot [Wed, 14 Feb 2018 23:43:50 +0000 (23:43 +0000)]
Merge "RCFilters: Add missing jQueryMsg dependency"

4 years agoSalvage site_stats row with negative values in miser mode
Aaron Schulz [Wed, 14 Feb 2018 23:23:42 +0000 (15:23 -0800)]
Salvage site_stats row with negative values in miser mode

* Instead of returning all zeroes, just use zero for the
  negative values in the row.
* Allow large numbers since the fields are BIGINT.
* Clean up the return types to truly be integers.
* Respect the $groups argument in SiteStatsInit::getDB().

Bug: T186947
Change-Id: I51fdc45124c12aba114540fc0ec66a3e63d61e09

4 years agoMerge "rdbms: avoid "SHOW MASTER/SLAVE STATUS" queries in the GTID case"
jenkins-bot [Wed, 14 Feb 2018 23:37:34 +0000 (23:37 +0000)]
Merge "rdbms: avoid "SHOW MASTER/SLAVE STATUS" queries in the GTID case"

4 years agoRCFilters: Add missing jQueryMsg dependency
Matthew Flaschen [Sat, 6 Jan 2018 01:11:08 +0000 (20:11 -0500)]
RCFilters: Add missing jQueryMsg dependency

Some of these messages use jQueryMsg-only features, like PLURAL.

Bug: T184320
Change-Id: I7f5a4979bb5ed5779e9d24d18189f89a9453c54e

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 14 Feb 2018 21:08:32 +0000 (22:08 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If74c8c7ca0ff8aa93e63505c9ce0009d891423fb

4 years agoMerge "Update $wgGitRepositoryViewers to use Gerrit/Gitiles instead of Phabricator"
jenkins-bot [Wed, 14 Feb 2018 18:59:32 +0000 (18:59 +0000)]
Merge "Update $wgGitRepositoryViewers to use Gerrit/Gitiles instead of Phabricator"

4 years agoUpdate $wgGitRepositoryViewers to use Gerrit/Gitiles instead of Phabricator
Jayprakash12345 [Tue, 13 Feb 2018 05:43:55 +0000 (05:43 +0000)]
Update $wgGitRepositoryViewers to use Gerrit/Gitiles instead of Phabricator

Bug: T187152
Change-Id: I957274e670eb6d1b7971d8dbad7765af568cc96a

4 years agoMerge "Log the reason why revision->getContent() returns null"
jenkins-bot [Wed, 14 Feb 2018 18:30:48 +0000 (18:30 +0000)]
Merge "Log the reason why revision->getContent() returns null"

4 years agoMerge "globals.txt: Remove trailing whitespace"
jenkins-bot [Wed, 14 Feb 2018 18:05:38 +0000 (18:05 +0000)]
Merge "globals.txt: Remove trailing whitespace"

4 years agoglobals.txt: Remove trailing whitespace
Chad Horohoe [Wed, 14 Feb 2018 17:57:48 +0000 (09:57 -0800)]
globals.txt: Remove trailing whitespace

Change-Id: I4e495754f810069247af60d72731a2f382eed8a6

4 years agoMerge "Only try to show character difference if it isn't empty"
jenkins-bot [Wed, 14 Feb 2018 17:31:33 +0000 (17:31 +0000)]
Merge "Only try to show character difference if it isn't empty"

4 years agoBe more db-friendly when purging expired userrights
Eddie Greiner-Petter [Sun, 15 Oct 2017 22:36:40 +0000 (00:36 +0200)]
Be more db-friendly when purging expired userrights

Each expired row has to be fetched from the user_groups table, deleted
from that table and added to the user_former_groups table.  Per Jaimes
request, let's not do this for all rows at once but for smaller chunks
and wait for replication to catch up after each chunk has been
processed. In addition the function to purge the expired rows now sets a
lock so that there won't be multiple concurrent runs.

Also, cleaning this table up isn't urgent and thus should be done in a
job and not a deferred update, so let's move it there.

Bug: T176754
Change-Id: I671d4b9d09677a2f474477ba7fea33a44d6318aa

4 years agoMerge "mediawiki.action.edit.preview: Remove dependency on module 'jquery.form'"
jenkins-bot [Tue, 13 Feb 2018 21:49:10 +0000 (21:49 +0000)]
Merge "mediawiki.action.edit.preview: Remove dependency on module 'jquery.form'"

4 years agoMerge "Fix typehint for multiple dbs in addCallableUpdate"
jenkins-bot [Tue, 13 Feb 2018 21:08:33 +0000 (21:08 +0000)]
Merge "Fix typehint for multiple dbs in addCallableUpdate"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 13 Feb 2018 20:58:16 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I5a54edceb1c256ae591518b788a6f9a93dd74abb

4 years agoFix typehint for multiple dbs in addCallableUpdate
Stephane Bisson [Tue, 13 Feb 2018 20:50:49 +0000 (15:50 -0500)]
Fix typehint for multiple dbs in addCallableUpdate

Change-Id: Ic4fe6c529d9394cfd0c8c8652a28f47973342096
Follow-up: I0371ecd20101c5e622497e5912676300b040865e

4 years agomediawiki.action.edit.preview: Remove dependency on module 'jquery.form'
Fomafix [Tue, 13 Feb 2018 17:47:10 +0000 (18:47 +0100)]
mediawiki.action.edit.preview: Remove dependency on module 'jquery.form'

The dependency on jQuery.fn.formToArray from module 'jquery.form' was
added in e7505417 and removed in 30a2b712.

The module 'jquery.form' is now unused in core.

Change-Id: Ic257b426584d8aff3a3bad233074f628077250eb

4 years agoMerge "Add SPARQL client to core"
jenkins-bot [Tue, 13 Feb 2018 18:22:32 +0000 (18:22 +0000)]
Merge "Add SPARQL client to core"

4 years agoMerge "Tag redirects from moves as new redirects"
jenkins-bot [Tue, 13 Feb 2018 17:58:59 +0000 (17:58 +0000)]
Merge "Tag redirects from moves as new redirects"