lhc/web/wiklou.git
3 years agoQuote $default in PostgresUpdater::setDefault
Reedy [Sat, 9 Sep 2017 16:11:24 +0000 (17:11 +0100)]
Quote $default in PostgresUpdater::setDefault

Bug: T175439
Change-Id: Id5f5f4f34c7b9ff9af4b706e3e126ba8fda6a0d5

3 years agoReplace outdated greys with WCAG conformant WikimediaUI palette ones
Volker E [Sat, 9 Sep 2017 08:27:16 +0000 (01:27 -0700)]
Replace outdated greys with WCAG conformant WikimediaUI palette ones

Replacing outdated greys with WCAG level AA conformant ones from
WikimediaUI color palette.

Bug: T152025
Change-Id: Ide230784be654def9f120d5242d036f7423e65b2

3 years agoRemove deprecated function wfFixSessionID()
Max Semenik [Sat, 9 Sep 2017 01:26:11 +0000 (18:26 -0700)]
Remove deprecated function wfFixSessionID()

Deprecated since 1.27, no callers anywhere.

Change-Id: I2d1019fdb21fe4a9d0aa767a71eb18739f841dfb

3 years agoDeprecate wfUsePHP()
Max Semenik [Sat, 9 Sep 2017 01:03:09 +0000 (18:03 -0700)]
Deprecate wfUsePHP()

No callers anywhere.

Change-Id: I47256448d313983e3cebd713f7c149e3c3a9ab47

3 years agoMerge "registration: Improve error message for invalid "callback" in extension.json"
jenkins-bot [Sat, 9 Sep 2017 00:13:46 +0000 (00:13 +0000)]
Merge "registration: Improve error message for invalid "callback" in extension.json"

3 years agoregistration: Improve error message for invalid "callback" in extension.json
Umherirrender [Wed, 6 Sep 2017 19:44:49 +0000 (21:44 +0200)]
registration: Improve error message for invalid "callback" in extension.json

Getting the following error for an invalid callback is not helpful:
Warning: Invalid argument: function: class not found in
/includes/registration/ExtensionRegistry.php on line 335

Change-Id: I4dfc011cb0a5cd06f1836d73e58f407d468e4546

3 years agoAdd Title::isValid method
daniel [Mon, 12 Jun 2017 19:11:42 +0000 (21:11 +0200)]
Add Title::isValid method

Make the notion of Title objects representing invalid titles explicit.

Bug: T165149
Change-Id: I89aaabdff9614fe63bd1244784a1d677dbc26f9e

3 years agoMerge "RCFilters: Remove getValue and use FormOptions"
jenkins-bot [Fri, 8 Sep 2017 21:33:07 +0000 (21:33 +0000)]
Merge "RCFilters: Remove getValue and use FormOptions"

3 years agoRCFilters: Remove getValue and use FormOptions
Matthew Flaschen [Fri, 8 Sep 2017 20:56:00 +0000 (16:56 -0400)]
RCFilters: Remove getValue and use FormOptions

Ensure the default is boolean, then FormOptions will
do the rest for us.

Bug: T174725
Change-Id: I92f2f77e1225f536a38f592578012855b948050c

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 8 Sep 2017 21:13:33 +0000 (23:13 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I80104ab312390512e35c648847ec49f179e6a046

3 years agoMerge "WLFilters: Respect default values"
jenkins-bot [Fri, 8 Sep 2017 17:31:27 +0000 (17:31 +0000)]
Merge "WLFilters: Respect default values"

3 years agoMerge "postEdit: Move MonoBook style to separate file"
jenkins-bot [Fri, 8 Sep 2017 15:54:24 +0000 (15:54 +0000)]
Merge "postEdit: Move MonoBook style to separate file"

3 years agoFix typo
Brad Jorsch [Fri, 8 Sep 2017 14:25:02 +0000 (10:25 -0400)]
Fix typo

Followup to Ic3a434c0

Change-Id: Ie57ab2dab2f9ae801de49e8e3998ec5a56a4541e

3 years agoWLFilters: Respect default values
Stephane Bisson [Fri, 8 Sep 2017 14:01:00 +0000 (10:01 -0400)]
WLFilters: Respect default values

Followup to I3e48a9f2d9b70f0b9f6d7c6329db9c8e8001ee49
Reported in T174725#3590145

Comparing current value and active value with
different representation ("1" !== true) leads to
not applying filters that are ON by default.

Bug: T174725
Change-Id: If083610c0294756589adfc32a59388cc7422ad5d

3 years agopostEdit: Move MonoBook style to separate file
Fomafix [Fri, 8 Sep 2017 09:32:04 +0000 (11:32 +0200)]
postEdit: Move MonoBook style to separate file

This avoids loading the MonoBook specific style on other skins.

The !important is not necessary because the skin sepecific styles are
at the end of the file and have a higher priority.

Change-Id: I4ba6c8f63b0082ac82260b20202d31d85328aa40

3 years agoAdd `border-radius` to align to WikimediaUI Style Guide
Volker E [Fri, 8 Sep 2017 04:27:58 +0000 (21:27 -0700)]
Add `border-radius` to align to WikimediaUI Style Guide

Adding `border-radius` in order to align to WikimediaUI Style Guide
and be more harmonious.

Change-Id: I4bda42c03a5dbf35866df4413cdb43233334912a

3 years agoActually delete extensions/ArticleCreationWorkflow
Kunal Mehta [Fri, 8 Sep 2017 01:18:36 +0000 (18:18 -0700)]
Actually delete extensions/ArticleCreationWorkflow

Change-Id: Ia1dfd909b9a0d3a91be3dc6108ba1f2e749f7c31

3 years agoRevert "Creating new WMF 1.30.0-wmf.17 branch"
Kunal Mehta [Fri, 8 Sep 2017 01:03:28 +0000 (18:03 -0700)]
Revert "Creating new WMF 1.30.0-wmf.17 branch"

This reverts commit 579f1bb11996f5e83d02828ab460335ebb7c1272.

Change-Id: I59e97e578d4c7e46f4aecc330fc14047a40c3495

3 years agoUpdate git submodules
Chad Horohoe [Fri, 8 Sep 2017 00:21:50 +0000 (17:21 -0700)]
Update git submodules

* Update extensions/AbuseFilter from branch 'wmf/1.30.0-wmf.17'
  - Avoid CommentStore errors by selecting correct set of columns

    Change-Id: I7d83a45fbf86dc0144d50e8b6258b97f1b0c7188

3 years agoMerge "ApiQueryLinks: Remove index forcing"
MaxSem [Thu, 7 Sep 2017 22:49:38 +0000 (22:49 +0000)]
Merge "ApiQueryLinks: Remove index forcing"

3 years agoMerge "Bump ACW"
jenkins-bot [Thu, 7 Sep 2017 22:37:20 +0000 (22:37 +0000)]
Merge "Bump ACW"

3 years agoBump ACW
Max Semenik [Thu, 7 Sep 2017 22:30:11 +0000 (15:30 -0700)]
Bump ACW

Change-Id: I3c88a2242f7fc738da2f952dca0f5e4639959aa9

3 years agoMerge "Branch ArticleCreationWorkflow" into wmf/1.30.0-wmf.17
jenkins-bot [Thu, 7 Sep 2017 21:23:14 +0000 (21:23 +0000)]
Merge "Branch ArticleCreationWorkflow" into wmf/1.30.0-wmf.17

3 years agoApiQueryRecentChanges: Fetch comment fields if rctoken is used
Brad Jorsch [Thu, 7 Sep 2017 20:58:57 +0000 (16:58 -0400)]
ApiQueryRecentChanges: Fetch comment fields if rctoken is used

When the deprecated rctoken parameter is used, the module calls
RecentChange::newFromRow(), which now requires that the comment fields
be present.

Bug: T175307
Change-Id: Ida025f419e43809c34fff386f1a1ee8881393b80
(cherry picked from commit 5ec0132821f4dca98a53b466a3d35b7a2853c616)

3 years agoApiQueryRecentChanges: Fetch comment fields if rctoken is used
Brad Jorsch [Thu, 7 Sep 2017 20:58:57 +0000 (16:58 -0400)]
ApiQueryRecentChanges: Fetch comment fields if rctoken is used

When the deprecated rctoken parameter is used, the module calls
RecentChange::newFromRow(), which now requires that the comment fields
be present.

Bug: T175307
Change-Id: Ida025f419e43809c34fff386f1a1ee8881393b80

3 years agoBranch ArticleCreationWorkflow
Max Semenik [Thu, 7 Sep 2017 20:41:20 +0000 (13:41 -0700)]
Branch ArticleCreationWorkflow

Bug: T175302
Change-Id: Ic3f277a7e8727a188ed4a8bb046928592d137598

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 7 Sep 2017 20:00:49 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If7c3b4e60e84dac723997bd6e2f97d23b861847a

3 years agoUpdate git submodules
jdlrobson [Thu, 7 Sep 2017 16:31:39 +0000 (12:31 -0400)]
Update git submodules

* Update extensions/MobileFrontend from branch 'wmf/1.30.0-wmf.17'
  - Do not use deprecated fallback handling for History/Contributions

    The Contributions page extends the History page so this change
    also fixes the warnings there.

    Bug: T175161
    Change-Id: Ia79d6e72c185fb3ffd47d62a0dc5342b31382294

3 years agoMerge "Move OrderedStreamingForkController class from CirrusSearch to core."
jenkins-bot [Thu, 7 Sep 2017 18:27:49 +0000 (18:27 +0000)]
Merge "Move OrderedStreamingForkController class from CirrusSearch to core."

3 years agoMove OrderedStreamingForkController class from CirrusSearch to core.
Stanislav Malyshev [Fri, 1 Sep 2017 22:50:59 +0000 (15:50 -0700)]
Move OrderedStreamingForkController class from CirrusSearch to core.

This class may be useful for scripts outside CirrusSearch.

Change-Id: I1ed993a3b0b64d828ae5caba6c4b540b77b2f6f5

3 years agoMerge "exception: Support message normalisation for structured logging"
jenkins-bot [Thu, 7 Sep 2017 17:08:33 +0000 (17:08 +0000)]
Merge "exception: Support message normalisation for structured logging"

3 years agoMerge "Title: Make getOtherPage() check canHaveTalkPage()"
jenkins-bot [Thu, 7 Sep 2017 09:38:24 +0000 (09:38 +0000)]
Merge "Title: Make getOtherPage() check canHaveTalkPage()"

3 years agoTitle: Make getOtherPage() check canHaveTalkPage()
Kunal Mehta [Tue, 29 Aug 2017 19:53:53 +0000 (12:53 -0700)]
Title: Make getOtherPage() check canHaveTalkPage()

Practically this doesn't make any difference, but once it's possible for
namespaces to not have talk pages, this function would have returned an
invalid Title.

Bug: T165149
Change-Id: I940433c22193d406d8b4a6cab0e6ad37e88e62c6

3 years agoMerge "ContribsPager: Batch page existence lookup for IP range contributions"
jenkins-bot [Thu, 7 Sep 2017 02:23:06 +0000 (02:23 +0000)]
Merge "ContribsPager: Batch page existence lookup for IP range contributions"

3 years agoDocument DB_SLAVE as deprecated
Kunal Mehta [Thu, 7 Sep 2017 01:09:42 +0000 (18:09 -0700)]
Document DB_SLAVE as deprecated

Change-Id: I50c127b7857b6dbccfd09014d72a130071870fab

3 years agoContribsPager: Batch page existence lookup for IP range contributions
Kunal Mehta [Thu, 7 Sep 2017 00:08:29 +0000 (17:08 -0700)]
ContribsPager: Batch page existence lookup for IP range contributions

When looking up contributions for a range of IP addresses, include the
IP's talk page in page existence lookup batch so it doesn't get looked
up individually.

Change-Id: I5151c10569a92805f79b59f68f9c57c451dc4597

3 years agoContribsPager: Don't call non-static function statically
Kunal Mehta [Thu, 7 Sep 2017 00:07:20 +0000 (17:07 -0700)]
ContribsPager: Don't call non-static function statically

Change-Id: Ic0753e96009f65f1599c9952784c52034b4ec096

3 years agoUpdate git submodules
Erik Bernhardson [Mon, 28 Aug 2017 19:58:12 +0000 (12:58 -0700)]
Update git submodules

* Update extensions/WikimediaEvents from branch 'wmf/1.30.0-wmf.17'
  - Encode human search relevance survey into html output

    Moves the search relevance configuration from javascript into php
    configuration so it can be run on a larger number of pages without
    exploding the size of javascript delivered to everyone with all
    that config.

    The downside of this approach is that because the config is cached
    into the page html any updates have to work their way through varnish
    caching. For the initial test this should be fine as we can purge the
    relevant pages over some small time period. In the future when we are
    doing larger scale collection we just have to keep in mind that
    configuration changes take around 7 days to propogate.

    Bug: T174387
    Change-Id: I7ae522155e67610d25b5857d7b3918559bce8bc7
    (cherry picked from commit e722fe1a9b0d41c3597f9f9326e7fc6f0e1cd9c6)

3 years agoMerge "RCFilters: Live Update: download less data"
jenkins-bot [Wed, 6 Sep 2017 21:10:08 +0000 (21:10 +0000)]
Merge "RCFilters: Live Update: download less data"

3 years agoMerge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Wed, 6 Sep 2017 21:00:31 +0000 (21:00 +0000)]
Merge "Sync up with Parsoid parserTests.txt"

3 years agoMerge "Align "What's this" vertically"
jenkins-bot [Wed, 6 Sep 2017 20:56:48 +0000 (20:56 +0000)]
Merge "Align "What's this" vertically"

3 years agoSync up with Parsoid parserTests.txt
C. Scott Ananian [Wed, 6 Sep 2017 20:32:34 +0000 (16:32 -0400)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit 3648950432dd65a7cb4a1f80184e72f301a9ca57

Change-Id: I6ec86f7296eb51683b53dbbf0d26f5a87b84e6c7

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 6 Sep 2017 20:12:31 +0000 (22:12 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I2aaed9c1c21b38c46c8ef3981ec629aab2af2027

3 years agoMerge "Making numerous fields unsigned to match their target referenced column"
jenkins-bot [Wed, 6 Sep 2017 19:37:29 +0000 (19:37 +0000)]
Merge "Making numerous fields unsigned to match their target referenced column"

3 years agoMerge "Remove outdated comment"
jenkins-bot [Wed, 6 Sep 2017 18:42:46 +0000 (18:42 +0000)]
Merge "Remove outdated comment"

3 years agoMaking numerous fields unsigned to match their target referenced column
Reedy [Wed, 26 Apr 2017 16:08:51 +0000 (17:08 +0100)]
Making numerous fields unsigned to match their target referenced column

Bug: T157227
Change-Id: Ic11822d6c893103adcc99a3e188a592f13c968b8

3 years agoUpdate git submodules
Brad Jorsch [Wed, 30 Aug 2017 17:06:22 +0000 (13:06 -0400)]
Update git submodules

* Update extensions/Flow from branch 'wmf/1.30.0-wmf.17'
  - Handle new fields for RecentChange object attributes

    See core change Ic3a434c0.

    Bug: T166732
    Change-Id: I284b5aae6979cd97ab53241c00a84077afd1e95d
    (cherry picked from commit 088142f6f0e6e92fc6f1c92c4861216b769c740e)

3 years agoRCFilters: Live Update: download less data
Stephane Bisson [Tue, 5 Sep 2017 15:45:55 +0000 (11:45 -0400)]
RCFilters: Live Update: download less data

Make ChangesListSpecialPage respect action=render
to exclude the MW chrome (header, logo, sidebar, etc).

Introduce peek=1 in ChangesListSpecialPage to skip
the form and changes list rendering and return
200 when there is new data and 304 (not modified)
where there isn't.

Together, they reduce the page size from 49.9k to 275b on polling
and eliminate most HTTP 404 console errors.

Bug: T173613
Change-Id: I0aec878ae80e22814b196b26e944db8c78a5f91a

3 years agoMerge "Move around "ا" to after "آ" and not before"
jenkins-bot [Wed, 6 Sep 2017 13:12:13 +0000 (13:12 +0000)]
Merge "Move around "ا" to after "آ" and not before"

3 years agoNote whether a category was added in a machine readable way
Mark A. Hershberger [Tue, 5 Sep 2017 18:18:02 +0000 (14:18 -0400)]
Note whether a category was added in a machine readable way

CategoryMembershipChange is great, but it doesn't have a
machine-readable way to see if the category has been added or removed
from the page. We could parse the comments, but that would rely on
reading the comments and matching the message against the translated
strings.

This patch adds a couple of parameters and notes whether the change
was an addition or removal in rc_params.

Also, puts the evaluation of the AbortEmailNotification hook before
the check of rc_type in the hopes that the extension CatWatch can send
out emails at the right time.

Bug: T175052
Change-Id: I3e2ac0cc148b9d618e2f8b7853b14bff827ee443

3 years agoApiQueryLinks: Remove index forcing
Brad Jorsch [Wed, 12 Apr 2017 14:07:03 +0000 (10:07 -0400)]
ApiQueryLinks: Remove index forcing

Appears to have been added for T16102, which has hopefully been fixed
since. Let's try it and see if queries break.

Bug: T162774
Change-Id: If60442b9c8856b80a071ed9df830f9a3397218c9

3 years agoMerge "WLFilters: hide watchlist-details during loading of the app"
jenkins-bot [Wed, 6 Sep 2017 00:22:51 +0000 (00:22 +0000)]
Merge "WLFilters: hide watchlist-details during loading of the app"

3 years agoMerge "RCLFilters: Bring back Saved Queries"
jenkins-bot [Wed, 6 Sep 2017 00:21:57 +0000 (00:21 +0000)]
Merge "RCLFilters: Bring back Saved Queries"

3 years agoUpdate git submodules
Brad Jorsch [Tue, 5 Sep 2017 19:37:39 +0000 (15:37 -0400)]
Update git submodules

* Update extensions/Scribunto from branch 'wmf/1.30.0-wmf.17'
  - Fix tests

    Iaa880531 added extra frames in the call stack, so the frame being
    tested by the "setfenv invalid level" and "getfenv invalid level" tests
    was no longer invalid.

    Bug: T175065
    Change-Id: Id1028e7c8bbb92fb9d7d01ebeabd94e8ba284b1c
    (cherry picked from commit 7418a571ac59cc25b682c681a9c2dd330c4a983a)

3 years agoMore thorough documentation for ChangesListSpecialPageStructuredFilters
Matthew Flaschen [Tue, 5 Sep 2017 23:43:39 +0000 (19:43 -0400)]
More thorough documentation for ChangesListSpecialPageStructuredFilters

Change-Id: Iacb3f36c0c2eaf109c39005b4cbd5ff434eb1d84

3 years agoMerge "Update OOjs UI to v0.23.0"
jenkins-bot [Tue, 5 Sep 2017 23:10:29 +0000 (23:10 +0000)]
Merge "Update OOjs UI to v0.23.0"

3 years agoRemove outdated comment
Arlo Breault [Tue, 5 Sep 2017 22:30:24 +0000 (18:30 -0400)]
Remove outdated comment

 * Presumably, should have been part of 3f7615be.

Change-Id: I096c65e72e07c2e1f5a8cd96f6cb930508db8568

3 years agoMerge "RCFilters: make isStructuredFilterUiEnabled public"
jenkins-bot [Tue, 5 Sep 2017 22:20:42 +0000 (22:20 +0000)]
Merge "RCFilters: make isStructuredFilterUiEnabled public"

3 years agoUpdate OOjs UI to v0.23.0
Volker E [Tue, 5 Sep 2017 22:07:32 +0000 (15:07 -0700)]
Update OOjs UI to v0.23.0

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.0

Depends-on: I26318472e5e0f5d1863525cf997d08973e2b931c
Change-Id: Icf1ad51da9d588226591366f822cabdd732f9018

3 years agoFix maintenance script that populates the ip_changes table
MusikAnimal [Tue, 5 Sep 2017 21:21:55 +0000 (17:21 -0400)]
Fix maintenance script that populates the ip_changes table

Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e065

3 years agoAdd basic IP range support to Special:Contributions
MusikAnimal [Fri, 21 Apr 2017 16:17:59 +0000 (12:17 -0400)]
Add basic IP range support to Special:Contributions

This works by using the new table introduced with T156318.

The only thing that differs from normal Special:Contribs is we are
showing the IP address next to each entry. This is it how it is
displayed if you request to see newbie contributions:
https://en.wikipedia.org/wiki/Special:Contributions?contribs=newbie

For the time being, Special:DeletedContributions does not support
IP ranges. Various other irrelevant links such as Uploads and Logs
are also hidden.

Refer to P4725 for a way to automate creation of edits by random
IPs in your dev environment.

IP::isValidBlock() has been deprecated with this dependent change:
https://gerrit.wikimedia.org/r/#/c/373165/

Bug: T163562
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e064

3 years agoMerge "CommentStore: Try to improve description of insert()"
jenkins-bot [Tue, 5 Sep 2017 19:56:16 +0000 (19:56 +0000)]
Merge "CommentStore: Try to improve description of insert()"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 5 Sep 2017 19:55:32 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id6736ce3f2ba9f37ec4886fd1c96956f1e7a6289

3 years agoCommentStore: Try to improve description of insert()
Kunal Mehta [Tue, 5 Sep 2017 19:02:33 +0000 (12:02 -0700)]
CommentStore: Try to improve description of insert()

And the similar insertWithTempTable() too.

Change-Id: Ibf0f96d3b9b0f7fe53eb9e11b94fabadc4580632

3 years agoRCLFilters: Bring back Saved Queries
Stephane Bisson [Tue, 5 Sep 2017 18:49:19 +0000 (14:49 -0400)]
RCLFilters: Bring back Saved Queries

Saved Queries used to be shown on Special:RecentChangesLinked
but it got lost when refactoring the top section to accomodate
Watchlist.

Change-Id: I2411dd068415a40cceef76833e94e184f57554af

3 years agoMerge "Handle comment truncation in CommentStore"
jenkins-bot [Tue, 5 Sep 2017 18:39:21 +0000 (18:39 +0000)]
Merge "Handle comment truncation in CommentStore"

3 years agoConvert INDEX into PRIMARY KEY in l10n_cache
tjlsangria [Fri, 28 Oct 2016 14:33:32 +0000 (15:33 +0100)]
Convert INDEX into PRIMARY KEY in l10n_cache

Bug: T146591
Change-Id: I85ab18bfa30e562e76253e3ef71653dbf46db041

3 years agoMerge "EditPage: Hard deprecate submit()"
jenkins-bot [Tue, 5 Sep 2017 17:35:23 +0000 (17:35 +0000)]
Merge "EditPage: Hard deprecate submit()"

3 years agoMerge "EditPage: Don't use RequestContext::getMain()"
jenkins-bot [Tue, 5 Sep 2017 17:34:20 +0000 (17:34 +0000)]
Merge "EditPage: Don't use RequestContext::getMain()"

3 years agoMerge "EditPage: Don't use $wgOut"
jenkins-bot [Tue, 5 Sep 2017 17:34:10 +0000 (17:34 +0000)]
Merge "EditPage: Don't use $wgOut"

3 years agoCreating new WMF 1.30.0-wmf.17 branch
Chad Horohoe [Tue, 5 Sep 2017 17:12:08 +0000 (17:12 +0000)]
Creating new WMF 1.30.0-wmf.17 branch

3 years agoMerge "Enable save button when removing item from UsersMultiselectWidget list"
jenkins-bot [Tue, 5 Sep 2017 16:00:51 +0000 (16:00 +0000)]
Merge "Enable save button when removing item from UsersMultiselectWidget list"

3 years agoresourceloader: Reduce severity for non-fatal JS errors to warn()
Timo Tijhof [Tue, 5 Sep 2017 15:29:34 +0000 (17:29 +0200)]
resourceloader: Reduce severity for non-fatal JS errors to warn()

Follows-up 37df74151 and 12cca1c6, which made the internal exceptions
from sortDependencies() for unknown modules, or circular dependencies,
get logged to the console instead of silently caught.

There were logged using mw.track('resourceloader.exception') which
get logged to the console using console.error() by default.

Change this to using console.warn() instead.

Until 37df74151 and 12cca1c6, messages from `resourceloader.exception` where
quite rare. However both the rare cases, as well as the cases we added in
these commits, are non-fatal. Given various false reports in recent weeks
on Phabricator from users thinking they are witnessing fatal errors, let's
change the severity level of these in the browser console to "warn" instead
of "error", which makes them easier to distinguish from fatal errors.

Change-Id: I8d7aff6c72e74836c034b18a5ff58428d27628ff

3 years agoMerge "Check for Wikidiff2 version 0.3 NOT for 0.3.0"
jenkins-bot [Tue, 5 Sep 2017 10:50:55 +0000 (10:50 +0000)]
Merge "Check for Wikidiff2 version 0.3 NOT for 0.3.0"

3 years agoMerge "Fix RestbaseVirtualRESTService URL standardization"
jenkins-bot [Tue, 5 Sep 2017 08:56:06 +0000 (08:56 +0000)]
Merge "Fix RestbaseVirtualRESTService URL standardization"

3 years agoEditPage: Hard deprecate submit()
Kunal Mehta [Tue, 5 Sep 2017 06:09:55 +0000 (23:09 -0700)]
EditPage: Hard deprecate submit()

Change-Id: I456139a8bd968dd3199225d6526624e778ed3381

3 years agoEditPage: Don't use RequestContext::getMain()
Kunal Mehta [Tue, 5 Sep 2017 05:55:43 +0000 (22:55 -0700)]
EditPage: Don't use RequestContext::getMain()

We already have a context object.

Change-Id: I09816dd485413d858e5ee422ae07a843cb543da5

3 years agoEditPage: Don't use $wgOut
Kunal Mehta [Tue, 5 Sep 2017 05:52:46 +0000 (22:52 -0700)]
EditPage: Don't use $wgOut

Use $this->context->getOutput() instead everywhere, except in one static
function, that will be dealt with later.

For the most part OutputPage is a singleton, so this should affect very
little.

Bug: T144366
Change-Id: I59699a47e55f281284c5e96676cfe7bc0c499e28

3 years agoMerge "EditPage: Deprecate getCheckboxes() and getCheckboxesOOUI()"
jenkins-bot [Tue, 5 Sep 2017 06:23:55 +0000 (06:23 +0000)]
Merge "EditPage: Deprecate getCheckboxes() and getCheckboxesOOUI()"

3 years agoEnable save button when removing item from UsersMultiselectWidget list
David Barratt [Mon, 4 Sep 2017 23:19:42 +0000 (19:19 -0400)]
Enable save button when removing item from UsersMultiselectWidget list

UsersMultiselectWidget uses a hidden input to store values. Hidden inputs do not trigger onChange events. The onChange event must be trigger manually.

Bug: T173973
Change-Id: Ib9ec31791f1fe7bdde8d91ae16a2111f4320c615

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 4 Sep 2017 19:55:23 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I896047415adbedd7d474845a1dac4531d9c8d196

3 years agoAlways put type information before variable name for @var tags
Kunal Mehta [Mon, 4 Sep 2017 18:05:26 +0000 (11:05 -0700)]
Always put type information before variable name for @var tags

Like other tags, @var should have the type information before the
variable name.

<https://docs.phpdoc.org/references/phpdoc/tags/var.html>

Change-Id: I9eca6957b1990fa8cc687103dc02ee38af5f9086

3 years agoMerge "SpecialUpload: Stop loading 'mediawiki.action.edit'"
jenkins-bot [Mon, 4 Sep 2017 17:29:28 +0000 (17:29 +0000)]
Merge "SpecialUpload: Stop loading 'mediawiki.action.edit'"

3 years agoFix you -> your in 'pagedata-text' message
Reedy [Mon, 4 Sep 2017 16:25:34 +0000 (17:25 +0100)]
Fix you -> your in 'pagedata-text' message

Bug: T174961
Change-Id: I7cfcfca4decac3e2afc09e58959a001ac13d3d49

3 years agoMerge "Turn Special:NewFiles list of media types into list of checkboxes"
jenkins-bot [Mon, 4 Sep 2017 16:23:30 +0000 (16:23 +0000)]
Merge "Turn Special:NewFiles list of media types into list of checkboxes"

3 years agoSpecialUpload: Stop loading 'mediawiki.action.edit'
Bartosz Dziewoński [Mon, 4 Sep 2017 16:04:28 +0000 (18:04 +0200)]
SpecialUpload: Stop loading 'mediawiki.action.edit'

The comment says it's for <charinsert> support, but that's not true
anymore, as the CharInsert extension itself takes care of loading its
script on Special:Upload (see CharInsert::onBeforePageDisplay()).

Back in the day, this module included a lot more stuff related to the
edit toolbar and such, so this might have been warranted, but there is
nothing useful for uploading left in it anymore.

It's very unintuitive that it would be loaded there; folks did not
realize that it is the case and recent changes to the module started
causing issues on Special:Upload.

Bug: T174935
Change-Id: I11e886801a27f796e5a5935ec9c93b1329cc5b87

3 years agoMerge "Drop compatibility with PHP 5.3"
jenkins-bot [Mon, 4 Sep 2017 14:34:50 +0000 (14:34 +0000)]
Merge "Drop compatibility with PHP 5.3"

3 years agoMerge "Fix typo in ILBFactory::waitForReplication phpdoc"
jenkins-bot [Mon, 4 Sep 2017 14:10:06 +0000 (14:10 +0000)]
Merge "Fix typo in ILBFactory::waitForReplication phpdoc"

3 years agoMerge "resourceloader: Preload base modules request from startup module"
jenkins-bot [Mon, 4 Sep 2017 12:36:37 +0000 (12:36 +0000)]
Merge "resourceloader: Preload base modules request from startup module"

3 years agoCheck for Wikidiff2 version 0.3 NOT for 0.3.0
Tobias Gritschacher [Mon, 4 Sep 2017 11:58:49 +0000 (13:58 +0200)]
Check for Wikidiff2 version 0.3 NOT for 0.3.0

version_compare( '0.3', '0.3.0', '>=' ) gives false, so we need to check
for 0.3 since the Wikidiff2 version is defined as 0.3 in
https://gerrit.wikimedia.org/r/#/c/319866/60/Wikidiff2.h

Bug: T166571
Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 3 Sep 2017 19:54:41 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I7b033dfc8380deaed29661b51cacc29f08c5b7f6

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 3 Sep 2017 06:21:33 +0000 (08:21 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5ae624cf1b2ed597abb2ffb96dc6f13267e93967

3 years agoMerge "EditPage: Remove unused variable in getCheckboxesOOUI()"
jenkins-bot [Sun, 3 Sep 2017 01:34:05 +0000 (01:34 +0000)]
Merge "EditPage: Remove unused variable in getCheckboxesOOUI()"

3 years agoEditPage: Deprecate getCheckboxes() and getCheckboxesOOUI()
Bartosz Dziewoński [Mon, 28 Aug 2017 17:47:01 +0000 (19:47 +0200)]
EditPage: Deprecate getCheckboxes() and getCheckboxesOOUI()

Follow-up to 478caa076f75fde935c66eb9334410d868c30818, which asked
for someone else to disentangle that. After this patch, we're left
with separate blocks of code that can just be deleted when we remove
the EditPageBeforeEditChecks hook or the getCheckboxes() function.

Change-Id: I88d2dda3a6e030f73e209e0d389d4c0aa6c45139

3 years agoDrop compatibility with PHP 5.3
Matěj Suchánek [Sat, 2 Sep 2017 18:01:44 +0000 (20:01 +0200)]
Drop compatibility with PHP 5.3

Since 5.4, $this works inside closures.

Change-Id: I6987f76a1e33d6d7ab020a57186e5477186bbf2e

3 years agoTableSorter: Sort unrecognized dates as -Infinity
Derk-Jan Hartman [Sat, 2 Sep 2017 08:51:48 +0000 (10:51 +0200)]
TableSorter: Sort unrecognized dates as -Infinity

Follow-up to: I664b4cc
Bug: T174814
Change-Id: I028681172be7a30e51cab42847c4fc35e9358aca

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 2 Sep 2017 07:16:49 +0000 (09:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibf8a472053f8dafc581fbe3bd8d9be188048995d

3 years agoMerge "WLFilters: reword watchlist-details slightly"
jenkins-bot [Fri, 1 Sep 2017 22:14:18 +0000 (22:14 +0000)]
Merge "WLFilters: reword watchlist-details slightly"

3 years agoMerge "mediawiki.special.changeslist.legend.js: Remove wait for document ready"
jenkins-bot [Fri, 1 Sep 2017 22:08:10 +0000 (22:08 +0000)]
Merge "mediawiki.special.changeslist.legend.js: Remove wait for document ready"

3 years agomediawiki.special.changeslist.legend.js: Remove wait for document ready
Fomafix [Fri, 1 Sep 2017 21:39:30 +0000 (23:39 +0200)]
mediawiki.special.changeslist.legend.js: Remove wait for document ready

mw.hook( 'wikipage.content' ) gets fired after document ready.

Change-Id: Ia1536e734f8ae08cc7cc07c3b1854bdaafb54866