lhc/web/wiklou.git
13 years agoFollow up r79532. Do not setup a user needlessly.
Platonides [Wed, 5 Jan 2011 19:35:58 +0000 (19:35 +0000)]
Follow up r79532. Do not setup a user needlessly.

13 years agoRefactor out protocol preperation to ApiQueryExtLinksUsage::prepareProtocols()
Sam Reed [Wed, 5 Jan 2011 19:28:00 +0000 (19:28 +0000)]
Refactor out protocol preperation to ApiQueryExtLinksUsage::prepareProtocols()

13 years ago(bug 26574) Added 'upload' to $wgRestrictionTypes, allowing upload protected pages...
Bryan Tong Minh [Wed, 5 Jan 2011 19:17:36 +0000 (19:17 +0000)]
(bug 26574) Added 'upload' to $wgRestrictionTypes, allowing upload protected pages to be queried via the API and Special:ProtectedPages, and allowing disabling upload protection by removing it from $wgRestrictionTypes.

13 years agoFollowup r79638
Sam Reed [Wed, 5 Jan 2011 17:57:12 +0000 (17:57 +0000)]
Followup r79638

If we're ping limited, add a warning as such, and don't bother trying to linkupdate any of the other articles in the output.

13 years agofollow r78679, correct the comment line
Philip Tzou [Wed, 5 Jan 2011 16:44:11 +0000 (16:44 +0000)]
follow r78679, correct the comment line

13 years agoBump version
Alexandre Emsenhuber [Wed, 5 Jan 2011 16:42:32 +0000 (16:42 +0000)]
Bump version

13 years agoFollow r79649 and r79650. Errrr, remove the redundant minus
Philip Tzou [Wed, 5 Jan 2011 16:37:36 +0000 (16:37 +0000)]
Follow r79649 and r79650. Errrr, remove the redundant minus

13 years agofollow r79649, move the in-block assignment outside.
Philip Tzou [Wed, 5 Jan 2011 16:30:10 +0000 (16:30 +0000)]
follow r79649, move the in-block assignment outside.

13 years agoAdd fallback languages support for ApiOpenSearch.
Philip Tzou [Wed, 5 Jan 2011 16:21:01 +0000 (16:21 +0000)]
Add fallback languages support for ApiOpenSearch.

13 years agoEasier method (and to check existence in correct language)
Alexandre Emsenhuber [Wed, 5 Jan 2011 15:50:34 +0000 (15:50 +0000)]
Easier method (and to check existence in correct language)

13 years agoFollowup r73348, r70608: move 'infinity' stuff to DB classes
Chad Horohoe [Wed, 5 Jan 2011 13:43:13 +0000 (13:43 +0000)]
Followup r73348, r70608: move 'infinity' stuff to DB classes

13 years agoFollowup r68129: rename UndeleteForm to SpecialUndelete per CR. Not used in any exten...
Chad Horohoe [Wed, 5 Jan 2011 13:20:39 +0000 (13:20 +0000)]
Followup r68129: rename UndeleteForm to SpecialUndelete per CR. Not used in any extensions

13 years agoAllow OutputPage::parse() to parse in any langauge, modified wfMsgExt() and wfMessage...
Alexandre Emsenhuber [Wed, 5 Jan 2011 12:24:39 +0000 (12:24 +0000)]
Allow OutputPage::parse() to parse in any langauge, modified wfMsgExt() and wfMessage() accordingly

13 years agoRemoving Makefile from /skins/common (only used for minifiying jquery, which isn...
Krinkle [Wed, 5 Jan 2011 12:21:26 +0000 (12:21 +0000)]
Removing Makefile from /skins/common (only used for minifiying jquery, which isn't in here anymore).
* jquery.js removed in r65962
* jquery.min.js removed in r72349
Follow-up: r61557, r61558, r65962, r66270, r72349.

13 years agoAllow filenames to be specified in a <gallery> with the File:, Image: or media: omitt...
Daniel Friesen [Wed, 5 Jan 2011 06:16:13 +0000 (06:16 +0000)]
Allow filenames to be specified in a <gallery> with the File:, Image: or media: omitted by defaulting to NS_FILE.

13 years ago* (bug 26498) allow LinksUpdate with API
Sam Reed [Wed, 5 Jan 2011 03:31:51 +0000 (03:31 +0000)]
* (bug 26498) allow LinksUpdate with API

Original patch by Umherirrender. Tweaked to take account of User->pingLimiter() (ie only update links if not limited)

Possible TODO: Error if we are limited? $this->dieUsageMsg( array( 'actionthrottledtext' ) ); seems a bit harsh

Maybe just have a linkupdate="$this->parseMsg( array( 'actionthrottledtext' ) )" in the result? Or something. Definately notification of error to some respect is needed. Just dieing and stopping the whole process is OTT?

13 years ago* (bug 26482) add a imimages param to prop=images
Sam Reed [Wed, 5 Jan 2011 02:52:04 +0000 (02:52 +0000)]
* (bug 26482) add a imimages param to prop=images

13 years ago* (bug 26460) Add support for listing category members by category pageid
Sam Reed [Tue, 4 Jan 2011 23:59:39 +0000 (23:59 +0000)]
* (bug 26460) Add support for listing category members by category pageid

13 years agoUpdate math_image_error message, texvc has been using svipng by default since r16460.
Ilmari Karonen [Tue, 4 Jan 2011 22:05:40 +0000 (22:05 +0000)]
Update math_image_error message, texvc has been using svipng by default since r16460.

13 years ago* (bug 25135) add "normalized" to action=parse
Sam Reed [Tue, 4 Jan 2011 21:37:18 +0000 (21:37 +0000)]
* (bug 25135) add "normalized" to action=parse

Mov addition of $oldid earlier

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Tue, 4 Jan 2011 21:15:16 +0000 (21:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-04 20:46:00 UTC)

13 years agoRemove another setting of failFunction in phase3 in a database constructor
Sam Reed [Tue, 4 Jan 2011 19:54:30 +0000 (19:54 +0000)]
Remove another setting of failFunction in phase3 in a database constructor

13 years agoSimplest possible fix for *(bug 26552) ForeignDBRepo broken?
Sam Reed [Tue, 4 Jan 2011 19:33:13 +0000 (19:33 +0000)]
Simplest possible fix for *(bug 26552) ForeignDBRepo broken?

Going to see what other uses I can find of stuff constructing their own Database Instances...

13 years agoRun preSaveTransform() with the user that did the edit, not unconditionally $wgUser
Alexandre Emsenhuber [Tue, 4 Jan 2011 19:08:44 +0000 (19:08 +0000)]
Run preSaveTransform() with the user that did the edit, not unconditionally $wgUser

13 years agoUse $this->mTitle instead of $wgArticle->getTitle()
Alexandre Emsenhuber [Tue, 4 Jan 2011 15:02:54 +0000 (15:02 +0000)]
Use $this->mTitle instead of $wgArticle->getTitle()

13 years agoUse isArticleRelated() instead of checking if $wgArticle is set
Alexandre Emsenhuber [Tue, 4 Jan 2011 14:49:08 +0000 (14:49 +0000)]
Use isArticleRelated() instead of checking if $wgArticle is set

13 years agoRemove two useless CSS rules that would cause one image to be embedded thrice
Roan Kattouw [Tue, 4 Jan 2011 14:28:31 +0000 (14:28 +0000)]
Remove two useless CSS rules that would cause one image to be embedded thrice

13 years agoAdd /* @embed */ comments for URLs in all RL-ified CSS files, except in jQuery UI...
Roan Kattouw [Tue, 4 Jan 2011 14:25:35 +0000 (14:25 +0000)]
Add /* @embed */ comments for URLs in all RL-ified CSS files, except in jQuery UI's default theme. This'll reduce the number of images loaded, especially for jQuery UI.

13 years agosvn:eol-style native
Alexandre Emsenhuber [Tue, 4 Jan 2011 13:23:18 +0000 (13:23 +0000)]
svn:eol-style native

13 years agoFix jQuery UI dialog CSS for close-x.png -> close.png rename in Vector theme
Roan Kattouw [Tue, 4 Jan 2011 12:58:15 +0000 (12:58 +0000)]
Fix jQuery UI dialog CSS for close-x.png -> close.png rename in Vector theme

13 years agoFix r79532: Strct standards
X! [Tue, 4 Jan 2011 11:58:17 +0000 (11:58 +0000)]
Fix r79532: Strct standards

13 years agoPartial revert of r79520, follow up to r79558. Unconditionally use the new format.
Platonides [Tue, 4 Jan 2011 11:31:06 +0000 (11:31 +0000)]
Partial revert of r79520, follow up to r79558. Unconditionally use the new format.
For environments post r70783, they will need to rerender pages with __NOEDITSECTION__ or no headings (hopefully those will be simple pages).
There will be no extra parser cache misses for environments pre r70783.

13 years agoLocalization update for he.
Rotem Liss [Tue, 4 Jan 2011 09:40:33 +0000 (09:40 +0000)]
Localization update for he.

13 years agoFix for bug 26561: clickjacking attacks. See the bug report for full documentation.
Tim Starling [Tue, 4 Jan 2011 06:12:33 +0000 (06:12 +0000)]
Fix for bug 26561: clickjacking attacks. See the bug report for full documentation.

13 years ago*sigh* I was looking at parser tests, but not notices in a site this time... Followup...
Daniel Friesen [Tue, 4 Jan 2011 04:23:01 +0000 (04:23 +0000)]
*sigh* I was looking at parser tests, but not notices in a site this time... Followup r79558 fix a small php notice.

13 years agoFollowup r79520 and r79528, one of the args was missing when calling doEditSectionLin...
Daniel Friesen [Tue, 4 Jan 2011 04:20:09 +0000 (04:20 +0000)]
Followup r79520 and r79528, one of the args was missing when calling doEditSectionLink. Additionally the LanguageConverter was screwing up editsection markers really badly. Switched to <editsection> pesudo-xml style markers for best compatibility with the language converter. (tags are already escaped so we don't need to worry about similar user input)

13 years ago* (bug 26560) On allusers if limit < total number of users, last user gets duplicate
Sam Reed [Tue, 4 Jan 2011 04:05:32 +0000 (04:05 +0000)]
* (bug 26560) On allusers if limit < total number of users, last user gets duplicate

If $lastUserData is set to null, it won't get added again!

13 years ago* (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights
Sam Reed [Tue, 4 Jan 2011 03:36:39 +0000 (03:36 +0000)]
* (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights

13 years agoAdd API query test
X! [Tue, 4 Jan 2011 03:22:40 +0000 (03:22 +0000)]
Add API query test

13 years ago* (bug 26558) list=allusers auprop=groups does not list groups a user is automaticall...
Sam Reed [Tue, 4 Jan 2011 02:48:02 +0000 (02:48 +0000)]
* (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of

13 years agoFollowup r79545, we don't really care for duplicate userrights
Sam Reed [Tue, 4 Jan 2011 02:18:03 +0000 (02:18 +0000)]
Followup r79545, we don't really care for duplicate userrights

13 years agoAdd rights to array. Grrr
Sam Reed [Tue, 4 Jan 2011 02:13:51 +0000 (02:13 +0000)]
Add rights to array. Grrr

13 years agoCrappy spaces from r79549
Sam Reed [Tue, 4 Jan 2011 02:08:38 +0000 (02:08 +0000)]
Crappy spaces from r79549

13 years agoRest of * (bug 25767) Add userrights properties to allusers and users query lists
Sam Reed [Tue, 4 Jan 2011 02:06:55 +0000 (02:06 +0000)]
Rest of * (bug 25767) Add userrights properties to allusers and users query lists

Add missing parameter from r79545

13 years agoForcing array breaks MWFunction with <2 parameters
X! [Tue, 4 Jan 2011 01:51:48 +0000 (01:51 +0000)]
Forcing array breaks MWFunction with <2 parameters

13 years agoFix r79494: Don't prefix functions now that they're in their own class
X! [Tue, 4 Jan 2011 01:44:11 +0000 (01:44 +0000)]
Fix r79494: Don't prefix functions now that they're in their own class

13 years ago* (bug 25767) Add userrights properties to allusers and users query lists
Sam Reed [Tue, 4 Jan 2011 01:39:02 +0000 (01:39 +0000)]
* (bug 25767) Add userrights properties to allusers and users query lists

First part of this bug. Listing of all rights that users have

13 years agoFollowup to r79532: Did I really need to implement a parameter? No, I did not.
X! [Tue, 4 Jan 2011 01:35:01 +0000 (01:35 +0000)]
Followup to r79532: Did I really need to implement a parameter? No, I did not.

13 years agoUpdate to use the PHPUnit autoloader, define $IP
X! [Tue, 4 Jan 2011 01:33:57 +0000 (01:33 +0000)]
Update to use the PHPUnit autoloader, define $IP

13 years agoRemove nasty ancient global $title (at least $wgTitle is easier to grep for), its...
Chad Horohoe [Tue, 4 Jan 2011 00:42:48 +0000 (00:42 +0000)]
Remove nasty ancient global $title (at least $wgTitle is easier to grep for), its no longer set since r78512. Afaict, this generic-named global is no longer in core.

It's not a title object, it's a string of what title= in the URL. If you want that, use WebRequest::getText() or something. Using this string is *wrong* and any extensions should be fixed (I didn't check because $title is a PITA to grep for). Don't backport to 1.17 because this is trivial, harmless, and may Break Something.

(Also made fileCachedPage private since it has no outside callers and I can't see any reason why you should)

13 years agoAdd new addExtensionTable() wrapper for adding new tables for extensions: way easier...
Chad Horohoe [Mon, 3 Jan 2011 23:56:49 +0000 (23:56 +0000)]
Add new addExtensionTable() wrapper for adding new tables for extensions: way easier than remembering array syntax for addExtensionUpdate()

13 years agomake action=parse return a missingtitle error if the page param refers to a missing...
Ilmari Karonen [Mon, 3 Jan 2011 23:20:13 +0000 (23:20 +0000)]
make action=parse return a missingtitle error if the page param refers to a missing (rather than just invalid) title

13 years agoAdd API format testing
X! [Mon, 3 Jan 2011 21:36:49 +0000 (21:36 +0000)]
Add API format testing

13 years agoAdd JSON test case
X! [Mon, 3 Jan 2011 21:14:51 +0000 (21:14 +0000)]
Add JSON test case

13 years agoFollowup r79523: Test that calling self:: and parent:: throws exception
X! [Mon, 3 Jan 2011 21:14:22 +0000 (21:14 +0000)]
Followup r79523: Test that calling self:: and parent:: throws exception

13 years agoFollowup r79520, some characters inside the encoded data were being modified by the...
Daniel Friesen [Mon, 3 Jan 2011 21:04:05 +0000 (21:04 +0000)]
Followup r79520, some characters inside the encoded data were being modified by the parser causing it to break. Switching to a encoding scheme without that issue and adding a test to throw a less fatal error.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Mon, 3 Jan 2011 20:52:23 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-03 20:25:00 UTC)

13 years agoMove comment about groups potentially returning less results from server.
Sam Reed [Mon, 3 Jan 2011 20:41:22 +0000 (20:41 +0000)]
Move comment about groups potentially returning less results from server.

Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)

13 years agomerge the nearly identical Title::moveToNewTitle() and Title::moveOverExistingRedirec...
Ilmari Karonen [Mon, 3 Jan 2011 20:32:04 +0000 (20:32 +0000)]
merge the nearly identical Title::moveToNewTitle() and Title::moveOverExistingRedirect() to a single Title::moveToInternal() method

13 years agoThrow an exception if calling parent or self on MWFunction.
X! [Mon, 3 Jan 2011 20:19:51 +0000 (20:19 +0000)]
Throw an exception if calling parent or self on MWFunction.

13 years agoTry to output editsection markers instead of rendered editsection links and defer...
Daniel Friesen [Mon, 3 Jan 2011 20:17:20 +0000 (20:17 +0000)]
Try to output editsection markers instead of rendered editsection links and defer the rendering to a point where the markup does not need to be stored in the cache.
Doing this allows skins to override doEditSectionLinks without poluting the parser cache or fragmenting the parser cache more.
As a side effect it eliminates the primary cause of user language based parser cache fragmentation.
Because this makes most old parser cache entries invalid $wgUseEditSectionTokens is provided so that large installations like Wikipedia can keep their old parser cache entries.

13 years agoRun is_callable, just to make sure the autoloader gets called.
X! [Mon, 3 Jan 2011 19:55:44 +0000 (19:55 +0000)]
Run is_callable, just to make sure the autoloader gets called.

13 years ago* Modified Article::loadPageData() to use a slave database connection and pageDataFro...
Alexandre Emsenhuber [Mon, 3 Jan 2011 19:50:01 +0000 (19:50 +0000)]
* Modified Article::loadPageData() to use a slave database connection and pageDataFromTitle() instead of pageDataFromId() in the default case, as in Wiki.php (this also saves a query since the ID will be fetched with other fileds)
* Removed the loadPageData() call for the initial article in Wiki.php, will be triggered by the isRedirect() call 7 lines below if needed (this was not needed if $target is set by the InitializeArticleMaybeRedirect hook), but kept the second one (same as above, Article::exists() triggers Title::getArticleId() that would use one query to get id and a second one is needed to get the complete page data)
* Modified Article::fetchContent() to use common code (loadPageData()) and to only call it if really needed

13 years agoJust call loadPageData() if not already done to get the $mIsRedirect flag in Article...
Alexandre Emsenhuber [Mon, 3 Jan 2011 18:15:44 +0000 (18:15 +0000)]
Just call loadPageData() if not already done to get the $mIsRedirect flag in Article::isRedirect() instead of doing a lot of useless stuff

13 years agono need to set $this->mOldId, this is already done in getOldID()
Alexandre Emsenhuber [Mon, 3 Jan 2011 17:12:27 +0000 (17:12 +0000)]
no need to set $this->mOldId, this is already done in getOldID()

13 years agoChange the xpath of the 'You can now Folder/index.php start using your wiki' text.
nadeesha [Mon, 3 Jan 2011 09:18:21 +0000 (09:18 +0000)]
Change the xpath of the 'You can now Folder/index.php start using your wiki' text.

13 years agoChanged 'enter your wiki' link, environment ok text and remove 'Subscribe to the...
nadeesha [Mon, 3 Jan 2011 09:07:55 +0000 (09:07 +0000)]
Changed 'enter your wiki' link, environment ok text and remove 'Subscribe to the release announcements mailing list' check box verification section

13 years agoChange the xpath of the 'Upgrade complete' text
nadeesha [Mon, 3 Jan 2011 09:06:53 +0000 (09:06 +0000)]
Change the xpath of the 'Upgrade complete' text

13 years agoRemove verification for help field hint for 'Subscribe to the release announcements...
nadeesha [Mon, 3 Jan 2011 09:05:58 +0000 (09:05 +0000)]
Remove verification for help field hint for  'Subscribe to the release announcements mailing list' as per  the code review comment(MediaWiki r79089)

13 years agoRemove testOnlyBackButtonAvailability() function as per the code review comment ...
nadeesha [Mon, 3 Jan 2011 09:05:18 +0000 (09:05 +0000)]
Remove testOnlyBackButtonAvailability() function as per the code review comment (MediaWiki r78165 )

13 years agoRemove unreachable return;
Sam Reed [Mon, 3 Jan 2011 03:40:26 +0000 (03:40 +0000)]
Remove unreachable return;

Add missing global $IP;

13 years agoMark broken parser tests as broken
X! [Mon, 3 Jan 2011 02:49:52 +0000 (02:49 +0000)]
Mark broken parser tests as broken

13 years agoMove wfCreateObject to MWFunction::newObj. This uses the ReflectionClass to
X! [Mon, 3 Jan 2011 02:10:05 +0000 (02:10 +0000)]
Move wfCreateObject to MWFunction::newObj. This uses the ReflectionClass to
instantiate a variable-length constructor in php 5.1.3 and up, and falls
back to the old, ugly, manual method that was in the old wfCreateObject
function. The instances in the core have been replaced.

13 years agoRefresh header fix for Opera, as in r79498
Tim Starling [Mon, 3 Jan 2011 02:05:10 +0000 (02:05 +0000)]
Refresh header fix for Opera, as in r79498

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sun, 2 Jan 2011 21:18:06 +0000 (21:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-02 20:53:00 UTC)

13 years ago* (bug 26541) Generator-ise ApiQueryRecentChanges
Sam Reed [Sun, 2 Jan 2011 21:01:44 +0000 (21:01 +0000)]
* (bug 26541) Generator-ise ApiQueryRecentChanges

13 years agoForgot the RELEASE-NOTES (woo, 500!)
X! [Sun, 2 Jan 2011 20:00:32 +0000 (20:00 +0000)]
Forgot the RELEASE-NOTES (woo, 500!)

13 years ago-Add &watchuser option to ApiBlock
X! [Sun, 2 Jan 2011 19:58:27 +0000 (19:58 +0000)]
-Add &watchuser option to ApiBlock
-Write tests for ApiBlock

13 years agoFix for r64254: undefined variable
Alexandre Emsenhuber [Sun, 2 Jan 2011 19:04:23 +0000 (19:04 +0000)]
Fix for r64254: undefined variable

13 years agoFollowup to r79463: Move fallback functions to new Fallback class
X! [Sun, 2 Jan 2011 15:54:18 +0000 (15:54 +0000)]
Followup to r79463: Move fallback functions to new Fallback class

13 years agoFix for r45497: undefined variable
Alexandre Emsenhuber [Sun, 2 Jan 2011 14:35:22 +0000 (14:35 +0000)]
Fix for r45497: undefined variable

13 years agoReplaced call to in_string() by strpos() since the former is not available at the...
Alexandre Emsenhuber [Sun, 2 Jan 2011 14:29:04 +0000 (14:29 +0000)]
Replaced call to in_string() by strpos() since the former is not available at the time this function is called from WebStart.php (was breaking the installer)

13 years agoThe subtitle on movepage is now redundant with the tabs
Niklas Laxström [Sun, 2 Jan 2011 12:43:43 +0000 (12:43 +0000)]
The subtitle on movepage is now redundant with the tabs

13 years agoFollow-up r79483: Fix syntax error: PHP Notice: Undefined variable: wgUpgradeKey...
Raimond Spekking [Sun, 2 Jan 2011 10:07:58 +0000 (10:07 +0000)]
Follow-up r79483: Fix syntax error: PHP Notice: Undefined variable: wgUpgradeKey in /home/betawiki/projects/mediawiki-ext/Installer/Installer.i18n.php on line 5997

13 years agoFixup some syntax errors in messages
Sam Reed [Sun, 2 Jan 2011 09:30:41 +0000 (09:30 +0000)]
Fixup some syntax errors in messages

13 years agoMethod documentation
Sam Reed [Sun, 2 Jan 2011 08:33:47 +0000 (08:33 +0000)]
Method documentation

13 years agoExplicitally define $duplicates = array();
Sam Reed [Sun, 2 Jan 2011 08:25:05 +0000 (08:25 +0000)]
Explicitally define $duplicates = array();

Also changed undefined $row for $rows

13 years ago* (bug 26540) Fixed wrong call to applyPatch in MysqlUpdater
Sam Reed [Sun, 2 Jan 2011 08:05:04 +0000 (08:05 +0000)]
* (bug 26540) Fixed wrong call to applyPatch in MysqlUpdater

13 years agoPer my comment on r68760: Make MWfunction class, complete with call_user_func helper...
X! [Sun, 2 Jan 2011 06:48:07 +0000 (06:48 +0000)]
Per my comment on r68760: Make MWfunction class, complete with call_user_func helper functions that automatically
make the callback PHP 5.1 compatible with the Class::Method syntax. Add Unit tests to supplement it.

13 years agoFollowup to r79477: Add invalid purge title
X! [Sun, 2 Jan 2011 06:15:32 +0000 (06:15 +0000)]
Followup to r79477: Add invalid purge title

13 years agoAdd API purge test (mainly as proof of concept for how API tests should be written)
X! [Sun, 2 Jan 2011 06:09:58 +0000 (06:09 +0000)]
Add API purge test (mainly as proof of concept for how API tests should be written)

13 years agoRefactor much of the API testing code.
X! [Sun, 2 Jan 2011 05:52:00 +0000 (05:52 +0000)]
Refactor much of the API testing code.
Old: ApiWatchTest not only tested the watch module, but also tested the login module,
     and the login module test was also used to log in to the API for the other tests.
New: ApiWatchTest only contains watch-specific methods. The login testing has been moved
     to ApiTest. The code used to log in and get tokens have been moved to ApiSetup. Nice,
     organized, and much nicer than before. ApiUploadTest is still pretty fugly, though.

13 years ago* Toggle entire element if no .mw-collapsible-content is found
Krinkle [Sun, 2 Jan 2011 04:46:44 +0000 (04:46 +0000)]
* Toggle entire element if no .mw-collapsible-content is found
* Bug fixed in which a single customtoggle should trigger multiple customcollapsible elements

If no .mw-collapsible-content element is found when the toggleElement() function is called, assume that the user wants the mw-collapsible itself to be toggled. This enables custom use with table rows (in which we dont want something inside to toggle but the entire table row) - with a remote toggle.

This change makes it possible to have a togglable table-row.

The intial "collapsed" state for a mw-customtoggle is no longer executed by performing a click on the mw-customtoggle. Instead by calling the toggle function directly.
Reason being that an mw-customtoggle could have any number of special functions bound to it (be it the function to toggle another mw-customcollapsible, or perhaps a totally different function).

I considered using this method for 'normal' default togglers as well. However default togglers have more actions involved aside from just 'toggling' the element. Namely changing the innerText to the localized message and swapping classes. Those stay as they are by simply simulating a click() event on them (if the initial state should be collapsed).

13 years agoFollowup r79470, removed unused variable
Sam Reed [Sun, 2 Jan 2011 04:46:41 +0000 (04:46 +0000)]
Followup r79470, removed unused variable

13 years agoGlobalFunction additions:
X! [Sun, 2 Jan 2011 04:38:04 +0000 (04:38 +0000)]
GlobalFunction additions:
-in_string has a case-insensitive option
-wfClientAcceptsGzip has a force option to force resetting the static value, useful for unit tests

Unit tests for more global functions added

13 years agoMethod documentation
Sam Reed [Sun, 2 Jan 2011 04:37:06 +0000 (04:37 +0000)]
Method documentation

Change variable assignment

13 years agoApiQueryRevisions: Switch from manual Cache checking, to use $article->getParserOutput()
Sam Reed [Sun, 2 Jan 2011 03:20:45 +0000 (03:20 +0000)]
ApiQueryRevisions: Switch from manual Cache checking, to use $article->getParserOutput()

ApiParse: Fix comment typo

13 years agoAdd more wfDebug tests
X! [Sun, 2 Jan 2011 02:33:07 +0000 (02:33 +0000)]
Add more wfDebug tests

13 years agoFollowup r79467: Add more wfDebug() tests, complete with MockOutputPage
X! [Sun, 2 Jan 2011 02:16:32 +0000 (02:16 +0000)]
Followup r79467: Add more wfDebug() tests, complete with MockOutputPage

13 years agoAdd some wfDebug() unit tests
X! [Sun, 2 Jan 2011 01:59:52 +0000 (01:59 +0000)]
Add some wfDebug() unit tests