lhc/web/wiklou.git
2 years ago.gitignore: Fix .vscode
Zoranzoki21 [Fri, 26 Oct 2018 13:33:53 +0000 (13:33 +0000)]
.gitignore: Fix .vscode

.vscode is directory

Change-Id: I82d1da1b51b4bd32423ad0bb70d30df109fae1ae

2 years agoMerge "RCFilters: Apply same distance to FilterItemHighlightButtons as other elements"
jenkins-bot [Fri, 26 Oct 2018 10:50:38 +0000 (10:50 +0000)]
Merge "RCFilters: Apply same distance to FilterItemHighlightButtons as other elements"

2 years agoMerge "RCFilters: Cleanup 'Namespaces' dropdown borders appearance"
jenkins-bot [Fri, 26 Oct 2018 10:50:33 +0000 (10:50 +0000)]
Merge "RCFilters: Cleanup 'Namespaces' dropdown borders appearance"

2 years agoMerge "Remove unnecessary, unoptimized, unused overview SVG"
jenkins-bot [Fri, 26 Oct 2018 03:04:20 +0000 (03:04 +0000)]
Merge "Remove unnecessary, unoptimized, unused overview SVG"

2 years agoFix use of non-existent variable Parser::$config
Tim Starling [Thu, 25 Oct 2018 23:14:15 +0000 (16:14 -0700)]
Fix use of non-existent variable Parser::$config

Fix bug from Ib4394f370cb561ccf195338a1c2e9e465dcb3dc3

Add test.

Bug: T208000
Change-Id: Ia81cca1b64afef2af3cb8dff19719a7f0de9d306

2 years agoRCFilters: Apply same distance to FilterItemHighlightButtons as other elements
Volker E [Thu, 25 Oct 2018 22:59:17 +0000 (15:59 -0700)]
RCFilters: Apply same distance to FilterItemHighlightButtons as other elements

FilterItemHighlightButtons have lost vertical alignment with
“Highlight results”. This patch reintroduces it.

Change-Id: If5578564efced5f0ba4d3ca7ed3d6787b5b0ce3a

2 years agoRCFilters: Cleanup 'Namespaces' dropdown borders appearance
Volker E [Thu, 25 Oct 2018 22:06:56 +0000 (15:06 -0700)]
RCFilters: Cleanup 'Namespaces' dropdown borders appearance

Cleaning-up by
- adding border only between namespace and talk options
- adding namespace border on all but the first occurrence

Change-Id: Icfc87757deda9b7655c4ea5c919b5c2f2e2ae09e

2 years agoMerge "Clear the title cache in MutableRevisionRecordTest"
jenkins-bot [Thu, 25 Oct 2018 21:50:51 +0000 (21:50 +0000)]
Merge "Clear the title cache in MutableRevisionRecordTest"

2 years agoMerge "Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures"
jenkins-bot [Thu, 25 Oct 2018 21:45:32 +0000 (21:45 +0000)]
Merge "Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures"

2 years agoMerge "Move timing code out of the try/catch in doPostOutputShutdown()"
jenkins-bot [Thu, 25 Oct 2018 21:45:27 +0000 (21:45 +0000)]
Merge "Move timing code out of the try/catch in doPostOutputShutdown()"

2 years agoMerge "Silence transaction profiler master queries notices for rollback"
jenkins-bot [Thu, 25 Oct 2018 21:27:08 +0000 (21:27 +0000)]
Merge "Silence transaction profiler master queries notices for rollback"

2 years agoMerge "rdbms: remove duplicate @params in IDatabase::select()"
jenkins-bot [Thu, 25 Oct 2018 21:17:19 +0000 (21:17 +0000)]
Merge "rdbms: remove duplicate @params in IDatabase::select()"

2 years agoMerge "filerepo: Inject the WAN cache info FileRepo instances"
jenkins-bot [Thu, 25 Oct 2018 21:17:09 +0000 (21:17 +0000)]
Merge "filerepo: Inject the WAN cache info FileRepo instances"

2 years agoMerge "Remove unused fields in ForeignDBViaLBRepo"
jenkins-bot [Thu, 25 Oct 2018 21:17:04 +0000 (21:17 +0000)]
Merge "Remove unused fields in ForeignDBViaLBRepo"

2 years agoMerge "rdbms: Use "mixed" type for $profiler field in LoadBalancer"
jenkins-bot [Thu, 25 Oct 2018 21:16:59 +0000 (21:16 +0000)]
Merge "rdbms: Use "mixed" type for $profiler field in LoadBalancer"

2 years agoClear the title cache in MutableRevisionRecordTest
Aaron Schulz [Thu, 25 Oct 2018 04:31:58 +0000 (21:31 -0700)]
Clear the title cache in MutableRevisionRecordTest

Also do so in various other test classes.

Follows-up 170c49d61cb8. Fixes Travis CI regression:

> 1) MediaWiki\Tests\Revision\MutableRevisionRecordTest::testSetGetPageId
> Failed asserting that 2 is identical to 0.
> tests/phpunit/includes/Revision/MutableRevisionRecordTest.php:129

Change-Id: I41c8bda8e620ebe7608a393d81f3b0f13af68ba7

2 years agoMake testFormatValueRestrictions() account for $wgArticlePath to avoid failures
Aaron Schulz [Thu, 25 Oct 2018 03:34:41 +0000 (20:34 -0700)]
Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures

Follows-up 170c49d61cb84411.

Change-Id: I37a57b5ece939c5743b7d08d02ce41c71daee5eb

2 years agofilerepo: Inject the WAN cache info FileRepo instances
Aaron Schulz [Sun, 21 Oct 2018 12:07:44 +0000 (05:07 -0700)]
filerepo: Inject the WAN cache info FileRepo instances

Also fixed some intellij IDEA warnings.

Change-Id: I667ed7ef9b49c1da1c8c7c9914daadb7c74b3c79

2 years agordbms: Use "mixed" type for $profiler field in LoadBalancer
Aaron Schulz [Wed, 24 Oct 2018 11:05:41 +0000 (04:05 -0700)]
rdbms: Use "mixed" type for $profiler field in LoadBalancer

Change-Id: I8d110d0420a155bb62f4212933d9de2562dc7661

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 25 Oct 2018 20:16:19 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I67923401760c77676ed4e674170335333ac15d15

2 years agoMerge "Fix code style in EmailNotification.php"
jenkins-bot [Thu, 25 Oct 2018 19:30:22 +0000 (19:30 +0000)]
Merge "Fix code style in EmailNotification.php"

2 years agoFix code style in EmailNotification.php
Alangi Derick [Tue, 23 Oct 2018 13:50:51 +0000 (14:50 +0100)]
Fix code style in EmailNotification.php

Code style fix for namespace "use" statement.

Change-Id: I0755481f640aae535c8328824812e25db467e528

2 years agoMerge "MailAddress->toString(): Reduce complexity by inverting ifs"
jenkins-bot [Thu, 25 Oct 2018 17:49:09 +0000 (17:49 +0000)]
Merge "MailAddress->toString(): Reduce complexity by inverting ifs"

2 years agoMailAddress->toString(): Reduce complexity by inverting ifs
Reedy [Sat, 20 Oct 2018 22:31:00 +0000 (23:31 +0100)]
MailAddress->toString(): Reduce complexity by inverting ifs

Change-Id: I5185c0231a0944f36d960211e78cf36273c94d52

2 years agoMove timing code out of the try/catch in doPostOutputShutdown()
Aaron Schulz [Thu, 25 Oct 2018 16:22:30 +0000 (09:22 -0700)]
Move timing code out of the try/catch in doPostOutputShutdown()

Change-Id: Idc24fdaff5bbcb98445cc4dee8c94cc75cd00573

2 years agordbms: avoid transaction status errors from ping() in rollback()
Aaron Schulz [Thu, 25 Oct 2018 15:34:39 +0000 (08:34 -0700)]
rdbms: avoid transaction status errors from ping() in rollback()

Change-Id: I38658cbf90518d9818824674da371637db15e156

2 years agoMerge "WikiPage: Truncate redirect fragments before inserting them into the DB"
jenkins-bot [Thu, 25 Oct 2018 04:43:50 +0000 (04:43 +0000)]
Merge "WikiPage: Truncate redirect fragments before inserting them into the DB"

2 years agoMerge "RCFilters: Fix centering of "no results" message"
jenkins-bot [Thu, 25 Oct 2018 03:13:49 +0000 (03:13 +0000)]
Merge "RCFilters: Fix centering of "no results" message"

2 years agoRCFilters: Fix centering of "no results" message
Roan Kattouw [Thu, 25 Oct 2018 00:50:47 +0000 (17:50 -0700)]
RCFilters: Fix centering of "no results" message

Was caused by a stray margin-right rule that applied to the wrong divs,
and wasn't needed anyway.

Bug: T207808
Change-Id: Ib6cf518653fbadb0c7d67d6a175b4af92c8f8d87
Follows-Up: I76fec57ff237ba02afefcea28916d8348bac9b0e

2 years agoWikiPage: Truncate redirect fragments before inserting them into the DB
Roan Kattouw [Thu, 25 Oct 2018 00:09:59 +0000 (17:09 -0700)]
WikiPage: Truncate redirect fragments before inserting them into the DB

The rd_fragment field is 255 bytes wide, but there is no limit on how
long title fragments can be. We don't want to let the database silently
truncate the fragment for us, because that can result in invalid UTF-8.
Instead, truncate it before insertion in a UTF-8-aware way.

Bug: T207876
Change-Id: I12745f3f4c174eaced56d80f3661a71d0e5637e6

2 years agoMerge "composer.json, require ext-fileinfo"
jenkins-bot [Wed, 24 Oct 2018 23:35:56 +0000 (23:35 +0000)]
Merge "composer.json, require ext-fileinfo"

2 years agoDisable $wgEnableImageWhitelist by default
Kunal Mehta [Wed, 24 Oct 2018 22:39:53 +0000 (15:39 -0700)]
Disable $wgEnableImageWhitelist by default

This opens up a hole for administrators to load images from external resources,
potentially leaking user's private information to external servers (IP address,
User-Agent, etc.).

Change-Id: Ie780637b292493e664e4d54671a5bb81046106f4

2 years agoMerge "Use a pre-commit hook for change_tag_def count updates"
jenkins-bot [Wed, 24 Oct 2018 22:14:03 +0000 (22:14 +0000)]
Merge "Use a pre-commit hook for change_tag_def count updates"

2 years agoMerge "Hard deprecate functionality replaced with random_bytes()"
jenkins-bot [Wed, 24 Oct 2018 22:13:06 +0000 (22:13 +0000)]
Merge "Hard deprecate functionality replaced with random_bytes()"

2 years agoMerge "Hard deprecate non-tidy OutputPage::addWikiText() method"
jenkins-bot [Wed, 24 Oct 2018 22:13:00 +0000 (22:13 +0000)]
Merge "Hard deprecate non-tidy OutputPage::addWikiText() method"

2 years agoMerge "RELEASE-NOTES-1.33: Note new Partial Blocks feature flag"
jenkins-bot [Wed, 24 Oct 2018 22:09:54 +0000 (22:09 +0000)]
Merge "RELEASE-NOTES-1.33: Note new Partial Blocks feature flag"

2 years agoMerge "Use PHP 7 '??' operator instead of if-then-else"
jenkins-bot [Wed, 24 Oct 2018 21:58:04 +0000 (21:58 +0000)]
Merge "Use PHP 7 '??' operator instead of if-then-else"

2 years agocomposer.json, require ext-fileinfo
addshore [Mon, 24 Sep 2018 08:25:53 +0000 (09:25 +0100)]
composer.json, require ext-fileinfo

PHPVersionCheck requires fileinfo be installed for mime_content_type

Change-Id: Iea7d2c7842c770e77c05265d4f4b08b17f9ab71f

2 years agoMerge "Fix PHPDoc type for instance variables and methods"
jenkins-bot [Wed, 24 Oct 2018 21:17:02 +0000 (21:17 +0000)]
Merge "Fix PHPDoc type for instance variables and methods"

2 years agoUse a pre-commit hook for change_tag_def count updates
Aaron Schulz [Wed, 24 Oct 2018 21:09:41 +0000 (14:09 -0700)]
Use a pre-commit hook for change_tag_def count updates

Bug: T207881
Change-Id: I3000f14d0e49482b0c90ffcfc494211fbc198a20

2 years agoMerge "Minor cleanup of languages/ConverterRule.php"
jenkins-bot [Wed, 24 Oct 2018 20:59:58 +0000 (20:59 +0000)]
Merge "Minor cleanup of languages/ConverterRule.php"

2 years agoRELEASE-NOTES-1.33: Note new Partial Blocks feature flag
Moriel Schottlender [Wed, 24 Oct 2018 20:44:00 +0000 (13:44 -0700)]
RELEASE-NOTES-1.33: Note new Partial Blocks feature flag

Change-Id: Ibc7a3265f9c3f067e280f9f5e17a2b16b2bed69b

2 years agoMerge "Tidy Message::parseAsBlock() by enabling tidy in MessageCache"
jenkins-bot [Wed, 24 Oct 2018 20:35:06 +0000 (20:35 +0000)]
Merge "Tidy Message::parseAsBlock() by enabling tidy in MessageCache"

2 years agoMerge "extraParserTests.txt: Fix typo"
jenkins-bot [Wed, 24 Oct 2018 20:35:01 +0000 (20:35 +0000)]
Merge "extraParserTests.txt: Fix typo"

2 years agoHard deprecate non-tidy OutputPage::addWikiText() method
C. Scott Ananian [Tue, 25 Sep 2018 14:05:55 +0000 (10:05 -0400)]
Hard deprecate non-tidy OutputPage::addWikiText() method

Tidy will always be enabled with our future parsers.  Hard-deprecate
this method which doesn't tidy the output.

Users of `OutputPage::addWikiText()` will be converted one-by-one to
`OutputPage::addWikiTextAsInterface()` so that any unexpected issues
(deliberately untidy wikitext added, which should be rare) can be
addressed.

Bug: T198214
Depends-On: I778ba9e6efed576605f492c9a073c7203b6c0477
Depends-On: I16529879a3b3aed960c5dc006e2af513d7e91fcd
Change-Id: If8353c37245d9d233d589f82c198668ccb3fce05

2 years agoMerge "RELEASE-NOTES-1.32: Add all new/changed libraries in composer.json"
jenkins-bot [Wed, 24 Oct 2018 18:03:41 +0000 (18:03 +0000)]
Merge "RELEASE-NOTES-1.32: Add all new/changed libraries in composer.json"

2 years agoMerge "Remove deprecated "Parsoid v1 API" compatibility thunks"
jenkins-bot [Wed, 24 Oct 2018 17:45:34 +0000 (17:45 +0000)]
Merge "Remove deprecated "Parsoid v1 API" compatibility thunks"

2 years agoMerge "HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'"
jenkins-bot [Wed, 24 Oct 2018 17:14:34 +0000 (17:14 +0000)]
Merge "HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'"

2 years agoRemove deprecated "Parsoid v1 API" compatibility thunks
C. Scott Ananian [Tue, 25 Sep 2018 19:44:33 +0000 (15:44 -0400)]
Remove deprecated "Parsoid v1 API" compatibility thunks

These have been deprecated since MW 1.26, and were hard deprecated
in MW 1.32.

Bug: T205029
Change-Id: I387794ecceec8aec1bd01923a71673aa2ddf4282

2 years agoList Partial Block details in ApiQueryBlocks and ApiQueryUserinfo.
David Barratt [Tue, 26 Jun 2018 23:12:05 +0000 (19:12 -0400)]
List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo.

The ApiQueryBlocks and ApiQueryUserinfo endpoints will now return whether or not the block is
sitewide or partial. Partial block restrictions can be returned with ApiQueryBlocks.

Bug: T197141
Change-Id: I76eb4cac4dc989c621a00a39996faebd0eb9892c

2 years agoUpdate Special:BlockList to present Partial Block details from the database
David Barratt [Tue, 19 Jun 2018 19:57:34 +0000 (15:57 -0400)]
Update Special:BlockList to present Partial Block details from the database

The Special:BlockList page will be updated to show details from the Partial
Block within the "Block parameters" column. The format of the column will
change to make the details more readable.

Bug: T197143
Change-Id: Ibd79b049d93e427c2d541f8ef93005847482ef59

2 years agoFollow-up cfa70ea6d0: Fix rebase artefact, also remove preference listing
James D. Forrester [Wed, 24 Oct 2018 14:58:47 +0000 (07:58 -0700)]
Follow-up cfa70ea6d0: Fix rebase artefact, also remove preference listing

Change-Id: Ia146f013beba2c82a8f76355b49a4192fbd0ed3b

2 years agoMinor cleanup of languages/ConverterRule.php
Alangi Derick [Tue, 23 Oct 2018 13:38:42 +0000 (14:38 +0100)]
Minor cleanup of languages/ConverterRule.php

Remove extra space before comma and fix
minor issues with line comments.

Change-Id: I0306fe172eaa29ab504394f0a80b8652089a809c

2 years agoSilence transaction profiler master queries notices for rollback
Aaron Schulz [Wed, 24 Oct 2018 09:48:14 +0000 (02:48 -0700)]
Silence transaction profiler master queries notices for rollback

Change-Id: I53f0149cbf69ee2e57fe556668dd6cbfadd79823

2 years agoMerge "Remove old "bulletin board style toolbar" from core"
jenkins-bot [Wed, 24 Oct 2018 05:30:14 +0000 (05:30 +0000)]
Merge "Remove old "bulletin board style toolbar" from core"

2 years agoMerge "Enforce partial blocks"
jenkins-bot [Wed, 24 Oct 2018 03:15:39 +0000 (03:15 +0000)]
Merge "Enforce partial blocks"

2 years agoMerge "Add partial block details to block-log entries."
jenkins-bot [Wed, 24 Oct 2018 01:45:25 +0000 (01:45 +0000)]
Merge "Add partial block details to block-log entries."

2 years agoMerge "Update Special:Block to set Partial Blocks"
jenkins-bot [Wed, 24 Oct 2018 01:45:18 +0000 (01:45 +0000)]
Merge "Update Special:Block to set Partial Blocks"

2 years agoMerge "TitlesMultiselectWidget: Add a widget that allows selection of multiple titles"
jenkins-bot [Wed, 24 Oct 2018 01:35:54 +0000 (01:35 +0000)]
Merge "TitlesMultiselectWidget: Add a widget that allows selection of multiple titles"

2 years agoMerge "Add block restriction classes"
jenkins-bot [Wed, 24 Oct 2018 01:28:36 +0000 (01:28 +0000)]
Merge "Add block restriction classes"

2 years agoEnforce partial blocks
Dayllan Maza [Mon, 27 Aug 2018 01:45:18 +0000 (21:45 -0400)]
Enforce partial blocks

Enforce partial blocks and display a slightly different block
notice depending on if the block is sitewide or not

Bug: T197117
Depends-On: I675316dddf272fd0d6172ecad3882160752bf780
Change-Id: I8a3635a4a04a33912eb139b7b13c4bd874183d31

2 years agoFix slow query counting by unindexed field ar_page_id
Tim Starling [Wed, 24 Oct 2018 00:21:28 +0000 (17:21 -0700)]
Fix slow query counting by unindexed field ar_page_id

Bug: T207530
Change-Id: I81a70ca03fd219d2e96b17714645d9cc4f99b3b9

2 years agoAdd partial block details to block-log entries.
Dayllan Maza [Wed, 19 Sep 2018 05:51:49 +0000 (01:51 -0400)]
Add partial block details to block-log entries.

Block information needs to be more detailed if a block is not
sitewide. With this change, page restrictions will be visible
as part of the block information in Special:Contributions,
Special:Block, and Special:Log and via API

Bug: T197108
Change-Id: I5d2ef606f709bdd60bf52e2a048890b0f6360fca

3 years agoUpdate Special:Block to set Partial Blocks
David Barratt [Mon, 27 Aug 2018 22:19:37 +0000 (18:19 -0400)]
Update Special:Block to set Partial Blocks

Make the necessary UI changes to Special:Block in order to set/update
partial blocks.

Bug: T197109
Change-Id: Ib3067824b5dcbdd893ab1f165d169a35d0716cb2

3 years agoTitlesMultiselectWidget: Add a widget that allows selection of multiple titles
Moriel Schottlender [Thu, 30 Aug 2018 00:33:32 +0000 (17:33 -0700)]
TitlesMultiselectWidget: Add a widget that allows selection of multiple titles

Add the widget in both PHP and JS for OOUI, and into HTMLForm
definitions.

In JS, the widget uses the engine from mw.widgets.TitleWidget
with the async support from OO.ui.mixin.RequestManager.

The PHP version provides a textarea, like UsersMultiselectWidget.php
which is then infused if JS is available.

Also, add highlightSearchQuery option for TitleWidget to allow for
not highlighting the partial search query the user typed in, if the
UI requires it. This option (highlighting partial result) is already
optional in the TitleOptionWidget, so this config exposes that
optionality in the TitleWidget widget for its menu children.

Notes:

HTMLTitlesMultiselectField is a duplication of HTMLUsersMultiselectField
except for:
- The configuration variable changed to 'titles' (from 'users')
- OOUI modules were adjusted for the TitlesMultiselectWidget
- The PHP version instantiates a MediaWiki\Widget\TitlesMultiselectWidget

TitlesMultiselectWidget is a duplication of UsersMultiselectWidget
except for:
- $usersArray was renamed to $titlesArray
- getJavascriptClassName returns the correct js class for
  mw.widgets.TitlesMultiselectWidget for infusion.

Bug: T197109
Depends-On: I675316dddf272fd0d6172ecad3882160752bf780
Change-Id: Ie96947a35f70b76731e16ae5b85de815dfa4a8ce

3 years agoAdd block restriction classes
Dayllan Maza [Thu, 16 Aug 2018 04:55:55 +0000 (00:55 -0400)]
Add block restriction classes

Partial blocks logic will be used in multiple places. This
classes will group block restriction functionality to avoid
code duplication

Bug: T202036
Change-Id: I675316dddf272fd0d6172ecad3882160752bf780

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 23 Oct 2018 19:53:55 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If085dbc6560e9580ac86ddb42a4f730d47f1e605

3 years agoRELEASE-NOTES-1.32: Add all new/changed libraries in composer.json
James D. Forrester [Tue, 23 Oct 2018 17:56:52 +0000 (10:56 -0700)]
RELEASE-NOTES-1.32: Add all new/changed libraries in composer.json

Change-Id: I50b47470b531b04642913b36dc7b4282476df6db

3 years agoMerge "Remove fixed phpcs:ignore"
jenkins-bot [Tue, 23 Oct 2018 18:54:35 +0000 (18:54 +0000)]
Merge "Remove fixed phpcs:ignore"

3 years agoRemove fixed phpcs:ignore
Umherirrender [Tue, 23 Oct 2018 18:35:00 +0000 (20:35 +0200)]
Remove fixed phpcs:ignore

Follow-Up: I418345870e25fa37df0195ddc74193b54fe6d2a5
Change-Id: I0b3a546455c2f35d3aeadbdd31a07bdb1958a74c

3 years agoRELEASE-NOTES-1.32: Add all new/changed libraries in resources/lib
James D. Forrester [Tue, 23 Oct 2018 17:52:51 +0000 (10:52 -0700)]
RELEASE-NOTES-1.32: Add all new/changed libraries in resources/lib

Change-Id: I1dffba3bb31850e1a2f1529c49329ba7c9c7d4a7

3 years agofix stubs dump query to use straight join
Ariel T. Glenn [Tue, 23 Oct 2018 15:18:47 +0000 (18:18 +0300)]
fix stubs dump query to use straight join

regression from a combination of
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/380669/
and
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/459885/

We have to do a straight join for all stubs, since they all
now order revisions by rev_id after deployment of the second
patchset above.

Bug: T207628
Change-Id: I4d2a311c14c66d4813eb9fc3c587fa3ddb958454

3 years agoMerge "Fix warnings in SpecialEmailuser"
jenkins-bot [Tue, 23 Oct 2018 05:38:22 +0000 (05:38 +0000)]
Merge "Fix warnings in SpecialEmailuser"

3 years agordbms: remove duplicate @params in IDatabase::select()
Aaron Schulz [Tue, 23 Oct 2018 04:06:34 +0000 (21:06 -0700)]
rdbms: remove duplicate @params in IDatabase::select()

Change-Id: I1b374cabb00d934d9203229c82a93197f03e9b05

3 years agoMerge "Make Language::hasVariant() more strict"
jenkins-bot [Mon, 22 Oct 2018 21:50:06 +0000 (21:50 +0000)]
Merge "Make Language::hasVariant() more strict"

3 years agoMake Language::hasVariant() more strict
C. Scott Ananian [Fri, 19 Oct 2018 19:00:52 +0000 (15:00 -0400)]
Make Language::hasVariant() more strict

In d59f27aeab08b171e5ab6a081e763a4cad0bca04 we made
LanguageConverter::validateVariant() try harder to convert a variant
into an acceptable MediaWiki-internal form, looking at deprecated
codes and BCP 47 aliases.  However, this misled Language::hasVariant()
into thinking that bogus names (like all-uppercase strings) were
acceptable variant names, which then led exceptions when they were
passed to the various conversion methods.

This is a belt-and-suspenders patch for T207433 -- in that case we
shouldn't have created a Language object with code 'sr-cyrl' in the
first place, but once one was created we shouldn't have tried to
ask LanguageSr to convert texts to 'sr-cyrl'.  The latter problem
is fixed by this patch.

Bug: T207433
Change-Id: Id993bc7989144b5031a551662e8e492bd23f698a

3 years agoFix warnings in SpecialEmailuser
Amir Sarabadani [Mon, 22 Oct 2018 19:59:35 +0000 (21:59 +0200)]
Fix warnings in SpecialEmailuser

Change-Id: I527f8891f3821e0e8a4c65db97fdbe8ba5dd3e76

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 22 Oct 2018 19:53:57 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id5f41040e7924ee2a377f5bb47999ff8a5987831

3 years agoMerge "Remove UtfNormal class"
jenkins-bot [Mon, 22 Oct 2018 19:43:21 +0000 (19:43 +0000)]
Merge "Remove UtfNormal class"

3 years agoMerge "Hard-deprecate LegacyHookPreAuthenticationProvider class"
jenkins-bot [Mon, 22 Oct 2018 19:33:56 +0000 (19:33 +0000)]
Merge "Hard-deprecate LegacyHookPreAuthenticationProvider class"

3 years agoHTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'
Bartosz Dziewoński [Fri, 17 Aug 2018 21:07:52 +0000 (23:07 +0200)]
HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'

Bug: T197179
Change-Id: I911cabc1e1e1c2abb8e91a55c05eaa1c76134087

3 years agoRemove UtfNormal class
Reedy [Thu, 31 May 2018 23:37:07 +0000 (00:37 +0100)]
Remove UtfNormal class

Change-Id: I1cab16d95ed888b482d23f73577c988700e0bca4

3 years agoHard-deprecate LegacyHookPreAuthenticationProvider class
Gergő Tisza [Wed, 10 Oct 2018 01:21:54 +0000 (18:21 -0700)]
Hard-deprecate LegacyHookPreAuthenticationProvider class

The hooks that used to be called by this class will be removed in
I24d6fa963. The only reason to keep this class around is that
someone might have added it to $wgAuthManagerConfig so removing
it would trigger class lookup failures, so make sure any use
of the class triggers a deprecation warning.

Change-Id: I9755288eda7461ecf3dcd35de2081fbb3eb04ae3

3 years agoUpdate wikimedia/base-convert to 2.0.0
Kunal Mehta [Mon, 22 Oct 2018 18:17:40 +0000 (11:17 -0700)]
Update wikimedia/base-convert to 2.0.0

The breaking change is dropping PHP 5 support.

Bug: T194052
Depends-On: I4de5c0ab827c96e2cef4e0b2cd7d10a109393668
Change-Id: If39ea5274bfa3c9b0ce18f9a43a27445a90ea3fc

3 years agoMerge "Remove untidy wrapper from ImagePage::makeMetadataTable()"
jenkins-bot [Mon, 22 Oct 2018 17:39:12 +0000 (17:39 +0000)]
Merge "Remove untidy wrapper from ImagePage::makeMetadataTable()"

3 years agoMerge "Fix bad join on ChangeTag subquery"
jenkins-bot [Mon, 22 Oct 2018 17:38:02 +0000 (17:38 +0000)]
Merge "Fix bad join on ChangeTag subquery"

3 years agoMerge "Include BCP 47 codes in $wgDummyLanguageCodes, but deprecate it"
jenkins-bot [Mon, 22 Oct 2018 17:13:50 +0000 (17:13 +0000)]
Merge "Include BCP 47 codes in $wgDummyLanguageCodes, but deprecate it"

3 years agoMerge "Deprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode"
jenkins-bot [Mon, 22 Oct 2018 17:08:50 +0000 (17:08 +0000)]
Merge "Deprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode"

3 years agoMerge "Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy"
jenkins-bot [Mon, 22 Oct 2018 16:47:47 +0000 (16:47 +0000)]
Merge "Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy"

3 years agoRemove untidy wrapper from ImagePage::makeMetadataTable()
C. Scott Ananian [Wed, 17 Oct 2018 14:47:35 +0000 (10:47 -0400)]
Remove untidy wrapper from ImagePage::makeMetadataTable()

Replace a fragile <div> wrapper with the robust
OutputPage::wrapWikiTextAsInterface() wrapper.

Bug: T205624
Change-Id: I0a1ba0da6af97f0233afdd8ba7202abed0998419

3 years agoMerge "Remove Language::truncate(), deprecated in MW 1.31"
jenkins-bot [Mon, 22 Oct 2018 16:33:57 +0000 (16:33 +0000)]
Merge "Remove Language::truncate(), deprecated in MW 1.31"

3 years agoFollow-up T174035: Wrap inline ternary in brackets to make phpcs happy
James D. Forrester [Mon, 22 Oct 2018 16:23:22 +0000 (09:23 -0700)]
Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy

Bug: T203805
Change-Id: I418345870e25fa37df0195ddc74193b54fe6d2a5

3 years agoMerge "Rename WebInstallerOutput::addWikiTextInterface"
jenkins-bot [Mon, 22 Oct 2018 15:48:46 +0000 (15:48 +0000)]
Merge "Rename WebInstallerOutput::addWikiTextInterface"

3 years agoMerge "Fix comment handling on image upload or deletion"
jenkins-bot [Mon, 22 Oct 2018 15:08:42 +0000 (15:08 +0000)]
Merge "Fix comment handling on image upload or deletion"

3 years agoFix bad join on ChangeTag subquery
Amir Sarabadani [Mon, 22 Oct 2018 13:53:29 +0000 (15:53 +0200)]
Fix bad join on ChangeTag subquery

Bug: T207313
Change-Id: Iae6440630a533dfbcee3ccec34a9f231d3d013b5

3 years agoMerge "Replace http://be-x-old. by https://be-tarask."
jenkins-bot [Mon, 22 Oct 2018 10:19:12 +0000 (10:19 +0000)]
Merge "Replace be-x-old. by https://be-tarask."

3 years agoRename WebInstallerOutput::addWikiTextInterface
C. Scott Ananian [Mon, 22 Oct 2018 03:00:14 +0000 (23:00 -0400)]
Rename WebInstallerOutput::addWikiTextInterface

Follow up to I89f3398cffa771afcd5a33cfd11eb8510af3e7f7: this patch
was intended to mirror a new method added to OutputPage in
Ia58910164baaca608cea3b24333b7d13ed773339 but the bikeshed was painted
a slightly different color before the OutputPage patch was merged, and
somehow this patch wasn't changed to match.  The `addWikiTextInterface`
name was never included in a released MW version, so we don't need to
deprecate it, just fix it.

Change-Id: I636cb0ea0f9631c4c5e2bc118f479aec76d2b231

3 years agoMerge "Use OutputPage::wrapWikiTextAsInterface() to add safe <div> wrappers"
jenkins-bot [Mon, 22 Oct 2018 02:00:35 +0000 (02:00 +0000)]
Merge "Use OutputPage::wrapWikiTextAsInterface() to add safe <div> wrappers"

3 years agoDeprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode
C. Scott Ananian [Fri, 19 Oct 2018 15:06:15 +0000 (11:06 -0400)]
Deprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode

These were introduced in MW 1.17 and are always true in production.

They were useful to allow folks to defer title conversion, but it's
been a long time now.  We don't need to make this optional any more.

Change-Id: I65dcfe80dc3e1dfeb4d63924a8928655e012a20c

3 years agoMerge "Use OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()"
jenkins-bot [Mon, 22 Oct 2018 01:49:58 +0000 (01:49 +0000)]
Merge "Use OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()"