lhc/web/wiklou.git
4 years agoUpdate RemexHtml to 1.0.1
Tim Starling [Thu, 23 Mar 2017 01:47:38 +0000 (12:47 +1100)]
Update RemexHtml to 1.0.1

For a bug fix

Depends-On: I4421afbfa52d7711d9369398891e91ae09db50c9
Change-Id: I5285c0b1c6f42891c002637cd3e4bd2f54615940

4 years agoMerge "Allow extensions to add jQueryMsg magic words"
jenkins-bot [Wed, 22 Mar 2017 21:18:19 +0000 (21:18 +0000)]
Merge "Allow extensions to add jQueryMsg magic words"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 22 Mar 2017 21:02:54 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I83074d7d6edd5cf2e3b69d0bb2382012a5b4e438

4 years agoMerge "RCFilters UI: Make the 'no results' message bold"
jenkins-bot [Wed, 22 Mar 2017 19:30:35 +0000 (19:30 +0000)]
Merge "RCFilters UI: Make the 'no results' message bold"

4 years agoMerge "RCFilters: Normalize overlay font-size for Monobook"
jenkins-bot [Wed, 22 Mar 2017 19:28:29 +0000 (19:28 +0000)]
Merge "RCFilters: Normalize overlay font-size for Monobook"

4 years agoAllow extensions to add jQueryMsg magic words
Matthew Flaschen [Wed, 22 Mar 2017 06:09:48 +0000 (02:09 -0400)]
Allow extensions to add jQueryMsg magic words

Change-Id: Ie82a147ff32ccda3f757108474f5cbab71d45ace

4 years agoMerge "Stop declaring ImageHistoryPseudoPager props dynamically"
jenkins-bot [Wed, 22 Mar 2017 16:32:01 +0000 (16:32 +0000)]
Merge "Stop declaring ImageHistoryPseudoPager props dynamically"

4 years agoStop declaring ImageHistoryPseudoPager props dynamically
addshore [Wed, 22 Mar 2017 12:21:24 +0000 (12:21 +0000)]
Stop declaring ImageHistoryPseudoPager props dynamically

The 3 properties declared here were introduced in:
0ca92d0bf5dd4e71b678d373a1beb3089d16a866

Change-Id: Ibbd0a86f02ab010720446db1aa2dc9ea0eb05aef

4 years agoMerge "Fix log msg param in UploadFromUrl::saveTempFileChunk"
jenkins-bot [Wed, 22 Mar 2017 14:46:45 +0000 (14:46 +0000)]
Merge "Fix log msg param in UploadFromUrl::saveTempFileChunk"

4 years agoMerge "Mark public methods as public in ImageHistoryPseudoPager"
jenkins-bot [Wed, 22 Mar 2017 14:43:55 +0000 (14:43 +0000)]
Merge "Mark public methods as public in ImageHistoryPseudoPager"

4 years agoMerge "Bugzilla -> Phab task number in $wgUrlProtocols phpdoc"
jenkins-bot [Wed, 22 Mar 2017 14:40:37 +0000 (14:40 +0000)]
Merge "Bugzilla -> Phab task number in $wgUrlProtocols phpdoc"

4 years agoMerge "Fix undefined ExternalStore::decompressRevisionText"
jenkins-bot [Wed, 22 Mar 2017 13:17:46 +0000 (13:17 +0000)]
Merge "Fix undefined ExternalStore::decompressRevisionText"

4 years agoCheck for string initialization in ucfirst() to make HHVM 3.18 happy
Andre Klapper [Wed, 22 Mar 2017 12:16:19 +0000 (13:16 +0100)]
Check for string initialization in ucfirst() to make HHVM 3.18 happy

Bug: T161095
Change-Id: I45b5d9e819061f443d4342c004bad80bd87c2a17

4 years agoMark public methods as public in ImageHistoryPseudoPager
addshore [Wed, 22 Mar 2017 12:16:00 +0000 (12:16 +0000)]
Mark public methods as public in ImageHistoryPseudoPager

Change-Id: Iad4442d87df683daca978fa95068f9ca5221d8a5

4 years agoFix undefined ExternalStore::decompressRevisionText
Paladox [Wed, 22 Mar 2017 11:16:11 +0000 (11:16 +0000)]
Fix undefined ExternalStore::decompressRevisionText

make ExternalStore::decompressRevisionText self::decompressRevisionText

Change-Id: I3dc7317550f47e7e94d1403d3861d1059c7af6c9

4 years agoFix log msg param in UploadFromUrl::saveTempFileChunk
addshore [Wed, 22 Mar 2017 10:39:46 +0000 (10:39 +0000)]
Fix log msg param in UploadFromUrl::saveTempFileChunk

$this->nbytes does not exist and is never written to.
It is probably intended that this uses the local $nbytes.

Change-Id: I8e923a27625d04c81b2e272a597d40d59397851f

4 years agoBugzilla -> Phab task number in $wgUrlProtocols phpdoc
addshore [Wed, 22 Mar 2017 10:02:55 +0000 (10:02 +0000)]
Bugzilla -> Phab task number in $wgUrlProtocols phpdoc

Change-Id: I1478ece1691d0b86aeae272dd041425eac4ed960

4 years agoMerge "Make Revision::getRevisionText() cache the converted text"
jenkins-bot [Wed, 22 Mar 2017 04:38:21 +0000 (04:38 +0000)]
Merge "Make Revision::getRevisionText() cache the converted text"

4 years agoMake Revision::getRevisionText() cache the converted text
Aaron Schulz [Wed, 22 Mar 2017 04:20:40 +0000 (21:20 -0700)]
Make Revision::getRevisionText() cache the converted text

Follows-up c2bbb51c2082.

This makes it consistent with Revision::loadText() to avoid polluting
the text cache values.

Bug: T161037
Change-Id: If2bd114870c7f7db0e56d4e8092a5dd722d3bde5

4 years agoMerge "resourceloader: Follow redirects for JavaScript/CSS in WikiModule"
jenkins-bot [Wed, 22 Mar 2017 03:59:40 +0000 (03:59 +0000)]
Merge "resourceloader: Follow redirects for JavaScript/CSS in WikiModule"

4 years agoMerge "Cast to bool in Database::update"
jenkins-bot [Wed, 22 Mar 2017 02:22:11 +0000 (02:22 +0000)]
Merge "Cast to bool in Database::update"

4 years agoMerge "RCFilters: Add conflicts for minor edits"
jenkins-bot [Wed, 22 Mar 2017 02:16:07 +0000 (02:16 +0000)]
Merge "RCFilters: Add conflicts for minor edits"

4 years agoRCFilters: Add conflicts for minor edits
Moriel Schottlender [Mon, 20 Mar 2017 23:26:15 +0000 (16:26 -0700)]
RCFilters: Add conflicts for minor edits

Bug: T160803
Change-Id: I91d736d772e36f54144330c30092fac85dc70d20

4 years agoDeprecate WikiRevision::$user
addshore [Thu, 16 Mar 2017 10:30:11 +0000 (10:30 +0000)]
Deprecate WikiRevision::$user

This was introduced in 436a028086fb3f01c4605c5ad2964d56f9306aca
but was not used there.
It also currently looks unused.

We could go ahead and just remove this now, as anything that wants
to set the $user when the property is removed would still succeed.
But lets adhere to the deprecation policy here.

Change-Id: Id47323bb1ff480a16b46107825ed5f2f861ad976

4 years agoDeprecate WikiRevision::$importer
addshore [Thu, 16 Mar 2017 10:18:59 +0000 (10:18 +0000)]
Deprecate WikiRevision::$importer

This was introduced in 9b3128eb2b654761f21fd4ca1d5a1a4b796dc912
but was not used there.
It also currently looks unused, even when grepping for possible
magic usages of 'importer' and "importer".

We could go ahead and just remove this now, as anything that wants
to set the $importer when the property is removed would still succeed.
But lets adhere to the deprecation policy here.

Change-Id: I5ac16dd87a95be6a3cdd4b16988d37d1d6104749

4 years agoDeprecate WikiRevision::$fileIsTemp and fix $isTemp
addshore [Thu, 16 Mar 2017 10:09:03 +0000 (10:09 +0000)]
Deprecate WikiRevision::$fileIsTemp and fix $isTemp

Cleanup from 43d5d3b682cc1733ad01a837d11af4a402d57e6a

This commit introduces both $fileIsTemp $isTemp
It would appear that the intent was to have one property here
and it looks like both of these are meant to do the same thing.

It also looks as if both public properties are actually unused
(only used by the getter and setters)

As isTemp will now sometimes return true line 766 $autoDeleteSource
will be true in new cases.
As a result $tmpFile->autocollect(); will be called in more cases

Change-Id: I8014172fb9fd7a0e4a89d0872bafdf6c50f92646

4 years agoRCFilters: Normalize overlay font-size for Monobook
Moriel Schottlender [Tue, 21 Mar 2017 22:05:53 +0000 (15:05 -0700)]
RCFilters: Normalize overlay font-size for Monobook

Bug: T161033
Change-Id: Ia2215046f6d3fd026ecd1b27625cb94e806ababf

4 years agoCast to bool in Database::update
addshore [Tue, 21 Mar 2017 22:37:30 +0000 (22:37 +0000)]
Cast to bool in Database::update

The interface is documented as returning a bool, so stick to that
interface.

Bug: T160956
Change-Id: I725651e1d66fdd6c52ef82e93fd9e3c837edb022

4 years agoRCFilters UI: Make the 'no results' message bold
Moriel Schottlender [Tue, 21 Mar 2017 21:49:35 +0000 (14:49 -0700)]
RCFilters UI: Make the 'no results' message bold

Bug: T160935
Change-Id: I237c81abfbd50e910e428cc495e38f3d364500e0

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 21 Mar 2017 21:01:20 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iecc7b545f9858bef1789765e5abf010802638fd1

4 years agoMerge "Update OOjs UI to v0.20.0"
jenkins-bot [Tue, 21 Mar 2017 20:02:30 +0000 (20:02 +0000)]
Merge "Update OOjs UI to v0.20.0"

4 years agoMerge "maintenance: Fix broken url in comment for createCommonPasswordCdb.php"
jenkins-bot [Tue, 21 Mar 2017 08:18:57 +0000 (08:18 +0000)]
Merge "maintenance: Fix broken url in comment for createCommonPasswordCdb.php"

4 years agoMerge "Remove erroneous space in unset() call"
jenkins-bot [Tue, 21 Mar 2017 02:32:39 +0000 (02:32 +0000)]
Merge "Remove erroneous space in unset() call"

4 years agoMerge "SpecialRecentchanges: Unbreak $wgAllowCategorizedRecentChanges"
jenkins-bot [Tue, 21 Mar 2017 02:16:32 +0000 (02:16 +0000)]
Merge "SpecialRecentchanges: Unbreak $wgAllowCategorizedRecentChanges"

4 years agoMerge "User::getRights phpdoc from return array to string[]"
jenkins-bot [Tue, 21 Mar 2017 02:16:29 +0000 (02:16 +0000)]
Merge "User::getRights phpdoc from return array to string[]"

4 years agoRemove erroneous space in unset() call
Reedy [Tue, 21 Mar 2017 02:06:33 +0000 (02:06 +0000)]
Remove erroneous space in unset() call

Change-Id: I67cac037aa1db46ef60ae0c321c1394d9a3bd410

4 years agoRCFilters UI: Don't set reset button title in "restore" mode
Roan Kattouw [Mon, 20 Mar 2017 23:26:14 +0000 (16:26 -0700)]
RCFilters UI: Don't set reset button title in "restore" mode

In "clear" mode, the button only has an icon, so it needs a title.
In "restore" mode, the button has text, so it doesn't need a title,
much less a wrong one (the one from the "clear" mode).

Bonus: Remove properties from constructor that are already
set in reevaluateResetRestoreState().

Change-Id: Idab5731f51b42455801a505475002adf8437c66e

4 years agoMerge "Remove the localStorage replication of the block cookie"
jenkins-bot [Mon, 20 Mar 2017 23:16:31 +0000 (23:16 +0000)]
Merge "Remove the localStorage replication of the block cookie"

4 years agomaintenance: Fix broken url in comment for createCommonPasswordCdb.php
Timo Tijhof [Sat, 18 Mar 2017 01:12:32 +0000 (18:12 -0700)]
maintenance: Fix broken url in comment for createCommonPasswordCdb.php

Follows-up 2d15dcfc3f4b.

Use a permalink instead. The files have changed since.

Change-Id: I52882f29bb1d0fc791e8a43452c329344188fa53

4 years agoXml: Add test for listDropDown and remove unused getArrayFromWikiTextList
Timo Tijhof [Sat, 18 Mar 2017 01:25:12 +0000 (18:25 -0700)]
Xml: Add test for listDropDown and remove unused getArrayFromWikiTextList

Follows-up 4b49705613 and 8c7095be85 (T34950).

Change-Id: I95b7f7ce03b2cbe68215a7ff17afc1997a54f9b1

4 years agophpunit: Fix RecentChangeTest failure when coverage is enabled
Timo Tijhof [Mon, 20 Mar 2017 21:55:22 +0000 (14:55 -0700)]
phpunit: Fix RecentChangeTest failure when coverage is enabled

From <https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/>

2) RecentChangeTest::testIsInRCLifespan with data set #0 (6000, 1490019080, 0, true)
   Failed asserting that false matches expected true.

3) RecentChangeTest::testIsInRCLifespan with data set #3 (3000, 1490016080, 6000, true)
   Failed asserting that false matches expected true.

Change-Id: I309bb229542f3af62e3e83025d88e77ecb55cd31

4 years agoMerge "Revert "RCFilters: Change reset button title when it changes state""
jenkins-bot [Mon, 20 Mar 2017 22:00:30 +0000 (22:00 +0000)]
Merge "Revert "RCFilters: Change reset button title when it changes state""

4 years agoMerge "Track usage of highlight feature"
jenkins-bot [Mon, 20 Mar 2017 21:48:35 +0000 (21:48 +0000)]
Merge "Track usage of highlight feature"

4 years agoRevert "RCFilters: Change reset button title when it changes state"
Catrope [Mon, 20 Mar 2017 21:43:32 +0000 (21:43 +0000)]
Revert "RCFilters: Change reset button title when it changes state"

It makes no sense to add a tooltip to a button that already
has text, especially if the tooltip text is (almost)
the same as the button text.

This reverts commit 31047fb1bf03944158fe4f7da99686e7955a3b5c.

Change-Id: I2f9c819a85fc05f37c7c0c5acf2d72319bdb0d76

4 years agoMerge "mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget"
jenkins-bot [Mon, 20 Mar 2017 21:35:43 +0000 (21:35 +0000)]
Merge "mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget"

4 years agoMerge "Adjust message history-fieldset-title"
jenkins-bot [Mon, 20 Mar 2017 21:18:58 +0000 (21:18 +0000)]
Merge "Adjust message history-fieldset-title"

4 years agoMerge "RCFilters: Scroll popup up to top when it is reopened"
jenkins-bot [Mon, 20 Mar 2017 21:00:12 +0000 (21:00 +0000)]
Merge "RCFilters: Scroll popup up to top when it is reopened"

4 years agoMerge "Disable filter by redirect Special:AllPages and query=allpages in miser mode"
jenkins-bot [Mon, 20 Mar 2017 20:03:37 +0000 (20:03 +0000)]
Merge "Disable filter by redirect Special:AllPages and query=allpages in miser mode"

4 years agoMerge "RecentChanges: Correct 'no matches found' message"
jenkins-bot [Mon, 20 Mar 2017 19:55:26 +0000 (19:55 +0000)]
Merge "RecentChanges: Correct 'no matches found' message"

4 years agoMerge "RCFilters: Change reset button title when it changes state"
jenkins-bot [Mon, 20 Mar 2017 19:50:54 +0000 (19:50 +0000)]
Merge "RCFilters: Change reset button title when it changes state"

4 years agoMerge "Use executeOpHandlesInternal() in SwiftFileBackend"
jenkins-bot [Mon, 20 Mar 2017 19:36:53 +0000 (19:36 +0000)]
Merge "Use executeOpHandlesInternal() in SwiftFileBackend"

4 years agoDisable filter by redirect Special:AllPages and query=allpages in miser mode
Reedy [Mon, 20 Mar 2017 17:54:40 +0000 (17:54 +0000)]
Disable filter by redirect Special:AllPages and query=allpages in miser mode

Bug: T160916
Change-Id: Ib9562b404731e1f621b9f07c33821d04cd2aa6ae

4 years agoRCFilters: Scroll popup up to top when it is reopened
Moriel Schottlender [Mon, 20 Mar 2017 19:12:15 +0000 (12:12 -0700)]
RCFilters: Scroll popup up to top when it is reopened

Change-Id: I0cad078f2d6b3062189ca3aca0085e346667d1bf

4 years agoRecentChanges: Correct 'no matches found' message
Moriel Schottlender [Mon, 20 Mar 2017 18:57:42 +0000 (11:57 -0700)]
RecentChanges: Correct 'no matches found' message

Change-Id: Ic490fae5f3d7c474f368e981bfe9572108cf07e7

4 years agoRCFilters: Change reset button title when it changes state
Moriel Schottlender [Mon, 20 Mar 2017 18:21:16 +0000 (11:21 -0700)]
RCFilters: Change reset button title when it changes state

The button changes state between 'restore default filters' and
the trash icon which is to remove all selected filters.

The title for the button should also change accordingly.

Change-Id: I9070f0c4959f5c7c97d57d943103ae2baf89d6d2

4 years agoUse executeOpHandlesInternal() in SwiftFileBackend
Aaron Schulz [Mon, 13 Mar 2017 21:26:56 +0000 (14:26 -0700)]
Use executeOpHandlesInternal() in SwiftFileBackend

Instead calling doExecuteOpHandlesInternal() directly, use the
wrapper parent class method instead so that closeResources() is
called on all of the handles.

Change-Id: Iab0d4f7c08d155639a44f48147b78283059a6d24

4 years agomediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget
Timo Tijhof [Sat, 18 Mar 2017 00:04:12 +0000 (17:04 -0700)]
mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget

Redundant with CSS 'text-overflow: ellipsis', which is already applied.

Aside from ellipsis overflow, autoEllipsis() was also serving as indirect
caller of `highlightText( option.matchText )` and `attr('title')`,
which we want to keep, so leave that in its place.

Bug: T160804
Change-Id: I550183750d66d769cc9c960150a2349d1b9181aa

4 years agoUser::getRights phpdoc from return array to string[]
addshore [Mon, 20 Mar 2017 17:38:39 +0000 (17:38 +0000)]
User::getRights phpdoc from return array to string[]

Change-Id: I188ed3d427f53ff773235d35ef277de0a3221777

4 years agoMerge "Selenium tests in Node.js using WebdriverIO"
jenkins-bot [Mon, 20 Mar 2017 17:05:58 +0000 (17:05 +0000)]
Merge "Selenium tests in Node.js using WebdriverIO"

4 years agoAdjust message history-fieldset-title
Umherirrender [Mon, 20 Mar 2017 15:55:58 +0000 (16:55 +0100)]
Adjust message history-fieldset-title

"Browse" could assume to browse the old wikitext of this page. Changed
it to "Search" similar to message sp-contributions-search, which is used
on Special:Contributions for a similar fieldset

Change-Id: I87b17d352999536c29df898c5822f61016bd7873

4 years agoMerge "RCFilters UI: Followup Ic97c7c6aae7: Only add state message if item is selected"
jenkins-bot [Mon, 20 Mar 2017 15:02:27 +0000 (15:02 +0000)]
Merge "RCFilters UI: Followup Ic97c7c6aae7: Only add state message if item is selected"

4 years agoSpecialRecentchanges: Unbreak $wgAllowCategorizedRecentChanges
Bartosz Dziewoński [Mon, 20 Mar 2017 14:26:47 +0000 (15:26 +0100)]
SpecialRecentchanges: Unbreak $wgAllowCategorizedRecentChanges

Bug: T85742
Change-Id: I8709af6031d1cb2d1b6d25eb250c1fce150514e7

4 years agoTrack usage of highlight feature
Stephane Bisson [Mon, 20 Mar 2017 10:54:35 +0000 (06:54 -0400)]
Track usage of highlight feature

Bug: T158344
Change-Id: I9a0c5e40b813e075ec33eea882b625dc43a15df6

4 years agoMerge "Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()"
jenkins-bot [Mon, 20 Mar 2017 09:32:47 +0000 (09:32 +0000)]
Merge "Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()"

4 years agoMerge "Avoid database connection in SpecialSearchTest data provider"
jenkins-bot [Mon, 20 Mar 2017 07:32:56 +0000 (07:32 +0000)]
Merge "Avoid database connection in SpecialSearchTest data provider"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 19 Mar 2017 20:53:59 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I8909bf70bc12c12dd42e318e70987b0597760b67

4 years agoMerge "Remove deprecated noop functions"
jenkins-bot [Sun, 19 Mar 2017 09:30:53 +0000 (09:30 +0000)]
Merge "Remove deprecated noop functions"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 18 Mar 2017 21:03:51 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I525052178b2be3c22e4016cea54d96ea6e687a87

4 years agoAvoid database connection in SpecialSearchTest data provider
aude [Sat, 18 Mar 2017 19:42:09 +0000 (15:42 -0400)]
Avoid database connection in SpecialSearchTest data provider

SearchResult::newFromTitle involves database connnection,
thus better to avoid calling this in the data provider.

Change-Id: I891e97cf18ca1dd44abefe01731dfc5da51f1982

4 years agoRCFilters UI: Followup Ic97c7c6aae7: Only add state message if item is selected
Moriel Schottlender [Sat, 18 Mar 2017 18:39:36 +0000 (11:39 -0700)]
RCFilters UI: Followup Ic97c7c6aae7: Only add state message if item is selected

Unselected items are highlighted, and hence are not in actual conflict
or coverage or inclusion states.

Bug: T156427
Change-Id: Ie8b6020e6dc93b46e94d2bc2bebb71b56f1e3645

4 years agoMerge "Replace deprecated jQuery.nodeName"
jenkins-bot [Sat, 18 Mar 2017 09:50:32 +0000 (09:50 +0000)]
Merge "Replace deprecated jQuery.nodeName"

4 years agoMerge "resourceloader: Fix broken @coverage for ImageModuleTest"
jenkins-bot [Sat, 18 Mar 2017 02:16:51 +0000 (02:16 +0000)]
Merge "resourceloader: Fix broken @coverage for ImageModuleTest"

4 years agoMerge "RCFilters: Update conflict messages"
jenkins-bot [Sat, 18 Mar 2017 02:16:46 +0000 (02:16 +0000)]
Merge "RCFilters: Update conflict messages"

4 years agoMerge "RCFilters UI: Implement conflict global result message"
jenkins-bot [Sat, 18 Mar 2017 02:01:52 +0000 (02:01 +0000)]
Merge "RCFilters UI: Implement conflict global result message"

4 years agoRCFilters: Update conflict messages
Roan Kattouw [Sat, 18 Mar 2017 01:45:47 +0000 (18:45 -0700)]
RCFilters: Update conflict messages

Bug: T160803
Change-Id: I5c645ddce991f9352d779ba4d72d5171a948f836

4 years agoresourceloader: Fix broken @coverage for ImageModuleTest
Timo Tijhof [Sat, 18 Mar 2017 01:26:08 +0000 (18:26 -0700)]
resourceloader: Fix broken @coverage for ImageModuleTest

Follows-up f4329ddbc8.

Change-Id: I7e1761295328af7ead42da4b722a2275b5c1ddb9

4 years agoMerge "Watchlist: Fix form and preference overriding"
jenkins-bot [Sat, 18 Mar 2017 01:16:49 +0000 (01:16 +0000)]
Merge "Watchlist: Fix form and preference overriding"

4 years agoRCFilters UI: Implement conflict global result message
Moriel Schottlender [Sat, 18 Mar 2017 00:29:07 +0000 (17:29 -0700)]
RCFilters UI: Implement conflict global result message

Bug: T156427
Change-Id: I7ae968477091db37e3e2d17fca6f212f919d90d8

4 years agoMerge "RCFilters UI: Create tooltips for filter states"
jenkins-bot [Sat, 18 Mar 2017 01:05:29 +0000 (01:05 +0000)]
Merge "RCFilters UI: Create tooltips for filter states"

4 years agoWatchlist: Fix form and preference overriding
Matthew Flaschen [Fri, 17 Mar 2017 22:33:12 +0000 (18:33 -0400)]
Watchlist: Fix form and preference overriding

Fix a regression caused by aa063f4c5a19.  Restore the behavior
where:

* Without action=submit: Boolean preferences apply to the displayed form and its
  results, but they can be overriden by the query string.
* With action=submit: Only boolean parameters in the query string apply;
  preferences are not considered.

  (However, boolean preferences not on the form, i.e. 'extended', still
  always apply.)

This behavior is a consequence of how checkboxes work in HTML; only
checked boxes are sent to the server.

Bug: T160734
Change-Id: Ic050dd1445ade9449496bb051f04ca0a87b8b5d7

4 years agoMerge "Mark 'jquery.autoElllipsis' module as deprecated"
jenkins-bot [Sat, 18 Mar 2017 00:50:13 +0000 (00:50 +0000)]
Merge "Mark 'jquery.autoElllipsis' module as deprecated"

4 years agoRCFilters UI: Create tooltips for filter states
Roan Kattouw [Fri, 10 Mar 2017 03:47:34 +0000 (19:47 -0800)]
RCFilters UI: Create tooltips for filter states

Tooltips represent the state of the filter, whether it is
conflicted, included, or fully covered.

If none of the above, tooltip message falls back on displaying
the description of the filter.

Bug: T156864
Change-Id: Ic97c7c6aae78bb6ddf51f0294eeae4b7f86a1a1d

4 years agoMerge "resourceloader: Fix broken 'deprecated' string messages"
jenkins-bot [Sat, 18 Mar 2017 00:38:43 +0000 (00:38 +0000)]
Merge "resourceloader: Fix broken 'deprecated' string messages"

4 years agoMark 'jquery.autoElllipsis' module as deprecated
Timo Tijhof [Fri, 17 Mar 2017 23:57:36 +0000 (16:57 -0700)]
Mark 'jquery.autoElllipsis' module as deprecated

It was originally introduced for jquery.searchSuggest, which hasn't
used this since 2014 (56a4aff8ca61106c) when it was removed for
performance reasons (T61172) in favour of CSS text-overflow.

Deprecation is done the same way as for 'jquery.arrowSteps'.

Bug: T160804
Change-Id: Ib7b37b94200a8802de9d98581d3cb42df6e5ba17

4 years agoresourceloader: Fix broken 'deprecated' string messages
Timo Tijhof [Sat, 18 Mar 2017 00:22:34 +0000 (17:22 -0700)]
resourceloader: Fix broken 'deprecated' string messages

Some used a string value, others an array with 'message' property.
Standardise on the string value, which seems more intuitive.

Change-Id: I5caead7b7017d2bad660db02fb45a54a26bf3728

4 years agoRemove unused 'jquery.arrowSteps' (deprecated in 1.28)
Timo Tijhof [Sat, 18 Mar 2017 00:11:53 +0000 (17:11 -0700)]
Remove unused 'jquery.arrowSteps' (deprecated in 1.28)

Was only used by UploadWizard, and no-where else in Wikimedia Git.
UploadWizard has its own copy as of last year. (T144974)

Change-Id: I3d426f67f8ba061d10434469f261cb725bd672d6

4 years agoMerge "RCFilters UI: Remove custom margin from capsule item widgets"
jenkins-bot [Fri, 17 Mar 2017 23:50:07 +0000 (23:50 +0000)]
Merge "RCFilters UI: Remove custom margin from capsule item widgets"

4 years agoRCFilters UI: Close gap between popup and input
Moriel Schottlender [Fri, 17 Mar 2017 22:35:21 +0000 (15:35 -0700)]
RCFilters UI: Close gap between popup and input

Bug: T160213
Change-Id: I9a36be445c3203b599034f8c45297ecd635cbcaf

4 years agoRCFilters UI: Remove custom margin from capsule item widgets
Moriel Schottlender [Fri, 17 Mar 2017 22:41:00 +0000 (15:41 -0700)]
RCFilters UI: Remove custom margin from capsule item widgets

Use the default margin for capsule item widget from OOUI so it
has proper distance in the second row as well.

Bug: T160784
Change-Id: Icba3f0fe532f473d066261405ddc04b8b6c6a31f

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 17 Mar 2017 20:57:16 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibf1d7374533428a2024f5f252c6d91ecc866455d

4 years agoMerge "ResourceLoaderOOUIModule: Minor code quality fixes, and more comments"
jenkins-bot [Fri, 17 Mar 2017 20:21:42 +0000 (20:21 +0000)]
Merge "ResourceLoaderOOUIModule: Minor code quality fixes, and more comments"

4 years agoMerge "RCFilters UI: Add a 'what's this?' link to filter groups"
jenkins-bot [Fri, 17 Mar 2017 20:05:21 +0000 (20:05 +0000)]
Merge "RCFilters UI: Add a 'what's this?' link to filter groups"

4 years agoRCFilters UI: Add a 'what's this?' link to filter groups
Moriel Schottlender [Fri, 17 Mar 2017 00:21:36 +0000 (17:21 -0700)]
RCFilters UI: Add a 'what's this?' link to filter groups

Bug: T159186
Change-Id: I347c23fdabab2a1e1c52f5b10995bcbb2a316875

4 years agoRemove the localStorage replication of the block cookie
Sam Wilson [Wed, 18 Jan 2017 07:03:05 +0000 (15:03 +0800)]
Remove the localStorage replication of the block cookie

The block cookie was being replicated to localStorage in an attempt
to make it harder for users to get around the block by deleting the
cookie (and changing IP addresses).

This whole setup was hard to test, had a few bugs (e.g. the localStorage
value would never expire), and given that it is a minor improvement
over just a plain cookie, it is now being removed. The cookie is only
intended to stop casual block-evaders (other users will get around it
by deleting the cookie or using incognito mode) and so it is not felt
worth having the extra complexity that will only guard against people
who know to remove cookies, not use incognito mode, and yet don't know
to remove localStorage.

Bug: T152952
Change-Id: Ifb06dc2390f4d648d7fcb39e30267de5eddc6941

4 years agoReplace deprecated jQuery.nodeName
Fomafix [Fri, 17 Mar 2017 14:42:20 +0000 (15:42 +0100)]
Replace deprecated jQuery.nodeName

jQuery.nodeName gets deprecated in jQuery 3.2.0. [1] [2]

[1] https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/
[2] https://github.com/jquery/jquery/issues/3475

Change-Id: I7e6d5191e4db5117dbcfa89b07f25e672ed1e4d2

4 years agoReplace deprecated Context::getStats() with MWServices::getStatsdDataFactory()
WMDE-Fisch [Fri, 17 Mar 2017 10:57:37 +0000 (11:57 +0100)]
Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()

Change-Id: I1756f69ca2ebd301a5049bf758d1a87c37771fe6

4 years agoRemove deprecated noop functions
WMDE-Fisch [Fri, 17 Mar 2017 10:25:53 +0000 (11:25 +0100)]
Remove deprecated noop functions

Change-Id: Ia821d43e243b1ee146d3bc4ed35f6aff0bf17466

4 years agoMerge "Add password validation to Special:ChangeCredentials"
jenkins-bot [Fri, 17 Mar 2017 08:35:06 +0000 (08:35 +0000)]
Merge "Add password validation to Special:ChangeCredentials"

4 years agoMerge "Update account creation form validation"
jenkins-bot [Fri, 17 Mar 2017 08:32:34 +0000 (08:32 +0000)]
Merge "Update account creation form validation"

4 years agoMerge "resourceloader: Use SVG url when ResourceLoaderImageModule can't embed"
jenkins-bot [Fri, 17 Mar 2017 06:33:31 +0000 (06:33 +0000)]
Merge "resourceloader: Use SVG url when ResourceLoaderImageModule can't embed"