lhc/web/wiklou.git
5 years agoUpdate OOUI to v0.31.0
James D. Forrester [Thu, 14 Mar 2019 01:03:02 +0000 (18:03 -0700)]
Update OOUI to v0.31.0

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.31.0

Bug: T215645
Bug: T217471
Bug: T217584
Bug: T217952
Bug: T218271
Depends-On: Icc14a3662039080f1a65d098004640366351f0bb
Change-Id: Icc14a3662039080f1a65d098004640366351f0ba

5 years agoMerge "Remove references to Html5Depurate"
jenkins-bot [Wed, 13 Mar 2019 23:31:02 +0000 (23:31 +0000)]
Merge "Remove references to Html5Depurate"

5 years agoMerge "Avoid a few overly complicated is_null() checks"
jenkins-bot [Wed, 13 Mar 2019 22:23:50 +0000 (22:23 +0000)]
Merge "Avoid a few overly complicated is_null() checks"

5 years agoRemove references to Html5Depurate
Subramanya Sastry [Wed, 13 Mar 2019 21:33:37 +0000 (16:33 -0500)]
Remove references to Html5Depurate

Change-Id: I4f07c5ae606f5c86242bb7d299f4f30a044860b4

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 13 Mar 2019 20:58:23 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I0b3266b3300731491affb838bb287496fe942d3a

5 years agoMerge "resourceloader: Remove redundant var-freeing in addScript()"
jenkins-bot [Wed, 13 Mar 2019 18:11:21 +0000 (18:11 +0000)]
Merge "resourceloader: Remove redundant var-freeing in addScript()"

5 years agoMerge "resourceloader: Reduce size of ES5 StringSet fallback"
jenkins-bot [Wed, 13 Mar 2019 17:59:14 +0000 (17:59 +0000)]
Merge "resourceloader: Reduce size of ES5 StringSet fallback"

5 years agoMerge "resourceloader: Minor optimisation in variable declarations"
jenkins-bot [Wed, 13 Mar 2019 17:59:08 +0000 (17:59 +0000)]
Merge "resourceloader: Minor optimisation in variable declarations"

5 years agoparser: closeParagraph already resets the lastSection
Arlo Breault [Wed, 6 Mar 2019 21:49:07 +0000 (16:49 -0500)]
parser: closeParagraph already resets the lastSection

Change-Id: Ic24c9aa25852cc786a5ca438c2c1e9031f9e7c17

5 years agoMerge "Replace sorting classes with better naming convention"
jenkins-bot [Wed, 13 Mar 2019 00:27:11 +0000 (00:27 +0000)]
Merge "Replace sorting classes with better naming convention"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 12 Mar 2019 21:09:11 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I2887536cb78f5b4780550b67a2fde8aaf7530a97

5 years agoMerge "LogEntry: Restore logic to add change tags on udp-only publish"
jenkins-bot [Tue, 12 Mar 2019 17:55:18 +0000 (17:55 +0000)]
Merge "LogEntry: Restore logic to add change tags on udp-only publish"

5 years agoMerge "ApiMain.php api/request logging event changes"
Ottomata [Tue, 12 Mar 2019 17:23:12 +0000 (17:23 +0000)]
Merge "ApiMain.php api/request logging event changes"

5 years agoMerge "Add password policy setting `suggestChangeOnLogin`"
jenkins-bot [Tue, 12 Mar 2019 16:35:00 +0000 (16:35 +0000)]
Merge "Add password policy setting `suggestChangeOnLogin`"

5 years agoApiMain.php api/request logging event changes
Andrew Otto [Fri, 8 Mar 2019 21:50:34 +0000 (16:50 -0500)]
ApiMain.php api/request logging event changes

- Use 'Z' UTC timezone on dt
- Don't provide empty arrays if no data entries
- No need to set X-Request-Id in http.request_headers, it is meta.request_id

Bug: T214080
Bug: T212529
Change-Id: I37aa41a46ce74b372070e88a2f4da746fcbe2449

5 years agoLogEntry: Restore logic to add change tags on udp-only publish
Brad Jorsch [Tue, 12 Mar 2019 14:55:27 +0000 (10:55 -0400)]
LogEntry: Restore logic to add change tags on udp-only publish

This was unintentionally removed in I8df2fd98.

Bug: T218110
Change-Id: Ie8678b4207032d6eb877d596eb8f115798c80a1e

5 years agoMerge "Remove deprecated ParserOutput::legacyOptions"
jenkins-bot [Tue, 12 Mar 2019 08:35:09 +0000 (08:35 +0000)]
Merge "Remove deprecated ParserOutput::legacyOptions"

5 years agoMerge "Improve documentation of the PageContentLanguage hook"
jenkins-bot [Tue, 12 Mar 2019 07:33:57 +0000 (07:33 +0000)]
Merge "Improve documentation of the PageContentLanguage hook"

5 years agoReplace sorting classes with better naming convention
Volker E [Sat, 19 Jan 2019 02:24:21 +0000 (18:24 -0800)]
Replace sorting classes with better naming convention

Improving CSS structure by removing code duplications.

Bug: T214218
Change-Id: I0501e1ab934aef3af289fee618b99578a1f0285c

5 years agoImprove documentation of the PageContentLanguage hook
Niklas Laxström [Wed, 6 Mar 2019 12:23:06 +0000 (13:23 +0100)]
Improve documentation of the PageContentLanguage hook

Clarify that the type of second parameter that is being passed
to the hooks can be anything because one hook can change it and
then it is passed to another hook without the hook caller having
possibility to check or modify the value.

Clarify that hooks should only return Language objects.

Rename $wgLang to $userLang in the hook parameter documentation to
avoid false posivite matches for the global.

Fix some typos, use Title::inNamespace and add a test assertion.

Also, the $content parameter is unused by all implementations of
this method, and on quick look never passed by any caller. I kept
it for now, however.

Bug: T214358
Change-Id: Iae49d2998c2b762565d232c0337d84d43a4a900c

5 years agoRemove deprecated ParserOutput::legacyOptions
Aaron Schulz [Fri, 8 Mar 2019 22:31:01 +0000 (14:31 -0800)]
Remove deprecated ParserOutput::legacyOptions

Change-Id: I5f32dd741f3ee795ec599aacb687d5cee2c52835

5 years agoMerge "jobqueue: allow direct server configuration arrays to JobQueueDB"
jenkins-bot [Tue, 12 Mar 2019 04:25:50 +0000 (04:25 +0000)]
Merge "jobqueue: allow direct server configuration arrays to JobQueueDB"

5 years agoMerge "Add sanity check to notifyUpdatesForRevision() for $oldRev"
jenkins-bot [Tue, 12 Mar 2019 04:22:19 +0000 (04:22 +0000)]
Merge "Add sanity check to notifyUpdatesForRevision() for $oldRev"

5 years agoMerge "resourceloader: Reword and expand doc comment about FileModule "packageFiles""
jenkins-bot [Tue, 12 Mar 2019 04:20:02 +0000 (04:20 +0000)]
Merge "resourceloader: Reword and expand doc comment about FileModule "packageFiles""

5 years agoresourceloader: Reword and expand doc comment about FileModule "packageFiles"
Aaron Schulz [Sun, 10 Mar 2019 19:56:34 +0000 (12:56 -0700)]
resourceloader: Reword and expand doc comment about FileModule "packageFiles"

Change-Id: Id9d68205504ecbddea6ca248e108f368fdcac2d2

5 years agoMerge "logging: Start using LinkTarget & UserIdentity in ManualLogEntry"
jenkins-bot [Tue, 12 Mar 2019 02:14:39 +0000 (02:14 +0000)]
Merge "logging: Start using LinkTarget & UserIdentity in ManualLogEntry"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 11 Mar 2019 20:55:59 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I7ee423c084fbe33d4731e43ce5506f6a6f0c40be

5 years agoMerge "Fix the order of the parameters for htmlform-title-badnamespace"
jenkins-bot [Mon, 11 Mar 2019 20:28:07 +0000 (20:28 +0000)]
Merge "Fix the order of the parameters for htmlform-title-badnamespace"

5 years agoMerge "Bump minimum SQLite version to 3.8.0"
jenkins-bot [Mon, 11 Mar 2019 20:27:59 +0000 (20:27 +0000)]
Merge "Bump minimum SQLite version to 3.8.0"

5 years agoMerge "Fix small typos"
jenkins-bot [Mon, 11 Mar 2019 18:34:01 +0000 (18:34 +0000)]
Merge "Fix small typos"

5 years agoMerge "Linker: Use RequestContext::getMain()->getLanguage() instead of $wgLang"
jenkins-bot [Mon, 11 Mar 2019 18:30:56 +0000 (18:30 +0000)]
Merge "Linker: Use RequestContext::getMain()->getLanguage() instead of $wgLang"

5 years agoOutputPage: Use $this->getUser()
Fomafix [Mon, 11 Mar 2019 16:50:46 +0000 (17:50 +0100)]
OutputPage: Use $this->getUser()

Use $this->getUser() instead of $this->getContext()->getUser().
ContextSource::getUser is a shortcut for $this->getContext()->getUser().

Change-Id: I7d19116b634500cd1a435bebe235c7562889f7bb

5 years agoMerge "Avoid using stale data for revision visibility and actor data"
jenkins-bot [Mon, 11 Mar 2019 14:37:48 +0000 (14:37 +0000)]
Merge "Avoid using stale data for revision visibility and actor data"

5 years agoMerge "Streamline code involving .= string concatenations"
jenkins-bot [Mon, 11 Mar 2019 12:39:04 +0000 (12:39 +0000)]
Merge "Streamline code involving .= string concatenations"

5 years agoStreamline code involving .= string concatenations
Thiemo Kreuz [Thu, 7 Mar 2019 09:55:31 +0000 (10:55 +0100)]
Streamline code involving .= string concatenations

This was inspired by Idbbdb31. Originally, I did a regex search for
code that did string concatenations like `$str = $str . …` and replaced
them all with the .= operator. A duplicate patch was uploaded by another
author. I rebeased this patch on top of the other, which leaves all
the manual optimizations I did.

Change-Id: Iaeb73d9c63302c9409bd1051b91e0d2bd77788a7

5 years agoAvoid a few overly complicated is_null() checks
Thiemo Kreuz [Mon, 11 Mar 2019 09:29:20 +0000 (10:29 +0100)]
Avoid a few overly complicated is_null() checks

We can use the ?? syntax introduced with PHP 7.0 because it is already
supported by HHVM, even when HHVM is set to be compatible with PHP 5.6.

This was inspired by Ib117e05.

Change-Id: If980839fe6f86f2b4e86bbe99905a796e4708c7c

5 years agoBump minimum SQLite version to 3.8.0
Max Semenik [Sat, 29 Sep 2018 02:44:45 +0000 (19:44 -0700)]
Bump minimum SQLite version to 3.8.0

3.3.7 is 12 years old, no chance in hell you will find it somewhere
that supports modern MediaWiki. Since Ubuntu 14.04 LTS has 3.8.2, this
seems like a reasonable conservative version.

Change-Id: I5fbb35bd2d4c0993889b79f463a3c35ce6765d3b

5 years agoMerge "ProtectionForm: Add type hint to ::showLogExtract() header"
jenkins-bot [Sun, 10 Mar 2019 23:37:07 +0000 (23:37 +0000)]
Merge "ProtectionForm: Add type hint to ::showLogExtract() header"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 10 Mar 2019 20:56:09 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibf7f5a6cc435b330df709d40f8ea0687c65832c5

5 years agoAvoid using stale data for revision visibility and actor data
Bill Pirkle [Wed, 27 Feb 2019 21:26:17 +0000 (15:26 -0600)]
Avoid using stale data for revision visibility and actor data

Created class RevisionStoreCacheRecord to avoid returning stale
cached revision visibility and actor data when changes were
made after the cache was populated for that revision.

Bug: T216159
Change-Id: Iabed80e06a08ff0793dfe64db881cbcd535cb13f

5 years agoMerge "mediawiki.cookie: Export config via packageFiles"
jenkins-bot [Sun, 10 Mar 2019 20:14:52 +0000 (20:14 +0000)]
Merge "mediawiki.cookie: Export config via packageFiles"

5 years agoProtectionForm: Add type hint to ::showLogExtract() header
Derick Alangi [Sun, 10 Mar 2019 18:12:48 +0000 (19:12 +0100)]
ProtectionForm: Add type hint to ::showLogExtract() header

https://codesearch.wmflabs.org/core/?q=showLogExtract%5C(&i=nope&files=&repos=
according to codesearch shows that this method takes as first argument an output
page object and also, objects are passed by reference by default so removed &.

Change-Id: I167ae6300b37d4e9292bd8ad14351f1ca35184d2

5 years agoRemove a few method_exists() checks
Max Semenik [Sun, 10 Mar 2019 08:08:44 +0000 (00:08 -0800)]
Remove a few method_exists() checks

These functions are present in every PHP version we support now.

Change-Id: I11add0fc9f6c3c3caff859db9c0475c4d2818577

5 years agoMerge "installer: Code augmentation in wfInstallerMain function"
jenkins-bot [Sun, 10 Mar 2019 05:33:59 +0000 (05:33 +0000)]
Merge "installer: Code augmentation in wfInstallerMain function"

5 years agoMerge "Add @var to class properties to clarify types"
jenkins-bot [Sun, 10 Mar 2019 03:34:17 +0000 (03:34 +0000)]
Merge "Add @var to class properties to clarify types"

5 years agoMerge "Move class HistoryPager to own file"
jenkins-bot [Sun, 10 Mar 2019 03:25:36 +0000 (03:25 +0000)]
Merge "Move class HistoryPager to own file"

5 years agoMerge "Move class RangeDifference to own file"
jenkins-bot [Sun, 10 Mar 2019 03:20:09 +0000 (03:20 +0000)]
Merge "Move class RangeDifference to own file"

5 years agoMerge "Remove suppress of PhanRedefineFunctionInternal"
jenkins-bot [Sun, 10 Mar 2019 03:15:24 +0000 (03:15 +0000)]
Merge "Remove suppress of PhanRedefineFunctionInternal"

5 years agomediawiki.cookie: Export config via packageFiles
Timo Tijhof [Sat, 9 Mar 2019 02:46:38 +0000 (02:46 +0000)]
mediawiki.cookie: Export config via packageFiles

* Add a private setDefaults() method to allow mocking from
  unit tests.

* Use matching keys between the data export and the API.

* Reduce duplication in the code.

* Access the Sinon stub explicitly instead of via the public path.

* Remove use of the now-redundant QUnit.newMwEnvironment().

Change-Id: I600332cdb738f0b443549948b9f070f3ccfa12aa

5 years agoMerge "maintenance: Replace deprecated global $wgParser with getParser() service"
jenkins-bot [Sat, 9 Mar 2019 23:56:19 +0000 (23:56 +0000)]
Merge "maintenance: Replace deprecated global $wgParser with getParser() service"

5 years agomaintenance: Replace deprecated global $wgParser with getParser() service
Derick Alangi [Sat, 9 Mar 2019 22:37:49 +0000 (23:37 +0100)]
maintenance: Replace deprecated global $wgParser with getParser() service

$wgParser is deprecated and using globals should also be avoid. So, replacing
the use of global $wgParser by a mediawiki service.

Change-Id: I34b61338e500567773249c71da0a7125cfd50d02

5 years agoMerge "installer: Remove redundant $key variable"
jenkins-bot [Sat, 9 Mar 2019 22:38:59 +0000 (22:38 +0000)]
Merge "installer: Remove redundant $key variable"

5 years agoinstaller: Remove redundant $key variable
Timo Tijhof [Sat, 9 Mar 2019 22:15:20 +0000 (22:15 +0000)]
installer: Remove redundant $key variable

Change-Id: Ie6d59a1fd94ccfb2a3b5248f1f98ae640a4d5c2c

5 years agoMerge "NamespaceMultiselectWidget: Allow filtering by namespace ID or label"
jenkins-bot [Sat, 9 Mar 2019 20:59:51 +0000 (20:59 +0000)]
Merge "NamespaceMultiselectWidget: Allow filtering by namespace ID or label"

5 years agoAdd sanity check to notifyUpdatesForRevision() for $oldRev
Aaron Schulz [Sat, 9 Mar 2019 20:27:29 +0000 (12:27 -0800)]
Add sanity check to notifyUpdatesForRevision() for $oldRev

Change-Id: Ibd8975efb33d061ab16dc1a59899b6f78976ec5d

5 years agoMerge "Block: Explicit convert Message to string"
jenkins-bot [Sat, 9 Mar 2019 20:08:22 +0000 (20:08 +0000)]
Merge "Block: Explicit convert Message to string"

5 years agoAdd password policy setting `suggestChangeOnLogin`
Dayllan Maza [Wed, 20 Feb 2019 06:02:33 +0000 (01:02 -0500)]
Add password policy setting `suggestChangeOnLogin`

Password policy checks that fail and have `suggestChangeOnLogin` set to true will
prompt for a password change on login.

Below are some rules that apply to this setting in different scenarios:

- If only one policy fails and has `suggestChangeOnLogin = false`, a password change will
  not be requested
- If more than one policy fails and one or more have `suggestChangeOnLogin` set to true`,
  a password change will be requested
- If `forceChange` is present in any of the failing policies, `suggestChangeOnLogin` value
  will be ignored and password change will be enforced
- if $wgInvalidPasswordReset is set to false `suggestChangeOnLogin` is ignored

IMPORTANT**
Before this patch, suggesting a password change was the default behavior (depending on
$wgInvalidPasswordReset), which means that the necessary changes to $wgPasswordPolicy
need to be in place before this patch is merged and gets to production.

Bug: T211621
Change-Id: I7a4a0a06273fa4e8bd0da3dac54cf5a1b78bb3fd

5 years agoinstaller: Code augmentation in wfInstallerMain function
Derick Alangi [Sat, 9 Mar 2019 13:22:30 +0000 (14:22 +0100)]
installer: Code augmentation in wfInstallerMain function

Cleanup null checks and string literals in wfInstallerMain function.

Change-Id: Ib117e05faf899b0c46820d337f1bd3ebd4272419

5 years agoFix the order of the parameters for htmlform-title-badnamespace
mainframe98 [Sat, 9 Mar 2019 16:00:26 +0000 (17:00 +0100)]
Fix the order of the parameters for htmlform-title-badnamespace

The name of the page is the first parameter, and the namespace is
the second parameter.

Change-Id: I738cdd920d0ce641837c5dc1da391602a15df794

5 years agoinstaller: Get WebRequest in mw-config via RequestContext
Derick Alangi [Sat, 9 Mar 2019 13:29:03 +0000 (14:29 +0100)]
installer: Get WebRequest in mw-config via RequestContext

Change-Id: I535a91d09cc74ab08b782973a946dcf3fc3e6b46

5 years agoRemove suppress of PhanRedefineFunctionInternal
Umherirrender [Sat, 9 Mar 2019 12:29:40 +0000 (12:29 +0000)]
Remove suppress of PhanRedefineFunctionInternal

There is no longer an override

Change-Id: Ie7c99228135689d20ab6ffb287c978642851f3ee

5 years agoresourceloader: Remove redundant var-freeing in addScript()
Timo Tijhof [Sat, 9 Mar 2019 05:06:36 +0000 (05:06 +0000)]
resourceloader: Remove redundant var-freeing in addScript()

This was copied from jQuery 1.x, where it existed to reduce
memory usage in IE6-8. This was because it's JS engine was not
able to break the circular closure reference (the function
invocation has a reference to the script element, the script
element has an event listener with closure access to the script
element). This bug is no longer relevant.

Change-Id: I6fd66c5fbf3afb3c9e09bba6322dc3fac2fad4a6

5 years agoresourceloader: Reduce size of ES5 StringSet fallback
Timo Tijhof [Sat, 9 Mar 2019 05:05:06 +0000 (05:05 +0000)]
resourceloader: Reduce size of ES5 StringSet fallback

Over 90% of browsers have ES6 Set implemented.
Make the fallback a bit smaller.

Change-Id: Icfd18cbeac6d95702ac409297a01c81829d5a41b

5 years agoresourceloader: Minor optimisation in variable declarations
Timo Tijhof [Sat, 9 Mar 2019 04:56:54 +0000 (04:56 +0000)]
resourceloader: Minor optimisation in variable declarations

Trying out Safari after a while and, it's Dev Tools have a
way to see the compiler's type inference, showing that Safari
is not able to always detect some numbers as non-optional.

While I generally avoid optimising for an optimiser, I believe
being more explicit is always better or equal. Plus, it saves a
few bytes while at it.

Change-Id: I4084452a74c51953ff0a1609b3b52d696f14a7e1

5 years agoMerge "mediawiki.cookie: Move file to its own directory"
jenkins-bot [Sat, 9 Mar 2019 05:06:20 +0000 (05:06 +0000)]
Merge "mediawiki.cookie: Move file to its own directory"

5 years agoMerge "SVGMetadataExtractorTest: remove method existence test"
jenkins-bot [Sat, 9 Mar 2019 03:43:48 +0000 (03:43 +0000)]
Merge "SVGMetadataExtractorTest: remove method existence test"

5 years agoMerge "Installer: Fix an obsolete comment"
jenkins-bot [Sat, 9 Mar 2019 03:43:43 +0000 (03:43 +0000)]
Merge "Installer: Fix an obsolete comment"

5 years agoMerge "Remove $wgMediaInTargetLanguage"
jenkins-bot [Sat, 9 Mar 2019 03:42:21 +0000 (03:42 +0000)]
Merge "Remove $wgMediaInTargetLanguage"

5 years agojobqueue: allow direct server configuration arrays to JobQueueDB
Aaron Schulz [Sat, 9 Mar 2019 01:01:30 +0000 (17:01 -0800)]
jobqueue: allow direct server configuration arrays to JobQueueDB

This is useful for using a separate sqlite DB.

Change-Id: I6a7bb1d4bddedca34d68b0d8460c96c6ef5bbcf6

5 years agoInstaller: Fix an obsolete comment
Max Semenik [Sat, 9 Mar 2019 03:12:49 +0000 (19:12 -0800)]
Installer: Fix an obsolete comment

Change-Id: I0ae459b016f491ff3bc2c702e55be29fdcfec5eb

5 years agomediawiki.cookie: Move file to its own directory
Timo Tijhof [Sat, 9 Mar 2019 02:48:26 +0000 (02:48 +0000)]
mediawiki.cookie: Move file to its own directory

In preparation for using RL packageFiles functionality, and
to make sure git can track the file, which it seems to be unable
to otherwise.

Change-Id: I966718db2028a45c3dce1c2c10218e5137e23c7d

5 years agoMerge "Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason"
jenkins-bot [Sat, 9 Mar 2019 02:25:26 +0000 (02:25 +0000)]
Merge "Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason"

5 years agoMake HTMLCacheUpdateJob avoid waiting on replication for no reason
Aaron Schulz [Sat, 9 Mar 2019 01:36:21 +0000 (17:36 -0800)]
Make HTMLCacheUpdateJob avoid waiting on replication for no reason

Change-Id: Ica381dad0bdb0555add1c7925e0e48991e7e0964

5 years agoMake PurgeJobUtils::invalidatePages avoid waiting on replication for no reason
Aaron Schulz [Sat, 9 Mar 2019 01:33:16 +0000 (17:33 -0800)]
Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason

Change-Id: I9ea4e4034ffc30a14b138279515447f990807e07

5 years agoSVGMetadataExtractorTest: remove method existence test
Max Semenik [Sat, 9 Mar 2019 01:48:55 +0000 (17:48 -0800)]
SVGMetadataExtractorTest: remove method existence test

It should be present in everything we support, as the earliest libxml
version would be 2.9.1 while >2.6.20 is required.

See https://3v4l.org/LdTIr

Change-Id: Ibc7152e9224ef8d5803d0e0ff8314cdf9eb8eac4

5 years agoMerge "Make addIdentifierQuotes part of IDatabase"
jenkins-bot [Sat, 9 Mar 2019 00:41:04 +0000 (00:41 +0000)]
Merge "Make addIdentifierQuotes part of IDatabase"

5 years agoMake addIdentifierQuotes part of IDatabase
Brian Wolff [Sun, 17 Feb 2019 11:02:34 +0000 (11:02 +0000)]
Make addIdentifierQuotes part of IDatabase

This is so it can be used in places that typehint an IDatabase,
ultimately so that I can make phan-taint-check happy.

Bug: T216348
Change-Id: Iabf3e9a6add380322a12cdbb6a337bad690f1370

5 years agoMerge "objectcache: Use constant for $ttl param default in WANObjectCache::set()"
jenkins-bot [Sat, 9 Mar 2019 00:15:00 +0000 (00:15 +0000)]
Merge "objectcache: Use constant for $ttl param default in WANObjectCache::set()"

5 years agoobjectcache: Use constant for $ttl param default in WANObjectCache::set()
Andrew Green [Mon, 17 Oct 2016 15:21:08 +0000 (10:21 -0500)]
objectcache: Use constant for $ttl param default in WANObjectCache::set()

Change-Id: I3f936088cd63af4d535d7f46fe5619e8bb866999

5 years agoMerge "rdbms: optimize Database::selectDomain() to avoid extra queries"
jenkins-bot [Fri, 8 Mar 2019 23:37:14 +0000 (23:37 +0000)]
Merge "rdbms: optimize Database::selectDomain() to avoid extra queries"

5 years agoMerge "Remove `list-style-type` declaration from elements.css"
jenkins-bot [Fri, 8 Mar 2019 23:37:08 +0000 (23:37 +0000)]
Merge "Remove `list-style-type` declaration from elements.css"

5 years agoRemove $wgMediaInTargetLanguage
Max Semenik [Fri, 8 Mar 2019 23:23:10 +0000 (15:23 -0800)]
Remove $wgMediaInTargetLanguage

It's a temporary feature flag not included in any release, just
removing it outright. The functonality will now be always enabled.

Bug: T205040
Change-Id: Ia9da82e6f6b2d270f1790a99fc8c35ad5e6aee5e

5 years agoMerge "resourceloader: Omit default 'debug=false' from load.php urls"
jenkins-bot [Fri, 8 Mar 2019 23:12:31 +0000 (23:12 +0000)]
Merge "resourceloader: Omit default 'debug=false' from load.php urls"

5 years agoMerge "resourceloader: Separate context from extraQuery in ClientHtmlTest"
jenkins-bot [Fri, 8 Mar 2019 23:12:26 +0000 (23:12 +0000)]
Merge "resourceloader: Separate context from extraQuery in ClientHtmlTest"

5 years agoMerge "ApiQueryLogEvents: Add IGNORE INDEX to avoid MariaDB optimizer bug"
jenkins-bot [Fri, 8 Mar 2019 23:12:20 +0000 (23:12 +0000)]
Merge "ApiQueryLogEvents: Add IGNORE INDEX to avoid MariaDB optimizer bug"

5 years agoMerge "resourceloader: Replace ResourceLoaderDebug config use with context"
jenkins-bot [Fri, 8 Mar 2019 23:05:29 +0000 (23:05 +0000)]
Merge "resourceloader: Replace ResourceLoaderDebug config use with context"

5 years agoMove class RangeDifference to own file
Umherirrender [Fri, 8 Mar 2019 22:29:14 +0000 (23:29 +0100)]
Move class RangeDifference to own file

Change-Id: I5262c7484017a0d920cc24297515d5946f614ee6

5 years agoRemove `list-style-type` declaration from elements.css
Volker E [Fri, 8 Mar 2019 22:24:53 +0000 (14:24 -0800)]
Remove `list-style-type` declaration from elements.css

This doesn't make any sense here, as
a) we should apply `disc` in alignment to Design Style Guide
b) it's overwritten anyways in both, Vector and MonoBook, with
   different styles

Bug: T151100
Change-Id: Ied6810a78d8fbe5371838921cda468e6873d2e57

5 years agordbms: optimize Database::selectDomain() to avoid extra queries
Aaron Schulz [Fri, 8 Mar 2019 22:04:54 +0000 (14:04 -0800)]
rdbms: optimize Database::selectDomain() to avoid extra queries

Also clean up and align the mysql subclass versions of the method.
Enforce that raw "USE" queries are not passed in, since they would
break the tracking (even before this change).

Change-Id: I11c9145c6c0525f27a4ec8d94c500a22a712b320

5 years agoMerge "jquery.tablesorter: Optimise getElementSortKey() code"
jenkins-bot [Fri, 8 Mar 2019 21:45:58 +0000 (21:45 +0000)]
Merge "jquery.tablesorter: Optimise getElementSortKey() code"

5 years agoMerge "Move CacheDependency classes to own files"
jenkins-bot [Fri, 8 Mar 2019 21:45:31 +0000 (21:45 +0000)]
Merge "Move CacheDependency classes to own files"

5 years agoMerge "objectcache: add metrics for WAN cache deletes and check key touches/resets"
jenkins-bot [Fri, 8 Mar 2019 21:40:12 +0000 (21:40 +0000)]
Merge "objectcache: add metrics for WAN cache deletes and check key touches/resets"

5 years agoMerge "objectcache: move ERR_* constants to IExpiringStore"
jenkins-bot [Fri, 8 Mar 2019 21:40:04 +0000 (21:40 +0000)]
Merge "objectcache: move ERR_* constants to IExpiringStore"

5 years agoresourceloader: Omit default 'debug=false' from load.php urls
Timo Tijhof [Fri, 8 Mar 2019 20:37:12 +0000 (20:37 +0000)]
resourceloader: Omit default 'debug=false' from load.php urls

Change-Id: I2a2f92b0f0438420105e6a4e4d97eb5f8c480917

5 years agoresourceloader: Separate context from extraQuery in ClientHtmlTest
Timo Tijhof [Fri, 8 Mar 2019 20:58:16 +0000 (20:58 +0000)]
resourceloader: Separate context from extraQuery in ClientHtmlTest

The test was dual-purposing the same array both to create
a ResourceLoaderContext object, and to pass further down as
$extraQuery parameter.

This meant that ResourceLoaderClientHtml::makeLoad, and indirectly
ResourceLoader::makeLoaderQuery, did not have any control over
the formatting of the query string, due to it forcing the key/value
pairs regardless (in addition to being redundant).

This is needed in order to omit debug=false by default, which is
the next commit.

Change-Id: I3c098a9a5055ec8f2b64319c6cadd13c030ba76a

5 years agoMove CacheDependency classes to own files
Umherirrender [Fri, 8 Mar 2019 21:27:29 +0000 (22:27 +0100)]
Move CacheDependency classes to own files

Change-Id: Icacf36674f10fa19a09499d68d596d5e2cc235f0

5 years agoobjectcache: remove BagOStuff::modifySimpleRelayEvent()
Aaron Schulz [Thu, 7 Mar 2019 23:12:33 +0000 (15:12 -0800)]
objectcache: remove BagOStuff::modifySimpleRelayEvent()

This was only there as part of EventRelayer use by WAN cache, which
has since been removed. No other usage really makes sense.

Change-Id: I201425bb88739dd8febbfbc3d24a15e6d3d88d9c

5 years agoobjectcache: move ERR_* constants to IExpiringStore
Aaron Schulz [Fri, 8 Mar 2019 21:11:54 +0000 (13:11 -0800)]
objectcache: move ERR_* constants to IExpiringStore

Also removed unused ERR_* constant from WANObjectCache and fixed
comment in the constructor.

Change-Id: I4377fc3f533113a459b648fad084ba097ff51762

5 years agojquery.tablesorter: Optimise getElementSortKey() code
Timo Tijhof [Fri, 8 Mar 2019 16:02:44 +0000 (16:02 +0000)]
jquery.tablesorter: Optimise getElementSortKey() code

* Document why this uses $().data() instead of $.data(),
  as the rest of this file does.

* Move single-use $() to where it is needed.

* Use native Image.alt directly instead of going via jQuery
  and attributes. This also obviates the need for a default,
  as the DOM handles that already.

* Remove needless $.makeArray(), use $.map() directly which
  supports the same array-like objects as $.makeArray().

* Use native elem.textContent directly for text nodes,
  instead of $(elem).text().

Change-Id: I92da50e1c01f11585d2bac4f01dba1f671444a63

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 8 Mar 2019 21:06:23 +0000 (22:06 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If38e8f3671ef5a53006836c5ac14bbadc6930098