4 years agoFix you -> your in 'pagedata-text' message
Reedy [Mon, 4 Sep 2017 16:25:34 +0000 (17:25 +0100)]
Fix you -> your in 'pagedata-text' message

Bug: T174961
Change-Id: I7cfcfca4decac3e2afc09e58959a001ac13d3d49

4 years agoMerge "Turn Special:NewFiles list of media types into list of checkboxes"
jenkins-bot [Mon, 4 Sep 2017 16:23:30 +0000 (16:23 +0000)]
Merge "Turn Special:NewFiles list of media types into list of checkboxes"

4 years agoMerge "Drop compatibility with PHP 5.3"
jenkins-bot [Mon, 4 Sep 2017 14:34:50 +0000 (14:34 +0000)]
Merge "Drop compatibility with PHP 5.3"

4 years agoMerge "Fix typo in ILBFactory::waitForReplication phpdoc"
jenkins-bot [Mon, 4 Sep 2017 14:10:06 +0000 (14:10 +0000)]
Merge "Fix typo in ILBFactory::waitForReplication phpdoc"

4 years agoMerge "resourceloader: Preload base modules request from startup module"
jenkins-bot [Mon, 4 Sep 2017 12:36:37 +0000 (12:36 +0000)]
Merge "resourceloader: Preload base modules request from startup module"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 3 Sep 2017 19:54:41 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I7b033dfc8380deaed29661b51cacc29f08c5b7f6

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 3 Sep 2017 06:21:33 +0000 (08:21 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5ae624cf1b2ed597abb2ffb96dc6f13267e93967

4 years agoMerge "EditPage: Remove unused variable in getCheckboxesOOUI()"
jenkins-bot [Sun, 3 Sep 2017 01:34:05 +0000 (01:34 +0000)]
Merge "EditPage: Remove unused variable in getCheckboxesOOUI()"

4 years agoDrop compatibility with PHP 5.3
Matěj Suchánek [Sat, 2 Sep 2017 18:01:44 +0000 (20:01 +0200)]
Drop compatibility with PHP 5.3

Since 5.4, $this works inside closures.

Change-Id: I6987f76a1e33d6d7ab020a57186e5477186bbf2e

4 years agoTableSorter: Sort unrecognized dates as -Infinity
Derk-Jan Hartman [Sat, 2 Sep 2017 08:51:48 +0000 (10:51 +0200)]
TableSorter: Sort unrecognized dates as -Infinity

Follow-up to: I664b4cc
Bug: T174814
Change-Id: I028681172be7a30e51cab42847c4fc35e9358aca

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 2 Sep 2017 07:16:49 +0000 (09:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibf8a472053f8dafc581fbe3bd8d9be188048995d

4 years agoMerge "WLFilters: reword watchlist-details slightly"
jenkins-bot [Fri, 1 Sep 2017 22:14:18 +0000 (22:14 +0000)]
Merge "WLFilters: reword watchlist-details slightly"

4 years agoMerge "mediawiki.special.changeslist.legend.js: Remove wait for document ready"
jenkins-bot [Fri, 1 Sep 2017 22:08:10 +0000 (22:08 +0000)]
Merge "mediawiki.special.changeslist.legend.js: Remove wait for document ready"

4 years agomediawiki.special.changeslist.legend.js: Remove wait for document ready
Fomafix [Fri, 1 Sep 2017 21:39:30 +0000 (23:39 +0200)]
mediawiki.special.changeslist.legend.js: Remove wait for document ready

mw.hook( 'wikipage.content' ) gets fired after document ready.

Change-Id: Ia1536e734f8ae08cc7cc07c3b1854bdaafb54866

4 years agoMerge "Remove reference to deprecated IDatabase->nextSequenceValue()"
jenkins-bot [Fri, 1 Sep 2017 20:20:40 +0000 (20:20 +0000)]
Merge "Remove reference to deprecated IDatabase->nextSequenceValue()"

4 years agoWLFilters: reword watchlist-details slightly
Stephane Bisson [Fri, 1 Sep 2017 19:52:49 +0000 (15:52 -0400)]
WLFilters: reword watchlist-details slightly

It won't show up like this on en.wp due to
site customization but other wikis will see it.

Bug: T172030
Change-Id: I2dbaad3c5f8200d95431fda6f246decdb1633c62

4 years agoMerge "EditPage: Restore getSummaryInput(); deprecate it and getSummaryInputOOUI()"
jenkins-bot [Fri, 1 Sep 2017 20:17:01 +0000 (20:17 +0000)]
Merge "EditPage: Restore getSummaryInput(); deprecate it and getSummaryInputOOUI()"

4 years agoEditPage: Restore getSummaryInput(); deprecate it and getSummaryInputOOUI()
Bartosz Dziewoński [Wed, 30 Aug 2017 18:33:23 +0000 (20:33 +0200)]
EditPage: Restore getSummaryInput(); deprecate it and getSummaryInputOOUI()

Follow-up to 478caa076f75fde935c66eb9334410d868c30818.
We can't just remove it without a deprecation.

Change-Id: I3286e8de12bacb50a6d080477adbecf09b3be71c

4 years agoMerge "WLFilters: fix msg keys to comply with standard"
jenkins-bot [Fri, 1 Sep 2017 18:54:57 +0000 (18:54 +0000)]
Merge "WLFilters: fix msg keys to comply with standard"

4 years agoMerge "RCFilters: Minimize vertical spacing; get rid of legend and <br>s"
jenkins-bot [Fri, 1 Sep 2017 18:21:15 +0000 (18:21 +0000)]
Merge "RCFilters: Minimize vertical spacing; get rid of legend and <br>s"

4 years agoWLFilters: fix msg keys to comply with standard
Stephane Bisson [Fri, 1 Sep 2017 18:07:45 +0000 (14:07 -0400)]
WLFilters: fix msg keys to comply with standard

Change-Id: Iea19ddb38b362fb01535cde595d82cc7fd1ad479

4 years agoRCFilters: Minimize vertical spacing; get rid of legend and <br>s
Moriel Schottlender [Thu, 24 Aug 2017 23:52:29 +0000 (16:52 -0700)]
RCFilters: Minimize vertical spacing; get rid of legend and <br>s

Bug: T174121
Change-Id: I2249bf3d313232fe2f0dff6e34c5140885a13735

4 years agoRemove patch-log_search-rename-index.sql from MW 1.16 updaters
Reedy [Fri, 1 Sep 2017 16:39:50 +0000 (17:39 +0100)]
Remove patch-log_search-rename-index.sql from MW 1.16 updaters

Otherwise, the PK on log_search keeps getting dropped, ls_field_val readded and
this is then repeated on every run of update.php

Change-Id: I6b00933c29b5e24ec2833001fcf45053292d190c
Follows-up: Id635297838938c7c5dfe65d45285a4d16d65152d

4 years agoRemove reference to deprecated IDatabase->nextSequenceValue()
Brad Jorsch [Fri, 1 Sep 2017 13:46:43 +0000 (09:46 -0400)]
Remove reference to deprecated IDatabase->nextSequenceValue()

The method was deprecated and made unnecessary in Ib308190c.

Change-Id: I1729ac0b3a88270a4c2f064187a2472112aaeb1e

4 years agoMerge "Re add wpScrolltop id in EditPage"
jenkins-bot [Fri, 1 Sep 2017 11:18:11 +0000 (11:18 +0000)]
Merge "Re add wpScrolltop id in EditPage"

4 years agoMerge "Deprecate IDatabase::nextSequenceValue()"
jenkins-bot [Fri, 1 Sep 2017 09:39:07 +0000 (09:39 +0000)]
Merge "Deprecate IDatabase::nextSequenceValue()"

4 years agoRe add wpScrolltop id in EditPage
addshore [Fri, 1 Sep 2017 09:35:23 +0000 (12:35 +0300)]
Re add wpScrolltop id in EditPage

Regression from:

Bug: T174723
Change-Id: I2c174eaab822b5990663503ca9258a5811425054

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 1 Sep 2017 07:03:09 +0000 (09:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib2b10d3b2e691568eafcdf2342cd703487013dca

4 years agoMerge "EtcdConfig: allow slashes in config key names"
jenkins-bot [Fri, 1 Sep 2017 03:58:21 +0000 (03:58 +0000)]
Merge "EtcdConfig: allow slashes in config key names"

4 years agoEtcdConfig: allow slashes in config key names
Tim Starling [Fri, 1 Sep 2017 01:53:18 +0000 (11:53 +1000)]
EtcdConfig: allow slashes in config key names

Allowing slashes in config key names allows us to trivially support the
proposed hierarchical structure with a single EtcdConfig object, by
fetching values with the relevant prefixes on startup.

Bug: T156924
Change-Id: Ica0914e61baba9c0462481925be15d79b66dc342

4 years agoresourceloader: Preload base modules request from startup module
Timo Tijhof [Tue, 18 Jul 2017 02:36:25 +0000 (21:36 -0500)]
resourceloader: Preload base modules request from startup module

This allows browsers that support W3C Preload <https://www.w3.org/TR/preload/>,
to start downloading and parsing the second load.php JavaScript request
as soon as the headers of the startup module arrive.

- HTML request, response start.
|\- Discover <script src async> for startup.js, request, response start.
| \ - Startup response end, JS parsing.
|  |
|__|- HTML parsing and rendering yields for async JS execution.
   \- JavaScript inserts <script>, Base-modules request starts. <<<

- HTML request, response start.
|\- Discover <script src async> for startup.js, request, response start
  \ - Base-modules request starts. <<<
|  |- Startup response end, JS parsing.
|  |
|__|- HTML parsing and rendering yields for async JS execution.
   \- JavaScript inserts <script>. (Base-modules req on-going, or done)

On local testing with "Slow 3G" network throttling in Chrome,
this reduced page load time (window.onload, time to interaction for JS)
by about 1 second (from 14s to 13s).
See also https://phabricator.wikimedia.org/T164299#3572231

Bug: T164299
Change-Id: I7047f4ab881947cf3392256087cc5a0cb177dd3a

4 years agoMerge "Revert "Fix link prefix/suffixes around Category and Language links.""
jenkins-bot [Fri, 1 Sep 2017 00:57:54 +0000 (00:57 +0000)]
Merge "Revert "Fix link prefix/suffixes around Category and Language links.""

4 years agoRevert "Fix link prefix/suffixes around Category and Language links."
Tim Starling [Fri, 1 Sep 2017 00:36:41 +0000 (00:36 +0000)]
Revert "Fix link prefix/suffixes around Category and Language links."

This reverts commit c66c9aa5352743b2f87bc4627a1be529c5d18535.

Bug: T174639
Change-Id: Ibf6d3780f384ba8edc80bf28c893f1aee8ce28a8

4 years agoMerge "Move section ID fallbacks into headers themselves"
jenkins-bot [Thu, 31 Aug 2017 21:02:12 +0000 (21:02 +0000)]
Merge "Move section ID fallbacks into headers themselves"

4 years agoMerge "WLFilters: fix server-side tag filtering"
jenkins-bot [Thu, 31 Aug 2017 18:27:57 +0000 (18:27 +0000)]
Merge "WLFilters: fix server-side tag filtering"

4 years agoMerge "WLFilters: wrap Watchlist-details in a div instead of a p"
jenkins-bot [Thu, 31 Aug 2017 17:47:05 +0000 (17:47 +0000)]
Merge "WLFilters: wrap Watchlist-details in a div instead of a p"

4 years agoMerge "WLFilters: adapt to customized watchlist-details"
jenkins-bot [Thu, 31 Aug 2017 17:37:39 +0000 (17:37 +0000)]
Merge "WLFilters: adapt to customized watchlist-details"

4 years agoMerge "EditPage: Make getCheckboxesDefinition() public"
jenkins-bot [Thu, 31 Aug 2017 17:37:35 +0000 (17:37 +0000)]
Merge "EditPage: Make getCheckboxesDefinition() public"

4 years agoWLFilters: wrap Watchlist-details in a div instead of a p
Stephane Bisson [Thu, 31 Aug 2017 16:17:36 +0000 (12:17 -0400)]
WLFilters: wrap Watchlist-details in a div instead of a p

Bug: T172030
Change-Id: I65c50d75b21b3e5d7b69fdecb79c032f5d1d8853

4 years agoEditPage: Make getCheckboxesDefinition() public
Bartosz Dziewoński [Thu, 31 Aug 2017 15:24:08 +0000 (17:24 +0200)]
EditPage: Make getCheckboxesDefinition() public

Bug: T174613
Change-Id: I2dc4104580ac36551ec1ca0deed38ce50e5473ac

4 years agoDeprecate IDatabase::nextSequenceValue()
Brad Jorsch [Thu, 31 Aug 2017 00:27:51 +0000 (20:27 -0400)]
Deprecate IDatabase::nextSequenceValue()

It's often forgotten because MySQL and Sqlite don't use it, the only
users are PostgreSQL and Oracle. And when used, if inserts to multiple
tables are being done it's easy to get the ordering wrong.

This patch reimplements DatabasePostgres::insertId() in terms of PG's
lastval() function, and adds triggers to the Oracle schema to make it
work the same as the other databases.

Bug: T164900
Change-Id: Ib308190c52673a9266c8495a589ae644f9fbefce

4 years agoEditPage: Remove unused variable in getCheckboxesOOUI()
Bartosz Dziewoński [Thu, 31 Aug 2017 14:37:40 +0000 (16:37 +0200)]
EditPage: Remove unused variable in getCheckboxesOOUI()

This was unnecessarily copypasted from getCheckboxes().
The label's 'id' attribute is correctly being set below.

Change-Id: I1557461bfd16c22bb949e26d419e154f80c963d7

4 years agoMerge "RCFilters: Make top links in RecentChanges expand to full-width"
jenkins-bot [Thu, 31 Aug 2017 12:46:17 +0000 (12:46 +0000)]
Merge "RCFilters: Make top links in RecentChanges expand to full-width"

4 years agoWLFilters: adapt to customized watchlist-details
Stephane Bisson [Thu, 31 Aug 2017 12:24:24 +0000 (08:24 -0400)]
WLFilters: adapt to customized watchlist-details

The watchlist-details message is sometimes customized
to add community notices, which makes it much taller.

This fixes the position of the 'edit watchlist' button
so it's always right and bottom aligned regardless of
the size of the watchlist-details section.

Bug: T172030
Change-Id: I8b6b9d799f7929a1d78c8f0e30020a4222fc3bb6

4 years agoUploadFromUrl: Fix typo
Prateek Saxena [Thu, 31 Aug 2017 11:11:06 +0000 (21:11 +1000)]
UploadFromUrl: Fix typo

Change-Id: I4df0db5b4a0df0191e1eaa305fc49f1959c4a354

4 years agoWLFilters: fix server-side tag filtering
Stephane Bisson [Wed, 30 Aug 2017 15:31:41 +0000 (11:31 -0400)]
WLFilters: fix server-side tag filtering

Tag filtering was enabled in the UI but the
backend was not properly wired for it.

Change-Id: I1c50b67b0a4aaddb561e79fdacd9849ffe0ded8c

4 years agoFix typo in ILBFactory::waitForReplication phpdoc
addshore [Thu, 31 Aug 2017 09:54:23 +0000 (12:54 +0300)]
Fix typo in ILBFactory::waitForReplication phpdoc

Change-Id: Ifd79c80af49b03744190e4c5af56c904550fffcd

4 years agoRCFilters: Make top links in RecentChanges expand to full-width
Moriel Schottlender [Wed, 30 Aug 2017 23:27:48 +0000 (16:27 -0700)]
RCFilters: Make top links in RecentChanges expand to full-width

Bug: T174617
Change-Id: Iff4c563b894eaaf713d3818a97928d0342b1ca23

4 years agoDB excepions: consistently declare constructors as public
Chad Horohoe [Wed, 30 Aug 2017 23:44:35 +0000 (16:44 -0700)]
DB excepions: consistently declare constructors as public

Also DBTransactionSizeError::getKey() while we're here

Change-Id: Ic76abf3ca0bf74dd96018d67da466365957bf3b1

4 years agoFix various PostgreSQL failures
Brad Jorsch [Wed, 30 Aug 2017 19:51:50 +0000 (15:51 -0400)]
Fix various PostgreSQL failures

* Fix schema for image_comment_temp.
* Provide values in CommentStoreTest::provideInsertRoundTrip() for
  columns where the PG schema doesn't have a default value but the MySQL
  schema does.
* Call nextSequenceValue() from CommentStoreTest::testInsertRoundTrip().
* Correctly handle $options being the string 'FOR UPDATE' in
* Correctly handle the initial table in DatabasePostgres::selectSQLText() FOR
  UPDATE mangling.
* Correctly handle aliases in DatabasePostgres::selectSQLText() FOR
  UPDATE mangling.

Tests in PG are still going to be broken thanks to the fact that
nextSequenceValue() and insertId() can't be separated by another
nextSequenceValue()/insertId() pair. That should be taken care of by

Change-Id: Ia770a003ca9170ab8bcc1436d8afe30700e00ada

4 years agoWLFilters: describe how unseen changes should look
Stephane Bisson [Wed, 30 Aug 2017 20:05:42 +0000 (16:05 -0400)]
WLFilters: describe how unseen changes should look

Makes the unseen changes description customizable
based on whether or not the beta feature is enabled.

Bug: T172030
Change-Id: I0cef7e5fb261e12f3ca069e7409f3aea3fc874cf

4 years agoMerge "Only do one query for page ids in PageProps::getGoodIDs"
jenkins-bot [Wed, 30 Aug 2017 19:42:27 +0000 (19:42 +0000)]
Merge "Only do one query for page ids in PageProps::getGoodIDs"

4 years agoMerge "Fix highlight display for enhanced mode"
jenkins-bot [Wed, 30 Aug 2017 19:05:16 +0000 (19:05 +0000)]
Merge "Fix highlight display for enhanced mode"

4 years agoMerge "WLFilters: convert 'edit watchlist' button to new UX"
jenkins-bot [Wed, 30 Aug 2017 18:39:20 +0000 (18:39 +0000)]
Merge "WLFilters: convert 'edit watchlist' button to new UX"

4 years agoMerge "Batch request titles for cdn purge from db"
jenkins-bot [Wed, 30 Aug 2017 18:38:11 +0000 (18:38 +0000)]
Merge "Batch request titles for cdn purge from db"

4 years agoOnly do one query for page ids in PageProps::getGoodIDs
Marius Hoch [Wed, 30 Aug 2017 18:32:19 +0000 (20:32 +0200)]
Only do one query for page ids in PageProps::getGoodIDs

Change-Id: I0d1cff3173d54de0b8fadb5bf9766789ffe030a4

4 years agoFix highlight display for enhanced mode
Moriel Schottlender [Thu, 3 Aug 2017 01:29:25 +0000 (18:29 -0700)]
Fix highlight display for enhanced mode

Bug: T170875
Change-Id: Ibd7d447aba1ae5576ea637a2d5ef06cb3f622b26

4 years agoBatch request titles for cdn purge from db
Erik Bernhardson [Tue, 29 Aug 2017 16:30:14 +0000 (09:30 -0700)]
Batch request titles for cdn purge from db

Xenon shows a significant amount of time is spent individually fetching
the content model for titles being purged. It's probably not a huge
improvement but lets fetch them all in one go instead of lazily as

Change-Id: I71af6f13c84e740c1367617d7a51210501363b33

4 years agoWLFilters: convert 'edit watchlist' button to new UX
Stephane Bisson [Mon, 28 Aug 2017 20:45:21 +0000 (16:45 -0400)]
WLFilters: convert 'edit watchlist' button to new UX

Bug: T172030
Change-Id: Ifcde40c66fbb6543d4f2aebfc8499c03533b8b91

4 years agoMerge "RCFilters: rephrase the feedback link text"
jenkins-bot [Wed, 30 Aug 2017 18:00:38 +0000 (18:00 +0000)]
Merge "RCFilters: rephrase the feedback link text"

4 years agoMerge "Fix index in PostgreSQL schema"
jenkins-bot [Wed, 30 Aug 2017 16:54:15 +0000 (16:54 +0000)]
Merge "Fix index in PostgreSQL schema"

4 years agoMerge "Prefix comment table when adding indexes"
jenkins-bot [Wed, 30 Aug 2017 16:54:12 +0000 (16:54 +0000)]
Merge "Prefix comment table when adding indexes"

4 years agoPrefix comment table when adding indexes
Reedy [Wed, 30 Aug 2017 15:33:14 +0000 (16:33 +0100)]
Prefix comment table when adding indexes

Change-Id: Ie87d2ef68050a402d6c81ca98cc7402f7c5f14aa
Follows-Up: Ic3a434c061ed6e443ea072bc62dda09acbeeed7f

4 years agoMerge "Use HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE"
jenkins-bot [Wed, 30 Aug 2017 16:32:58 +0000 (16:32 +0000)]
Merge "Use HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE"

4 years agoFix index in PostgreSQL schema
Brad Jorsch [Wed, 30 Aug 2017 16:27:33 +0000 (12:27 -0400)]
Fix index in PostgreSQL schema

Followup to Ic3a434c06

Change-Id: I68966726f91b1854e845b2a0757b599644749b4f

4 years agoTurn Special:NewFiles list of media types into list of checkboxes
Matthias Mullie [Wed, 30 Aug 2017 13:29:26 +0000 (15:29 +0200)]
Turn Special:NewFiles list of media types into list of checkboxes

It's a pretty short, finite list of media types, so we don't need
it to be this dropdown thingy.
Just a list of checkboxes is more convenient because it'll be
easy to see which of the media types are missing/not selected.

Bug: T174518
Change-Id: Ice768f0808eb9d70f682697f48272795417bbe74

4 years agoMerge "RCFilters: Include invert param when reading default saved query"
jenkins-bot [Wed, 30 Aug 2017 12:08:18 +0000 (12:08 +0000)]
Merge "RCFilters: Include invert param when reading default saved query"

4 years agoMerge "SpecialRecentchanges: Restore ability to use language links in 'recentchangest...
jenkins-bot [Wed, 30 Aug 2017 07:26:43 +0000 (07:26 +0000)]
Merge "SpecialRecentchanges: Restore ability to use language links in 'recentchangestext' message"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 30 Aug 2017 06:42:52 +0000 (08:42 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia9564e3135fe8cc5ba61588cd921180af7489167

4 years agoparserTests: Improve class name guessing for PHPUnit
Kunal Mehta [Sat, 8 Jul 2017 07:14:13 +0000 (00:14 -0700)]
parserTests: Improve class name guessing for PHPUnit

Since we know the extension name, actually use it instead of trying to
guess it based on the directory name.

The new directory layout for autodiscovery encourages "tests/parser" so
the directory one level up is unlikely to be the extension name.

Change-Id: I352944a84197acba6fe425b6044b17c520e263d7

4 years agoAdd `comment` table and code to start using it
Brad Jorsch [Tue, 6 Jun 2017 17:39:14 +0000 (13:39 -0400)]
Add `comment` table and code to start using it

A subsequent patch will remove the old columns.

Bug: T166732
Change-Id: Ic3a434c061ed6e443ea072bc62dda09acbeeed7f

4 years agoRCFilters: Include invert param when reading default saved query
Moriel Schottlender [Tue, 29 Aug 2017 22:04:45 +0000 (15:04 -0700)]
RCFilters: Include invert param when reading default saved query

Bug: T174506
Change-Id: Ibca0e0c80d8069ac3e73533f1f342c2946cce6ca

4 years agoMerge "WLFilters: Use displaysOnUnstructuredUi instead of isVisible"
jenkins-bot [Tue, 29 Aug 2017 21:11:58 +0000 (21:11 +0000)]
Merge "WLFilters: Use displaysOnUnstructuredUi instead of isVisible"

4 years agoRCFilters: rephrase the feedback link text
Stephane Bisson [Tue, 29 Aug 2017 20:54:33 +0000 (16:54 -0400)]
RCFilters: rephrase the feedback link text

It now works fine whether the filters you are using
are in beta (WL) or not (RC, soon).

Bug: T174411
Change-Id: I1714d70f3f1016cba2d06ea0c11ca7c664735905

4 years agoMerge "Add @since tag to Title::canHaveTalkPage()"
jenkins-bot [Tue, 29 Aug 2017 20:14:03 +0000 (20:14 +0000)]
Merge "Add @since tag to Title::canHaveTalkPage()"

4 years agoAvoid using deprecated Title::canTalk()
Kunal Mehta [Tue, 29 Aug 2017 19:36:33 +0000 (12:36 -0700)]
Avoid using deprecated Title::canTalk()

Change-Id: Ibd224f9de595435524e683262882c9ebf2761abf

4 years agoAdd @since tag to Title::canHaveTalkPage()
Kunal Mehta [Tue, 29 Aug 2017 19:28:39 +0000 (12:28 -0700)]
Add @since tag to Title::canHaveTalkPage()

It was added in f8ac44cca56.

Change-Id: Iee3e074f5108a905b66c52305978c99b2604f2cd

4 years agoMerge "Rename IP::isValidBlock to isValidRange, deprecating the former"
jenkins-bot [Tue, 29 Aug 2017 18:50:15 +0000 (18:50 +0000)]
Merge "Rename IP::isValidBlock to isValidRange, deprecating the former"

4 years agoMerge "Get better error message for duplicate names in MagicWordArray"
jenkins-bot [Tue, 29 Aug 2017 18:50:11 +0000 (18:50 +0000)]
Merge "Get better error message for duplicate names in MagicWordArray"

4 years agoRename IP::isValidBlock to isValidRange, deprecating the former
MusikAnimal [Wed, 23 Aug 2017 00:07:35 +0000 (20:07 -0400)]
Rename IP::isValidBlock to isValidRange, deprecating the former

This is to remove confusion with the MediaWiki Block class.

All instances of isValidBlock within MediaWiki core have been updated.

Usage of this function will be more widespread with this patch:

Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e067

4 years agoConvert UNIQUE keys into PRIMARY KEY
Reedy [Fri, 4 Aug 2017 12:43:50 +0000 (14:43 +0200)]
Convert UNIQUE keys into PRIMARY KEY

WMF DBAs have been doing a massive effort to convert UNIQUE KEYS into

Having a PK is essential to do maintenance, specially on large tasks.
By not having a PK it is impossible to add it in a safe way if not done
directly on the master.

Having a PK means that we can easily change the PK into another one if
needed in the future. The ones we chose might not be the best ones, but
will allow us to get them changed.

Bug: T172514
Change-Id: Id635297838938c7c5dfe65d45285a4d16d65152d

4 years agoUse HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE
Suriyaa Kudo [Tue, 29 Aug 2017 15:07:47 +0000 (17:07 +0200)]
Use HTTPS protocol in resources/src/mediawiki.toolbar/images/ksh/LICENSE

Change-Id: I2a5eb6d09322d4bd93d901d30613bc6ed63a7363

4 years agoMerge "RCFilters: Target pushPin icon for size, not all icons"
jenkins-bot [Tue, 29 Aug 2017 12:27:26 +0000 (12:27 +0000)]
Merge "RCFilters: Target pushPin icon for size, not all icons"

4 years agoWLFilters: Use displaysOnUnstructuredUi instead of isVisible
Stephane Bisson [Tue, 29 Aug 2017 12:05:17 +0000 (08:05 -0400)]
WLFilters: Use displaysOnUnstructuredUi instead of isVisible

Follow up I3e48a9f2d9b70f0b9f6d7c6329db9c8e8001ee49

Bug: T171134
Change-Id: Ife0b10265c34d2dfd9a4d234f4a5409382530cc9

4 years agoMerge "Run Selenium tests for skins"
jenkins-bot [Tue, 29 Aug 2017 10:44:35 +0000 (10:44 +0000)]
Merge "Run Selenium tests for skins"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 29 Aug 2017 06:13:33 +0000 (08:13 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I31af5076f228c31072f4fca54e049eb4cf54feb0

4 years agoMerge "WLFilters: set default values"
jenkins-bot [Tue, 29 Aug 2017 00:50:06 +0000 (00:50 +0000)]
Merge "WLFilters: set default values"

4 years agoRCFilters: Target pushPin icon for size, not all icons
Moriel Schottlender [Mon, 28 Aug 2017 22:31:23 +0000 (15:31 -0700)]
RCFilters: Target pushPin icon for size, not all icons


Bug: T173264
Change-Id: Icb92c55a5b067d77138bae93f4db96309c72a223

4 years agoEnable mediawiki.hlist on mobile
jdlrobson [Mon, 28 Aug 2017 21:14:37 +0000 (16:14 -0500)]
Enable mediawiki.hlist on mobile

Bug: T42062
Change-Id: Iee059a6605cf12a073954378f49ddc721a7e016a

4 years agoRCFilters: Minimize saved query before comparison
Moriel Schottlender [Mon, 28 Aug 2017 20:06:31 +0000 (13:06 -0700)]
RCFilters: Minimize saved query before comparison

Bug: T174193
Change-Id: I8e9345e8899fd27565930896e62c4d3be235ad58

4 years agoMerge "EditPage: Remove temporary OOUI page class name"
jenkins-bot [Mon, 28 Aug 2017 18:45:01 +0000 (18:45 +0000)]
Merge "EditPage: Remove temporary OOUI page class name"

4 years agoMerge "Making sister search sidebar links blue"
jenkins-bot [Mon, 28 Aug 2017 18:11:40 +0000 (18:11 +0000)]
Merge "Making sister search sidebar links blue"

4 years agoEnable mediawiki.special.userlogin.common.styles on mobile and allow skins to style it
jdlrobson [Fri, 18 Aug 2017 19:34:00 +0000 (14:34 -0500)]
Enable mediawiki.special.userlogin.common.styles on mobile and allow skins to style it

Depends-On: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
Bug: T173597
Change-Id: I36e596e4d6060ef168464732028cd0dcbf21d0f8

4 years agoWLFilters: set default values
Stephane Bisson [Mon, 21 Aug 2017 19:28:23 +0000 (15:28 -0400)]
WLFilters: set default values

* Respect different default values for 'limit' and 'day'
  in RC and WL.

* Make 'latestrevision' respect 'watchlistextended'

Introducing 2 properties to ChangesListBooleanFilter
* activeValue: The value that defines when a filter is active.
  Most filters are active when they are set to 'true' but
  'extended' has no effect when it is 'true' and applies
  filtering when it is set to false.

* isVisible: Whether this filter is visible anywhere.
  'extended' is not visible in the legacy form but
  it is activated from preference or URL. When
  understanding form submission, it should not be assume
  to be 'false' when not present in the request.

Bug: T171134
Change-Id: I3e48a9f2d9b70f0b9f6d7c6329db9c8e8001ee49

4 years agoMerge "Consistent behavior of read-only reason"
jenkins-bot [Mon, 28 Aug 2017 16:36:24 +0000 (16:36 +0000)]
Merge "Consistent behavior of read-only reason"

4 years agoSpecialRecentchanges: Restore ability to use language links in 'recentchangestext...
Bartosz Dziewoński [Mon, 28 Aug 2017 16:12:14 +0000 (18:12 +0200)]
SpecialRecentchanges: Restore ability to use language links in 'recentchangestext' message

Bug: T172461
Change-Id: I7b660c78f410f09815a82810824d56cb7a477280

4 years agoMerge "RCFilters: Adjust highlight for seen/unseen states in Watchlist"
jenkins-bot [Mon, 28 Aug 2017 16:05:56 +0000 (16:05 +0000)]
Merge "RCFilters: Adjust highlight for seen/unseen states in Watchlist"

4 years agoConsistent behavior of read-only reason
Florian Schmidt [Sat, 19 Aug 2017 16:21:40 +0000 (18:21 +0200)]
Consistent behavior of read-only reason

Before this commit, the reason set in the global $wgReadOnly was differently handled
on different special pages. While on most of them, like Special:Upload, the reason
is allowed to have HTML, which can be used in Wikitext, too, Special:CreateAccount
always outputted an escaped version of this reason.

Most special pages uses the ReadOnlyError exception to print a read-only error,
however, AuthManager uses Status objects to communicate between the backend and the
frontend. Therefore the same message and parameters were wrapped in a Status object
and, in the frontend, directly passed to the constructor of ErrorPageError. Unfortunately,
Status::getMessage() escapes the parameters of a message, which is the reason, why the
wiki is read-only. To bypass this restriction, AuthManager now creates a Message object
directly, does not escape the reason, and uses the resulting object to create a Status
object from.

Now the reason is not escaped on Special:CreateAccount anymore, like on most other
special pages.

The read-only message on the protection form is, also before this commit, not escaped and
already displayed correctly, as the read-only is checked in the constructor of the
protection form already and, if the Wiki is read only, handled as a permission error and
already displayed correctly. This commit fixes the behavior of WikiPage in case of it's used
somewhere else, subclassed or if the check in the frontend will be removed and the Status of
WikiPage will be used.

Bug: T157036
Change-Id: Idbfe556fcb90f8bda8fae9d728ca9dee5ea02f67

4 years agoRCFilters: Adjust highlight for seen/unseen states in Watchlist
Moriel Schottlender [Sat, 26 Aug 2017 01:02:48 +0000 (18:02 -0700)]
RCFilters: Adjust highlight for seen/unseen states in Watchlist

Bug: T171235
Change-Id: I33d059d2be83e4730e6dc82f689f49a514286874

4 years agoMerge "Add Atayal (tay) language"
jenkins-bot [Mon, 28 Aug 2017 13:33:06 +0000 (13:33 +0000)]
Merge "Add Atayal (tay) language"