lhc/web/wiklou.git
5 years agoUpdate composer/spdx-licenses to 1.4.0 and mediawiki/mediawiki-codesniffer to 21.0.0
Reedy [Thu, 26 Jul 2018 16:31:49 +0000 (17:31 +0100)]
Update composer/spdx-licenses to 1.4.0 and mediawiki/mediawiki-codesniffer to 21.0.0

https://github.com/composer/spdx-licenses/compare/1.3.0...1.4.0

Change-Id: I39f7a1310455159866bfed5224536e800befec0d

5 years agoMerge "Upstream EasyDeflate library from VisualEditor"
jenkins-bot [Thu, 26 Jul 2018 15:06:41 +0000 (15:06 +0000)]
Merge "Upstream EasyDeflate library from VisualEditor"

5 years agoMerge "Deprecate public access to some DifferenceEngine properties"
jenkins-bot [Thu, 26 Jul 2018 12:06:05 +0000 (12:06 +0000)]
Merge "Deprecate public access to some DifferenceEngine properties"

5 years agoDeprecate public access to some DifferenceEngine properties
Gergő Tisza [Wed, 11 Jul 2018 08:54:58 +0000 (10:54 +0200)]
Deprecate public access to some DifferenceEngine properties

These had no business being public in the first place and there is
no usage in Gerrit. In case something does use them, it will probably
be broken by the refactoring that's soon to come, so the deprecation
warning makes it easier to figure out where the problem lies.

Change-Id: I72ba5cfbf91f4af16028ba4f8619df6a7168a786

5 years agoUse setContentLang() instead of setMwGlobals()
Aryeh Gregor [Wed, 25 Jul 2018 14:57:23 +0000 (17:57 +0300)]
Use setContentLang() instead of setMwGlobals()

This changes behavior in some tests by making them set $wgLanguageCode
as well as $wgContLang, but that seems like a good thing.

Bug: T200246
Change-Id: I936888f46ff9fefe2707efba837e2ce3a7ca5e3f

5 years agoMerge "Use 'default' instead of 'value' in HTMLTextField"
jenkins-bot [Thu, 26 Jul 2018 09:05:18 +0000 (09:05 +0000)]
Merge "Use 'default' instead of 'value' in HTMLTextField"

5 years agoMerge "Add helper trait for deprecating properties"
jenkins-bot [Wed, 25 Jul 2018 22:49:39 +0000 (22:49 +0000)]
Merge "Add helper trait for deprecating properties"

5 years agoMake MessageCache use APC for big messages
Aaron Schulz [Mon, 25 Jun 2018 12:16:15 +0000 (13:16 +0100)]
Make MessageCache use APC for big messages

Bug: T118893
Change-Id: I418d0ca490911d7ee4213fe1728cfbc637ef8b10

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 25 Jul 2018 19:57:29 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I69852319aa363902ca532563bee3938103e1be41

5 years agoUse 'default' instead of 'value' in HTMLTextField
Jayprakash12345 [Wed, 25 Jul 2018 19:38:16 +0000 (01:08 +0530)]
Use 'default' instead of 'value' in HTMLTextField

Bug: T193087
Change-Id: I631970797a778caa77d3605e0a5b8ca00e2cb56e

5 years agoMerge "Make the 'other' option superessable in getSuggestedDurations"
jenkins-bot [Wed, 25 Jul 2018 17:06:06 +0000 (17:06 +0000)]
Merge "Make the 'other' option superessable in getSuggestedDurations"

5 years agoMerge "Follow-up 9742d569b: Replace accidental \t in i18n with a space"
jenkins-bot [Wed, 25 Jul 2018 16:23:13 +0000 (16:23 +0000)]
Merge "Follow-up 9742d569b: Replace accidental \t in i18n with a space"

5 years agoMerge "Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional"
jenkins-bot [Wed, 25 Jul 2018 16:22:22 +0000 (16:22 +0000)]
Merge "Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional"

5 years agoDeprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional
Bill Pirkle [Tue, 17 Jul 2018 16:51:36 +0000 (11:51 -0500)]
Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional

Clarify and simplify exception output by deprecating
$wgShowSQLErrors and wgShowDBErrorBacktrace.
$wgShowExceptionDetails will now control most related output.
$wgShowHostnames will now solely control output of
MWExceptionRenderer::reportOutageHTML.

Bug: T165768
Change-Id: Idead2c11c499463dfa6293c3d4b33be3bde92e1a

5 years agoFollow-up 9742d569b: Replace accidental \t in i18n with a space
James D. Forrester [Wed, 25 Jul 2018 15:34:51 +0000 (08:34 -0700)]
Follow-up 9742d569b: Replace accidental \t in i18n with a space

Change-Id: Id8ad5916b7dd59a078fb600c7998e41f1b8abd3c

5 years agoMerge "Make load* methods of DifferenceEngine idempotent"
jenkins-bot [Wed, 25 Jul 2018 15:33:48 +0000 (15:33 +0000)]
Merge "Make load* methods of DifferenceEngine idempotent"

5 years agoMerge "cache: Minor docs for MessageCache interaction with WANObjectCache"
jenkins-bot [Wed, 25 Jul 2018 14:52:44 +0000 (14:52 +0000)]
Merge "cache: Minor docs for MessageCache interaction with WANObjectCache"

5 years agocache: Minor docs for MessageCache interaction with WANObjectCache
Timo Tijhof [Sun, 22 Jul 2018 23:52:41 +0000 (00:52 +0100)]
cache: Minor docs for MessageCache interaction with WANObjectCache

Follows-up 04bc03a29a.

Change-Id: I8fb810fc2e08277bb64fa18595483a2161cfb1cc

5 years agoMerge "Fallback language for Santali should be English"
jenkins-bot [Wed, 25 Jul 2018 11:59:58 +0000 (11:59 +0000)]
Merge "Fallback language for Santali should be English"

5 years agoMerge "ApiBase: Use prefixed parameter name for 'missingparam' error"
jenkins-bot [Wed, 25 Jul 2018 05:29:12 +0000 (05:29 +0000)]
Merge "ApiBase: Use prefixed parameter name for 'missingparam' error"

5 years agoMerge "Make OutputPage::mPagetitle private"
jenkins-bot [Wed, 25 Jul 2018 04:40:53 +0000 (04:40 +0000)]
Merge "Make OutputPage::mPagetitle private"

5 years agoMerge "objectcache: improve logging and error handling in BagOStuff"
jenkins-bot [Wed, 25 Jul 2018 04:16:18 +0000 (04:16 +0000)]
Merge "objectcache: improve logging and error handling in BagOStuff"

5 years agoFallback language for Santali should be English
Martin Urbanec [Tue, 24 Jul 2018 19:47:50 +0000 (21:47 +0200)]
Fallback language for Santali should be English

Bug: T200290
Change-Id: I65005b8b31bd022c7978628f69c5d56d735063e3

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 24 Jul 2018 19:53:03 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Idbc346a6c0d5bf2bdc2278bc2ef3440579500dc7

5 years agoobjectcache: improve logging and error handling in BagOStuff
Aaron Schulz [Thu, 12 Jul 2018 15:26:13 +0000 (16:26 +0100)]
objectcache: improve logging and error handling in BagOStuff

Bug: T198239
Bug: T199383
Change-Id: I0b4110396d03b98e83a7b614caf57d7e7c284361

5 years agoMerge "PageArchive: Pass correct overrides to newRevisionFromArchiveRow()"
jenkins-bot [Tue, 24 Jul 2018 16:18:25 +0000 (16:18 +0000)]
Merge "PageArchive: Pass correct overrides to newRevisionFromArchiveRow()"

5 years agoMerge "Avoid a redirect loop when the request URL is not normalized"
jenkins-bot [Tue, 24 Jul 2018 16:13:39 +0000 (16:13 +0000)]
Merge "Avoid a redirect loop when the request URL is not normalized"

5 years agoMake the 'other' option superessable in getSuggestedDurations
Huji Lee [Mon, 30 Apr 2018 01:38:42 +0000 (21:38 -0400)]
Make the 'other' option superessable in getSuggestedDurations

Bug: T193364
Change-Id: Ic2dbc961f7eebad11da53724b9cce2f804ffad39

5 years agoMake OutputPage::mPagetitle private
Aryeh Gregor [Tue, 24 Jul 2018 13:38:44 +0000 (16:38 +0300)]
Make OutputPage::mPagetitle private

Code search revealed only one outside access, which I've submitted a patch for.

Depends-On: I001deecad241b091070483d882088d2d6361ed5a
Change-Id: I0f7e565f4eacc1074c619772b2d11a47a05e3584

5 years agothiemowmde's legal name changed
Thiemo Kreuz (WMDE) [Tue, 24 Jul 2018 06:02:55 +0000 (06:02 +0000)]
thiemowmde's legal name changed

I was a co-author only, and my contribution was not really
noteworthy, so I choose to remove the outdated name (in this
case only).

Change-Id: I9d9592d5b114adae633f6a4bdac2dd60f329bd7a

5 years agoMerge "LogEventsList: Correct typo"
jenkins-bot [Tue, 24 Jul 2018 01:54:31 +0000 (01:54 +0000)]
Merge "LogEventsList: Correct typo"

5 years agoMerge "$wgHttpsPort should only be used in very special cases"
jenkins-bot [Tue, 24 Jul 2018 01:13:32 +0000 (01:13 +0000)]
Merge "$wgHttpsPort should only be used in very special cases"

5 years agoMerge "LogPager: Add backwards-compatibility for hide_[type]_log URL params"
jenkins-bot [Mon, 23 Jul 2018 20:55:21 +0000 (20:55 +0000)]
Merge "LogPager: Add backwards-compatibility for hide_[type]_log URL params"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 23 Jul 2018 20:08:57 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I8b632d4052c2634867c7d498305cf287d2fc58c9

5 years agoRevert "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"
Greg Grossmeier [Mon, 23 Jul 2018 16:45:31 +0000 (16:45 +0000)]
Revert "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"

This reverts commit 8380f0173e79b66f0e2afd6c49cd88afb9f4f6f3.

Reason for revert: Caused T199941

Bug: T199941
Change-Id: I93af756a2d70d6bc91f828fe6ac19bf10ca8788f

5 years agoMerge "Revert "Accept BCP 47 codes as aliases for nonstandard variants""
jenkins-bot [Mon, 23 Jul 2018 17:22:32 +0000 (17:22 +0000)]
Merge "Revert "Accept BCP 47 codes as aliases for nonstandard variants""

5 years agoRevert "Accept BCP 47 codes as aliases for nonstandard variants"
Greg Grossmeier [Mon, 23 Jul 2018 16:44:55 +0000 (16:44 +0000)]
Revert "Accept BCP 47 codes as aliases for nonstandard variants"

This reverts commit 0818070c59eb4e8330496796b943951c01c7a573.

Reason for revert: Caused T199941

Bug: T199941
Change-Id: I24c178eb33890477de79cbb3122861c140578011

5 years agoMerge "LogEventsList: Use DerivativeContext"
jenkins-bot [Mon, 23 Jul 2018 16:28:45 +0000 (16:28 +0000)]
Merge "LogEventsList: Use DerivativeContext"

5 years agoLogEventsList: Correct typo
Bartosz Dziewoński [Mon, 23 Jul 2018 16:18:04 +0000 (18:18 +0200)]
LogEventsList: Correct typo

The parameter to getTitleInputDesc() is actually unused, so this was
not breaking anything.

Change-Id: Ia301faf511e30b4fc4542ccb80b24cf807cf731c

5 years agoApiBase: Use prefixed parameter name for 'missingparam' error
Brad Jorsch [Mon, 23 Jul 2018 13:22:23 +0000 (09:22 -0400)]
ApiBase: Use prefixed parameter name for 'missingparam' error

Similar errors use the prefixed parameter name, this one should too.

Bug: T200155
Change-Id: Ia14d6a9c457af06e72428c1eae14bd3849b4595a

5 years agoPageArchive: Pass correct overrides to newRevisionFromArchiveRow()
Brad Jorsch [Mon, 23 Jul 2018 12:44:02 +0000 (08:44 -0400)]
PageArchive: Pass correct overrides to newRevisionFromArchiveRow()

Revision::newFromArchiveRow took 'page' as an override for ar_page_id,
while RevisionStore::newRevisionFromArchiveRow() needs 'page_id'.

Thanks to sanity checks elsewhere in RevisionStore, this mistaken
override causes an exception to be thrown rather than undeleted
revisions potentially pointing to the wrong page.

Bug: T200072
Change-Id: I9d7543866c674f4d8aea9ec00fcc15cbf616ca66

5 years agoLogEventsList: Use DerivativeContext
Prateek Saxena [Mon, 23 Jul 2018 04:22:36 +0000 (09:52 +0530)]
LogEventsList: Use DerivativeContext

Bug: T200136
Change-Id: Ie2b7753684dc0257b0b53d9c9314feeb14d99182

5 years agoMerge "HTMLMultiSelectField: Improve compat with GET forms with no wpFormIdentifier"
jenkins-bot [Mon, 23 Jul 2018 02:55:53 +0000 (02:55 +0000)]
Merge "HTMLMultiSelectField: Improve compat with GET forms with no wpFormIdentifier"

5 years agoAdded non-parallel fallback to MultiHttpClient when curl is unavailable
Bill Pirkle [Thu, 12 Jul 2018 22:07:54 +0000 (17:07 -0500)]
Added non-parallel fallback to MultiHttpClient when curl is unavailable

If the curl extension is not available, fall back to the existing
HttpRequestFactory and associated classes. Also added related phpunit tests.

Bug: T139169
Change-Id: I2f9d4acbb491bce28d7105e124c5cee7e16e86d7

5 years agoMerge "Make MessageCache use getWithSetCallback() for big messages"
jenkins-bot [Sun, 22 Jul 2018 23:59:18 +0000 (23:59 +0000)]
Merge "Make MessageCache use getWithSetCallback() for big messages"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 22 Jul 2018 19:52:41 +0000 (21:52 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I93c905909b83a89898922e241610275186e5346b

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 21 Jul 2018 19:52:53 +0000 (21:52 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I848c703ad10f39827730fcdacdd83b4ad47b346d

5 years agoMerge "Explicitly mark Skin::makeVariablesScript() public"
jenkins-bot [Sat, 21 Jul 2018 00:55:09 +0000 (00:55 +0000)]
Merge "Explicitly mark Skin::makeVariablesScript() public"

5 years agoMerge "Fix octal escape sequence overflow in FiltersTest.php"
jenkins-bot [Fri, 20 Jul 2018 20:37:45 +0000 (20:37 +0000)]
Merge "Fix octal escape sequence overflow in FiltersTest.php"

5 years agoExplicitly mark Skin::makeVariablesScript() public
Reedy [Fri, 20 Jul 2018 20:02:40 +0000 (21:02 +0100)]
Explicitly mark Skin::makeVariablesScript() public

Remove else. If contains an unconditional return

Change-Id: I57a04339395d947dffbc3595d321106d4fd8256c

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 20 Jul 2018 19:53:15 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I01a747cba68c60850761ac5dcef992bcebaaf6b5

5 years agoMerge "Send API timing to statsd for all requests, not just writes"
jenkins-bot [Fri, 20 Jul 2018 15:13:48 +0000 (15:13 +0000)]
Merge "Send API timing to statsd for all requests, not just writes"

5 years agoAdd maintenance script for resetting login/signup throttle
Gergő Tisza [Mon, 28 May 2018 16:25:36 +0000 (16:25 +0000)]
Add maintenance script for resetting login/signup throttle

Bug: T194506
Change-Id: I6dda5f516ba47a452e438946379fcb696c8c87f9

5 years agoMerge "filebackend: let any specific backend value of "readOnly" override the default"
jenkins-bot [Fri, 20 Jul 2018 10:51:35 +0000 (10:51 +0000)]
Merge "filebackend: let any specific backend value of "readOnly" override the default"

5 years agoMerge "JobQueueGroup: Allow readOnlyReason to be specified per JQ type"
jenkins-bot [Fri, 20 Jul 2018 10:30:37 +0000 (10:30 +0000)]
Merge "JobQueueGroup: Allow readOnlyReason to be specified per JQ type"

5 years agoMerge "Install cache/integration-tests as require-dev"
jenkins-bot [Fri, 20 Jul 2018 10:21:48 +0000 (10:21 +0000)]
Merge "Install cache/integration-tests as require-dev"

5 years agoInstall cache/integration-tests as require-dev
addshore [Wed, 18 Jul 2018 10:47:27 +0000 (12:47 +0200)]
Install cache/integration-tests as require-dev

Bug: T199440
Change-Id: I1e50d7202a5d02088319ec9e90e0136519cba1ce

5 years agoGlobalFunctions: use a closure instead of polluting global namespace
Max Semenik [Fri, 20 Jul 2018 06:54:49 +0000 (23:54 -0700)]
GlobalFunctions: use a closure instead of polluting global namespace

Change-Id: Ia587008de75a8bde90ad45d4932284f0b6401845

5 years agoSend API timing to statsd for all requests, not just writes
Tim Starling [Fri, 20 Jul 2018 06:49:49 +0000 (16:49 +1000)]
Send API timing to statsd for all requests, not just writes

The rate will be about 8k req/s, whereas currently graphite1001
receives about 350k metric updates per second, so we would expect
this to increase statsd load by about 2%.

This would have been very helpful in diagnosing API cluster overload
incidents such as the one on July 11.

Change-Id: I0a248e1bcec05915d98ec735f4cfb9800e64412d

5 years agoMerge "language: Document sources of data and example usage"
jenkins-bot [Fri, 20 Jul 2018 06:12:44 +0000 (06:12 +0000)]
Merge "language: Document sources of data and example usage"

5 years agoMerge "resourceloader: CSSMin::getLocalFileReferences now strips anchors"
jenkins-bot [Fri, 20 Jul 2018 04:59:31 +0000 (04:59 +0000)]
Merge "resourceloader: CSSMin::getLocalFileReferences now strips anchors"

5 years agoMerge "Language::listToText: Avoid PHP warnings from E_STRICT"
jenkins-bot [Fri, 20 Jul 2018 04:56:09 +0000 (04:56 +0000)]
Merge "Language::listToText: Avoid PHP warnings from E_STRICT"

5 years agoresourceloader: CSSMin::getLocalFileReferences now strips anchors
Antoine Musso [Tue, 17 Jul 2018 15:59:17 +0000 (17:59 +0200)]
resourceloader: CSSMin::getLocalFileReferences now strips anchors

When processing:

  url( 'foo.svg#anchors' )

getLocalFileReferences() would yield a file 'foo.svg#anchors'. It might
occur with upstream libraries, such as WikiFonts used by the Refreshed
skin.

When a path is found, strip the anchor entirely. Skip the case if that
results in an empty file.

remap() would properly skip the behavior "#default#', also skip url that
are solely an anchor such as '#other'.

Add a few test cases to cover CSSMin::getLocalFileReferences and cover
anchors usage in CSSMin::remap.

Bug: T115436
Change-Id: I1749ddc2b89021807f42d64131931ad7a99a7b43

5 years agolanguage: Document sources of data and example usage
Timo Tijhof [Fri, 20 Jul 2018 03:06:28 +0000 (20:06 -0700)]
language: Document sources of data and example usage

Change-Id: I0c72069d010285d9b88ff83bc1478410961065d3

5 years agoparserTests: re-enable save parse and fix MCR errors
Tim Starling [Fri, 20 Jul 2018 02:03:48 +0000 (12:03 +1000)]
parserTests: re-enable save parse and fix MCR errors

* Re-enable parse on save as requested in T159014, instead hide
  the feature behind an option.
* Add the MCR tables to the list of tables that need to be cloned. Fixes
  unconditional exception.
* Fix some undefined member variables, remove assignment to unused
  variable $this->databaseSetupDone.

Bug: T159014
Change-Id: I6be577ebcbadeb4e08079a82543d521fc2bb5948

5 years agoLogPager: Add backwards-compatibility for hide_[type]_log URL params
Prateek Saxena [Thu, 19 Jul 2018 05:02:24 +0000 (10:32 +0530)]
LogPager: Add backwards-compatibility for hide_[type]_log URL params

Also, the $default value in LogEventsList#getFiltersDesc was not
being generated properly and would have always been an empty array.

Bug: T199856
Change-Id: Id286c76259406521f12cda67a4a715032e022637

5 years agoMerge "Convert Title::getTitleCache() to using MapCacheLRU (again)"
jenkins-bot [Fri, 20 Jul 2018 00:06:16 +0000 (00:06 +0000)]
Merge "Convert Title::getTitleCache() to using MapCacheLRU (again)"

5 years agoMerge "ApiMain: Always create a new printer in getPrinterByName()"
jenkins-bot [Fri, 20 Jul 2018 00:06:10 +0000 (00:06 +0000)]
Merge "ApiMain: Always create a new printer in getPrinterByName()"

5 years agoMerge "Avoid passing "false" as keys to MapCacheLRU in RepoGroup"
jenkins-bot [Fri, 20 Jul 2018 00:06:05 +0000 (00:06 +0000)]
Merge "Avoid passing "false" as keys to MapCacheLRU in RepoGroup"

5 years agoConvert Title::getTitleCache() to using MapCacheLRU (again)
Aaron Schulz [Thu, 19 Jul 2018 23:40:02 +0000 (00:40 +0100)]
Convert Title::getTitleCache() to using MapCacheLRU (again)

Re-applies commit 7a25cd388c8adcce6, reverted by 3648e5683c0ff11c0.

Change-Id: I087edb15fbe11ccac7be28540e20d990f5615c4e

5 years agoAvoid passing "false" as keys to MapCacheLRU in RepoGroup
Aaron Schulz [Thu, 19 Jul 2018 10:02:57 +0000 (11:02 +0100)]
Avoid passing "false" as keys to MapCacheLRU in RepoGroup

Bug: T200026
Change-Id: I40f6ad2a3d281d06c9b6eaf4f31d9796ea5e9e9e

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 19 Jul 2018 20:13:30 +0000 (22:13 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I78f8728c250651e132b1104d2a26047ee938ac54

5 years agoMerge "Convert Title::getTitleCache() to using MapCacheLRU (again)"
jenkins-bot [Thu, 19 Jul 2018 18:19:56 +0000 (18:19 +0000)]
Merge "Convert Title::getTitleCache() to using MapCacheLRU (again)"

5 years agoMerge "In mysql.php ignore SIGINT"
jenkins-bot [Thu, 19 Jul 2018 17:35:01 +0000 (17:35 +0000)]
Merge "In mysql.php ignore SIGINT"

5 years agoLanguage::listToText: Avoid PHP warnings from E_STRICT
Mark A. Hershberger [Fri, 13 Jul 2018 18:19:51 +0000 (14:19 -0400)]
Language::listToText: Avoid PHP warnings from E_STRICT

Language::listToText() uses for(;;) which assumes the index in a list
starts at 0 and following keys are consecutive integers.

This assumption fails (and results in warnings with E_STRICT) when
SpecialListGroupRights::formatPermissions() uses the key-preserving
array_intersect() to create a subset of $allGroups.

Bug: T199559
Change-Id: I4eb03a95509d69653156a2764d58c0c5d0d1dfbc

5 years agoMerge "RCFilters: Work around Chrome browser bug in filter menu"
jenkins-bot [Thu, 19 Jul 2018 17:02:53 +0000 (17:02 +0000)]
Merge "RCFilters: Work around Chrome browser bug in filter menu"

5 years agoMerge "Set default wgMultiContentRevisionSchemaMigrationStage to write-both"
jenkins-bot [Thu, 19 Jul 2018 16:59:29 +0000 (16:59 +0000)]
Merge "Set default wgMultiContentRevisionSchemaMigrationStage to write-both"

5 years agoJobQueueGroup: Allow readOnlyReason to be specified per JQ type
Marko Obrovac [Thu, 19 Jul 2018 16:13:38 +0000 (18:13 +0200)]
JobQueueGroup: Allow readOnlyReason to be specified per JQ type

We use $wgReadOnly for various reasons, one of which is to disallow
writes in the currently-non-active DC. However, we should allow the
readOnlyReason configuration variable to be available per JobQueue type
and have it the code respect that.

In our current set-up, we use JobQueueEventBus which ever only uses the
enqueue execution path and does not depend upon which DC it is executed
in, so this will allow us to enqueue jobs in both DCs.

Note that this is an alternative approach to the one outlined in
Ibbad6063b6b154d7f7d172c79f7be324bf80eb7e

Bug: T199594
Change-Id: I8f1a57a81ea11c1c587c0057fa8bb3454b0e0b56

5 years agofilebackend: let any specific backend value of "readOnly" override the default
Aaron Schulz [Thu, 19 Jul 2018 16:11:39 +0000 (17:11 +0100)]
filebackend: let any specific backend value of "readOnly" override the default

Previously, only different reason strings could override, but there was
no way to override the read-only mode to being off.

Change-Id: I4266694034bfbdada90d4be96bcbc1a37f5b5409

5 years agoMerge "docs: Remove table-layout documentation from core"
jenkins-bot [Thu, 19 Jul 2018 16:11:24 +0000 (16:11 +0000)]
Merge "docs: Remove table-layout documentation from core"

5 years agoApiMain: Always create a new printer in getPrinterByName()
Brad Jorsch [Thu, 19 Jul 2018 13:24:48 +0000 (09:24 -0400)]
ApiMain: Always create a new printer in getPrinterByName()

ApiMain already caches the printer in ->mPrinter, so if
getPrinterByName() is being called more than once that's because we
really want a new printer instance, without any cached errors or other
behavior that results from reusing the same instance.

Bug: T199949
Change-Id: I779cbbaa8aab9b049a8eed732416edd828121ec4

5 years agoMerge "config: Add new ConfigRepository"
jenkins-bot [Thu, 19 Jul 2018 14:40:26 +0000 (14:40 +0000)]
Merge "config: Add new ConfigRepository"

5 years agoMerge "registration: Expose config array to ExtensionRegistry"
jenkins-bot [Thu, 19 Jul 2018 14:26:51 +0000 (14:26 +0000)]
Merge "registration: Expose config array to ExtensionRegistry"

5 years agoconfig: Add new ConfigRepository
Florian Schmidt [Wed, 14 Dec 2016 20:55:56 +0000 (21:55 +0100)]
config: Add new ConfigRepository

This, for now, has the focus for holding metadata of each
configuration option inside of MediaWiki (both extensions and core).
It's very close to the Config interface and friends, and uses these
implementations to retrieve the actual value of the
configuration option.

The goal with this change is to implement a basic architecture to
allow to display the values of the curent configuration of the MediaWiki
installation on-wiki (e.g. on a special page). It also provides a
central point, where the currently known options can be fetched
from.

The long-term goal, of course, would be to get a web interface to really
configure the MediaWiki installation. But, this is more like a dream,
then a plan (from the point of view of this commit).

Next steps would be:
 * Enable ExtensionRegistry to "register" the configuration options of
   extensions, so they're available in the repo (done).
 * Find a good way to get mediawiki/core configurations into this repo
 * Work out an overall architecture to display the different possible
   values. (I think about something like different formatters for types).

Change-Id: I9419508eaa85ffc55520db7f33b3e9530fc99f00

5 years agoFix octal escape sequence overflow in FiltersTest.php
RazeSoldier [Thu, 19 Jul 2018 14:09:15 +0000 (22:09 +0800)]
Fix octal escape sequence overflow in FiltersTest.php

The octal escape sequence must be less than or equal to 377.
Change \666 to \377.

Bug: T200004
Change-Id: I3804a0c0fab7ec74bc9dd1281d800fffd53f05fa

5 years agoregistration: Expose config array to ExtensionRegistry
Florian Schmidt [Fri, 13 Jan 2017 05:21:00 +0000 (06:21 +0100)]
registration: Expose config array to ExtensionRegistry

Currently, the ExtensionProcessor processes the config array of the
extension and just sets the value as a global. In this way, however,
the metadata of the configs (description, public, ...) aren't available.

This change exposes the configurations in the extracted data as the
config key.

Bug: T155908
Change-Id: Ie41e6ecb8d08a5b20b56eb2281af1dfdd808b2c4

5 years agoMake MessageCache use getWithSetCallback() for big messages
Aaron Schulz [Mon, 25 Jun 2018 12:15:27 +0000 (13:15 +0100)]
Make MessageCache use getWithSetCallback() for big messages

Change-Id: I8f93e1dffbcbbabf4d7cb361b001d8ca6e7ad954

5 years agodocs: Remove table-layout documentation from core
Volker E [Thu, 19 Jul 2018 12:39:34 +0000 (14:39 +0200)]
docs: Remove table-layout documentation from core

This doesn't belong here and also doesn't make a lot of sense
with current browser support any more.
We shouldn't provide basic HTML documentation in 2018 as part of
core.

Change-Id: I1a3516e45902d16f0d9efbe97cb2dbd6efd566be

5 years agoConvert Title::getTitleCache() to using MapCacheLRU (again)
Aaron Schulz [Tue, 17 Jul 2018 07:47:06 +0000 (08:47 +0100)]
Convert Title::getTitleCache() to using MapCacheLRU (again)

Re-appplies commit 7a25cd388c8a, which was reverted because
HTMLTitleTextField was passing `null` as a title key, this was
fixed in I29ecd94cdf9e30.

Bug: T199763
Change-Id: I7fe8bbed3fb24240e47ba22de57da9dc8a9bea22

5 years agoRemove JobQueueSecondTestQueue class.
Petr Pchelko [Thu, 19 Jul 2018 09:42:47 +0000 (11:42 +0200)]
Remove JobQueueSecondTestQueue class.

After the switchover is completed we do not need this any more.
This class was marked deprecated as soon as it was created, so
removing it should be safe.

Change-Id: I3451a7a9d1e78bb2c7c988aeb1e3aac93bfc1b6f

5 years agoMerge "registration: Add class docs for ExtensionJsonValidator"
jenkins-bot [Thu, 19 Jul 2018 09:32:52 +0000 (09:32 +0000)]
Merge "registration: Add class docs for ExtensionJsonValidator"

5 years agoMerge "Fix handling of already logged-in user in Special:Userlogin"
jenkins-bot [Thu, 19 Jul 2018 08:32:11 +0000 (08:32 +0000)]
Merge "Fix handling of already logged-in user in Special:Userlogin"

5 years agoDeprecate wfArrayFilter() and wfArrayFilterByKey()
Max Semenik [Wed, 18 Jul 2018 08:42:52 +0000 (01:42 -0700)]
Deprecate wfArrayFilter() and wfArrayFilterByKey()

Now that all our supported PHP versions have array_filter()
with a third parameter, these functions aren't needed anymore.

Depends-On: I3b097a1a048baabcaca15dc214a3a1bb06e746cc
Depends-On: I0187e27ac47cbab099249572201d1a649226a734
Change-Id: I7cabd0252691a083cb749cf9d3a7a23f1d076c39

5 years agoMerge "LogEventsList: Remove options not used by HTMLForm"
jenkins-bot [Thu, 19 Jul 2018 02:25:04 +0000 (02:25 +0000)]
Merge "LogEventsList: Remove options not used by HTMLForm"

5 years agoMerge "Make MultiWriteBagOStuff use the native merge() of each backend"
jenkins-bot [Thu, 19 Jul 2018 01:53:32 +0000 (01:53 +0000)]
Merge "Make MultiWriteBagOStuff use the native merge() of each backend"

5 years agoMerge "Convert MemcLockManager to using MapCacheLRU"
Krinkle [Thu, 19 Jul 2018 01:48:56 +0000 (01:48 +0000)]
Merge "Convert MemcLockManager to using MapCacheLRU"

5 years agoregistration: Add class docs for ExtensionJsonValidator
Timo Tijhof [Thu, 19 Jul 2018 01:20:29 +0000 (18:20 -0700)]
registration: Add class docs for ExtensionJsonValidator

Change-Id: Ic37544de1400600719764057a63cc546c26218d8

5 years agoFix handling of already logged-in user in Special:Userlogin
Gergő Tisza [Wed, 18 Jul 2018 22:49:50 +0000 (00:49 +0200)]
Fix handling of already logged-in user in Special:Userlogin

Due to a forgotten return clause, the full request handling
is executed after calling successfulAction() when the user
reloads the login page while logged in. With a typical setup
case this is masked by the fact that successfulAction() does
a redirect (although it probably still impacts performance),
for less common configurations this might result in the login
form rendered below a success message, or in calling extension
hooks which should not be called.

Bug: T185702
Change-Id: If19220c4cf17b08f7e03ca0d06381067f26dda1a

5 years agoMake MultiWriteBagOStuff use the native merge() of each backend
Aaron Schulz [Tue, 10 Jul 2018 23:26:43 +0000 (00:26 +0100)]
Make MultiWriteBagOStuff use the native merge() of each backend

This lets backends that support CAS take advantage of it.

Also fix race condition with merge() in asyncWrites mode where two
threads might add to a list/set but the first request finishes after
the second, which would erase an item during the set().

Bug: T198239
Change-Id: Ibd2539429746f12b4de74d0f031089cb80aa8b4b

5 years agoMerge "LogEventsList: Add backwards-compatibility for log-show-hide messages"
jenkins-bot [Wed, 18 Jul 2018 21:03:59 +0000 (21:03 +0000)]
Merge "LogEventsList: Add backwards-compatibility for log-show-hide messages"