lhc/web/wiklou.git
22 months agoRemove getMainWANInstance and getMainStashInstance functions
Zoranzoki21 [Sun, 15 Sep 2019 12:55:47 +0000 (14:55 +0200)]
Remove getMainWANInstance and getMainStashInstance functions
from ObjectCache as they were deprecated in 1.28

Change-Id: I133470a1c69c836f38b1ae5fecc05e50b70f4457

22 months agoMerge "actions: Rename Doxygen group from "Action done on pages" to "Actions""
jenkins-bot [Sun, 15 Sep 2019 10:19:23 +0000 (10:19 +0000)]
Merge "actions: Rename Doxygen group from "Action done on pages" to "Actions""

22 months agoMerge "phan: Disable enable_class_alias_support"
jenkins-bot [Sun, 15 Sep 2019 08:51:29 +0000 (08:51 +0000)]
Merge "phan: Disable enable_class_alias_support"

22 months agophan: Disable enable_class_alias_support
Umherirrender [Thu, 12 Sep 2019 19:40:57 +0000 (21:40 +0200)]
phan: Disable enable_class_alias_support

It is enabled for b/c in extensions, but not needed in core

Change-Id: I51dca12be9c77049f77563d9bf0edd07928c2300

22 months agoMerge "Revision: Inject Logger instead of LoggerSpi"
jenkins-bot [Sun, 15 Sep 2019 06:59:15 +0000 (06:59 +0000)]
Merge "Revision: Inject Logger instead of LoggerSpi"

22 months agoMerge "Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'"
jenkins-bot [Sat, 14 Sep 2019 23:54:48 +0000 (23:54 +0000)]
Merge "Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'"

22 months agoIntegrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'
Fomafix [Fri, 13 Sep 2019 08:08:20 +0000 (10:08 +0200)]
Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'

This reduces the number of modules.

Bug: T232688
Change-Id: Id63592d8f674b994adccf5f7f6bbda50d84d0edb

22 months agoMerge "Fix a typo (folow -> follow)"
jenkins-bot [Sat, 14 Sep 2019 21:09:06 +0000 (21:09 +0000)]
Merge "Fix a typo (folow -> follow)"

22 months agoMerge "Log DNS blacklist matches with info level, non-matches with debug level"
jenkins-bot [Sat, 14 Sep 2019 20:16:10 +0000 (20:16 +0000)]
Merge "Log DNS blacklist matches with info level, non-matches with debug level"

22 months agoChangesListSpecialPage: Cache the change tag list and its summary
Roan Kattouw [Sat, 27 Jul 2019 02:25:28 +0000 (19:25 -0700)]
ChangesListSpecialPage: Cache the change tag list and its summary

Even though we don't parse messages in the summary callback, the startup
module still spends 29% of its time building the change tag list
summary. Let's put the whole thing behind a 24-hour cache until we
figure out something better.

Bug: T223260
Change-Id: If145ef21159f3702895e5ecafeedd05d00a79de4

22 months agoMerge "Make doTestLockCalls() faster"
jenkins-bot [Sat, 14 Sep 2019 18:53:15 +0000 (18:53 +0000)]
Merge "Make doTestLockCalls() faster"

22 months agoLog DNS blacklist matches with info level, non-matches with debug level
Martin Urbanec [Tue, 20 Aug 2019 17:29:59 +0000 (19:29 +0200)]
Log DNS blacklist matches with info level, non-matches with debug level

Bug: T230822
Change-Id: I036b38ac322181fdba4e9e6c1ff539f79b5bb79c

22 months agoMerge "Suppress PhanUndeclaredProperty for custom properties and phan bugs"
jenkins-bot [Sat, 14 Sep 2019 15:53:31 +0000 (15:53 +0000)]
Merge "Suppress PhanUndeclaredProperty for custom properties and phan bugs"

22 months agoMerge "Declare dynamic properties"
jenkins-bot [Sat, 14 Sep 2019 15:53:25 +0000 (15:53 +0000)]
Merge "Declare dynamic properties"

22 months agoSuppress PhanUndeclaredProperty for custom properties and phan bugs
Daimona Eaytoy [Sat, 7 Sep 2019 13:06:50 +0000 (15:06 +0200)]
Suppress PhanUndeclaredProperty for custom properties and phan bugs

And remove the issue from the exclusions list.

Bug: T231636
Change-Id: Iee73ddb554e354abe52d13dcfc453f9a15bb8877

22 months agoDeclare dynamic properties
Daimona Eaytoy [Wed, 11 Sep 2019 09:30:12 +0000 (11:30 +0200)]
Declare dynamic properties

This is for classes with a single undeclared property - aside from
BlockManager: I3f51fd3579514b83b567dfe20926df2f0930dc85 removed the
declaration of $permissionManager without actually removing all uses.

Change-Id: Ic2a95f77071312041be6e0633ea9b5325e98de42

22 months agoMerge "Remove dead code from RCCacheEntryFactory"
jenkins-bot [Sat, 14 Sep 2019 13:12:52 +0000 (13:12 +0000)]
Merge "Remove dead code from RCCacheEntryFactory"

22 months agoMerge "Change the Balinese language autonym to "Bali""
jenkins-bot [Sat, 14 Sep 2019 11:53:24 +0000 (11:53 +0000)]
Merge "Change the Balinese language autonym to "Bali""

22 months agoMake doTestLockCalls() faster
Aaron Schulz [Sat, 14 Sep 2019 05:41:10 +0000 (22:41 -0700)]
Make doTestLockCalls() faster

This was mostly doing many runs just to test for random lock errors in
versions of Windows from a few years back. Just do three quick rounds.

Change-Id: I2ec2a8ce66a5c14bfc9338b60f8a57b2de8eaece

22 months agoMerge "Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'"
jenkins-bot [Sat, 14 Sep 2019 03:50:40 +0000 (03:50 +0000)]
Merge "Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'"

22 months agoMerge "Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpda...
jenkins-bot [Sat, 14 Sep 2019 03:29:48 +0000 (03:29 +0000)]
Merge "Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates hooks were deprecated"

22 months agoMerge "API: Add missing `@ingroup API` to a few Api-related classes"
jenkins-bot [Sat, 14 Sep 2019 03:29:10 +0000 (03:29 +0000)]
Merge "API: Add missing `@ingroup API` to a few Api-related classes"

22 months agoMerge "docs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST"
jenkins-bot [Sat, 14 Sep 2019 03:29:02 +0000 (03:29 +0000)]
Merge "docs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST"

22 months agoMerge "docs: Remove aliases that are only used in tests/"
jenkins-bot [Sat, 14 Sep 2019 03:27:56 +0000 (03:27 +0000)]
Merge "docs: Remove aliases that are only used in tests/"

22 months agoMerge "Make PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one...
jenkins-bot [Sat, 14 Sep 2019 02:59:44 +0000 (02:59 +0000)]
Merge "Make PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one batch"

22 months agoStorage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'
Timo Tijhof [Sat, 14 Sep 2019 01:23:36 +0000 (02:23 +0100)]
Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'

In order to make statistics from WANObjectCache more useful,
each kind of key should generally have a unique first make*Key
component. This usually corresponds 1:1 to a call to make*Key,
unless the same key format is duplicated in muliple places.

In this case, change ('BlobStore', 'address', …, …)
to ('SqlBlobStore-blob', …, …).

Bug: T197849
Change-Id: Iba3ae1bf947d6f56c72df2cf3f2160d458d38c66

22 months agoMerge "StreamFile: Deprecate ::parseRange() and ::send404Message() methods"
jenkins-bot [Sat, 14 Sep 2019 01:03:47 +0000 (01:03 +0000)]
Merge "StreamFile: Deprecate ::parseRange() and ::send404Message() methods"

22 months agoMerge "filebackend: rename and simplify header sanitizing methods in SwiftFileBackend"
jenkins-bot [Sat, 14 Sep 2019 00:12:05 +0000 (00:12 +0000)]
Merge "filebackend: rename and simplify header sanitizing methods in SwiftFileBackend"

22 months agoactions: Rename Doxygen group from "Action done on pages" to "Actions"
Timo Tijhof [Fri, 13 Sep 2019 23:32:16 +0000 (00:32 +0100)]
actions: Rename Doxygen group from "Action done on pages" to "Actions"

Bug: T232104
Change-Id: Ia3b8c14bd62ac241824bce216361141adb77cc47

22 months agoAPI: Add missing `@ingroup API` to a few Api-related classes
Timo Tijhof [Fri, 13 Sep 2019 23:07:23 +0000 (00:07 +0100)]
API: Add missing `@ingroup API` to a few Api-related classes

Bug: T232104
Change-Id: Iea6714bc2f77525d6e164df37ca8f453886e3ca8

22 months agodocs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST
Timo Tijhof [Fri, 13 Sep 2019 22:57:35 +0000 (23:57 +0100)]
docs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST

These are to create pages with an overview of `@bug` and `@test`
annotations of which there are none in MediaWiki core in doc block
comments, like `/**`. As far as I know, there is also no practice
or plans to start using these or to use Doxygen as a way to
organise such work (we use Phabricator instead to report things
that are broken and/or should have tests).

Bug: T232104
Change-Id: I1056f22c38b11157ac7b5a23e9838978e8901171

22 months agodocs: Remove aliases that are only used in tests/
Timo Tijhof [Fri, 13 Sep 2019 21:58:48 +0000 (22:58 +0100)]
docs: Remove aliases that are only used in tests/

Follows-up fec6692394, which excluded 'tests/' from indexing,
which means these aliases are no longer needed.

Change-Id: Ice6be877b8f526f26ef9657a335142d07428fa6e

22 months agoMerge "Remove usages of Title::get{Previous,Next}RevisionId"
jenkins-bot [Fri, 13 Sep 2019 22:58:36 +0000 (22:58 +0000)]
Merge "Remove usages of Title::get{Previous,Next}RevisionId"

22 months agoMerge "Remove User::setNewpassword()"
jenkins-bot [Fri, 13 Sep 2019 21:56:41 +0000 (21:56 +0000)]
Merge "Remove User::setNewpassword()"

22 months agoMerge "deleteLogFormatter: explicitly declare parsedParametersDeleteLog"
jenkins-bot [Fri, 13 Sep 2019 21:56:35 +0000 (21:56 +0000)]
Merge "deleteLogFormatter: explicitly declare parsedParametersDeleteLog"

22 months agoMerge "Declare dynamic properties"
jenkins-bot [Fri, 13 Sep 2019 21:49:14 +0000 (21:49 +0000)]
Merge "Declare dynamic properties"

22 months agoMerge "Make CdnCacheUpdate::expand() private and update the sole caller"
jenkins-bot [Fri, 13 Sep 2019 21:25:47 +0000 (21:25 +0000)]
Merge "Make CdnCacheUpdate::expand() private and update the sole caller"

22 months agoMerge "user: Use cached singleton instance variable"
jenkins-bot [Fri, 13 Sep 2019 21:17:49 +0000 (21:17 +0000)]
Merge "user: Use cached singleton instance variable"

22 months agoMerge "docs: Exclude extra markdown files from Doxygen"
jenkins-bot [Fri, 13 Sep 2019 20:47:41 +0000 (20:47 +0000)]
Merge "docs: Exclude extra markdown files from Doxygen"

22 months agoMerge "changes: Fix wrong typehint"
jenkins-bot [Fri, 13 Sep 2019 20:47:34 +0000 (20:47 +0000)]
Merge "changes: Fix wrong typehint"

22 months agoMerge "libs: Declare dynamic properties and improve doc types"
jenkins-bot [Fri, 13 Sep 2019 20:47:28 +0000 (20:47 +0000)]
Merge "libs: Declare dynamic properties and improve doc types"

22 months agoMerge "Expose LinksUpdate recursive flag with a getter"
jenkins-bot [Fri, 13 Sep 2019 20:04:40 +0000 (20:04 +0000)]
Merge "Expose LinksUpdate recursive flag with a getter"

22 months agoMake PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one batch
Aaron Schulz [Wed, 11 Sep 2019 22:15:17 +0000 (15:15 -0700)]
Make PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one batch

Change-Id: I1fd19ebee1cfe1c94cab3e8fe40824d9723573da

22 months agoFollow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates...
James D. Forrester [Fri, 13 Sep 2019 17:59:48 +0000 (10:59 -0700)]
Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates hooks were deprecated

Change-Id: Id35cc5e1d21a62d0d6469b80b693bb654215db2a

22 months agoRemove User::setNewpassword()
Reedy [Fri, 13 Sep 2019 18:03:20 +0000 (19:03 +0100)]
Remove User::setNewpassword()

Change-Id: I0a52ac16bc9c62bf344af3f489f4cbe7576fc733

22 months agodeleteLogFormatter: explicitly declare parsedParametersDeleteLog
Daimona Eaytoy [Wed, 11 Sep 2019 09:14:34 +0000 (11:14 +0200)]
deleteLogFormatter: explicitly declare parsedParametersDeleteLog

Instead of having a dynamic property checked via isset().

Change-Id: I64e3a3135b898b65e789aa8307ab9e3ffa0e9f4a

22 months agoDeclare dynamic properties
Daimona Eaytoy [Wed, 11 Sep 2019 09:07:30 +0000 (11:07 +0200)]
Declare dynamic properties

This is for all classes with 2 or more undeclared properties.

Change-Id: I1d80deb31f331bcc277b33f9e9f74857ba825637

22 months agouser: Use cached singleton instance variable
Reedy [Fri, 13 Sep 2019 17:44:11 +0000 (18:44 +0100)]
user: Use cached singleton instance variable

Remove unnecesary qualification (there's a use statement)

Change-Id: I0c39e2086f38275db7912231f6ddbfa090f095d8

22 months agoMerge "Fix a typo (yeild -> yield)"
jenkins-bot [Fri, 13 Sep 2019 17:10:14 +0000 (17:10 +0000)]
Merge "Fix a typo (yeild -> yield)"

22 months agoRemove usages of Title::get{Previous,Next}RevisionId
Petr Pchelko [Tue, 27 Aug 2019 02:45:33 +0000 (19:45 -0700)]
Remove usages of Title::get{Previous,Next}RevisionId

The methods were deprecated since 1.34.

Change-Id: Ib95ac1ba36a8ffd6b71ed67642d8abb2e3538bae

22 months agodocs: Exclude extra markdown files from Doxygen
apaskulin [Tue, 10 Sep 2019 18:58:32 +0000 (18:58 +0000)]
docs: Exclude extra markdown files from Doxygen

Cleans up the Doxygen file list by excluding markdown
files other than the intro, main code of conduct, and
/docs directory.

docs: Add heading to code of conduct

Adds an h1 heading to use as the file listing
in Doxygen instead of the file name.

Change-Id: Id13eec2670aa4b96275f1e688a29c22c3f38a859

22 months agoFix a typo (folow -> follow)
DannyS712 [Fri, 13 Sep 2019 03:32:11 +0000 (03:32 +0000)]
Fix a typo (folow -> follow)

Bug: T201491
Change-Id: I1083f6f0e29b9f3e9c2d0dd2bdb9e1f524327c0a

22 months agoMerge "output: Narrow Title type hint to LinkTarget"
jenkins-bot [Fri, 13 Sep 2019 13:31:24 +0000 (13:31 +0000)]
Merge "output: Narrow Title type hint to LinkTarget"

22 months agoMerge "Reset all logging tables together"
jenkins-bot [Fri, 13 Sep 2019 12:06:20 +0000 (12:06 +0000)]
Merge "Reset all logging tables together"

22 months agoMerge "Improve MediaWikiIntegrationTestCase::resetDB()"
jenkins-bot [Fri, 13 Sep 2019 12:00:51 +0000 (12:00 +0000)]
Merge "Improve MediaWikiIntegrationTestCase::resetDB()"

22 months agoReset all logging tables together
Adam Wight [Thu, 12 Sep 2019 15:19:57 +0000 (17:19 +0200)]
Reset all logging tables together

For example, leftover cruft in `log_search` will cause spurious
associated_rev links between unrelated revisions and log entries.

Bug: T227849
Change-Id: Ie344522229e4142f2c61a267b4d693051b813236

22 months agoImprove MediaWikiIntegrationTestCase::resetDB()
Lucas Werkmeister [Thu, 12 Sep 2019 15:36:01 +0000 (17:36 +0200)]
Improve MediaWikiIntegrationTestCase::resetDB()

Test the intersection of $tablesUsed with each set of tables
separately and only update it afterwards.  Without this fix, overlaps
between the table groups would cause additional groups to be pulled in
unnecessarily.

Change-Id: I1b2a6eb47e061dee8a27fb4779809b4684c05104

22 months agoRemove dead code from RCCacheEntryFactory
Matěj Suchánek [Fri, 13 Sep 2019 09:51:52 +0000 (11:51 +0200)]
Remove dead code from RCCacheEntryFactory

Change-Id: I7832bac1e9c700e4a2a37b765d257ce8a7ace458

22 months agooutput: Narrow Title type hint to LinkTarget
Thiemo Kreuz [Fri, 13 Sep 2019 09:34:33 +0000 (11:34 +0200)]
output: Narrow Title type hint to LinkTarget

The code never needs a full Title object, but only what the (more
narrow) interface provides.

Change-Id: I3a7aa35c7e90fffaf37f4cb444549237c20e0bd9

22 months agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 13 Sep 2019 07:30:02 +0000 (09:30 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ieebc40ae9287950ee4ce61612e982d6e307bb2b3

22 months agoFix a typo (yeild -> yield)
DannyS712 [Fri, 13 Sep 2019 03:37:16 +0000 (03:37 +0000)]
Fix a typo (yeild -> yield)

Bug: T201491
Change-Id: I70443514d55c681e51233b6e80ac7911c5e12d5a

22 months agoMerge "filebackend: Use HTTPFileStreamer::send404Message() in caller instead"
jenkins-bot [Fri, 13 Sep 2019 02:33:15 +0000 (02:33 +0000)]
Merge "filebackend: Use HTTPFileStreamer::send404Message() in caller instead"

22 months agoMake CdnCacheUpdate::expand() private and update the sole caller
Aaron Schulz [Thu, 12 Sep 2019 00:08:52 +0000 (17:08 -0700)]
Make CdnCacheUpdate::expand() private and update the sole caller

Change-Id: Id427a1667618b65055be772e9919052e95def1f9

22 months agoMerge "Fix param docs and passed type of UserMailer::sendWithPear"
jenkins-bot [Thu, 12 Sep 2019 23:01:43 +0000 (23:01 +0000)]
Merge "Fix param docs and passed type of UserMailer::sendWithPear"

22 months agoMerge "Avoid Database::tableName in WikiExporter"
jenkins-bot [Thu, 12 Sep 2019 22:36:03 +0000 (22:36 +0000)]
Merge "Avoid Database::tableName in WikiExporter"

22 months agoMerge "Fix spaces in doc comments"
jenkins-bot [Thu, 12 Sep 2019 22:35:56 +0000 (22:35 +0000)]
Merge "Fix spaces in doc comments"

22 months agoMerge "Make DefaultPreferencesFactory depend on PermissionManager."
jenkins-bot [Thu, 12 Sep 2019 21:03:30 +0000 (21:03 +0000)]
Merge "Make DefaultPreferencesFactory depend on PermissionManager."

22 months agoFix spaces in doc comments
Umherirrender [Thu, 12 Sep 2019 19:45:18 +0000 (21:45 +0200)]
Fix spaces in doc comments

Change-Id: Ic404324003d40569d0ddb697c8b1bcf95f28e2ec

22 months agoAvoid Database::tableName in WikiExporter
Umherirrender [Wed, 4 Sep 2019 16:11:46 +0000 (18:11 +0200)]
Avoid Database::tableName in WikiExporter

Using * in select is not the prefered way.
List all needed columns to make the use visible and to avoid issues when
new fields gets added with big data.
As each column name is unique there is no need to get the table name for
prefixing the columns

The following columns no longer selected:
- log_user_text -> not used due to use of ActorMigration class
- log_actor -> Add by ActorMigration class
- log_comment_id -> Added by CommentStore
- log_page -> Unused in the writer, the ns/title pair is used instead

Move the arrays out of the loop, because there are not depending on
values changing in the loop

Change-Id: I140641b7ed75bc2b8db2e7612020d668f1be663b

22 months agoFix param docs and passed type of UserMailer::sendWithPear
Umherirrender [Wed, 11 Sep 2019 20:12:04 +0000 (22:12 +0200)]
Fix param docs and passed type of UserMailer::sendWithPear

Mail::send accepts mixed for recipients and only array for headers
The documentation for recipients allows string with comma-separated list
or a string array
https://github.com/pear/Mail/blob/master/Mail/mail.php#L115-L119

Change-Id: Ia8269e91a7dcfe09d41bd03f8830b83f28812564

22 months agoMerge "mw.ForeignApi: don’t set origin for same-origin requests"
jenkins-bot [Thu, 12 Sep 2019 17:34:37 +0000 (17:34 +0000)]
Merge "mw.ForeignApi: don’t set origin for same-origin requests"

22 months agoMerge "Resources: Consistently use base paths without trailing '/'"
jenkins-bot [Thu, 12 Sep 2019 17:34:27 +0000 (17:34 +0000)]
Merge "Resources: Consistently use base paths without trailing '/'"

22 months agoStreamFile: Merge duplicate switch cases 'jpg' and 'jpeg'
Derick Alangi [Thu, 12 Sep 2019 13:26:45 +0000 (14:26 +0100)]
StreamFile: Merge duplicate switch cases 'jpg' and 'jpeg'

Change-Id: I51d233e80c4b0cebc269b54629582d4cf76e186f

22 months agoStreamFile: Deprecate ::parseRange() and ::send404Message() methods
Derick Alangi [Sun, 8 Sep 2019 20:32:25 +0000 (21:32 +0100)]
StreamFile: Deprecate ::parseRange() and ::send404Message() methods

StreamFile::parseRange() and StreamFile::send404Message() are now replaced
by HTTPFileStreamer::parseRange() and HTTPFileStreamer::send404Message().

Change-Id: Id777211de42a225361ce068adaab64e3ddc03fdc

22 months agofilebackend: Use HTTPFileStreamer::send404Message() in caller instead
Derick Alangi [Tue, 10 Sep 2019 09:10:44 +0000 (10:10 +0100)]
filebackend: Use HTTPFileStreamer::send404Message() in caller instead

Replaced usage of StreamFile::STEAM_HEADLESS (now making it unused) by
HTTPFileStreamer::STREAM_HEADLESS. Also, deprecated these unused constants.
Searched around and found nothing and CS also says so too;

https://codesearch.wmflabs.org/search/?q=StreamFile%3A%3A(STREAM_ALLOW_OB%7CSTREAM_HEADLESS)&i=nope&files=&repos=

Change-Id: Ia3fc2cf072fa2fddb910c64a547d12cb243290d5

22 months agoResources: Consistently use base paths without trailing '/'
Fomafix [Thu, 12 Sep 2019 13:07:47 +0000 (15:07 +0200)]
Resources: Consistently use base paths without trailing '/'

Change-Id: Iebaf740f9367a34dc29a9312bccd54f92f0c66f2

22 months agoMerge "Replace usages of deprecated User::isAllowed. Step 2."
jenkins-bot [Thu, 12 Sep 2019 12:33:03 +0000 (12:33 +0000)]
Merge "Replace usages of deprecated User::isAllowed. Step 2."

22 months agoMerge "Make SpecialBlankPageTest independend from the language"
jenkins-bot [Thu, 12 Sep 2019 12:00:06 +0000 (12:00 +0000)]
Merge "Make SpecialBlankPageTest independend from the language"

22 months agoMake SpecialBlankPageTest independend from the language
Thiemo Kreuz [Thu, 12 Sep 2019 11:10:52 +0000 (13:10 +0200)]
Make SpecialBlankPageTest independend from the language

I would like to argue this is best practice. This also currently blocks
https://gerrit.wikimedia.org/r/521480

Change-Id: I8477f8280038c383c35bebf559ba2b5841748821

22 months agochanges: Fix wrong typehint
Daimona Eaytoy [Wed, 11 Sep 2019 09:00:28 +0000 (11:00 +0200)]
changes: Fix wrong typehint

Fortunately the method is private.

Change-Id: Ic3838f1269c99b9679c7552bcb7b049f0b8e7b6f

22 months agolibs: Declare dynamic properties and improve doc types
Daimona Eaytoy [Wed, 11 Sep 2019 08:57:15 +0000 (10:57 +0200)]
libs: Declare dynamic properties and improve doc types

Change-Id: I5cf39d3dde5990e6a0fde91b98cf692e39a3a431

22 months agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 12 Sep 2019 06:29:35 +0000 (08:29 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie04c47bbaa02a23e152f48a35e62f0185054ef6b

22 months agoMerge "Cleanup File::purgeEverything() to use JobQueueGroup::lazyPush() in one batch"
jenkins-bot [Thu, 12 Sep 2019 00:11:18 +0000 (00:11 +0000)]
Merge "Cleanup File::purgeEverything() to use JobQueueGroup::lazyPush() in one batch"

22 months agoMerge "Fix XMP parser errors due to trailing nullchar"
jenkins-bot [Wed, 11 Sep 2019 23:56:51 +0000 (23:56 +0000)]
Merge "Fix XMP parser errors due to trailing nullchar"

22 months agoReplace usages of deprecated User::isAllowed. Step 2.
Petr Pchelko [Wed, 21 Aug 2019 02:01:06 +0000 (19:01 -0700)]
Replace usages of deprecated User::isAllowed. Step 2.

Bug: T220191
Depends-On: I509cd88355cfd0cc074f4135ec86399b4075f89f
Change-Id: I2341e6f1d108c92924620fba3c64ec090cb09918

22 months agoFix XMP parser errors due to trailing nullchar
Derk-Jan Hartman [Wed, 11 Sep 2019 22:12:22 +0000 (00:12 +0200)]
Fix XMP parser errors due to trailing nullchar

JPEG files can have trailing \0 chars at the end of the XMP value. Use
trim() to remove these from the string value.

Bug: T118799
Change-Id: Id4ab223ef432e5d2c0dd3b4e332320db02422700

22 months agoMake DefaultPreferencesFactory depend on PermissionManager.
Petr Pchelko [Thu, 22 Aug 2019 22:53:05 +0000 (15:53 -0700)]
Make DefaultPreferencesFactory depend on PermissionManager.

Bug: T220191
Change-Id: I3f5c4340501d59b5ca63b096364b5cc8388cff80

22 months agoCleanup File::purgeEverything() to use JobQueueGroup::lazyPush() in one batch
Aaron Schulz [Wed, 11 Sep 2019 22:09:07 +0000 (15:09 -0700)]
Cleanup File::purgeEverything() to use JobQueueGroup::lazyPush() in one batch

Change-Id: I347de55ecca4d2779eba6a8627276b9afef48905

22 months agoCleanup LinksUpdate::invalidateProperties() to use JobQueueGroup::lazyPush() in one...
Aaron Schulz [Wed, 11 Sep 2019 22:07:41 +0000 (15:07 -0700)]
Cleanup LinksUpdate::invalidateProperties() to use JobQueueGroup::lazyPush() in one batch

Change-Id: I7afaf6e6c0692aad83c017660bb8fdbb8a88597a

22 months agoCleanup field visibility and comments in CdnCacheUpdate and HTMLCacheUpdate
Aaron Schulz [Wed, 11 Sep 2019 22:00:13 +0000 (15:00 -0700)]
Cleanup field visibility and comments in CdnCacheUpdate and HTMLCacheUpdate

Change-Id: Ifbdc3e845aee9c6785c7813f6c955da4bfbe2bc8

22 months agoCleanup Title::touchLinks() to use JobQueueGroup::lazyPush() in one batch
Aaron Schulz [Wed, 11 Sep 2019 21:56:24 +0000 (14:56 -0700)]
Cleanup Title::touchLinks() to use JobQueueGroup::lazyPush() in one batch

Change-Id: I45f36a06cc333170f60162ee37b464865b6bdc37

22 months agoMerge "Add general messagebox (neutral) styling to shared.css"
jenkins-bot [Wed, 11 Sep 2019 21:07:28 +0000 (21:07 +0000)]
Merge "Add general messagebox (neutral) styling to shared.css"

22 months agoTitle: Fix case mismatch for function/method calls
Derick Alangi [Wed, 11 Sep 2019 18:05:22 +0000 (19:05 +0100)]
Title: Fix case mismatch for function/method calls

Change-Id: I278bd54818a0d143415192d17ef815d40f0c2b63

22 months agoMerge "mediawiki.util: Add debounce() function"
jenkins-bot [Wed, 11 Sep 2019 19:33:40 +0000 (19:33 +0000)]
Merge "mediawiki.util: Add debounce() function"

22 months agoMerge "deferred: Fix MW version number when hard deprecating to '1.34'"
jenkins-bot [Wed, 11 Sep 2019 19:33:33 +0000 (19:33 +0000)]
Merge "deferred: Fix MW version number when hard deprecating to '1.34'"

22 months agoMerge "jquery.color: Merge $.colorUtil back into this module"
jenkins-bot [Wed, 11 Sep 2019 19:15:22 +0000 (19:15 +0000)]
Merge "jquery.color: Merge $.colorUtil back into this module"

22 months agoMerge "Update OOUI to v0.34.1"
jenkins-bot [Wed, 11 Sep 2019 19:07:08 +0000 (19:07 +0000)]
Merge "Update OOUI to v0.34.1"

22 months agoMerge "Pass the user and request into BlockManager::getUserBlock"
jenkins-bot [Wed, 11 Sep 2019 18:58:32 +0000 (18:58 +0000)]
Merge "Pass the user and request into BlockManager::getUserBlock"

22 months agoMerge "mediawiki.special.userlogin.signup: Remove unused debounce dependency"
jenkins-bot [Wed, 11 Sep 2019 18:52:38 +0000 (18:52 +0000)]
Merge "mediawiki.special.userlogin.signup: Remove unused debounce dependency"

22 months agoMerge "mediawiki.util: Remove redundant IE8 support from addCSS()"
jenkins-bot [Wed, 11 Sep 2019 18:42:27 +0000 (18:42 +0000)]
Merge "mediawiki.util: Remove redundant IE8 support from addCSS()"