2 years agoMerge "generatePhpCharToUpperMappings: Die if fopen fails"
jenkins-bot [Thu, 19 Sep 2019 08:19:53 +0000 (08:19 +0000)]
Merge "generatePhpCharToUpperMappings: Die if fopen fails"

2 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Thu, 19 Sep 2019 08:19:47 +0000 (08:19 +0000)]
Merge "Localisation updates from https://translatewiki.net."

2 years agoMerge "StringUtils: Add a utility for checking if a string is a valid regex"
jenkins-bot [Thu, 19 Sep 2019 08:03:33 +0000 (08:03 +0000)]
Merge "StringUtils: Add a utility for checking if a string is a valid regex"

2 years agogeneratePhpCharToUpperMappings: Die if fopen fails
Fomafix [Wed, 18 Sep 2019 19:46:42 +0000 (21:46 +0200)]
generatePhpCharToUpperMappings: Die if fopen fails

This prevents additional errors in the following code.

Change-Id: I27770e6ca09c495ec7b6cb588c251b4014697bfe

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 19 Sep 2019 06:48:24 +0000 (08:48 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia5a76e28cc8a824370748cc719ad76dd7f9f0d02

2 years agoMake purgeList.php use getCdnUrls()
Gilles Dubuc [Wed, 18 Sep 2019 20:36:26 +0000 (22:36 +0200)]
Make purgeList.php use getCdnUrls()

Bug: T233095
Change-Id: I8c1d3f273ff2d81b9f28403136f4a6e4c3311724

2 years agoMerge "Remove unused `.success-box` class"
jenkins-bot [Wed, 18 Sep 2019 20:21:11 +0000 (20:21 +0000)]
Merge "Remove unused `.success-box` class"

2 years agoAPI: Use ApiBlockInfoTrait in ApiQueryUsers and AllUsers
Brad Jorsch [Thu, 5 Sep 2019 18:24:28 +0000 (14:24 -0400)]
API: Use ApiBlockInfoTrait in ApiQueryUsers and AllUsers

For efficient bulk querying, this means that
ApiQueryBase::showHiddenUsersAddBlockInfo() needs to return everything
needed by DatabaseBlock::newFromRow().

Since we're rewriting it anyway, we may as well also move
ApiQueryBase::showHiddenUsersAddBlockInfo() out into a trait of its own.

Bug: T232021
Change-Id: I9c5b17a232ecbfbffefc7e40608cf5684ce8a644

2 years agoMerge "Remove redundant 'jquery.accessKeylabel' module alias"
jenkins-bot [Wed, 18 Sep 2019 19:02:59 +0000 (19:02 +0000)]
Merge "Remove redundant 'jquery.accessKeylabel' module alias"

2 years agoMerge "Remove unused localisation messages for old edit toolbar"
jenkins-bot [Wed, 18 Sep 2019 19:01:35 +0000 (19:01 +0000)]
Merge "Remove unused localisation messages for old edit toolbar"

2 years agoRemove redundant 'jquery.accessKeylabel' module alias
Timo Tijhof [Wed, 18 Sep 2019 18:37:03 +0000 (19:37 +0100)]
Remove redundant 'jquery.accessKeylabel' module alias

Follows-up f168493b57. This isn't actually used anywhere so might
as well remove right away like we did with some of the other
modules we combined this release.

Change-Id: I6267db732e9835d9dba5cf32d2c6743461f7cb35

2 years agoMerge "wdio-mediawiki: release 0.5.0"
jenkins-bot [Wed, 18 Sep 2019 16:31:56 +0000 (16:31 +0000)]
Merge "wdio-mediawiki: release 0.5.0"

2 years agowdio-mediawiki: release 0.5.0
Lucas Werkmeister [Tue, 17 Sep 2019 16:10:34 +0000 (18:10 +0200)]
wdio-mediawiki: release 0.5.0

Change-Id: Ib6bfcb18aed1ea24753ea8e2e15796c9fff84cf0

2 years agoMobile friendly styling of Special:ListFiles
jdlrobson [Wed, 11 Sep 2019 21:31:56 +0000 (14:31 -0700)]
Mobile friendly styling of Special:ListFiles

This makes core's Special:ListFiles match the styling of
Special:Uploads that is provided by MobileFrontend. The latter
can be removed once this change is incorporated.

The tablet/desktop mode of this page is not impacted except
that the title will be context aware when a username is selected
to show "Uploads by <username>" rather than the generic "list files".

Bug: T102139
Change-Id: I266313b8c71bdf410d336e020aca7dabbe115be5

2 years agoRemove unused localisation messages for old edit toolbar
Bartosz Dziewoński [Wed, 28 Aug 2019 10:33:50 +0000 (12:33 +0200)]
Remove unused localisation messages for old edit toolbar

Not used since cfa70ea6d003ae69d52aad67a543912449c71e00. Also not used
by any extensions (WikiEditor and VisualEditor have their own messages).

The message 'sig-text' used to also be part of the old edit toolbar,
but it is currently still used by WikiEditor.

Bug: T224429
Change-Id: I342351aaa2c69b5a7dde865edd38f1f2f94cfb8c

2 years agoMerge "Set l18n cache to array in DevelopmentSettings.php"
jenkins-bot [Wed, 18 Sep 2019 11:59:57 +0000 (11:59 +0000)]
Merge "Set l18n cache to array in DevelopmentSettings.php"

2 years agoStringUtils: Add a utility for checking if a string is a valid regex
Daimona Eaytoy [Wed, 5 Sep 2018 14:20:13 +0000 (16:20 +0200)]
StringUtils: Add a utility for checking if a string is a valid regex

There's no function to check if a string is a valid regex, and doing it
via preg_match requires error suppression, often performed with @. This
isn't however a good practice, and suppressing errors via functions is
not a one line solution. Adding an utility function would probably be a
benefit for several use cases (try to grep '@preg_match' for a few of

Change-Id: I257a096319f1ec13441e9f745dcd22545fdd5cc6

2 years agoLocalFile: avoid hard failures on non-existing files.
daniel [Fri, 30 Aug 2019 08:55:01 +0000 (10:55 +0200)]
LocalFile: avoid hard failures on non-existing files.

Some methods on LocalFile will fatal if called on a non-existing file.
ApiQueryImageInfo did not take that into account.

This patch changes LocalFile to avoid fatal errors, and ApiQueryImageInfo
to not try and report information on non-existing files.

NOTE: the modified code has NO test coverage! This should be fixed
before this patch is applied, or the patch needs to be thoroughly tested

Bug: T221812
Change-Id: I9b74545a393d1b7a25c8262d4fe37a6492bbc11e

2 years agoMerge "objectcache: fix DatabaseSqlite::initSqliteDatabase() call location"
jenkins-bot [Wed, 18 Sep 2019 08:39:40 +0000 (08:39 +0000)]
Merge "objectcache: fix DatabaseSqlite::initSqliteDatabase() call location"

2 years agoUse UserIdentity instead of User in REST
Petr Pchelko [Fri, 13 Sep 2019 21:07:59 +0000 (14:07 -0700)]
Use UserIdentity instead of User in REST

Change-Id: Ia6a517c6a64664be2363492108f9497fc949f299

2 years agoMerge "objectcache: Escape dots from cache keys in StatsD metrics"
jenkins-bot [Wed, 18 Sep 2019 02:54:32 +0000 (02:54 +0000)]
Merge "objectcache: Escape dots from cache keys in StatsD metrics"

2 years agoobjectcache: fix DatabaseSqlite::initSqliteDatabase() call location
Aaron Schulz [Wed, 18 Sep 2019 02:22:51 +0000 (19:22 -0700)]
objectcache: fix DatabaseSqlite::initSqliteDatabase() call location

This should be called in the non-LB cause (e.g. custom DBs).

Follow-up mishandled merge conflict in 3298a9db9021.

Bug: T233117
Change-Id: I71a5c28db05a3c294e5c244037be2ee0209d61ad

2 years agoRemove unused `.success-box` class
Volker E [Tue, 17 Sep 2019 22:24:24 +0000 (15:24 -0700)]
Remove unused `.success-box` class

Change-Id: Ie5ecaed60fc7f6342301550c57b238044c20e4a4

2 years agoMerge "docs: Ignore extensions/ and skins/ in mwdocgen.php by default"
jenkins-bot [Tue, 17 Sep 2019 21:53:11 +0000 (21:53 +0000)]
Merge "docs: Ignore extensions/ and skins/ in mwdocgen.php by default"

2 years agoMerge "docs: Ignore README.md by default"
jenkins-bot [Tue, 17 Sep 2019 21:53:04 +0000 (21:53 +0000)]
Merge "docs: Ignore README.md by default"

2 years agoSet l18n cache to array in DevelopmentSettings.php
Amir Sarabadani [Thu, 8 Aug 2019 10:37:48 +0000 (12:37 +0200)]
Set l18n cache to array in DevelopmentSettings.php

Bug: T218207
Change-Id: Ib52d766436f487570b26fde54abfb1ff780c3647

2 years agoMerge "DefaultPreferencesFactory: Remove fallback for null PermissionManager"
jenkins-bot [Tue, 17 Sep 2019 20:32:17 +0000 (20:32 +0000)]
Merge "DefaultPreferencesFactory: Remove fallback for null PermissionManager"

2 years agoMerge "Break PreferencesFormOOUI->PermissionManager dependency"
jenkins-bot [Tue, 17 Sep 2019 20:32:10 +0000 (20:32 +0000)]
Merge "Break PreferencesFormOOUI->PermissionManager dependency"

2 years agoMerge "Improve documentation for the MinimumPasswordLengthToLogin policy"
jenkins-bot [Tue, 17 Sep 2019 20:07:50 +0000 (20:07 +0000)]
Merge "Improve documentation for the MinimumPasswordLengthToLogin policy"

2 years agoMerge "mediawiki.Title: Reduce transfer size of phpCharToUpper.json"
jenkins-bot [Tue, 17 Sep 2019 19:48:47 +0000 (19:48 +0000)]
Merge "mediawiki.Title: Reduce transfer size of phpCharToUpper.json"

2 years agoImprove documentation for the MinimumPasswordLengthToLogin policy
Thalia [Tue, 17 Sep 2019 19:16:05 +0000 (20:16 +0100)]
Improve documentation for the MinimumPasswordLengthToLogin policy

Bug: T233119
Change-Id: I2d0fa6f7116b407cbf62ad93da73d0800c9d14f9

2 years agoMerge "wdio-mediawiki: fix @since versions"
jenkins-bot [Tue, 17 Sep 2019 19:06:31 +0000 (19:06 +0000)]
Merge "wdio-mediawiki: fix @since versions"

2 years agomediawiki.Title: Reduce transfer size of phpCharToUpper.json
Timo Tijhof [Tue, 17 Sep 2019 18:40:03 +0000 (19:40 +0100)]
mediawiki.Title: Reduce transfer size of phpCharToUpper.json

Follows-up 416895821fdb68, which increased this payload by 1-2KB.

Bug: T233095
Change-Id: I90745fe1c1ad4389fef399a30966b123f7812506

2 years agoMerge "REST: Properly handle HEAD requests"
jenkins-bot [Tue, 17 Sep 2019 18:57:18 +0000 (18:57 +0000)]
Merge "REST: Properly handle HEAD requests"

2 years agoMerge "Use TextFormatter in the REST API"
jenkins-bot [Tue, 17 Sep 2019 18:57:09 +0000 (18:57 +0000)]
Merge "Use TextFormatter in the REST API"

2 years agowdio-mediawiki: update signatures in README.md
Lucas Werkmeister [Tue, 17 Sep 2019 16:03:38 +0000 (18:03 +0200)]
wdio-mediawiki: update signatures in README.md

Add parameter types everywhere, and mark the parameters of blockUser and
unblockUser as optional.

Change-Id: I4713fed9f073801333796d974fff9d2d7059d1f0

2 years agoBreak PreferencesFormOOUI->PermissionManager dependency
Petr Pchelko [Fri, 13 Sep 2019 15:26:11 +0000 (08:26 -0700)]
Break PreferencesFormOOUI->PermissionManager dependency

Depends-On: Id0f0bdb39b9e0be4d7c38c229371be04bb5aec5c
Change-Id: I9209cf26a27ab66306f61937b620bfe05c2045b0

2 years agoMerge "Allow logging arbitrary extra data in MWExceptionHandler::logException"
jenkins-bot [Tue, 17 Sep 2019 12:54:18 +0000 (12:54 +0000)]
Merge "Allow logging arbitrary extra data in MWExceptionHandler::logException"

2 years agoMerge "Make WatchedItemQueryService depend on PermissionManager"
jenkins-bot [Tue, 17 Sep 2019 10:11:26 +0000 (10:11 +0000)]
Merge "Make WatchedItemQueryService depend on PermissionManager"

2 years agoDeprecate `$wgSysopEmailBans`
DannyS712 [Thu, 5 Sep 2019 22:57:06 +0000 (22:57 +0000)]
Deprecate `$wgSysopEmailBans`

Bug: T232169
Change-Id: Iba2493eb2f49d32c5aa1b4da53c9c221847fb125

2 years agoMergeHistory: Update revactor_page too
Brad Jorsch [Tue, 10 Sep 2019 15:24:24 +0000 (11:24 -0400)]
MergeHistory: Update revactor_page too

When using MergeHistory, we need to update the denormalized
revision_actor_temp.revactor_page to match the update we do for

Also, we need a maintenance script to clean up the rows that were broken
by our failure to do that before.

Bug: T232464
Change-Id: Ib819a9d9fc978d75d7cc7e53f361483b69ab8020

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 17 Sep 2019 06:23:10 +0000 (08:23 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5c4e2bd9d76c70622b408f870ac11af9739dad73

2 years agoREST: Properly handle HEAD requests
Tim Starling [Tue, 10 Sep 2019 06:26:53 +0000 (16:26 +1000)]
REST: Properly handle HEAD requests

Just handle a HEAD request as a GET request, if no specific HEAD handler
exists. This is simple and similar to what the rest of MediaWiki does in
response to a HEAD request.

Bug: T226043
Change-Id: I7b2bd657c20b56844459874131a3d85fabe7db3d

2 years agoUse TextFormatter in the REST API
Tim Starling [Tue, 16 Jul 2019 22:43:43 +0000 (08:43 +1000)]
Use TextFormatter in the REST API

* Add ResponseFactory::createLocalizedHttpError(), which generates a
  JSON response body from a MessageValue
* ResponseFactory::__construct() accepts an array of TextFormatter
  objects. For ease of testing, the array may be empty. The integrated
  ResponseFactory has a TextFormatter for English, and one for
  $wgContLang if that is different.
* Use createLocalizedHttpError() to show helpful error messages for
  errors generated by Router.

Change-Id: I897a0aee42227916c568333ab384966f1b87f599

2 years agoMerge "Standardise preview warning box when using ?action=edit"
jenkins-bot [Tue, 17 Sep 2019 02:06:54 +0000 (02:06 +0000)]
Merge "Standardise preview warning box when using ?action=edit"

2 years agoMerge "BaseTemplate: Hard-deprecate msgWiki()"
jenkins-bot [Tue, 17 Sep 2019 01:59:13 +0000 (01:59 +0000)]
Merge "BaseTemplate: Hard-deprecate msgWiki()"

2 years agoMerge "Bump PHP version requirement to 7.2.0+"
jenkins-bot [Tue, 17 Sep 2019 01:39:02 +0000 (01:39 +0000)]
Merge "Bump PHP version requirement to 7.2.0+"

2 years agoBump PHP version requirement to 7.2.0+
James D. Forrester [Thu, 13 Jun 2019 18:53:16 +0000 (11:53 -0700)]
Bump PHP version requirement to 7.2.0+

Bug: T216165
Bug: T216166
Change-Id: I99e45c2a8fd1512a76a42ce978cb96f39ee2456e

2 years agoMerge "services: Do not use deprecated ReflectionType::__toString() in tests"
jenkins-bot [Tue, 17 Sep 2019 00:40:49 +0000 (00:40 +0000)]
Merge "services: Do not use deprecated ReflectionType::__toString() in tests"

2 years agoMerge "SectionProfiler: Do not attempt to use null values as arrays"
jenkins-bot [Mon, 16 Sep 2019 23:37:17 +0000 (23:37 +0000)]
Merge "SectionProfiler: Do not attempt to use null values as arrays"

2 years agoMerge "Title::getTalkPage(): Restore behavior of interwiki-prefixed & fragment-only...
jenkins-bot [Mon, 16 Sep 2019 23:16:16 +0000 (23:16 +0000)]
Merge "Title::getTalkPage(): Restore behavior of interwiki-prefixed & fragment-only titles"

2 years agoMerge "Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result"
jenkins-bot [Mon, 16 Sep 2019 22:47:52 +0000 (22:47 +0000)]
Merge "Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result"

2 years agoMerge "wdio-mediawiki: extract bot() function"
jenkins-bot [Mon, 16 Sep 2019 22:47:41 +0000 (22:47 +0000)]
Merge "wdio-mediawiki: extract bot() function"

2 years agoMerge "Chinese Conversion Table Update 2019-3"
jenkins-bot [Mon, 16 Sep 2019 21:06:05 +0000 (21:06 +0000)]
Merge "Chinese Conversion Table Update 2019-3"

2 years agoMerge "mediawiki.page.ready: Avoid duplicate DOM query on logout click"
jenkins-bot [Mon, 16 Sep 2019 20:28:05 +0000 (20:28 +0000)]
Merge "mediawiki.page.ready: Avoid duplicate DOM query on logout click"

2 years agoMerge "mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick"
jenkins-bot [Mon, 16 Sep 2019 20:27:59 +0000 (20:27 +0000)]
Merge "mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick"

2 years agoSectionProfiler: Do not attempt to use null values as arrays
Máté Szabó [Mon, 16 Sep 2019 19:30:47 +0000 (21:30 +0200)]
SectionProfiler: Do not attempt to use null values as arrays

When SectionProfiler::getFunctionStats() is called, the 'start'
and 'end' member variables may be null if no code called the
scopedProfileIn()/scopedProfileOut() methods on this profiler instance.
This can occur, for instance, when generating the parser limit report
for wikitext that did not include expensive parser functions.

In PHP 7.4, attemping to use a null value as an array generates
a PHP Notice.[1] This patch adds a check to SectionProfiler::getFunctionStats
to verify that the 'start' value is an array before attempting to
access its keys.

[1] https://github.com/php/php-src/blob/php-7.4.0RC1/UPGRADING#L25

Bug: T233012
Change-Id: I2d35bfddfcc4c194aa71265e40387f2f2914e3a5

2 years agoservices: Do not use deprecated ReflectionType::__toString() in tests
Máté Szabó [Mon, 16 Sep 2019 19:14:07 +0000 (21:14 +0200)]
services: Do not use deprecated ReflectionType::__toString() in tests

The \MediaWikiServicesTest::provideGetService() PHPUnit data provider
method uses the ReflectionType::__toString() method to obtain the
return type of service instantiator callables as a string.

In PHP 7.4, calling this method generates an E_DEPRECATED notice.
The solution is to use ReflectionType::getName() instead, available
since PHP 7.1.[1]

This patch updates the method to use ReflectionType::getName()
if it is available, and fall back to ReflectionType::__toString()

[1] https://github.com/php/php-src/blob/php-7.4.0RC1/UPGRADING#L395

Bug: T233012
Change-Id: I69b97f75795e6c4e005bf1a23fb798f7e52da2fd

2 years agoMerge "Update old URLs in DefaultSettings related to Squid caching"
jenkins-bot [Mon, 16 Sep 2019 18:34:31 +0000 (18:34 +0000)]
Merge "Update old URLs in DefaultSettings related to Squid caching"

2 years agowdio-mediawiki: extract bot() function
Lucas Werkmeister [Mon, 16 Sep 2019 14:36:13 +0000 (16:36 +0200)]
wdio-mediawiki: extract bot() function

This functionality was previously copy+pasted for most other methods,
and is also useful externally, to make API requests that are not covered
by other methods in Api.js.

createAccount() needs a different type of token, so for now we leave it
alone. (Perhaps the token type could become a parameter of bot() later?)

Change-Id: Ica24213a1f0d651bfc3fbffe24b63251a4841658

2 years agowdio-mediawiki: fix @since versions
Lucas Werkmeister [Mon, 16 Sep 2019 16:39:08 +0000 (18:39 +0200)]
wdio-mediawiki: fix @since versions

The initial version of this package (added in change I547a7899e7, commit
16a4d9da7b) was 0.1.0, not 1.0.0.

Change-Id: I39511be15ea8ec27692f8547f375349bb6384a6b

2 years agoMake WatchedItemQueryService depend on PermissionManager
Petr Pchelko [Fri, 13 Sep 2019 20:39:50 +0000 (13:39 -0700)]
Make WatchedItemQueryService depend on PermissionManager

Bug: T220191
Change-Id: I714d2b33b83dab230a8168765d5523cb14971371

2 years agoChinese Conversion Table Update 2019-3
Chiefwei [Mon, 16 Sep 2019 14:30:52 +0000 (22:30 +0800)]
Chinese Conversion Table Update 2019-3

Update the Chinese conversion table routinely to fix bugs reported from https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .

It is only data changes and only works for Chinese WikiProjects.

Change-Id: Iaed40e230bd7be0656af3b24837e870743c84700

2 years agoNote in `Createacct-reason` that the reason provided is publicly visible
DannyS712 [Sun, 21 Jul 2019 22:51:25 +0000 (22:51 +0000)]
Note in `Createacct-reason` that the reason provided is publicly visible

Bug: T211732
Change-Id: Idb3a354dd7b2425bcde1f85382481f7af5ca3080

2 years agoMerge "objectcache: remove references to recently removed methods"
jenkins-bot [Mon, 16 Sep 2019 09:15:37 +0000 (09:15 +0000)]
Merge "objectcache: remove references to recently removed methods"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 16 Sep 2019 07:08:56 +0000 (09:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic665f6f2f3f9ee34f2447d74e4c7c890b5ad0710

2 years agoobjectcache: remove references to recently removed methods
Aaron Schulz [Sun, 15 Sep 2019 20:52:07 +0000 (13:52 -0700)]
objectcache: remove references to recently removed methods

Follow-up to 9d5e3f56d55c81e

Change-Id: Idca42b5ca405c31953a516aa3f96cf64cc0e0a12

2 years agoMerge "resourceloader: Add Doxygen group and improve overall docs"
jenkins-bot [Sun, 15 Sep 2019 19:58:46 +0000 (19:58 +0000)]
Merge "resourceloader: Add Doxygen group and improve overall docs"

2 years agoMerge "OutputPage: Add visibility to various methods & do some micro-optimizations"
jenkins-bot [Sun, 15 Sep 2019 16:41:21 +0000 (16:41 +0000)]
Merge "OutputPage: Add visibility to various methods & do some micro-optimizations"

2 years agoMerge "Update docblocks for methods potentially returning null"
jenkins-bot [Sun, 15 Sep 2019 16:27:34 +0000 (16:27 +0000)]
Merge "Update docblocks for methods potentially returning null"

2 years agoOutputPage: Add visibility to various methods & do some micro-optimizations
Derick Alangi [Sat, 14 Sep 2019 10:26:31 +0000 (11:26 +0100)]
OutputPage: Add visibility to various methods & do some micro-optimizations

Methods that visibility was added to are; `addMeta()`, `addLink()`,
`setCanonicalUrl()`, `addScript()`, `getHeadItemsArray()`, `addParserOutput()`,
`getCacheVaryCookies()` and `haveCacheVaryCookies()`. Last but not lease, did
a few micro-optimizations to `addMeta()` and `addLink()`.

Change-Id: I94d037a5edc7131627724fd1d864000128077b0c

2 years agoUpdate docblocks for methods potentially returning null
Daimona Eaytoy [Sun, 15 Sep 2019 13:22:08 +0000 (15:22 +0200)]
Update docblocks for methods potentially returning null

These were discovered by setting `null_casts_as_any_type` to true in
phan, and filtering by `PhanTypeMismatchReturnNullable`. Of course there
are others, some of which are false positives, but we cannot suppress
them now (or the UnusedSuppressionPlugin will complain).

Change-Id: Ia8443e575c22f47a6d8c63038f4e7ac36815fc27

2 years agoRemove getMainWANInstance and getMainStashInstance functions
Zoranzoki21 [Sun, 15 Sep 2019 12:55:47 +0000 (14:55 +0200)]
Remove getMainWANInstance and getMainStashInstance functions
from ObjectCache as they were deprecated in 1.28

Change-Id: I133470a1c69c836f38b1ae5fecc05e50b70f4457

2 years agoMerge "actions: Rename Doxygen group from "Action done on pages" to "Actions""
jenkins-bot [Sun, 15 Sep 2019 10:19:23 +0000 (10:19 +0000)]
Merge "actions: Rename Doxygen group from "Action done on pages" to "Actions""

2 years agoMerge "phan: Disable enable_class_alias_support"
jenkins-bot [Sun, 15 Sep 2019 08:51:29 +0000 (08:51 +0000)]
Merge "phan: Disable enable_class_alias_support"

2 years agophan: Disable enable_class_alias_support
Umherirrender [Thu, 12 Sep 2019 19:40:57 +0000 (21:40 +0200)]
phan: Disable enable_class_alias_support

It is enabled for b/c in extensions, but not needed in core

Change-Id: I51dca12be9c77049f77563d9bf0edd07928c2300

2 years agoMerge "Revision: Inject Logger instead of LoggerSpi"
jenkins-bot [Sun, 15 Sep 2019 06:59:15 +0000 (06:59 +0000)]
Merge "Revision: Inject Logger instead of LoggerSpi"

2 years agoMerge "Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'"
jenkins-bot [Sat, 14 Sep 2019 23:54:48 +0000 (23:54 +0000)]
Merge "Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'"

2 years agomediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick
Timo Tijhof [Sat, 14 Sep 2019 01:00:55 +0000 (02:00 +0100)]
mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick

* Remove redundant closures around the two files.

* Export checkboxShiftClick as a regular function.
  This jQuery plugin is not used anywhere in Wikimedia Gerrit,
  nor elsewhere indexed by Codesearch, nor anywhere on-wiki
  in User, Project or MediaWiki namespaces.
  As such, remove the deprecated module alias as well.

Change-Id: I6bc41036829964080abf1ab0bbd306356bb8fe57

2 years agomediawiki.page.ready: Avoid duplicate DOM query on logout click
Timo Tijhof [Sat, 14 Sep 2019 02:19:46 +0000 (03:19 +0100)]
mediawiki.page.ready: Avoid duplicate DOM query on logout click

The result of this DOM selector query is already available
as 'this' given we're in an event handler, use that directly

* Use the 'href' property directly instead of using jQuery or attributes.
* Avoid shadow names by naming the error handler param 'err' instead
  of 'e'.

Change-Id: I94a757ca1dd782b1e138a372983b6bfa16081485

2 years agoIntegrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'
Fomafix [Fri, 13 Sep 2019 08:08:20 +0000 (10:08 +0200)]
Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'

This reduces the number of modules.

Bug: T232688
Change-Id: Id63592d8f674b994adccf5f7f6bbda50d84d0edb

2 years agoUpdate old URLs in DefaultSettings related to Squid caching
Thalia [Sat, 14 Sep 2019 21:30:16 +0000 (22:30 +0100)]
Update old URLs in DefaultSettings related to Squid caching

Change-Id: Ic94fd638a80fcdc74f42c726f2e2e256b8f0c04d

2 years agoMerge "Fix a typo (folow -> follow)"
jenkins-bot [Sat, 14 Sep 2019 21:09:06 +0000 (21:09 +0000)]
Merge "Fix a typo (folow -> follow)"

2 years agodocs: Ignore extensions/ and skins/ in mwdocgen.php by default
Timo Tijhof [Sat, 14 Sep 2019 18:31:53 +0000 (19:31 +0100)]
docs: Ignore extensions/ and skins/ in mwdocgen.php by default

The default was previously to index all of core and extensions,
which is likely not the intent of someone running this for the
first time (which can then easily take over half an hour).

Even in CI, we never do this, and we never have afaik.

Generally, local use is to replicate CI (all of core), or a subset
of core by passing e.g. '--file includes/libs' or some such.

Indexing an extension is still possible, same way as before,
by passing '--file extensions/FooBar'. And, if one really wants
to index all of core and all extensions, the new '--extensions'
option allows one to opt back in to the old behaviour.

* Exclude all of 'resources/'. There are no PHP or Markdown files
  here that need to be indexed.

Bug: T232104
Change-Id: I55617776ac86f3fdcb6c1ba1eebe892edcb5fafb

2 years agoMerge "Log DNS blacklist matches with info level, non-matches with debug level"
jenkins-bot [Sat, 14 Sep 2019 20:16:10 +0000 (20:16 +0000)]
Merge "Log DNS blacklist matches with info level, non-matches with debug level"

2 years agoChangesListSpecialPage: Cache the change tag list and its summary
Roan Kattouw [Sat, 27 Jul 2019 02:25:28 +0000 (19:25 -0700)]
ChangesListSpecialPage: Cache the change tag list and its summary

Even though we don't parse messages in the summary callback, the startup
module still spends 29% of its time building the change tag list
summary. Let's put the whole thing behind a 24-hour cache until we
figure out something better.

Bug: T223260
Change-Id: If145ef21159f3702895e5ecafeedd05d00a79de4

2 years agoMerge "Make doTestLockCalls() faster"
jenkins-bot [Sat, 14 Sep 2019 18:53:15 +0000 (18:53 +0000)]
Merge "Make doTestLockCalls() faster"

2 years agoresourceloader: Add Doxygen group and improve overall docs
Timo Tijhof [Sat, 14 Sep 2019 04:32:54 +0000 (05:32 +0100)]
resourceloader: Add Doxygen group and improve overall docs

* Add license header where missing.
* Add missing `@since` (1.17 for most classes), except
  ResourceLoaderLessVarFileModule since 1.32 (1bc62c548c).

* Remove duplicate file-level description for class-only files,
  merge with the class description instead.

* Remove my own `@author` annotation from one file.

* Mark core's own FileModule subclasses as `@internal`, except
  for the following which we support use of in extensions:
  ResourceLoaderOOUIIconPackModule, and

Change-Id: I336af2e4ccdbe2512594e8861b72628d24194e41

2 years agodocs: Ignore README.md by default
Timo Tijhof [Sat, 14 Sep 2019 18:30:48 +0000 (19:30 +0100)]
docs: Ignore README.md by default

This makes it more future-proof so that when more files are
added, they are excluded by default. If and when we do get a file
that is intended for this, it's likely such commit will test it
and find it doesn't work and then whitelist accordingly.

Change-Id: I3b8e421724d45e6aaecea58238f430a87cbbe977

2 years agoobjectcache: Escape dots from cache keys in StatsD metrics
Timo Tijhof [Sat, 14 Sep 2019 02:04:26 +0000 (03:04 +0100)]
objectcache: Escape dots from cache keys in StatsD metrics

Bug: T232907
Change-Id: Ia61256e24fe35803e69a83a1ca235e18297c75cd

2 years agoLog DNS blacklist matches with info level, non-matches with debug level
Martin Urbanec [Tue, 20 Aug 2019 17:29:59 +0000 (19:29 +0200)]
Log DNS blacklist matches with info level, non-matches with debug level

Bug: T230822
Change-Id: I036b38ac322181fdba4e9e6c1ff539f79b5bb79c

2 years agoMerge "Suppress PhanUndeclaredProperty for custom properties and phan bugs"
jenkins-bot [Sat, 14 Sep 2019 15:53:31 +0000 (15:53 +0000)]
Merge "Suppress PhanUndeclaredProperty for custom properties and phan bugs"

2 years agoMerge "Declare dynamic properties"
jenkins-bot [Sat, 14 Sep 2019 15:53:25 +0000 (15:53 +0000)]
Merge "Declare dynamic properties"

2 years agoSuppress PhanUndeclaredProperty for custom properties and phan bugs
Daimona Eaytoy [Sat, 7 Sep 2019 13:06:50 +0000 (15:06 +0200)]
Suppress PhanUndeclaredProperty for custom properties and phan bugs

And remove the issue from the exclusions list.

Bug: T231636
Change-Id: Iee73ddb554e354abe52d13dcfc453f9a15bb8877

2 years agoDeclare dynamic properties
Daimona Eaytoy [Wed, 11 Sep 2019 09:30:12 +0000 (11:30 +0200)]
Declare dynamic properties

This is for classes with a single undeclared property - aside from
BlockManager: I3f51fd3579514b83b567dfe20926df2f0930dc85 removed the
declaration of $permissionManager without actually removing all uses.

Change-Id: Ic2a95f77071312041be6e0633ea9b5325e98de42

2 years agoMerge "Remove dead code from RCCacheEntryFactory"
jenkins-bot [Sat, 14 Sep 2019 13:12:52 +0000 (13:12 +0000)]
Merge "Remove dead code from RCCacheEntryFactory"

2 years agoMerge "Change the Balinese language autonym to "Bali""
jenkins-bot [Sat, 14 Sep 2019 11:53:24 +0000 (11:53 +0000)]
Merge "Change the Balinese language autonym to "Bali""

2 years agoMake doTestLockCalls() faster
Aaron Schulz [Sat, 14 Sep 2019 05:41:10 +0000 (22:41 -0700)]
Make doTestLockCalls() faster

This was mostly doing many runs just to test for random lock errors in
versions of Windows from a few years back. Just do three quick rounds.

Change-Id: I2ec2a8ce66a5c14bfc9338b60f8a57b2de8eaece

2 years agoMerge "Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'"
jenkins-bot [Sat, 14 Sep 2019 03:50:40 +0000 (03:50 +0000)]
Merge "Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'"

2 years agoMerge "Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpda...
jenkins-bot [Sat, 14 Sep 2019 03:29:48 +0000 (03:29 +0000)]
Merge "Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates hooks were deprecated"