3 years agoFix missing if from $wgDBssl comment
Reedy [Fri, 8 Dec 2017 01:34:34 +0000 (01:34 +0000)]
Fix missing if from $wgDBssl comment

Change-Id: I46d1a87c990198090fd322da3193014487e871e6

3 years agoMerge "SpecialPages: Add ul { margin-top: 0; margin-bottom: 0 } for multicolumn"
jenkins-bot [Thu, 7 Dec 2017 22:13:22 +0000 (22:13 +0000)]
Merge "SpecialPages: Add ul { margin-top: 0; margin-bottom: 0 } for multicolumn"

3 years agoSpecialPages: Add ul { margin-top: 0; margin-bottom: 0 } for multicolumn
Fomafix [Sun, 3 Dec 2017 19:24:11 +0000 (20:24 +0100)]
SpecialPages: Add ul { margin-top: 0; margin-bottom: 0 } for multicolumn

The two-column layout has on skin Timeless currently a different top
margin on the first and on the second column. This change fixes this.

Bug: T181947
Change-Id: If995845c6cab58fe24b1d9b7859c0614db75ceb7

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 7 Dec 2017 21:38:17 +0000 (22:38 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I42ccf64af59b022731649b95edd0f6eff33146e6

3 years agoMerge "Changed Instances of rawParams() to plaintextParams()"
jenkins-bot [Thu, 7 Dec 2017 20:36:29 +0000 (20:36 +0000)]
Merge "Changed Instances of rawParams() to plaintextParams()"

3 years agoChanged Instances of rawParams() to plaintextParams()
ryan10145 [Thu, 7 Dec 2017 02:54:03 +0000 (21:54 -0500)]
Changed Instances of rawParams() to plaintextParams()

Bug: T182213
Change-Id: Ibf24dee5ea19092e8a38e57f34c98f513d4c9b21

3 years agoMerge "Fix "Save current filter settings" menu and legend overlap"
jenkins-bot [Thu, 7 Dec 2017 18:25:38 +0000 (18:25 +0000)]
Merge "Fix "Save current filter settings" menu and legend overlap"

3 years agoMerge "GitInfo: Fix shell restrictions for submodules"
jenkins-bot [Thu, 7 Dec 2017 18:10:40 +0000 (18:10 +0000)]
Merge "GitInfo: Fix shell restrictions for submodules"

3 years agoMerge "WLFilters: Correctly check if RCFilters should be enabled on WL"
jenkins-bot [Thu, 7 Dec 2017 16:31:41 +0000 (16:31 +0000)]
Merge "WLFilters: Correctly check if RCFilters should be enabled on WL"

3 years agoImageListPager: Don't stomp on $join_conds
Brad Jorsch [Thu, 7 Dec 2017 15:14:35 +0000 (10:14 -0500)]
ImageListPager: Don't stomp on $join_conds

When adding a join to the oldimage table to get counts, don't stomp on
any existing values in $join_conds. Just add the condition.

Bug: T182245
Change-Id: I4cd3332355f9974bdf35dc083be5bba537fcfb5f

3 years agoMerge "RCFilters: Set up conditional views for RCLinked"
jenkins-bot [Thu, 7 Dec 2017 14:02:29 +0000 (14:02 +0000)]
Merge "RCFilters: Set up conditional views for RCLinked"

3 years agoWLFilters: Correctly check if RCFilters should be enabled on WL
Stephane Bisson [Thu, 7 Dec 2017 13:26:02 +0000 (08:26 -0500)]
WLFilters: Correctly check if RCFilters should be enabled on WL

Side-effect of Ib933de3a3f9e876924386e80f315506f60f8af54

ChangesListSpecialPage#isStructuredFilterUiEnabled needs
to call static::checkStructuredFilterUiEnabled() to reach
the implementation from SpecialWatchlist.

Bug: T182318
Change-Id: I1e90d7e29f9e7fc5acece6466ed818210058dd2c

3 years agoMerge "placeholder-message for html form should be ->text() not ->parse()"
jenkins-bot [Thu, 7 Dec 2017 07:14:11 +0000 (07:14 +0000)]
Merge "placeholder-message for html form should be ->text() not ->parse()"

3 years agoLocalSettingsGenerator: Fix typo in exception message
Hoto Cocoa [Thu, 7 Dec 2017 06:06:13 +0000 (15:06 +0900)]
LocalSettingsGenerator: Fix typo in exception message

Change-Id: I61fe67468eec659f312fb9aa4c20ec9bf083e78b

3 years agoMerge "Always return a string from Language::formatNum()"
jenkins-bot [Thu, 7 Dec 2017 06:12:17 +0000 (06:12 +0000)]
Merge "Always return a string from Language::formatNum()"

3 years agoAlways return a string from Language::formatNum()
Sam Wilson [Wed, 6 Dec 2017 22:55:08 +0000 (06:55 +0800)]
Always return a string from Language::formatNum()

It says it returns a string, and so it should.

Bug: T182277
Change-Id: Ic68c65c634c2557a1d07281623cd6c971b000323

3 years agoRCFilters: Set up conditional views for RCLinked
Moriel Schottlender [Thu, 7 Dec 2017 00:40:36 +0000 (16:40 -0800)]
RCFilters: Set up conditional views for RCLinked

The views that are only meant for specific pages should be set up
conditionally only when we are in that specific page, to prevent
issues with saved queries or param overload.

Change-Id: Id0bf89ce397ff8a54ce0a30d1ba7d8f9bbdd14a3

3 years agoWikiPageTest: Fix typo in @covers
Kunal Mehta [Thu, 7 Dec 2017 04:19:25 +0000 (20:19 -0800)]
WikiPageTest: Fix typo in @covers

Change-Id: I3f3a3b2a1f5e5aed61cd71db17ae6a6a01fe2ecb

3 years agoFix "Save current filter settings" menu and legend overlap
petarpetkovic [Thu, 7 Dec 2017 02:06:48 +0000 (03:06 +0100)]
Fix "Save current filter settings" menu and legend overlap

Pass overlay to SaveFiltersPopupButtonWidget, so it gets onto same
stacking context as the rest of popup widgets.

Bug: T182269
Change-Id: I2c45f82840f651c39a0e572e003c82cbbd8c1c2e

3 years agoplaceholder-message for html form should be ->text() not ->parse()
Brian Wolff [Thu, 7 Dec 2017 01:42:24 +0000 (01:42 +0000)]
placeholder-message for html form should be ->text() not ->parse()

placeholder is an html attribute, it does not support arbitrary
html, so ->text() is most appropriate, not full parse.

Follow up d3cd609e

Change-Id: Ia2aa5a001e19ee90e99936ef4f0dc879f182999f

3 years agoMerge "RCLFilters: Make 'target' and 'to/from' sticky"
jenkins-bot [Wed, 6 Dec 2017 22:50:14 +0000 (22:50 +0000)]
Merge "RCLFilters: Make 'target' and 'to/from' sticky"

3 years agomedia: Ensure there ie enough data to extract software version
Sébastien Santoro [Thu, 12 Oct 2017 23:54:29 +0000 (23:54 +0000)]
media: Ensure there ie enough data to extract software version

The Software EXIF / other metadata field was expected to contain
the software name followed by the version number.

There are occurences in Wikimedia production logs of errors showing
that's not always the case.

Bug: T178130
Change-Id: I4187a41b5fd8d7b5574ab50523668d8feb11bccc

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 6 Dec 2017 21:07:58 +0000 (22:07 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I6a56314c866bd36b92a85362bae533992a04df79

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 6 Dec 2017 21:01:19 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic9f1eafc6ea82af6eabedff7dea438f773a420cf

3 years agoRCLFilters: Make 'target' and 'to/from' sticky
Stephane Bisson [Wed, 6 Dec 2017 20:33:10 +0000 (15:33 -0500)]
RCLFilters: Make 'target' and 'to/from' sticky

Make these parameters sticky to exclude them
from Saved Queries and related features
(empty, restoreDefaults).

Bug: T172161
Change-Id: Ib8b3ecd34c6af9e0983573586485a9a9f503c060

3 years agoMerge "RCLFilters: UI tweaks"
jenkins-bot [Wed, 6 Dec 2017 19:47:13 +0000 (19:47 +0000)]
Merge "RCLFilters: UI tweaks"

3 years agoMerge "Prevent results from wiggling"
jenkins-bot [Wed, 6 Dec 2017 19:41:55 +0000 (19:41 +0000)]
Merge "Prevent results from wiggling"

3 years agoRCFilters: Reserve space between filters and results
petarpetkovic [Wed, 6 Dec 2017 17:56:23 +0000 (18:56 +0100)]
RCFilters: Reserve space between filters and results

- Add bottom margin to RCFilters head. There is no more reserved space
for "View newest changes" link, so we need to make sure we have enough
white space separator between head and results.

Bug: T182149
Change-Id: I592ab7bb1f12785d5bd802bb16f11b4e74fb26b7

3 years agoRCLFilters: UI tweaks
Stephane Bisson [Wed, 6 Dec 2017 12:05:24 +0000 (07:05 -0500)]
RCLFilters: UI tweaks

Follow-up to I96af7ba583d03e6ff9833ac3b5f4b80cfd0ee626

* Reword 'Recentchangeslinked-summary'
* Bold ToOrFrom selector label
* Bold 'FROM' in 'rcfilters-filter-showlinkedfrom-option-label'
* Bold 'TO' in 'rcfilters-filter-showlinkedto-option-label'
* Reword target page selector placeholder
* Prevent title suggestions from showing duplicate entries
* Show a specific message when there is no results
  because no target page is specified.

Bug: T172161
Change-Id: I1b1ee793b3eff4183039acc27fe6cca042ee57d0

3 years agoAdded file icon for mp3 files
Cormac Parle [Wed, 6 Dec 2017 16:10:47 +0000 (16:10 +0000)]
Added file icon for mp3 files

Bug: T182139
Change-Id: Ib834ef5b0bb15b3981288b2e711107830dcb5af8

3 years agoMerge "Allow wikilinks in "show/hide <type of change>" labels on Watchlist and Recent...
jenkins-bot [Wed, 6 Dec 2017 13:23:47 +0000 (13:23 +0000)]
Merge "Allow wikilinks in "show/hide <type of change>" labels on Watchlist and RecentChanges"

3 years agoMerge "Add missing @throws in Importers"
jenkins-bot [Wed, 6 Dec 2017 12:49:50 +0000 (12:49 +0000)]
Merge "Add missing @throws in Importers"

3 years agoAdd missing @throws in Importers
WMDE-Fisch [Tue, 14 Nov 2017 10:32:59 +0000 (11:32 +0100)]
Add missing @throws in Importers

Change-Id: I02760e59d73f4278cca87483ab4578b6e76b2324

3 years agoGet conflict results from diff3
WMDE-Fisch [Thu, 29 Dec 2016 14:08:54 +0000 (15:08 +0100)]
Get conflict results from diff3

This patch extends the global wfMerge function to also return the
result of the first merge attempt that detects merge conflicts.

The additional output explicitly names the conflicting lines and
could help when solving edit conflicts.

Bug: T151320
Change-Id: I97acebdc87b31779200c7fde4dd4449cd1ee8ead

3 years agoRevert "Support changing icon variants on hover"
VolkerE [Wed, 6 Dec 2017 00:33:35 +0000 (00:33 +0000)]
Revert "Support changing icon variants on hover"

This reverts commit 46c62ff5f474c6fe7a409863058e81bb678229b2. After reconsidering menu item treatment under UI Standardization perspective, we don't need and shouldn't use such pattern.

Bug: T110051
Change-Id: I0e8b6035f516e6629010b4f18471445c8833156e

3 years agoPrevent results from wiggling
petarpetkovic [Tue, 5 Dec 2017 22:12:51 +0000 (23:12 +0100)]
Prevent results from wiggling

The patch Ifecaaff572 introduces clearing to the right for the first
result list item, when grouping is disabled. The difference between
cleared vs non-cleared result becomes visible when legend is toggled,
causing really small (around a pixel), but annoying wiggle.

Change-Id: Ida6fb6f8ad0caf666258e3f1e770c6da9e24af58

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 5 Dec 2017 21:09:39 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I3432086a7a800e4c50609eb2a20cca9c314725af

3 years agoTests for WikiPage::insertOn
addshore [Mon, 4 Dec 2017 16:09:54 +0000 (17:09 +0100)]
Tests for WikiPage::insertOn

Change-Id: I1bf7d19c4baaf0f720fcd6a1d9c16bf7489b5392

3 years agoTests for WikiPage::updateIfNewerOn
addshore [Mon, 4 Dec 2017 15:39:49 +0000 (16:39 +0100)]
Tests for WikiPage::updateIfNewerOn

This method is deprecated but due to refactoring
we should still test it.

Change-Id: I171ab731fff48ddd9fa54ef433881154377a2c7f

3 years agoTests for WikiPage::updateRevisionOn
addshore [Mon, 4 Dec 2017 15:31:57 +0000 (16:31 +0100)]
Tests for WikiPage::updateRevisionOn

Bug: T180989
Change-Id: I245d9d467e3113bf49e06ee5c725205d4225671a

3 years agoTest for WikiPge::insertProtectNullRevision
addshore [Mon, 4 Dec 2017 15:00:17 +0000 (16:00 +0100)]
Test for WikiPge::insertProtectNullRevision

Bug: T180989
Change-Id: Iffee0bbe9fb18bb6c7f7af10b6405007468ac0b9

3 years agoTests for WikiPage::newFromID
addshore [Mon, 4 Dec 2017 14:14:12 +0000 (15:14 +0100)]
Tests for WikiPage::newFromID

Bug: T180989
Change-Id: Idb4d7ce8ccc27226b0f00e2127acef6158dd32a9

3 years agoTest for WikiPage::newFromRow
addshore [Mon, 4 Dec 2017 14:03:41 +0000 (15:03 +0100)]
Test for WikiPage::newFromRow

Bug: T180989
Change-Id: If630e3e3561ac2017a2b7c82ade842e86f8cb22e

3 years agoImprove phpdoc of 'OldRestrictions' in Title
addshore [Mon, 4 Dec 2017 13:29:14 +0000 (14:29 +0100)]
Improve phpdoc of 'OldRestrictions' in Title

The previous version of the phpdoc simply says
that the field contains a comma seperated list of
page restrictions, which is wrong.
The field is actually a colon seperated list of comma
seperated lists.

The new phpdoc and example have been pulled from mw.org
and checked against what actually exists in a real db.

Change-Id: I6bfdfd87120150e4b53e1b4c49e95041f55d8c97

3 years agoMerge "Tests for WikiPage::insertRedirectEntry"
jenkins-bot [Tue, 5 Dec 2017 19:23:56 +0000 (19:23 +0000)]
Merge "Tests for WikiPage::insertRedirectEntry"

3 years agoMerge "RCLFilters: Show images and descriptions with page suggestions"
jenkins-bot [Tue, 5 Dec 2017 18:12:25 +0000 (18:12 +0000)]
Merge "RCLFilters: Show images and descriptions with page suggestions"

3 years agoMerge "ImagePage: Make metadata table's initial collapse CSS-only"
jenkins-bot [Tue, 5 Dec 2017 17:38:29 +0000 (17:38 +0000)]
Merge "ImagePage: Make metadata table's initial collapse CSS-only"

3 years agoMerge "Absolutely position "legend" on grouped results"
jenkins-bot [Tue, 5 Dec 2017 17:24:48 +0000 (17:24 +0000)]
Merge "Absolutely position "legend" on grouped results"

3 years agoMerge "Warn for uploads with new name but same content as local file"
jenkins-bot [Tue, 5 Dec 2017 14:58:34 +0000 (14:58 +0000)]
Merge "Warn for uploads with new name but same content as local file"

3 years agoMerge "ImagePage: Clean up metadata.js collapsing"
jenkins-bot [Tue, 5 Dec 2017 14:50:10 +0000 (14:50 +0000)]
Merge "ImagePage: Clean up metadata.js collapsing"

3 years agoRCLFilters: Show images and descriptions with page suggestions
Stephane Bisson [Tue, 5 Dec 2017 13:43:05 +0000 (08:43 -0500)]
RCLFilters: Show images and descriptions with page suggestions

Bug: T172161
Change-Id: I1a5501eefdb721367436db50be0787c8f6a78d47

3 years agoMerge "RCFilters: Update invert URL param when toggled"
jenkins-bot [Tue, 5 Dec 2017 11:49:33 +0000 (11:49 +0000)]
Merge "RCFilters: Update invert URL param when toggled"

3 years agoMerge "RCLFilters: convert related changes tool to new UX"
jenkins-bot [Tue, 5 Dec 2017 11:46:45 +0000 (11:46 +0000)]
Merge "RCLFilters: convert related changes tool to new UX"

3 years agoMerge "RCFilters: Clarify 'hidden' and 'sticky' filters"
jenkins-bot [Tue, 5 Dec 2017 11:46:41 +0000 (11:46 +0000)]
Merge "RCFilters: Clarify 'hidden' and 'sticky' filters"

3 years agoMerge "RCFilters: Make 'days' and 'limit' sticky"
jenkins-bot [Tue, 5 Dec 2017 11:46:36 +0000 (11:46 +0000)]
Merge "RCFilters: Make 'days' and 'limit' sticky"

3 years agoTests for WikiPage::insertRedirectEntry
addshore [Mon, 4 Dec 2017 12:59:15 +0000 (13:59 +0100)]
Tests for WikiPage::insertRedirectEntry

Bug: T180989
Change-Id: I677202b22594c7fc8fcf97b805ae69726945f96d

3 years agoImagePage: Make metadata table's initial collapse CSS-only
Timo Tijhof [Tue, 5 Dec 2017 00:09:06 +0000 (00:09 +0000)]
ImagePage: Make metadata table's initial collapse CSS-only

Make the initial collapse of the metadata table not depend on
JavaScript. This eliminates the FOUC, and will also reduce JS
footprint once compat can be removed.

* Move the 'display: none;' styles from metadata.css to
  filepage.css so that they are part of the base styles for
  file pages (metadata.css is only for supporting metadata.js,
  which is loaded dynamically).

* Apply "collapsed" class from the PHP side immediately,
  instead of calling "addClass" in JavaScript.

* Restrict hide-styles to only apply under .client-js to make
  sure the rows remain visible in no-js mode.

* Declare dependency between metadata.js and filepage.css.
  This is just for documentation purposes, as they are both
  already separately loaded on all file pages.

Change-Id: If22bf7acb47b59151dc3b0843a62507c100e548b

3 years agoImagePage: Clean up metadata.js collapsing
Timo Tijhof [Mon, 4 Dec 2017 23:50:06 +0000 (23:50 +0000)]
ImagePage: Clean up metadata.js collapsing

In preparation for trying out a CSS-only approach for the initial
collapse that doesn't cause the expanded view to flash first.

Bug: T182047
Change-Id: I42941ccb05d5525599a0209f0f33db9fe836580b

3 years agoRCFilters: Update invert URL param when toggled
Moriel Schottlender [Tue, 5 Dec 2017 00:39:01 +0000 (16:39 -0800)]
RCFilters: Update invert URL param when toggled

Bug: T182045
Change-Id: Ia9a8afb336305969ac8b5c2e7ffab146844ad9ee

3 years agoMerge "API: Account for PHP 7.2 change"
jenkins-bot [Tue, 5 Dec 2017 00:06:19 +0000 (00:06 +0000)]
Merge "API: Account for PHP 7.2 change"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 4 Dec 2017 21:23:14 +0000 (22:23 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib8affd4b492c3be56458b54d28e4c02cb7ecfc9c

3 years agoRCLFilters: convert related changes tool to new UX
Stephane Bisson [Wed, 6 Sep 2017 10:28:05 +0000 (06:28 -0400)]
RCLFilters: convert related changes tool to new UX

Bug: T172161
Change-Id: I96af7ba583d03e6ff9833ac3b5f4b80cfd0ee626

3 years agoMerge "A few doc comment fixups"
jenkins-bot [Mon, 4 Dec 2017 20:22:10 +0000 (20:22 +0000)]
Merge "A few doc comment fixups"

3 years agoAllow wikilinks in "show/hide <type of change>" labels on Watchlist and RecentChanges
Pppery [Sun, 3 Dec 2017 03:34:12 +0000 (22:34 -0500)]
Allow wikilinks in "show/hide <type of change>" labels on Watchlist and RecentChanges

This is done by treating the messages as wikitext rather than plain

Bug: T142406
Change-Id: I5342b9491df47bbb549e91ebba9d0a8b273a7d17

3 years agoMerge "Test for WikiPage::updateRedirectOn"
jenkins-bot [Mon, 4 Dec 2017 19:09:47 +0000 (19:09 +0000)]
Merge "Test for WikiPage::updateRedirectOn"

3 years agoMerge "Add test for WikiPage::updateCategoryCounts"
jenkins-bot [Mon, 4 Dec 2017 19:05:29 +0000 (19:05 +0000)]
Merge "Add test for WikiPage::updateCategoryCounts"

3 years agoMerge "Refactor test for WikiPage::doRollback"
jenkins-bot [Mon, 4 Dec 2017 18:59:06 +0000 (18:59 +0000)]
Merge "Refactor test for WikiPage::doRollback"

3 years agoMerge "WikiPage tests @covers for doDeleteArticleReal & commitRollback"
jenkins-bot [Mon, 4 Dec 2017 18:59:01 +0000 (18:59 +0000)]
Merge "WikiPage tests @covers for doDeleteArticleReal & commitRollback"

3 years agoMerge "Split WikiPageTest into ContentHandler & NoContentHandler tests"
jenkins-bot [Mon, 4 Dec 2017 18:55:16 +0000 (18:55 +0000)]
Merge "Split WikiPageTest into ContentHandler & NoContentHandler tests"

3 years agoAPI: Account for PHP 7.2 change
Brad Jorsch [Mon, 4 Dec 2017 18:36:48 +0000 (13:36 -0500)]
API: Account for PHP 7.2 change

PHP 7.2 broke existing functionality in making count( null ) raise a
warning. So add tests for null all over the place, or change tests where
we know the value is null or an array (but not false, empty-string, or
0) to just cast to boolean.

Bug: T182004
Change-Id: Idfe23a07daa9f60eee72f2daf04304be87057a29

3 years agoMerge "objectcache: various cleanups to WANObjectCache"
jenkins-bot [Mon, 4 Dec 2017 18:38:09 +0000 (18:38 +0000)]
Merge "objectcache: various cleanups to WANObjectCache"

3 years agoMerge "Replace some Special:Undelete button with OOUI ones"
jenkins-bot [Mon, 4 Dec 2017 18:25:29 +0000 (18:25 +0000)]
Merge "Replace some Special:Undelete button with OOUI ones"

3 years agoReplace some Special:Undelete button with OOUI ones
Albert221 [Mon, 4 Dec 2017 16:43:29 +0000 (17:43 +0100)]
Replace some Special:Undelete button with OOUI ones

Bug: T180207
Change-Id: Icb550a6ad8f90d7718441ec17a1026a2cfb9d754

3 years agoRCFilters: Clarify 'hidden' and 'sticky' filters
Stephane Bisson [Fri, 3 Nov 2017 20:20:10 +0000 (16:20 -0400)]
RCFilters: Clarify 'hidden' and 'sticky' filters

Clarify the meaning and behavior of sticky and hidden filters
according to the following definitions:

When 'sticky' is false, the filter is saved in Saved Queries. Its
state is considered and altered by the 'Clear all filters' and
'Restore default filters' buttons.

When 'sticky' is true, the filter state is only changed using its
associated control (i.e. Number of days selector).

'hidden' simply means it is not shown as a capsule in the active
filters area.

Change-Id: I7ccb7c202e21917eb288055c509c9f904a0d01bb

3 years agoMerge "Only send statsd data for WAN cache in non-CLI mode"
jenkins-bot [Mon, 4 Dec 2017 17:31:48 +0000 (17:31 +0000)]
Merge "Only send statsd data for WAN cache in non-CLI mode"

3 years agoMerge "Remove unuseful debug messages"
jenkins-bot [Mon, 4 Dec 2017 16:00:21 +0000 (16:00 +0000)]
Merge "Remove unuseful debug messages"

3 years agoAbsolutely position "legend" on grouped results
petarpetkovic [Wed, 29 Nov 2017 15:28:36 +0000 (16:28 +0100)]
Absolutely position "legend" on grouped results

- When results are grouped by page, on pages where new RC filters
are enabled, apply position: absolute to legend, to avoid top
result entries being pushed too much.

Bug: T174728
Change-Id: Ifecaaff5727905b3c4e860555ba094f71aac6f80

3 years agoTest for WikiPage::updateRedirectOn
addshore [Mon, 4 Dec 2017 12:11:26 +0000 (13:11 +0100)]
Test for WikiPage::updateRedirectOn

Bug: T180989
Change-Id: I798ded72142503e52395b45fe9ec71a215d5ab92

3 years agoRemove unuseful debug messages
Niklas Laxström [Mon, 4 Dec 2017 10:12:51 +0000 (11:12 +0100)]
Remove unuseful debug messages

I spotted one of these in my debug log. Without context it is not
useful nor informative. Given it can actually come from three places,
it is useless.

Change-Id: Ic293d8944e9a1a8152c5a5e0b695c5ddc07ee6aa

3 years agoAdd test for WikiPage::updateCategoryCounts
addshore [Thu, 30 Nov 2017 18:23:01 +0000 (19:23 +0100)]
Add test for WikiPage::updateCategoryCounts

Bug: T180989
Change-Id: Iff4bb885e5d385a7b3ec6169ee9a3e1e82d7d993

3 years agoRefactor test for WikiPage::doRollback
addshore [Tue, 28 Nov 2017 14:04:01 +0000 (14:04 +0000)]
Refactor test for WikiPage::doRollback

This test was not running and a comment said
it was broken.
This patch refactors the test.

Bug: T180989
Change-Id: I46b73371e5fd65860fce6cc101bad6abfa20e91d

3 years agoWikiPage tests @covers for doDeleteArticleReal & commitRollback
addshore [Tue, 28 Nov 2017 13:41:07 +0000 (13:41 +0000)]
WikiPage tests @covers for doDeleteArticleReal & commitRollback

Bug: T180989
Change-Id: I70dcad9d527be4d91a88a14fe9787c53a7cf7d2f

3 years agoSplit WikiPageTest into ContentHandler & NoContentHandler tests
addshore [Mon, 27 Nov 2017 14:39:20 +0000 (14:39 +0000)]
Split WikiPageTest into ContentHandler & NoContentHandler tests

Follow up to Iccdcd4a4f72c8b1329d36ff2e8699ba6b23c9ae7

Bug: T180989
Change-Id: Ib37a058586c7222ffe3ee5dc5f0e134ee18f0ff7

3 years agoFix phpdoc for WikiPage::updateRedirectOn $redirectTitle param
addshore [Mon, 4 Dec 2017 09:43:01 +0000 (10:43 +0100)]
Fix phpdoc for WikiPage::updateRedirectOn $redirectTitle param

Change-Id: I8e666db2a7502bd1773252aa71db47819f63f08b

3 years agoA few doc comment fixups
Tim Starling [Fri, 1 Dec 2017 10:02:26 +0000 (21:02 +1100)]
A few doc comment fixups

* Remove some creation dates, they are not protected by GPL
* Remove duplicate @defgroup API
* Remove @ingroup from some @file doc comments on class files. It is not
  useful to list class files alongside classes in the doxygen module menu.
  Add @ingroup to some more class files that had @ingroup on their file,
  that was probably the author's intent.
* In PackedOverlayImageGallery, use the file comment as a class comment
* Don't put @defgroup and @file in the same comment. @defgroup makes the
  whole doc comment describe the group.
* Instead of putting AnsiTermColorer in two groups, use hierarchical

Change-Id: If54f6e0b2bc1ea6de42045885cf836ee67b8e961

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 3 Dec 2017 21:03:45 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Id5fe73a56a251d6feafca45edba583532180bd4c

3 years agoShow protection log on every use of moveddeleted-notice
Étienne Beaulé [Sun, 3 Sep 2017 17:03:28 +0000 (14:03 -0300)]
Show protection log on every use of moveddeleted-notice

As a follow-up to T171338, the other uses of the message were ignored.
This change adds the protection log to these uses; that is, history and
image pages.

Bug: T174889
Change-Id: Ib9f22d6e06c372c4a32e77a08c846d768853bc21

3 years ago.gitignore: Exclude Extension:Score generated files
Kunal Mehta [Sun, 3 Dec 2017 07:21:04 +0000 (23:21 -0800)]
.gitignore: Exclude Extension:Score generated files

Change-Id: Ic9cd0051cc8bd241b933037466a2af76d0f6a287

3 years agoMerge "xmp: Lower severity of XMP parse failure log events"
jenkins-bot [Sun, 3 Dec 2017 07:48:52 +0000 (07:48 +0000)]
Merge "xmp: Lower severity of XMP parse failure log events"

3 years agoGitInfo: Fix shell restrictions for submodules
Kunal Mehta [Sun, 3 Dec 2017 07:19:24 +0000 (23:19 -0800)]
GitInfo: Fix shell restrictions for submodules

Submodules have their git directory in the master repository's directory
(../.git/modules/<name>). firejail does not allow whitelisted paths to
have ".." in them, so use realpath() to get rid of that.

`git show` still wants to be able to access the main repository
directory though, so we also need to whitelist the $repoDir itself.

Bug: T181919
Change-Id: I928df92b47733bc7fbb9c796bcfc1504d4a4598c

3 years agoLower DatabaseMysqlBase::lock logging to INFO
Aaron Schulz [Sun, 3 Dec 2017 03:54:08 +0000 (19:54 -0800)]
Lower DatabaseMysqlBase::lock logging to INFO

Whether the lock() acquisition failing is a huge problem depends
on what the caller is doing. Let the caller do any logging it needs.

Bug: T180793
Change-Id: I3d05138d312d8b973df153bb511e69619d663c9d

3 years agoxmp: Lower severity of XMP parse failure log events
Bryan Davis [Sun, 3 Dec 2017 00:43:52 +0000 (17:43 -0700)]
xmp: Lower severity of XMP parse failure log events

Errors when parsing XMP information blocks broadly indicate that the
file is somehow malformed. This is generally a content issue rather than
an operational issue.

Bug: T118799
Change-Id: I3c7992343f28db75cd9ec0701c1eceebf6db2d08

3 years agoRevert "Special:Preferences: Use OOjs UI" and follow-ups
Bartosz Dziewoński [Sat, 2 Dec 2017 21:15:35 +0000 (22:15 +0100)]
Revert "Special:Preferences: Use OOjs UI" and follow-ups

The number of issues with the new interface is unacceptable and we
will not be able to fix them reasonably quickly. See subtasks of
T180538 for the list of issues, raised both by the Wikimedia community
and by WMF employees.

I should have pushed back harder against the merging of this half-baked
change with the promise that we'll fix it later. I convinced myself
that the regressions were not so noticeable and that the issues that
were pointed out will in fact be fixed by someone. Predictably,
however, regressions were bad and the only person fixing the issues
was me.

I am not going to work nights to make this page decent again within a
reasonable timeframe; I'm not sure if I'd even be able to since many
issues are problems with the design rather than the implementation. No
one else seems to be working on improving it, therefore I am reverting
the change.

On the bright side, this work has resulted in a number of improvements
to HTMLForm and Preferences code, which are not being reverted here:

If anyone reattempts this, I recommend gating the new interface behind
a configuration variable and URL parameter, like we did with
$wgOOUIEditPage in the past, and testing thoroughly in production
before enabling it for everyone.

* Revert "Special:Preferences: Use OOjs UI"
  This reverts commit 486e566cfef612de6773df435a74d5fc37e27174.
* Revert "Preferences: Show preview of edit fonts in edit font selector"
  This reverts commit 6634ff729dc7f6d0f541639dbdf3c4d9f786ddf6.
* Revert "Follow-Up Iae63b6994: Add missing editfont dependency"
  This reverts commit ce42fdf151c39f91cf4077673219fa6228a54d7f.
* Revert "Preferences: Improve visual appearance by “unboxing” sections"
  This reverts commit c9415bb0059f4dae4abc5e39a8af844328333120.
* Revert "Remove box-shadow from preference panels for ooui-apex"
  This reverts commit a934b82ca27971e8f0553a7ab7c8ee30fccf3283.
* Revert "Preferences: Don't show the watchlist token; just link to ResetTokens"
  This reverts commit e8c9102fc7b66460c33f643b0dea7190cb89ac83.
* Revert "mw.special.preferences: Make the "Basic information" section more compact"
  This reverts commit d48b7260f30c1ec57046a1f8e4c82057aed45e5f.
* Revert "mw.special.preferences: Widen the dropdown of the "Time zone" field"
  This reverts commit afd5f1417efdd463d86186257c4ec77dd4a442ce.

Bug: T117781
Bug: T180538
Change-Id: I44b5daea1828f71881b5bd35218f5ecb7ab7f36e

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 2 Dec 2017 20:59:29 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I1995cac694d9093d8356fd122b92f44e86bb643e

3 years agoOnly send statsd data for WAN cache in non-CLI mode
Aaron Schulz [Sat, 2 Dec 2017 20:34:22 +0000 (12:34 -0800)]
Only send statsd data for WAN cache in non-CLI mode

Bug: T181385
Change-Id: Ic51a084206cea93621393359ded4ff77beef5f13

3 years agoMerge "Try to avoid bogus JobTest failures for PHP 7"
jenkins-bot [Sat, 2 Dec 2017 20:20:30 +0000 (20:20 +0000)]
Merge "Try to avoid bogus JobTest failures for PHP 7"

3 years agoAdd GENDER where strings could differ
Albert221 [Sat, 2 Dec 2017 17:20:41 +0000 (18:20 +0100)]
Add GENDER where strings could differ

Bug: T129731
Change-Id: If1100a5c9ec4882f96237c70e5270a9aa40e6b24

3 years agoMerge "Fix double escaping for 'userlogin-createanother', 'userlogin-joinproject'"
jenkins-bot [Sat, 2 Dec 2017 16:55:07 +0000 (16:55 +0000)]
Merge "Fix double escaping for 'userlogin-createanother', 'userlogin-joinproject'"

3 years agoFix double escaping for 'userlogin-createanother', 'userlogin-joinproject'
Bartosz Dziewoński [Sat, 2 Dec 2017 16:14:34 +0000 (17:14 +0100)]
Fix double escaping for 'userlogin-createanother', 'userlogin-joinproject'

Change-Id: I6773420cf656e0bf47897198251e43917e1d57c6

3 years agoTry to avoid bogus JobTest failures for PHP 7
Aaron Schulz [Fri, 1 Dec 2017 22:44:37 +0000 (14:44 -0800)]
Try to avoid bogus JobTest failures for PHP 7

Change-Id: I07b4bd796a668fef83ebb3e2824ccc608781a6e8