lhc/web/wiklou.git
3 years agotitle: Disable the failing tests from TitlePermissionTest
Timo Tijhof [Wed, 15 Aug 2018 23:03:19 +0000 (00:03 +0100)]
title: Disable the failing tests from TitlePermissionTest

Bug: T201776
Change-Id: I088bd797225e0c60c66de4d4d1aa12d0b5bf67d8

3 years agoMerge "Set getEditConflictMainTextBox parameter type to array"
jenkins-bot [Thu, 16 Aug 2018 10:02:18 +0000 (10:02 +0000)]
Merge "Set getEditConflictMainTextBox parameter type to array"

3 years agoMerge "selenium: undo page"
jenkins-bot [Thu, 16 Aug 2018 09:56:57 +0000 (09:56 +0000)]
Merge "selenium: undo page"

3 years agoSet getEditConflictMainTextBox parameter type to array
WMDE-Fisch [Thu, 16 Aug 2018 09:00:06 +0000 (11:00 +0200)]
Set getEditConflictMainTextBox parameter type to array

This is only called at one place in core and used in the TwoColConf
extention. The passed argument is always an array.

Change-Id: I4ca94442b79dc8871ed72943be733d100e093e44

3 years agoUnbreak Special:JavaScriptTest
Niklas Laxström [Thu, 16 Aug 2018 06:28:17 +0000 (08:28 +0200)]
Unbreak Special:JavaScriptTest

Follow-up to dec8009

Change-Id: I812253cc1a504a8bb876700026dbfd35a727458b

3 years agoMerge "rdbms: use Database::getDomainId for transaction logging calls"
jenkins-bot [Thu, 16 Aug 2018 05:54:35 +0000 (05:54 +0000)]
Merge "rdbms: use Database::getDomainId for transaction logging calls"

3 years agoMerge "Fix spelling of word "necessary""
jenkins-bot [Thu, 16 Aug 2018 05:37:02 +0000 (05:37 +0000)]
Merge "Fix spelling of word "necessary""

3 years agoMerge "rdbms: Disable DBConnRef::selectDB() for sanity"
jenkins-bot [Thu, 16 Aug 2018 04:33:58 +0000 (04:33 +0000)]
Merge "rdbms: Disable DBConnRef::selectDB() for sanity"

3 years agoFix spelling of word "necessary"
petarpetkovic [Wed, 15 Aug 2018 23:33:12 +0000 (01:33 +0200)]
Fix spelling of word "necessary"

Bug: T201491
Change-Id: Ic983889a5702b8b8552c88ebc4d676f35e9fe61e

3 years agoFix some of the common typos
petarpetkovic [Mon, 13 Aug 2018 17:07:14 +0000 (19:07 +0200)]
Fix some of the common typos

* supress -> suppress (Except in backup_LogTest.php)
* recomend -> recommend
* becuase -> because
* accross -> across

Bug: T201491
Change-Id: I8faa4e6cc688b3ee204b3f79ab55eb7b65cc1fdd

3 years agoMerge "Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget"
jenkins-bot [Wed, 15 Aug 2018 22:34:18 +0000 (22:34 +0000)]
Merge "Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget"

3 years agoMerge "Actually inject InterwikiLookup into MediaWikiTitleCodec"
jenkins-bot [Wed, 15 Aug 2018 20:32:21 +0000 (20:32 +0000)]
Merge "Actually inject InterwikiLookup into MediaWikiTitleCodec"

3 years agoMerge "Have LinkCache::getMutableCacheKeys() accept LinkTarget"
jenkins-bot [Wed, 15 Aug 2018 20:32:16 +0000 (20:32 +0000)]
Merge "Have LinkCache::getMutableCacheKeys() accept LinkTarget"

3 years agoMerge "Title: Access properties directly instead of wrapper functions"
jenkins-bot [Wed, 15 Aug 2018 20:13:08 +0000 (20:13 +0000)]
Merge "Title: Access properties directly instead of wrapper functions"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 15 Aug 2018 20:03:09 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4b07075f2c8b2965f542f08cfbb62d71b23d9099

3 years agoMerge "Make LinkBatch::setCaller chainable"
jenkins-bot [Wed, 15 Aug 2018 19:57:26 +0000 (19:57 +0000)]
Merge "Make LinkBatch::setCaller chainable"

3 years agoMerge "Update OOUI to v0.28.0"
jenkins-bot [Wed, 15 Aug 2018 17:56:16 +0000 (17:56 +0000)]
Merge "Update OOUI to v0.28.0"

3 years agoUpdate OOUI to v0.28.0
Volker E [Tue, 14 Aug 2018 23:55:10 +0000 (16:55 -0700)]
Update OOUI to v0.28.0

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.28.0

Bug: T109529
Bug: T183601
Bug: T183645
Bug: T185751
Bug: T189113
Bug: T189953
Bug: T190441
Bug: T190581
Bug: T194104
Bug: T197004
Bug: T198845
Bug: T201329
Bug: T201871
Depends-on: I3c000504661e190ac8752f69419bed28785601b5
Change-Id: I0c101a942011f6095678ffbd90f9bd536132091c

3 years agoMerge "Add option to populateChangeTagDef not to update the count"
jenkins-bot [Wed, 15 Aug 2018 15:06:03 +0000 (15:06 +0000)]
Merge "Add option to populateChangeTagDef not to update the count"

3 years agoMerge "Remove dead code from Title::secureAndSplit()"
jenkins-bot [Wed, 15 Aug 2018 15:01:32 +0000 (15:01 +0000)]
Merge "Remove dead code from Title::secureAndSplit()"

3 years agoMerge "TitleValue: Don't use Assert for basic type checks"
jenkins-bot [Wed, 15 Aug 2018 14:48:05 +0000 (14:48 +0000)]
Merge "TitleValue: Don't use Assert for basic type checks"

3 years agoMerge "Have TitleParser::parseTitle() default to NS_MAIN to match Title"
jenkins-bot [Wed, 15 Aug 2018 14:43:44 +0000 (14:43 +0000)]
Merge "Have TitleParser::parseTitle() default to NS_MAIN to match Title"

3 years agoAdd option to populateChangeTagDef not to update the count
Amir Sarabadani [Mon, 13 Aug 2018 10:44:11 +0000 (12:44 +0200)]
Add option to populateChangeTagDef not to update the count

I need this when I'm picking this up to continue populating

Change-Id: I52c74d3c1c59ee966027d5d9cb1a2bd3cf6dfc7a

3 years agoHave WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget
Kunal Mehta [Wed, 15 Aug 2018 09:28:51 +0000 (02:28 -0700)]
Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget

Nothing specifically requires TitleValue here.

Change-Id: I62ee1995c49071db2871149b941277b29836a94a

3 years agoMake LinkBatch::setCaller chainable
Niklas Laxström [Wed, 15 Aug 2018 08:57:21 +0000 (10:57 +0200)]
Make LinkBatch::setCaller chainable

To allow for one-liners such as $lb->setCaller( __METHOD__ )->execute();

Change-Id: I45cd81d9e583f09aacb578ffb87d7c11b0e13d57

3 years agordbms: use Database::getDomainId for transaction logging calls
Aaron Schulz [Wed, 15 Aug 2018 08:20:30 +0000 (01:20 -0700)]
rdbms: use Database::getDomainId for transaction logging calls

Change-Id: I360ca633b145dc8e510bb00b542ac44933283943

3 years agoActually inject InterwikiLookup into MediaWikiTitleCodec
Kunal Mehta [Wed, 15 Aug 2018 07:15:04 +0000 (00:15 -0700)]
Actually inject InterwikiLookup into MediaWikiTitleCodec

Change-Id: Ic469f0fb8068bfb06b741d957b21e66dfa839cd6

3 years agoMerge "rdbms: split out private LoadBalancer::openLocalConnection method"
jenkins-bot [Wed, 15 Aug 2018 06:06:02 +0000 (06:06 +0000)]
Merge "rdbms: split out private LoadBalancer::openLocalConnection method"

3 years agoHave LinkCache::getMutableCacheKeys() accept LinkTarget
Kunal Mehta [Wed, 15 Aug 2018 05:56:27 +0000 (22:56 -0700)]
Have LinkCache::getMutableCacheKeys() accept LinkTarget

Change-Id: Id84590b3aa285e31a358877167fe8ff502077f3c

3 years agoTitle: Access properties directly instead of wrapper functions
Kunal Mehta [Wed, 15 Aug 2018 05:33:56 +0000 (22:33 -0700)]
Title: Access properties directly instead of wrapper functions

Since this is pretty hot code, avoid the performance hit of a function
call when we can directly access the property.

Change-Id: I287de5eb003582b5704e9d93e2fc99d16c0ffb2a

3 years agoMerge "Make ExternalStoreDB "wiki" context override the server "dbname" field"
jenkins-bot [Wed, 15 Aug 2018 05:34:15 +0000 (05:34 +0000)]
Merge "Make ExternalStoreDB "wiki" context override the server "dbname" field"

3 years agoMerge "JavaScriptMinifier: Merge $push and $pop into $model"
jenkins-bot [Wed, 15 Aug 2018 05:23:46 +0000 (05:23 +0000)]
Merge "JavaScriptMinifier: Merge $push and $pop into $model"

3 years agoRemove dead code from Title::secureAndSplit()
Kunal Mehta [Wed, 15 Aug 2018 05:13:18 +0000 (22:13 -0700)]
Remove dead code from Title::secureAndSplit()

Change-Id: I08810f0ab20fc1608f2d3b2248dcd5106044080b

3 years agordbms: split out private LoadBalancer::openLocalConnection method
Aaron Schulz [Wed, 15 Aug 2018 04:19:12 +0000 (21:19 -0700)]
rdbms: split out private LoadBalancer::openLocalConnection method

Change-Id: I2138b3d28f8f1a8ea706165fbe3a7e3f0d858447

3 years agoTitleValue: Don't use Assert for basic type checks
Kunal Mehta [Wed, 15 Aug 2018 04:09:44 +0000 (21:09 -0700)]
TitleValue: Don't use Assert for basic type checks

Previously, `new TitleValue()` was roughly twice as slow as
`Title::makeTitle()`. Switching to basic is_int/is_string checks
makes TitleValue roughly twice as fast as Title!

Tested with benchmarkTitleValue.php.

Bug: T201801
Change-Id: Idccf159983145c1c11af9182292e1d5f704ba077

3 years agoHave TitleParser::parseTitle() default to NS_MAIN to match Title
Kunal Mehta [Wed, 15 Aug 2018 03:58:34 +0000 (20:58 -0700)]
Have TitleParser::parseTitle() default to NS_MAIN to match Title

Matches the default parameters of Title::newFromText().

Change-Id: Id08312d424be9ae7e64688bb21687204ae77c560

3 years agoMerge "MergeHistory: Fix flaky test due to relative timestamp"
jenkins-bot [Wed, 15 Aug 2018 03:27:48 +0000 (03:27 +0000)]
Merge "MergeHistory: Fix flaky test due to relative timestamp"

3 years agordbms: Disable DBConnRef::selectDB() for sanity
Aaron Schulz [Tue, 14 Aug 2018 07:27:27 +0000 (00:27 -0700)]
rdbms: Disable DBConnRef::selectDB() for sanity

Bug: T193565
Change-Id: I4276d1a7d77a019e0e60dab4b9ec36c93e418037

3 years agoMake ExternalStoreDB "wiki" context override the server "dbname" field
Aaron Schulz [Wed, 15 Aug 2018 01:44:40 +0000 (18:44 -0700)]
Make ExternalStoreDB "wiki" context override the server "dbname" field

This is all that is needed for b/c and going beyond that can break
foreign wiki (domain) external store access if matching per-wiki DB
names *are* used for external store.

Follow up to 92e4ace7eae61.

Bug: T200471
Change-Id: I877139ff659f542da04d4d8f5ef3297dbfcfd734

3 years agoMerge "DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base"
jenkins-bot [Wed, 15 Aug 2018 01:52:55 +0000 (01:52 +0000)]
Merge "DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base"

3 years agoMerge "resourceloader: Remove $wgResourceLoaderLESSVars support"
jenkins-bot [Wed, 15 Aug 2018 01:24:36 +0000 (01:24 +0000)]
Merge "resourceloader: Remove $wgResourceLoaderLESSVars support"

3 years agoMergeHistory: Fix flaky test due to relative timestamp
Timo Tijhof [Wed, 15 Aug 2018 00:11:43 +0000 (01:11 +0100)]
MergeHistory: Fix flaky test due to relative timestamp

In PHP, `strtotime('tomorrow')` evaluates to the first midnight
after the current time.

Which means on Aug 14 at 23:59:59, strtotime('tomorrow') refers
to a timestamp merely 1 second in the future (Aug 15 00:00:00).

This causes the test to fail because this timestamp is computed
in a data provider, before the test itself starts. In order to
pass, it needs to be far enough in the future that it will also
be after the point in time where the test creates the page and
revisions in question.

Fix this by:
* ... moving it into the test itself, where even plain time()
      should probably suffice, but that's for another time.

* ... using +24*3600 instead of strtotime().

Bug: T201976
Change-Id: Ice5d54af4fb7cffa8db9b657796ba6ebecdaffa0

3 years agoDateTimeInputWidget: Rename LESS var to align with WikimediaUI Base
Volker E [Sat, 11 Aug 2018 00:14:49 +0000 (17:14 -0700)]
DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base

Change-Id: I1d3a33cb9911250793dc07758d384d7a625de1c5

3 years agoMerge "Parser: Call firstCallInit() in getTags/getFunctionHooks"
jenkins-bot [Wed, 15 Aug 2018 00:49:40 +0000 (00:49 +0000)]
Merge "Parser: Call firstCallInit() in getTags/getFunctionHooks"

3 years agoMerge "Fast manual restart for populateContentTables.php"
jenkins-bot [Wed, 15 Aug 2018 00:05:28 +0000 (00:05 +0000)]
Merge "Fast manual restart for populateContentTables.php"

3 years agoMerge "RemexDriver: improved tracing"
jenkins-bot [Wed, 15 Aug 2018 00:03:14 +0000 (00:03 +0000)]
Merge "RemexDriver: improved tracing"

3 years agoMerge "password: Move commonpasswords.cdb to includes/password/"
jenkins-bot [Tue, 14 Aug 2018 23:53:19 +0000 (23:53 +0000)]
Merge "password: Move commonpasswords.cdb to includes/password/"

3 years agoMerge "collation: Move first-letters-root to includes/collation/data"
jenkins-bot [Tue, 14 Aug 2018 23:53:14 +0000 (23:53 +0000)]
Merge "collation: Move first-letters-root to includes/collation/data"

3 years agoMerge "language: Add generate-normalize-data maintenance script"
jenkins-bot [Tue, 14 Aug 2018 23:21:10 +0000 (23:21 +0000)]
Merge "language: Add generate-normalize-data maintenance script"

3 years agoMerge "Fix reset interwiki table between tests"
jenkins-bot [Tue, 14 Aug 2018 23:17:37 +0000 (23:17 +0000)]
Merge "Fix reset interwiki table between tests"

3 years agoMerge "Follow-up fc88eea: Add new oojs-ui.styles.icons-editing-citation pack"
jenkins-bot [Tue, 14 Aug 2018 22:31:47 +0000 (22:31 +0000)]
Merge "Follow-up fc88eea: Add new oojs-ui.styles.icons-editing-citation pack"

3 years agoMerge "Upgrade wikimedia/remex-html to 2.0.0"
jenkins-bot [Tue, 14 Aug 2018 21:59:41 +0000 (21:59 +0000)]
Merge "Upgrade wikimedia/remex-html to 2.0.0"

3 years agoMerge "Fix common typo "MediWiki" in MW core"
jenkins-bot [Tue, 14 Aug 2018 21:40:47 +0000 (21:40 +0000)]
Merge "Fix common typo "MediWiki" in MW core"

3 years agoParser: Call firstCallInit() in getTags/getFunctionHooks
Kunal Mehta [Tue, 14 Aug 2018 05:49:53 +0000 (22:49 -0700)]
Parser: Call firstCallInit() in getTags/getFunctionHooks

So callers don't need to do this manually. Pointed out by Tim in T201799.

Depends-On: Ia6c36d5a650095e35093bf47e275e081e89b3daf
Change-Id: Ida62767f3ca53f99609cae01d3a20051bb92ccab

3 years agoFix common typo "MediWiki" in MW core
Alangi Derick [Tue, 14 Aug 2018 20:34:05 +0000 (21:34 +0100)]
Fix common typo "MediWiki" in MW core

Fixed typo "MediWiki" to "MediaWiki" in core.

Bug: T201491
Change-Id: I55cb4af63b72cfa08de079544c43ae9f1366a457

3 years agoMerge "Feedback form: tweak field spacing"
jenkins-bot [Tue, 14 Aug 2018 21:00:41 +0000 (21:00 +0000)]
Merge "Feedback form: tweak field spacing"

3 years agoMerge "Swap SET and WHERE statements in ChangeTags::undefineTag"
jenkins-bot [Tue, 14 Aug 2018 21:00:29 +0000 (21:00 +0000)]
Merge "Swap SET and WHERE statements in ChangeTags::undefineTag"

3 years agoFollow-up fc88eea: Add new oojs-ui.styles.icons-editing-citation pack
James D. Forrester [Tue, 14 Aug 2018 20:24:06 +0000 (13:24 -0700)]
Follow-up fc88eea: Add new oojs-ui.styles.icons-editing-citation pack

Change-Id: I8a0426fc288a499e40f02f1da7a9f1b09e6dbd5f

3 years agoMerge "build: Update eslint-config-wikimedia to 0.7.2"
jenkins-bot [Tue, 14 Aug 2018 20:49:21 +0000 (20:49 +0000)]
Merge "build: Update eslint-config-wikimedia to 0.7.2"

3 years agoRemexDriver: improved tracing
Tim Starling [Mon, 6 Aug 2018 02:15:25 +0000 (12:15 +1000)]
RemexDriver: improved tracing

Use the new RemexHtml trace features. Add two more tracing modes.

Fix missing member variable declarations and remove unused local
variables.

Change-Id: I512462e1019f9a466684abfa4aab7697b324d5b1

3 years agoUpgrade wikimedia/remex-html to 2.0.0
Kunal Mehta [Tue, 14 Aug 2018 20:38:37 +0000 (13:38 -0700)]
Upgrade wikimedia/remex-html to 2.0.0

Depends-On: Ie13945649314853cbd5707363f3a10da55752743
Change-Id: Ib6c8aaa797c128c273cde8095eb0bb1527fc0e21

3 years agoMerge "rdbms: Avoid numRows() warnings for mysqli after table creation"
jenkins-bot [Tue, 14 Aug 2018 20:24:40 +0000 (20:24 +0000)]
Merge "rdbms: Avoid numRows() warnings for mysqli after table creation"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 14 Aug 2018 20:03:52 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Idca283c3e5caa43b345988307d55b263e6fa9fc0

3 years agoSwap SET and WHERE statements in ChangeTags::undefineTag
Amir Sarabadani [Tue, 14 Aug 2018 19:00:43 +0000 (21:00 +0200)]
Swap SET and WHERE statements in ChangeTags::undefineTag

Follows-up 417d8036ae9.

It should work the other way around, I'm so stupid.

Bug: T201934
Change-Id: I69132b2c237d05242ec6ed1a1e3aca7886edf2bc

3 years agoresourceloader: Remove $wgResourceLoaderLESSVars support
Timo Tijhof [Thu, 9 Aug 2018 15:09:56 +0000 (16:09 +0100)]
resourceloader: Remove $wgResourceLoaderLESSVars support

The use of global variables was deprecated in favour of
ResourceLoaderModule::getLessVars() on a per-module basis.

Also moved testLessFileCompilation case to the appropiate file as it
covers ResourceLoaderFileModule.php, not ResourceLoader.php.

Bug: T140804
Depends-On: Ib1b2808df2384473bfac47f53a5d25d7c9bbca2b
Depends-On: I96047f69d01c4736306df2719267e6347daf556f
Change-Id: If708087c85c80355c7e78f1768529b5f2e16ed07

3 years agordbms: Avoid numRows() warnings for mysqli after table creation
Aaron Schulz [Tue, 14 Aug 2018 18:42:45 +0000 (11:42 -0700)]
rdbms: Avoid numRows() warnings for mysqli after table creation

Bug: T201900
Change-Id: Ie86a7b8e680d79ad3f9be6ca4ec260b0589e5d0e

3 years agoMerge "resourceloader: Optimise getCombinedVersion() with string concat"
jenkins-bot [Tue, 14 Aug 2018 18:52:08 +0000 (18:52 +0000)]
Merge "resourceloader: Optimise getCombinedVersion() with string concat"

3 years agoMerge "resourceloader: Remove support for `state(name, state)` signature"
jenkins-bot [Tue, 14 Aug 2018 18:41:06 +0000 (18:41 +0000)]
Merge "resourceloader: Remove support for `state(name, state)` signature"

3 years agoMerge "Move l10n_cache table to a separate DB for sqlite via the installer"
jenkins-bot [Tue, 14 Aug 2018 18:32:33 +0000 (18:32 +0000)]
Merge "Move l10n_cache table to a separate DB for sqlite via the installer"

3 years agobuild: Update eslint-config-wikimedia to 0.7.2
Ed Sanders [Tue, 14 Aug 2018 18:24:51 +0000 (19:24 +0100)]
build: Update eslint-config-wikimedia to 0.7.2

Change-Id: Ibdf9cc013e1265ef461169ec2227652eaf917900

3 years agoFeedback form: tweak field spacing
David Lynch [Tue, 14 Aug 2018 16:28:53 +0000 (11:28 -0500)]
Feedback form: tweak field spacing

Bug: T201871
Change-Id: I80ab0c7a11ef05ed063b8f58e27bd18433ea5807

3 years agoMove l10n_cache table to a separate DB for sqlite via the installer
Aaron Schulz [Thu, 5 Jul 2018 11:58:48 +0000 (12:58 +0100)]
Move l10n_cache table to a separate DB for sqlite via the installer

This does not set 'db' as the cache type so that admins can still
easily set the cache directory to use the file-based cdb system.
If they do not, then at least the second DB file will be used to
avoid heavy contention.

Bug: T93097
Change-Id: Ib3912f00cf12de99801ebda4f06135b2987ce71a

3 years agoMerge "Avoid MapCacheLRU error when MessageCache fails to load"
jenkins-bot [Tue, 14 Aug 2018 16:32:07 +0000 (16:32 +0000)]
Merge "Avoid MapCacheLRU error when MessageCache fails to load"

3 years agoMerge "Improve MapCacheLRU error message"
jenkins-bot [Tue, 14 Aug 2018 16:24:50 +0000 (16:24 +0000)]
Merge "Improve MapCacheLRU error message"

3 years agoselenium: undo page
Pablo Grass [Tue, 14 Aug 2018 14:27:31 +0000 (16:27 +0200)]
selenium: undo page

Add basic undo page object and test showing a previous edit can be
undone.

Bug: T201901
Change-Id: Idc1b3889abc6e655032bc1576f1b9d591abd6c8d

3 years agoFix typos
Fomafix [Tue, 14 Aug 2018 07:56:35 +0000 (09:56 +0200)]
Fix typos

Bug: T201491
Change-Id: I25a27d11faabe2f5fa02950c7a4fb58b13fb3662

3 years agoAvoid MapCacheLRU error when MessageCache fails to load
Aaron Schulz [Tue, 14 Aug 2018 06:03:27 +0000 (23:03 -0700)]
Avoid MapCacheLRU error when MessageCache fails to load

Bug: T201893
Change-Id: I6093113a3ffa8092dea3351a6ed6c815c7ff7162

3 years agoImprove MapCacheLRU error message
Aaron Schulz [Tue, 14 Aug 2018 05:52:22 +0000 (22:52 -0700)]
Improve MapCacheLRU error message

Bug: T201893
Change-Id: I74ef2cf31d83186f68e676da1b80c4c44ca28d69

3 years agoParser: Add accessors needed by CodeMirror
Kunal Mehta [Tue, 14 Aug 2018 05:44:48 +0000 (22:44 -0700)]
Parser: Add accessors needed by CodeMirror

Change-Id: Ia2d98baf6caed2cd779cb00aceba5785cf13d633

3 years agoFast manual restart for populateContentTables.php
Tim Starling [Tue, 14 Aug 2018 05:20:17 +0000 (15:20 +1000)]
Fast manual restart for populateContentTables.php

Currently it takes hours to scan the table if interrupted halfway
through.

Change-Id: Ibcc04b43629039c92abf9ec2cc2a1da07685d033

3 years agoFix reset interwiki table between tests
Pwirth [Mon, 6 Aug 2018 16:27:00 +0000 (16:27 +0000)]
Fix reset interwiki table between tests

This fixes the following SQL error, when the interwikilinks table was
marked as used:
Fatal error: Uncaught exception 'Wikimedia\Rdbms\DBQueryError' with message 'A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: INSERT  INTO `unittest_interwiki` (1,2,3) VALUES ('Array','Array','Array')
Function: MediaWikiTestCase::resetDB

iterator_to_array on the result of the select of the interwiki table
returns an array with the first entry having the key 1. For
multi insert to work, the array must start on 0.
Change-Id: I3dc1be9e2f016709f451fe6e8d7cc60862c1ffea

3 years agoMerge "JavaScriptMinifier: Turn $goto into a generic $model"
jenkins-bot [Tue, 14 Aug 2018 01:25:44 +0000 (01:25 +0000)]
Merge "JavaScriptMinifier: Turn $goto into a generic $model"

3 years agoMerge "Make MapCacheLRU throw errors for bad $field arguments"
jenkins-bot [Tue, 14 Aug 2018 01:17:17 +0000 (01:17 +0000)]
Merge "Make MapCacheLRU throw errors for bad $field arguments"

3 years agoMake MapCacheLRU throw errors for bad $field arguments
Aaron Schulz [Thu, 19 Jul 2018 09:50:28 +0000 (10:50 +0100)]
Make MapCacheLRU throw errors for bad $field arguments

Change-Id: Ibde33e0ff671d3428b73c66766478f58763726e1

3 years agoresourceloader: Optimise getCombinedVersion() with string concat
Timo Tijhof [Tue, 14 Aug 2018 00:39:45 +0000 (01:39 +0100)]
resourceloader: Optimise getCombinedVersion() with string concat

This is used many times in the hot path. The main motivation for
this is to reduce memory churn in that path.

By building up a string directly instead of first mapping into an
array, and than using Array#join() - we avoid some of that churn.

It terms of speed, avoiding Array#join resulted in the same
or better performance for the browsers I tested.

|                | Chrome 60     | Safari 11.1   | Firefox 61
| map+join       | 241K/s (± 2%) | 189K/s (± 5%) | 161K/s (± 6%)
| forEach+concat | 297K/s (± 1%) | 398K/s (± 2%) | 159K/s (± 13%)
| reduce         | 437K/s (± 2%) | 396K/s (± 1%) | 138K/s (± 12%)

For Chrome and Safari, 'reduce' were marked "fastest".
For Firefox, JSPerf marked all three as fastest due to the
variable ranges overlapping. Re-runs produced similar results,
each time with three cases laid out in a slightly different order
in the 130-165K/s range. The test used a copy of en.wikipedia's
current registry with the module queue of a random article.
https://jsperf.com/array-map-and-join-vs-string-concat/1

Change-Id: Ifbd8f6509ac118657c5ad2833f54fd6e8e63f9ce

3 years agoMerge "Use separate insert/delete statements to work around Blazegraph bug"
jenkins-bot [Tue, 14 Aug 2018 00:31:39 +0000 (00:31 +0000)]
Merge "Use separate insert/delete statements to work around Blazegraph bug"

3 years agoresourceloader: Remove support for `state(name, state)` signature
Timo Tijhof [Mon, 13 Aug 2018 23:55:48 +0000 (00:55 +0100)]
resourceloader: Remove support for `state(name, state)` signature

This has no usage in non-test code anywhere in Wikimedia Git,
and was only used in the test suite for mw.loader in core,
and in the test suite for the NavigationTiming extension.

The core usage is as part of this commit. The usage in NavTiming
is updated by I240ced4e65988f9.

Bug: T127328
Depends-On: I240ced4e65988f96c7ece3772378c2c9a335fb9a
Change-Id: Ic17c797e528feaf07a4777709d705615fea353e5

3 years agoMerge "rdbms: add "maxReadRows" limit to TransactionProfiler"
jenkins-bot [Mon, 13 Aug 2018 23:26:37 +0000 (23:26 +0000)]
Merge "rdbms: add "maxReadRows" limit to TransactionProfiler"

3 years agoUse separate insert/delete statements to work around Blazegraph bug
Stanislav Malyshev [Mon, 6 Aug 2018 23:40:29 +0000 (16:40 -0700)]
Use separate insert/delete statements to work around Blazegraph bug

Bug https://github.com/blazegraph/database/issues/100 happens on DELETE/INSERT
but not on separate delete and insert, try to work around it

Change-Id: Iba6a98dde6f4bea9051cd6dee91fb19db5eca10e
Bug: T201217

3 years agoMerge "Use LB server configuration to force DB domains in ExternalStorageDB"
jenkins-bot [Mon, 13 Aug 2018 22:30:44 +0000 (22:30 +0000)]
Merge "Use LB server configuration to force DB domains in ExternalStorageDB"

3 years agoMerge "Add @since to LoadBalancer getServerInfo() per a3096440627"
jenkins-bot [Mon, 13 Aug 2018 22:23:18 +0000 (22:23 +0000)]
Merge "Add @since to LoadBalancer getServerInfo() per a3096440627"

3 years agoMerge "benchmarks: Add benchmark for JavaScriptMinifier"
jenkins-bot [Mon, 13 Aug 2018 21:51:34 +0000 (21:51 +0000)]
Merge "benchmarks: Add benchmark for JavaScriptMinifier"

3 years agoMerge "benchmarks: Add a default to the 'file' option of benchmarkTidy.php"
jenkins-bot [Mon, 13 Aug 2018 21:47:32 +0000 (21:47 +0000)]
Merge "benchmarks: Add a default to the 'file' option of benchmarkTidy.php"

3 years agordbms: add "maxReadRows" limit to TransactionProfiler
Aaron Schulz [Mon, 2 Jul 2018 11:19:23 +0000 (12:19 +0100)]
rdbms: add "maxReadRows" limit to TransactionProfiler

Change-Id: I008fc1857c7aa43d93f43361803d5e52c4ddf089

3 years agoMerge "Legacy: remove unused style rules for floatleft/right"
jenkins-bot [Mon, 13 Aug 2018 20:06:20 +0000 (20:06 +0000)]
Merge "Legacy: remove unused style rules for floatleft/right"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 13 Aug 2018 19:53:21 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5e43c646bdd57b075c804b687981ed17c4c1bc81

3 years agoAdd @since to LoadBalancer getServerInfo() per a3096440627
Aaron Schulz [Mon, 13 Aug 2018 19:05:49 +0000 (12:05 -0700)]
Add @since to LoadBalancer getServerInfo() per a3096440627

Change-Id: I31de4449dca774f4da580a40581c5b82678be478

3 years agoUse LB server configuration to force DB domains in ExternalStorageDB
Aaron Schulz [Sun, 12 Aug 2018 10:14:54 +0000 (03:14 -0700)]
Use LB server configuration to force DB domains in ExternalStorageDB

This is for backwards-compatibility for pre 14ee3f210782 external store
configuration that relied on not using the main wiki DB name(s).

Bug: T200471
Change-Id: Ie60cae64e32ff2532565cbd79c8e084634a61cce

3 years agoMerge "Upgrade wikimedia/timestamp to 2.0.0"
jenkins-bot [Mon, 13 Aug 2018 18:19:14 +0000 (18:19 +0000)]
Merge "Upgrade wikimedia/timestamp to 2.0.0"

3 years agoJavaScriptMinifier: Merge $push and $pop into $model
Timo Tijhof [Mon, 13 Aug 2018 16:51:07 +0000 (17:51 +0100)]
JavaScriptMinifier: Merge $push and $pop into $model

Bug: T201606
Change-Id: Ie28ccca2c44461e67964913cc76a414dce296dce