5 years agoMerge "Use mw-parser-output for numbered external link counters"
jenkins-bot [Tue, 1 Aug 2017 15:34:07 +0000 (15:34 +0000)]
Merge "Use mw-parser-output for numbered external link counters"

5 years agoMerge "Remove unused csslint rules"
jenkins-bot [Tue, 1 Aug 2017 15:34:04 +0000 (15:34 +0000)]
Merge "Remove unused csslint rules"

5 years agoMerge "Allow blacklisting certain namespaces in Special:ShortPages"
jenkins-bot [Tue, 1 Aug 2017 14:20:30 +0000 (14:20 +0000)]
Merge "Allow blacklisting certain namespaces in Special:ShortPages"

5 years agoUse mw-parser-output for numbered external link counters
Ed Sanders [Tue, 1 Aug 2017 12:45:54 +0000 (13:45 +0100)]
Use mw-parser-output for numbered external link counters

1. Not every skin uses mw-body-content (e.g. Minerva)
2. A page may have multiple separate parser outputs,
   e.g. Flow, where the numbering context should reset.

Change-Id: I867e0da619f99600210340becd468ec293bf9667

5 years agoRemove unused csslint rules
Ed Sanders [Tue, 1 Aug 2017 12:38:24 +0000 (13:38 +0100)]
Remove unused csslint rules

Change-Id: I290f442b6a15fecd7cd2061190e52585984d2b6b

5 years agoMerge "EditPage: Drop 80% width restriction on wpSummary for OOUI form"
jenkins-bot [Mon, 31 Jul 2017 23:20:18 +0000 (23:20 +0000)]
Merge "EditPage: Drop 80% width restriction on wpSummary for OOUI form"

5 years agoEditPage: Drop 80% width restriction on wpSummary for OOUI form
James D. Forrester [Thu, 20 Jul 2017 16:25:58 +0000 (09:25 -0700)]
EditPage: Drop 80% width restriction on wpSummary for OOUI form

Bug: T64316
Change-Id: I007a92e32a62cdf8a1b3ac479386e32fb54469f5

5 years agoMerge "RCFilters: show new changes"
jenkins-bot [Mon, 31 Jul 2017 22:23:45 +0000 (22:23 +0000)]
Merge "RCFilters: show new changes"

5 years agoAllow blacklisting certain namespaces in Special:ShortPages
jdlrobson [Thu, 27 Jul 2017 23:29:21 +0000 (16:29 -0700)]
Allow blacklisting certain namespaces in Special:ShortPages

This new config variable ($wgShortPagesNamespaceBlacklist)
allows wikis to specify namespaces which should be excluded from

This will be used by Commons, for which NS_FILE is a content namespace
(accessible via Special:Random and Special:Nearby) but is not useful
to list on Special:ShortPages.

If the blacklist cancels out all namespace in wgContentNamespaces then
all namespaces will show up on the page.

Bug: T170687
Change-Id: I10b4849a5d7f3f8af75ccc6cfba230d03725c898

5 years agoMerge "Adjust print styles for thumb"
jenkins-bot [Mon, 31 Jul 2017 22:01:28 +0000 (22:01 +0000)]
Merge "Adjust print styles for thumb"

5 years agoAdjust print styles for thumb
jdlrobson [Fri, 21 Jul 2017 21:45:35 +0000 (14:45 -0700)]
Adjust print styles for thumb

* Remove all borders and margins
* Gray thumb caption color
* Increasing padding
* Aligning to left
* Explicitly choose font size

Bug: T169823
Change-Id: If32f76f11f260bb33decf1ebe934470acee66ce6

5 years agoMerge "Remove obsolete animation vendor prefix"
jenkins-bot [Mon, 31 Jul 2017 21:00:22 +0000 (21:00 +0000)]
Merge "Remove obsolete animation vendor prefix"

5 years agoMerge "Follow-up b446a3b9: don't auto-close DateInputWidget too early"
jenkins-bot [Mon, 31 Jul 2017 20:57:04 +0000 (20:57 +0000)]
Merge "Follow-up b446a3b9: don't auto-close DateInputWidget too early"

5 years agoMerge "Enable archive search by default on Special:Undelete."
jenkins-bot [Mon, 31 Jul 2017 20:33:25 +0000 (20:33 +0000)]
Merge "Enable archive search by default on Special:Undelete."

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 31 Jul 2017 20:04:15 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5389c55f987527a1ba58e11cea0937e1d6888cb7

5 years agoRemove obsolete animation vendor prefix
Volker E [Mon, 31 Jul 2017 19:34:56 +0000 (21:34 +0200)]
Remove obsolete animation vendor prefix

Opera 12.10 supported unprefixed animations, gradients, transforms &
transitions. See http://www.opera.com/docs/changelogs/unified/1210/
Opera 15 used Blink and was supported up to v30 with
`-webkit` prefix.

Change-Id: Ie8edbcd7f85c713ea2156706ea3a3a7b423d8d9d

5 years agoFollow-up b446a3b9: don't auto-close DateInputWidget too early
Roan Kattouw [Mon, 31 Jul 2017 19:22:59 +0000 (12:22 -0700)]
Follow-up b446a3b9: don't auto-close DateInputWidget too early

Clicking on a month does not mean that the user has made a selection,
it only means that if we are in { precision: 'month' } mode.
In { precision: 'day' } mode, clicking a month is navigational,
so don't auto-close in that case.

Bug: T172041
Change-Id: I16a3e15a3b69844ff866fc09ba6a9268e85b2930

5 years agoMerge "Adjustments to floating elements in print styles"
jenkins-bot [Mon, 31 Jul 2017 18:38:50 +0000 (18:38 +0000)]
Merge "Adjustments to floating elements in print styles"

5 years agoAdjustments to floating elements in print styles
jdlrobson [Fri, 21 Jul 2017 21:48:16 +0000 (14:48 -0700)]
Adjustments to floating elements in print styles

Bug: T169823
Change-Id: I38c030fe5d321f8d3419dca5a69e2a0f99ae6c16

5 years agoMerge "refreshLinks.php: Fix fatal when using --category parameter"
jenkins-bot [Mon, 31 Jul 2017 18:19:03 +0000 (18:19 +0000)]
Merge "refreshLinks.php: Fix fatal when using --category parameter"

5 years agoEnable archive search by default on Special:Undelete.
Stanislav Malyshev [Mon, 31 Jul 2017 18:11:29 +0000 (11:11 -0700)]
Enable archive search by default on Special:Undelete.

Bug: T163235
Change-Id: I7341719ec8858011965f91d873ce446efc05dcdf

5 years agoRemove StructuredChangeFiltersEnableSaving completely
Stephane Bisson [Mon, 31 Jul 2017 15:47:59 +0000 (11:47 -0400)]
Remove StructuredChangeFiltersEnableSaving completely

Follow up I9202b7ee2f9ff80106d1fb4d3e6cddec04c8b4ac

Remove one last occurence in SpecialRecentchanges.php

Change-Id: I74fd3969ad73f0b34db5c4edcf9114c27b48b187

5 years agoMerge "RCFilters: Remove $wgStructuredChangeFiltersEnableSaving feature flag"
jenkins-bot [Mon, 31 Jul 2017 13:43:36 +0000 (13:43 +0000)]
Merge "RCFilters: Remove $wgStructuredChangeFiltersEnableSaving feature flag"

5 years agoMerge "mw.htmlform: Fix hiding of the textbox for 'selectorother' fields on page...
jenkins-bot [Mon, 31 Jul 2017 13:43:32 +0000 (13:43 +0000)]
Merge "mw.htmlform: Fix hiding of the textbox for 'selectorother' fields on page load"

5 years agoRCFilters: Remove $wgStructuredChangeFiltersEnableSaving feature flag
Roan Kattouw [Fri, 28 Jul 2017 19:09:22 +0000 (12:09 -0700)]
RCFilters: Remove $wgStructuredChangeFiltersEnableSaving feature flag

It's set to true now, and the feature is mature enough that we
don't need it to be feature-flagged anymore.

Change-Id: I9202b7ee2f9ff80106d1fb4d3e6cddec04c8b4ac

5 years agoRCFilters: show new changes
Stephane Bisson [Fri, 21 Jul 2017 15:41:36 +0000 (11:41 -0400)]
RCFilters: show new changes

When "live update" is off and new changes are detected,
show a link to load and prepend the changes to the list.

Also adding a line between old and new changes
when grouping by pages is off.

Bug: T163426
Change-Id: I6a111d23956bdc04caa4c71e9deede056779aafa

5 years agomw.htmlform: Fix hiding of the textbox for 'selectorother' fields on page load
Louperivois [Thu, 8 Jun 2017 20:50:41 +0000 (16:50 -0400)]
mw.htmlform: Fix hiding of the textbox for 'selectorother' fields on page load

Bug: T166621
Change-Id: I3921651585dd8b382afc99eca18a927eba1ebe47

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 30 Jul 2017 20:05:59 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I96387423844fd658c38225a43cabdc06e258900f

5 years agorefreshLinks.php: Fix fatal when using --category parameter
Jesús Martínez Novo [Sun, 30 Jul 2017 13:39:36 +0000 (15:39 +0200)]
refreshLinks.php: Fix fatal when using --category parameter

A title object must be passed to refreshCategory(), which is created in
the above lines, not the string representation received as a parameter.

bug: T172061
Change-Id: Id579a86a26cb438c1866351064c6887dbcea23b0

5 years agoMerge "build: Update Travis CI config to use fast Trusty containers"
jenkins-bot [Sun, 30 Jul 2017 03:48:07 +0000 (03:48 +0000)]
Merge "build: Update Travis CI config to use fast Trusty containers"

5 years agoMerge "phpunit: Fix failing DeprecatedGlobalTest on HHVM at Travis CI"
jenkins-bot [Sun, 30 Jul 2017 03:47:27 +0000 (03:47 +0000)]
Merge "phpunit: Fix failing DeprecatedGlobalTest on HHVM at Travis CI"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 29 Jul 2017 20:02:39 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I65223520fecf6d5ef2ae15427edf417422c15666

5 years agoMerge "Hide "hideuser" on Special:Block for non-infinite blocks"
jenkins-bot [Sat, 29 Jul 2017 04:24:00 +0000 (04:24 +0000)]
Merge "Hide "hideuser" on Special:Block for non-infinite blocks"

5 years agobuild: Update Travis CI config to use fast Trusty containers
Timo Tijhof [Sat, 29 Jul 2017 00:56:19 +0000 (17:56 -0700)]
build: Update Travis CI config to use fast Trusty containers

We tried this before when Trusty containers were still in Beta,
but the issues we ran into at the time have since been fixed.

1. Missing package djvulibre-bin: Fixed.

2. MySQL launch problems: Fixed

Also add HHVM 3.18 to the test matrix (latest currently preinstalled
version of HHVM).

Change-Id: I2f56e303c01f069207fb086e784e49292ea4eb58

5 years agophpunit: Fix failing DeprecatedGlobalTest on HHVM at Travis CI
Timo Tijhof [Sat, 29 Jul 2017 01:02:28 +0000 (18:02 -0700)]
phpunit: Fix failing DeprecatedGlobalTest on HHVM at Travis CI

Follows-up 1d77070f19e3. On Travis CI, this test fails on HHVM:

> There was 1 failure:
> 1) DeprecatedGlobalTest::testWarning
> Failed asserting that exception of type "PHPUnit_Framework_Error" is thrown.

I've been unable to reproduce this locally, but within Travis CI
it happens on both Trusty containers and Trusty VMs, no matter the
version of HHVM. After some trial and error, I narrowed it down
to the error_reporting setting, which presumably has a different default
in the HHVM package Travis CI uses.

Change-Id: I588218103d6c72df5ad4fb6289df688b3740233e

5 years agoMerge "RCFilters: Make 'related links' collapsible"
jenkins-bot [Sat, 29 Jul 2017 01:16:05 +0000 (01:16 +0000)]
Merge "RCFilters: Make 'related links' collapsible"

5 years agoMerge "Follow-up 0b3ea6e1ab: use more flexible regex for timestamp in ChangesListSpec...
jenkins-bot [Sat, 29 Jul 2017 01:14:17 +0000 (01:14 +0000)]
Merge "Follow-up 0b3ea6e1ab: use more flexible regex for timestamp in ChangesListSpecialPageTest"

5 years agoRCFilters: Make 'related links' collapsible
Moriel Schottlender [Fri, 28 Jul 2017 07:53:57 +0000 (00:53 -0700)]
RCFilters: Make 'related links' collapsible

Bug: T166919
Change-Id: I89d69c6614f641ac92143f0b1a718145e9cd61bd

5 years agoFollow-up 0b3ea6e1ab: use more flexible regex for timestamp in ChangesListSpecialPageTest
Roan Kattouw [Sat, 29 Jul 2017 00:36:25 +0000 (17:36 -0700)]
Follow-up 0b3ea6e1ab: use more flexible regex for timestamp in ChangesListSpecialPageTest

Postgres uses timestamps like "2017-07-28 17:37:03" that aren't all numbers.

Bug: T75174
Change-Id: I1b65578c955ccdce1060783b06c2ca577796e68f

5 years agoMerge "RCFilters: Create a sticky preference for days/limit groups"
jenkins-bot [Sat, 29 Jul 2017 00:05:39 +0000 (00:05 +0000)]
Merge "RCFilters: Create a sticky preference for days/limit groups"

5 years agoMerge "Follow-up to '3D' file type addition"
jenkins-bot [Sat, 29 Jul 2017 00:03:18 +0000 (00:03 +0000)]
Merge "Follow-up to '3D' file type addition"

5 years agoMerge "Update wikimedia/relpath from 1.0.3 -> 2.0.0"
jenkins-bot [Sat, 29 Jul 2017 00:01:17 +0000 (00:01 +0000)]
Merge "Update wikimedia/relpath from 1.0.3 -> 2.0.0"

5 years agoFollow-up to '3D' file type addition
Matthias Mullie [Thu, 20 Jul 2017 14:43:50 +0000 (16:43 +0200)]
Follow-up to '3D' file type addition

Based on feedback on Id78a504302fa664b353a4c45bdc5d99f95a0180a

Bug: T157348
Change-Id: Id6bfe8d20307f62e4673a5ef30e79f164b1ea034

5 years agoUpdate wikimedia/relpath from 1.0.3 -> 2.0.0
Timo Tijhof [Fri, 28 Jul 2017 21:26:40 +0000 (14:26 -0700)]
Update wikimedia/relpath from 1.0.3 -> 2.0.0

* (4f670afd92) Normalize leading path separator to forward slash
               Fixes Windows compatibility.
* (b0eeb17d31) Drop support for PHP 5.3 and PHP 5.4.

Depends-On: I98eb809ff72c4d09bfbb89a9dad9bc7094868240
Change-Id: I4111af30dfbfe2c72d52325bbd1923773e3b4202

5 years agoMerge "RCFilters: Remember legend expand/collapse state"
jenkins-bot [Fri, 28 Jul 2017 23:12:40 +0000 (23:12 +0000)]
Merge "RCFilters: Remember legend expand/collapse state"

5 years agoMerge "RCFilters: Open limit/days popups the other way"
jenkins-bot [Fri, 28 Jul 2017 23:10:57 +0000 (23:10 +0000)]
Merge "RCFilters: Open limit/days popups the other way"

5 years agoRCFilters: Create a sticky preference for days/limit groups
Moriel Schottlender [Thu, 27 Jul 2017 22:32:32 +0000 (15:32 -0700)]
RCFilters: Create a sticky preference for days/limit groups

- Add sticky preference for groups and the operation behind
- Allow normalization from the UriProcessor
- Backwards-compatibility for saved queries
- Allow saved queries to load regardless of sticky params
  and to be compared correctly without the sticky params.
- Add days/limit preferences and update those on change
- Update the preference even if we received a new value
  from the URL.

Bug: T171514
Bug: T171368
Change-Id: I5232f3372f0e5c981332d152faf0ab47cc470b56

5 years agoMerge "RCFilters: Allow setting a new query as default"
jenkins-bot [Fri, 28 Jul 2017 23:02:25 +0000 (23:02 +0000)]
Merge "RCFilters: Allow setting a new query as default"

5 years agoRCFilters: Open limit/days popups the other way
Moriel Schottlender [Fri, 28 Jul 2017 22:58:55 +0000 (15:58 -0700)]
RCFilters: Open limit/days popups the other way

Bug: T171968
Change-Id: I83127f43cef02194c839cd0ac531ae43fa386e9a

5 years agoRCFilters: Remember legend expand/collapse state
Moriel Schottlender [Fri, 28 Jul 2017 22:19:27 +0000 (15:19 -0700)]
RCFilters: Remember legend expand/collapse state

Bug: T168043
Change-Id: I2f22f4211cfcbd9e81ee20f013fde921635e5ebc

5 years agoMerge "Adjustments to print table styles"
jenkins-bot [Fri, 28 Jul 2017 22:05:43 +0000 (22:05 +0000)]
Merge "Adjustments to print table styles"

5 years agoMerge "rdbms: Complete coverage for Database::selectSQLText()"
jenkins-bot [Fri, 28 Jul 2017 21:02:54 +0000 (21:02 +0000)]
Merge "rdbms: Complete coverage for Database::selectSQLText()"

5 years agoRCFilters: Allow setting a new query as default
Stephane Bisson [Fri, 28 Jul 2017 19:47:48 +0000 (15:47 -0400)]
RCFilters: Allow setting a new query as default

When creating a new saved query, there's a checkbox
to set it as default as the same time.

Bug: T171922
Change-Id: Id6da0e79c54bc65d76636bbff64b2ece568c0cd4

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 28 Jul 2017 19:59:25 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie36e6cc52456c039483fb52bbf56a5714d7e3128

5 years agoMerge "updateCredits: Fix collation name"
jenkins-bot [Fri, 28 Jul 2017 18:55:29 +0000 (18:55 +0000)]
Merge "updateCredits: Fix collation name"

5 years agoMerge "RCFilters: Reduce space between filters and saved queries button"
jenkins-bot [Fri, 28 Jul 2017 18:11:14 +0000 (18:11 +0000)]
Merge "RCFilters: Reduce space between filters and saved queries button"

5 years agoMerge "RCFilters: Trim input text before evaluation"
jenkins-bot [Fri, 28 Jul 2017 18:08:38 +0000 (18:08 +0000)]
Merge "RCFilters: Trim input text before evaluation"

5 years agoMerge "RCFilters: Close limit/days popups after choosing value"
jenkins-bot [Fri, 28 Jul 2017 18:07:29 +0000 (18:07 +0000)]
Merge "RCFilters: Close limit/days popups after choosing value"

5 years agoupdateCredits: Fix collation name
Bartosz Dziewoński [Fri, 28 Jul 2017 17:13:54 +0000 (19:13 +0200)]
updateCredits: Fix collation name

'uca-default-u-kn' is a valid name for MediaWiki's category collation
functionality ($wgCategoryCollation / Collation class), not for PHP's
collation functionality (Collator class).

'uca-default-u-kn' for Collation maps to 'root-u-kn' for Collator
(see Collation::factory()), and the '-u-kn' suffix is later stripped
to enable numeric collation (see IcuCollation::_construct()).

This doesn't seem to result in any changes in the output.

Change-Id: I8cc7d283aee5408f8b7bed365661ff286236a694

5 years agoMerge "resourceloader: Soft-deprecate use of global LESS variables"
jenkins-bot [Fri, 28 Jul 2017 17:09:49 +0000 (17:09 +0000)]
Merge "resourceloader: Soft-deprecate use of global LESS variables"

5 years agoresourceloader: Soft-deprecate use of global LESS variables
Timo Tijhof [Sat, 22 Jul 2017 00:29:14 +0000 (17:29 -0700)]
resourceloader: Soft-deprecate use of global LESS variables

Add deprecation notice to $wgResourceLoaderLESSVars and
hook 'ResourceLoaderGetLessVars'. Warnings to be added in 1.31.

Users should migrate to exposing variables via the individual module's
getLessVars() method.
- Ensures better cache invalidation.
- Separates concerns for getting information and exposing information
  as less variables. And allows an extension to, for example, use
  a different variable name for something if needed.

The 'deviceWidthTablet' variable will need to be migrated to
either a regular configuration variable that individual modules
can expose in their getLessVars() method - or, alternatively, we
can deprecate it altogether in favour of exposing it through
a less import file instead (see T112747). That would mean, however,
that the value can only be changed in core, not by site config.

Bug: T140804
Change-Id: I61cff1d9652d88dc53c43075dd5053b7707809e6

5 years agoMerge "resourceloader: Fix @covers for CSSMin tests"
jenkins-bot [Fri, 28 Jul 2017 14:08:42 +0000 (14:08 +0000)]
Merge "resourceloader: Fix @covers for CSSMin tests"

5 years agoAdjustments to print table styles
jdlrobson [Fri, 21 Jul 2017 21:33:52 +0000 (14:33 -0700)]
Adjustments to print table styles

* Remove bolding
* Reset backgrounds
* Explicitly choose font sizes
* Adjust paddings

Bug: T169823
Change-Id: I9c82f10fa92a24c7bcfff4458c6e5b8d2ddaffbf

5 years agoMerge "RCFilters: Make namespace and tag features no longer experimental"
jenkins-bot [Fri, 28 Jul 2017 08:18:01 +0000 (08:18 +0000)]
Merge "RCFilters: Make namespace and tag features no longer experimental"

5 years agoRCFilters: Reduce space between filters and saved queries button
Moriel Schottlender [Fri, 28 Jul 2017 08:02:45 +0000 (01:02 -0700)]
RCFilters: Reduce space between filters and saved queries button

Bug: T171822
Change-Id: I521a8e00ad8ea585b30d4d7e0ca36b1e5da031c2

5 years agoRCFilters: Trim input text before evaluation
Moriel Schottlender [Fri, 28 Jul 2017 07:28:40 +0000 (00:28 -0700)]
RCFilters: Trim input text before evaluation

Make sure that trailing and leading spaces don't affect searching
and view switches.

Bug: T168225
Change-Id: I2379c7848887ef2cb2cafa9c3cfef8cbe5ed6a62

5 years agoRCFilters: Close limit/days popups after choosing value
Moriel Schottlender [Fri, 28 Jul 2017 07:21:34 +0000 (00:21 -0700)]
RCFilters: Close limit/days popups after choosing value

Change-Id: Icd47d243ee64fdc9ab5c0790735a48ba9585e808

5 years agoMerge "Fix Special:ListUsers "subpage parameter" handling"
jenkins-bot [Fri, 28 Jul 2017 07:05:54 +0000 (07:05 +0000)]
Merge "Fix Special:ListUsers "subpage parameter" handling"

5 years agoMerge "Enable jsduck for resources/src/mediawiki.rcfilters and make pass"
jenkins-bot [Fri, 28 Jul 2017 05:48:51 +0000 (05:48 +0000)]
Merge "Enable jsduck for resources/src/mediawiki.rcfilters and make pass"

5 years agoMerge "RCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultP...
jenkins-bot [Fri, 28 Jul 2017 05:40:15 +0000 (05:40 +0000)]
Merge "RCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultParams"

5 years agoresourceloader: Fix @covers for CSSMin tests
Timo Tijhof [Fri, 28 Jul 2017 04:40:21 +0000 (21:40 -0700)]
resourceloader: Fix @covers for CSSMin tests

Change-Id: Idb451d244fbdfbb218a56c2953298b7fe29ed3d4

5 years agordbms: Complete coverage for Database::selectSQLText()
Timo Tijhof [Fri, 28 Jul 2017 04:19:53 +0000 (21:19 -0700)]
rdbms: Complete coverage for Database::selectSQLText()

Only missing cases where 'USE INDEX' and 'IGNORE INDEX'.
The test doesn't do much since the underlying methods are no-ops
by default, but at least it ensures there are no PHP errors from
these branches.

We can later re-use some of these test cases in tests specific
to one backend.

Change-Id: Id004a2ae41efaa7a367f964013e25d98ecc591ff

5 years agophpunit: Exclude /languages/messages from coverage report
Timo Tijhof [Fri, 28 Jul 2017 04:03:18 +0000 (21:03 -0700)]
phpunit: Exclude /languages/messages from coverage report

Indexing these files takes about 5-10% of the run time when generating
code coverage reports for core. It has no coverage at the moment and
probably won't any time soon given it's just variable declarations.

At least for now, exclude it to significantly speed up generating of
coverage reports.

Change-Id: I0357e004e96d4f4b19036474c8353ddb778e31f3

5 years agoEnable jsduck for resources/src/mediawiki.rcfilters and make pass
Roan Kattouw [Thu, 27 Jul 2017 23:18:19 +0000 (16:18 -0700)]
Enable jsduck for resources/src/mediawiki.rcfilters and make pass

Change-Id: I2a29689e2697108a5c5206cc61b36b5fb838182f

5 years agoMerge "Split minoredit into minoredit and enotif_minoredit"
jenkins-bot [Fri, 28 Jul 2017 00:34:55 +0000 (00:34 +0000)]
Merge "Split minoredit into minoredit and enotif_minoredit"

5 years agoSplit minoredit into minoredit and enotif_minoredit
Matthew Flaschen [Fri, 28 Jul 2017 00:11:28 +0000 (20:11 -0400)]
Split minoredit into minoredit and enotif_minoredit

This allows minoredit to have links, while enotif_minoredit can

Change-Id: I7aff9e5a5e6d460f6fce7da36a32e4717b247e4c

5 years agoRCFilters: Make namespace and tag features no longer experimental
Roan Kattouw [Thu, 27 Jul 2017 23:56:45 +0000 (16:56 -0700)]
RCFilters: Make namespace and tag features no longer experimental

Change-Id: I6a8619088d5672a156617a313d22f25701289e9c

5 years agoFollow-up 94b6ba5453: cast default value to string
Roan Kattouw [Thu, 27 Jul 2017 23:33:20 +0000 (16:33 -0700)]
Follow-up 94b6ba5453: cast default value to string

The function we're calling here expects an array of strings,
and if we pass it a number it will treat the number 50
differently from the string "50".

Change-Id: I2af535e8ef5dbbba50460013ec4d24e7f29b6b03

5 years agoRCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultParams
Roan Kattouw [Thu, 27 Jul 2017 23:17:50 +0000 (16:17 -0700)]
RCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultParams

Change-Id: Id26f4e9716d2276123881c3c74f908265dd1a52f

5 years agoMerge "mediawiki.legacy.shared can be run in mobile target"
jenkins-bot [Thu, 27 Jul 2017 22:08:44 +0000 (22:08 +0000)]
Merge "mediawiki.legacy.shared can be run in mobile target"

5 years agoMerge "benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff"
jenkins-bot [Thu, 27 Jul 2017 21:54:12 +0000 (21:54 +0000)]
Merge "benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff"

5 years agomediawiki.legacy.shared can be run in mobile target
jdlrobson [Thu, 27 Jul 2017 21:49:25 +0000 (14:49 -0700)]
mediawiki.legacy.shared can be run in mobile target

Minerva explicitly disables it
These are needed for rendering for:

Change-Id: I759c023b4ce63186929b893953042fc0a5059aa2

5 years agobenchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff
Timo Tijhof [Thu, 27 Jul 2017 21:09:41 +0000 (14:09 -0700)]
benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff

Currently, HashBagOStuff leads in most benchmarks, except for
the --fill benchmark, where MapCacheLRU is faster on HHVM.
(by invoking with `PHP=hhvm mwscript maintenance/bench...`)

Run in MediaWiki-Vagrant (Debian Jessie) on MacBook Pro host.

$ benchmarkLruHash.php --count 50000 --construct
Running PHP 5.6.30-0+deb8u1:
- HashBagOStuff-construct (22% faster)
  total: 446.20ms (min: 0.01ms, median: 0.01ms, max: 2.09ms)
- MapCacheLRU-construct
  total: 575.31ms (min: 0.01ms, median: 0.01ms, max: 3.51ms)
Running PHP version 5.6.99-hhvm:
- HashBagOStuff-construct (13% faster)
  total: 124.70ms (min: 0.00ms, median: 0.00ms, max: 1.27ms)
- MapCacheLRU-construct
  total: 143.76ms (min: 0.00ms, median: 0.00ms, max: 2.01ms)

For MapCacheLRU, the main slowdown is its use of Wikimedia\Assert.
Removing that would make it faster than HashBagOStuff.

$ benchmarkLruHash.php --count 3000 --fill
Running PHP 5.6.30-0+deb8u1:
- HashBagOStuff-fill (22% faster)
  total: 10196.82ms (min: 2.91ms, median: 3.24ms, max: 9.51ms)
- MapCacheLRU-fill
  total: 13197.13ms (min: 3.92ms, median: 4.31ms, max: 9.90ms)
Running PHP version 5.6.99-hhvm:
- HashBagOStuff-fill
  total: 5700.37ms (min: 1.71ms, median: 1.85ms, max: 8.24ms)
- MapCacheLRU-fill (11% faster)
  total: 4986.90ms (min: 1.48ms, median: 1.62ms, max: 6.93ms)

Change-Id: Icd03f872dddb308f162c72674c8d2aa6092395e5

5 years agoMerge "RCFilters: Read base value of limit/days from preference"
jenkins-bot [Thu, 27 Jul 2017 20:52:52 +0000 (20:52 +0000)]
Merge "RCFilters: Read base value of limit/days from preference"

5 years agoRCFilters: Read base value of limit/days from preference
Moriel Schottlender [Thu, 27 Jul 2017 18:20:27 +0000 (11:20 -0700)]
RCFilters: Read base value of limit/days from preference

Bug: T171368
Change-Id: I0cdbae5bf6b9d00efe351c551d1f8a52459559c4

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 27 Jul 2017 20:08:26 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie37ac9953b5715c876cb64d657ef353cf2095215

5 years agoMerge "Changing interwiki results header from <p> to <h2>"
jenkins-bot [Thu, 27 Jul 2017 18:08:22 +0000 (18:08 +0000)]
Merge "Changing interwiki results header from <p> to <h2>"

5 years agoMerge "HTMLUsersMultiSelectField: Don't use content language for placeholder message"
jenkins-bot [Thu, 27 Jul 2017 16:54:55 +0000 (16:54 +0000)]
Merge "HTMLUsersMultiSelectField: Don't use content language for placeholder message"

5 years agoFix font size and backgrounds in gallery
jdlrobson [Fri, 21 Jul 2017 21:26:19 +0000 (14:26 -0700)]
Fix font size and backgrounds in gallery

In print medium we should be explicit about font size
 - don't rely on %
and colors should be made more printer friendly

Additional changes:
* Remove some duplicated rule between gallery.print.css and
* Scope background definitions to screen medium

Bug: T169823
Change-Id: Iffcff305a4e0b973bdd52a57f52d8a0766cef512

5 years agoHTMLUsersMultiSelectField: Don't use content language for placeholder message
Roan Kattouw [Thu, 27 Jul 2017 16:38:57 +0000 (09:38 -0700)]
HTMLUsersMultiSelectField: Don't use content language for placeholder message

No idea why this was using content language to begin with, but it seems
like it should clearly use the user language instead.

Bug: T171817
Change-Id: I1763ffd8ee037dbb5dd94c410cb6a82e0f6b27e9

5 years agoMerge "New parameters 'reverse' and 'sortbyvalue' for Special:PagesWithProp"
jenkins-bot [Thu, 27 Jul 2017 16:25:01 +0000 (16:25 +0000)]
Merge "New parameters 'reverse' and 'sortbyvalue' for Special:PagesWithProp"

5 years agoChanging interwiki results header from <p> to <h2>
Jan Drewniak [Mon, 24 Jul 2017 15:44:02 +0000 (17:44 +0200)]
Changing interwiki results header from <p> to <h2>

Makes the header on interwiki results
(results from different languages on Special:Search)

Bug: T146655
Change-Id: I10ea6f85f97b4c8a5e585b2b1090af68054cbe2c

5 years agoMerge "resourceloader: Include lessVars in FileModule definition summary"
jenkins-bot [Thu, 27 Jul 2017 14:42:09 +0000 (14:42 +0000)]
Merge "resourceloader: Include lessVars in FileModule definition summary"

5 years agoMerge "UserPager: Call text() on message, don't use it directly"
jenkins-bot [Thu, 27 Jul 2017 13:43:24 +0000 (13:43 +0000)]
Merge "UserPager: Call text() on message, don't use it directly"

5 years agoUserPager: Call text() on message, don't use it directly
Prateek Saxena [Thu, 27 Jul 2017 08:11:55 +0000 (13:41 +0530)]
UserPager: Call text() on message, don't use it directly

Bug: T171806
Change-Id: Ib9a1ae7b65f8a01542c61b192252f3bb3ded1236

5 years agoMerge "Re-introduce use of mime_content_type()"
jenkins-bot [Thu, 27 Jul 2017 03:05:45 +0000 (03:05 +0000)]
Merge "Re-introduce use of mime_content_type()"

5 years agoresourceloader: Include lessVars in FileModule definition summary
Timo Tijhof [Thu, 27 Jul 2017 01:53:37 +0000 (18:53 -0700)]
resourceloader: Include lessVars in FileModule definition summary

This already worked as expected for any module that uses the new
enableModuleContentVersion model, but for the majority of file modules
this is not yet the case for performance reasons. As such, make
sure lessVars are included in our manual tracking.

Include it conditionally to avoid changing the array for other modules,
which would needlessly invalidate their cache.

Bug: T171809
Change-Id: Ib250068e0ecfc29a09ca33c23bef901ee0482bf2

5 years agoRe-introduce use of mime_content_type()
Timo Tijhof [Tue, 25 Jul 2017 05:11:17 +0000 (22:11 -0700)]
Re-introduce use of mime_content_type()

Follows-up eac059c7224. See also https://stackoverflow.com/a/39676272/319266.

This function was never deprecated. For a short time, the www.php.net
manual page for `mime_content_type` wrongly documented it as having been
deprecated in PHP 5.3, but this wasn't true, and it has been present in
every PHP version since PHP 4.3, including PHP 7 and HHVM 2.3+.

Between PHP 4.3.0-4.3.2 and PHP 5.0-5.3, the function would be absent
if the Mimemagic extension was not enabled at compile-time. However, while
mime_content_type was first introduced by the Mimemagic PHP ext, it is
backend by the Finfo extension since PHP 5.3.0.

Confirmed via https://3v4l.org/IQC1Q.

* CSSMin: Revert conditional use of finfo back to unconditional use
  of mime_content_type.

* MimeAnalyzer: Replace conditional use of finfo with unconditional use
  use of mime_content_type. Also remove the now-redundant 'else' branch.
  The 'else' branch existed because this code was written at a time where
  MediaWiki still supported PHP 4, of which some minor versions could
  sometimes be compiled without this function.

Change-Id: Iee4a0b6f616a469bb779c40e386045f9c3200446

5 years agoMerge "Use double quotes instead of singe quotes for HTML attributes"
jenkins-bot [Wed, 26 Jul 2017 23:08:57 +0000 (23:08 +0000)]
Merge "Use double quotes instead of singe quotes for HTML attributes"

5 years agoMerge "Cap 'days' param in RC/Watchlist at $wgRCMaxAge"
jenkins-bot [Wed, 26 Jul 2017 23:02:31 +0000 (23:02 +0000)]
Merge "Cap 'days' param in RC/Watchlist at $wgRCMaxAge"