lhc/web/wiklou.git
4 years agoChange the autonym of Banjar from "Bahasa Banjar" to "Banjar"
Mahuton [Wed, 28 Aug 2019 06:48:27 +0000 (08:48 +0200)]
Change the autonym of Banjar from "Bahasa Banjar" to "Banjar"

Change requested on the Sundanese Wikipedia village pump

Bug: T231283
Change-Id: Ib2f49f77634c497135c0b32256fca4e919866a38

4 years agoChange the autonym of Sunda from "Basa Sunda" to "Sunda"
Mahuton [Wed, 28 Aug 2019 07:22:16 +0000 (09:22 +0200)]
Change the autonym of Sunda from "Basa Sunda" to "Sunda"

Change requested on the Sundanese Wikipedia village pump

Bug: T228832
Change-Id: Id26493395a028b72f0254c7b866eb074eccbe1f9

4 years agoMerge "Use DatabaseBlock instead of deprecated Block in CompositeBlock tests"
jenkins-bot [Sat, 31 Aug 2019 03:34:01 +0000 (03:34 +0000)]
Merge "Use DatabaseBlock instead of deprecated Block in CompositeBlock tests"

4 years agoMerge "user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method"
jenkins-bot [Fri, 30 Aug 2019 22:50:27 +0000 (22:50 +0000)]
Merge "user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method"

4 years agoMerge "ContribsPage: Re-remove the getContribs() method"
jenkins-bot [Fri, 30 Aug 2019 22:37:41 +0000 (22:37 +0000)]
Merge "ContribsPage: Re-remove the getContribs() method"

4 years agoMerge "filebackend: fix PhpStorm warnings in FileBackend"
jenkins-bot [Fri, 30 Aug 2019 22:27:11 +0000 (22:27 +0000)]
Merge "filebackend: fix PhpStorm warnings in FileBackend"

4 years agoMerge "MessageFormatterFactory"
jenkins-bot [Fri, 30 Aug 2019 22:12:28 +0000 (22:12 +0000)]
Merge "MessageFormatterFactory"

4 years agouser: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method
Derick Alangi [Tue, 27 Aug 2019 21:43:33 +0000 (22:43 +0100)]
user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method

This method is no longer used in core or any extension per CS below;

https://codesearch.wmflabs.org/search/?q=addNewUserLogEntryAutoCreate&i=nope&files=&repos=

Change-Id: I906db9a123f6eb4210642b68525324071422eb61

4 years agoContribsPage: Re-remove the getContribs() method
DannyS712 [Thu, 29 Aug 2019 20:22:15 +0000 (20:22 +0000)]
ContribsPage: Re-remove the getContribs() method

Dependencies remove the use from Flow and ArticleFeedback.

This reverts commit e6a8e5268d8b70867e58b1c827d42fec56bb315f.

Depends-On: If77a646344b3ee89505bb17be7571f63cff16a5a
Depends-On: I3b2fa1c65cfc32e8ebc21166d32f174557694d88
Bug: T220447
Bug: T231540
Change-Id: I3f87c0310f2f2de674d8c2fa017642bcc69fd834

4 years agoMerge "rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls"
jenkins-bot [Fri, 30 Aug 2019 19:42:04 +0000 (19:42 +0000)]
Merge "rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls"

4 years agoUse DatabaseBlock instead of deprecated Block in CompositeBlock tests
Thalia [Fri, 30 Aug 2019 18:54:34 +0000 (19:54 +0100)]
Use DatabaseBlock instead of deprecated Block in CompositeBlock tests

Change-Id: I377da7e070ccd4f1ebb4a3e9619833e912180491

4 years agoMerge "Make Special:ChangeContentModel field labels consistently use colons"
jenkins-bot [Fri, 30 Aug 2019 18:38:52 +0000 (18:38 +0000)]
Merge "Make Special:ChangeContentModel field labels consistently use colons"

4 years agoMerge "Localisation updates from https://translatewiki.net."
D3r1ck01 [Fri, 30 Aug 2019 18:35:50 +0000 (18:35 +0000)]
Merge "Localisation updates from https://translatewiki.net."

4 years agoMerge "Return null from EditPage::importContentFormData"
jenkins-bot [Fri, 30 Aug 2019 18:16:05 +0000 (18:16 +0000)]
Merge "Return null from EditPage::importContentFormData"

4 years agofilebackend: fix PhpStorm warnings in FileBackend
Aaron Schulz [Wed, 17 Jul 2019 11:55:19 +0000 (04:55 -0700)]
filebackend: fix PhpStorm warnings in FileBackend

Change-Id: Ia02bc8a94a28e7582c078bb89bd92d1ecf9e2841

4 years agoMerge "Actually assign suppression-related rights to 'suppress' group"
jenkins-bot [Fri, 30 Aug 2019 17:00:46 +0000 (17:00 +0000)]
Merge "Actually assign suppression-related rights to 'suppress' group"

4 years agoMerge "Unsuppress other phan issues with low count"
jenkins-bot [Fri, 30 Aug 2019 13:55:53 +0000 (13:55 +0000)]
Merge "Unsuppress other phan issues with low count"

4 years agoMerge "Globally unsuppress phan issues with low count"
jenkins-bot [Fri, 30 Aug 2019 13:55:33 +0000 (13:55 +0000)]
Merge "Globally unsuppress phan issues with low count"

4 years agoAlso set $wgContLang in MWITC::setContentLang()
Lucas Werkmeister [Fri, 30 Aug 2019 12:31:11 +0000 (14:31 +0200)]
Also set $wgContLang in MWITC::setContentLang()

This assignment got lost in change Ie7a89f6ed7 (commit 47464abb4f) – the
resetServices() now implicit in setMwGlobals() resets the
ContentLanguage service, but does not update the $wgContLang global.
setService( 'ContentLanguage' ) does update it, but that method is
deliberately not used in this branch of setContentLang(), for reasons
that I assume are still relevant even though the comment explaining them
was removed – see change I8c60e37c17 (commit c70c2e4714).

Bug: T231630
Change-Id: I0170cc6bf40a5524523c45e8ffff8f72adc2fc47

4 years agoMerge "Add some LocalRepo integration tests"
jenkins-bot [Fri, 30 Aug 2019 11:42:55 +0000 (11:42 +0000)]
Merge "Add some LocalRepo integration tests"

4 years agoUnsuppress other phan issues with low count
Daimona Eaytoy [Thu, 29 Aug 2019 13:19:39 +0000 (15:19 +0200)]
Unsuppress other phan issues with low count

And also update approximated counts, which for the most part are lower
than reported (hooray!)

Bug: T231636
Depends-On: Ica50297ec7c71a81ba2204f9763499da925067bd
Change-Id: I78354bf5f0c831108c8f606e50c87cf6bc00d8bd

4 years agoIntroduce BlobStore::getBlobBatch method
Petr Pchelko [Mon, 26 Aug 2019 20:18:50 +0000 (13:18 -0700)]
Introduce BlobStore::getBlobBatch method

Bug: T230834
Change-Id: I56306c50a6617dc91e4eb362ef010703ac25d951

4 years agoGlobally unsuppress phan issues with low count
Daimona Eaytoy [Thu, 29 Aug 2019 09:59:59 +0000 (11:59 +0200)]
Globally unsuppress phan issues with low count

All of these suppression prevent the detection of many common mistakes,
and could easily prevent things like T231488. Especially if there are
few issues of a given type, it's way better to suppress them inline,
instead of disabling them for the whole core.
This patch only touches the one with a lower count (although those
counts may be out of date).

Bug: T231636
Change-Id: Ica50297ec7c71a81ba2204f9763499da925067bd

4 years agoAdd some LocalRepo integration tests
Aryeh Gregor [Mon, 26 Aug 2019 16:06:04 +0000 (19:06 +0300)]
Add some LocalRepo integration tests

Coverage is still far from 100%, but better than nothing.

Change-Id: Ifb22491414653a5730a83434c4ea31a3540f7d26

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 30 Aug 2019 07:05:17 +0000 (09:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I386c2b204c10a0d8d79d95f78b502bc3585dbb7d

4 years agordbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls
Aaron Schulz [Fri, 30 Aug 2019 04:53:38 +0000 (21:53 -0700)]
rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls

Place more calls in LBFactory and un-owned LoadBalancer instances

Bug: T231443
Change-Id: Id93e70ada114801efe3aa81e865f0a930489bd29

4 years agoMerge "resourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS"
jenkins-bot [Fri, 30 Aug 2019 02:00:29 +0000 (02:00 +0000)]
Merge "resourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS"

4 years agoresourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS
Timo Tijhof [Fri, 30 Aug 2019 00:40:48 +0000 (01:40 +0100)]
resourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS

Added originally in c46fc745a9de7201e based on the support document for
jQuery Mobile 1.3, via <https://jquerymobile.com/browser-support/1.3/>.

These have been obsolete since T102318 because startup.js is now a feature
test, with UA-snifs only for browsers that both *do* have all Grade A
capabilities for which we still want to disable the JS pipeline.

* Palm WebOS: Upstream jQuery 1.x allegedly worked fine on WebOS 1.4+.
  Not sure why we excluded WebOS <= 1.4, looks like that should have
  been <= 1.3 instead.
  If it doesn't have the neccecary HTML5/ES5/CSS3 features,
  it will remain in Grade C without a sniff. Otherwise, it's probably
  fine to enable. Either way, not officially supported (Grade X).

  Usage on WMF wikis is presumed less than 0.1% as neiter Palm nor
  WebOS show up on https://analytics.wikimedia.org/.

  The example UAs mention WebKit/525 and WebKit/532 which
  correlate with Safari 3.x and Safari 4.x, which we know
  doesn't pass the feature test.

* Symbian:
  The example UAs mention WebKit/413 which corelates with Safari 2,
  which we know doesn't pass the feature test.

Change-Id: I62a83e3b4967f309739095d9c73650f9859ee856

4 years agoMerge "logging: Deprecate LogEventsList::$mDefaultQuery member"
jenkins-bot [Fri, 30 Aug 2019 00:15:30 +0000 (00:15 +0000)]
Merge "logging: Deprecate LogEventsList::$mDefaultQuery member"

4 years agoMerge "Improve formatting of constructor documentation for block classes"
jenkins-bot [Thu, 29 Aug 2019 22:49:59 +0000 (22:49 +0000)]
Merge "Improve formatting of constructor documentation for block classes"

4 years agoMerge "Preserve grapheme clusters in upper corner completion suggester highlighting"
jenkins-bot [Thu, 29 Aug 2019 22:16:19 +0000 (22:16 +0000)]
Merge "Preserve grapheme clusters in upper corner completion suggester highlighting"

4 years agoPreserve grapheme clusters in upper corner completion suggester highlighting
tjones [Mon, 19 Aug 2019 18:23:33 +0000 (14:23 -0400)]
Preserve grapheme clusters in upper corner completion suggester highlighting

Grapheme clusters in Indic scripts can be split by highlighting,
resulting in really ugly text in the suggestions. For example,
म +  े should equal मे, but doesn't if highlighting markup comes between
the two characters. Affected scripts include Devanagari, Tamil, Telegu,
Thai, Myanmar, Khmer, and Javanese, and probably others. Latin and
Cyrillic script also have the problem, but the presentation is not as
bad (at least on some browser/OS combinations).

- Define a comboMarks regex (equivalent to \p{Mark} in other programming
languages) and use it in a new highlighting function,
prefixPlusComboHighlight, to include trailing combining characters in
highlighted text.

- Change the calling function to use prefixPlusComboHighlight instead of
prefixHighlight.

Note: This only fixes problems with **grapheme clusters** in
suggestions in the **search box in the upper corner** (upper right in
LTR languages, upper left in RTL languages). The main search box on the
Special:Search page uses different code. Ligatures, such as
Arabic ي + ا becoming يا, are not covered by this simple regex-based
solution.

Bug: T35242
Change-Id: I915c50180bc2196e0302f27835241624b7837f16

4 years agologging: Deprecate LogEventsList::$mDefaultQuery member
Derick Alangi [Thu, 29 Aug 2019 21:16:28 +0000 (22:16 +0100)]
logging: Deprecate LogEventsList::$mDefaultQuery member

This is a follow up on follow-up-I91003a9a3f2a56114de5b

Change-Id: If670ed959bcbc3149b0979541c641ada63377b7f

4 years agoMerge "Move User::getAllRights to PermissionManager."
jenkins-bot [Thu, 29 Aug 2019 21:00:23 +0000 (21:00 +0000)]
Merge "Move User::getAllRights to PermissionManager."

4 years agoMerge "Remove usages of Title::quickUserCan"
jenkins-bot [Thu, 29 Aug 2019 20:58:02 +0000 (20:58 +0000)]
Merge "Remove usages of Title::quickUserCan"

4 years agoMerge "ContribsPage: bring back getContribs() method"
jenkins-bot [Thu, 29 Aug 2019 19:42:46 +0000 (19:42 +0000)]
Merge "ContribsPage: bring back getContribs() method"

4 years agoContribsPage: bring back getContribs() method
daniel [Thu, 29 Aug 2019 18:00:27 +0000 (20:00 +0200)]
ContribsPage: bring back getContribs() method

Follows-up 73664393f8da2ec.

Apparently the method still has callers. Hot fix (UBN).

Bug: T231540
Change-Id: I09ba81fc7ac4afe4c5cc54c3a589a54e31e9c419

4 years agoRemove usages of Title::quickUserCan
Petr Pchelko [Fri, 23 Aug 2019 23:53:15 +0000 (16:53 -0700)]
Remove usages of Title::quickUserCan

Change-Id: Ifa53e0ec800e23dc4184d133a100fb9378dfee9e

4 years agoMerge "mime,logging: Remove unused private methods"
jenkins-bot [Thu, 29 Aug 2019 18:27:10 +0000 (18:27 +0000)]
Merge "mime,logging: Remove unused private methods"

4 years agoMerge "Integration tests for Language fallback methods"
jenkins-bot [Thu, 29 Aug 2019 18:18:10 +0000 (18:18 +0000)]
Merge "Integration tests for Language fallback methods"

4 years agoMerge "createNoOpMock() method for PHPUnit tests"
jenkins-bot [Thu, 29 Aug 2019 18:15:43 +0000 (18:15 +0000)]
Merge "createNoOpMock() method for PHPUnit tests"

4 years agoMerge "filerepo: rename resolveToStoragePath() and tweak file operation arrays"
jenkins-bot [Thu, 29 Aug 2019 18:12:04 +0000 (18:12 +0000)]
Merge "filerepo: rename resolveToStoragePath() and tweak file operation arrays"

4 years agoMerge "HashRing optimizations and PhpStorm warning work-arounds"
jenkins-bot [Thu, 29 Aug 2019 18:06:28 +0000 (18:06 +0000)]
Merge "HashRing optimizations and PhpStorm warning work-arounds"

4 years agoMerge "Remove $wgMemCachedDebug"
jenkins-bot [Thu, 29 Aug 2019 18:06:20 +0000 (18:06 +0000)]
Merge "Remove $wgMemCachedDebug"

4 years agoMerge "filebackend: fix @throws comment in FileBackend::makeContentDisposition()"
jenkins-bot [Thu, 29 Aug 2019 18:02:14 +0000 (18:02 +0000)]
Merge "filebackend: fix @throws comment in FileBackend::makeContentDisposition()"

4 years agoMerge "filebackend: add idiom constant to FileBackend for null results"
jenkins-bot [Thu, 29 Aug 2019 17:55:39 +0000 (17:55 +0000)]
Merge "filebackend: add idiom constant to FileBackend for null results"

4 years agomime,logging: Remove unused private methods
Derick Alangi [Thu, 29 Aug 2019 11:44:53 +0000 (12:44 +0100)]
mime,logging: Remove unused private methods

These methods are defined but not used.

Change-Id: I91003a9a3f2a56114de5baede6a1034ee4ed8d80

4 years agofilerepo: rename resolveToStoragePath() and tweak file operation arrays
Aaron Schulz [Fri, 23 Aug 2019 16:44:24 +0000 (09:44 -0700)]
filerepo: rename resolveToStoragePath() and tweak file operation arrays

This makes it clearer what the method actually does

Change-Id: Ifd69484560eb2949242927bea820c1c7786c43d2

4 years agoHashRing optimizations and PhpStorm warning work-arounds
Aaron Schulz [Sat, 17 Aug 2019 18:55:06 +0000 (14:55 -0400)]
HashRing optimizations and PhpStorm warning work-arounds

Change-Id: I640636575f06a419e0f78504d8e7ba61edfad8e8

4 years agoRemove $wgMemCachedDebug
Aaron Schulz [Wed, 28 Aug 2019 21:11:21 +0000 (14:11 -0700)]
Remove $wgMemCachedDebug

Change-Id: I98380ac1cb66e33719b4836410311aea3513115c

4 years agoMake ObjectCache check the value of apc.enable_cli in CLI mode
Aaron Schulz [Wed, 28 Aug 2019 14:23:19 +0000 (07:23 -0700)]
Make ObjectCache check the value of apc.enable_cli in CLI mode

Add HashBagOStuff fallback for APC in MWLBFactory::injectObjectCaches.

Also fix APC-cache variable typo in MWLBFactory.

Bug: T227838
Change-Id: I71cb2ca58972ea09ab2f64f7e47bda7a5096c19b

4 years agoIntegration tests for Language fallback methods
Aryeh Gregor [Sun, 25 Aug 2019 11:15:53 +0000 (14:15 +0300)]
Integration tests for Language fallback methods

100% coverage.  Next: reimplementation as a service, and tests for the
new service.

Change-Id: Icdd5b84eb91fc83905209ce08d499011f7288e33

4 years agoMerge "build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issues"
jenkins-bot [Thu, 29 Aug 2019 15:22:09 +0000 (15:22 +0000)]
Merge "build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issues"

4 years agocreateNoOpMock() method for PHPUnit tests
Aryeh Gregor [Wed, 28 Aug 2019 10:01:39 +0000 (13:01 +0300)]
createNoOpMock() method for PHPUnit tests

This is just a shortcut for a commonly-used pattern, when you want to
create a mock that's never supposed to have methods called.

Change-Id: Ia7267e3d3108c1ff94485f7e44bf409808a762be

4 years agoMerge "Fix FileBackendGroup test for some configurations"
jenkins-bot [Thu, 29 Aug 2019 14:53:49 +0000 (14:53 +0000)]
Merge "Fix FileBackendGroup test for some configurations"

4 years agoMove User::getAllRights to PermissionManager.
Petr Pchelko [Wed, 28 Aug 2019 17:31:34 +0000 (10:31 -0700)]
Move User::getAllRights to PermissionManager.

Bug: T220191
Change-Id: I7f4bf7f6a85b01ffd7f9ea3991597f1bd40ab1f6

4 years agoFix FileBackendGroup test for some configurations
Aryeh Gregor [Thu, 29 Aug 2019 11:10:46 +0000 (14:10 +0300)]
Fix FileBackendGroup test for some configurations

The expected value of FileBackendGroup::config()['srvCache'] was being
obtained from MediaWikiServices::getLocalServerObjectCache(), but the
class actually used ObjectCache::getLocalServerInstance( 'hash' ). It
happens these are often the same, so it passed the gate-and-submit jobs,
but it's causing failures on Travis CI.

Follow-up to bd2a4395025, which added the failing test. Thanks to
Krinkle for pointing out the failures on CI.

Change-Id: I17651766f4ee2752dfcae9574d2538269dec4ebe

4 years agoMerge "Remove unneeded overrideMwServices/resetServices"
jenkins-bot [Thu, 29 Aug 2019 13:22:31 +0000 (13:22 +0000)]
Merge "Remove unneeded overrideMwServices/resetServices"

4 years agoMerge "Call resetServices() when setting globals in tests"
jenkins-bot [Thu, 29 Aug 2019 13:21:27 +0000 (13:21 +0000)]
Merge "Call resetServices() when setting globals in tests"

4 years agoImprove formatting of constructor documentation for block classes
Thalia [Thu, 29 Aug 2019 12:18:50 +0000 (13:18 +0100)]
Improve formatting of constructor documentation for block classes

Change-Id: Idced6ce907f63d2c041d1bb926b8224ece54c3de

4 years agoMerge "Add UnknownContentHandler."
jenkins-bot [Thu, 29 Aug 2019 12:09:45 +0000 (12:09 +0000)]
Merge "Add UnknownContentHandler."

4 years agoRemove unneeded overrideMwServices/resetServices
Aryeh Gregor [Mon, 26 Aug 2019 09:13:49 +0000 (12:13 +0300)]
Remove unneeded overrideMwServices/resetServices

Change-Id: If6cbdec05b8f310ef3a0b4649aaa16d9fb80a047

4 years agoCall resetServices() when setting globals in tests
Aryeh Gregor [Mon, 26 Aug 2019 08:17:59 +0000 (11:17 +0300)]
Call resetServices() when setting globals in tests

Now that resetServices() will preserve (but reset) customized services,
it should be reasonably safe to call it every time globals are changed,
and much more effective than relying on tests to call it every time
themselves.

Depends-On: Iab8ea3a61bbc6803805d855ef23c071067646f71
Depends-On: I00e35ecea6a27468674b2a6e7d9d9eb6518e3bd5
Change-Id: Ie7a89f6ed7d52a0bc01672019ff92e7ee105a1f3

4 years agoAvoid fatal errors when reporting exceptions.
daniel [Thu, 29 Aug 2019 11:07:46 +0000 (13:07 +0200)]
Avoid fatal errors when reporting exceptions.

When reporting exceptions that occur during initialization, wgUser may
be null. Don't die when that happens.

Change-Id: I65d5a17d80f9021e28a218c7a5a17e399bc7ce98

4 years agoAdd UnknownContentHandler.
daniel [Wed, 21 Aug 2019 15:51:10 +0000 (17:51 +0200)]
Add UnknownContentHandler.

UnknownContentHandler can be configued to handle models that
belong to extensions that have been undeployed:

  $wgContentHandlers['xyzzy'] = 'UnknownContentHandler';

This way, no errors will be thrown when trying to access
pages with the unsupported model. Instead, an error message is
shown, and editing is prevented.

This patch also improves handling of non-editable content in
EditPage and in DifferenceEngine.

Bug: T220608
Change-Id: Ia94521b786c0a5225a674e4dc3cb6761a723d75b

4 years agofilebackend: add idiom constant to FileBackend for null results
Aaron Schulz [Thu, 29 Aug 2019 08:14:24 +0000 (01:14 -0700)]
filebackend: add idiom constant to FileBackend for null results

Change-Id: I65f043e87d82192c13d3627fb45ef222f0290bf8

4 years agoMerge "Fix categories detele SPARQL clause"
jenkins-bot [Thu, 29 Aug 2019 06:51:45 +0000 (06:51 +0000)]
Merge "Fix categories detele SPARQL clause"

4 years agofilebackend: fix @throws comment in FileBackend::makeContentDisposition()
Aaron Schulz [Thu, 29 Aug 2019 05:32:59 +0000 (22:32 -0700)]
filebackend: fix @throws comment in FileBackend::makeContentDisposition()

Change-Id: I653b0c9b28939a0976328ed1de6444dd38b7fa55

4 years agoMerge "profiler: Centralise output responsibility from ProfilerOutputText to Profiler"
jenkins-bot [Thu, 29 Aug 2019 05:25:40 +0000 (05:25 +0000)]
Merge "profiler: Centralise output responsibility from ProfilerOutputText to Profiler"

4 years agoMerge "mediawiki.Uri: Add another test for arrayParams"
jenkins-bot [Thu, 29 Aug 2019 03:19:42 +0000 (03:19 +0000)]
Merge "mediawiki.Uri: Add another test for arrayParams"

4 years agomediawiki.Uri: Add another test for arrayParams
Bartosz Dziewoński [Wed, 28 Aug 2019 12:17:13 +0000 (14:17 +0200)]
mediawiki.Uri: Add another test for arrayParams

Verify that the added handling is correctly conditional.

Bug: T231382
Change-Id: I71b834c1c0a7bdaf28d990eafd4ce5d70a55e141

4 years agoMerge "Special:NewFiles: Use a proper user widget instead"
jenkins-bot [Wed, 28 Aug 2019 20:57:14 +0000 (20:57 +0000)]
Merge "Special:NewFiles: Use a proper user widget instead"

4 years agoMerge "resourceloader: Purge localStorage blob if last written 30+ days ago"
jenkins-bot [Wed, 28 Aug 2019 20:57:07 +0000 (20:57 +0000)]
Merge "resourceloader: Purge localStorage blob if last written 30+ days ago"

4 years agoMerge "Pagers: Drop 'newbie' feature"
jenkins-bot [Wed, 28 Aug 2019 20:43:44 +0000 (20:43 +0000)]
Merge "Pagers: Drop 'newbie' feature"

4 years agoMerge "Fix call to non-existing TempFSFileFactory::getTempFSFile()"
jenkins-bot [Wed, 28 Aug 2019 20:09:58 +0000 (20:09 +0000)]
Merge "Fix call to non-existing TempFSFileFactory::getTempFSFile()"

4 years agoMerge "Special:DeletedContributions: Drop 'newbies' feature"
Jforrester [Wed, 28 Aug 2019 19:23:51 +0000 (19:23 +0000)]
Merge "Special:DeletedContributions: Drop 'newbies' feature"

4 years agoFix call to non-existing TempFSFileFactory::getTempFSFile()
daniel [Wed, 28 Aug 2019 19:08:58 +0000 (21:08 +0200)]
Fix call to non-existing TempFSFileFactory::getTempFSFile()

Should be TempFSFileFactory::newTempFSFile()

Bug: T231488
Change-Id: I9fbf7d993773f55965268ac10b347110148671c9

4 years agoMerge "Fix typo in comment"
jenkins-bot [Wed, 28 Aug 2019 18:51:41 +0000 (18:51 +0000)]
Merge "Fix typo in comment"

4 years agoMerge "Make WantedQueryPage::makeWlhLink protected"
jenkins-bot [Wed, 28 Aug 2019 18:46:51 +0000 (18:46 +0000)]
Merge "Make WantedQueryPage::makeWlhLink protected"

4 years agoMerge "PermissionManager should not cache anonymous rights under ID 0"
jenkins-bot [Wed, 28 Aug 2019 18:21:37 +0000 (18:21 +0000)]
Merge "PermissionManager should not cache anonymous rights under ID 0"

4 years agoSpecial:NewFiles: Use a proper user widget instead
James D. Forrester [Fri, 2 Aug 2019 19:34:44 +0000 (12:34 -0700)]
Special:NewFiles: Use a proper user widget instead

Change-Id: I276f55e9d4dd2d539dae232c7a4c1e71745a6168

4 years agoPagers: Drop 'newbie' feature
James D. Forrester [Fri, 2 Aug 2019 19:33:56 +0000 (12:33 -0700)]
Pagers: Drop 'newbie' feature

Change-Id: I14c4da7b107aa9c712bd81522021ae7ecaf2b790

4 years agoSpecial:DeletedContributions: Drop 'newbies' feature
James D. Forrester [Tue, 27 Aug 2019 20:41:00 +0000 (13:41 -0700)]
Special:DeletedContributions: Drop 'newbies' feature

Change-Id: I32c67fb19f50f3949ffe981488c009c82a244999

4 years agoMerge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Wed, 28 Aug 2019 17:41:39 +0000 (17:41 +0000)]
Merge "Sync up with Parsoid parserTests.txt"

4 years agoMerge "Remove unused localisation message 'wlshowlast'"
jenkins-bot [Wed, 28 Aug 2019 17:34:58 +0000 (17:34 +0000)]
Merge "Remove unused localisation message 'wlshowlast'"

4 years agoMerge "Remove unused localisation messages 'ascending_abbrev', 'descending_abbrev'"
jenkins-bot [Wed, 28 Aug 2019 17:33:48 +0000 (17:33 +0000)]
Merge "Remove unused localisation messages 'ascending_abbrev', 'descending_abbrev'"

4 years agoMerge "Upstream "pulsating dot" widget from VE"
jenkins-bot [Wed, 28 Aug 2019 17:23:53 +0000 (17:23 +0000)]
Merge "Upstream "pulsating dot" widget from VE"

4 years agoMake WantedQueryPage::makeWlhLink protected
Ostrzyciel [Wed, 28 Aug 2019 17:12:36 +0000 (19:12 +0200)]
Make WantedQueryPage::makeWlhLink protected

Bug: T231481
Change-Id: I6ace1bb99879ec8256b29f86220e8fc2e785f593

4 years agoMerge "Integration tests for FileBackendGroup"
jenkins-bot [Wed, 28 Aug 2019 17:09:44 +0000 (17:09 +0000)]
Merge "Integration tests for FileBackendGroup"

4 years agoMerge "Grunt: Expand js{,on} for readability"
jenkins-bot [Wed, 28 Aug 2019 17:04:44 +0000 (17:04 +0000)]
Merge "Grunt: Expand js{,on} for readability"

4 years agoPermissionManager should not cache anonymous rights under ID 0
Petr Pchelko [Tue, 20 Aug 2019 20:59:49 +0000 (13:59 -0700)]
PermissionManager should not cache anonymous rights under ID 0

Bug: T228253
Change-Id: I8a54830842f220ff1ac4402a3380c2229a99b619

4 years agoprofiler: Centralise output responsibility from ProfilerOutputText to Profiler
Timo Tijhof [Wed, 28 Aug 2019 00:41:42 +0000 (01:41 +0100)]
profiler: Centralise output responsibility from ProfilerOutputText to Profiler

Make it Profiler.php's responsibility to enforce this, based on the
existing signal from ProfilerOutput::logsToOutput().

The ProfilerOutputText class should not have to double-check this
a second time.

Long-term, I'd like even this check in Profiler::logDataPageOutputOnly
to be removed, because really the external caller of that should
know whether it is safe to output stuff or not rather than stashing
its own state inside Profiler::$allowOutput and then implicitly
reading it back out again later on. But, that's for another time.

Also:
* Remove use of deprecated Profiler::setTemplated while at it.
* Make 'visible' parameter explicit, as for other parameters.

Change-Id: Iaa3fc4ea25a059b90235d769db60c04b8f152f05

4 years agoSync up with Parsoid parserTests.txt
Arlo Breault [Wed, 28 Aug 2019 16:05:09 +0000 (12:05 -0400)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit 06a41a99d7811a361446b894da7c5c8224398ad1

Change-Id: I9d324b3e6e9167683c15b7fee2a53b598d79a67c

4 years agoDocs: Standardise "messages used" comments
Ed Sanders [Wed, 28 Aug 2019 15:41:47 +0000 (16:41 +0100)]
Docs: Standardise "messages used" comments

Change-Id: Ie99f8a62da734956863b1e1c41c8768f0e083fed

4 years agoGrunt: Expand js{,on} for readability
Ed Sanders [Wed, 28 Aug 2019 15:40:08 +0000 (16:40 +0100)]
Grunt: Expand js{,on} for readability

Change-Id: Ib3bfb1a9d6547e1062ea3ad08de7ea721c111586

4 years agoMerge "ApiFeedContributions: Drop 'newbies' feature"
jenkins-bot [Wed, 28 Aug 2019 15:25:51 +0000 (15:25 +0000)]
Merge "ApiFeedContributions: Drop 'newbies' feature"

4 years agoApiFeedContributions: Drop 'newbies' feature
James D. Forrester [Tue, 27 Aug 2019 20:40:40 +0000 (13:40 -0700)]
ApiFeedContributions: Drop 'newbies' feature

It has been broken since 2011 (r100315), so no need for
deprecation.

Change-Id: I099f52211c8ce401d827405cb313e1d3932b92f8

4 years agoMerge "skins: Skin::getSkinNameMessages() method is now deprecated"
jenkins-bot [Wed, 28 Aug 2019 12:56:25 +0000 (12:56 +0000)]
Merge "skins: Skin::getSkinNameMessages() method is now deprecated"

4 years agoMerge "skins: Remove use of deprecated MessageCache::singleton()"
jenkins-bot [Wed, 28 Aug 2019 12:56:19 +0000 (12:56 +0000)]
Merge "skins: Remove use of deprecated MessageCache::singleton()"

4 years agoRemove unused localisation message 'wlshowlast'
Bartosz Dziewoński [Wed, 28 Aug 2019 10:51:44 +0000 (12:51 +0200)]
Remove unused localisation message 'wlshowlast'

Not used since 34a3efd5f75ca25f1b8b3b3a2efd13bfb1f7c631.

Note that a similar message 'rclinks' is still used.

Bug: T224429
Change-Id: I471a6a88b838bd7f1fab34c531c556e8ccd2779a