lhc/web/wiklou.git
10 years agoAdd vendor to mwdocgen's excludes list.
Daniel Friesen [Sat, 8 Jun 2013 11:07:57 +0000 (04:07 -0700)]
Add vendor to mwdocgen's excludes list.

Now that we support composer libraries we should exclude vendor/
so that our Doxygen script doesn't go generating documentation
for 3rd party libraries we use.

Change-Id: I40502015820f0b9b4b1ef5810bcddcc5970134c5

10 years agoMerge "Fix comment for mw.user.sessionId()"
jenkins-bot [Sat, 8 Jun 2013 10:54:37 +0000 (10:54 +0000)]
Merge "Fix comment for mw.user.sessionId()"

10 years agoFix comment for mw.user.sessionId()
S Page [Sat, 8 Jun 2013 06:15:27 +0000 (23:15 -0700)]
Fix comment for mw.user.sessionId()

Change-Id: I19ab8b6de9f7bfe4418a6cab863ee97b77905795

10 years agoFix Thai link trail regexp
Gabriel Wicke [Sat, 8 Jun 2013 01:37:42 +0000 (18:37 -0700)]
Fix Thai link trail regexp

Escaping the end anchor is unlikely to be useful. This was noticed as it
resulted in an invalid regexp after being transformed in Parsoid.

Change-Id: I955215c83ff29032f8276b0fa3e6b9701a1f2359

10 years agoMerge "Made SwiftFileBackend::loadObjectListing() populate stat entries in reverse...
jenkins-bot [Fri, 7 Jun 2013 23:40:44 +0000 (23:40 +0000)]
Merge "Made SwiftFileBackend::loadObjectListing() populate stat entries in reverse order."

10 years agoMerge "Hide exceptions in MediaWiki::doJobs() as deferred updates do."
jenkins-bot [Fri, 7 Jun 2013 23:37:25 +0000 (23:37 +0000)]
Merge "Hide exceptions in MediaWiki::doJobs() as deferred updates do."

10 years agoGitweb -> Gitblit
Alex Monk [Fri, 7 Jun 2013 22:03:18 +0000 (23:03 +0100)]
Gitweb -> Gitblit

Change-Id: I54387a6ca5ed020e66594d4bf410a042d4ae010f

10 years agoMerge "Support installing PHPUnit using composer."
jenkins-bot [Fri, 7 Jun 2013 21:09:31 +0000 (21:09 +0000)]
Merge "Support installing PHPUnit using composer."

10 years agoMerge "Enhancement: Allow XmlTypeCheck for strings"
jenkins-bot [Fri, 7 Jun 2013 20:07:08 +0000 (20:07 +0000)]
Merge "Enhancement: Allow XmlTypeCheck for strings"

10 years agoMerge "Allow server selection when running sql.php"
jenkins-bot [Fri, 7 Jun 2013 18:28:12 +0000 (18:28 +0000)]
Merge "Allow server selection when running sql.php"

10 years agoMerge "Use getPrefixedDBkey() for template profile call."
jenkins-bot [Fri, 7 Jun 2013 18:18:41 +0000 (18:18 +0000)]
Merge "Use getPrefixedDBkey() for template profile call."

10 years agoEnhancement: Allow XmlTypeCheck for strings
physikerwelt [Sun, 2 Jun 2013 17:24:32 +0000 (17:24 +0000)]
Enhancement: Allow XmlTypeCheck for strings

This change allows that the class XmlTypeCheck can be used to
check strings as well as files. Therefore the constructor has
been extended to one further element that indicates if the
input to be checked is a file or a string.

The functionality is tested with php unit tests.

Change-Id: I7432a754a512e0324c171667c3eac9d8e7838e0e

10 years agoShow rollback link on changes list only for RC_EDIT
umherirrender [Thu, 30 May 2013 05:25:07 +0000 (07:25 +0200)]
Show rollback link on changes list only for RC_EDIT

Changing from !RC_NEW to RC_EDIT to have no rollback links, when this
method is called accidently for RC_LOG or RC_EXTERNAL (or for the old
RC_MOVE/RC_MOVE_OVER_REDIRECT). For that types there are 0 revisions to
rollback.

Change-Id: I1cbdc87a8b8e0cecf6fbfa3b3a64d5015057bccf

10 years agoUse getPrefixedDBkey() for template profile call.
Aaron Schulz [Fri, 7 Jun 2013 17:42:59 +0000 (10:42 -0700)]
Use getPrefixedDBkey() for template profile call.

Change-Id: Iac5183635984aa9261c1e85e32f6bb173ec513ae

10 years agoMerge "Fixed long memcached keys for infoaction."
Aaron Schulz [Fri, 7 Jun 2013 17:11:18 +0000 (17:11 +0000)]
Merge "Fixed long memcached keys for infoaction."

10 years agoSupport installing PHPUnit using composer.
Daniel Friesen [Mon, 3 Jun 2013 10:35:35 +0000 (03:35 -0700)]
Support installing PHPUnit using composer.

"phpunit/phpunit" already exists inside our composer.json's "require-dev" however this has been
entirely useless as we don't include the autoloader which would load composer's PHPUnit.

This change begins including composer's autoloader when present and also tweaks phpunit.php
to ensure PHPUnit isn't double loaded. As a result besides supporting PHPUnit via composer this
also means that we're ready to make use of any library we add to our composer.json in the future.

Change-Id: I891740e8fd3d237c5f473862027205d951f564b9

10 years agoMerge ""Your domain" appearance fixes for new forms"
jenkins-bot [Thu, 6 Jun 2013 21:54:40 +0000 (21:54 +0000)]
Merge ""Your domain" appearance fixes for new forms"

10 years agoFixed long memcached keys for infoaction.
Aaron Schulz [Thu, 6 Jun 2013 20:40:07 +0000 (13:40 -0700)]
Fixed long memcached keys for infoaction.

* One place was already using SHA1, so invalidation was broken.

Change-Id: Ie0d3b9274ed2e1c5a7b1616cd237a5e25fd99d12

10 years agoedit.php maintenance script not setting up context, just globals
Alex Monk [Thu, 6 Jun 2013 20:20:20 +0000 (21:20 +0100)]
edit.php maintenance script not setting up context, just globals

Was breaking one of Echo's hooks

Bug: 49271
Change-Id: Ie1b5f5bc4a672bcfff3c99b9a76b37c502c09985

10 years agoaction=parse now can parse in preview mode
Max Semenik [Thu, 6 Jun 2013 16:04:40 +0000 (20:04 +0400)]
action=parse now can parse in preview mode

Bug: 49239
Change-Id: Iacfea0219ef21dc91d669f51140ec129c2f41f76

10 years ago"Your domain" appearance fixes for new forms
S Page [Thu, 6 Jun 2013 01:47:04 +0000 (18:47 -0700)]
"Your domain" appearance fixes for new forms

* Restore lost id=mw-user-domain-section (so wikitech can hide it).
* Remove obsolete pos-above class.
* Fix message key.

Bug: 49225
Change-Id: I73bcd44eff10a4fd2d1a392e82427e42e92fc3bf

10 years agoRefactored WikiPage::updateCategoryCounts() to use upsert().
Aaron Schulz [Tue, 4 Jun 2013 18:59:34 +0000 (11:59 -0700)]
Refactored WikiPage::updateCategoryCounts() to use upsert().

* Also made it avoid inserting aggregate rows on membership
  decrement if there was no prior row aggregate row.

Change-Id: I7e6d07e42cc06cedbd9d10ed9f276f20636dc222

10 years agoMerge "Doc fix for MediaHandler::getThumbType"
jenkins-bot [Thu, 6 Jun 2013 01:33:12 +0000 (01:33 +0000)]
Merge "Doc fix for MediaHandler::getThumbType"

10 years agoThe language used to render SVGs should be definable
jarry1250 [Fri, 24 May 2013 12:56:06 +0000 (14:56 +0200)]
The language used to render SVGs should be definable

See bug for context.

The implementation is slightly untidy because I've written it so
as to avoid invalidating the existing SVG thumbs -- there will be
no immediate difference (visual/performance/other) as a result of
this.

Tested by me in both...
* [[File:Example.svg|thumb|lang=fr]] AND
* http://example.org/w/index.php?title=File:Example.svg&lang=fr
...modes. Example file on
https://commons.wikimedia.org/wiki/File:Gerrit_patchset_25838_test.svg

Added parser tests.

Bug: 32987
Change-Id: I4cadf96ecd5e169a88ad468a0478d355db980103

10 years agoDoc fix for MediaHandler::getThumbType
Brian Wolff [Wed, 5 Jun 2013 17:28:13 +0000 (14:28 -0300)]
Doc fix for MediaHandler::getThumbType

Change-Id: I892937b3bcaf976537c89cb4f52fab20a2fba5b0

10 years agoFollow up I6e64a missing global deceleration for $wgHTTPConnectTimeout
Brian Wolff [Wed, 5 Jun 2013 15:38:09 +0000 (12:38 -0300)]
Follow up I6e64a missing global deceleration for $wgHTTPConnectTimeout

Bug: 47027
Change-Id: I3e2a84ee8a759dd2bdb2fd0837e0cd5605541816

10 years agoMerge "RefreshLinks on imagelinks on new uploads to kill tracking cat."
jenkins-bot [Wed, 5 Jun 2013 16:35:41 +0000 (16:35 +0000)]
Merge "RefreshLinks on imagelinks on new uploads to kill tracking cat."

10 years agoShorten our in-comment urls to the whatwg HTML spec.
Daniel Friesen [Mon, 13 May 2013 03:21:13 +0000 (20:21 -0700)]
Shorten our in-comment urls to the whatwg HTML spec.

whatwg.org has a redirect to /specs/web-apps/current-work/multipage/ from /html/.

Change-Id: If21705c214ca8f14db5a0c6dda3c43c22f9ca811

10 years agoRefreshLinks on imagelinks on new uploads to kill tracking cat.
Brian Wolff [Mon, 15 Apr 2013 23:06:23 +0000 (20:06 -0300)]
RefreshLinks on imagelinks on new uploads to kill tracking cat.

When someone uploads a new file, we should refresh all the pages
that use that image, so that [[Category:Pages with broken file links]]
gets removed.

Future fixme would to run this again on file deletes, but that's
less critical as they will eventually get added on next reparse
and people don't expect that to happen instantly like when fixing
the issue. Ditto for someone creating a new file redirect.

Bug: 46749
Change-Id: I7889598eee54a1c07c64f750b8499e922ba59704

10 years agoMerge "jquery.client: Fix profile of some UAs and add exactMatchOnly param"
jenkins-bot [Wed, 5 Jun 2013 12:31:24 +0000 (12:31 +0000)]
Merge "jquery.client: Fix profile of some UAs and add exactMatchOnly param"

10 years agojquery.client: Fix profile of some UAs and add exactMatchOnly param
Ed Sanders [Tue, 4 Jun 2013 18:56:13 +0000 (19:56 +0100)]
jquery.client: Fix profile of some UAs and add exactMatchOnly param

Fix detection of Iceweasel (add to wildUserAgents), Safari (make
comma after KHTML optional) and Android (add to versionPrefixes
and names).

Add 'exactMatchOnly' parameter to test function which triggers
a return value of false if the browser is not found (previously
was always true). Also making ltr/rtl splitting in support map
optional.

Change-Id: I541a6c134e9668f6bf5af49d4508a82d4f546bb6

10 years agoMerge "jquery.tablesorter: Reset unaffected columns' sort counts when sorting"
jenkins-bot [Wed, 5 Jun 2013 11:48:07 +0000 (11:48 +0000)]
Merge "jquery.tablesorter: Reset unaffected columns' sort counts when sorting"

10 years ago[LockManager] Made it easier to get both SH and EX locks at once.
Aaron Schulz [Sat, 20 Apr 2013 07:10:19 +0000 (00:10 -0700)]
[LockManager] Made it easier to get both SH and EX locks at once.

* This also makes it possible for subclasses to optimize this case.
* Added a timeout parameter to ScopedLock::factory().
* Cleaned up a few bits of documentation.

Change-Id: Id3e9cf01f25ab498ea00d87ffb6d00aa8b05052b

10 years agoAllow setting of connection timeouts for HTTP requests using cURL
Chad Horohoe [Mon, 8 Apr 2013 23:45:05 +0000 (19:45 -0400)]
Allow setting of connection timeouts for HTTP requests using cURL

Bug: 47027
Change-Id: I6e64a8bfc58e899149463d305eac672c1e8ad2ba

10 years agoRemove unused global
Platonides [Tue, 4 Jun 2013 21:40:30 +0000 (23:40 +0200)]
Remove unused global

Follow-up 22eb569

Change-Id: I2c34b1f02c7304bd6864a7402c8be0ab313c7162

10 years agoFollow-up 05077dc3740
Platonides [Tue, 4 Jun 2013 21:30:16 +0000 (23:30 +0200)]
Follow-up 05077dc3740

* s/___METHOD__/__METHOD__/
* Remove the mention to cur table as deprecation reason,
since it is obviously not trying to use cur (removed in 1.5),
this code is clearly newer (expecting data from a mixture of
tables), although using an old interface.

Change-Id: I0b4fdf7de4f56c1100ef3cdd7705e8f6701bc7cf

10 years agoMerge "Remove the $wgHandheldForIPhone config variable entirely"
TheDJ [Tue, 4 Jun 2013 19:58:06 +0000 (19:58 +0000)]
Merge "Remove the $wgHandheldForIPhone config variable entirely"

10 years agoRemove the $wgHandheldForIPhone config variable entirely
MatmaRex [Sat, 11 May 2013 19:05:43 +0000 (21:05 +0200)]
Remove the $wgHandheldForIPhone config variable entirely

It only really made sense in pair with $wgHandheldStyle, and that has
been removed in Ia8d79b4a.

Remove irrelevant tests, adjust still relevant ones.

Change-Id: I7c24128f7b148d0244538ad95bb60bf09ec4b5cb

10 years agoMerge "More cleanup when removing accounts with removeUnusedAccounts.php"
jenkins-bot [Tue, 4 Jun 2013 19:34:44 +0000 (19:34 +0000)]
Merge "More cleanup when removing accounts with removeUnusedAccounts.php"

10 years agoMerge "mediawiki.icon: Move arrow icons to a separate module"
jenkins-bot [Tue, 4 Jun 2013 19:10:12 +0000 (19:10 +0000)]
Merge "mediawiki.icon: Move arrow icons to a separate module"

10 years agoMore cleanup when removing accounts with removeUnusedAccounts.php
Alexandre Emsenhuber [Tue, 4 Jun 2013 19:02:33 +0000 (21:02 +0200)]
More cleanup when removing accounts with removeUnusedAccounts.php

Delete entries from user_groups, user_former_groups and user_properties tables too

Change-Id: I581e5e6b749b9718fee3187513adc02e78c1a71b

10 years agoAdded tests for new DatabaseBase::upsert
umherirrender [Tue, 4 Jun 2013 18:34:49 +0000 (20:34 +0200)]
Added tests for new DatabaseBase::upsert

Follow up Id7fc6652
Pass function name to begin/rollback/commit
Use __METHOD__ as default param (see I86cbdeab)

Change-Id: I9eb326c035d4a604db5b3492f090d8dd9d21c920

10 years agoMerge "User: Clean up coding style and documentation"
jenkins-bot [Tue, 4 Jun 2013 16:57:57 +0000 (16:57 +0000)]
Merge "User: Clean up coding style and documentation"

10 years agoIntroducing ContentGetParserOutput hook.
daniel [Tue, 16 Oct 2012 10:38:20 +0000 (12:38 +0200)]
Introducing ContentGetParserOutput hook.

This hooks allows extensions to override the normal model-specific rendering
of page content. A typical use would be to provide syntax highlighting for
pages that contain scripts. In that sense, ContentGetParserOutput is a
generalization of the old ShowRawCssJs hook.

Change-Id: Ibfb2cbefea44eeee9f2a027f47e7721bf177ba0f

10 years agomediawiki.icon: Move arrow icons to a separate module
Brad Jorsch [Sat, 25 May 2013 09:24:42 +0000 (11:24 +0200)]
mediawiki.icon: Move arrow icons to a separate module

The arrow icons for the enhanced watchlist/recent changes could be
useful elsewhere. But to do that, we need to be able to load them
separately; this does that by adding a new module just for the CSS
needed for the arrows.

Also, this fixes a use of OutputPage::addModuleStyles that really should
have been OutputPage::addModules so dependencies are resolved.

Change-Id: I639a5ccbc3b7b2794e7b12ecb64e5ee6b10a640a

10 years agoUser: Clean up coding style and documentation
Timo Tijhof [Mon, 3 Jun 2013 22:02:10 +0000 (00:02 +0200)]
User: Clean up coding style and documentation

* Parameter type hint should be a variable type or a class
  name. Types Null, Bool, Boolean, Int, Integer, String do
  not exist and are invalid values. Changed to their PHP
  type names (basically just lowercase).
* Made inline comments consistently use "//" instead of "#".
* Removed various odd spurious spaces sequences in @param
  lines. They are sometimes used to pretty-align multi-line
  descriptions. Though I think that is silly, I've left those
  alone. I've only removed the spaces where it seems arbitrary
  and not aligning with anything. Last I checked the common
  convention for multi-line descriptions is to simply continue
  on the next line with one extra space as indention.
* Swapped "$var Type" in cases where the surrounding @param's
  already use "Type $var".

Change-Id: I6b315e308271194815879c509d3ac6aeb409851b

10 years agoMerge "RecentChange: deprecate newFromCurRow and loadFromCurRow"
jenkins-bot [Tue, 4 Jun 2013 13:31:30 +0000 (13:31 +0000)]
Merge "RecentChange: deprecate newFromCurRow and loadFromCurRow"

10 years agoMerge "Cologne Blue: add missing 'undeletethispage' message"
jenkins-bot [Tue, 4 Jun 2013 13:07:25 +0000 (13:07 +0000)]
Merge "Cologne Blue: add missing 'undeletethispage' message"

10 years agoMerge "Allow patrolling page creations from Special:RecentChanges"
jenkins-bot [Tue, 4 Jun 2013 12:58:56 +0000 (12:58 +0000)]
Merge "Allow patrolling page creations from Special:RecentChanges"

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Tue, 4 Jun 2013 09:19:06 +0000 (09:19 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ibaaab99ded40c3a8badde9abfcc9710d01555dd9

10 years ago[Database] Added an upsert() function to perform/emulate ON DUPLICATE KEY UPDATE.
Aaron Schulz [Thu, 2 May 2013 22:50:29 +0000 (15:50 -0700)]
[Database] Added an upsert() function to perform/emulate ON DUPLICATE KEY UPDATE.

Change-Id: Id7fc6652268a439af0457309a678677351867f37

10 years agoAdd a script to remove deleted files from storage
Aaron Schulz [Tue, 7 May 2013 00:03:38 +0000 (17:03 -0700)]
Add a script to remove deleted files from storage

Bug: 47990
Change-Id: I2fcc2b2c3e92cd851c38f947de6756a982cf194d

10 years agoremove invalid comment from SkinVector::setupSkinUserCss
MatmaRex [Tue, 16 Apr 2013 20:13:55 +0000 (22:13 +0200)]
remove invalid comment from SkinVector::setupSkinUserCss

It seems to refer to pre-ResourceLoader situation (or at least
pre-skins.vector one). Originally added in 6df94d49, back in 2010.

Change-Id: I759fa99041db465ec6baff94b6b96a79b47438dd

10 years agoMerge "Fix edit patrolling in multi Diffs"
jenkins-bot [Mon, 3 Jun 2013 18:54:52 +0000 (18:54 +0000)]
Merge "Fix edit patrolling in multi Diffs"

10 years agoinvalidparammix/missingparam get the module prefix twice
Matthias Mullie [Mon, 3 Jun 2013 18:23:16 +0000 (20:23 +0200)]
invalidparammix/missingparam get the module prefix twice

dieUsage will call encodeParamName, which will already prefix the error code with the module prefix

E.g. for ApiViewFeedbackArticleFeedbackv5 (prefix afvf), this error code was
(incorrectly): afvfafvfinvalidparammix. Should be: afvfinvalidparammix

Change-Id: Ia351678b49e96ef58dce773331ebe9a1b3ebf824

10 years agomediawiki.legacy.ajax: Wrap Sajax methods in mw.log.deprecate
Alex Monk [Fri, 31 May 2013 02:27:58 +0000 (03:27 +0100)]
mediawiki.legacy.ajax: Wrap Sajax methods in mw.log.deprecate

Bug: 40785
Change-Id: I52f01e4e7d8a0ee595b4775068c8a3d630140092

10 years agoMerge "Make headers in FauxRequest case insensitive"
jenkins-bot [Mon, 3 Jun 2013 15:06:43 +0000 (15:06 +0000)]
Merge "Make headers in FauxRequest case insensitive"

10 years agoMerge "Remove occurence of $wgOut in HTMLForm::displayForm()'s documentation"
jenkins-bot [Mon, 3 Jun 2013 14:48:47 +0000 (14:48 +0000)]
Merge "Remove occurence of $wgOut in HTMLForm::displayForm()'s documentation"

10 years agoMake headers in FauxRequest case insensitive
daniel [Fri, 31 May 2013 13:43:31 +0000 (15:43 +0200)]
Make headers in FauxRequest case insensitive

HTTP headers are case insensitive per spec, and WebRequest
treats them like that, so FauxRequest should too.

Change-Id: I4257af7a8de2792ac556c670dcc7f28e4af4cb44

10 years agoMerge "mediawiki.legacy.ajax: Pass JSHint"
jenkins-bot [Mon, 3 Jun 2013 13:42:35 +0000 (13:42 +0000)]
Merge "mediawiki.legacy.ajax: Pass JSHint"

10 years agoMerge "Update linktrails for Hindi and Odia"
jenkins-bot [Mon, 3 Jun 2013 13:38:32 +0000 (13:38 +0000)]
Merge "Update linktrails for Hindi and Odia"

10 years agoMerge "Fix api.post call in mediawiki.api.edit.js"
jenkins-bot [Mon, 3 Jun 2013 13:25:00 +0000 (13:25 +0000)]
Merge "Fix api.post call in mediawiki.api.edit.js"

10 years agoMerge "Localisation updates from http://translatewiki.net."
Siebrand [Mon, 3 Jun 2013 12:23:43 +0000 (12:23 +0000)]
Merge "Localisation updates from translatewiki.net."

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Mon, 3 Jun 2013 12:13:53 +0000 (12:13 +0000)]
Localisation updates from translatewiki.net.

Add support for Batak Toba (bbc/bbc-latn).

Change-Id: I4bb9b5539ebe7cf92015c31f0b115439e34b6071

10 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Mon, 3 Jun 2013 12:12:40 +0000 (12:12 +0000)]
Merge "Localisation updates from translatewiki.net."

10 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Mon, 3 Jun 2013 11:49:40 +0000 (11:49 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I5a78027cc669b2c99308f6761a960570c01c8f93

10 years agoMerge "Update referenced PHP version in 'normal' README."
ArielGlenn [Mon, 3 Jun 2013 11:00:28 +0000 (11:00 +0000)]
Merge "Update referenced PHP version in 'normal' README."

10 years agoRemove occurence of $wgOut in HTMLForm::displayForm()'s documentation
Alexandre Emsenhuber [Mon, 3 Jun 2013 08:51:06 +0000 (10:51 +0200)]
Remove occurence of $wgOut in HTMLForm::displayForm()'s documentation

Mention the context instead

Change-Id: Ic081abc7ee8b63281d7a4d56fac9333e79e39f29

10 years agoCologne Blue: add missing 'undeletethispage' message
MatmaRex [Wed, 29 May 2013 20:23:00 +0000 (22:23 +0200)]
Cologne Blue: add missing 'undeletethispage' message

The link was added in I9486649e (previously the bottom menu only
included a 'Delete this page' link), but the message was never created.

Bug: 48939
Change-Id: I8efaf9c14f918e7e1ac3d68eac7f1e662dfe0204

10 years agoFix api.post call in mediawiki.api.edit.js
umherirrender [Sun, 2 Jun 2013 19:33:07 +0000 (21:33 +0200)]
Fix api.post call in mediawiki.api.edit.js

api.post does not have 3 parameters, fixed this by passing a object with
ok and err as key.

Fixed spacing while at it

Change-Id: I0ffa761aebd11c00380a8637d259480992e018d4

10 years agoFix edit patrolling in multi Diffs
Marius Hoch [Sun, 2 Jun 2013 13:23:09 +0000 (15:23 +0200)]
Fix edit patrolling in multi Diffs

In multi diffs we had a "wrong" value for rc_last_oldid
set (not the directly previous revision but the one
selected by the user). Due to that there weren't any
unpatrolled recentchanges rows found. As that is cached
in memcached these rows stay unpatrollable forever.

Bug: 49019
Change-Id: I5d6111032dba7d102e30d85718639697f44c036e

10 years agomediawiki.legacy.ajax: Pass JSHint
Timo Tijhof [Sat, 1 Jun 2013 11:53:42 +0000 (12:53 +0100)]
mediawiki.legacy.ajax: Pass JSHint

* Added closure so that "mw.util.wikiScript" doesn't access
  global "mw" directory but uses local reference to global
  "mediaWiki".
* Keps names as-is, as such disabled camelcase rule locally
  for this file. This code will be wrap-deprecated and removed
  over the next 2 releases.
* Turned into local cross-references and exposed those, that
  way the individual methods don't all call implied globals but
  are ensured to be referring to the original methods as they
  were defined in the same scope.
* Fixed clashing 'e' variable name.
* Removed unexpected "delete x" statement. Does nothing and
  causes a lint warning.
* Replaced "delete request" with "request = undefined". The
  purpose of the statement is to explicitly dereference the
  XHR object in older IE browsers. However "delete" is not
  allowed for local varables, setting to undefined has the
  same effect.

* Moved debug_mode and request_type down to the other exposures.

Change-Id: Ib45ed9bd8c6f4ebdb060a527a63eaf59d2839493

10 years agoMerge "Update messages.inc and rebuild MessagesEn.php."
jenkins-bot [Sat, 1 Jun 2013 10:36:21 +0000 (10:36 +0000)]
Merge "Update messages.inc and rebuild MessagesEn.php."

10 years agodoc: doxygen expands tabs to 4 spaces instead of 8
Antoine Musso [Sat, 1 Jun 2013 09:50:04 +0000 (11:50 +0200)]
doc: doxygen expands tabs to 4 spaces instead of 8

In doxygen, code snippets (and possibly over places) have their
tabulations expanded to 8 spaces which is a bit too much. The TAB_SIZE
configuration parameter let us set the number of spaces, down to 4 which
makes code examples easier to read IMHO.

Change-Id: I62b417496f4e5ec70e80919c28747f1bd44a7bd6

10 years agoUpdate messages.inc and rebuild MessagesEn.php.
Alexandre Emsenhuber [Sat, 1 Jun 2013 08:09:26 +0000 (10:09 +0200)]
Update messages.inc and rebuild MessagesEn.php.

Change-Id: I567f5f96c7b21dbc166e9cf4ac02078dd9023ea0

10 years agotest: inject autoloader in Maintenance class
Antoine Musso [Mon, 20 May 2013 11:19:13 +0000 (13:19 +0200)]
test: inject autoloader in Maintenance class

We used to inject the test autoloader from the global space after the
Maintenance class has been initialized.  That prevents us from using
tests classes (such as Mock) during the Maintenance setup.

This patch move the TestsAutoLoader.php require() at the beginning of
finalSetup() which would let use Mock classes.

Change-Id: Ia402eafae8407d1516e3d200ac97539e3681fdc6

10 years agoLinkCache singleton can now be altered
Antoine Musso [Mon, 20 May 2013 10:37:15 +0000 (12:37 +0200)]
LinkCache singleton can now be altered

This patch adds the ability to destroy the LinkCache singleton or to
replace the instance with a different object.  Note the $instance static
variable is now at the class level instead of at the method level.

Change-Id: Ib110ad061868834a52a6bac651976b3ffab4a6ce

10 years agoThrow an exception in ScopedCallback for invalid callbacks.
Aaron Schulz [Fri, 31 May 2013 22:21:39 +0000 (15:21 -0700)]
Throw an exception in ScopedCallback for invalid callbacks.

Change-Id: I303dec64e55df0b1de73c6db6577bfb005cbe464

10 years agoCleaned up some Article comments.
Aaron Schulz [Fri, 31 May 2013 20:44:16 +0000 (13:44 -0700)]
Cleaned up some Article comments.

Change-Id: Iad1a56179345044aff8c144b8b72cdaaffa778c4

10 years agoremove leftover @embed directive
S Page [Sat, 1 Jun 2013 02:55:31 +0000 (19:55 -0700)]
remove leftover @embed directive

Change-Id: I38ef973b458fd45f7bc6c768e6e097c521071656

10 years agoMerge "Migrate Extension:PostEdit interface to core"
jenkins-bot [Sat, 1 Jun 2013 00:45:18 +0000 (00:45 +0000)]
Merge "Migrate Extension:PostEdit interface to core"

10 years agoMerge "WebRequest::getIP() cleanups."
jenkins-bot [Sat, 1 Jun 2013 00:12:26 +0000 (00:12 +0000)]
Merge "WebRequest::getIP() cleanups."

10 years agoMerge "Do not show empty parenthesis on log entry with no block flags"
Parent5446 [Fri, 31 May 2013 22:52:49 +0000 (22:52 +0000)]
Merge "Do not show empty parenthesis on log entry with no block flags"

10 years agoMerge "Fixed EZConnect string regex in OracleInstaller class."
jenkins-bot [Fri, 31 May 2013 21:33:26 +0000 (21:33 +0000)]
Merge "Fixed EZConnect string regex in OracleInstaller class."

10 years agoMerge "Update Parsoid-only tests to reflect shortened typeof"
jenkins-bot [Fri, 31 May 2013 21:31:56 +0000 (21:31 +0000)]
Merge "Update Parsoid-only tests to reflect shortened typeof"

10 years agoMigrate Extension:PostEdit interface to core
Ori Livneh [Thu, 30 May 2013 18:10:46 +0000 (11:10 -0700)]
Migrate Extension:PostEdit interface to core

As requested by the VisualEditor team, this change migrates the post-edit
confirmation notice from Extension:PostEdit to core.

This entails porting the 'postedit-confirmation' en/qqq message from the
extension's i18n file (the message key remains the same) to the appropriate
message files and augmenting mediawiki.action.view.postEdit.js to not only
signal post-edit state but also act on it by displaying the confirmation.

Bug: 48276
Change-Id: I01cfc0630c3a505af82922844b5e70c1d61f3c1d

10 years agoMerge "Delete RELEASE-NOTES-1.21"
jenkins-bot [Fri, 31 May 2013 21:13:33 +0000 (21:13 +0000)]
Merge "Delete RELEASE-NOTES-1.21"

10 years agoDo not show empty parenthesis on log entry with no block flags
umherirrender [Fri, 31 May 2013 20:18:10 +0000 (22:18 +0200)]
Do not show empty parenthesis on log entry with no block flags

When nothing is stored in the database, the explode in
LogPage::formatBlockFlags will explode a empty string to a array with a
empty string as only value. Changed the count(array) check to empty
string check.

Bug: 47035
Change-Id: I879169599a2a24b35e26d4a23ab8202f267d8b00

10 years agoFixed trailing slash removal code.
Aaron Schulz [Fri, 31 May 2013 17:56:12 +0000 (10:56 -0700)]
Fixed trailing slash removal code.

Change-Id: I152dcec5cc8f4c417e3503f4b8fd3fdd8bc4fda5

10 years agoFixed EZConnect string regex in OracleInstaller class.
freakolowsky [Sun, 26 May 2013 07:20:38 +0000 (09:20 +0200)]
Fixed EZConnect string regex in OracleInstaller class.

The Oracle connect string was valid only if it contained alphanumerics,
underscore and dot. Some new schmemes makes uses of slashes and
EZConnect has the concept of server types (pooled, dedicated, shared)
which we now validate.

The long regex is now in OracleInstaller::checkConnectStringFormat()
(flagged with @since 1.22). The patch provides a bunch of very basic
tests to test out the regex.

Change-Id: Ie3a0af9801bfdbc9129298be07e1676145a1607a

10 years agoUpdate Parsoid-only tests to reflect shortened typeof
Gabriel Wicke [Fri, 31 May 2013 13:43:54 +0000 (06:43 -0700)]
Update Parsoid-only tests to reflect shortened typeof

https://gerrit.wikimedia.org/r/#/c/64217/ cleans up the RDFa types by dropping
the Object/ prefix and renaming mw:Object/Template to the more general
mw:Object/Transclusion. This patch updates the Parsoid-only tests to reflect
this change.

Change-Id: I474c2cf672beb239d0ac482043ccdfd4681d64fb

10 years agoDelete RELEASE-NOTES-1.21
Reedy [Thu, 30 May 2013 20:55:40 +0000 (21:55 +0100)]
Delete RELEASE-NOTES-1.21

1.21 is now released

Change-Id: Ic7519a3a81e33b2212e0c0d28d2a85f0eb7ff39e

10 years agoMerge "Darker labels in new login and create acct forms"
jenkins-bot [Thu, 30 May 2013 20:39:14 +0000 (20:39 +0000)]
Merge "Darker labels in new login and create acct forms"

10 years agoMerge "benefits icon part of background, not float"
jenkins-bot [Thu, 30 May 2013 20:32:35 +0000 (20:32 +0000)]
Merge "benefits icon part of background, not float"

10 years agoMerge "Compress PNGs used in new forms"
Swalling [Thu, 30 May 2013 19:59:47 +0000 (19:59 +0000)]
Merge "Compress PNGs used in new forms"

10 years agoWebRequest::getIP() cleanups.
Aaron Schulz [Thu, 30 May 2013 17:30:55 +0000 (10:30 -0700)]
WebRequest::getIP() cleanups.

* Always treat the first XFF IP from cache proxies as sane
  even if it is a private IP (useful for things like labs wmf).
* Make sure IP::canonicalize() gets called if the IP is selected
  from the XFF chain (this matches getRawIP()).
* Altered and expanded unit tests.

bug: 48919
Change-Id: I350aca72c7a96ba3ec727324800612fc84e0e7a4

10 years agoMerge "Tooltips for HTMLCheckMatrix"
jenkins-bot [Thu, 30 May 2013 18:10:23 +0000 (18:10 +0000)]
Merge "Tooltips for HTMLCheckMatrix"

10 years agoTooltips for HTMLCheckMatrix
Erik Bernhardson [Thu, 2 May 2013 00:27:14 +0000 (17:27 -0700)]
Tooltips for HTMLCheckMatrix

Generates tooltips on the columns labels of HTMLCheckMatrix.
Bug: 47094

Change-Id: I9670ecdc2cb553df07ee06e3b83b003382471d27

10 years agoMerge "Micro optimization when fetching a magic from cache"
jenkins-bot [Thu, 30 May 2013 15:50:05 +0000 (15:50 +0000)]
Merge "Micro optimization when fetching a magic from cache"

10 years agoMicro optimization when fetching a magic from cache
Antoine Musso [Wed, 29 May 2013 10:21:42 +0000 (12:21 +0200)]
Micro optimization when fetching a magic from cache

The Language::getMagic() methods would request a full copy of the magic
words array from the cache.  Instead use LocalisationCache::getSubitem()
to only fetch the magic word we are interested in.

I do not think that makes that much of a difference, but that is
certainly nicer.  Note that getSubItem() returns null on miss instead of
the previous 'false', that still works for the !is_array().

Change-Id: I02824fd313eeecb5e5b26cb79d7b5549f6648f91