lhc/web/wiklou.git
13 years ago* random redirect-related fixes:
Ryan Schmidt [Tue, 22 Feb 2011 16:39:17 +0000 (16:39 +0000)]
* random redirect-related fixes:
** automatically add redirect=no to all links on the redirect page in Article::viewRedirect.
** properly check if redirects are enabled if $wgMaxRedirects < 1 (moved check from Title::newFromRedirectArray to Title::newFromRedirectInternal).

13 years ago* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)
Sam Reed [Tue, 22 Feb 2011 15:33:02 +0000 (15:33 +0000)]
* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)

Add RELEASE-NOTES for r82547

13 years agoRemove trailing ?>
Platonides [Tue, 22 Feb 2011 15:09:41 +0000 (15:09 +0000)]
Remove trailing ?>

13 years agoRename startExternalParse() when used for internal usage, per r80818 CR.
Platonides [Tue, 22 Feb 2011 15:05:08 +0000 (15:05 +0000)]
Rename startExternalParse() when used for internal usage, per r80818 CR.

13 years agoMerge r67177 from 1.16wmf4
Platonides [Tue, 22 Feb 2011 10:26:00 +0000 (10:26 +0000)]
Merge r67177 from 1.16wmf4

13 years agomaintenance/commandLine.inc loads DefaultSettings, LocalSettings and then runs Setup.php
Platonides [Mon, 21 Feb 2011 23:19:26 +0000 (23:19 +0000)]
maintenance/commandLine.inc loads DefaultSettings, LocalSettings and then runs Setup.php
As Setup.php assigns variables based on the cache config, bootstrap.php was late on reseting them, as some objects were already created.
So we could end up with a SqlBagOStuff created there, which when later accessed (such as trying to invalidate the cache for a user) would
-as any non-sqlite SqlBagOStuff- open a new db connection. Which is precisely what we shall not be done when dealing with temporary tables
(and would indeed fail miserably due to not finding unittest_objectcache table).

In summary, reenabling temporary tables disabled in r79411.

13 years agoremove hardcoded local path
Antoine Musso [Mon, 21 Feb 2011 22:56:16 +0000 (22:56 +0000)]
remove hardcoded local path

13 years agoFollow up r80205 magic, so that you can also use require.
Platonides [Mon, 21 Feb 2011 22:36:35 +0000 (22:36 +0000)]
Follow up r80205 magic, so that you can also use require.

13 years agoimprove namespace related methods
Antoine Musso [Mon, 21 Feb 2011 22:17:06 +0000 (22:17 +0000)]
improve namespace related methods

MWNamespace::getTalk() could give erroneus results when using it on specials
namespaces (NS_MEDIA, NS_SPECIAL). It now use MWNamespace::isMethodValidFor()
which will throw an exception if a special namespace was given.

MWNamespace::getSubject() is now returning identity for specials namespaces.

New MWNamespace::getAssociated() used to find out the subject page of a talk
page and vice versa. Special namespaces will results in an exception.

TESTS:

Added tests for almost complete code coverage. Functions relying on global
$wgCanonicalNamespaces are still incomplete though.
MWNamespace::isMovable() needs more assertions.

Tests results (ignoring incomplete tests output):

$ php phpunit.php --filter MWNamespace
PHPUnit 3.5.10 by Sebastian Bergmann.

.........IIIII..........

Time: 1 second, Memory: 31.75Mb

OK, but incomplete or skipped tests!
Tests: 24, Assertions: 99, Incomplete: 5.

13 years agoAdd missing to mw.config
Krinkle [Mon, 21 Feb 2011 21:24:09 +0000 (21:24 +0000)]
Add missing  to mw.config

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Mon, 21 Feb 2011 20:36:18 +0000 (20:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-21 20:13:00 UTC)

13 years agoFollow-up r73270. Moving the attribute check down to the point where it's for sure...
Krinkle [Mon, 21 Feb 2011 20:36:07 +0000 (20:36 +0000)]
Follow-up r73270. Moving the attribute check down to the point where it's for sure not a string or undefined.  (caused 'cant call getAttribute member function on non-object el [undefined]'. Also add a check to verify that el is a dom element and not just not indefined

13 years ago* (bug 27616) Add userid of blocked user and blocker to list=blocks
Sam Reed [Mon, 21 Feb 2011 19:48:15 +0000 (19:48 +0000)]
* (bug 27616) Add userid of blocked user and blocker to list=blocks

Also tweak comment about "blocking admin". Non admins can block if they have the right... Sooo,  "user" is more appropriate

13 years ago* (bug 27611) list=blocks: Use ipb_by_text instead of join with user table
Sam Reed [Mon, 21 Feb 2011 19:34:57 +0000 (19:34 +0000)]
* (bug 27611) list=blocks: Use ipb_by_text instead of join with user table

Save a table join when looking up blocks (yay!)

Minor issue, for blocks where users have been renamed, we get their old name (Not a big deal IMHO)

13 years agoDe-escaping $ at end of linkTrail regexes dating back from r15823 and beyond
Sam Reed [Mon, 21 Feb 2011 19:12:13 +0000 (19:12 +0000)]
De-escaping $ at end of linkTrail regexes dating back from r15823 and beyond

13 years agoPer Hashar on r82547, u modifier needed on regexes
Sam Reed [Mon, 21 Feb 2011 19:02:55 +0000 (19:02 +0000)]
Per Hashar on r82547, u modifier needed on regexes

13 years agoFixup and add another return type
Sam Reed [Mon, 21 Feb 2011 17:12:33 +0000 (17:12 +0000)]
Fixup and add another return type

13 years agoSome more member variable type hints
Sam Reed [Mon, 21 Feb 2011 17:03:18 +0000 (17:03 +0000)]
Some more member variable type hints

13 years agoRewrote LanguageConverter::autoConvert() to make it use preg_match() with an offset...
Tim Starling [Mon, 21 Feb 2011 14:17:50 +0000 (14:17 +0000)]
Rewrote LanguageConverter::autoConvert() to make it use preg_match() with an offset instead of preg_split(). Reduces memory usage for my test case ([[台灣演員列表]]) to a negligible amount. This should eliminate the most common cause of OOMs on Wikimedia. Produces the exact same output for that test case for the zh -> zh-tw, parser tests pass, seems to work.

13 years agoAdd basic linktrail to SH and SL
Sam Reed [Mon, 21 Feb 2011 13:33:10 +0000 (13:33 +0000)]
Add basic linktrail to SH and SL

13 years agoGallery's perrow was overwriting the original style= attribute.
Derk-Jan Hartman [Sun, 20 Feb 2011 21:31:15 +0000 (21:31 +0000)]
Gallery's perrow was overwriting the original style= attribute.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sun, 20 Feb 2011 20:52:59 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-20 20:02:00 UTC)

13 years ago(bug 27355) Guard against context being null, this happens when wikiEditor disables...
Roan Kattouw [Sun, 20 Feb 2011 19:27:03 +0000 (19:27 +0000)]
(bug 27355) Guard against context being null, this happens when wikiEditor disables itself in unsupported browsers and was causing a JS error

13 years agospaces, added some braces to DairikiDiff.php
Jack Phoenix [Sun, 20 Feb 2011 19:04:58 +0000 (19:04 +0000)]
spaces, added some braces to DairikiDiff.php

13 years agoSpaces to tabs
Platonides [Sun, 20 Feb 2011 17:52:09 +0000 (17:52 +0000)]
Spaces to tabs

13 years agoForce wgDebugTimestamps false
Antoine Musso [Sun, 20 Feb 2011 17:44:37 +0000 (17:44 +0000)]
Force wgDebugTimestamps false

Test GlobalTest::testDebugFunctionTest() does not take into account the setting
$wgDebugTimestamps = true.  Setting it false makes sure the tests pass though
not testing the settings :(

13 years ago(bug 27468) Move private styles out to their own section, so they override everything...
Roan Kattouw [Sun, 20 Feb 2011 17:24:42 +0000 (17:24 +0000)]
(bug 27468) Move private styles out to their own section, so they override everything except user styles. Moved from one makeResourceLoaderLink() call with array_merge() to multiple calls, because makeResourceLoaderLink() orders the modules, then groups them, so the input order is not preserved. Also fixed an issue in makeResourceLoaderLink() where the $uery variable was reused in each iteration but not cleared, allowing pollution to occur in theory (doesn't seem to have happened in practice, though).

13 years agoRevert errorneous line removal in r82439
Max Semenik [Sun, 20 Feb 2011 16:53:49 +0000 (16:53 +0000)]
Revert errorneous line removal in r82439

13 years agowfMsgReal() -> wfMsgExt()
Alexandre Emsenhuber [Sun, 20 Feb 2011 16:36:13 +0000 (16:36 +0000)]
wfMsgReal() -> wfMsgExt()

13 years agoPer Tim Starling, follow-up r76252: move WikiDiff.php to DairikiDiff.php to not confu...
Alexandre Emsenhuber [Sun, 20 Feb 2011 16:28:13 +0000 (16:28 +0000)]
Per Tim Starling, follow-up r76252: move WikiDiff.php to DairikiDiff.php to not confuse with the wikidiff extension

13 years agoPer Platonides; follow-up r78201: add "stubthreshold" to ParserOptions; also provides...
Alexandre Emsenhuber [Sun, 20 Feb 2011 15:03:25 +0000 (15:03 +0000)]
Per Platonides; follow-up r78201: add "stubthreshold" to ParserOptions; also provides a proper fix to r81765

13 years agoFollowup r82509, prefix the code for urlwidth too
Sam Reed [Sun, 20 Feb 2011 13:59:40 +0000 (13:59 +0000)]
Followup r82509, prefix the code for urlwidth too

13 years agoRemove error duplication in ApiQueryStashImageInfo by using non hardcoded prefix...
Sam Reed [Sun, 20 Feb 2011 13:51:24 +0000 (13:51 +0000)]
Remove error duplication in ApiQueryStashImageInfo by using non hardcoded prefix in ApiQueryImageInfo

13 years agoPer comment on r82477, update output for prop=statimageinfo
Sam Reed [Sun, 20 Feb 2011 13:50:15 +0000 (13:50 +0000)]
Per comment on r82477, update output for prop=statimageinfo

13 years agoMore explicit variable definitions, function documentation
Sam Reed [Sun, 20 Feb 2011 13:33:42 +0000 (13:33 +0000)]
More explicit variable definitions, function documentation

13 years agoBug 26683: Unable to download index.php from localhost message displayed at complete...
Max Semenik [Sun, 20 Feb 2011 08:29:25 +0000 (08:29 +0000)]
Bug 26683: Unable to download index.php from localhost message displayed at complete page in IE7 & IE8

13 years agoFix ArticleTablesTest after r81528. It needs to set both $wgLanguageCode and $wgContLang.
Platonides [Sun, 20 Feb 2011 00:44:33 +0000 (00:44 +0000)]
Fix ArticleTablesTest after r81528. It needs to set both $wgLanguageCode and $wgContLang.
Added setUp() and teardown()

13 years agoBreak the self-reference between parser and preprocessor, so they can be counting...
Platonides [Sun, 20 Feb 2011 00:27:01 +0000 (00:27 +0000)]
Break the self-reference between parser and preprocessor, so they can be counting collected.
Saved a couple of Mb in the destructive make (126.25Mb -> 124.25Mb).

13 years agoSave and restore $wgHooks in NewParserTest.
Platonides [Sun, 20 Feb 2011 00:13:26 +0000 (00:13 +0000)]
Save and restore $wgHooks in NewParserTest.
ParserGetVariableValueTs hook still being set to ParserTest::getFakeTimestamp was the reason for the crazy failures of MagicVariableTest inside phpunit that I was seeing.

13 years agobug 27146
Krinkle [Sun, 20 Feb 2011 00:12:24 +0000 (00:12 +0000)]
bug 27146

13 years agomw.loader.implement now calls script without setting mw to mediaWiki since this is...
Krinkle [Sat, 19 Feb 2011 23:52:11 +0000 (23:52 +0000)]
mw.loader.implement now calls script without setting mw to mediaWiki since this is already globally avaiable
* Also shortens a few wrapper functions the same way
* Partial revert of r82496. Apparantly mw-alias is not available in startUp module. TODO: Find out why ?

(See also r82496 commit message)

13 years agoUsing the mw alias for mediaWiki in core. Saves bandwidth and makes sense (there...
Krinkle [Sat, 19 Feb 2011 22:59:44 +0000 (22:59 +0000)]
Using the mw alias for mediaWiki in core. Saves bandwidth and makes sense (there's no point in a wrapper function for ($,mw) if we use jQuery and mediaWiki inside of it).

TODO: Since the alias is globally available from the start, the 'mw' argument in the wrapper is redundant, so that should be removed at some point as well.

13 years ago(bug 3112) Adding colors for active and visited external links.
Krinkle [Sat, 19 Feb 2011 22:44:49 +0000 (22:44 +0000)]
(bug 3112) Adding colors for active and visited external links.
This is in-core for internal links and red links, but there's no visual clue of active and visited links for external links.

Normal external: #36b;
/* Added: */
Active external: #b63;
Visited external: #636;

These two colors (orange and purple -ish) are in the same saturation/brightness as the blue for normal (inactive/unvisited) external links.
Since these visual clues were also lacking in external links to interwikis I've replaced that override with similar colors as well.

13 years agoAnd some more function level documentation
Sam Reed [Sat, 19 Feb 2011 22:18:39 +0000 (22:18 +0000)]
And some more function level documentation

13 years agoMore function documentation
Sam Reed [Sat, 19 Feb 2011 22:08:26 +0000 (22:08 +0000)]
More function documentation

13 years agoLocalization update for he.
Rotem Liss [Sat, 19 Feb 2011 22:01:05 +0000 (22:01 +0000)]
Localization update for he.

13 years agoMore function documentation
Sam Reed [Sat, 19 Feb 2011 21:56:54 +0000 (21:56 +0000)]
More function documentation

13 years agoExplicitally define variables
Sam Reed [Sat, 19 Feb 2011 21:44:20 +0000 (21:44 +0000)]
Explicitally define variables

13 years agoExplicitally define some variables
Sam Reed [Sat, 19 Feb 2011 21:34:44 +0000 (21:34 +0000)]
Explicitally define some variables

Bracify file

13 years agoImprove method documentation
Sam Reed [Sat, 19 Feb 2011 21:16:47 +0000 (21:16 +0000)]
Improve method documentation

Few bits of fixup

13 years agoDon't use getCheck, because the opts array is reused to generate the query for the...
Derk-Jan Hartman [Sat, 19 Feb 2011 21:03:52 +0000 (21:03 +0000)]
Don't use getCheck, because the opts array is reused to generate the query for the RSS/Atom feed.
getCheck checks for presence, not for true/false, so that was why rss feeds behaved as if
deletedOnly was set.

Follow up to r65651
Fixes bug #27546

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sat, 19 Feb 2011 20:56:36 +0000 (20:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-19 20:30:00 UTC)

13 years agoAll functions of the importer have $title, origTitle, but processTitle() returned...
Derk-Jan Hartman [Sat, 19 Feb 2011 20:35:51 +0000 (20:35 +0000)]
All functions of the importer have $title, origTitle, but processTitle() returned $title, origTitle.
This caused confusion and a misusage of the processTitle() result.

Follow up to r66267.
Fixes bug 27486

13 years ago(Bug 27539) Allow attributes beginning with a digit in wiktext tag parameters.
Platonides [Sat, 19 Feb 2011 20:16:54 +0000 (20:16 +0000)]
(Bug 27539) Allow attributes beginning with a digit in wiktext tag parameters.
Its removal in r70849 breaks ProofreadPage extension.
Restricted r82475 relaxation to just numbers.
Added tests.

This only affects wikitext (tag hooks).
MW_ATTRIBS_REGEX is only used through decodeTagAttributes() calls.
fixTagAttributes() calls decodeTagAttributes(), and would be nastier to
fix, since it is called with HTML parameters (eg. by removeHTMLtags)
but such incorrect parameters grabbed would be removed by validateTagAttributes()

13 years ago* (bug 27560) Search queries no longer fail in walloon language
Alexandre Emsenhuber [Sat, 19 Feb 2011 20:06:50 +0000 (20:06 +0000)]
* (bug 27560) Search queries no longer fail in walloon language

13 years ago* (bug 27554) Update api information text to reflect change in bug 26125
Sam Reed [Sat, 19 Feb 2011 19:52:08 +0000 (19:52 +0000)]
* (bug 27554) Update api information text to reflect change in bug 26125

13 years agoRelaxed the allowed format of parser tag attributes as per bug 27539. One side-effect...
Sean Colombo [Sat, 19 Feb 2011 19:25:26 +0000 (19:25 +0000)]
Relaxed the allowed format of parser tag attributes as per bug 27539. One side-effect is that this will fix the widely-used pagelist tag which has "1to10" as an attribute name.

13 years agoRevert r74387: it may not fix the IE8 jumping bug in all cases, but it definitely...
Roan Kattouw [Sat, 19 Feb 2011 19:21:52 +0000 (19:21 +0000)]
Revert r74387: it may not fix the IE8 jumping bug in all cases, but it definitely fixes it in most cases. Reverting a partial fix for not being perfect, then never coming up with a full fix is not acceptable.

13 years ago(Bug #27467) preload can leave UNIQ
Mark A. Hershberger [Sat, 19 Feb 2011 19:18:02 +0000 (19:18 +0000)]
(Bug #27467) preload can leave UNIQ

Patch to fix from P.Copp

13 years agoFollow-up r82452: need to transform entries sinces some wiki like to use variables...
Alexandre Emsenhuber [Sat, 19 Feb 2011 19:15:45 +0000 (19:15 +0000)]
Follow-up r82452: need to transform entries sinces some wiki like to use variables or parser functions in the sidebar

13 years agoImproving jquery.makeCollapsible & small fixed mw.util
Krinkle [Sat, 19 Feb 2011 17:46:30 +0000 (17:46 +0000)]
Improving jquery.makeCollapsible & small fixed mw.util
* Making makeCollapsible more DRY.
* Small optimalizations and fixes in mw.util

13 years ago(bug 27302) Avoid unnecessary requests for user and site modules if the relevant...
Roan Kattouw [Sat, 19 Feb 2011 17:07:05 +0000 (17:07 +0000)]
(bug 27302) Avoid unnecessary requests for user and site modules if the relevant wiki pages don't exist.

Done by adding isKnownEmpty() to ResourceLoaderModule and overriding it to check for page existence in ResourceLoaderWikiModule. Needed to rearrange some code in OutputPage::makeResourceLoaderLink() to have the emptiness check and dropping of modules work properly. Also factored the page_touched check in ResourceLoaderWikiModule::getModifiedTime() out to a separate method (getTitleMtimes()) and moved in-object caching there as well, so getModifiedTime() and isKnownEmpty() share code and caching for their timestamp/existence checks.

This does not account for the case where e.g. a user has user CSS but no user JS: I had implemented this by checking for $context->getOnly() in getTitleMtimes(), but then realized it's not safe to do this in a function called by getModifiedTime(): it causes the timestamp list in the startup module to only take scripts in account for wiki modules, because the startup module has &only=scripts set

13 years agoRemove unused global.
Platonides [Sat, 19 Feb 2011 17:00:34 +0000 (17:00 +0000)]
Remove unused global.

13 years agoFollow up r82091, which uses the local file constant SERVICES_JSON_LOOSE_TYPE.
Platonides [Sat, 19 Feb 2011 16:59:34 +0000 (16:59 +0000)]
Follow up r82091, which uses the local file constant SERVICES_JSON_LOOSE_TYPE.

13 years agoFix logic error in r73204 (!) causing ResourceLoaderContext::getHash() to always...
Roan Kattouw [Sat, 19 Feb 2011 16:48:05 +0000 (16:48 +0000)]
Fix logic error in r73204 (!) causing ResourceLoaderContext::getHash() to always return null

13 years agoPartial revert my accidental revert of r82366 in r82445.
Max Semenik [Sat, 19 Feb 2011 16:25:02 +0000 (16:25 +0000)]
Partial revert my accidental revert of r82366 in r82445.

13 years agoClose the xmlreader when we are done with it.
Derk-Jan Hartman [Sat, 19 Feb 2011 15:42:02 +0000 (15:42 +0000)]
Close the xmlreader when we are done with it.

13 years ago(bug 27328) Redo r82218 properly, expanding URLs with absolute paths
Roan Kattouw [Sat, 19 Feb 2011 14:58:16 +0000 (14:58 +0000)]
(bug 27328) Redo r82218 properly, expanding URLs with absolute paths

13 years agoRevert r82218 , doesn't fix absolute path URLs but breaks them. Will fix properly...
Roan Kattouw [Sat, 19 Feb 2011 14:46:49 +0000 (14:46 +0000)]
Revert r82218 , doesn't fix absolute path URLs but breaks them. Will fix properly in next commit

13 years ago* Use OutputPage::getSyndicationLinks() to build feed links
Alexandre Emsenhuber [Sat, 19 Feb 2011 14:40:56 +0000 (14:40 +0000)]
* Use OutputPage::getSyndicationLinks() to build feed links
* Ported r82395 to legacy skins (possible double "printable" parameter in URL and hidden dependency of $wgTitle)

13 years ago* Use $this->mTitle instead of $wgTitle
Alexandre Emsenhuber [Sat, 19 Feb 2011 13:39:09 +0000 (13:39 +0000)]
* Use $this->mTitle instead of $wgTitle
* Put back the wfMsgForContentNoTrans() added in r66835 but reverted in r68707 since wfMsgForContent() is breaking the {{...}} syntax

13 years agoMerged retrieval of request URL and header from WebRequest and Setup.php to avoid...
Alexandre Emsenhuber [Sat, 19 Feb 2011 13:09:17 +0000 (13:09 +0000)]
Merged retrieval of request URL and header from WebRequest and Setup.php to avoid duplicate code and reduced the number of wfDebug() calls in Setup.php.
The only side effect is that headers name are in uppercase in the debug log.

13 years agoWe have a OutputPage object; so use it to get the Title object instead of $wgTitle
Alexandre Emsenhuber [Sat, 19 Feb 2011 12:31:50 +0000 (12:31 +0000)]
We have a OutputPage object; so use it to get the Title object instead of $wgTitle

13 years agoRemove parentheses for Xmf file-info-size message
Antoine Musso [Sat, 19 Feb 2011 11:57:07 +0000 (11:57 +0000)]
Remove parentheses for Xmf file-info-size message

Now being done in the code. Should help fixing bug 27472

13 years agoBug 27518: Updater calls PopulateLogSearch before adding logging.log_user_text; popul...
Max Semenik [Sat, 19 Feb 2011 11:49:14 +0000 (11:49 +0000)]
Bug 27518: Updater calls PopulateLogSearch before adding logging.log_user_text; populateLogUsertext not called

13 years agoBug 27053 - sourceFile() didn't expand all the required variables. Apparently, broken...
Max Semenik [Sat, 19 Feb 2011 08:01:45 +0000 (08:01 +0000)]
Bug 27053 - sourceFile() didn't expand all the required variables. Apparently, broken by r81084

13 years agoFollow-up r76456: more thorough check for UTF-8 support. Now it checks whether PCRE...
Max Semenik [Sat, 19 Feb 2011 07:27:27 +0000 (07:27 +0000)]
Follow-up r76456: more thorough check for UTF-8 support. Now it checks whether PCRE can actually convert from uppercase to lowercase and vice versa.

13 years agoBug #26059 — Add support for KML/KMZ filetype
Mark A. Hershberger [Sat, 19 Feb 2011 03:22:03 +0000 (03:22 +0000)]
Bug #26059 — Add support for KML/KMZ filetype

Patch from Derk-Jan Hartman of which he writes:

    I figured adding kml support would be a breeze, but I had not
    counted on the brain dead browser that is IE6.

    Unfortunately, kml contains the element <heading, which triggers
    the protection in detectScript() that protects from uploads that
    IE6 might mistake for HTML.  It triggers on "<head" not sure if we
    can work around this, but Tim will know.

13 years agoget rid of unnecessary double quotes
Jack Phoenix [Sat, 19 Feb 2011 02:09:53 +0000 (02:09 +0000)]
get rid of unnecessary double quotes

13 years agoadd braces + some other coding style tweaks
Jack Phoenix [Sat, 19 Feb 2011 02:07:10 +0000 (02:07 +0000)]
add braces + some other coding style tweaks

13 years agoMore function and variable documentation
Sam Reed [Sat, 19 Feb 2011 01:02:56 +0000 (01:02 +0000)]
More function and variable documentation

13 years agoMore function level documentation
Sam Reed [Sat, 19 Feb 2011 00:44:38 +0000 (00:44 +0000)]
More function level documentation

Fixup some indenting

13 years agoMore parameter documentation
Sam Reed [Sat, 19 Feb 2011 00:30:18 +0000 (00:30 +0000)]
More parameter documentation

13 years agoMore function level documentation
Sam Reed [Fri, 18 Feb 2011 23:56:08 +0000 (23:56 +0000)]
More function level documentation

13 years agoFollow up r63584. The change of resetArticleID() could have all kinds of
Platonides [Fri, 18 Feb 2011 23:44:18 +0000 (23:44 +0000)]
Follow up r63584. The change of resetArticleID() could have all kinds of
side effects, given that it stops lazy cache fillings.

13 years agoFollowup r49655
Sam Reed [Fri, 18 Feb 2011 23:42:19 +0000 (23:42 +0000)]
Followup r49655

I'd guess there's never been a Title::newFromTitle method, swapping for Title::newFromText

13 years agoParameter documentation
Sam Reed [Fri, 18 Feb 2011 23:34:24 +0000 (23:34 +0000)]
Parameter documentation

13 years agoExplicitally define some variables
Sam Reed [Fri, 18 Feb 2011 23:21:48 +0000 (23:21 +0000)]
Explicitally define some variables

Function documentation

13 years agoFixup assignment in loop
Sam Reed [Fri, 18 Feb 2011 22:59:01 +0000 (22:59 +0000)]
Fixup assignment in loop

comment out undefined variable used in function call

13 years agoMark a fixme comment in Oracle DB file for undefined variable
Sam Reed [Fri, 18 Feb 2011 22:58:02 +0000 (22:58 +0000)]
Mark a fixme comment in Oracle DB file for undefined variable

Add documentation

13 years agoFixup whitespace, brackets etc
Sam Reed [Fri, 18 Feb 2011 22:49:56 +0000 (22:49 +0000)]
Fixup whitespace, brackets etc

Remove usage of @

13 years agore bug #25523: add mime.info and mime.types for *.dwg files so that when people add...
Mark A. Hershberger [Fri, 18 Feb 2011 21:54:19 +0000 (21:54 +0000)]
re bug #25523: add mime.info and mime.types for *.dwg files so that when people add dwg to $wgFileExtensions, they can move files.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Fri, 18 Feb 2011 21:02:18 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-18 20:25:00 UTC)

13 years agoFix invalid HTML introduced in r68096: Xml::buildForm() adds <table></table> too
Raimond Spekking [Fri, 18 Feb 2011 18:35:08 +0000 (18:35 +0000)]
Fix invalid HTML introduced in r68096: Xml::buildForm() adds <table></table> too

13 years ago* Added a third parameter to ChangeTags::buildTagFilterSelector() to pass the Title...
Alexandre Emsenhuber [Fri, 18 Feb 2011 16:03:07 +0000 (16:03 +0000)]
* Added a third parameter to ChangeTags::buildTagFilterSelector() to pass the Title object instead of using $wgTitle, only used when the second parameter is true (no such call both in core and extensions)
* Expanded documentation

13 years agoFollow-up r82391 per Nikerabbit's CR: Fix it in a better way
Raimond Spekking [Fri, 18 Feb 2011 15:14:08 +0000 (15:14 +0000)]
Follow-up r82391 per Nikerabbit's CR: Fix it in a better way

13 years agoRemove comment that makes no sense post r82399
Roan Kattouw [Fri, 18 Feb 2011 14:21:52 +0000 (14:21 +0000)]
Remove comment that makes no sense post r82399

13 years agoFix comments and whitespace for \\\\ .
Tim Starling [Fri, 18 Feb 2011 14:18:26 +0000 (14:18 +0000)]
Fix comments and whitespace for \\\\ .

13 years agoJavaScriptDistiller fixes:
Tim Starling [Fri, 18 Feb 2011 14:09:03 +0000 (14:09 +0000)]
JavaScriptDistiller fixes:
* Removed some repeated subexpressions, /(.)*/ etc. These cause the stack space to be rapidly exhausted, leading to a segfault for malicious input. I replaced the ([\r\n]|.) subexpressions with a dot with a /s modifier. Added a pcre.recursion_limit hack to take care of the rest.
* Supported assertions and non-capturing subpatterns in ParseMaster::add() by recognising that parentheses that aren't followed by "?" are capturing. Used another assertion to do this.
* Fixed a bug whereby if a single-line comment had a slash in it, it was recognised as a regex instead of a comment. This occurred because the leading whitespace caused the regex regex to match at an earlier string position than the comment regex, giving it undue precedence. This was the subject of several reports on IRC and the main reason for me starting work on JavaScriptDistiller. Used a lookbehind assertion.
* Give comments precedence over regexes and strings where there is ambiguity at the same string location. Not sure if this does anything, but it seemed like a good idea at the time.
* Removed unused variable ParseMaster::$TRIM.
* To test it, I ran the old and new jquery.js output through Google Closure Compiler. The result was the same, proving that there are no functional differences.

13 years ago* Use appendQueryValue() instead of appendQuery() so that if e.g. printable=no is...
Alexandre Emsenhuber [Fri, 18 Feb 2011 12:25:22 +0000 (12:25 +0000)]
* Use appendQueryValue() instead of appendQuery() so that if e.g. printable=no is already present in the URL, it doesn't become printable=no&printable=yes
* Call getLocalURL() on the local Title object instead of $wgTitle in WebRequest