lhc/web/wiklou.git
4 years ago[MCR] Add @covers tag for PageArchive::undeleteRevisions
addshore [Thu, 21 Dec 2017 14:33:28 +0000 (14:33 +0000)]
[MCR] Add @covers tag for PageArchive::undeleteRevisions

Change-Id: I8dd19244e29f05e22aa5014ec6d6182b5917cc3c

4 years agoMerge "[MCR] Add test for PageArchive::listRevisions"
jenkins-bot [Thu, 21 Dec 2017 22:10:35 +0000 (22:10 +0000)]
Merge "[MCR] Add test for PageArchive::listRevisions"

4 years ago[MCR] Fix RevisionInsertComplete Revision pass by reference
addshore [Thu, 21 Dec 2017 21:18:07 +0000 (21:18 +0000)]
[MCR] Fix RevisionInsertComplete Revision pass by reference

This was broken in:
6af796f3e0cf3e66cd7d7e59af8445f5712d68fe
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
https://gerrit.wikimedia.org/r/#/c/399174/7

Bug: T183503
Change-Id: I674493507ca4aa6677a3bab7a01d6dc3c2cdbc5b

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 21 Dec 2017 20:57:18 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iaad62f37560b8d965c81d72158dbcf5335babdd8

4 years agoMerge "ApiBlock: Improve username validation"
jenkins-bot [Thu, 21 Dec 2017 19:01:05 +0000 (19:01 +0000)]
Merge "ApiBlock: Improve username validation"

4 years agoMerge "MCR: Deprecate and gut Revision class"
jenkins-bot [Thu, 21 Dec 2017 18:40:21 +0000 (18:40 +0000)]
Merge "MCR: Deprecate and gut Revision class"

4 years agoMerge "RecentChangesLinked: Include title without subpage in form"
jenkins-bot [Thu, 21 Dec 2017 18:26:09 +0000 (18:26 +0000)]
Merge "RecentChangesLinked: Include title without subpage in form"

4 years agoMCR: Deprecate and gut Revision class
daniel [Thu, 31 Aug 2017 18:41:04 +0000 (20:41 +0200)]
MCR: Deprecate and gut Revision class

This is a re-submission of I4f24e7fbb68.

As a first major step towards Multi-Content-Revisions (MCR),
this patch turns the Revision class into a legacy proxy for
the new RevisionRecord and RevisionStore classes.

Backwards compatibility is maintained for all but some
rare edge cases, like constructing a completely empty
Revision object.

For more information on MCR, see
<https://www.mediawiki.org/wiki/Requests_for_comment/Multi-Content_Revisions>.

NOTE: once this is merged, verify create/delete/restore cycle on beta,
      ideally with emulated replication lag.

Bug: T174025
Change-Id: Ia4c20a91e98df0b9b14b138eb4825c55e5200384

4 years ago[MCR] Add test for PageArchive::listRevisions
addshore [Thu, 21 Dec 2017 14:33:03 +0000 (14:33 +0000)]
[MCR] Add test for PageArchive::listRevisions

Change-Id: If4ab58cd889e7166142a9f9a28fc81d776a7db3f

4 years agoRecentChangesLinked: Include title without subpage in form
Stephane Bisson [Thu, 21 Dec 2017 14:38:21 +0000 (09:38 -0500)]
RecentChangesLinked: Include title without subpage in form

When the 'title' hidden field contains the subpage, the 'target'
input field is never taken into account since the subpage always
takes precedence in ChangesListSpecialPage->setup()

I75cfb2b56a4da6357e6117b3f34f3178bfb2c90c introduced
SpecialRecentChangesLinked->getPageTitle which overrides
SpecialPage->getPageTitle to include the subpage by default.

This helped with redirecting to the right page when parsing
a saved query on the server but changed the behavior everywhere
that function was used in the context of RCL. That includes
SpecialRecentChanges.php:545 where the option form is built.

Bug: T183437
Change-Id: Id39d1887719ecb6900b25fefbb133dff9c4d0456

4 years agoRCFilters: Query using current (not default) sticky parameters values
Stephane Bisson [Thu, 21 Dec 2017 15:04:33 +0000 (10:04 -0500)]
RCFilters: Query using current (not default) sticky parameters values

For some sticky parameters, defaults are synchronized to current
using Item to Group event, but it only happens for some specific
group types.

That should be cleaned up, but regardless, there is no reason
to query using the default values. Current values are what matters.

Bug: T183438
Change-Id: I527b38ea7f91f70231ed74723212e493e9cce9e5

4 years agoMerge "Fix typo"
jenkins-bot [Thu, 21 Dec 2017 13:39:38 +0000 (13:39 +0000)]
Merge "Fix typo"

4 years agoFollow-up e213462f7c61c: fix typo ("constriant" -> "constraint")
Roan Kattouw [Thu, 21 Dec 2017 11:59:53 +0000 (12:59 +0100)]
Follow-up e213462f7c61c: fix typo ("constriant" -> "constraint")

Change-Id: I6e1fd74e387af5a913301bf296fe9f6da0dd1837

4 years agoFix typo
Fomafix [Thu, 21 Dec 2017 11:53:54 +0000 (12:53 +0100)]
Fix typo

Change-Id: I56e762d0d565e36530a5dc7a7ad0aa7cb66531b8

4 years agoTest for writes being prevented on replica connections.
daniel [Wed, 20 Dec 2017 18:37:13 +0000 (19:37 +0100)]
Test for writes being prevented on replica connections.

Bug: T183265
Change-Id: I319efa418cf8a46985f6faa60096559efa15d267

4 years agoMerge "Add tags for undo edits"
Nikerabbit [Thu, 21 Dec 2017 07:27:17 +0000 (07:27 +0000)]
Merge "Add tags for undo edits"

4 years agoMerge "Simplify logic to prevent writes on replica DB connections"
jenkins-bot [Wed, 20 Dec 2017 22:32:24 +0000 (22:32 +0000)]
Merge "Simplify logic to prevent writes on replica DB connections"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 20 Dec 2017 21:56:21 +0000 (22:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibf7138a1acb001da968e74c7cc24333188c675ae

4 years agoSimplify logic to prevent writes on replica DB connections
Aaron Schulz [Wed, 20 Dec 2017 12:31:07 +0000 (04:31 -0800)]
Simplify logic to prevent writes on replica DB connections

This reverts most of 36f4daf32c591d6b7e2435629fc6e431398b641a.

Change-Id: Ie8205749b14be186e80296b168c32310c10ce875

4 years agoMerge "Fix old style filters disappearing regression"
jenkins-bot [Wed, 20 Dec 2017 20:47:08 +0000 (20:47 +0000)]
Merge "Fix old style filters disappearing regression"

4 years agoMerge "RCFilters: Don't load JS or redirect when transcluding"
jenkins-bot [Wed, 20 Dec 2017 19:08:02 +0000 (19:08 +0000)]
Merge "RCFilters: Don't load JS or redirect when transcluding"

4 years agoFix old style filters disappearing regression
petarpetkovic [Wed, 20 Dec 2017 17:50:03 +0000 (18:50 +0100)]
Fix old style filters disappearing regression

Add FormWrapperWidget after controller is initialized, to avoid it
being removed when changes list view model is updated during
initialization.

Change-Id: I3bd4d1bc9efbcdbf99493498267ed1a690fd1ab2

4 years agoMerge "Provide an appropriate comment"
jenkins-bot [Wed, 20 Dec 2017 16:38:05 +0000 (16:38 +0000)]
Merge "Provide an appropriate comment"

4 years agoMerge "objectcache: add another example case to WANObjectCache::getWithSetCallback()"
jenkins-bot [Wed, 20 Dec 2017 16:29:40 +0000 (16:29 +0000)]
Merge "objectcache: add another example case to WANObjectCache::getWithSetCallback()"

4 years agoFollow-up 36f4daf32c: allow no-write database connections to use transactions
Roan Kattouw [Wed, 20 Dec 2017 14:25:35 +0000 (15:25 +0100)]
Follow-up 36f4daf32c: allow no-write database connections to use transactions

After 36f4daf32c was merged, Aaron pointed out on Gerrit that:

    Transaction can be used on replicas for REPEATABLE-READ mode, so
    queries in that transaction see the same version of the DB. Those
    do not involve writes and things would probably break sometimes
    without it (like reads following foreign keys and reference in
    separate queries).

So allow no-write connections to call begin() and commit(), and only
throw an exception when a write query is attempted.

Bug: T183265
Change-Id: I138677a714df13ead08061c3e9ef794c3befbe9d

4 years agoMerge "Standardize editfont size across browsers/OSes"
jenkins-bot [Wed, 20 Dec 2017 01:25:05 +0000 (01:25 +0000)]
Merge "Standardize editfont size across browsers/OSes"

4 years agoMerge "Remove empty RevisionRecordTest"
jenkins-bot [Tue, 19 Dec 2017 23:18:47 +0000 (23:18 +0000)]
Merge "Remove empty RevisionRecordTest"

4 years agoUnify monospace font family stack
Volker E [Wed, 27 Sep 2017 22:39:32 +0000 (00:39 +0200)]
Unify monospace font family stack

Bug: T176636
Change-Id: I28d490a6c1decb68fce20307cc58678c9fe64ecc

4 years agoStandardize editfont size across browsers/OSes
Ed Sanders [Thu, 7 Dec 2017 13:24:09 +0000 (13:24 +0000)]
Standardize editfont size across browsers/OSes

Bug: T176636
Bug: T181324
Bug: T182320
Change-Id: I836a05674723ae0864372f8d0e32c7b430906a92

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 19 Dec 2017 21:01:09 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia4bc5f0583c9f8d5d3d1868d6e5f85d2e41afcbf

4 years agomw.Feedback: Remove weird unnecessary switch statements
Bartosz Dziewoński [Tue, 19 Dec 2017 18:48:05 +0000 (19:48 +0100)]
mw.Feedback: Remove weird unnecessary switch statements

They made sense prior to 7196fafcdcbe658caf9ffde508717714b9cf4510,
but no longer do since the success and error handling are in different
functions. I probably should have removed them in that commit.

Change-Id: I1167dc1b5a79eadfe607abfc73bd2f0e95194b78

4 years agoRemove empty RevisionRecordTest
addshore [Tue, 19 Dec 2017 17:50:03 +0000 (17:50 +0000)]
Remove empty RevisionRecordTest

Bug: T183219
Change-Id: Ic58308da4a54186995a2d985b40e0bbf86b8cef3

4 years agoProvide an appropriate comment
Volker E [Tue, 19 Dec 2017 17:27:56 +0000 (09:27 -0800)]
Provide an appropriate comment

Let's stay with blue (`#36c`) for something called blue.

Change-Id: I1ebb0909d491f1ecf4d1e5733e7ac6589d28c731

4 years agoMerge "Prevent write operations to database replicas."
jenkins-bot [Tue, 19 Dec 2017 16:44:46 +0000 (16:44 +0000)]
Merge "Prevent write operations to database replicas."

4 years agoPrevent write operations to database replicas.
daniel [Tue, 19 Dec 2017 16:11:08 +0000 (17:11 +0100)]
Prevent write operations to database replicas.

Bug: T183265
Change-Id: I8e17644d1b447416adee18e42cf0122b52a80b22

4 years agoMerge "Trigger name changes"
jenkins-bot [Tue, 19 Dec 2017 15:45:06 +0000 (15:45 +0000)]
Merge "Trigger name changes"

4 years agoTrigger name changes
freakolowsky [Fri, 15 Dec 2017 12:47:27 +0000 (13:47 +0100)]
Trigger name changes

Modifid the names as described in the task/bug.

Additionally found and added two missing permissions in user.sql, and
fixed an unrelated error to make the schema function.

Bug: T182981
Change-Id: Ia213c0e6b6759a950cdee4181d9c5695e3c5da4a

4 years agoMerge "[MCR] Fix SqlBlobStore using DB_REPLICA for writes"
jenkins-bot [Tue, 19 Dec 2017 15:06:02 +0000 (15:06 +0000)]
Merge "[MCR] Fix SqlBlobStore using DB_REPLICA for writes"

4 years agoApiBlock: Improve username validation
Brad Jorsch [Tue, 19 Dec 2017 14:56:16 +0000 (09:56 -0500)]
ApiBlock: Improve username validation

The current username validation lets any invalid username through, on
the assumption that it's an IP address. We can do better: call the
backend to get the actual type and target, and reject anything with
TYPE_USER where the actual input name is invalid (regardless of
underlying mangling for stuff like T31797).

Bug: T183211
Change-Id: I676642eee1222447df22a1c32b24f55e6273bcec

4 years ago[MCR] Fix SqlBlobStore using DB_REPLICA for writes
addshore [Tue, 19 Dec 2017 14:58:06 +0000 (14:58 +0000)]
[MCR] Fix SqlBlobStore using DB_REPLICA for writes

Bug: T183242
Bug: T183245
Bug: T183252
Change-Id: Ic0b9910b5de5ce6817d6a4a3e5e32103e2113926

4 years agoMerge "Revert "[MCR] Turn Revision into a proxy to new code.""
jenkins-bot [Tue, 19 Dec 2017 13:10:53 +0000 (13:10 +0000)]
Merge "Revert "[MCR] Turn Revision into a proxy to new code.""

4 years agoMerge "Add HEBREW POINT METEG to the Hebrew special characters"
jenkins-bot [Tue, 19 Dec 2017 12:44:42 +0000 (12:44 +0000)]
Merge "Add HEBREW POINT METEG to the Hebrew special characters"

4 years agoRevert "[MCR] Turn Revision into a proxy to new code."
Daniel Kinzler [Tue, 19 Dec 2017 10:42:34 +0000 (10:42 +0000)]
Revert "[MCR] Turn Revision into a proxy to new code."

This reverts commit 9dcc56b3c9e7a3212d0900ee23808b9402cad952.

With this patch applied, newly created revisions are sometimes not found
just after submitting an edit, until replicas have caught up.

Our best theory is that it somehow interfere with ChronologyProtector,
but we don't have a good idea how.

Also, as legoktm mentioned, the commit message is terrible and needs fixing.

Change-Id: Idf3404f3fa8f8d08a7fb2ab8268726e2c1edecfe

4 years agoMerge "RCLFilters: make target and to/from parameters sticky again"
jenkins-bot [Tue, 19 Dec 2017 12:34:59 +0000 (12:34 +0000)]
Merge "RCLFilters: make target and to/from parameters sticky again"

4 years agoMerge "Require indentation of CASE statements in PHP code"
jenkins-bot [Tue, 19 Dec 2017 12:21:59 +0000 (12:21 +0000)]
Merge "Require indentation of CASE statements in PHP code"

4 years agoRCLFilters: make target and to/from parameters sticky again
Stephane Bisson [Tue, 19 Dec 2017 12:03:26 +0000 (07:03 -0500)]
RCLFilters: make target and to/from parameters sticky again

Regression from Id0bf89ce397ff8a54ce0a30d1ba7d8f9bbdd14a3

Change-Id: Ied7a73b662266eb1ea0c085e5b9c88df0de7e2f6

4 years agoAdd HEBREW POINT METEG to the Hebrew special characters
Amire80 [Tue, 19 Dec 2017 09:52:47 +0000 (11:52 +0200)]
Add HEBREW POINT METEG to the Hebrew special characters

It's very common in the Bible, and in many other books for indicating stress.

Change-Id: I4a564df82398b15ea4ec9c0a67f119c7ef1bdf95

4 years agoRevisionTest: Make @covers tags absolute
Kunal Mehta [Tue, 19 Dec 2017 06:01:02 +0000 (22:01 -0800)]
RevisionTest: Make @covers tags absolute

PHPUnit requires @covers tags to be absolute, they cannot depend
upon `use ...` statements.

Change-Id: I92fadc51cc924477d884536b860272b5a230cd36

4 years agoRevisionTest: Revision::constructFromRowArray is not a function
Kunal Mehta [Tue, 19 Dec 2017 03:24:46 +0000 (19:24 -0800)]
RevisionTest: Revision::constructFromRowArray is not a function

I'm guessing that RevisionStore::newMutableRevisionFromArray() is
what is supposed to be tested here, since Revision::__construct()
calls that if it gets an array.

Change-Id: Ia6c2e7eb667aa746a12ce74aad62e58d2468defd

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 18 Dec 2017 21:07:19 +0000 (22:07 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I7b73fc1564496c5e6988fda30b4fccddea9d0e2a

4 years agoMerge "Fix how "Live updates" behave when user logs out"
jenkins-bot [Mon, 18 Dec 2017 16:06:14 +0000 (16:06 +0000)]
Merge "Fix how "Live updates" behave when user logs out"

4 years agoMerge "RCLFilters: change working of 'to-and-from' selector"
jenkins-bot [Mon, 18 Dec 2017 15:56:17 +0000 (15:56 +0000)]
Merge "RCLFilters: change working of 'to-and-from' selector"

4 years agoMerge "ApiMain: Fix call to Linker::makeHeadline()"
jenkins-bot [Mon, 18 Dec 2017 15:54:28 +0000 (15:54 +0000)]
Merge "ApiMain: Fix call to Linker::makeHeadline()"

4 years agoMerge "Fix heading selecting over-select"
jenkins-bot [Mon, 18 Dec 2017 15:27:05 +0000 (15:27 +0000)]
Merge "Fix heading selecting over-select"

4 years agoApiMain: Fix call to Linker::makeHeadline()
Brad Jorsch [Mon, 18 Dec 2017 14:53:27 +0000 (09:53 -0500)]
ApiMain: Fix call to Linker::makeHeadline()

It's required that the $attribs parameter also contain the closing '>'.

Bug: T183125
Change-Id: Ic3015067a6b1e95e3487a8580e6a9aa8a6c280ed

4 years ago[MCR] Turn Revision into a proxy to new code.
daniel [Thu, 31 Aug 2017 18:41:04 +0000 (20:41 +0200)]
[MCR] Turn Revision into a proxy to new code.

Change-Id: I4f24e7fbb683cb51f3fd8b250732bae9c7541ba2

4 years agoFix heading selecting over-select
golopot [Mon, 18 Dec 2017 07:01:30 +0000 (15:01 +0800)]
Fix heading selecting over-select

In Chrome, multiple clicking selecting a heading cause a bug that the
first character in the next paragrpah is also selected.

Change-Id: Ib52662c39720dcd36ea0b60c9884530895dd9e6a

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 17 Dec 2017 21:01:06 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If167af95a237f67c19013cd5c1daf9c1cbdad492

4 years agoMerge "Use another pageid in WikiPageDbTestBase::testInsertOn_idSpecified"
jenkins-bot [Sun, 17 Dec 2017 17:46:38 +0000 (17:46 +0000)]
Merge "Use another pageid in WikiPageDbTestBase::testInsertOn_idSpecified"

4 years agoMerge "Fix tooltip accessibility for screen readers"
jenkins-bot [Sat, 16 Dec 2017 14:59:35 +0000 (14:59 +0000)]
Merge "Fix tooltip accessibility for screen readers"

4 years agoFix tooltip accessibility for screen readers
David Sn [Sat, 16 Dec 2017 01:39:35 +0000 (01:39 +0000)]
Fix tooltip accessibility for screen readers

By adding an additional aria-label attribute to the tooltip,
we can ensure that every tooltip will be accessible
for accessibility tools like screen readers.

Works with Echo extension, but I am not sure if there
are extensions who are using the original-title attribute.

Tested with ChromeVox on Chrome 62.0.3202.94.

Bug: T54711
Change-Id: I19500c4e8ccbdcb8288b9c2299a29b3f8a31639d

4 years agoMergeHistory: Duplicate watchers on history merge
Fomafix [Mon, 11 Apr 2016 10:41:39 +0000 (12:41 +0200)]
MergeHistory: Duplicate watchers on history merge

Bug: T132130
Change-Id: Ibb2be4f6f975f8f3c542689530fc120f8a464914

4 years agoUse another pageid in WikiPageDbTestBase::testInsertOn_idSpecified
Umherirrender [Fri, 15 Dec 2017 21:03:07 +0000 (22:03 +0100)]
Use another pageid in WikiPageDbTestBase::testInsertOn_idSpecified

integer bigger than 2147483648 is bad on 32-bit php

1) WikiPageContentHandlerDbTest::testInsertOn_idSpecified
Failed asserting that -816015107 is identical to 3478952189.

> echo intval( 3478952189 );
-816015107

Change-Id: Ia2ab870dfe53bef873def3905ae93ea52d4ab2ad

4 years agoNormalize path in AutoloadGenerator::setExcludePaths
Umherirrender [Fri, 15 Dec 2017 22:00:36 +0000 (23:00 +0100)]
Normalize path in AutoloadGenerator::setExcludePaths

Fix is for windows machine

Change-Id: Iadedeb6a04df439c0e940b8eb62fa46757c571c3

4 years agoMerge "SqlBlobStoreTest: Use utf-8 as name in iconv"
jenkins-bot [Fri, 15 Dec 2017 22:04:23 +0000 (22:04 +0000)]
Merge "SqlBlobStoreTest: Use utf-8 as name in iconv"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 15 Dec 2017 20:56:35 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I81ca4030d9c7e37c26828049921737fd0395fa52

4 years agoobjectcache: add another example case to WANObjectCache::getWithSetCallback()
Aaron Schulz [Wed, 6 Dec 2017 05:01:36 +0000 (21:01 -0800)]
objectcache: add another example case to WANObjectCache::getWithSetCallback()

Change-Id: I4beb1441790f5371d9fe55ca05cd17dc9fcdcf80

4 years agoMerge "Fix additional usage of incorrect case"
jenkins-bot [Fri, 15 Dec 2017 19:57:01 +0000 (19:57 +0000)]
Merge "Fix additional usage of incorrect case"

4 years agoSqlBlobStoreTest: Use utf-8 as name in iconv
Umherirrender [Fri, 15 Dec 2017 18:56:48 +0000 (19:56 +0100)]
SqlBlobStoreTest: Use utf-8 as name in iconv

utf8 is an alias that doesn't work with all PHP installations.

Change-Id: I6ce9c5b4ece1a8c263afb1d4895dacd3c790a51a

4 years agoFix typo in ImportHandleUnknownUser hook documentation
Brad Jorsch [Fri, 15 Dec 2017 18:12:09 +0000 (13:12 -0500)]
Fix typo in ImportHandleUnknownUser hook documentation

Change-Id: Ib37facf546e3088cc64373882bb276d2703575b4

4 years agoRCLFilters: change working of 'to-and-from' selector
Stephane Bisson [Fri, 15 Dec 2017 14:00:34 +0000 (09:00 -0500)]
RCLFilters: change working of 'to-and-from' selector

Bug: T172161
Change-Id: I749d7d4ba383daa79685da389d27bde832a508c2

4 years agoFix additional usage of incorrect case
mainframe98 [Fri, 15 Dec 2017 10:58:11 +0000 (11:58 +0100)]
Fix additional usage of incorrect case

Courtesy of the PhpStorm inspection Case mismatch in method call or
class usage.

Bug: T166759
Change-Id: I27c53658b99048fa0dd8f9d6ef1398620386e1cc

4 years agoMerge "RevisionTest: Use utf-8 as name in iconv"
jenkins-bot [Fri, 15 Dec 2017 05:25:11 +0000 (05:25 +0000)]
Merge "RevisionTest: Use utf-8 as name in iconv"

4 years agoRevisionTest: Use utf-8 as name in iconv
Umherirrender [Fri, 8 Dec 2017 13:55:06 +0000 (14:55 +0100)]
RevisionTest: Use utf-8 as name in iconv

utf8 is an alias that doesn't work with all PHP installations.

Change-Id: Ief6e5d8b73c9b4a6614430b699f3399b8137689a

4 years agoMerge "Split limit report out of Parser::parse()"
jenkins-bot [Fri, 15 Dec 2017 05:04:01 +0000 (05:04 +0000)]
Merge "Split limit report out of Parser::parse()"

4 years agoRemove WatchedItem constants and methods deprecated in REL1_27
Reedy [Fri, 8 Dec 2017 03:09:15 +0000 (03:09 +0000)]
Remove WatchedItem constants and methods deprecated in REL1_27

Remove associated tests

Bug: T182381
Change-Id: I0214250a7cb81518074a14e35590370b13d4ba64

4 years agoMerge "ContentHandler: simplify tag tests"
jenkins-bot [Fri, 15 Dec 2017 04:35:21 +0000 (04:35 +0000)]
Merge "ContentHandler: simplify tag tests"

4 years agoContentHandler: simplify tag tests
Framawiki [Tue, 12 Dec 2017 18:21:02 +0000 (19:21 +0100)]
ContentHandler: simplify tag tests

Follows up 62713be990.

Change-Id: Id1f7e6ae470b461e26ef8b7346f715873ccea4c9

4 years agoMerge "Localise some special pages into Korean (ko)"
jenkins-bot [Fri, 15 Dec 2017 04:26:04 +0000 (04:26 +0000)]
Merge "Localise some special pages into Korean (ko)"

4 years agoLocalise some special pages into Korean (ko)
Yongmin Hong [Tue, 12 Dec 2017 11:47:13 +0000 (20:47 +0900)]
Localise some special pages into Korean (ko)

* Synced from MessageEn.php
* Change Special:ListGroupRights so it's less ambigious

Change-Id: I1dfac96825850cdcda135b2e1ce3e19cf71e99e9
Signed-off-by: Yongmin Hong <revi@pobox.com>
4 years agoFix @covers tags to use absolute class names in Storage tests
Kunal Mehta [Fri, 15 Dec 2017 03:20:51 +0000 (19:20 -0800)]
Fix @covers tags to use absolute class names in Storage tests

PHPUnit doesn't support use statements when evaluating @covers tags.

Change-Id: I7f649afd3e417a6b71b2f61c6ff59be5f404be8f

4 years agoMerge "XMPReader: Log filename if available"
jenkins-bot [Fri, 15 Dec 2017 01:33:55 +0000 (01:33 +0000)]
Merge "XMPReader: Log filename if available"

4 years agoMerge "mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards"
jenkins-bot [Fri, 15 Dec 2017 00:26:44 +0000 (00:26 +0000)]
Merge "mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards"

4 years agoOOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988
Bartosz Dziewoński [Thu, 14 Dec 2017 22:56:40 +0000 (23:56 +0100)]
OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

Bug: T182359
Bug: T182395
Change-Id: I764a96780e418830e5c92ec57c50f549951ff47f

4 years agoMerge "[MCR] Tests for RevisionStore & Related classes"
jenkins-bot [Thu, 14 Dec 2017 22:50:58 +0000 (22:50 +0000)]
Merge "[MCR] Tests for RevisionStore & Related classes"

4 years agoMerge "[MCR] Break Revision into RevisionRecord and RevisionStore"
jenkins-bot [Thu, 14 Dec 2017 22:50:51 +0000 (22:50 +0000)]
Merge "[MCR] Break Revision into RevisionRecord and RevisionStore"

4 years agoMerge "mediawiki.loader: Fix logError() not to print exceptions twice"
jenkins-bot [Thu, 14 Dec 2017 22:31:43 +0000 (22:31 +0000)]
Merge "mediawiki.loader: Fix logError() not to print exceptions twice"

4 years agoMerge "Add dropSequence to postgres"
jenkins-bot [Thu, 14 Dec 2017 21:57:45 +0000 (21:57 +0000)]
Merge "Add dropSequence to postgres"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 14 Dec 2017 20:59:04 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I0e9482e99525f1fa6fd791f09597abd91485342b

4 years agomediawiki.loader: Fix logError() not to print exceptions twice
Timo Tijhof [Wed, 13 Dec 2017 22:45:45 +0000 (23:45 +0100)]
mediawiki.loader: Fix logError() not to print exceptions twice

Current behaviour results in:

Chrome 65 (initial)
> ▶ [WARN] Error: foo Error: foo
>  at bar
>  at main

Chrome 65 (expanded)
> ▼ [WARN] Error: foo Error: foo
>            at bar
>            at main
>  at logError
>  at main

Safari 11 (initial)
> ▶ [WARN] Error: foo, Error: foo

Safari 11 (expanded)
> ▼ [WARN] Error: foo is undefined
>     * Error: foo is undefined
>         at bar
>         at main

Firefox 57
> [WARN] Error: foo | Error: foo
>                   | Stacktrace:
>                   |   bar
>                   |   main

I don't recall why I did it this way, but it seems redundant.
This commit effectively removes the first "Error: foo"

Change-Id: Idc5dee34ce2b5068e3a2d8800e2b5f6b879525d1

4 years agoAvoid using array_map in ExtensionRegistry and ExtensionProcessor for simple operations
Yifei He [Wed, 13 Dec 2017 09:41:03 +0000 (17:41 +0800)]
Avoid using array_map in ExtensionRegistry and ExtensionProcessor for simple operations

Bug: T182645
Change-Id: Ia98b1d798b1f93ca30686c009d479668616229ae

4 years ago[MCR] Tests for RevisionStore & Related classes
addshore [Wed, 15 Nov 2017 12:02:40 +0000 (12:02 +0000)]
[MCR] Tests for RevisionStore & Related classes

Code introduced in:
I140f43a6fb443b38483f41f268c906b9cea64cf7

Change-Id: Iefad870baf2d16f12e9901b303246c64d6431ca6

4 years agoMerge "Change EnqueueJob docs to discourage obsolete use-cases"
jenkins-bot [Thu, 14 Dec 2017 03:22:29 +0000 (03:22 +0000)]
Merge "Change EnqueueJob docs to discourage obsolete use-cases"

4 years agoChange EnqueueJob docs to discourage obsolete use-cases
Aaron Schulz [Wed, 6 Dec 2017 21:15:22 +0000 (13:15 -0800)]
Change EnqueueJob docs to discourage obsolete use-cases

Bug: T181216
Change-Id: I9332d26ae9a74c3721cff9c497d5356f05efb428

4 years agoRCFilters: Don't load JS or redirect when transcluding
Roan Kattouw [Thu, 14 Dec 2017 02:04:12 +0000 (18:04 -0800)]
RCFilters: Don't load JS or redirect when transcluding

We were changing the URL on every page that contained
{{Special:Recentchanges}}.

Bug: T181032
Change-Id: Ib4a0d3c1733da0bd0076aa43b91fc06939c51b75

4 years agoFix manual IN queries in checkStorage.php
Pppery [Thu, 14 Dec 2017 01:56:14 +0000 (20:56 -0500)]
Fix manual IN queries in checkStorage.php

Bug: T182689
Change-Id: Ifca7bd6d0385dd470cddc483f4641eeb2832580c

4 years agoMerge "Track which namespaces edit conflicts are resolved in"
jenkins-bot [Thu, 14 Dec 2017 00:47:19 +0000 (00:47 +0000)]
Merge "Track which namespaces edit conflicts are resolved in"

4 years agoMerge "RCFilters: Change findHighlightedItem due to deprecation"
jenkins-bot [Wed, 13 Dec 2017 23:29:37 +0000 (23:29 +0000)]
Merge "RCFilters: Change findHighlightedItem due to deprecation"

4 years agoMerge "Convert includes/Feed.php to Mustache templates"
jenkins-bot [Wed, 13 Dec 2017 23:09:25 +0000 (23:09 +0000)]
Merge "Convert includes/Feed.php to Mustache templates"

4 years agoRCFilters: Change findHighlightedItem due to deprecation
Moriel Schottlender [Wed, 13 Dec 2017 22:58:40 +0000 (14:58 -0800)]
RCFilters: Change findHighlightedItem due to deprecation

SelectWidget's getHighlightedItem was deprecated and switched with
findHighlightedItem, see T76630

Change-Id: I90535c9f72d9a63e8e8d4184cc85aaf77e7b454c