8 years agoMerge "Make feedlink icon visible by setting a size"
jenkins-bot [Thu, 17 Sep 2015 15:28:10 +0000 (15:28 +0000)]
Merge "Make feedlink icon visible by setting a size"

8 years agoBrowser test: avoid loading elements over network
Antoine Musso [Wed, 8 Jul 2015 16:32:53 +0000 (18:32 +0200)]
Browser test: avoid loading elements over network

Page object let us search elements for which attributes match a given
regex.  Unfortunatly it loads the list of elements first, then foreach
of them trigger a call to Selenium to retrieve the attribute to match.

Attempting to regex match a link href, would cause hundred of roundtrip
to the Selenium host.

Instead, use a CSS selector to get the element we are interested in
which skips the bad page object code.

Bug: T92613
Bug: T112291
Change-Id: I12949a4d0ef61d38adbaaf622722c89033949cad

8 years agoMerge "Add line breaks between label and value in "Username" and "Password""
jenkins-bot [Thu, 17 Sep 2015 06:48:24 +0000 (06:48 +0000)]
Merge "Add line breaks between label and value in "Username" and "Password""

8 years agoMerge "Drop zh-tw message "saveprefs""
jenkins-bot [Thu, 17 Sep 2015 06:16:35 +0000 (06:16 +0000)]
Merge "Drop zh-tw message "saveprefs""

8 years agoDrop zh-tw message "saveprefs"
Liangent [Wed, 16 Sep 2015 23:32:29 +0000 (23:32 +0000)]
Drop zh-tw message "saveprefs"

Change-Id: I4b0da9f17e77a9a0d7af7522d7cb59d8891246f7

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 16 Sep 2015 20:20:29 +0000 (22:20 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id35e5c6fd7a706cc76e88d9181edb8f39a3ac201

8 years agoMake feedlink icon visible by setting a size
umherirrender [Wed, 16 Sep 2015 19:46:19 +0000 (21:46 +0200)]
Make feedlink icon visible by setting a size

Also avoid repeat and adding the necessary padding to give place for the
icon before the label.

Follows I1e47b626fa937066823f056aec6fbc0205fdb9b6,
Iabaebe9bf1e11a06bb951769693b1be4404e5b00 and

Change-Id: Iaf8882142b58f2c793d9f8692a9d4051460c7144

8 years agoMerge "Move query rewriting into search backend"
jenkins-bot [Wed, 16 Sep 2015 18:57:55 +0000 (18:57 +0000)]
Merge "Move query rewriting into search backend"

8 years agoPurge remaining oversight references from code
Alex Monk [Tue, 15 Sep 2015 22:38:15 +0000 (23:38 +0100)]
Purge remaining oversight references from code

i18n change coming in a separate commit

Change-Id: I46b9311cd01e95e524587ce40dcbae62f58dc5a8

8 years agoAdd line breaks between label and value in "Username" and "Password"
Amir E. Aharoni [Fri, 7 Aug 2015 14:18:59 +0000 (17:18 +0300)]
Add line breaks between label and value in "Username" and "Password"

This is supposed to separate the label from the value,
which is needed to avoid messing it up in RTL languages.

Bug: T108321
Change-Id: Idde5841c1099e171cd911cc25fb1771eda885723

8 years agoMerge "Add missing argument to dieDebug call so it does not die"
jenkins-bot [Wed, 16 Sep 2015 17:43:04 +0000 (17:43 +0000)]
Merge "Add missing argument to dieDebug call so it does not die"

8 years agoMerge "Remove dead local vars in ApiRevisionDelete"
jenkins-bot [Wed, 16 Sep 2015 17:41:27 +0000 (17:41 +0000)]
Merge "Remove dead local vars in ApiRevisionDelete"

8 years agoMerge "Moved some WANObjectCache number literals to constants"
jenkins-bot [Wed, 16 Sep 2015 17:20:26 +0000 (17:20 +0000)]
Merge "Moved some WANObjectCache number literals to constants"

8 years agoMoved some WANObjectCache number literals to constants
Aaron Schulz [Wed, 16 Sep 2015 17:05:54 +0000 (10:05 -0700)]
Moved some WANObjectCache number literals to constants

Change-Id: I848440408b54c1dfd4961c15cc83aad9a1a19425

8 years agoRemove dead argument in EncryptedPassword.php
jeroendedauw [Wed, 16 Sep 2015 11:39:21 +0000 (13:39 +0200)]
Remove dead argument in EncryptedPassword.php

Change-Id: Ib0bb2733284262c233e6de4c7645f0b215690156

8 years agoMerge "FauxRequest: Avoid header leak"
jenkins-bot [Wed, 16 Sep 2015 17:02:57 +0000 (17:02 +0000)]
Merge "FauxRequest: Avoid header leak"

8 years agoFauxRequest: Avoid header leak
umherirrender [Wed, 16 Sep 2015 16:35:37 +0000 (18:35 +0200)]
FauxRequest: Avoid header leak

Actually override initHeaders to avoid init of the header, if no header
was set.

The tests was taken from I4c06369968e.
Follows-up 578a0c082f.

Change-Id: I86b2a9bae2f5938374fd9e5e46997c3fdfe87e39

8 years agoRemove dead argument in SpecialEditTags
jeroendedauw [Wed, 16 Sep 2015 11:40:11 +0000 (13:40 +0200)]
Remove dead argument in SpecialEditTags

Change-Id: Idba1fd203e5616774a46e36b42fc124062261bee

8 years agoRemove commented out code in SpecialExport
jeroendedauw [Mon, 7 Sep 2015 19:21:24 +0000 (21:21 +0200)]
Remove commented out code in SpecialExport

The removed code was about exporting/importing image information,
which is not possible at the moment, but also nobody seems to work on this.

Change-Id: Ie10d3bc23454ca797f41bd12c4e05360233978a2

8 years agoMerge "Add '@since 1.25' annotation to wfLoad*() functions"
jenkins-bot [Wed, 16 Sep 2015 16:38:01 +0000 (16:38 +0000)]
Merge "Add '@since 1.25' annotation to wfLoad*() functions"

8 years agoresourceloader: Add missing argument to makeLoaderImplementScript
jeroendedauw [Wed, 16 Sep 2015 14:53:18 +0000 (16:53 +0200)]
resourceloader: Add missing argument to makeLoaderImplementScript

Change-Id: I661ec86ab53639be6999e15ac20c726477fae8a5

8 years agoRemove dead local vars in ApiRevisionDelete
jeroendedauw [Wed, 16 Sep 2015 14:58:03 +0000 (16:58 +0200)]
Remove dead local vars in ApiRevisionDelete

Change-Id: I9c5ab515e9c95402e73423d4aa8632d57660bdff

8 years agoAdd missing argument to dieDebug call so it does not die
jeroendedauw [Wed, 16 Sep 2015 14:52:39 +0000 (16:52 +0200)]
Add missing argument to dieDebug call so it does not die

Change-Id: I672f4f1a407b35bf88216508156035ef96a7289f

8 years agoAdd '@since 1.25' annotation to wfLoad*() functions
Bartosz Dziewoński [Wed, 16 Sep 2015 13:55:13 +0000 (15:55 +0200)]
Add '@since 1.25' annotation to wfLoad*() functions

Change-Id: I2cf9c2eddaa8b3449bd2852c496515b5bc133981

8 years agomediawiki.Title: Correct documentation
Bartosz Dziewoński [Wed, 16 Sep 2015 12:30:59 +0000 (14:30 +0200)]
mediawiki.Title: Correct documentation

Follow-up to a074db332cc103319adacabcc52b1f615217e222, which removed a
config option but not its documentation entry.

Change-Id: I3a0596b27da9e36eb2bb718a635130341545abab

8 years agoMake MWExceptionHandler work with PHP7's exception changes
jeroendedauw [Mon, 7 Sep 2015 18:37:57 +0000 (20:37 +0200)]
Make MWExceptionHandler work with PHP7's exception changes

See https://wiki.php.net/rfc/throwable-interface

Bug: T107933
Change-Id: I703c8710c8adeff14c1cbaab89f5688f6cb96c24

8 years agoMerge "When aborting EnhancedRC block line, block should reflect that"
jenkins-bot [Wed, 16 Sep 2015 11:00:33 +0000 (11:00 +0000)]
Merge "When aborting EnhancedRC block line, block should reflect that"

8 years agoWhen aborting EnhancedRC block line, block should reflect that
Matthias Mullie [Wed, 16 Sep 2015 10:44:04 +0000 (10:44 +0000)]
When aborting EnhancedRC block line, block should reflect that

It was possible to abort the rendering of all block lines, but
the block would still be rendered (with nothing inside). It
would also render a "x changes" link, even though that "x" is
no longer correct.

This had been reverted in adba11dfe332c4c10dbbf0f817982d4a225de6b1,
but has now been fixed up.

Change-Id: Ic5d15e56bc2f46fa6aa8c9375f3cafeb13e1ea9c

8 years agoMerge "Revert "When aborting EnhancedRC block line, block should reflect that""
jenkins-bot [Wed, 16 Sep 2015 10:12:02 +0000 (10:12 +0000)]
Merge "Revert "When aborting EnhancedRC block line, block should reflect that""

8 years agoRevert "When aborting EnhancedRC block line, block should reflect that"
Catrope [Wed, 16 Sep 2015 09:56:29 +0000 (09:56 +0000)]
Revert "When aborting EnhancedRC block line, block should reflect that"

Caused errors when there were two new topics created on the
same Flow board on the same day.

BadMethodCallException from line 496 of
Call to a member function getTitle() on a non-object (NULL)

This reverts commit b30417048bb4b6b785ecae4a8b90aa1f452c4412.

Bug: T112738
Change-Id: Ib404d78eaf1aa9ac7ea34516183bcc9956efc515

8 years agoMerge "mediawiki.Title: Remove fileExtension option from newFromFileName"
jenkins-bot [Wed, 16 Sep 2015 06:21:47 +0000 (06:21 +0000)]
Merge "mediawiki.Title: Remove fileExtension option from newFromFileName"

8 years agomediawiki.Title: Remove fileExtension option from newFromFileName
Timo Tijhof [Sat, 12 Sep 2015 05:45:00 +0000 (06:45 +0100)]
mediawiki.Title: Remove fileExtension option from newFromFileName

Follows-up cc8b00ed5b55a4946533.

Has confusing behaviour and is not used anywhere in Wikimedia Git,
nor in on-wiki scripts.

Change-Id: Ibc1a821df93fab67856d025cf6671f41efdaebb1

8 years agoresourceloader: Don't localise hidden exception
Timo Tijhof [Tue, 15 Sep 2015 18:35:13 +0000 (19:35 +0100)]
resourceloader: Don't localise hidden exception

Mechanical stacktraces are mostly program identifiers (which are English) with some
glue text.

When stacktraces are disabled by the site admin, the replacement message doesn't
seem valuable to localise. And one could argue it should be in the user language
instead of the site language in that case, which complicates the output buffer
and caching layers for this.

It also reduces coupling with MediaWiki (Ref T32956).

Change-Id: If446f1b815add2be4baf1c333f18a4bab0cc9c37

8 years agoresourceloader: Support absolute-path references in mw.loader.load()
Timo Tijhof [Tue, 15 Sep 2015 23:51:18 +0000 (00:51 +0100)]
resourceloader: Support absolute-path references in mw.loader.load()

Follows-up b5e69c4ef621 which made loader sources no longer expanded urls.

Change-Id: Ia2fcd13f46d548a98620c3e78b8f59b81d976eb4

8 years agoMerge "resourceloader: Don't call wfExpandUrl() on load.php urls"
jenkins-bot [Tue, 15 Sep 2015 23:25:38 +0000 (23:25 +0000)]
Merge "resourceloader: Don't call wfExpandUrl() on load.php urls"

8 years agoMerge "SpecialMovepage: Convert form to use OOUI controls"
jenkins-bot [Tue, 15 Sep 2015 22:40:01 +0000 (22:40 +0000)]
Merge "SpecialMovepage: Convert form to use OOUI controls"

8 years agoresourceloader: Don't call wfExpandUrl() on load.php urls
Timo Tijhof [Tue, 15 Sep 2015 20:21:04 +0000 (21:21 +0100)]
resourceloader: Don't call wfExpandUrl() on load.php urls

wfExpandUrl() should only be used if the url needs to be absolute
and/or needs to point to the canonical, internal or default wgServer
for the wiki.

For meta-data or API responses this can make sense, but for resources
loaded by the browser from the current page, there is no added value
in expanding these to the default domain.

This is causing problems in custom setups such as at Wikimedia,
with "zero" and "m" sub domains for which $wgServer points to the
canonical domain.

Bug: T106966
Bug: T112646
Change-Id: Ie25d3a8f69564319a1b29b5c5904f3d352924a31

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 15 Sep 2015 20:06:39 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ia4020fe3ad9f37dc5f8a5f1b27974582edfdd2f4

8 years agoRemove unused private methods in FauxRequest
jeroendedauw [Mon, 7 Sep 2015 19:22:23 +0000 (21:22 +0200)]
Remove unused private methods in FauxRequest

Change-Id: I49a0a8ced0819eeef3ff404fc14b0b90c36b0922

8 years agoRemove WMF deployment hack for .feedlink from mediawiki.legacy.shared
Bartosz Dziewoński [Sun, 16 Aug 2015 14:17:47 +0000 (16:17 +0200)]
Remove WMF deployment hack for .feedlink from mediawiki.legacy.shared

To be merged 30 days after 579ec5dee1cdb08fc6c94121ff5570a501f98e0c is
deployed, and we know for sure that the new mediawiki.feedlink module
is included on all pages that need it.

Bug: T89981
Change-Id: I1e47b626fa937066823f056aec6fbc0205fdb9b6

8 years agoMerge "Allow Linker::formatComment to link to another wiki per default."
jenkins-bot [Tue, 15 Sep 2015 18:49:08 +0000 (18:49 +0000)]
Merge "Allow Linker::formatComment to link to another wiki per default."

8 years agoMerge "mediawiki.Upload.Dialog: Remove size config from example docs"
jenkins-bot [Tue, 15 Sep 2015 16:49:37 +0000 (16:49 +0000)]
Merge "mediawiki.Upload.Dialog: Remove size config from example docs"

8 years agomediawiki.Upload.Dialog: Remove size config from example docs
Ed Sanders [Tue, 15 Sep 2015 16:09:18 +0000 (17:09 +0100)]
mediawiki.Upload.Dialog: Remove size config from example docs

The dialog has a default size (inherited static.size value) and
we shouldn't be encouraging the user to change it, especially
as we add more things to the layout.

Change-Id: I684dfba14e8d872733a7ff2573b67578bce25762

8 years agoAllow Linker::formatComment to link to another wiki per default.
daniel [Mon, 7 Sep 2015 17:02:24 +0000 (19:02 +0200)]
Allow Linker::formatComment to link to another wiki per default.

This also adds tests against injection to LinkerTest.

Bug: T111676
Change-Id: I757f2b91f3b50d789d04e530049c34b4628253e3

8 years agoIgnore exceptions from document.querySelector()
Roan Kattouw [Tue, 15 Sep 2015 13:25:36 +0000 (15:25 +0200)]
Ignore exceptions from document.querySelector()

In Firefox and Safari, passing selectors with pseudo-elements
into querySelector() can cause it to throw an exception.
Ignore these exceptions rather than aborting the selector audit.

Bug: T112650
Change-Id: I9a1bd5eb6ff5ea11eb70ff5bda994b4e51d2431e

8 years agoMerge "resourceloader: Jobs created in request() should wait for executing modules"
jenkins-bot [Tue, 15 Sep 2015 14:03:31 +0000 (14:03 +0000)]
Merge "resourceloader: Jobs created in request() should wait for executing modules"

8 years agoMerge "Use XmlSelect in SpecialEditTags"
jenkins-bot [Tue, 15 Sep 2015 14:03:27 +0000 (14:03 +0000)]
Merge "Use XmlSelect in SpecialEditTags"

8 years agoMerge "Enable multiple default values for XmlSelect"
jenkins-bot [Tue, 15 Sep 2015 13:54:40 +0000 (13:54 +0000)]
Merge "Enable multiple default values for XmlSelect"

8 years agoMerge "Removed clearSharedCache() hack in User.php"
jenkins-bot [Tue, 15 Sep 2015 12:13:12 +0000 (12:13 +0000)]
Merge "Removed clearSharedCache() hack in User.php"

8 years agoresourceloader: Proxy 'window.performance' to support Safari bug
Timo Tijhof [Tue, 15 Sep 2015 00:50:32 +0000 (01:50 +0100)]
resourceloader: Proxy 'window.performance' to support Safari bug

Follows-up 5b0749d, which first introduced a call to performance.mark
outside of startup.js – thus triggering this excotic bug in Safari.

In Safari the native thread MAY (emphasis on MAY) decide at any
point to recreate window.performance and blow away any previously
succesfully attached properties.

Bug: T112287
Change-Id: I653e580566da5335d34f1cf1ef52f51ceee2cf5a

8 years agoMerge "build: Upgrade grunt-banana-checker to v0.3.0"
jenkins-bot [Mon, 14 Sep 2015 23:45:46 +0000 (23:45 +0000)]
Merge "build: Upgrade grunt-banana-checker to v0.3.0"

8 years agoMerge "Provide VRS objects with a name for more informative debugging/logging"
jenkins-bot [Mon, 14 Sep 2015 19:54:06 +0000 (19:54 +0000)]
Merge "Provide VRS objects with a name for more informative debugging/logging"

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 14 Sep 2015 19:40:34 +0000 (21:40 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4dc82c7424593f75b6247775104503b7eec82fff

8 years agoProvide VRS objects with a name for more informative debugging/logging
C. Scott Ananian [Mon, 14 Sep 2015 18:36:18 +0000 (14:36 -0400)]
Provide VRS objects with a name for more informative debugging/logging

Bug: T112330
Change-Id: Iaa3af55ebc426d54e8bef94dba5415bc535e096b

8 years agoRemove WikiReference::getHostname.
daniel [Fri, 11 Sep 2015 17:34:54 +0000 (19:34 +0200)]
Remove WikiReference::getHostname.

getHostname() was broken and seems to be unused.

Change-Id: I8d44a6907ad395ea12deebf404831c06e07ed401

8 years agoMerge "Add support for fragments to WikiMap"
jenkins-bot [Mon, 14 Sep 2015 10:12:41 +0000 (10:12 +0000)]
Merge "Add support for fragments to WikiMap"

8 years agoMerge "Add tests for WikiMap and WikiReference"
jenkins-bot [Mon, 14 Sep 2015 10:12:37 +0000 (10:12 +0000)]
Merge "Add tests for WikiMap and WikiReference"

8 years agoUse XmlSelect in SpecialEditTags
Geoffrey Mon [Sun, 13 Sep 2015 23:00:37 +0000 (23:00 +0000)]
Use XmlSelect in SpecialEditTags

Bug: T93234
Change-Id: I758691f230cff04540b358e9881fe2bfac2d1b9e

8 years agoEnable multiple default values for XmlSelect
Geoffrey Mon [Sun, 13 Sep 2015 22:52:33 +0000 (22:52 +0000)]
Enable multiple default values for XmlSelect

Useful for when a <select> tag with the 'multiple' attribute is

Bug: T93234
Change-Id: Ib83aed3392cf15cce4637fac56979a0f6b3d6b2f

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 13 Sep 2015 19:42:12 +0000 (21:42 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4893e65a430118dbe35f90144afa492899f90150

8 years agoRemoving MediaWiki:Yourgender/de-formal
maurelio [Sun, 13 Sep 2015 15:18:29 +0000 (17:18 +0200)]
Removing MediaWiki:Yourgender/de-formal

Bug: T111795
Change-Id: Iced432dda98b88c0c4fecfe30a2f6d3c67219273

8 years agoSpecialPagesWithProp: convert implicit join into join_conds
Ricordisamoa [Sun, 23 Aug 2015 10:36:38 +0000 (12:36 +0200)]
SpecialPagesWithProp: convert implicit join into join_conds

Bug: T71083
Change-Id: Ic36ecd33a9b4b2ad8b3ca24fabbe496c5207b28f

8 years agoMerge "Add missing images used in installer's CSS"
jenkins-bot [Sat, 12 Sep 2015 18:10:07 +0000 (18:10 +0000)]
Merge "Add missing images used in installer's CSS"

8 years agoAdd missing images used in installer's CSS
Bartosz Dziewoński [Sat, 12 Sep 2015 17:54:00 +0000 (19:54 +0200)]
Add missing images used in installer's CSS

Copied from resources/src/mediawiki.legacy/images.
Follow-up to 1e06a9f02f9a3ca645f5abe5cd38943fcfa3aea2.

Bug: T111519
Change-Id: Idb7f02ee62eb535af3c2dbbaed53dabe04ae4e9e

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 12 Sep 2015 17:41:28 +0000 (19:41 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib11cc9121522a71ea2a8ea13192e445f44ee4cb3

8 years agoRephrase api-help-param-list for clarity
Amir E. Aharoni [Sat, 12 Sep 2015 10:04:51 +0000 (13:04 +0300)]
Rephrase api-help-param-list for clarity

What is currently shown on the ApiHelp is something like this:
One value: title, text, nearmatch

It would be clearer to say
One of the following values: title, text, nearmatch

The example is from

Change-Id: I92f17f90ae77c6c151b817bae8b2f08d858a0f64

8 years agoMerge "Remove unused $wgAPIGeneratorModules from DefaultSettings.php"
jenkins-bot [Sat, 12 Sep 2015 07:16:00 +0000 (07:16 +0000)]
Merge "Remove unused $wgAPIGeneratorModules from DefaultSettings.php"

8 years agoSpecialUpload: Improve display of error messages
Bartosz Dziewoński [Fri, 11 Sep 2015 21:15:46 +0000 (23:15 +0200)]
SpecialUpload: Improve display of error messages

Before: https://phabricator.wikimedia.org/F2569195
After:  https://phabricator.wikimedia.org/F2569202

Change-Id: I212ea1fa4074868c3d2a18d51fb43da786f47d1d

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 11 Sep 2015 22:49:35 +0000 (00:49 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I71bc38489ea62625740f6dd9d73ca046bcf8e400

8 years agoMerge "mediawiki.Title: Add normalizeExtension method"
jenkins-bot [Fri, 11 Sep 2015 20:45:53 +0000 (20:45 +0000)]
Merge "mediawiki.Title: Add normalizeExtension method"

8 years agoRemove unused $wgAPIGeneratorModules from DefaultSettings.php
Kunal Mehta [Fri, 11 Sep 2015 20:39:13 +0000 (13:39 -0700)]
Remove unused $wgAPIGeneratorModules from DefaultSettings.php

This is completely ignored by the API and never made it into a stable
release - it was added and removed in 1.21.

Change-Id: I87a8df78a4bcffae9bbd51faa1137abb1faf2aa2

8 years agomediawiki.Title: Add normalizeExtension method
Bartosz Dziewoński [Fri, 11 Sep 2015 19:38:40 +0000 (21:38 +0200)]
mediawiki.Title: Add normalizeExtension method

And use it in newFromUserInput to canonicalize the extension better.

Comes with tests for the new method, and some new test cases for

Bug: T48741
Change-Id: I1cf240b991dc170c46ba76b207b4e4ba77f87956

8 years agoFixed some IDEA doc warnings
Aaron Schulz [Fri, 11 Sep 2015 19:38:37 +0000 (12:38 -0700)]
Fixed some IDEA doc warnings

Change-Id: I9ccc6599d5fbcc143ef33a5619b3c1d1c52e192f

8 years agoMerge "mw.widgets.CategorySelector: Add configuration to limit number of results"
jenkins-bot [Fri, 11 Sep 2015 14:47:15 +0000 (14:47 +0000)]
Merge "mw.widgets.CategorySelector: Add configuration to limit number of results"

8 years agoMerge "mw.widgets.CategorySelector: Return {string}[] from getNewMenuItems' promise"
jenkins-bot [Fri, 11 Sep 2015 14:38:44 +0000 (14:38 +0000)]
Merge "mw.widgets.CategorySelector: Return {string}[] from getNewMenuItems' promise"

8 years agoMerge "mw.widgets.TitleInputWidget: Set default for limit during config init"
jenkins-bot [Fri, 11 Sep 2015 14:27:24 +0000 (14:27 +0000)]
Merge "mw.widgets.TitleInputWidget: Set default for limit during config init"

8 years agoAdd support for fragments to WikiMap
daniel [Fri, 11 Sep 2015 14:17:52 +0000 (16:17 +0200)]
Add support for fragments to WikiMap

WikiMap::makeForeignUrl should support fragement IDs in the
generated URL.

Change-Id: I612d5f465822b56356a78b3e72fb441a888668f1

8 years agoAdd tests for WikiMap and WikiReference
daniel [Fri, 11 Sep 2015 14:21:16 +0000 (16:21 +0200)]
Add tests for WikiMap and WikiReference

Change-Id: Ie218296fc7c1ceba588fadef076d66be865b1905

8 years agomw.widgets.CategorySelector: Add configuration to limit number of results
Prateek Saxena [Fri, 11 Sep 2015 06:05:38 +0000 (11:35 +0530)]
mw.widgets.CategorySelector: Add configuration to limit number of results

Change-Id: I530bca7950fa75e667d7e5f08d51b304fe3ad14b

8 years agomw.widgets.CategorySelector: Return {string}[] from getNewMenuItems' promise
Prateek Saxena [Fri, 11 Sep 2015 05:47:37 +0000 (11:17 +0530)]
mw.widgets.CategorySelector: Return {string}[] from getNewMenuItems' promise

The object that was being returned only replicated the data with no added
ease of use to the method that was consuming it.

Change-Id: Ieabc6b12ea2ba28e3ef80e451dd2b9e8190ff1e8

8 years agoresourceloader: Jobs created in request() should wait for executing modules
Timo Tijhof [Fri, 11 Sep 2015 05:20:54 +0000 (06:20 +0100)]
resourceloader: Jobs created in request() should wait for executing modules

Fix a regression from 6e903b94f2. It failed to update this code to account for
the new "executing" state.

This code was sometimes causing the job dependencies to be an empty array
when the module in question is currently being executed. As such the job
wasn't blocked by anything and happily run the next time a random module
invoked handlePending to run any jobs that have been satisfied.


* in-page RLQ: Page loads a module X that contains scripts and styles.
  - state=loading
* Module X is found in storage and implemented.
  - state=executing
* execute() adds styles to css buffer (which is asynchronous).
  It provides a callback from which it would run the module's script, set
  to "ready", and trigger handlePending().
* in-page RLQ: The edit page uses 'mw.loader.using' to require module X
  and has a callback that uses the module.
* using() sees X is not already "ready", so it calls request() for X.
* request() creates a job for "X". It then wrongly filters out X from the list
  of modules to wait for. The filter is intended to remove modules that are
  complete (e.g. "ready", "error", or "missing"). After 6e903b94f2, it also
  removed anything with state "executing". This resulted in a job with
  an empty dependency list (nothing to wait for).
* The callstack is finished. At some point the css buffer will call back.
  Some other module requested before X enters state "ready" and triggers
  handlePending(). It finds an left-over empty job with no dependencies
  and runs it. "It" being the callback of X – eventhough X isn't ready.

The added test fails without the change in mediawiki.js.

Bug: T112232
Change-Id: I3cc0c282e68a37b9b3256b213508362734161655

8 years agomw.widgets.TitleInputWidget: Set default for limit during config init
Prateek Saxena [Fri, 11 Sep 2015 06:06:44 +0000 (11:36 +0530)]
mw.widgets.TitleInputWidget: Set default for limit during config init

Change-Id: I2a78175b904247a3dceeeeb68c68067367c0dbbd

8 years agoresourceloader: Document internal mw.loader#jobs property
Timo Tijhof [Fri, 11 Sep 2015 04:37:30 +0000 (05:37 +0100)]
resourceloader: Document internal mw.loader#jobs property

Also use push() instead of old-fashioned micro-optimising .length
assignment. This is inconsistent with the rest of the code and in
modern browsers push is as fast (or faster; < 0.1% difference).

Change-Id: Iaad007cb7a5f2afcab3f0859d2525d49e86775c0

8 years agoMake signature of RaggettInternalHHVM::cleanWrapped() compatible with RaggetBase's
Ori Livneh [Fri, 11 Sep 2015 04:06:01 +0000 (21:06 -0700)]
Make signature of RaggettInternalHHVM::cleanWrapped() compatible with RaggetBase's

Change-Id: I18239e7c6ba77a00c59015b791b7ea7e55154307

8 years agoAdd Html5Depurate tidy driver
Tim Starling [Thu, 3 Sep 2015 04:46:48 +0000 (14:46 +1000)]
Add Html5Depurate tidy driver

Also document input format for MWTidy::tidy().

Change-Id: I77071d3db0524695c2baf9a4670ca2455438c83d

8 years agoMerge "Abstract and refactor Tidy support"
jenkins-bot [Fri, 11 Sep 2015 03:30:17 +0000 (03:30 +0000)]
Merge "Abstract and refactor Tidy support"

8 years agoAbstract and refactor Tidy support
Tim Starling [Mon, 31 Aug 2015 04:42:55 +0000 (14:42 +1000)]
Abstract and refactor Tidy support

* Split tidy implementations into a class hierarchy
* Bring all tidy configuration into a single associative array and
  deprecate the old configuration.
* Remove $wgAlwaysUseTidy

This is preparatory to replacement of Tidy (T89331). I used the name
"Raggett" for things relating to Dave Raggett's Tidy, since if we use
"tidy" to mean the new abstract system as well as Raggett's tidy, it
gets confusing.

Change-Id: I77af1a16cbbb47fc226d05fb9aad56c58e8910b5

8 years agoMerge "Made uploadLinksBox() use quickUserCan() to avoid title blacklist queries"
jenkins-bot [Fri, 11 Sep 2015 01:14:49 +0000 (01:14 +0000)]
Merge "Made uploadLinksBox() use quickUserCan() to avoid title blacklist queries"

8 years agoMade uploadLinksBox() use quickUserCan() to avoid title blacklist queries
Aaron Schulz [Fri, 11 Sep 2015 00:57:29 +0000 (17:57 -0700)]
Made uploadLinksBox() use quickUserCan() to avoid title blacklist queries

Change-Id: I48347acfa70020313d6860d95bc9f286ced9400b

8 years agomediawiki.less: wrap '\9' CSS hack in e() call to pacify persnickety parsers
Ori Livneh [Thu, 10 Sep 2015 21:59:39 +0000 (14:59 -0700)]
mediawiki.less: wrap '\9' CSS hack in e() call to pacify persnickety parsers

`oyejorge/less.php` is an alternate LESS library for PHP that I am hoping to
use to replace lessphp (see T112035). It chokes on literal '\9' in CSS rules,
but this limitation is easy to work around via e().

Change-Id: I015ac022c575fc09fa7dab0d4084ee9de4c563f8

8 years agoRemove dead local vars in UsercreateTemplate
jeroendedauw [Mon, 7 Sep 2015 19:46:29 +0000 (21:46 +0200)]
Remove dead local vars in UsercreateTemplate

Change-Id: I61738d0d1c1355fdd9a192ab0edf73a78ae3546c

8 years agoMerge "Remove unused private field in MagicWordArray"
jenkins-bot [Thu, 10 Sep 2015 19:25:51 +0000 (19:25 +0000)]
Merge "Remove unused private field in MagicWordArray"

8 years agoMerge "jquery.tablesorter: Add ability for cells with colspan in tbody"
jenkins-bot [Thu, 10 Sep 2015 19:19:42 +0000 (19:19 +0000)]
Merge "jquery.tablesorter: Add ability for cells with colspan in tbody"

8 years agoRemove unused private field in MagicWordArray
jeroendedauw [Mon, 7 Sep 2015 19:45:36 +0000 (21:45 +0200)]
Remove unused private field in MagicWordArray

Change-Id: Ib7a0c2834314e9c8db442956230d389e51dbb256

8 years agoMerge "Remove dead argument in LinkSearchPage"
jenkins-bot [Thu, 10 Sep 2015 19:09:39 +0000 (19:09 +0000)]
Merge "Remove dead argument in LinkSearchPage"

8 years agoMerge "mw.widget.DateInputWidget: Correct docs for mustBeAfter and mustBeBefore"
jenkins-bot [Thu, 10 Sep 2015 19:07:54 +0000 (19:07 +0000)]
Merge "mw.widget.DateInputWidget: Correct docs for mustBeAfter and mustBeBefore"

8 years agoRemove dead argument in LinkSearchPage
jeroendedauw [Mon, 7 Sep 2015 19:50:53 +0000 (21:50 +0200)]
Remove dead argument in LinkSearchPage

Change-Id: I43ecb7e3c9421a04ba186d7cc6065f80d4994433

8 years agoMerge "Remove return of void method results"
jenkins-bot [Thu, 10 Sep 2015 18:57:29 +0000 (18:57 +0000)]
Merge "Remove return of void method results"

8 years agoRemove return of void method results
jeroendedauw [Tue, 8 Sep 2015 00:36:29 +0000 (02:36 +0200)]
Remove return of void method results

Change-Id: I095ba37ceb150fcb7bee9df80201437c78426938

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 10 Sep 2015 18:42:38 +0000 (20:42 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Iec30781dc432dea8d3a6a0773309937baaa1b916