5 years agoTitle: Don't create mSubpages member variable
Kunal Mehta [Thu, 20 Jul 2017 01:56:19 +0000 (18:56 -0700)]
Title: Don't create mSubpages member variable

This variable is set and then immediately returned. It's never read
from, so it doesn't make sense as a member variable.

Change-Id: I507895c32b754b8606fb162db321294d31ab6d4e

5 years agoMerge "maintenance: Consistently use hasOption() for boolean options"
jenkins-bot [Wed, 19 Jul 2017 22:08:02 +0000 (22:08 +0000)]
Merge "maintenance: Consistently use hasOption() for boolean options"

5 years agoMerge "Add link to Special:PrefixIndex in delete dialog"
jenkins-bot [Wed, 19 Jul 2017 22:02:04 +0000 (22:02 +0000)]
Merge "Add link to Special:PrefixIndex in delete dialog"

5 years agoMerge "Revert "Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget""
Tjones [Wed, 19 Jul 2017 21:51:17 +0000 (21:51 +0000)]
Merge "Revert "Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget""

5 years agoAdd link to Special:PrefixIndex in delete dialog
Étienne Beaulé [Fri, 1 Aug 2014 02:56:27 +0000 (22:56 -0400)]
Add link to Special:PrefixIndex in delete dialog

This change adds a warning to ?action=delete with a link to a
Special:PrefixIndex of the page being deleted if the page being deleted
has subpages.

If there are less than 50 subpages, the exact count will be mentioned in
the message.

Bug: T32666
Change-Id: Ibd705ed77452a55f782ed855c676d7ee23e9ad61

5 years agoRevert "Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget"
EBernhardson [Wed, 19 Jul 2017 21:36:17 +0000 (21:36 +0000)]
Revert "Make mw.widgets.SearchInputWidget extend OO.ui.SearchInputWidget"

Typing a search query into the main box on Special:Search
causes the search to be performed for the first autocomplete
result, rather than the typed query. The first autocomplet
result should only be searched for if explicitly selected with
the mouse or arrow key.

This reverts commit 7882e3b66060f7bbd37e15688baf4dd30954b1b7.

Bug: T171112
Change-Id: I1af6ba90542fafe3ed1aeca420e9d6df6612f7d0

5 years agoMerge "IcuCollation: Fix diacritic characters for Aromanian (rup) and Moldovan (mo...
jenkins-bot [Wed, 19 Jul 2017 20:11:42 +0000 (20:11 +0000)]
Merge "IcuCollation: Fix diacritic characters for Aromanian (rup) and Moldovan (mo) headings"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 19 Jul 2017 20:00:38 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If2ca75be14878eb12f54f36e6365872b15c5f7e3

5 years agoMerge "Simplify print styles"
jenkins-bot [Wed, 19 Jul 2017 19:57:48 +0000 (19:57 +0000)]
Merge "Simplify print styles"

5 years agomaintenance: Consistently use hasOption() for boolean options
Timo Tijhof [Wed, 19 Jul 2017 19:51:30 +0000 (14:51 -0500)]
maintenance: Consistently use hasOption() for boolean options

We already do this in many places, but there were also still plenty
of getOption(, false) calls. Change these to hasOption() for consistency.

Change-Id: I74f91a5bf5a8036496ab1f493e5862a04d27ec0f

5 years agoIcuCollation: Fix diacritic characters for Aromanian (rup) and Moldovan (mo) headings
Bartosz Dziewoński [Wed, 19 Jul 2017 19:48:56 +0000 (21:48 +0200)]
IcuCollation: Fix diacritic characters for Aromanian (rup) and Moldovan (mo) headings

They should be Ș, Ț (comma-below) and instead they were cedilla-below (Ş, Ţ).
Same as for Romanian (ro) in 486f64f28302ecceed04977180fd21470cb54c81.

Both of these languages are unsupported by libicu and so the collations
are unlikely to have been used in practice.

Bug: T171043
Bug: T171044
Change-Id: Idd0d593e73cd784fbef7b75e8985f988f5555e26

5 years agoSimplify print styles
Volker E [Thu, 10 Nov 2016 04:49:49 +0000 (20:49 -0800)]
Simplify print styles

Simplifying CSS code by
- merging similar selectors,
- reordering them by CSS specificity and within selectors alphabetically &
- applying simpler `line-height` units dependent on `font-size` instead
of absolute.

Bug: T135022
Bug: T169823
Change-Id: I9aa92a3e70991126c56df0a6db408d1c6f84f172

5 years agoMerge "Set batch size to 1000 in updateRestrictions"
jenkins-bot [Wed, 19 Jul 2017 19:18:29 +0000 (19:18 +0000)]
Merge "Set batch size to 1000 in updateRestrictions"

5 years agoRCFilters: proper group name for user experience level
Stephane Bisson [Wed, 19 Jul 2017 18:49:18 +0000 (14:49 -0400)]
RCFilters: proper group name for user experience level

It's "User registration and experience",
not "Experience registration and experience".

Bug: T165160
Change-Id: Ie28de2ace687acb0cdd2a4d9c5de1158be3647e8

5 years agoUpdate FIRST_LETTER_VERSION for rowiki changes
Brian Wolff [Wed, 19 Jul 2017 17:37:29 +0000 (17:37 +0000)]
Update FIRST_LETTER_VERSION for rowiki changes

Can't just clear cache on production, as this
now uses per-server apc instance.

Follow-up 486f64f28302ecceed04977

Change-Id: I88df6d5a91c86ef687543d1a6988e0ec050bbfce

5 years agoMerge "IcuCollation: Fix diacritic characters for Romanian (ro) headings"
jenkins-bot [Wed, 19 Jul 2017 17:41:09 +0000 (17:41 +0000)]
Merge "IcuCollation: Fix diacritic characters for Romanian (ro) headings"

5 years agoSet batch size to 1000 in updateRestrictions
Reedy [Wed, 19 Jul 2017 17:35:02 +0000 (18:35 +0100)]
Set batch size to 1000 in updateRestrictions

As far as can be seen on enwiki, very few rows to update

Change-Id: Idf8dee951a5240c4ebaa73fc02c1248a6737b3f8

5 years agoIcuCollation: Fix diacritic characters for Romanian (ro) headings
Bartosz Dziewoński [Wed, 19 Jul 2017 14:27:50 +0000 (16:27 +0200)]
IcuCollation: Fix diacritic characters for Romanian (ro) headings

They should be Ș, Ț (comma-below) and instead they were cedilla-below (Ş, Ţ).

Bug: T168711
Change-Id: I6dc873c3ce93bca3e425439f70d0fb30aecc9533

5 years agoMerge "Support custom offsets from SearchResultSet"
jenkins-bot [Wed, 19 Jul 2017 10:57:28 +0000 (10:57 +0000)]
Merge "Support custom offsets from SearchResultSet"

5 years agoReturn a typed object from WikiPage::prepareContentForEdit
Kunal Mehta [Mon, 17 Jul 2017 21:44:53 +0000 (14:44 -0700)]
Return a typed object from WikiPage::prepareContentForEdit

This makes it easier to figure out what values are available and
includes documentation about each field.

This will also allow us to add deprecation warnings for deprecated
properties via __get() in the future.

Change-Id: I4ecc900372546013253256749563aaa203ff8963

5 years agoSupport custom offsets from SearchResultSet
Erik Bernhardson [Wed, 19 Jul 2017 04:19:48 +0000 (21:19 -0700)]
Support custom offsets from SearchResultSet

Work to support interleaved AB testing of search will display
interleaved results of two search configurations on the first page of
results, but standard results on all pages other than the first page.
This means that while 20 results may be requested, the next 'new' result
of the primary query may be at position 10. Allow the SearchResultSet
to declare what the new offset is.

Bug: T150032
Change-Id: I14c0c33249fcdb66f72f5966e2aa72781a34daee

5 years agoMerge "RCFilters: Emphasize UI when saved query is loaded"
jenkins-bot [Wed, 19 Jul 2017 02:52:26 +0000 (02:52 +0000)]
Merge "RCFilters: Emphasize UI when saved query is loaded"

5 years agoMerge "RCFilters: Increase the initial height of the loading box"
jenkins-bot [Wed, 19 Jul 2017 02:35:04 +0000 (02:35 +0000)]
Merge "RCFilters: Increase the initial height of the loading box"

5 years agoRCFilters: Emphasize UI when saved query is loaded
Moriel Schottlender [Fri, 14 Jul 2017 01:45:36 +0000 (20:45 -0500)]
RCFilters: Emphasize UI when saved query is loaded

Bug: T169063
Change-Id: Ia300ca7bb4afb7d8e247e57e53ecff826ddf0d7e

5 years agoMerge "RCFilters: Add range group filters - limit, days and hours"
jenkins-bot [Wed, 19 Jul 2017 02:32:21 +0000 (02:32 +0000)]
Merge "RCFilters: Add range group filters - limit, days and hours"

5 years agoRCFilters: Add range group filters - limit, days and hours
Moriel Schottlender [Fri, 23 Jun 2017 22:35:03 +0000 (15:35 -0700)]
RCFilters: Add range group filters - limit, days and hours

- Add 'hidden' groups that have base defaults but are not
  viewed in the filter drop-down.
- Add a UI for days, hours and limit selections, based on their
  group models.
- Clean up the fieldset form to remove redundant line breaks
  and empty objects.
- Add 'hours' as a subset of days, where the UI can split itself
  by picking up values >=1 and <1
- Add the ability to allow 'arbitrary' information from the URL
  values, but also make sure there is a validation method
  and a possibility to re-sort the values that are added in.

Bug: T162784
Bug: T162786
Change-Id: I8068a7cc411eef40ddb8af4eef1d4f1e5f2a2b82

5 years agoMerge "RCFilters: Don't emit wikipage.content on first load"
jenkins-bot [Tue, 18 Jul 2017 23:18:51 +0000 (23:18 +0000)]
Merge "RCFilters: Don't emit wikipage.content on first load"

5 years agoMerge "RCFilters: Change `What's this?` i18n based on user testing"
jenkins-bot [Tue, 18 Jul 2017 23:17:41 +0000 (23:17 +0000)]
Merge "RCFilters: Change `What's this?` i18n based on user testing"

5 years agoMerge "RCFilters: Only open one 'Whats This' popup at a time"
jenkins-bot [Tue, 18 Jul 2017 23:10:35 +0000 (23:10 +0000)]
Merge "RCFilters: Only open one 'Whats This' popup at a time"

5 years agoRCFilters: Don't emit wikipage.content on first load
Moriel Schottlender [Mon, 17 Jul 2017 21:38:58 +0000 (14:38 -0700)]
RCFilters: Don't emit wikipage.content on first load

If the first load uses existing DOM elements, don't emit that
hook. Only emit if we're pulling from the server for new results.

Bug: T165350
Change-Id: Ib17fdd16a908808f99fe8506c50c61d90ad4addc

5 years agoRCFilters: Change `What's this?` i18n based on user testing
James D. Forrester [Tue, 18 Jul 2017 23:06:09 +0000 (16:06 -0700)]
RCFilters: Change `What's this?` i18n based on user testing

Also minor tweak to the qqq to help translators understand.

Bug: T169053
Change-Id: If5aebae20d2e0037b28090d85cd9b076ac4b3178

5 years agoMerge "RCFilters: Log filter groupings"
jenkins-bot [Tue, 18 Jul 2017 23:04:10 +0000 (23:04 +0000)]
Merge "RCFilters: Log filter groupings"

5 years agoRCFilters: Only open one 'Whats This' popup at a time
Moriel Schottlender [Tue, 18 Jul 2017 22:19:40 +0000 (15:19 -0700)]
RCFilters: Only open one 'Whats This' popup at a time

Remove 'overlay' and this.$element from the $autoCloseIgnore, since
the entire popup is in the overlay anyways.

Bug: T169047
Change-Id: I57300413297d86eca9bcc3d49766f4e41ab628be

5 years agoRCFilters: Increase the initial height of the loading box
Moriel Schottlender [Tue, 18 Jul 2017 22:05:00 +0000 (15:05 -0700)]
RCFilters: Increase the initial height of the loading box

Bug: T168651
Change-Id: Ia4a079c9d177ad024611112a212a60f725ea1943

5 years agoMerge "maintenance: Add --dry-run option to deleteDefaultMessages.php"
jenkins-bot [Tue, 18 Jul 2017 21:36:14 +0000 (21:36 +0000)]
Merge "maintenance: Add --dry-run option to deleteDefaultMessages.php"

5 years agomaintenance: Add --dry-run option to deleteDefaultMessages.php
Timo Tijhof [Tue, 18 Jul 2017 19:59:24 +0000 (14:59 -0500)]
maintenance: Add --dry-run option to deleteDefaultMessages.php

For back-compat, keep the default as-is, because it is also
used as a post-update script by the installer.

But for convenience and safe manual use, do add a dry-run option.
(Ideally this would be a --delete option and dry-run by default.)

Change-Id: I3ca70f15f50b66f9d19fa705cef9a4aae2dd4e5c

5 years agoMerge "Revert "Localisation updates from https://translatewiki.net.""
L10n-bot [Tue, 18 Jul 2017 20:13:57 +0000 (20:13 +0000)]
Merge "Revert "Localisation updates from https://translatewiki.net.""

5 years agoRevert "Localisation updates from https://translatewiki.net."
Raimond Spekking [Tue, 18 Jul 2017 20:13:46 +0000 (20:13 +0000)]
Revert "Localisation updates from https://translatewiki.net."

Overwrites https://gerrit.wikimedia.org/r/365234

This reverts commit 467a1167a78fc7177957865a081a3f4487a5c061.

Change-Id: Icb4177ffbcc541dd5140c80a4133b868eb8f5169

5 years agoMerge "Remove excess getExternalLB() argument"
jenkins-bot [Tue, 18 Jul 2017 20:13:14 +0000 (20:13 +0000)]
Merge "Remove excess getExternalLB() argument"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 18 Jul 2017 20:11:38 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5888335a51fcc80cdcf19ec6fa59c1cf06434065

5 years agoMerge "RC Filters: combine user registration and experience level filters"
jenkins-bot [Tue, 18 Jul 2017 19:30:55 +0000 (19:30 +0000)]
Merge "RC Filters: combine user registration and experience level filters"

5 years agoMerge "Remove newline at end of MWExceptionRenderer::getShowBacktraceError"
jenkins-bot [Tue, 18 Jul 2017 19:23:40 +0000 (19:23 +0000)]
Merge "Remove newline at end of MWExceptionRenderer::getShowBacktraceError"

5 years agoMerge "build: Upgrade grunt-eslint from 19.0.0 to 20.0.0"
jenkins-bot [Tue, 18 Jul 2017 18:10:48 +0000 (18:10 +0000)]
Merge "build: Upgrade grunt-eslint from 19.0.0 to 20.0.0"

5 years agoMerge "HTMLSelectAndOtherField/HTMLSelectOrOtherField: Add OOUI implementation"
jenkins-bot [Tue, 18 Jul 2017 16:26:11 +0000 (16:26 +0000)]
Merge "HTMLSelectAndOtherField/HTMLSelectOrOtherField: Add OOUI implementation"

5 years agoMerge "DateTimeInputWidget: Ignore wheel when not focused"
jenkins-bot [Tue, 18 Jul 2017 16:11:56 +0000 (16:11 +0000)]
Merge "DateTimeInputWidget: Ignore wheel when not focused"

5 years agobuild: Upgrade grunt-eslint from 19.0.0 to 20.0.0
Ed Sanders [Tue, 18 Jul 2017 13:02:42 +0000 (14:02 +0100)]
build: Upgrade grunt-eslint from 19.0.0 to 20.0.0

Most indent and escaping fixes.

Change-Id: I210e2fc3c0ce3148327ef81f824e1ce9f1e269b6

5 years agoMerge "Export revision IDs to JS config on diff pages"
jenkins-bot [Tue, 18 Jul 2017 15:40:00 +0000 (15:40 +0000)]
Merge "Export revision IDs to JS config on diff pages"

5 years agoRC Filters: combine user registration and experience level filters
Stephane Bisson [Fri, 14 Jul 2017 12:07:41 +0000 (08:07 -0400)]
RC Filters: combine user registration and experience level filters

Add 'registered' and 'unregistered' filters to
user experience group.

Keep minimal definitions of user registration to
support hideanons and hideliu for no-js and
users who are not using ERI filters.

Reword all user experience levels description according
to the phab task.

Bug: T165160
Change-Id: Ie6b1795d7cbdb1692f8eeb13db7afb89ea4e5bbc

5 years agoMerge "Avoid globals in EditPage::__construct()"
jenkins-bot [Tue, 18 Jul 2017 14:44:28 +0000 (14:44 +0000)]
Merge "Avoid globals in EditPage::__construct()"

5 years agoMerge "Introduce config var for moved-paragraph-detection threshold"
jenkins-bot [Tue, 18 Jul 2017 14:20:00 +0000 (14:20 +0000)]
Merge "Introduce config var for moved-paragraph-detection threshold"

5 years agobuild: Update grunt-stylelint
Ed Sanders [Tue, 18 Jul 2017 13:16:24 +0000 (14:16 +0100)]
build: Update grunt-stylelint

Change-Id: I05e48d3eb749d192ccd4b837e4b8dc6307d761af

5 years agoMerge "ChangesListStringOptionsFilter: Make isSelected() respect ALL"
jenkins-bot [Tue, 18 Jul 2017 12:28:25 +0000 (12:28 +0000)]
Merge "ChangesListStringOptionsFilter: Make isSelected() respect ALL"

5 years agoMerge "RCFilters: Correct language for invert button"
jenkins-bot [Tue, 18 Jul 2017 12:23:18 +0000 (12:23 +0000)]
Merge "RCFilters: Correct language for invert button"

5 years agoRemove newline at end of MWExceptionRenderer::getShowBacktraceError
Fomafix [Mon, 3 Jul 2017 14:21:49 +0000 (16:21 +0200)]
Remove newline at end of MWExceptionRenderer::getShowBacktraceError

Also add a period at the end of the sentence.

This changes the HTML comment from

<!-- Set $wgShowExceptionDetails = true; at the bottom
of LocalSettings.php to show detailed debugging


<!-- Set $wgShowExceptionDetails = true; at the bottom
of LocalSettings.php to show detailed debugging
information. -->

This is a follow-up to 842b7a1769 (T162315).

Change-Id: I45ff4f856ad1c0dc72066fce7771077ff4663785

5 years agoExport revision IDs to JS config on diff pages
Ed Sanders [Mon, 17 Jul 2017 20:19:33 +0000 (21:19 +0100)]
Export revision IDs to JS config on diff pages

Bug: T169574
Change-Id: Ic4abaae6e9c74509f7a114a697cdbb78dd1b89b6

5 years agoIntroduce config var for moved-paragraph-detection threshold
Tobias Gritschacher [Thu, 8 Jun 2017 14:59:21 +0000 (16:59 +0200)]
Introduce config var for moved-paragraph-detection threshold

This introduces a configuration variable for the bailout threshold for
the moved-paragraph-detection in wikidiff2.
This allows to rollout a new version of wikidiff2 that supports
detecting changes in moved paragraphs without changing behaviour of all
wikis in production as the default value of the setting (0) will leave the
new feature disabled.
Compatibility with older versions of wikidiff2 is retained by checking for
the version number of wikidiff2 and calling the method without the 4th
parameter if the version is < 0.3.0.

Bug: T166571
Change-Id: Ic01054354a4fbba410e58c9873edcbde797f883d

5 years agoRCFilters: Log filter groupings
Moriel Schottlender [Wed, 12 Jul 2017 23:30:12 +0000 (18:30 -0500)]
RCFilters: Log filter groupings

Depends-On: Ib9df52d708993f2ed29633251365d4af2b6a4761
Change-Id: I09b2d45cdca323d43cf91d0b21bed06f2db8183c

5 years agoMerge "Special:Contributions: Open "To date" widget after selecting a "From date""
jenkins-bot [Tue, 18 Jul 2017 04:02:11 +0000 (04:02 +0000)]
Merge "Special:Contributions: Open "To date" widget after selecting a "From date""

5 years agoMerge "doc: Fix a few Example docs for PHP classes"
jenkins-bot [Tue, 18 Jul 2017 01:50:14 +0000 (01:50 +0000)]
Merge "doc: Fix a few Example docs for PHP classes"

5 years agoMerge "phpunit: Load extension unit tests for --testsuite=skins"
jenkins-bot [Tue, 18 Jul 2017 01:40:08 +0000 (01:40 +0000)]
Merge "phpunit: Load extension unit tests for --testsuite=skins"

5 years agodoc: Fix a few Example docs for PHP classes
Timo Tijhof [Tue, 18 Jul 2017 01:24:32 +0000 (20:24 -0500)]
doc: Fix a few Example docs for PHP classes

* "@example" is specifically for creating entries on the "Examples"
  page produced by Doxygen, which is not specific to individual classes
  or methods, but rather is meant to be about the software as a whole.
  There are currently four entries produced there, and they are all broken:
  - .../src/includes/rcfeed/RedisPubSubFeedEngine.php (unnamed example, broken)
  - .../src/tests/phpunit/MediaWikiTestCase.php (unnamed example)
  - 42 (empty page named "42")
  - user (empty page named "user")

* Remove usage and replace with either a regular paragraph that is
  part of the member/method/class description, or for code examples,
  use "@par" to create a sub heading, and then a @code-@endcode block.

Change-Id: I52c937fef4b377173f6c4dbad9dc4a9f8beae4ee

5 years agophpunit: Load extension unit tests for --testsuite=skins
jdlrobson [Mon, 17 Jul 2017 20:38:01 +0000 (13:38 -0700)]
phpunit: Load extension unit tests for --testsuite=skins

Skins, like extensions, can register PHPUnit tests.
The testsuite interface in PHPUnit is designed to execute one run only,
so this should be based on the semantic entry of "skin jobs".
Changing the Jenkins job to run both doesn't work (only one value accepted).
Working around by running phpunit twice also seems wrong.

Bug: T170880
Change-Id: Ic04f4a842b2912574826b01b00d49db93d51c99b

5 years agoChangesListStringOptionsFilter: Make isSelected() respect ALL
Roan Kattouw [Mon, 17 Jul 2017 23:52:51 +0000 (16:52 -0700)]
ChangesListStringOptionsFilter: Make isSelected() respect ALL

ChangesListStringOptionsGroup::modifyQuery checks for ALL and
behaves accordingly, but isSelected() didn't. This broke conflict
detection when an entire non-full-coverage group was selected.

Bug: T162630
Change-Id: Ie241744201380ca5450d5edbb3eba971194f3df4

5 years agoRemove excess getExternalLB() argument
Aaron Schulz [Mon, 17 Jul 2017 23:32:53 +0000 (16:32 -0700)]
Remove excess getExternalLB() argument

Change-Id: I097b1ba46806649f014ca624d15d9064ee0f9ba7

5 years agoMerge "qunit: Remove redundant conditional for sandbox teardown"
jenkins-bot [Mon, 17 Jul 2017 23:00:57 +0000 (23:00 +0000)]
Merge "qunit: Remove redundant conditional for sandbox teardown"

5 years agoRCFilters: Correct language for invert button
Moriel Schottlender [Mon, 17 Jul 2017 22:38:32 +0000 (15:38 -0700)]
RCFilters: Correct language for invert button

Bug: T166912
Change-Id: Iabbbe2c76d5dc51f2aa49646c84b8eba7bc692a1

5 years agoMerge "Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion"
jenkins-bot [Mon, 17 Jul 2017 21:49:44 +0000 (21:49 +0000)]
Merge "Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion"

5 years agoAvoid globals in EditPage::__construct()
Kunal Mehta [Mon, 17 Jul 2017 21:07:45 +0000 (14:07 -0700)]
Avoid globals in EditPage::__construct()

Change-Id: Icb1d1042f4bb5e4397c49f20ce26ab9c73e9d0d1

5 years agoqunit: Remove redundant conditional for sandbox teardown
Timo Tijhof [Sat, 8 Jul 2017 00:35:26 +0000 (17:35 -0700)]
qunit: Remove redundant conditional for sandbox teardown

Follows-up 0a208911a257, which added support for the `executeNow`
parameter to QUnit.module.

To properly support nested modules, we also need to skip registering
a second setup and teardown because nested modules already run the
beforeEach (setup), and afterEach (teardown), of their parent modules.

During setup this would needlessly create two sandboxes and override
the 'sandbox' property on the same 'this' context object. During
teardown it would fail because the inner module's teardown would
have already torn down the sandbox.

Change-Id: Ib17bbbef45b2bd0247979cf0fa8aed17800c54a0

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 17 Jul 2017 20:05:22 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Iaa3a7149e92d2cee9ad5cd7b445ff8f3ae0684ce

5 years agoMerge "DateInputWidget: Unbreak closing the calendar when selecting a date"
jenkins-bot [Mon, 17 Jul 2017 19:47:01 +0000 (19:47 +0000)]
Merge "DateInputWidget: Unbreak closing the calendar when selecting a date"

5 years agoMerge "RCFilters: Reduce saved queries items height"
jenkins-bot [Mon, 17 Jul 2017 19:44:33 +0000 (19:44 +0000)]
Merge "RCFilters: Reduce saved queries items height"

5 years agoSpecial:Contributions: Open "To date" widget after selecting a "From date"
Roan Kattouw [Wed, 12 Jul 2017 22:40:58 +0000 (15:40 -0700)]
Special:Contributions: Open "To date" widget after selecting a "From date"

Add a 'deactivate' event to DateInputWidget, with a boolean indicating
whether the deactivation occurred because the user chose a date.
Also consolidate some of the code handling this case into the deactivate()

Bug: T120733
Change-Id: Ia56cc28b400a0bc051dff79b2d3870a8954137a6

5 years agoDateInputWidget: Unbreak closing the calendar when selecting a date
Roan Kattouw [Wed, 12 Jul 2017 22:14:45 +0000 (15:14 -0700)]
DateInputWidget: Unbreak closing the calendar when selecting a date

I24327e1fe broke this by reopening the calendar when the handle was focused.

Bonus: also fix auto-closing in { precision: 'month' } mode.

Bug: T120733
Change-Id: Ief43f10c1e01f9a6f90b098e4f8ec1f84d8038d1

5 years agoMerge "rcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning"
jenkins-bot [Mon, 17 Jul 2017 19:07:26 +0000 (19:07 +0000)]
Merge "rcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning"

5 years agoMerge "registration: Allow protocol-relative links in "url" field"
jenkins-bot [Mon, 17 Jul 2017 17:30:47 +0000 (17:30 +0000)]
Merge "registration: Allow protocol-relative links in "url" field"

5 years agoMerge "Bump justinrainbow/json-schema development dependency to ~5.2"
jenkins-bot [Mon, 17 Jul 2017 17:29:06 +0000 (17:29 +0000)]
Merge "Bump justinrainbow/json-schema development dependency to ~5.2"

5 years agoMerge "Update wikimedia/composer-merge-plugin from 1.4.0 -> 1.4.1"
jenkins-bot [Mon, 17 Jul 2017 17:21:13 +0000 (17:21 +0000)]
Merge "Update wikimedia/composer-merge-plugin from 1.4.0 -> 1.4.1"

5 years agorcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning
Bartosz Dziewoński [Mon, 17 Jul 2017 17:19:15 +0000 (19:19 +0200)]
rcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning

When viewing recent changes, I get 'JQMIGRATE: jQuery.unique is
deprecated, use jQuery.uniqueSort' in the console.

The bad parentheses change the meaning of $.extend to try to extend
the global $ object, and somehow that ends up touching deprecated
properties. There might be a jQuery bug here somewhere too.

Change-Id: I49265c5882dd189e2b17916c2e14c62d16235677

5 years agoregistration: Allow protocol-relative links in "url" field
Kunal Mehta [Mon, 17 Jul 2017 17:13:49 +0000 (10:13 -0700)]
registration: Allow protocol-relative links in "url" field

Bug: T93010
Change-Id: I626fb5528b41910d859d8596a8ad350f94c1082e

5 years agoBump justinrainbow/json-schema development dependency to ~5.2
Kunal Mehta [Mon, 17 Jul 2017 17:12:55 +0000 (10:12 -0700)]
Bump justinrainbow/json-schema development dependency to ~5.2


Change-Id: I9e3aa67bcf1f4e7b6b0dc831c64df73ce0fea8fe

5 years agoMerge "Bump minimum required MySQL Version to 5.5.8"
jenkins-bot [Mon, 17 Jul 2017 17:11:54 +0000 (17:11 +0000)]
Merge "Bump minimum required MySQL Version to 5.5.8"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 16 Jul 2017 19:59:08 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ief7038a0c8b5e47b01b177e3a2cd7a472538f02d

5 years agoUpdate wikimedia/composer-merge-plugin from 1.4.0 -> 1.4.1
Reedy [Sun, 16 Jul 2017 15:34:09 +0000 (16:34 +0100)]
Update wikimedia/composer-merge-plugin from 1.4.0 -> 1.4.1


Change-Id: I805516387648ae76a2b22adac6f94c498b69e6a3
Depends-On: I50338e7f64f8eb3ff9e7177f59d93c88e08562d6

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 15 Jul 2017 20:02:18 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9bd42f589285be09db8e45e5eb88966f430228d5

5 years agoMerge "resourceloader: Avoid mw-exception log spam from PHPUnit tests"
jenkins-bot [Sat, 15 Jul 2017 18:23:49 +0000 (18:23 +0000)]
Merge "resourceloader: Avoid mw-exception log spam from PHPUnit tests"

5 years agoBump minimum required MySQL Version to 5.5.8
Reedy [Thu, 13 Jul 2017 16:14:37 +0000 (17:14 +0100)]
Bump minimum required MySQL Version to 5.5.8

Bug: T161232
Change-Id: I5f7d08ad7e58ce89c9fd766f0ac45fa996bf6a44

5 years agoMerge "New maintenance script to recalculate category membership counts"
jenkins-bot [Sat, 15 Jul 2017 08:02:20 +0000 (08:02 +0000)]
Merge "New maintenance script to recalculate category membership counts"

5 years agoNew maintenance script to recalculate category membership counts
This, that and the other [Thu, 26 Jan 2017 11:39:30 +0000 (22:39 +1100)]
New maintenance script to recalculate category membership counts

The category membership counts stored in the category table have a habit of
drifting away from the actual number of pages in the category. This script
identifies incorrectly-counted categories by performing a SELECT on the
replica DB, then querying master for up-to-date counts and updating the
category rows with those counts.

It's possible that a LinksUpdate job will be in progress while this script
is run. LinksUpdate does categorylinks INSERTs and category UPDATEs in
separate transactions, and our count might occur in between, leading to
category values that are slightly off. But since we are only updating
categories with already incorrect counts, we are not making the situation
any worse than it already was.

The script runs reasonably quickly on all but the very largest wikis.

Bug: T18765
Change-Id: I555f068fbf3aee20a7775d5532781f421f706346

5 years agomediawiki.toc: Migrate test from deprecated asyncTest()
Timo Tijhof [Tue, 11 Jul 2017 20:05:17 +0000 (13:05 -0700)]
mediawiki.toc: Migrate test from deprecated asyncTest()

Instead, use assert.async(), or (in this case) return the Promise directly
to QUnit.test, which will naturally await it.
As bonus, it'll handle errors, too. (instead of timing out)

Change-Id: I94ee0bf72a3d8ac2e588cd75cbe0787b5001d5b4

5 years agoresourceloader: Avoid mw-exception log spam from PHPUnit tests
Timo Tijhof [Thu, 13 Jul 2017 05:16:53 +0000 (22:16 -0700)]
resourceloader: Avoid mw-exception log spam from PHPUnit tests

Bug: T50002
Change-Id: Ida18f271883535eca2a1d26ee34120190914d87a

5 years agoMerge "mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start"
jenkins-bot [Sat, 15 Jul 2017 00:27:30 +0000 (00:27 +0000)]
Merge "mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start"

5 years agoMerge "Remove temporary hole in abstractions"
jenkins-bot [Sat, 15 Jul 2017 00:20:12 +0000 (00:20 +0000)]
Merge "Remove temporary hole in abstractions"

5 years agoRemove temporary hole in abstractions
Max Semenik [Fri, 14 Jul 2017 23:36:10 +0000 (16:36 -0700)]
Remove temporary hole in abstractions

Was introduced temprarily to facilitate event logging, now the only caller is gone.

Bug: T166247
Change-Id: I0f9cdccc6b3a566d9f7ebf02515f724348205071

5 years agoRCFilters: Allow experimental live update feature to be enabled with query string...
Roan Kattouw [Fri, 14 Jul 2017 21:35:48 +0000 (14:35 -0700)]
RCFilters: Allow experimental live update feature to be enabled with query string parameter

For testing. Adding ?liveupdate=1 to the URL will unhide the live update button.

Bug: T167743
Change-Id: I2696da959d34adf952f7f2fa6477ab756ef259bd

5 years agoRCFilters: Reduce saved queries items height
Moriel Schottlender [Fri, 14 Jul 2017 20:50:11 +0000 (15:50 -0500)]
RCFilters: Reduce saved queries items height

Bug: T164861
Change-Id: I30a558bc73cc552e0d2b70ab7fd9299e866fd6d2

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 14 Jul 2017 20:01:37 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I272241868eec5790ebc164f74b3d8f6982153776

5 years agoMerge "Add urlencode for URL encoding of lang values"
jenkins-bot [Fri, 14 Jul 2017 17:29:40 +0000 (17:29 +0000)]
Merge "Add urlencode for URL encoding of lang values"

5 years agoMerge "ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format...
jenkins-bot [Fri, 14 Jul 2017 14:04:10 +0000 (14:04 +0000)]
Merge "ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rows"

5 years agoDateTimeInputWidget: Ignore wheel when not focused
Brad Jorsch [Fri, 14 Jul 2017 12:42:47 +0000 (08:42 -0400)]
DateTimeInputWidget: Ignore wheel when not focused

Much like I6c9f4679, it's probably best that the widget only use wheel
input when it's focused so it won't accidentally trigger when scrolling
through a form.

Bug: T170607
Change-Id: I46dc3eb01733be939c62e7e7f3f044f21ef1e6d8