lhc/web/wiklou.git
3 years agoDeprecate Parser::fetchFile() since it's unused
Kunal Mehta [Mon, 28 May 2018 06:16:28 +0000 (23:16 -0700)]
Deprecate Parser::fetchFile() since it's unused

Change-Id: Ic2bc3dd0479a373159a22da5f0a6961e212352ff

3 years agoComplete coverage of Parser::getTemplateDom()
Kunal Mehta [Mon, 28 May 2018 06:05:48 +0000 (23:05 -0700)]
Complete coverage of Parser::getTemplateDom()

This test covers the branch of code when the $mTplRedirCache is already
populated, by using the same template that redirects twice.

Change-Id: Ie0ce277c75366b7b060e0da6873175976621aff9

3 years agoMerge "Remove deprecated utfnormal back-compat"
jenkins-bot [Mon, 28 May 2018 03:50:48 +0000 (03:50 +0000)]
Merge "Remove deprecated utfnormal back-compat"

3 years agoMerge "Add 'Special:MyLanguage' in 'All skins' category link"
jenkins-bot [Mon, 28 May 2018 03:41:37 +0000 (03:41 +0000)]
Merge "Add 'Special:MyLanguage' in 'All skins' category link"

3 years agoRemove deprecated utfnormal back-compat
Kunal Mehta [Fri, 25 May 2018 18:47:32 +0000 (11:47 -0700)]
Remove deprecated utfnormal back-compat

Change-Id: Id8f497d0bbaab8282057c9d271a7c9b1e77d1a3f

3 years agoresourceloader: Add coverage for non-js error case in makeModuleResponse
Timo Tijhof [Mon, 28 May 2018 00:39:58 +0000 (01:39 +0100)]
resourceloader: Add coverage for non-js error case in makeModuleResponse

Adds coverage for line 1170-1175.

Change-Id: I2208264d3fca306b2740b243d7cdc209b224ebca

3 years agoMerge "Improve Parser::braceSubstitution() coverage"
jenkins-bot [Sun, 27 May 2018 23:26:33 +0000 (23:26 +0000)]
Merge "Improve Parser::braceSubstitution() coverage"

4 years agoMerge "Remove eslint-disable no-use-before-define"
jenkins-bot [Sun, 27 May 2018 20:47:17 +0000 (20:47 +0000)]
Merge "Remove eslint-disable no-use-before-define"

4 years agoMerge "Hooks: remove some unnecessary code"
jenkins-bot [Sun, 27 May 2018 20:28:23 +0000 (20:28 +0000)]
Merge "Hooks: remove some unnecessary code"

4 years agoMerge "Complete test coverage of Hooks class"
jenkins-bot [Sun, 27 May 2018 20:28:21 +0000 (20:28 +0000)]
Merge "Complete test coverage of Hooks class"

4 years agoRemove eslint-disable no-use-before-define
Fomafix [Sat, 26 May 2018 12:58:37 +0000 (14:58 +0200)]
Remove eslint-disable no-use-before-define

mediawiki.js: Reorder setGlobalMapValue() to avoid a forward reference.
mediawiki.action.edit.stash.js: Reorder two functions without to avoid
  forward references.

In all other cases add eslint-disable-next-line no-use-before-define.

Change-Id: Ic8b2f8cf61dcfb1a215ad3d3dddfd40282e3e836

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 27 May 2018 19:57:02 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5c895f4b61a73570671acf36c817cc405f54ec0b

4 years agoMerge "Improve AutoLoader test coverage"
jenkins-bot [Sun, 27 May 2018 19:50:45 +0000 (19:50 +0000)]
Merge "Improve AutoLoader test coverage"

4 years agoHooks: remove some unnecessary code
Kunal Mehta [Sun, 27 May 2018 06:39:07 +0000 (23:39 -0700)]
Hooks: remove some unnecessary code

PHP automatically creates the array when you try to append an item to
it. Really.

Change-Id: I73b1efe749a9311feeb0d14e1c76b5bbbc0265bd

4 years agoComplete test coverage of Hooks class
Kunal Mehta [Sun, 27 May 2018 06:38:28 +0000 (23:38 -0700)]
Complete test coverage of Hooks class

Change-Id: I9e720c44e6d6c9c5d726a8a147e07ee9b638913f

4 years agoImprove Parser::braceSubstitution() coverage
Kunal Mehta [Sun, 27 May 2018 05:57:55 +0000 (22:57 -0700)]
Improve Parser::braceSubstitution() coverage

Change-Id: I3d9426143fe486c6aed0494b68773a36e24c02d9

4 years agoImprove AutoLoader test coverage
Kunal Mehta [Sun, 27 May 2018 04:29:36 +0000 (21:29 -0700)]
Improve AutoLoader test coverage

Change-Id: Iddb24cad41979a4798392ab08d104dac41ed736d

4 years agoParser: Don't catch exception just to rethrow it
Kunal Mehta [Sun, 27 May 2018 01:14:51 +0000 (18:14 -0700)]
Parser: Don't catch exception just to rethrow it

This is left over from 4ff813680.

Change-Id: I624c2c22b7736af249647997565fe06f52d40fe2

4 years agoMerge "AutoLoaderStructureTest: Allow PSR-4 directories to have files with 0 classes"
jenkins-bot [Sun, 27 May 2018 00:13:13 +0000 (00:13 +0000)]
Merge "AutoLoaderStructureTest: Allow PSR-4 directories to have files with 0 classes"

4 years agoMerge "Rename ApiQueryContributions to ApiQueryUserContribs to match api module name"
jenkins-bot [Sat, 26 May 2018 23:57:30 +0000 (23:57 +0000)]
Merge "Rename ApiQueryContributions to ApiQueryUserContribs to match api module name"

4 years agoAutoLoaderStructureTest: Allow PSR-4 directories to have files with 0 classes
Kunal Mehta [Sat, 26 May 2018 23:51:56 +0000 (16:51 -0700)]
AutoLoaderStructureTest: Allow PSR-4 directories to have files with 0 classes

Files like ServiceWiring.php can be safely located in a PSR-4 autoloaded
directory, because they have no classes.

Change-Id: I359b305df9071d6bc5afe4b5f29e762041f4aaef

4 years agoSplit AutoloaderTest into a structure and class test
Kunal Mehta [Fri, 25 May 2018 05:13:22 +0000 (22:13 -0700)]
Split AutoloaderTest into a structure and class test

AutoloaderTest covers the AutoLoader class, and AutoLoaderStructureTest
covers the structure part of the test.

Change-Id: Ic4e7bfd670e1c3413631bda31260cc1cc825b1a2

4 years agoMerge "Increase cleanupTitles.php batch size"
jenkins-bot [Sat, 26 May 2018 23:09:05 +0000 (23:09 +0000)]
Merge "Increase cleanupTitles.php batch size"

4 years agoRename ApiQueryContributions to ApiQueryUserContribs to match api module name
Reedy [Fri, 25 May 2018 00:46:30 +0000 (01:46 +0100)]
Rename ApiQueryContributions to ApiQueryUserContribs to match api module name

Change-Id: I865628b87eda7be349522fcfaf94f5563142026e

4 years agoMerge "Hard deprecate UtfNormal methods"
jenkins-bot [Sat, 26 May 2018 23:06:25 +0000 (23:06 +0000)]
Merge "Hard deprecate UtfNormal methods"

4 years agoMerge "Switch includes/{sparql,Storage,tidy} to use the PSR-4 autoloader"
jenkins-bot [Sat, 26 May 2018 22:54:11 +0000 (22:54 +0000)]
Merge "Switch includes/{sparql,Storage,tidy} to use the PSR-4 autoloader"

4 years agoMerge "Switch includes/{preferences,services,session,shell} to use the PSR-4 autoloader"
jenkins-bot [Sat, 26 May 2018 22:40:47 +0000 (22:40 +0000)]
Merge "Switch includes/{preferences,services,session,shell} to use the PSR-4 autoloader"

4 years agoMerge "Add structure test to ensure PSR-4 autoloader covers everything"
jenkins-bot [Sat, 26 May 2018 22:40:44 +0000 (22:40 +0000)]
Merge "Add structure test to ensure PSR-4 autoloader covers everything"

4 years agoHard deprecate UtfNormal methods
Kunal Mehta [Fri, 25 May 2018 18:16:16 +0000 (11:16 -0700)]
Hard deprecate UtfNormal methods

Change-Id: Iafbf89aa85ae77cd790aeac6911ccc2d014a6c65

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 26 May 2018 21:03:33 +0000 (23:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4500053ecbb780a723d5f2398a3d1693a9d12d31

4 years agoAdd 'Special:MyLanguage' in 'All skins' category link
Suriyaa Kudo [Sat, 26 May 2018 14:02:10 +0000 (16:02 +0200)]
Add 'Special:MyLanguage' in 'All skins' category link

Change-Id: I5f9f6c3c9151ea1570d0ec3f361af40fba8abd20

4 years agoAvoid PHP 7.2 warnings in DBConRefTest about count() on non-Countable
Aaron Schulz [Sat, 26 May 2018 00:29:17 +0000 (17:29 -0700)]
Avoid PHP 7.2 warnings in DBConRefTest about count() on non-Countable

Change-Id: Ida81bf998b462f2f6bb2b708df1f15bbc1933db1

4 years agoIncrease cleanupTitles.php batch size
Reedy [Sat, 26 May 2018 00:25:03 +0000 (00:25 +0000)]
Increase cleanupTitles.php batch size

Change-Id: I086892e44936fdaf9d5d1f3667325daaaaa7260e

4 years agoMerge "languages: Use static array files for normalizer data"
jenkins-bot [Fri, 25 May 2018 23:03:18 +0000 (23:03 +0000)]
Merge "languages: Use static array files for normalizer data"

4 years agoMerge "MediaWiki\Auth\Throttler: Change "ip" key name"
jenkins-bot [Fri, 25 May 2018 22:38:39 +0000 (22:38 +0000)]
Merge "MediaWiki\Auth\Throttler: Change "ip" key name"

4 years agoMediaWiki\Auth\Throttler: Change "ip" key name
Brad Jorsch [Fri, 25 May 2018 18:50:55 +0000 (14:50 -0400)]
MediaWiki\Auth\Throttler: Change "ip" key name

Apparently 'ip' is overwritten by logstash at some level, so use 'ipKey'
instead.

Change-Id: I0547acdbb9f3fc7a990bd4baa2d748e89bac8c3b

4 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Fri, 25 May 2018 19:54:18 +0000 (19:54 +0000)]
Merge "Localisation updates from https://translatewiki.net."

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 25 May 2018 19:54:09 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I1bb2563f7ebba3c66062b79bd523c3f226b54cb9

4 years agoMerge "Enable merging of WrappedStringList between 'bottomscripts' and 'reportime'"
jenkins-bot [Fri, 25 May 2018 19:52:13 +0000 (19:52 +0000)]
Merge "Enable merging of WrappedStringList between 'bottomscripts' and 'reportime'"

4 years agoRemove non namespaced TimestampException
Reedy [Fri, 25 May 2018 12:08:24 +0000 (13:08 +0100)]
Remove non namespaced TimestampException

Change-Id: I6d5cc227cacc6a24e92002e589e439a3bbd033a7

4 years agoMerge "Move includes/auth back to the standard classmap autoloader"
jenkins-bot [Fri, 25 May 2018 02:23:00 +0000 (02:23 +0000)]
Merge "Move includes/auth back to the standard classmap autoloader"

4 years agoSwitch includes/{sparql,Storage,tidy} to use the PSR-4 autoloader
Kunal Mehta [Thu, 24 May 2018 02:31:33 +0000 (19:31 -0700)]
Switch includes/{sparql,Storage,tidy} to use the PSR-4 autoloader

Change-Id: I1ae3cb3833a28286eb4ae09b586785d156917e8e

4 years agoSwitch includes/{preferences,services,session,shell} to use the PSR-4 autoloader
Kunal Mehta [Thu, 24 May 2018 02:28:33 +0000 (19:28 -0700)]
Switch includes/{preferences,services,session,shell} to use the PSR-4 autoloader

Change-Id: Ic095ed65d05517cdb7b383cde8c664044f790f05

4 years agoAdd structure test to ensure PSR-4 autoloader covers everything
Kunal Mehta [Fri, 25 May 2018 01:55:47 +0000 (18:55 -0700)]
Add structure test to ensure PSR-4 autoloader covers everything

This ensures that there aren't any classes inside a PSR-4 autoloaded
directory that aren't being autoloaded properly.

Change-Id: I200a8535c2f47a6bf3287a7fe1182151493372f4

4 years agoMove includes/auth back to the standard classmap autoloader
Kunal Mehta [Fri, 25 May 2018 01:57:28 +0000 (18:57 -0700)]
Move includes/auth back to the standard classmap autoloader

Partially reverts c587ab1375eaf61acbd3e066ff791d096e769189.

Change-Id: Ie8cfe356b07f08d481370b9f61b1d08ed6c9c799

4 years agoMerge "Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy'"
jenkins-bot [Fri, 25 May 2018 00:56:01 +0000 (00:56 +0000)]
Merge "Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy'"

4 years agoFollow-up If8dfdaf1: Hard-deprecate, drop two uses, other pre-5.3 back-compat code
James D. Forrester [Fri, 25 May 2018 00:01:02 +0000 (17:01 -0700)]
Follow-up If8dfdaf1: Hard-deprecate, drop two uses, other pre-5.3 back-compat code

Change-Id: I1c5eee3fe30d6687d88e07011a3d40b6770d0daf

4 years agoMerge "EditPage: Fix duplicate classic toolbar"
jenkins-bot [Thu, 24 May 2018 23:08:23 +0000 (23:08 +0000)]
Merge "EditPage: Fix duplicate classic toolbar"

4 years agoEditPage: Fix duplicate classic toolbar
Bartosz Dziewoński [Thu, 24 May 2018 22:54:14 +0000 (00:54 +0200)]
EditPage: Fix duplicate classic toolbar

Caused by an incorrectly resolved rebase conflict
between 14cffee7c1ea7e6f411730a52aadb2458fcfb0fd
and 70941efd35562dcb7003229b56c91a98a67de7a9.

Bug: T195517
Change-Id: I294acff48fe9b1a1a9384d717f09d90e417204ab

4 years agoInsert space before compatibility link in PHP version message
petarpetkovic [Thu, 24 May 2018 22:27:21 +0000 (00:27 +0200)]
Insert space before compatibility link in PHP version message

Change-Id: Ia056ba7f9eddbcf31082c7b2f7a64e7dbf02cba4

4 years agoMerge "Add unicode mapping for ICU 60 and 61"
jenkins-bot [Thu, 24 May 2018 21:46:32 +0000 (21:46 +0000)]
Merge "Add unicode mapping for ICU 60 and 61"

4 years agoAdd unicode mapping for ICU 60 and 61
Reedy [Thu, 24 May 2018 21:28:19 +0000 (22:28 +0100)]
Add unicode mapping for ICU 60 and 61

Change-Id: Ifbbc8d7ecc788bc2c6b07a8ebba46a9648545786

4 years agoIcuCollation: Deprecate getICUVersion(), no need for PHP53 back-compat
James D. Forrester [Thu, 24 May 2018 20:11:11 +0000 (13:11 -0700)]
IcuCollation: Deprecate getICUVersion(), no need for PHP53 back-compat

Change-Id: If8dfdaf187b32b7b9a2c09a240416b9f481593f1

4 years agoRestore 'PreferencesForm' as alias for 'PreferencesFormLegacy'
Bartosz Dziewoński [Wed, 9 May 2018 20:39:20 +0000 (22:39 +0200)]
Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy'

In change 4633f4d46a8db46721474e9ffa6a130d8b7a2404 it was changed
to an interface implemented by both PreferencesFormLegacy and
PreferencesFormOOUI so that existing typehints for some functions
parameter would accept them both. Replace those typehints to use
HTMLForm instead. There was really no guarantee in the past that
they would only be given PreferencesForm or its subclasses, either.

Because the typehint change affects some hooks, note it as a
deprecation in MW 1.31 and a breaking change in MW 1.32.

Also add @since tags and correct some typos in code comments.

Follow-up to 4633f4d46a8db46721474e9ffa6a130d8b7a2404.

Change-Id: I61749f1d864cf68afe90cd9e15ba2d7a74252501

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 24 May 2018 19:53:30 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie807be662d077fe0e177e82834d70581210a5f3e

4 years agoMerge "mw.page.gallery: Prevent jumpiness due to viewport height changes"
jenkins-bot [Thu, 24 May 2018 19:17:44 +0000 (19:17 +0000)]
Merge "mw.page.gallery: Prevent jumpiness due to viewport height changes"

4 years agomw.page.gallery: Prevent jumpiness due to viewport height changes
Bartosz Dziewoński [Tue, 8 May 2018 19:12:00 +0000 (21:12 +0200)]
mw.page.gallery: Prevent jumpiness due to viewport height changes

* Do not recalculate if only viewport height has changed, but not
  width. Viewport height doesn't affect this at all.
* Set a min-height on the gallery element before resetting image
  dimensions so that content following it only reflows once, when
  we calculate dimensions again.

Bug: T194193
Change-Id: I6362863cc0f3f7b76c9ec7437d37ff6762ecf153

4 years agoMerge "Switch includes/{auth,edit,editpage} to use the PSR-4 autoloader"
jenkins-bot [Thu, 24 May 2018 17:00:16 +0000 (17:00 +0000)]
Merge "Switch includes/{auth,edit,editpage} to use the PSR-4 autoloader"

4 years agoMerge "Re-enable MediaWiki.Files.ClassMatchesFilename sniffs"
jenkins-bot [Thu, 24 May 2018 17:00:13 +0000 (17:00 +0000)]
Merge "Re-enable MediaWiki.Files.ClassMatchesFilename sniffs"

4 years agoMerge "Have class match filename in some maintenance scripts"
jenkins-bot [Thu, 24 May 2018 16:49:18 +0000 (16:49 +0000)]
Merge "Have class match filename in some maintenance scripts"

4 years agoBump PHP version requirement to 7.0.0+
James D. Forrester [Thu, 18 Jan 2018 23:34:32 +0000 (15:34 -0800)]
Bump PHP version requirement to 7.0.0+

Bug: T172165
Change-Id: I740f32ac859d9bb3787fdf8414f82ae6f410492f

4 years agoDrop $wgStyleVersion, deprecated in 1.31 and now unused
James D. Forrester [Wed, 23 May 2018 22:00:46 +0000 (15:00 -0700)]
Drop $wgStyleVersion, deprecated in 1.31 and now unused

Bug: T181318
Change-Id: Ib988f3118786debda135d6ad3d27deda5a51fc8a

4 years agoMerge "Skin: Drop appending of wgStyleVersion in getSkinStylePath()"
jenkins-bot [Thu, 24 May 2018 14:05:28 +0000 (14:05 +0000)]
Merge "Skin: Drop appending of wgStyleVersion in getSkinStylePath()"

4 years agoEnable merging of WrappedStringList between 'bottomscripts' and 'reportime'
Timo Tijhof [Thu, 24 May 2018 13:10:48 +0000 (14:10 +0100)]
Enable merging of WrappedStringList between 'bottomscripts' and 'reportime'

* Fix ResourceLoaderClientHtml to return what it was documented to
  return, a WrappedStringList. It accidentally used the wrong join()
  method, causing it to create a plain string too early.

* Update method documentations from ClientHtml::getBodyHtml to
  BaseTemplate::getTrail for 'bottomscripts', and from
  ResourceLoader::makeInlineScript for 'reporttime'.

* Update BaseTemplate::getTrail to join by new line instead of native string
  concatenation.

This by itself would suffice for the most common case, but in order
to also account for the possibility of extensions using hooks for
'SkinAfterBottomScripts' that concatenate, update bottomScripts()
to pass a plain string to the hook and merge it later.

Change-Id: If0d227cb9db67229a27d489c082db790ea8e3840

4 years agoMerge "resourceloader: Move style deprecation warnings to <body>"
jenkins-bot [Thu, 24 May 2018 13:03:21 +0000 (13:03 +0000)]
Merge "resourceloader: Move style deprecation warnings to <body>"

4 years agoRemove mentions of jquery.mw-jump in code comments
Timo Tijhof [Thu, 24 May 2018 12:35:50 +0000 (13:35 +0100)]
Remove mentions of jquery.mw-jump in code comments

The idea of listening for an event and doing something, with on('focus'),
is rather trivial and not worth attributing to another module, in particular
when that module is being phased out :)

Bug: T195256
Change-Id: Ic6a65254cbcc5e9503fece1afb7861a706713d77

4 years agoMerge "Add ability to filter based on rc_title in API"
jenkins-bot [Thu, 24 May 2018 10:13:06 +0000 (10:13 +0000)]
Merge "Add ability to filter based on rc_title in API"

4 years agoSwitch includes/{auth,edit,editpage} to use the PSR-4 autoloader
Kunal Mehta [Thu, 24 May 2018 01:24:05 +0000 (18:24 -0700)]
Switch includes/{auth,edit,editpage} to use the PSR-4 autoloader

Change-Id: I9210d26c1031d69f6691fef038cc2db6f391b70e

4 years agoRe-enable MediaWiki.Files.ClassMatchesFilename sniffs
Kunal Mehta [Thu, 24 May 2018 02:23:49 +0000 (19:23 -0700)]
Re-enable MediaWiki.Files.ClassMatchesFilename sniffs

Change-Id: I63f54b0336168a50aef72e38202e153677eafd3c

4 years agoHave class match filename in some maintenance scripts
Kunal Mehta [Thu, 24 May 2018 01:34:01 +0000 (18:34 -0700)]
Have class match filename in some maintenance scripts

Each of these scripts had a class name that was not referenced outside
of the script file itself, and are safe to rename as a result.

Change-Id: Id605aca11db51ee433baeaa998a0e33184c930ca

4 years agoMerge "Update wikimedia/wrappedstring to v3.0.0"
jenkins-bot [Thu, 24 May 2018 02:14:00 +0000 (02:14 +0000)]
Merge "Update wikimedia/wrappedstring to v3.0.0"

4 years agoMerge "IP: Fix sanitization of IPv4 ranges"
jenkins-bot [Thu, 24 May 2018 00:31:31 +0000 (00:31 +0000)]
Merge "IP: Fix sanitization of IPv4 ranges"

4 years agoMerge "Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors"
jenkins-bot [Thu, 24 May 2018 00:27:01 +0000 (00:27 +0000)]
Merge "Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors"

4 years agoMerge "RELEASE-NOTES-1.32: Line wrap to 80 chars"
jenkins-bot [Thu, 24 May 2018 00:08:04 +0000 (00:08 +0000)]
Merge "RELEASE-NOTES-1.32: Line wrap to 80 chars"

4 years agoSkin: Drop appending of wgStyleVersion in getSkinStylePath()
James D. Forrester [Wed, 23 May 2018 21:56:13 +0000 (14:56 -0700)]
Skin: Drop appending of wgStyleVersion in getSkinStylePath()

This setting is deprecated.

Bug: T181318
Change-Id: I9e56764e37b5f10ce1bddfb7826c18982fb1ebb2

4 years agoMerge "Enable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well"
jenkins-bot [Wed, 23 May 2018 23:48:44 +0000 (23:48 +0000)]
Merge "Enable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well"

4 years agoRELEASE-NOTES-1.32: Line wrap to 80 chars
James D. Forrester [Wed, 23 May 2018 21:59:52 +0000 (14:59 -0700)]
RELEASE-NOTES-1.32: Line wrap to 80 chars

Change-Id: I673efe2777da17bd44788ee8a11707e040242176

4 years agoFix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors
Kunal Mehta [Wed, 23 May 2018 23:23:42 +0000 (16:23 -0700)]
Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag errors

Change-Id: I936c3f5fca1a0061f215e80469f5d882cb32ee29

4 years agoEnable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well
Amir Sarabadani [Fri, 18 May 2018 13:46:47 +0000 (15:46 +0200)]
Enable deleteAutoPatrolLogs to delete pre-2011 autopatrol logs as well

Bug: T184485
Change-Id: I3f123ea0ae69f80beec7425be0f3e4c00a409c0d

4 years agoUpdate wikimedia/wrappedstring to v3.0.0
Timo Tijhof [Wed, 23 May 2018 22:00:45 +0000 (23:00 +0100)]
Update wikimedia/wrappedstring to v3.0.0

Notable changes:
- Remove back compat layer for WrappedString\ -> Wikimedia\.
- Improve merging of nested lists.

Depends-On: I89c015e638fe3e77ef12b88948d3cfa007afa7b0
Change-Id: I10cc2ed66e1d78a77fec7ffeafc75962f7d73090

4 years agobuild: Updating mediawiki/mediawiki-codesniffer to 18.0.0
libraryupgrader [Sat, 14 Apr 2018 10:27:27 +0000 (10:27 +0000)]
build: Updating mediawiki/mediawiki-codesniffer to 18.0.0

Change-Id: Id39e8dcf22262d1b3c57628467163a995fe4053b

4 years agoMerge "WatchAction::onSubmit return correct value, not always true"
jenkins-bot [Wed, 23 May 2018 21:48:14 +0000 (21:48 +0000)]
Merge "WatchAction::onSubmit return correct value, not always true"

4 years agoMerge "Setup: Remove various Profile sections"
jenkins-bot [Wed, 23 May 2018 21:39:39 +0000 (21:39 +0000)]
Merge "Setup: Remove various Profile sections"

4 years agoMerge "Update 'OpenSearchDescription' links"
jenkins-bot [Wed, 23 May 2018 21:38:28 +0000 (21:38 +0000)]
Merge "Update 'OpenSearchDescription' links"

4 years agoMerge "Add 'Special:MyLanguage' in Short URL link"
jenkins-bot [Wed, 23 May 2018 21:36:01 +0000 (21:36 +0000)]
Merge "Add 'Special:MyLanguage' in Short URL link"

4 years agoMerge "OutputPage: Remove appending of wgStyleVersion to legacy resources"
jenkins-bot [Wed, 23 May 2018 21:34:07 +0000 (21:34 +0000)]
Merge "OutputPage: Remove appending of wgStyleVersion to legacy resources"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 23 May 2018 20:00:37 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I12af86ca297eae5af2e7c74fce0d198e6c473827

4 years agoOutputPage: Remove appending of wgStyleVersion to legacy resources
Timo Tijhof [Mon, 21 May 2018 21:21:28 +0000 (22:21 +0100)]
OutputPage: Remove appending of wgStyleVersion to legacy resources

For addScriptFile(), just remove the appending of wgStyleVersion.
Going forward, anyone still using this, should simply append a query
parameter themselves in a way that is specific to that one url
(instead of relying on a generic global variable). Alternatively, one
could use OutputPage::transformResourcePath if the file is in /w/.

For addStyles(), also remove the appending of wgStyleVersion. Since this
method takes paths relative to /w/skins, we can easily update this to
automatically use transformResourcePath(), so that file-hash based query
parameters are automatically added.

Test Plan:
* Add calls to top of OutputPage::output():
  `$this->addStyle( 'Vector/README.md' );`
  `$this->addScriptFile( "{$GLOBALS['wgScriptPath']}/composer.json" );`
* Before, they are both inserted as `<link>` (head) and `<script>` (body)
  with a query parameter based on wgStyleVersion.
* After, the `<script>` (end of body) has no query.
  After, the stylesheet (head) has a SHA1 content hash as query.

Bug: T181318
Change-Id: Ie5ab5066ef7d07279086bde838d7305e9e4eabaf

4 years agoWatchAction::onSubmit return correct value, not always true
Florian Schmidt [Fri, 18 May 2018 20:08:09 +0000 (22:08 +0200)]
WatchAction::onSubmit return correct value, not always true

The onSubmit method documentation states, that the caller can expect either
true for a successfull run, false if not tried and an array of error messages
in case of an failure. WatchAction however always returned false, even though
a Status object is availble with all needed information.

The behaviour of WatchAction::onSubmit is now changed to return the appropriate
value taken from the returned Status object of WatchAction::doSelf.

Also:
 * Added WatchAction test class to higher test coverage, especially for the
   static methods
 * Marked getUnwatchToken as deprecated, it's not used and a caller can easily
   switch to getWatchToken with "unwatch" as the action parameter

Change-Id: I2c1b91e1884a0d5f27f5e7ab9eafd6173642c21c

4 years agoMerge "Translate ApiHelp, ApiSandbox and Autoblocklist to Spanish"
jenkins-bot [Wed, 23 May 2018 18:15:40 +0000 (18:15 +0000)]
Merge "Translate ApiHelp, ApiSandbox and Autoblocklist to Spanish"

4 years agoMerge "resourceloader: Remove 'user.styles' dependency from 'user' module"
jenkins-bot [Wed, 23 May 2018 18:04:39 +0000 (18:04 +0000)]
Merge "resourceloader: Remove 'user.styles' dependency from 'user' module"

4 years agoMerge "OutputPage: Remove support for non-existent /w/skins/common directory"
jenkins-bot [Wed, 23 May 2018 18:01:11 +0000 (18:01 +0000)]
Merge "OutputPage: Remove support for non-existent /w/skins/common directory"

4 years agoMerge "Remove the unused 'jquery.farbtastic' module"
jenkins-bot [Wed, 23 May 2018 17:41:24 +0000 (17:41 +0000)]
Merge "Remove the unused 'jquery.farbtastic' module"

4 years agoMerge "Convert content.externallinks.css to less"
jenkins-bot [Wed, 23 May 2018 17:01:55 +0000 (17:01 +0000)]
Merge "Convert content.externallinks.css to less"

4 years agoRemove the unused 'jquery.farbtastic' module
Timo Tijhof [Wed, 23 May 2018 16:28:23 +0000 (17:28 +0100)]
Remove the unused 'jquery.farbtastic' module

This was added in (r99923; 4d8c7e96ed1f) while reviewing the
'gadget-preferences' branch in SVN of the Gadgets extension during
development of MediaWiki 1.18, intended for use in a color picker
on Special:Gadgets as part of an experimental feature that was
never completed (r94051).

The module has no usage anywhere in Wikimedia Git, nor in any
third-party hosted repos indexed by MediaWiki Codesearch, nor
anywhere on-wiki at WMF in site scripts (per mwgrep).

Bug: T193826
Bug: T192623
Change-Id: I8ed6c09dc7efd750ad4688b895b2e3f808a0e52b

4 years agoMerge "resourceloader: Remove mwLoadEnd code (moved to Navigation Timing)"
jenkins-bot [Wed, 23 May 2018 16:03:49 +0000 (16:03 +0000)]
Merge "resourceloader: Remove mwLoadEnd code (moved to Navigation Timing)"

4 years agoMerge "Translate special pages into Gorontalo"
jenkins-bot [Wed, 23 May 2018 15:58:38 +0000 (15:58 +0000)]
Merge "Translate special pages into Gorontalo"

4 years agoMerge "Crimean Tatar/crh transliteration odds and ends"
jenkins-bot [Wed, 23 May 2018 15:58:33 +0000 (15:58 +0000)]
Merge "Crimean Tatar/crh transliteration odds and ends"

4 years agoTranslate special pages into Gorontalo
Martin Urbanec [Wed, 25 Apr 2018 13:05:14 +0000 (15:05 +0200)]
Translate special pages into Gorontalo

Bug: T189128
Change-Id: Icb3685f4115c63fb5b50ce5429f564481d2cdfd6

4 years agoTranslate ApiHelp, ApiSandbox and Autoblocklist to Spanish
MarcoAurelio [Wed, 23 May 2018 15:07:31 +0000 (15:07 +0000)]
Translate ApiHelp, ApiSandbox and Autoblocklist to Spanish

Change-Id: Ie8cab864112cde17a5f5ced7645fff25c558abdf