lhc/web/wiklou.git
6 years agoMerge "SpecialProtectedpages: Remove options not used by HTMLForm"
jenkins-bot [Fri, 12 Jan 2018 21:35:33 +0000 (21:35 +0000)]
Merge "SpecialProtectedpages: Remove options not used by HTMLForm"

6 years agoPerformance: Shortcut Language::truncate if there's no need to truncate
Jesús Martínez Novo [Sat, 17 Jun 2017 11:56:14 +0000 (13:56 +0200)]
Performance: Shortcut Language::truncate if there's no need to truncate

Return the unmodified string if there's no need to truncate it without
doing a not-so-trivial round of getting a message from the message
cache.

Change-Id: I11ac88672aeb9d1c4f5709b79ad2d17223bd64d8

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 12 Jan 2018 21:00:07 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iaceffb9f545a39a60a00d3e219abb5ff8fda8087

6 years agoMerge "CSSMin: Remove XML declaration from SVGs"
jenkins-bot [Fri, 12 Jan 2018 20:19:11 +0000 (20:19 +0000)]
Merge "CSSMin: Remove XML declaration from SVGs"

6 years agoMerge "Use native ES5 Array prototype methods instead of jQuery"
jenkins-bot [Fri, 12 Jan 2018 20:15:41 +0000 (20:15 +0000)]
Merge "Use native ES5 Array prototype methods instead of jQuery"

6 years agoMerge "config: Increase coverage of EtcdConfig::parseDirectory()"
jenkins-bot [Fri, 12 Jan 2018 20:13:28 +0000 (20:13 +0000)]
Merge "config: Increase coverage of EtcdConfig::parseDirectory()"

6 years agoconfig: Increase coverage of EtcdConfig::parseDirectory()
Timo Tijhof [Fri, 12 Jan 2018 19:25:58 +0000 (19:25 +0000)]
config: Increase coverage of EtcdConfig::parseDirectory()

One of the error cases wasn't covered yet.

Change-Id: I762b37c7448c0f689248a99bad0b206d7cf63d73

6 years agoUse cache set options in SqlBlobStore::getBlob
Aaron Schulz [Mon, 18 Dec 2017 20:35:52 +0000 (12:35 -0800)]
Use cache set options in SqlBlobStore::getBlob

This is useful for sanity in the case of DB rollback.

Change-Id: I2e50183835a97bc82efee53a407a624f0e35f53f

6 years agoRemove various redundant '@license' tags in file headers
Timo Tijhof [Mon, 4 Dec 2017 19:25:31 +0000 (19:25 +0000)]
Remove various redundant '@license' tags in file headers

Redundant given this is the project-wide license already,
especially in file headers that already include the GPL license
header.

This and other minor fixups based on feedback from Ie0cea0ef5027c7e5.

* Add @file where missing.
* Move @ingroup and @deprecated from file to class doc where needed.

Change-Id: I7067abb7abee1f0c238cb2536e16192e946d8daa

6 years agoMerge "Replace cpPosTime cookie/parameter with cpPosIndex"
jenkins-bot [Fri, 12 Jan 2018 18:08:59 +0000 (18:08 +0000)]
Merge "Replace cpPosTime cookie/parameter with cpPosIndex"

6 years agoUse native ES5 Array prototype methods instead of jQuery
Fomafix [Fri, 12 Jan 2018 15:47:40 +0000 (16:47 +0100)]
Use native ES5 Array prototype methods instead of jQuery

Replace
* $.each( array, function ( index, value ) { ... } ) by
  array.forEach( function ( value, index ) { ... } )

* $.grep( array, function ( value ) { ... } ) by
  array.filter( function ( value ) { ... } )

* $.map( array, function ( value ) { ... } ) by
  array.map( function ( value ) { ... } )

* $.inArray( value, array ) by
  array.indexOf( value )

This change is a follow-up to 1edba8029a561919febf8b90f5df689d090665dd.

Change-Id: I16134642c52002de0eacb987bed5143f528bf627

6 years agoOOUI: Manually pull in fix from I99caad7b ahead of the release cycle
James D. Forrester [Fri, 12 Jan 2018 16:56:02 +0000 (08:56 -0800)]
OOUI: Manually pull in fix from I99caad7b ahead of the release cycle

The .map file will be wrong, but those aren't used outside of an
experimental branch yet, so it's not the end of the world.

Bug: T184665
Change-Id: I9ff1ed80496ec61b836de4221dd36cde6d4a71ac

6 years agoMerge "List new comment tables in ParserTestRunner"
jenkins-bot [Fri, 12 Jan 2018 15:43:14 +0000 (15:43 +0000)]
Merge "List new comment tables in ParserTestRunner"

6 years agoApiSandbox: Use OO.ui.getDefaultOverlay()
Brad Jorsch [Fri, 12 Jan 2018 15:18:41 +0000 (10:18 -0500)]
ApiSandbox: Use OO.ui.getDefaultOverlay()

Mostly via the shortcut of passing true to the '$overlay' parameter.

Also use it instead of <body> as the container for fullscreen mode, so
we don't have to worry about different z indexes to not go over the
default overlay in different skins.

And rename our OptionalWidget's "$overlay" parameter to "$cover" since
it's not an overlay in the sense that OOUI uses that term.

Bug: T184790
Change-Id: Ia65400f4c8c5e0f44cdb30e09c854fa38590e39d

6 years agoMerge "Add tests for legacy encoding when constructing RevisionRecords"
jenkins-bot [Fri, 12 Jan 2018 15:17:33 +0000 (15:17 +0000)]
Merge "Add tests for legacy encoding when constructing RevisionRecords"

6 years agoMerge "RevisionStore, fix loadSlotContent with no $blobFlags"
jenkins-bot [Fri, 12 Jan 2018 15:07:01 +0000 (15:07 +0000)]
Merge "RevisionStore, fix loadSlotContent with no $blobFlags"

6 years agoAdd tests for legacy encoding when constructing RevisionRecords
daniel [Fri, 12 Jan 2018 14:40:47 +0000 (15:40 +0100)]
Add tests for legacy encoding when constructing RevisionRecords

Change-Id: I49265a394b0780a48fecbf037477d2bb39195e89

6 years agoRevisionStore, fix loadSlotContent with no $blobFlags
addshore [Fri, 12 Jan 2018 11:52:31 +0000 (11:52 +0000)]
RevisionStore, fix loadSlotContent with no $blobFlags

This includes tests that were previously created in:
I6dcfc0497bfce6605fa5517c9f91faf7131f4334

Bug: T184749
Change-Id: Ieb02ac593fc6b42af1692d03d9d578a76417eb54

6 years agoCSSMin: Remove XML declaration from SVGs
Volker E [Tue, 9 Jan 2018 03:05:40 +0000 (19:05 -0800)]
CSSMin: Remove XML declaration from SVGs

Removing unnecessary XML declaration prolog when embedding SVGs
as data URI and adding more complex elements & attributes to test.

Bug: T175318
Change-Id: Ibec8c2ab498554a6ad33b4420ae6258dcc80fcdf

6 years agoMerge "Remove @param comments that literally repeat what the code says"
jenkins-bot [Thu, 11 Jan 2018 23:48:03 +0000 (23:48 +0000)]
Merge "Remove @param comments that literally repeat what the code says"

6 years agoJavaScriptMinifier: Remove support for unused $maxLineLength param
Timo Tijhof [Thu, 11 Jan 2018 22:59:47 +0000 (22:59 +0000)]
JavaScriptMinifier: Remove support for unused $maxLineLength param

Follows-up 93b8023946b0e.

The $wgResourceLoaderMinifierMaxLineLength config var was deprecated
in MediaWiki 1.27. The parameter of minify() was not used by other
code, and no new usage has been introduced since then, either.

Remove the feature from JavaScriptMinifier, and add a release note.
The 1.31 release notes already contain a note about the removal
of the configuration variables.

The feature was not covered by unit tests.

Change-Id: I38eb4187e3a8e2d882f317481b43f0bf6ac3bada

6 years agoList new comment tables in ParserTestRunner
Umherirrender [Thu, 11 Jan 2018 22:51:56 +0000 (23:51 +0100)]
List new comment tables in ParserTestRunner

Running the parser tests while in the migration,
some tables are missing.

Bug: T182416
Change-Id: I1010f4a35e5bf4626e522629447e43c413a05668

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 11 Jan 2018 22:25:29 +0000 (23:25 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I3cdb9fd7efb494da8dce2f4dd4f0d1c829f374ee

6 years agoJavaScriptMinifier: Enable phpcs and fix violations
Timo Tijhof [Thu, 11 Jan 2018 22:21:53 +0000 (22:21 +0000)]
JavaScriptMinifier: Enable phpcs and fix violations

Found 90 violations. 88 fixed by phpxbf. 2 remaining violations
were Generic.Files.LineLength.TooLong (fixed manually).

Change-Id: I760acc5b249fe6f4863652de7b563eaa5f13f05f

6 years agoMerge "Use native ES5 Array prototype methods instead of jQuery"
jenkins-bot [Thu, 11 Jan 2018 21:43:08 +0000 (21:43 +0000)]
Merge "Use native ES5 Array prototype methods instead of jQuery"

6 years agoUse native ES5 Array prototype methods instead of jQuery
Fomafix [Thu, 11 Jan 2018 14:27:08 +0000 (15:27 +0100)]
Use native ES5 Array prototype methods instead of jQuery

Replace
* $.each( array, function ( index, value ) { ... } ) by
  array.forEach( function ( value, index ) { ... } )

* $.grep( array, function ( value ) { ... } ) by
  array.filter( function ( value ) { ... } )

* $.map( array, function ( value ) { ... } ) by
  array.map( function ( value ) { ... } )

This change is a follow-up to 9d67e9973e6766e057c70ea8c811be8e269fb80a.

Change-Id: I8ef9af8c4d2f440faca65ec7c78a977ea7c31ad2

6 years agoJavaScriptMinifier: Fix "Uninitialized offset" in string and regexp parsing
Timo Tijhof [Wed, 10 Jan 2018 02:02:27 +0000 (02:02 +0000)]
JavaScriptMinifier: Fix "Uninitialized offset" in string and regexp parsing

When parsing an incomplete string literal or regex literal at the end of a file,
$end would be set to an offset higher than $length, because the code
speculatively increases $end without correcting for this scenario.

This is due to the assumption that the strcspn() search will end because
an end character was seen, instead of simply ending because the string
doesn't have any further characters.

Bug: T75556
Change-Id: I2325c9aff33293c13ff414699c2d47306182aaa6

6 years agoJavaScriptMinifier: Improve docs for parsing of string literals
Timo Tijhof [Wed, 10 Jan 2018 01:14:40 +0000 (01:14 +0000)]
JavaScriptMinifier: Improve docs for parsing of string literals

Also update docs for parsing of regexp literals to match.

Bug: T75556
Change-Id: I86c79b1b1866339d65d1c69e56d457c62544aaac

6 years agoMerge "RevisionStore tests for current behaviour of getTitle"
jenkins-bot [Thu, 11 Jan 2018 17:24:38 +0000 (17:24 +0000)]
Merge "RevisionStore tests for current behaviour of getTitle"

6 years agoRevisionStore tests for current behaviour of getTitle
addshore [Thu, 11 Jan 2018 16:56:29 +0000 (16:56 +0000)]
RevisionStore tests for current behaviour of getTitle

Change-Id: I6e345b10abb81f6eae94ab9475563f690aaee012

6 years agoImprove PARAM_HELP_MSG_PER_VALUE documentation
Lucas Werkmeister [Thu, 11 Jan 2018 17:02:04 +0000 (18:02 +0100)]
Improve PARAM_HELP_MSG_PER_VALUE documentation

Per-value documentation is only generated if this option is specified,
even if it is only set to an empty array (i. e., when using the default
key for all values). Attempt to make this more clear.

Change-Id: I844df226271aadb1f06b3cc00ba32cc6c06ec76a

6 years agoMerge "Make Revision::__construct work with bad page ID"
jenkins-bot [Thu, 11 Jan 2018 16:33:34 +0000 (16:33 +0000)]
Merge "Make Revision::__construct work with bad page ID"

6 years agoMake Revision::__construct work with bad page ID
daniel [Thu, 11 Jan 2018 15:43:18 +0000 (16:43 +0100)]
Make Revision::__construct work with bad page ID

For backwards-copatibility, we need to be able to construct a Revision
object even for bad page IDs.

Bug: T184689
Change-Id: I18c823d7b72504447982364d581b34e98924b67f

6 years agoMerge "Handle failure to load content in Revision getSize, etc"
jenkins-bot [Thu, 11 Jan 2018 14:50:00 +0000 (14:50 +0000)]
Merge "Handle failure to load content in Revision getSize, etc"

6 years agoMerge "Add test for newNullRevision with bad page ID"
jenkins-bot [Thu, 11 Jan 2018 14:27:23 +0000 (14:27 +0000)]
Merge "Add test for newNullRevision with bad page ID"

6 years agoMerge "Revision::newNullRevision don't pass null to RevisionStore"
jenkins-bot [Thu, 11 Jan 2018 14:27:06 +0000 (14:27 +0000)]
Merge "Revision::newNullRevision don't pass null to RevisionStore"

6 years agoHandle failure to load content in Revision getSize, etc
daniel [Thu, 11 Jan 2018 12:40:53 +0000 (13:40 +0100)]
Handle failure to load content in Revision getSize, etc

The Revision class used to just return null if size or hsash were unknown
and could nto be determined. This patch restores this behavior by
catching any RevisionAccessExceptions raised by RevisionRecord when
failing to load content.

Bug: T184693
Bug: T184690
Change-Id: I393ea19b9fb48219583fc65ce81ea14d8d0a2357

6 years agoMerge "Deprecate old interwiki search result widget"
jenkins-bot [Thu, 11 Jan 2018 13:35:36 +0000 (13:35 +0000)]
Merge "Deprecate old interwiki search result widget"

6 years agoAdd test for newNullRevision with bad page ID
daniel [Thu, 11 Jan 2018 12:56:17 +0000 (13:56 +0100)]
Add test for newNullRevision with bad page ID

Bug: T184687
Change-Id: I893d71999f034f84bf067dedacb821a74374ea7c

6 years agoRevision::newNullRevision don't pass null to RevisionStore
addshore [Thu, 11 Jan 2018 09:22:16 +0000 (09:22 +0000)]
Revision::newNullRevision don't pass null to RevisionStore

RevisionStore::newNullRevision must be passed a Title object when
being used, passing null will result in a fatal.

Title::newFromID can return null, so check and return null early if we
have no Title object.

Also use Title::GAID_FOR_UPDATE for a higher chance of getting a Title.
Prior to the Revision overhaul newNullRevision would have always done a
select from master, it is documented as accepting $dbw and also passed
FOR UPDATE as an option to selectRow.

Bug: T184687
Change-Id: If1f99d091ab9cd37d514a4f4cbf3c28b64426cb7

6 years agoLocalize namespaces to inh
Martin Urbanec [Thu, 11 Jan 2018 07:42:22 +0000 (07:42 +0000)]
Localize namespaces to inh

Bug: T184511
Change-Id: Ia5f6add2ae4342f4916cb611c711f031c8f40575

6 years agoMerge "Add Special:Stats as an alias for Special:Statistics"
jenkins-bot [Thu, 11 Jan 2018 00:06:14 +0000 (00:06 +0000)]
Merge "Add Special:Stats as an alias for Special:Statistics"

6 years agoMerge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )"
jenkins-bot [Wed, 10 Jan 2018 23:48:21 +0000 (23:48 +0000)]
Merge "Use jQuery 3 .catch( fn ) instead of .then( null, fn )"

6 years agoRevert "Prevent new users from being sent emails"
Dmaza [Wed, 10 Jan 2018 21:23:33 +0000 (21:23 +0000)]
Revert "Prevent new users from being sent emails"

This reverts commit b52421dedd45fc035a2993d10ea90c878cd77453.

Bug: T184470
Change-Id: I2f5fe8993c6e186cd2df0841292653f8fecc0254

6 years agoSpecialProtectedpages: Remove options not used by HTMLForm
Bartosz Dziewoński [Wed, 10 Jan 2018 22:08:02 +0000 (23:08 +0100)]
SpecialProtectedpages: Remove options not used by HTMLForm

HTMLForm gets the selected value from the request. The values
specified in the form descriptor were never used. (You can specify a
default value, but that uses the 'default' key anyway.)

Change-Id: I095ee004cbe74470f33c72b391b22dd4395bff6e

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 10 Jan 2018 20:56:51 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I60c6fd2b3c01d2e1b70197b90ca0bc46a5d6a9dc

6 years agoDeprecate old interwiki search result widget
Erik Bernhardson [Wed, 3 Jan 2018 20:09:03 +0000 (12:09 -0800)]
Deprecate old interwiki search result widget

Update the flag for new interwiki sidebar from unset means disabled
to unset means enabled. Deprecate the old rendering widgets to be
removed at a later date per deprecation policy.

Change-Id: I80d8375bbd3e1fabc9b2432b6875d17a96aee099
Related: I9a488438

6 years agoUse findItemFromData instead getItemFromData
Prateek Saxena [Thu, 14 Dec 2017 07:44:50 +0000 (13:14 +0530)]
Use findItemFromData instead getItemFromData

Change-Id: I3cea1dacc1452b05e7e7423e47dcb2ffdf70c1ce
Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630

6 years ago[MCR] RevisionStore::getTitle, Fix flags passed to Title::newFromID
addshore [Wed, 10 Jan 2018 16:17:40 +0000 (16:17 +0000)]
[MCR] RevisionStore::getTitle, Fix flags passed to Title::newFromID

This was passing $queryFlags directly into Title::newFromID which
expects different flags.

Instead we now set Title::GAID_FOR_UPDATE if $queryFlags will end up
hitting the master.

Change-Id: I9c6e275c22fe74a98e79c54049afa4915a7f565d

6 years agoMerge "Numbers in the parser profiling data are not internationalized"
jenkins-bot [Wed, 10 Jan 2018 18:12:05 +0000 (18:12 +0000)]
Merge "Numbers in the parser profiling data are not internationalized"

6 years agoMerge "Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious...
jenkins-bot [Wed, 10 Jan 2018 17:14:54 +0000 (17:14 +0000)]
Merge "Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next"""

6 years agoRevert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""
addshore [Wed, 10 Jan 2018 12:23:06 +0000 (12:23 +0000)]
Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""

This is a partial revert of a revert that reverted a fix believed to
have had its underlying issue fixed in:
https://gerrit.wikimedia.org/r/#/c/400577/

The compat layer (Revision), now passes a Title object into the
RevisionStore, and this title is used to construct the Record and
also any new Revision objects.

Bug: T184559
Bug: T183548
Change-Id: Id073265c173f60aa8c456550fdb4bb5196013be8

6 years agoMerge "RCFilters: Only normalize title with 'target' when it is needed"
jenkins-bot [Wed, 10 Jan 2018 14:04:58 +0000 (14:04 +0000)]
Merge "RCFilters: Only normalize title with 'target' when it is needed"

6 years agoMerge "Integration tests for FirejailCommand"
jenkins-bot [Wed, 10 Jan 2018 13:25:59 +0000 (13:25 +0000)]
Merge "Integration tests for FirejailCommand"

6 years agoMerge "API: Don't apply size limit to action=compare"
jenkins-bot [Wed, 10 Jan 2018 13:20:22 +0000 (13:20 +0000)]
Merge "API: Don't apply size limit to action=compare"

6 years agoRemove @param comments that literally repeat what the code says
Thiemo Mättig [Thu, 28 Dec 2017 15:06:10 +0000 (16:06 +0100)]
Remove @param comments that literally repeat what the code says

These comments do not add anything. I argue they are worse than having
no comments, because I have to read them first to understand they
actually don't explain anything. Removing them makes room for actual
improvements in the future (if needed).

Change-Id: Iee70aad681b3385e9af282d5581c10addbb91ac4

6 years agoMerge "ApiQueryImageInfo: Don't return URLs if the archived file is missing"
jenkins-bot [Wed, 10 Jan 2018 13:10:19 +0000 (13:10 +0000)]
Merge "ApiQueryImageInfo: Don't return URLs if the archived file is missing"

6 years agoMerge "Use Sanitizer::mergeAttributes when merging classes into attributes"
jenkins-bot [Wed, 10 Jan 2018 13:09:33 +0000 (13:09 +0000)]
Merge "Use Sanitizer::mergeAttributes when merging classes into attributes"

6 years agoMerge "RCFilters: uriprocessor test: use hardcoded uri"
jenkins-bot [Wed, 10 Jan 2018 12:44:23 +0000 (12:44 +0000)]
Merge "RCFilters: uriprocessor test: use hardcoded uri"

6 years agoMerge "Update OOUI to v0.25.0"
jenkins-bot [Wed, 10 Jan 2018 12:39:30 +0000 (12:39 +0000)]
Merge "Update OOUI to v0.25.0"

6 years agoMerge "Bump min supported HHVM version to 3.18.5"
jenkins-bot [Wed, 10 Jan 2018 12:37:30 +0000 (12:37 +0000)]
Merge "Bump min supported HHVM version to 3.18.5"

6 years agoUpdate OOUI to v0.25.0
Volker E [Wed, 10 Jan 2018 01:04:08 +0000 (17:04 -0800)]
Update OOUI to v0.25.0

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.0

Depends-On: I5f574a0d2702f421c0c9d2556e3162abd55b9f23
Change-Id: I8a5b279f6dcb9b620e3e4e8998fc2b2d678573db

6 years agoBump min supported HHVM version to 3.18.5
Reedy [Sat, 30 Dec 2017 02:58:03 +0000 (02:58 +0000)]
Bump min supported HHVM version to 3.18.5

Change-Id: I0a22c638bf6bbd6c8b93e50c23f8e455e36acd7c

6 years agoUse jQuery 3 .catch( fn ) instead of .then( null, fn )
Fomafix [Tue, 9 Jan 2018 17:39:01 +0000 (18:39 +0100)]
Use jQuery 3 .catch( fn ) instead of .then( null, fn )

https://api.jquery.com/deferred.catch/ Since jQuery 3
deferred.catch( fn ) is an alias to deferred.then( null, fn )

This improves the readability.

Change-Id: I20fa3a1ed5c959ad0639ddf0162b8837fc15c720

6 years agoMerge "EditPage: Remove separator between cancel and help"
jenkins-bot [Wed, 10 Jan 2018 06:16:53 +0000 (06:16 +0000)]
Merge "EditPage: Remove separator between cancel and help"

6 years agoMerge "Added tests for ComposerInstalled"
jenkins-bot [Wed, 10 Jan 2018 06:04:37 +0000 (06:04 +0000)]
Merge "Added tests for ComposerInstalled"

6 years agoEditPage: Remove separator between cancel and help
Albert221 [Mon, 8 Jan 2018 22:18:05 +0000 (23:18 +0100)]
EditPage: Remove separator between cancel and help

It is no longer needed because those buttons
are already splitted visually by blank space.

Bug: T183672
Change-Id: I1f8a8413a5f4da441e3f4b4ef0b1e03d174987ca

6 years agoAdded tests for ComposerInstalled
ryan10145 [Tue, 9 Jan 2018 01:11:48 +0000 (20:11 -0500)]
Added tests for ComposerInstalled

Bug: T183899
Change-Id: Id822caad044a079884795dbea37baf10514bcf5c

6 years agoMerge "Migrate ar_text to modern storage"
jenkins-bot [Wed, 10 Jan 2018 00:10:51 +0000 (00:10 +0000)]
Merge "Migrate ar_text to modern storage"

6 years agoMerge "[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle"
jenkins-bot [Tue, 9 Jan 2018 22:40:25 +0000 (22:40 +0000)]
Merge "[BREAKING CHANGE] Rename TitleWidget#getTitle to TitleWidget#getMWTitle"

6 years agoMigrate ar_text to modern storage
Brad Jorsch [Tue, 28 Nov 2017 21:13:09 +0000 (16:13 -0500)]
Migrate ar_text to modern storage

This really should have been done a very long time ago.

This adds a maintenance script to migrate rows with ar_text_id null to
modern storage, either the text table or ExternalStore.

Bug: T36925
Change-Id: I5608c6b6d3ecad516b785e13d668427c1b762e41

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 9 Jan 2018 21:00:13 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I558e8cc84fb0d24d2eb1d4491a5cf9044cd10379

6 years agoAdd edit tags to list=watchlist
Umherirrender [Wed, 6 Dec 2017 19:56:19 +0000 (20:56 +0100)]
Add edit tags to list=watchlist

It is using the same query as list=recentchanges by left joining
tag_summary

Bug: T181975
Change-Id: I9e9ab9753ec0f813e9e555106cc81fd15ad9fb4a

6 years agoMerge "Remove obsolete style-only module 'mediawiki.action.history.diff'"
jenkins-bot [Tue, 9 Jan 2018 19:15:47 +0000 (19:15 +0000)]
Merge "Remove obsolete style-only module 'mediawiki.action.history.diff'"

6 years agoMerge "CSSMin: Re-introduce whitespace mangling in embedded SVGs"
jenkins-bot [Tue, 9 Jan 2018 17:44:56 +0000 (17:44 +0000)]
Merge "CSSMin: Re-introduce whitespace mangling in embedded SVGs"

6 years agoCSSMin: Re-introduce whitespace mangling in embedded SVGs
Volker E [Tue, 9 Jan 2018 02:34:22 +0000 (18:34 -0800)]
CSSMin: Re-introduce whitespace mangling in embedded SVGs

Convert newlines and tabs to spaces (which can be unencoded),
and consolidate runs of multiple spaces into a single space.
Also remove any leading and trailing spaces that might result
(most files end in a newline, for example).
Follow-up to Iddc98332d. This was reverted as dependency for the
original issues causing patch, but works perfectly fine.

Bug: T175318
Change-Id: Ic25d73caeb42ba7a32ef304806d401047b5a1997

6 years agoMerge "Fix type hint in ApiErrorFormatter::addMessagesFromStatus"
jenkins-bot [Tue, 9 Jan 2018 16:38:04 +0000 (16:38 +0000)]
Merge "Fix type hint in ApiErrorFormatter::addMessagesFromStatus"

6 years agoApiQueryImageInfo: Don't return URLs if the archived file is missing
Brad Jorsch [Tue, 9 Jan 2018 15:19:39 +0000 (10:19 -0500)]
ApiQueryImageInfo: Don't return URLs if the archived file is missing

If the archived file doesn't exist, indicate that instead of returning
bogus URLs.

Bug: T184445
Change-Id: I831b13314300f0289a2baf26ed21d81be31b292a

6 years agoRCFilters: uriprocessor test: use hardcoded uri
Stephane Bisson [Tue, 9 Jan 2018 15:15:06 +0000 (10:15 -0500)]
RCFilters: uriprocessor test: use hardcoded uri

new mw.Uri() without arguments uses the current browser
uri. It caused some tests to fail when run from a uri with
a subpage (Special:JavaScriptTest/qunit) and it's generally
bad to have unit tests use uncontrolled environment data.

Change-Id: Id434a491aadc2d84165edf4fd1c59775c9b815ad

6 years agoMerge "Move BaseDump into includes/export/"
jenkins-bot [Tue, 9 Jan 2018 14:52:14 +0000 (14:52 +0000)]
Merge "Move BaseDump into includes/export/"

6 years agoMerge "Add switch for readonly watchlists"
jenkins-bot [Tue, 9 Jan 2018 13:50:31 +0000 (13:50 +0000)]
Merge "Add switch for readonly watchlists"

6 years agoMerge "Update outdated WikiPageDeletionUpdates documentation"
jenkins-bot [Tue, 9 Jan 2018 13:19:33 +0000 (13:19 +0000)]
Merge "Update outdated WikiPageDeletionUpdates documentation"

6 years agoFix type hint in ApiErrorFormatter::addMessagesFromStatus
Thiemo Mättig [Tue, 9 Jan 2018 13:01:17 +0000 (14:01 +0100)]
Fix type hint in ApiErrorFormatter::addMessagesFromStatus

Change-Id: Ia7b628e9f6a7f8c8d803732504621c13976bf618

6 years agoUse IDatabase interface instead of Database in DBAccessBase
Thiemo Mättig [Tue, 9 Jan 2018 12:55:37 +0000 (13:55 +0100)]
Use IDatabase interface instead of Database in DBAccessBase

There is one subclass I'm aware of that overwrites the releaseConnection
method. It's in the EducationProgram extension and already updated, see
Ibb067ca.

Change-Id: I68504f9cd32aa0d0c6c068dbaa1f2ee65649afa4

6 years agoUpdate outdated WikiPageDeletionUpdates documentation
Thiemo Mättig [Tue, 9 Jan 2018 12:15:04 +0000 (13:15 +0100)]
Update outdated WikiPageDeletionUpdates documentation

This was already updated on
https://www.mediawiki.org/wiki/Manual:Hooks/WikiPageDeletionUpdates
more than a year ago, just missed here.

This patch is a direct follow up for a request in I3a42ec1.

Change-Id: I595b78da214c736d8e73d6d8c7af34a1613dd076

6 years agoMove BaseDump into includes/export/
Chad Horohoe [Mon, 8 Jan 2018 21:10:35 +0000 (13:10 -0800)]
Move BaseDump into includes/export/

There's no reason for this to have to live in Maintenance land. It's
generally useful and lets us avoid some random require/include calls

Change-Id: I60419c7f9fc52313905053bbeb3aa81666c9160c

6 years agoAdd Special:Stats as an alias for Special:Statistics
kaldari [Tue, 9 Jan 2018 01:20:57 +0000 (17:20 -0800)]
Add Special:Stats as an alias for Special:Statistics

Change-Id: Ib3dd0498f6ae77b522ddee786655994b24f63350

6 years agoFollow-up 8a7fb8577: For deprecated RL modules, allow strings
James D. Forrester [Tue, 9 Jan 2018 00:05:05 +0000 (16:05 -0800)]
Follow-up 8a7fb8577: For deprecated RL modules, allow strings

So that more than just PHP code and MediaWiki core can use it, but
also JSON-based static extension registrations. :-)

Change-Id: If22fccbb43c5b05db2a666d61ae8864ee9815e7d

6 years agoMerge "Treat phpdbg as run from the command line when checking PHP_SAPI"
jenkins-bot [Mon, 8 Jan 2018 23:03:41 +0000 (23:03 +0000)]
Merge "Treat phpdbg as run from the command line when checking PHP_SAPI"

6 years agoMerge "RCFilters: Fix limit display for limit=1"
jenkins-bot [Mon, 8 Jan 2018 22:42:08 +0000 (22:42 +0000)]
Merge "RCFilters: Fix limit display for limit=1"

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 8 Jan 2018 21:04:47 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9c3cdd99a86aa1a442591406baceeac8edb977ab

6 years agoMerge "Add text to tab links telling if they do exist"
jenkins-bot [Mon, 8 Jan 2018 19:24:22 +0000 (19:24 +0000)]
Merge "Add text to tab links telling if they do exist"

6 years agoPass along interface language to license preview
Matthias Mullie [Mon, 8 Jan 2018 12:36:20 +0000 (13:36 +0100)]
Pass along interface language to license preview

Bug: T184422
Change-Id: Ib1a99271ddc32f3ede0360716422e2de9fdfb005

6 years agoAdd text to tab links telling if they do exist
Albert221 [Wed, 3 Jan 2018 14:33:58 +0000 (15:33 +0100)]
Add text to tab links telling if they do exist

And changed a little bit signature of Linker::titleAttrib
and Linker::tooltipAndAcceskeyAttribs. Added $options
parameter to the second one and made $options parameter
satisfied by passing an array with options, because there
is one more now: 'nonexisting' which tells to add text
about the thing that the page does not exist to its tooltip.

Bug: T19099
Change-Id: Ia76dd6db363f6add5efb8955be9e23a1f8e8476f

6 years agoAPI: Don't apply size limit to action=compare
Brad Jorsch [Mon, 8 Jan 2018 14:21:23 +0000 (09:21 -0500)]
API: Don't apply size limit to action=compare

Some diffs can be really huge. Since ApiComparePages is intended to
return only the diff and some small metadata, bypass $wgAPIMaxResultSize
to allow the diff to be returned even if it's insanely huge.

Really insanely huge diffs might still make PHP run out of memory, even
before it gets the chance to return the diff to the API. That is outside
the scope of this change.

Bug: T184412
Change-Id: I755417f573c3caf85031d03b262aa55bd8cf36d7

6 years agoMerge "Fix BlobStoreFactoryTest @covers tag"
jenkins-bot [Mon, 8 Jan 2018 13:29:03 +0000 (13:29 +0000)]
Merge "Fix BlobStoreFactoryTest @covers tag"

6 years agoMerge "[MCR] Improve documentation and method naming on Revision and RevisionStore."
jenkins-bot [Mon, 8 Jan 2018 13:01:11 +0000 (13:01 +0000)]
Merge "[MCR] Improve documentation and method naming on Revision and RevisionStore."

6 years ago[MCR] Improve documentation and method naming on Revision and RevisionStore.
daniel [Wed, 27 Dec 2017 15:46:03 +0000 (16:46 +0100)]
[MCR] Improve documentation and method naming on Revision and RevisionStore.

Change-Id: I3b049acff9313814a4ac448289d1aef88cb7f9df

6 years agoAllow extension of the Special:Upload form
Matthias Mullie [Mon, 18 Dec 2017 14:14:38 +0000 (15:14 +0100)]
Allow extension of the Special:Upload form

* Some of the license selection code (License & Licenses)
  has seen some minor refactor to make it more open to
  reuse/extension elsewhere.
  Extension:3D will make use of these for patent selection in
  Iafb1e7e5da4b67f4c5ae7dda511d130ae10f748c
* License/TemplateSelectorLine has been modified so the text
  can be wikitext (as needed for patent labels)
* uploadLicense was renamed to uploadTemplatePreview and
  altered so it can be reused elsewhere. And, like
  window.wgUploadWarningObj, uploadTemplatePreview is now also
  added to `window` so it can be re-used from elsewhere (to
  preview patent templates)

Bug: T182683
Change-Id: I0c097442aa557dd90eb5825553ebf892f9af8a01

6 years agoAssert order of MediaWikiTestCaseSchema*Test execution
addshore [Fri, 5 Jan 2018 15:44:36 +0000 (15:44 +0000)]
Assert order of MediaWikiTestCaseSchema*Test execution

Make sure that we fail if these tests are run in the wrong order.
Essentially testing an assumption that currently holds true, but
could change in the future.

Change-Id: I8f33281d18f6f64e0e06c1b371b973542244dd24