lhc/web/wiklou.git
3 years agoFix sessionfailure i18n message during authentication
Alangi Derick [Thu, 1 Feb 2018 09:11:34 +0000 (10:11 +0100)]
Fix sessionfailure i18n message during authentication

Confusing message about session failure, telling the user to
resubmit the form is a better feedback message as most of the
time, it could be a session timeout causing the failure.

Bug: T181960
Change-Id: I8a644ac8adb89ec83a8e3b5a5ad4a2d8dc5c1d8c

3 years agoMerge "Use HTTPS instead of HTTP for caniuse.com"
jenkins-bot [Sun, 21 Jan 2018 06:11:44 +0000 (06:11 +0000)]
Merge "Use HTTPS instead of HTTP for caniuse.com"

3 years agoUpdate RunningStat use statement
Reedy [Sun, 21 Jan 2018 04:40:34 +0000 (04:40 +0000)]
Update RunningStat use statement

Bug: T182273
Change-Id: If9e946e767ca8f4c1af9b1a4855bbbffb98deff5

3 years agoUpdate WrappedString use statements
Reedy [Sun, 21 Jan 2018 04:39:17 +0000 (04:39 +0000)]
Update WrappedString use statements

Bug: T182273
Change-Id: Ia9515863491fa9c8684698fa33612eec5eb6d937

3 years agoUpdate IPSet use statements
Reedy [Sun, 21 Jan 2018 04:37:26 +0000 (04:37 +0000)]
Update IPSet use statements

Bug: T182273
Change-Id: I73fb52678dc56a542eccd209441557610b562d4b

3 years agoUpdate RelPath calls
Reedy [Sun, 21 Jan 2018 04:33:38 +0000 (04:33 +0000)]
Update RelPath calls

Bug: T182273
Change-Id: Ifd04e3b3ab72cc56bef48a1fc18fccb34b0af618

3 years agoMerge "Bypass wfGetDB when LoadBalancer is used in scope"
jenkins-bot [Sun, 21 Jan 2018 01:19:00 +0000 (01:19 +0000)]
Merge "Bypass wfGetDB when LoadBalancer is used in scope"

3 years agoUse HTTPS instead of HTTP for caniuse.com
Fomafix [Sun, 21 Jan 2018 00:41:04 +0000 (01:41 +0100)]
Use HTTPS instead of HTTP for caniuse.com

http://caniuse.com/ redirects to https://caniuse.com/

Change-Id: Iea8de252320a5a3aeda83dc21df5e51de2faf66c

3 years agoFollow-up 95e7c545: Fix .gitattributes file line truncation
James D. Forrester [Sat, 20 Jan 2018 23:30:38 +0000 (15:30 -0800)]
Follow-up 95e7c545: Fix .gitattributes file line truncation

Change-Id: I82bf4beeed41cde89da3f1f8bc517420bdfd03ad

3 years agoMerge "Change "Special:近易" to "Special:監修" in zh-classical"
jenkins-bot [Sat, 20 Jan 2018 22:13:51 +0000 (22:13 +0000)]
Merge "Change "Special:近易" to "Special:監修" in zh-classical"

3 years agoBypass wfGetDB when LoadBalancer is used in scope
Umherirrender [Sat, 20 Jan 2018 20:07:17 +0000 (21:07 +0100)]
Bypass wfGetDB when LoadBalancer is used in scope

wfGetDB calls LoadBalander::getConnection for $wiki=false,
when there is already a LoadBalancer in scope, call it directly

Change-Id: I4e29fd4e93a0d1f274e61af99c96021d3d06f8f3

3 years agoReplace deprecated wfGetLB() calls here and there
WMDE-Fisch [Thu, 4 Jan 2018 16:38:22 +0000 (17:38 +0100)]
Replace deprecated wfGetLB() calls here and there

Change-Id: Ic7cec2dcc6b8e0d500a4c37eb134976b314c33ca

3 years agoUpdate UserSaveOptions/UserSaveSettings hook descriptions
Thiemo Mättig [Thu, 11 Jan 2018 13:21:58 +0000 (14:21 +0100)]
Update UserSaveOptions/UserSaveSettings hook descriptions

I already updated
https://www.mediawiki.org/wiki/Manual:Hooks/UserSaveOptions
https://www.mediawiki.org/wiki/Manual:Hooks/UserSaveSettings
accordingly.

Change-Id: I492f83aa8acb6521f3e175fdbf507a7e44491ca2

3 years agoAdd abstract functions to abstract class..
Reedy [Fri, 1 Dec 2017 19:33:10 +0000 (19:33 +0000)]
Add abstract functions to abstract class..

Rather than just expecting the child class to have them

Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 20 Jan 2018 12:56:38 +0000 (13:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Icba7b1ff1e696b84333f8a8adaf79c2d8d16d7de

3 years agoMerge "Remove unused SpecialPasswordReset::$passwords"
jenkins-bot [Sat, 20 Jan 2018 12:20:06 +0000 (12:20 +0000)]
Merge "Remove unused SpecialPasswordReset::$passwords"

3 years agoMerge "Fix variable name to match code"
jenkins-bot [Sat, 20 Jan 2018 12:15:37 +0000 (12:15 +0000)]
Merge "Fix variable name to match code"

3 years agoMerge "Remove 2 unused private fields from ApiFormatBase"
jenkins-bot [Sat, 20 Jan 2018 12:14:24 +0000 (12:14 +0000)]
Merge "Remove 2 unused private fields from ApiFormatBase"

3 years agoMerge "Remove User::$mGroups"
jenkins-bot [Sat, 20 Jan 2018 12:14:21 +0000 (12:14 +0000)]
Merge "Remove User::$mGroups"

3 years agoSpecial:Upload: Use user interface language for error message
Fomafix [Tue, 19 Apr 2016 16:32:50 +0000 (16:32 +0000)]
Special:Upload: Use user interface language for error message

This change adds the parameters errorformat=html and errorlang with the user
interface language code to the API request.

Bug: T133059
Change-Id: I75b3c9537a8805367d36a4e51453a9f9219c9555

3 years agoConfigFactory: Improve error message for invalid callback
Umherirrender [Sat, 20 Jan 2018 09:44:46 +0000 (10:44 +0100)]
ConfigFactory: Improve error message for invalid callback

Getting the following error for an invalid callback in extension
registration is not helpful:
Fatal error: Uncaught exception 'InvalidArgumentException' with message
'Invalid callback provided' in /includes/config/ConfigFactory.php:108

Changed message to
Invalid callback '$1' provided

Added a test case for the instanceof part of the if

Change-Id: I425e2607b651c666336289c2c0d93730bb6312ed

3 years agoMerge "Update wikimedia dependencies"
MaxSem [Sat, 20 Jan 2018 07:16:31 +0000 (07:16 +0000)]
Merge "Update wikimedia dependencies"

3 years agoMerge "mediawiki.Uri: Don't double-escape fragments"
jenkins-bot [Sat, 20 Jan 2018 03:08:48 +0000 (03:08 +0000)]
Merge "mediawiki.Uri: Don't double-escape fragments"

3 years agoMerge "Localize namespaces to inh"
jenkins-bot [Sat, 20 Jan 2018 03:04:53 +0000 (03:04 +0000)]
Merge "Localize namespaces to inh"

3 years agoRemove unused SpecialPasswordReset::$passwords
Max Semenik [Sat, 20 Jan 2018 00:38:55 +0000 (16:38 -0800)]
Remove unused SpecialPasswordReset::$passwords

Change-Id: I4c03bd9b7f01bacba453a263c3676b4f47aec933

3 years agoFix variable name to match code
Max Semenik [Sat, 20 Jan 2018 00:36:52 +0000 (16:36 -0800)]
Fix variable name to match code

Change-Id: Idb97c9c5379d2ba4f0874ceaffcf48870bdd682e

3 years agoRemove 2 unused private fields from ApiFormatBase
Max Semenik [Sat, 20 Jan 2018 00:35:44 +0000 (16:35 -0800)]
Remove 2 unused private fields from ApiFormatBase

Change-Id: I20018c7c5a2bff451db44fdb605120942500c5e1

3 years agoRemove User::$mGroups
Max Semenik [Sat, 20 Jan 2018 00:33:59 +0000 (16:33 -0800)]
Remove User::$mGroups

Deprecated and unused. Private so nothing can possibly use it.

Change-Id: I70a20d35222cb0571e8b401c8b4e031d0be25d6b

3 years agomediawiki.Uri: Don't double-escape fragments
Roan Kattouw [Fri, 19 Jan 2018 23:16:29 +0000 (15:16 -0800)]
mediawiki.Uri: Don't double-escape fragments

Fragments were ingested already-escaped, then escaped again
when serializing. To prevent double-escaping, decode fragments
when ingesting them.

Bug: T183710
Change-Id: I19fc889bb7bde446476203bf6d6352dce8298256

3 years agoMerge "Follow-up 5aea96df: Add release notes for File SHA1 display"
jenkins-bot [Fri, 19 Jan 2018 18:47:18 +0000 (18:47 +0000)]
Merge "Follow-up 5aea96df: Add release notes for File SHA1 display"

3 years agoMerge "Move standard tar ignores to .gitattributes so `git archive` works"
jenkins-bot [Fri, 19 Jan 2018 18:35:23 +0000 (18:35 +0000)]
Merge "Move standard tar ignores to .gitattributes so `git archive` works"

3 years agoFollow-up 5aea96df: Add release notes for File SHA1 display
RazeSoldier [Thu, 18 Jan 2018 07:16:09 +0000 (15:16 +0800)]
Follow-up 5aea96df: Add release notes for File SHA1 display

Bug: T181651
Change-Id: I5e75f88d30954423aab8876687d959c3b400d2b6

3 years agoMerge "Move methods for handling external usernames to a dedicated class"
jenkins-bot [Fri, 19 Jan 2018 14:43:41 +0000 (14:43 +0000)]
Merge "Move methods for handling external usernames to a dedicated class"

3 years agoUpdate wikimedia dependencies
Reedy [Thu, 18 Jan 2018 21:15:07 +0000 (21:15 +0000)]
Update wikimedia dependencies

Updated:
* wikimedia/ip-set 1.1.0 -> 1.2.0
* wikimedia/relpath 2.0.0 -> 2.1.1
* wikimedia/running-stat 1.1.0 -> 1.2.1
* wikimedia/wrappedstring 2.2.0 -> 2.3.0

https://github.com/wikimedia/IPSet/compare/1.1.0...1.2.0
https://github.com/wikimedia/relpath/compare/2.0.0...2.1.1
https://github.com/wikimedia/runningstat/compare/v1.1.0...v1.2.1
https://github.com/wikimedia/WrappedString/compare/v2.2.0...v2.3.0

Bug: T182273
Change-Id: I23a734e7a5b9a7ff4d46901a9c5b3b51402687d5
Depends-On: Ib2402f41262549207c8386d74855240ca0d4a54b

3 years agoPHPVersionCheck: PHP 5.5.0 is no longer supported by upstream, but 5.6.0 is
James D. Forrester [Thu, 18 Jan 2018 23:50:41 +0000 (15:50 -0800)]
PHPVersionCheck: PHP 5.5.0 is no longer supported by upstream, but 5.6.0 is

Change-Id: I7031f0e909db8d63012f4057939292cb3b472cde

3 years agoMerge "Test HHVM LTS versions 3.21 and 3.24 on travis"
jenkins-bot [Thu, 18 Jan 2018 23:15:39 +0000 (23:15 +0000)]
Merge "Test HHVM LTS versions 3.21 and 3.24 on travis"

3 years agoMove standard tar ignores to .gitattributes so `git archive` works
Chad Horohoe [Thu, 18 Jan 2018 22:30:49 +0000 (14:30 -0800)]
Move standard tar ignores to .gitattributes so `git archive` works

Change-Id: Ib12a21827d85f781030309cf400f3207c8bbd8dd

3 years agoMerge "Fix phpdoc since $proto can be int"
jenkins-bot [Thu, 18 Jan 2018 21:30:29 +0000 (21:30 +0000)]
Merge "Fix phpdoc since $proto can be int"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 18 Jan 2018 21:25:06 +0000 (22:25 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I9bc9cb1c35fe84a38e237496306ddae98e904a40

3 years agoFix phpdoc since $proto can be int
Stanislav Malyshev [Thu, 18 Jan 2018 21:05:42 +0000 (13:05 -0800)]
Fix phpdoc since $proto can be int

In fact, some of the PROTO_* constants are ints,
some strings and one is null (PROTO_CURRENT).

Change-Id: I69c45ab87360ed1ab54b53b7e9e959ea566b4cba

3 years agoMove methods for handling external usernames to a dedicated class
Amir Sarabadani [Thu, 11 Jan 2018 12:20:35 +0000 (13:20 +0100)]
Move methods for handling external usernames to a dedicated class

This makes things centralized to reduce maintenance cost and also
enables me to use this methods in Wikibase to handle RC injection

Bug: T185034
Change-Id: Ic8c602e316144ccb5b05c69a0cc607cd53e38912

3 years agoRevert accidentally removed trait
Adam Roses Wight [Tue, 16 Jan 2018 23:42:29 +0000 (18:42 -0500)]
Revert accidentally removed trait

Change-Id: I82283be89f3f155d7793d4c900927d81a60d5e95

3 years agoMerge "Add PHPUnit tests for ApiDelete"
jenkins-bot [Thu, 18 Jan 2018 16:07:25 +0000 (16:07 +0000)]
Merge "Add PHPUnit tests for ApiDelete"

3 years agoAdd PHPUnit tests for ApiDelete
Yifei He [Sun, 14 Jan 2018 09:52:57 +0000 (17:52 +0800)]
Add PHPUnit tests for ApiDelete

This covers deleting non-file pages.

Bug: T183886
Change-Id: I31c27786b16b55f8bf4cf528bf4c1ea49075e02e

3 years agoTest HHVM LTS versions 3.21 and 3.24 on travis
Reedy [Sat, 30 Dec 2017 03:04:54 +0000 (03:04 +0000)]
Test HHVM LTS versions 3.21 and 3.24 on travis

Change-Id: I7f772443808f936c0d75910fd18bf8cbd0204088

3 years agoMerge "JavaScriptMinifier: Remove support for unused $maxLineLength param"
jenkins-bot [Thu, 18 Jan 2018 04:00:47 +0000 (04:00 +0000)]
Merge "JavaScriptMinifier: Remove support for unused $maxLineLength param"

3 years agoMerge "JavaScriptMinifier: Enable phpcs and fix violations"
jenkins-bot [Thu, 18 Jan 2018 03:46:57 +0000 (03:46 +0000)]
Merge "JavaScriptMinifier: Enable phpcs and fix violations"

3 years agoMerge "JavaScriptMinifier: Fix "Uninitialized offset" in string and regexp parsing"
jenkins-bot [Thu, 18 Jan 2018 03:29:10 +0000 (03:29 +0000)]
Merge "JavaScriptMinifier: Fix "Uninitialized offset" in string and regexp parsing"

3 years agoMerge "JavaScriptMinifier: Improve docs for parsing of string literals"
jenkins-bot [Thu, 18 Jan 2018 03:26:44 +0000 (03:26 +0000)]
Merge "JavaScriptMinifier: Improve docs for parsing of string literals"

3 years agoMerge "SpecialLog: Don't ignore offender when it's a nonexistent username"
jenkins-bot [Thu, 18 Jan 2018 03:09:53 +0000 (03:09 +0000)]
Merge "SpecialLog: Don't ignore offender when it's a nonexistent username"

3 years agoMerge "Non-MySQL comment table updates"
jenkins-bot [Thu, 18 Jan 2018 03:06:45 +0000 (03:06 +0000)]
Merge "Non-MySQL comment table updates"

3 years agoMerge "Add more data to categories dump"
jenkins-bot [Wed, 17 Jan 2018 21:58:31 +0000 (21:58 +0000)]
Merge "Add more data to categories dump"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 17 Jan 2018 21:21:59 +0000 (22:21 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I481c1a4d2cbf95edaae321815b41a44e455ea305

3 years agoSpecialLog: Don't ignore offender when it's a nonexistent username
Brad Jorsch [Wed, 17 Jan 2018 15:44:29 +0000 (10:44 -0500)]
SpecialLog: Don't ignore offender when it's a nonexistent username

When viewing the suppression log, the 'offender' field is ignored if it
specifies a username that happens to not exist locally. It would make
more sense for it to filter by that name and return an empty list.

Ideally such searches would have the possibility of succeeding, since
imported log entries can be attributed to a nonexistent user, but the
necessary data isn't currently being stored. The actor table patch
(I8d825eb0) will start storing that data once migration begins, although
a maintenance script run would be needed to populate it for old log
entries.

Change-Id: I73ac78f7623178ab878135b910a22013723885d3

3 years agoRemove support for PHP extension 'mysql' (not mysqli!)
Seb35 [Tue, 16 Jan 2018 19:02:11 +0000 (20:02 +0100)]
Remove support for PHP extension 'mysql' (not mysqli!)

This PHP extension was deprecated in PHP 5.5 and removed in PHP 7.0.
The newer MySQL driver 'mysqli' is the default driver since MediaWiki
1.22 and 'mysql' was deprecated in MediaWiki 1.30.

Bug: T120333
Change-Id: Icff7a63ab47ae1483de87ba6486945974699362b

3 years agoEditPage: Match the Save/Publish button's tooltip to its label
Bartosz Dziewoński [Wed, 17 Jan 2018 16:38:09 +0000 (17:38 +0100)]
EditPage: Match the Save/Publish button's tooltip to its label

Change 9ca9c7ee931ec7fde5518d91593a69b16d98b13d introduced the
localisation messages for this, but they were never used.

If $wgEditSubmitButtonLabelPublish is true, the button will now use
'tooltip-publish' for title and 'accesskey-publish' for accesskey.

Bug: T185071
Change-Id: I7dd4edf99c97b2b12d8b18603bb29786c72283a5

3 years agoNon-MySQL comment table updates
Brad Jorsch [Tue, 16 Jan 2018 17:30:24 +0000 (12:30 -0500)]
Non-MySQL comment table updates

Follows up Ic3a434c06.

Add schema for MSSQL and Oracle, and add a missing 'migrateComments'
call for PostgreSQL.

Bug: T166732
Change-Id: I408085db17bf951ce721427e7344b4afd5706e40

3 years agoMerge "EditPage: Simplify getEditButtons()"
jenkins-bot [Wed, 17 Jan 2018 17:08:01 +0000 (17:08 +0000)]
Merge "EditPage: Simplify getEditButtons()"

3 years agoMerge "EditPage: Update Save/Publish button flag from 'constructive' to 'progressive'"
jenkins-bot [Wed, 17 Jan 2018 17:04:36 +0000 (17:04 +0000)]
Merge "EditPage: Update Save/Publish button flag from 'constructive' to 'progressive'"

3 years agoMerge "Update OOUI to v0.25.1"
jenkins-bot [Wed, 17 Jan 2018 17:00:45 +0000 (17:00 +0000)]
Merge "Update OOUI to v0.25.1"

3 years agoEditPage: Simplify getEditButtons()
Bartosz Dziewoński [Wed, 17 Jan 2018 16:32:38 +0000 (17:32 +0100)]
EditPage: Simplify getEditButtons()

When this function supported both OOUI and non-OOUI buttons
(before 478caa076f75fde935c66eb9334410d868c30818), using
OOUI\Element::configFromHtmlAttributes() avoided some code
duplication, but now it's just unnecessary.

Change-Id: Ie941b9919e40b0a57d28ad76d1f0cc257456ce49

3 years agoEditPage: Update Save/Publish button flag from 'constructive' to 'progressive'
Bartosz Dziewoński [Wed, 17 Jan 2018 16:41:46 +0000 (17:41 +0100)]
EditPage: Update Save/Publish button flag from 'constructive' to 'progressive'

OOUI 'constructive' flag was removed in OOUI v0.25.0.

Change-Id: I751d45cca3919dcf67b79bc1de6a085ea018bf58

3 years agoMerge "Allow extension of the Special:Upload form"
jenkins-bot [Wed, 17 Jan 2018 16:35:02 +0000 (16:35 +0000)]
Merge "Allow extension of the Special:Upload form"

3 years agoApiQueryTags: Remove unused tgprop value
Brad Jorsch [Wed, 17 Jan 2018 15:01:51 +0000 (10:01 -0500)]
ApiQueryTags: Remove unused tgprop value

While a tgprop=name has been defined since the module was created, it
has never made any difference to the output. Let's just remove it.

Bug: T185058
Change-Id: If9d7597751a8bdb8e415d6f7bab741452a6fd753

3 years agoMerge "Page title is not used in Selenium tests"
jenkins-bot [Wed, 17 Jan 2018 13:07:59 +0000 (13:07 +0000)]
Merge "Page title is not used in Selenium tests"

3 years agoPage title is not used in Selenium tests
Željko Filipin [Wed, 17 Jan 2018 12:15:56 +0000 (13:15 +0100)]
Page title is not used in Selenium tests

Bug: T182421
Change-Id: I0de9bf27f1227e7b29c5aaa28451823e80fa8ff1

3 years agoMerge "New namespace MediaWiki\Tests\Maintenance"
jenkins-bot [Wed, 17 Jan 2018 10:14:40 +0000 (10:14 +0000)]
Merge "New namespace MediaWiki\Tests\Maintenance"

3 years agoUpdate OOUI to v0.25.1
Volker E [Wed, 17 Jan 2018 05:47:34 +0000 (21:47 -0800)]
Update OOUI to v0.25.1

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.1

Depends-on: I4d0697f93fccd919fedd370b0c196af8a3046c50
Change-Id: I6413f052928b1980a6a1031df92a932ba1f14941

3 years agoAdd more data to categories dump
Stanislav Malyshev [Fri, 17 Nov 2017 23:58:37 +0000 (15:58 -0800)]
Add more data to categories dump

Hidden category: <cat> a mediawiki:HiddenCategory .
Pages count: <cat> mediawiki:pages 10 .
Subcats count: <cat> mediawiki:subcategories 5 .

Note that pages count includes only actual articles, unlike mediawiki
table.

Bug: T173980
Change-Id: I6d34c58f844411f891195776406e11acd2aef7b1

3 years agoMerge "Port categories dump header fix"
jenkins-bot [Wed, 17 Jan 2018 00:19:42 +0000 (00:19 +0000)]
Merge "Port categories dump header fix"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 16 Jan 2018 21:23:39 +0000 (22:23 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If03561b99a16a7204512f9da32b67bc2f26c1100

3 years agoMerge "rdbms: specify DB name and table prefix even for the local domain"
jenkins-bot [Tue, 16 Jan 2018 21:04:35 +0000 (21:04 +0000)]
Merge "rdbms: specify DB name and table prefix even for the local domain"

3 years agoNew namespace MediaWiki\Tests\Maintenance
Adam Roses Wight [Tue, 16 Jan 2018 18:20:31 +0000 (13:20 -0500)]
New namespace MediaWiki\Tests\Maintenance

Bug: T184775
Change-Id: I041b8eb4f1ef3cf882a8082ff3f208604b8edf96

3 years agoMerge "Minor documentation cleanup"
jenkins-bot [Tue, 16 Jan 2018 19:47:19 +0000 (19:47 +0000)]
Merge "Minor documentation cleanup"

3 years agoMerge "Revert "Prevent new users from being sent emails""
jenkins-bot [Tue, 16 Jan 2018 19:44:11 +0000 (19:44 +0000)]
Merge "Revert "Prevent new users from being sent emails""

3 years agoMinor documentation cleanup
Adam Roses Wight [Tue, 16 Jan 2018 15:56:15 +0000 (10:56 -0500)]
Minor documentation cleanup

Bug: T184775
Change-Id: I883a2ebc0a1ce7667a92623a4861be80df26a65d

3 years agoWhen running Selenium tests, use `wd/hub`
Željko Filipin [Tue, 16 Jan 2018 17:40:27 +0000 (18:40 +0100)]
When running Selenium tests, use `wd/hub`

It works both on Mac and Windows. I am assuming it works on Linux too.

Bug: T182421
Change-Id: I85a9e7dbd9a66418c85585969adb5ac1548f5ef6

3 years agordbms: specify DB name and table prefix even for the local domain
Aaron Schulz [Fri, 12 Jan 2018 21:44:12 +0000 (13:44 -0800)]
rdbms: specify DB name and table prefix even for the local domain

When LoadBalancer opens new local domain connections, it currently
assumes that the domain specified by the server info array is the
same. For sanity, make sure that the handle is set to the local
domain.

The main LBFactory/LoadBalancer use $wgDBname/$wgDBprefix as the
local domain, corresponding with wfWikiId(). This relation is set
automatically in MWLBFactory. If $wgLBFactoryConf/$wgDBservers is
manually configured in a way breaking this correspondance, then it
is misconfigured.

Fixes made to avoid test failure:
* Make sure LoadBalancer::setDomainPrefix() updates the local
  domain alias member. Also do not bother changing the domain of
  foreign connections.
* Use the right domain ID for the connection array key names in
  LoadBalancer::openForeignConnection().
* Now that JobQueueTest no longer mistakenly uses the non-test
  tables, force it to use the main DB_MASTER handle so that it can
  see the unit test tables even if they are TEMPORARY; such tables
  are tied to the TCP connection, so separate handles see different
  temporary tables.

Change-Id: I56f8b32fe957f984b8c9753e6db3b20abe96b038

3 years agoMerge "Clear the backlink cache on file delete"
jenkins-bot [Tue, 16 Jan 2018 11:17:39 +0000 (11:17 +0000)]
Merge "Clear the backlink cache on file delete"

3 years agoClear the backlink cache on file delete
Cormac Parle [Wed, 10 Jan 2018 18:02:02 +0000 (18:02 +0000)]
Clear the backlink cache on file delete

When a file is deleted pages that link to the file
(backlinks) are purged. The set of backlinks for a file
is cached in the backlink cache, and this is where the set
of backlinks that need purging is read from. If, at file delete
time, there is a backlink cache for the file but it is not
up to date, then backlinks missing from the set of cached
backlinks for that file will not be purged, leading to
broken links.

This patch clears the backlink cache on file delete before
initiating purging of backlinks.

Bug: T183478
Change-Id: I3bbd79e5a8fa14bf80ceee81e944108edada322e

3 years agoMerge "Add Nyungar (nys) to Names.php & release note"
jenkins-bot [Tue, 16 Jan 2018 09:21:03 +0000 (09:21 +0000)]
Merge "Add Nyungar (nys) to Names.php & release note"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 15 Jan 2018 21:01:04 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ieaf4ce577d22bf2497c7913cde3e62a20d86941c

3 years agoMerge "mediawiki.util.test: Set wgFragmentMode before testing getUrl"
jenkins-bot [Mon, 15 Jan 2018 17:20:21 +0000 (17:20 +0000)]
Merge "mediawiki.util.test: Set wgFragmentMode before testing getUrl"

3 years agoMerge "watch.js: Simplify by using .map()"
jenkins-bot [Mon, 15 Jan 2018 16:36:36 +0000 (16:36 +0000)]
Merge "watch.js: Simplify by using .map()"

3 years agoselenium, update page spec to include more chars
addshore [Sat, 13 Jan 2018 12:19:28 +0000 (12:19 +0000)]
selenium, update page spec to include more chars

Bug: T184749
Change-Id: I3423011c467b0a6426cfa0dad522435618f24bd0

3 years agoSelenium README note about --url-base on Windows
addshore [Sat, 13 Jan 2018 11:52:26 +0000 (11:52 +0000)]
Selenium README note about --url-base on Windows

For me /wd/hub doesnt work and wd/hub must be used

Change-Id: Ic61d516b53c95b0d1351bcda7308870f5fc5171c

3 years agowatch.js: Simplify by using .map()
Fomafix [Mon, 15 Jan 2018 05:17:44 +0000 (06:17 +0100)]
watch.js: Simplify by using .map()

Change-Id: Idd0b4c67d05e0b300b347f2a3a6890c1f2ec88ad

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 14 Jan 2018 20:57:04 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I2b0a150164ee9db014aa531842196fdc16a2f7fe

3 years agomediawiki.util.test: Set wgFragmentMode before testing getUrl
Fomafix [Sat, 13 Jan 2018 10:47:26 +0000 (11:47 +0100)]
mediawiki.util.test: Set wgFragmentMode before testing getUrl

The result of mw.util.getUrl() depends on wgFragmentMode.
This change sets wgFragmentMode before testing mw.util.getUrl() and
tests the modes 'legacy' and 'html5'.

This change fixes failures on Special:JavaScriptTest when
  $wgFragmentMode = [ 'html5' ];
is set in LocalSettings.php.

Change-Id: Ifc65faacfcddb7d1bb4b298a0940c8f0208a23d7

3 years agoDocument expandBlob behavior when no flags are given.
daniel [Fri, 12 Jan 2018 13:51:56 +0000 (14:51 +0100)]
Document expandBlob behavior when no flags are given.

Bug: T184749
Change-Id: I5f1f029d928a7bc25877b0eae9f3822ec321b24a

3 years agoMerge "rdbms: add LoadBalancer::getLocalDomainId() method"
jenkins-bot [Sun, 14 Jan 2018 08:49:06 +0000 (08:49 +0000)]
Merge "rdbms: add LoadBalancer::getLocalDomainId() method"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 13 Jan 2018 20:54:19 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I6b8d75063390c28f8a6b421e215ce24a9ef8d0b3

3 years agordbms: add LoadBalancer::getLocalDomainId() method
Aaron Schulz [Fri, 12 Jan 2018 23:57:23 +0000 (15:57 -0800)]
rdbms: add LoadBalancer::getLocalDomainId() method

This returns the default domain without getting a connection

Also avoid assuming that LoadBalancerTest has the same DB handle
as other tests even though it makes its own LB object. That breaks
if temporary tables are used.

Change-Id: I351d42de38b3126222c5a40627a2a12f76a60939

3 years agoMerge "Use cache set options in SqlBlobStore::getBlob"
jenkins-bot [Sat, 13 Jan 2018 03:16:54 +0000 (03:16 +0000)]
Merge "Use cache set options in SqlBlobStore::getBlob"

3 years agoMerge "Fix LoadBalancer::getMasterPos() callers to handle a non-object being returned"
jenkins-bot [Sat, 13 Jan 2018 00:01:33 +0000 (00:01 +0000)]
Merge "Fix LoadBalancer::getMasterPos() callers to handle a non-object being returned"

3 years agoFix LoadBalancer::getMasterPos() callers to handle a non-object being returned
Aaron Schulz [Fri, 12 Jan 2018 23:18:14 +0000 (15:18 -0800)]
Fix LoadBalancer::getMasterPos() callers to handle a non-object being returned

Change-Id: I3356057f27a051835734329afa339ea76842a389

3 years agoMerge "OOUI: Manually pull in fix from I99caad7b ahead of the release cycle"
jenkins-bot [Fri, 12 Jan 2018 22:13:39 +0000 (22:13 +0000)]
Merge "OOUI: Manually pull in fix from I99caad7b ahead of the release cycle"

3 years agoMerge "ApiSandbox: Use OO.ui.getDefaultOverlay()"
jenkins-bot [Fri, 12 Jan 2018 21:50:26 +0000 (21:50 +0000)]
Merge "ApiSandbox: Use OO.ui.getDefaultOverlay()"

3 years agoMerge "Add edit tags to list=watchlist"
jenkins-bot [Fri, 12 Jan 2018 21:50:22 +0000 (21:50 +0000)]
Merge "Add edit tags to list=watchlist"

3 years agoSpecialProtectedtitles: Use 'comma-separator' instead of hardcoded comma
Bartosz Dziewoński [Wed, 10 Jan 2018 22:12:18 +0000 (23:12 +0100)]
SpecialProtectedtitles: Use 'comma-separator' instead of hardcoded comma

Also simplify the code.

Change-Id: Ib3914b618ba3a7f1fd3e9df5527653a28c3e4ef9