lhc/web/wiklou.git
3 years agoMerge "Ensure whether user can rollback page in ChangesList"
jenkins-bot [Mon, 9 Jul 2018 22:34:40 +0000 (22:34 +0000)]
Merge "Ensure whether user can rollback page in ChangesList"

3 years agoMerge "UsersMultiselectWidget: Reduce default non-JS rows to 10"
jenkins-bot [Mon, 9 Jul 2018 19:58:48 +0000 (19:58 +0000)]
Merge "UsersMultiselectWidget: Reduce default non-JS rows to 10"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 9 Jul 2018 19:53:16 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I9831872a1c218da0ac6b25c8b39548d269a64025

3 years agoMerge "Add a method to HTMLForm that allows the preText to be accessed externally."
jenkins-bot [Mon, 9 Jul 2018 18:35:24 +0000 (18:35 +0000)]
Merge "Add a method to HTMLForm that allows the preText to be accessed externally."

3 years agoMerge "Remove most uses of deprecated Language::truncate()"
jenkins-bot [Mon, 9 Jul 2018 18:29:18 +0000 (18:29 +0000)]
Merge "Remove most uses of deprecated Language::truncate()"

3 years agoMerge "Replace 'capsule' with appropriate 'tag'"
jenkins-bot [Mon, 9 Jul 2018 18:02:59 +0000 (18:02 +0000)]
Merge "Replace 'capsule' with appropriate 'tag'"

3 years agoMerge "Avoid losing cached ParserOutput in doEditContent."
jenkins-bot [Mon, 9 Jul 2018 17:57:23 +0000 (17:57 +0000)]
Merge "Avoid losing cached ParserOutput in doEditContent."

3 years agoReplace 'capsule' with appropriate 'tag'
Volker E [Mon, 9 Jul 2018 17:44:09 +0000 (19:44 +0200)]
Replace 'capsule' with appropriate 'tag'

UsersMultiselectWidget class extends OOUI's MenuTagMultiselectWidget,
not CapsuleMultiselectWidget any more.

Change-Id: Iea7450a371720bed392dfedb1032bc8c63c89fc4

3 years agoRemove most uses of deprecated Language::truncate()
C. Scott Ananian [Wed, 13 Jun 2018 17:49:29 +0000 (13:49 -0400)]
Remove most uses of deprecated Language::truncate()

The Language::truncate() function was split into
Language::truncateForVisual() (which measures characters) and
Language::truncateForDatabase() (which measures bytes) in 1.31, but
the patch which soft-deprecated Language::truncate() didn't actually
remove all the uses in the codebase.  Replace most of those old uses
now, which should actually improve the situation for
non-latin-alphabet users who were getting unfairly squeezed in a
number of places.

Bug: T197492
Change-Id: I2291c69d9df17c1a9e4ab1b7d4cbc73bc51d3ebb

3 years agoUsersMultiselectWidget: Reduce default non-JS rows to 10
Volker E [Mon, 9 Jul 2018 17:35:39 +0000 (19:35 +0200)]
UsersMultiselectWidget: Reduce default non-JS rows to 10

Reducing non-JS textarea `rows` attribute value to a more sane
default of `10`.

Bug: T194525
Change-Id: I6457ff354023a68d3e878e62161912dea4ff3d70

3 years agoAdd a method to HTMLForm that allows the preText to be accessed externally.
David Barratt [Mon, 9 Jul 2018 14:30:06 +0000 (10:30 -0400)]
Add a method to HTMLForm that allows the preText to be accessed externally.

Currently there is no way to access the preText outside of an HTMLForm. Adding
a getPreText method to HTMLForm so the preText is accessible.

Bug: T199115
Change-Id: I937028e7025b4a7b5d333e9bf5a25920f6a88316

3 years agoMerge "Allow ResourceLoaderImage modules without data URIs"
jenkins-bot [Mon, 9 Jul 2018 14:24:36 +0000 (14:24 +0000)]
Merge "Allow ResourceLoaderImage modules without data URIs"

3 years agoAvoid losing cached ParserOutput in doEditContent.
daniel [Sun, 8 Jul 2018 19:01:32 +0000 (21:01 +0200)]
Avoid losing cached ParserOutput in doEditContent.

Without this fix, the Content would be parsed twice during an edit,
if extensions that hook into EditFilter and similar
pre-parse hooks call WikiPage::prepareContentForEdit.

With this fix, ParserOutput created by prepareContentForEdit is
re-used by doEditContent.

This is a stop-gap solution. The Real Fix (tm) is to stop using
doEditContent, and use a PageUpdater instead.

Bug: T198483
Change-Id: I42123e48de2b087ef98d8a4855ee3aebd7f1de57

3 years agoMerge "Tweak 'mediawiki.skinning.elements' documentation"
jenkins-bot [Mon, 9 Jul 2018 12:34:28 +0000 (12:34 +0000)]
Merge "Tweak 'mediawiki.skinning.elements' documentation"

3 years agoTweak 'mediawiki.skinning.elements' documentation
Jack Phoenix [Wed, 4 Jul 2018 16:26:59 +0000 (19:26 +0300)]
Tweak 'mediawiki.skinning.elements' documentation

Skins haven't been a part of MediaWiki core for a while now,
they are very much separate things existing in their own,
separate repositories.

Change-Id: I55e3b6382b8fef3b25562b52580d1b1f902a760e

3 years agoMerge "Web installer: Correctly escape U+00A0 NO-BREAK SPACE"
jenkins-bot [Mon, 9 Jul 2018 04:26:42 +0000 (04:26 +0000)]
Merge "Web installer: Correctly escape U+00A0 NO-BREAK SPACE"

3 years agoWeb installer: Correctly escape U+00A0 NO-BREAK SPACE
Kevin Israel [Mon, 9 Jul 2018 02:27:52 +0000 (22:27 -0400)]
Web installer: Correctly escape U+00A0 NO-BREAK SPACE

Unicode escape sequences cannot be used in single quoted strings,
in which they are treated as literal text.

Follows-up 125cbd8c017b872c.

Change-Id: Ife53a613a801b8bb96542b42fd3d2bb3dccaf629

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 8 Jul 2018 21:05:10 +0000 (23:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Iedc84ad218c0997bf7a36637aa68c8b1f69189d6

3 years agoresourceloader: Add coverage for StartupModule::getAllModuleHashes
Timo Tijhof [Sun, 8 Jul 2018 06:48:35 +0000 (23:48 -0700)]
resourceloader: Add coverage for StartupModule::getAllModuleHashes

Change-Id: I94551a938cd93152eb1bb0a4748e1c0155539c4c

3 years agoMerge "Avoid deprecated IDatabase::getWikiId() reference"
jenkins-bot [Sat, 7 Jul 2018 23:07:45 +0000 (23:07 +0000)]
Merge "Avoid deprecated IDatabase::getWikiId() reference"

3 years agoAvoid deprecated IDatabase::getWikiId() reference
Aaron Schulz [Fri, 6 Jul 2018 19:19:51 +0000 (20:19 +0100)]
Avoid deprecated IDatabase::getWikiId() reference

Change-Id: I26991079b1630335c8a6e907554760fc85c1bad6

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 7 Jul 2018 20:08:00 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I6cbbc67a417d2c38ea4ce6e155ce2f101d0fd52d

3 years agoFix ParserTestRunner DB table test prefix logic
Aaron Schulz [Sat, 7 Jul 2018 08:52:43 +0000 (09:52 +0100)]
Fix ParserTestRunner DB table test prefix logic

Follow-up to 6cfdbdf60

Bug: T198943
Change-Id: I3c3553f2ec6b5ca0d401712e4018c7eec4d9204d

3 years agoFix PhanTypeMismatchDeclaredParam
Umherirrender [Tue, 26 Jun 2018 21:14:43 +0000 (23:14 +0200)]
Fix PhanTypeMismatchDeclaredParam

Auto fix MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam sniff

Change-Id: I865323fd0295aabd06f3e3c75e0e5043fb31069e

3 years agoMerge "Avoid duplicate IDs on Special:Preferences"
jenkins-bot [Fri, 6 Jul 2018 23:55:51 +0000 (23:55 +0000)]
Merge "Avoid duplicate IDs on Special:Preferences"

3 years agoRemove unused AuthManager::singleton() call
Reedy [Fri, 6 Jul 2018 23:08:27 +0000 (23:08 +0000)]
Remove unused AuthManager::singleton() call

Follows-up 3617c982c9db793.

Change-Id: I63aa3a747fea8e909bb34239871cda8316c54fe6

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 6 Jul 2018 20:08:47 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I807826a81b162c38cdd874174cb886b307236327

3 years agoMerge "Remove hasOwnProperty checks in for-loops"
jenkins-bot [Fri, 6 Jul 2018 18:13:49 +0000 (18:13 +0000)]
Merge "Remove hasOwnProperty checks in for-loops"

3 years agoMerge "build: Enable and make pass no-prototype-builtins"
jenkins-bot [Fri, 6 Jul 2018 18:13:44 +0000 (18:13 +0000)]
Merge "build: Enable and make pass no-prototype-builtins"

3 years agoMerge "build: Upgrade eslint to 5.x"
jenkins-bot [Fri, 6 Jul 2018 18:13:39 +0000 (18:13 +0000)]
Merge "build: Upgrade eslint to 5.x"

3 years agoMerge "Use consistent caching strategy in Revision storage classes"
jenkins-bot [Fri, 6 Jul 2018 18:09:13 +0000 (18:09 +0000)]
Merge "Use consistent caching strategy in Revision storage classes"

3 years agoMerge "rdbms: add resolveDomainID() method to LBFactory/LoadBalancer"
jenkins-bot [Fri, 6 Jul 2018 17:54:01 +0000 (17:54 +0000)]
Merge "rdbms: add resolveDomainID() method to LBFactory/LoadBalancer"

3 years agoMerge "Allow extra slots in write-both/read-new mode."
jenkins-bot [Fri, 6 Jul 2018 17:53:55 +0000 (17:53 +0000)]
Merge "Allow extra slots in write-both/read-new mode."

3 years agoMerge "Introduce new schema flags and use them in RevisionStore."
jenkins-bot [Fri, 6 Jul 2018 17:53:44 +0000 (17:53 +0000)]
Merge "Introduce new schema flags and use them in RevisionStore."

3 years agoAllow ResourceLoaderImage modules without data URIs
jdlrobson [Thu, 5 Jul 2018 23:51:30 +0000 (16:51 -0700)]
Allow ResourceLoaderImage modules without data URIs

Bug: T198930
Change-Id: I13853a59222b38de0afde301a781af06067d4ddc

3 years agoMerge "Document return of void in Maintenance::execute"
jenkins-bot [Fri, 6 Jul 2018 16:45:09 +0000 (16:45 +0000)]
Merge "Document return of void in Maintenance::execute"

3 years agoRemove hasOwnProperty checks in for-loops
Timo Tijhof [Fri, 6 Jul 2018 02:46:56 +0000 (19:46 -0700)]
Remove hasOwnProperty checks in for-loops

There are some good uses of hasOwnProperty checks, but in for-loops
they only make sense if the object in question is not a plain
object (eg. class instance) and the code in question is explicitly
interested in instance properties. This is rare, but one example
exists in mediawiki.Uri, where it clones an instance by copying
properties from another instance.

Anywhere a plain object is looped over, the check is redundant
because Object.prototype has no enumerable own properties.

Both jQuery and ResourceLoader do not support environments
that alter Object.prototype to be that way, and the majority
of our for-loops actually already didn't have this check.

This commit removes the few hasOwnProperty checks that still
existed on for-loops over plain objects.

Side-note: jQuery.each() does an unfiltered for-loop, which means
           it too does not perform hasOwnProperty checks.

Change-Id: Ib5e5a04a5a8e21ab62b4e779117077ea5b0f8a47

3 years agobuild: Enable and make pass no-prototype-builtins
James D. Forrester [Fri, 6 Jul 2018 00:36:01 +0000 (17:36 -0700)]
build: Enable and make pass no-prototype-builtins

Change-Id: I26a98be16c005c1c864ec592e1a41b44943f8f29

3 years agobuild: Upgrade eslint to 5.x
James D. Forrester [Tue, 3 Jul 2018 22:22:32 +0000 (15:22 -0700)]
build: Upgrade eslint to 5.x

Add two exceptions for max-len and no-prototype-builtins.

Change-Id: I5d3f7a3e282a237fb5de9f0eb29b579a08c32652

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 5 Jul 2018 19:53:52 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I75564eab47b421513de065554c8351feb02c92fa

3 years agoMerge "Changing the default for $wgPageCreationLog to true"
jenkins-bot [Thu, 5 Jul 2018 19:11:12 +0000 (19:11 +0000)]
Merge "Changing the default for $wgPageCreationLog to true"

3 years agoAvoid duplicate IDs on Special:Preferences
Bartosz Dziewoński [Thu, 5 Jul 2018 18:35:03 +0000 (20:35 +0200)]
Avoid duplicate IDs on Special:Preferences

The value of the 'section' parameter is used to generate some ID
attributes on Special:Preferences. Awkwardly, only the second part
(after the slash) is used, so have to ensure these are unique.

It is also used for the default localisation message for the title of
the section. Override this so that we don't have to rename and
duplicate the messages.

Bug: T198875
Change-Id: I0f22aafc8b2ad860dd42c5373eafdf88e848e3ad

3 years agoMerge "Remove $wgBrowserBlacklist setting (deprecated, no-op)"
jenkins-bot [Thu, 5 Jul 2018 16:08:47 +0000 (16:08 +0000)]
Merge "Remove $wgBrowserBlacklist setting (deprecated, no-op)"

3 years agoUse consistent caching strategy in Revision storage classes
daniel [Tue, 3 Jul 2018 15:46:30 +0000 (17:46 +0200)]
Use consistent caching strategy in Revision storage classes

DEPLOYMENT: This changes the cache key for revision
content blobs. Expect a brief rise in ExternalStore hits.

Bug: T198704
Change-Id: Icc2d16bc5a1e27ba4caea49a784ba7aeac15042a

3 years agoMerge "Append new line character to output of populateChangeTagDef.php"
jenkins-bot [Thu, 5 Jul 2018 15:27:02 +0000 (15:27 +0000)]
Merge "Append new line character to output of populateChangeTagDef.php"

3 years agoMerge "Release note for getLaggedSlaveMode() removal"
jenkins-bot [Thu, 5 Jul 2018 15:11:57 +0000 (15:11 +0000)]
Merge "Release note for getLaggedSlaveMode() removal"

3 years agoAppend new line character to output of populateChangeTagDef.php
Amir Sarabadani [Thu, 5 Jul 2018 15:11:29 +0000 (17:11 +0200)]
Append new line character to output of populateChangeTagDef.php

Right now, I run it in prod and it's basically useless

Change-Id: Ieb11884c3e9243df3058118cf2d581e715892595

3 years agoMerge "Revert "Introduce RevisionStoreFactory & Tests""
jenkins-bot [Thu, 5 Jul 2018 15:08:36 +0000 (15:08 +0000)]
Merge "Revert "Introduce RevisionStoreFactory & Tests""

3 years agoRelease note for getLaggedSlaveMode() removal
Antoine Musso [Thu, 5 Jul 2018 14:44:33 +0000 (16:44 +0200)]
Release note for getLaggedSlaveMode() removal

Wikimedia\Rdbms\LoadBalancer::getLaggedSlaveMode() has been removed by
19b71ac216b33e4864f8e912817ace022b179bac  it has been deprecated since
1.28.

Add a release note entry for 1.32.

Change-Id: Ifd7190ac65da5a3c613a514d2380ee62fda733e7

3 years agordbms: add resolveDomainID() method to LBFactory/LoadBalancer
Aaron Schulz [Thu, 5 Jul 2018 12:50:57 +0000 (13:50 +0100)]
rdbms: add resolveDomainID() method to LBFactory/LoadBalancer

Also add LBFactory::getLocalDomainID to match the one in LoadBalancer

Change-Id: Ia31f0800bd3b692194c08b1eab9cfb2f43679c7a

3 years agoMerge "Add support for extra database connections in unit tests."
jenkins-bot [Thu, 5 Jul 2018 11:05:12 +0000 (11:05 +0000)]
Merge "Add support for extra database connections in unit tests."

3 years agoMerge "Remove outdated transition code"
jenkins-bot [Thu, 5 Jul 2018 11:05:07 +0000 (11:05 +0000)]
Merge "Remove outdated transition code"

3 years agoRemove outdated transition code
Adam Wight [Wed, 4 Jul 2018 22:45:09 +0000 (00:45 +0200)]
Remove outdated transition code

This was a soft transition left over from when "edittime" was the last
form parameter. It has been replaced with an explicit "ultimate" param.

Change-Id: I28767fdf8fab512830fe6e24cacabb598d7cca90

3 years agoMerge "Limit the number of cached languages in MessageCache via MapCacheLRU"
jenkins-bot [Wed, 4 Jul 2018 22:18:08 +0000 (22:18 +0000)]
Merge "Limit the number of cached languages in MessageCache via MapCacheLRU"

3 years agoRemove $wgBrowserBlacklist setting (deprecated, no-op)
Timo Tijhof [Wed, 4 Jul 2018 02:36:13 +0000 (19:36 -0700)]
Remove $wgBrowserBlacklist setting (deprecated, no-op)

Not used in Wikimedia Git nor elsewhere in Codesearch.

Is a deprecated no-op since 1.30.

Change-Id: If796e77e49cd42f66aa401c6d256b9e4a9826fbd

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 4 Jul 2018 19:53:37 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie56758895fb4a1d83a0dc372463df7907f07b08c

3 years agoAdd support for extra database connections in unit tests.
daniel [Wed, 4 Jul 2018 15:20:31 +0000 (17:20 +0200)]
Add support for extra database connections in unit tests.

This adds a way to take any connection to the wiki database and
allow it to be used for unit tests.

This is needed to test code that requires two independent DB
connections, to the same database or to a different wiki's database.

Change-Id: I0b84a0c4d174cbde830786028ee7568c4ea9fb5d

3 years agoFix CONCAT assertions in some MCR tests
Aaron Schulz [Wed, 4 Jul 2018 07:20:53 +0000 (08:20 +0100)]
Fix CONCAT assertions in some MCR tests

Change-Id: I9507ae60751f8e9cc5e6205148cf2e37f67f42c5

3 years agoMerge "mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars"
jenkins-bot [Wed, 4 Jul 2018 02:00:58 +0000 (02:00 +0000)]
Merge "mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars"

3 years agoMerge "Add missing use statements"
jenkins-bot [Wed, 4 Jul 2018 00:44:28 +0000 (00:44 +0000)]
Merge "Add missing use statements"

3 years agomw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars
Bartosz Dziewoński [Mon, 2 Jul 2018 23:20:47 +0000 (01:20 +0200)]
mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars

Change-Id: Ie3b246fcb064a04bc90fec06f6285306a013a819

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 3 Jul 2018 19:54:37 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I3aa4ab1da349c15c6fb33c323324119aa352eff8

3 years agoSync up with Parsoid parserTests.txt
Arlo Breault [Tue, 3 Jul 2018 19:02:26 +0000 (15:02 -0400)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit bbc56abd8fcc245876fc340723ed3431565b61d1

Change-Id: I463401aa3d2dd290d5ba6813e8e869f713682dd3

3 years agoMerge "Fix error in various deprecated selectFields() methods"
jenkins-bot [Tue, 3 Jul 2018 17:20:34 +0000 (17:20 +0000)]
Merge "Fix error in various deprecated selectFields() methods"

3 years agoMerge "Remove deprecated CONN_TRX_AUTO alias"
jenkins-bot [Tue, 3 Jul 2018 17:08:02 +0000 (17:08 +0000)]
Merge "Remove deprecated CONN_TRX_AUTO alias"

3 years agoMerge "Hard deprecate wfBCP47, which was soft deprecated in 1.31"
jenkins-bot [Tue, 3 Jul 2018 16:29:57 +0000 (16:29 +0000)]
Merge "Hard deprecate wfBCP47, which was soft deprecated in 1.31"

3 years agoFix error in various deprecated selectFields() methods
Brad Jorsch [Tue, 3 Jul 2018 15:59:18 +0000 (11:59 -0400)]
Fix error in various deprecated selectFields() methods

When aliasing a field to null, it has to be aliased to the string 'NULL'
rather than PHP null.

Bug: T198687
Change-Id: I6096f306b97022da781eaabeb15e502f391673a9

3 years agoMerge "build: Set Travis conf to "allow failure" for long-failing builds"
jenkins-bot [Tue, 3 Jul 2018 15:37:45 +0000 (15:37 +0000)]
Merge "build: Set Travis conf to "allow failure" for long-failing builds"

3 years agoMerge "Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias"
jenkins-bot [Tue, 3 Jul 2018 15:01:03 +0000 (15:01 +0000)]
Merge "Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias"

3 years agoHard deprecate wfBCP47, which was soft deprecated in 1.31
C. Scott Ananian [Tue, 26 Jun 2018 18:11:59 +0000 (14:11 -0400)]
Hard deprecate wfBCP47, which was soft deprecated in 1.31

Change-Id: I8632f08a8cb22641b5d16d955f3164dc45843520

3 years agoRevert "Introduce RevisionStoreFactory & Tests"
Addshore [Tue, 3 Jul 2018 11:49:24 +0000 (11:49 +0000)]
Revert "Introduce RevisionStoreFactory & Tests"

This needs more work, I'll file some tickets with TODOs

This reverts commit eb39d5f945245d65c0f5e44466c6d616b62577f5.

Change-Id: I0678d0c4e4e7496a67dfe826b00246723e9c7d54

3 years agoMerge "mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty"
jenkins-bot [Tue, 3 Jul 2018 13:06:35 +0000 (13:06 +0000)]
Merge "mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty"

3 years agoRemove deprecated CONN_TRX_AUTO alias
Aaron Schulz [Tue, 3 Jul 2018 12:03:55 +0000 (13:03 +0100)]
Remove deprecated CONN_TRX_AUTO alias

Change-Id: I0bc9b89e998cd3b324f9c72507d40a473bfb6118

3 years agoUse CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias
Aaron Schulz [Tue, 3 Jul 2018 12:03:44 +0000 (13:03 +0100)]
Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias

Change-Id: I23dc7052bd1ca9a9c8fec2409f3067304745043a

3 years agoMerge "RESTBagOStuff: improve timeouts and logging"
jenkins-bot [Tue, 3 Jul 2018 11:18:43 +0000 (11:18 +0000)]
Merge "RESTBagOStuff: improve timeouts and logging"

3 years agoMerge "resourceloader: Simplify ResourceLoader::isFileModule()"
jenkins-bot [Tue, 3 Jul 2018 11:12:11 +0000 (11:12 +0000)]
Merge "resourceloader: Simplify ResourceLoader::isFileModule()"

3 years agoLimit the number of cached languages in MessageCache via MapCacheLRU
Aaron Schulz [Mon, 25 Jun 2018 09:45:55 +0000 (10:45 +0100)]
Limit the number of cached languages in MessageCache via MapCacheLRU

Change-Id: I37a128cfc553e0edaab524098461776cec3fe08a

3 years agoMerge "Add MediaWikiService::getPerDbNameStatsdDataFactory"
jenkins-bot [Tue, 3 Jul 2018 07:58:40 +0000 (07:58 +0000)]
Merge "Add MediaWikiService::getPerDbNameStatsdDataFactory"

3 years agoMerge "rdbms: fix Sqlite::tableExists() method to avoid STATUS_TRX_ERROR"
jenkins-bot [Tue, 3 Jul 2018 05:40:03 +0000 (05:40 +0000)]
Merge "rdbms: fix Sqlite::tableExists() method to avoid STATUS_TRX_ERROR"

3 years agobuild: Set Travis conf to "allow failure" for long-failing builds
Timo Tijhof [Tue, 3 Jul 2018 01:08:02 +0000 (18:08 -0700)]
build: Set Travis conf to "allow failure" for long-failing builds

Specifically, PHP 7.2, postgres and all HHVM builds have been
failing for at least a month or more. In order for notifications
to become useful, whitelist these for now, so that next time
the main MySQL/PHP 7.0 or PHP 7.1 build failes, we'll notice
sooner.

Also move the notifs back to #wikimedia-dev and make it match
the configuration of other repos that use Travis via GitHub
(such as CSSJanus), specifically, to use a message template
that spans only a single line, instead of the default which
spans several lines.

Change-Id: I3abbff51414d33cde34cca26896724e8999c32db

3 years agoresourceloader: Simplify ResourceLoader::isFileModule()
Timo Tijhof [Tue, 3 Jul 2018 01:04:31 +0000 (18:04 -0700)]
resourceloader: Simplify ResourceLoader::isFileModule()

Method already has 100% test coverage.

Change-Id: I695e0ecca7a749e1721e489007f3b9f99358a96b

3 years agoMerge "RC Filters: Avoid unnecessary update events when clearing highlight"
jenkins-bot [Mon, 2 Jul 2018 22:36:47 +0000 (22:36 +0000)]
Merge "RC Filters: Avoid unnecessary update events when clearing highlight"

3 years agoMerge "RC Filters: Lazy build menu on model initialization"
jenkins-bot [Mon, 2 Jul 2018 22:33:30 +0000 (22:33 +0000)]
Merge "RC Filters: Lazy build menu on model initialization"

3 years agoshell: Note that ::isDisabled() should be called before ::command()
Kunal Mehta [Sun, 24 Jun 2018 21:09:32 +0000 (00:09 +0300)]
shell: Note that ::isDisabled() should be called before ::command()

And check it in the FirejailCommandTest (integration) for completeness,
even though it will make no practical difference.

Change-Id: Ieb130a888ef8a8162cb0a049ab9c20eac3f58217

3 years agoMaintenance: Don't try shelling out if it's disabled
Kunal Mehta [Sun, 24 Jun 2018 21:07:42 +0000 (00:07 +0300)]
Maintenance: Don't try shelling out if it's disabled

Change-Id: Ib30c55aa9e048960f8fa66a41f7e2aa2fa03b253

3 years agoMerge "Prevent fatal error when {{#translation:}} is placed on subpage named code"
jenkins-bot [Mon, 2 Jul 2018 21:53:10 +0000 (21:53 +0000)]
Merge "Prevent fatal error when {{#translation:}} is placed on subpage named code"

3 years agoMerge "Special:Preferences: Replace OOUI preferences CSS by LESS file"
jenkins-bot [Mon, 2 Jul 2018 21:49:46 +0000 (21:49 +0000)]
Merge "Special:Preferences: Replace OOUI preferences CSS by LESS file"

3 years agoMerge "Special:Preferences: Improve section grouping"
jenkins-bot [Mon, 2 Jul 2018 21:47:58 +0000 (21:47 +0000)]
Merge "Special:Preferences: Improve section grouping"

3 years agoDeprecate string type for $lang of DifferenceEngine::setTextLanguage
Fomafix [Tue, 19 Jun 2018 19:37:17 +0000 (21:37 +0200)]
Deprecate string type for $lang of DifferenceEngine::setTextLanguage

Also move the comment about the default value from the setter to the
getter.

Change-Id: I2e1bd29db986dfa92d41a876340a6aa59ac6670d
Depends-On: I8b573866c2de9b21d3849f02269c1b9ca4f62aba

3 years agoRC Filters: Lazy build menu on model initialization
Kosta Harlan [Sat, 30 Jun 2018 16:30:23 +0000 (12:30 -0400)]
RC Filters: Lazy build menu on model initialization

Use setTimeout() on model initialization to build the menu as part of the
page load process to remove the perceptible delay on the first click of the
menu.

Bug: T198535
Change-Id: Icaf0a37444786e80536b680fa37d04d095091377

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 2 Jul 2018 19:54:08 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I8dd1dd52e3e29ae52591624bff32b8a0375afc3a

3 years agoMerge "RC Filters: Prevent updateIfHeightChanged on tag multiselect widget"
jenkins-bot [Mon, 2 Jul 2018 19:47:18 +0000 (19:47 +0000)]
Merge "RC Filters: Prevent updateIfHeightChanged on tag multiselect widget"

3 years agoChanging the default for $wgPageCreationLog to true
Kaldari [Sun, 1 Jul 2018 04:36:11 +0000 (21:36 -0700)]
Changing the default for $wgPageCreationLog to true

It's already been turned on for all WMF wikis except Commons and
Wikidata, which are explicitly set to false in the configs.

Bug: T196400
Change-Id: Ib98ed68165837db8f53473052d5edec4af3736d9

3 years agoAllow extra slots in write-both/read-new mode.
daniel [Thu, 28 Jun 2018 18:32:03 +0000 (20:32 +0200)]
Allow extra slots in write-both/read-new mode.

Bug: T198413
Change-Id: I3125d5c7ef8d12936d4332cd1602f2eaab2482b2

3 years agoAdd MediaWikiService::getPerDbNameStatsdDataFactory
addshore [Mon, 2 Jul 2018 17:01:45 +0000 (18:01 +0100)]
Add MediaWikiService::getPerDbNameStatsdDataFactory

Bug: T196609
Change-Id: I08a4909e2855e33569641166b77be5d8bf4e2c34

3 years agoMerge "Use array_merge to merge indexed arrays in categoryChangesAsRdf.php."
jenkins-bot [Mon, 2 Jul 2018 17:23:04 +0000 (17:23 +0000)]
Merge "Use array_merge to merge indexed arrays in categoryChangesAsRdf.php."

3 years agoRC Filters: Avoid unnecessary update events when clearing highlight
Kosta Harlan [Fri, 29 Jun 2018 18:58:03 +0000 (14:58 -0400)]
RC Filters: Avoid unnecessary update events when clearing highlight

The strict equality check just below the lines added in this commit will fail
if the Item's highlightColor is null/undefined, and if the incoming parameter
is null. This situation happens when
mw.rcfilters.dm.ItemModel.prototype.clearHighlightColor is called when updating
the state from the query parameters. By returning early we can avoid emitting
update events for every filter item.

Bug: T198359
Change-Id: Ia3e5f333964545c7f33777be915389728c03eace

3 years agoUse array_merge to merge indexed arrays in categoryChangesAsRdf.php.
daniel [Mon, 2 Jul 2018 15:43:41 +0000 (17:43 +0200)]
Use array_merge to merge indexed arrays in categoryChangesAsRdf.php.

Bug: T198356
Change-Id: Ic29568ecfc26da7e6d8c9a875232bfa4e0f9f380

3 years agoIntroduce new schema flags and use them in RevisionStore.
daniel [Tue, 26 Jun 2018 17:26:33 +0000 (19:26 +0200)]
Introduce new schema flags and use them in RevisionStore.

NOTE: this changes the numeric values of the MIGRATION_XXX constants!
Order is preserved.

Bug: T197619
Change-Id: I16db7dd5799ab98c1cb12e7cd1e0b2da83b366fc

3 years agoPrevent fatal error when {{#translation:}} is placed on subpage named code
Niklas Laxström [Mon, 2 Jul 2018 09:30:52 +0000 (11:30 +0200)]
Prevent fatal error when {{#translation:}} is placed on subpage named code

Bug: T198518
Change-Id: Ia202e78adc53a54f95597b8701304c7f3832bf9c