lhc/web/wiklou.git
2 years agoMerge "REST: Properly handle HEAD requests"
jenkins-bot [Tue, 17 Sep 2019 18:57:18 +0000 (18:57 +0000)]
Merge "REST: Properly handle HEAD requests"

2 years agoMerge "Use TextFormatter in the REST API"
jenkins-bot [Tue, 17 Sep 2019 18:57:09 +0000 (18:57 +0000)]
Merge "Use TextFormatter in the REST API"

2 years agowdio-mediawiki: update signatures in README.md
Lucas Werkmeister [Tue, 17 Sep 2019 16:03:38 +0000 (18:03 +0200)]
wdio-mediawiki: update signatures in README.md

Add parameter types everywhere, and mark the parameters of blockUser and
unblockUser as optional.

Change-Id: I4713fed9f073801333796d974fff9d2d7059d1f0

2 years agoMerge "Allow logging arbitrary extra data in MWExceptionHandler::logException"
jenkins-bot [Tue, 17 Sep 2019 12:54:18 +0000 (12:54 +0000)]
Merge "Allow logging arbitrary extra data in MWExceptionHandler::logException"

2 years agoMerge "Make WatchedItemQueryService depend on PermissionManager"
jenkins-bot [Tue, 17 Sep 2019 10:11:26 +0000 (10:11 +0000)]
Merge "Make WatchedItemQueryService depend on PermissionManager"

2 years agoDeprecate `$wgSysopEmailBans`
DannyS712 [Thu, 5 Sep 2019 22:57:06 +0000 (22:57 +0000)]
Deprecate `$wgSysopEmailBans`

Bug: T232169
Change-Id: Iba2493eb2f49d32c5aa1b4da53c9c221847fb125

2 years agoMergeHistory: Update revactor_page too
Brad Jorsch [Tue, 10 Sep 2019 15:24:24 +0000 (11:24 -0400)]
MergeHistory: Update revactor_page too

When using MergeHistory, we need to update the denormalized
revision_actor_temp.revactor_page to match the update we do for
revision.rev_page.

Also, we need a maintenance script to clean up the rows that were broken
by our failure to do that before.

Bug: T232464
Change-Id: Ib819a9d9fc978d75d7cc7e53f361483b69ab8020

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 17 Sep 2019 06:23:10 +0000 (08:23 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5c4e2bd9d76c70622b408f870ac11af9739dad73

2 years agoREST: Properly handle HEAD requests
Tim Starling [Tue, 10 Sep 2019 06:26:53 +0000 (16:26 +1000)]
REST: Properly handle HEAD requests

Just handle a HEAD request as a GET request, if no specific HEAD handler
exists. This is simple and similar to what the rest of MediaWiki does in
response to a HEAD request.

Bug: T226043
Change-Id: I7b2bd657c20b56844459874131a3d85fabe7db3d

2 years agoUse TextFormatter in the REST API
Tim Starling [Tue, 16 Jul 2019 22:43:43 +0000 (08:43 +1000)]
Use TextFormatter in the REST API

* Add ResponseFactory::createLocalizedHttpError(), which generates a
  JSON response body from a MessageValue
* ResponseFactory::__construct() accepts an array of TextFormatter
  objects. For ease of testing, the array may be empty. The integrated
  ResponseFactory has a TextFormatter for English, and one for
  $wgContLang if that is different.
* Use createLocalizedHttpError() to show helpful error messages for
  errors generated by Router.

Change-Id: I897a0aee42227916c568333ab384966f1b87f599

2 years agoMerge "Standardise preview warning box when using ?action=edit"
jenkins-bot [Tue, 17 Sep 2019 02:06:54 +0000 (02:06 +0000)]
Merge "Standardise preview warning box when using ?action=edit"

2 years agoMerge "BaseTemplate: Hard-deprecate msgWiki()"
jenkins-bot [Tue, 17 Sep 2019 01:59:13 +0000 (01:59 +0000)]
Merge "BaseTemplate: Hard-deprecate msgWiki()"

2 years agoMerge "Bump PHP version requirement to 7.2.0+"
jenkins-bot [Tue, 17 Sep 2019 01:39:02 +0000 (01:39 +0000)]
Merge "Bump PHP version requirement to 7.2.0+"

2 years agoBump PHP version requirement to 7.2.0+
James D. Forrester [Thu, 13 Jun 2019 18:53:16 +0000 (11:53 -0700)]
Bump PHP version requirement to 7.2.0+

Bug: T216165
Bug: T216166
Change-Id: I99e45c2a8fd1512a76a42ce978cb96f39ee2456e

2 years agoMerge "services: Do not use deprecated ReflectionType::__toString() in tests"
jenkins-bot [Tue, 17 Sep 2019 00:40:49 +0000 (00:40 +0000)]
Merge "services: Do not use deprecated ReflectionType::__toString() in tests"

2 years agoMerge "SectionProfiler: Do not attempt to use null values as arrays"
jenkins-bot [Mon, 16 Sep 2019 23:37:17 +0000 (23:37 +0000)]
Merge "SectionProfiler: Do not attempt to use null values as arrays"

2 years agoMerge "Title::getTalkPage(): Restore behavior of interwiki-prefixed & fragment-only...
jenkins-bot [Mon, 16 Sep 2019 23:16:16 +0000 (23:16 +0000)]
Merge "Title::getTalkPage(): Restore behavior of interwiki-prefixed & fragment-only titles"

2 years agoMerge "Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result"
jenkins-bot [Mon, 16 Sep 2019 22:47:52 +0000 (22:47 +0000)]
Merge "Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result"

2 years agoMerge "wdio-mediawiki: extract bot() function"
jenkins-bot [Mon, 16 Sep 2019 22:47:41 +0000 (22:47 +0000)]
Merge "wdio-mediawiki: extract bot() function"

2 years agoMerge "Chinese Conversion Table Update 2019-3"
jenkins-bot [Mon, 16 Sep 2019 21:06:05 +0000 (21:06 +0000)]
Merge "Chinese Conversion Table Update 2019-3"

2 years agoMerge "mediawiki.page.ready: Avoid duplicate DOM query on logout click"
jenkins-bot [Mon, 16 Sep 2019 20:28:05 +0000 (20:28 +0000)]
Merge "mediawiki.page.ready: Avoid duplicate DOM query on logout click"

2 years agoMerge "mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick"
jenkins-bot [Mon, 16 Sep 2019 20:27:59 +0000 (20:27 +0000)]
Merge "mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick"

2 years agoSectionProfiler: Do not attempt to use null values as arrays
Máté Szabó [Mon, 16 Sep 2019 19:30:47 +0000 (21:30 +0200)]
SectionProfiler: Do not attempt to use null values as arrays

When SectionProfiler::getFunctionStats() is called, the 'start'
and 'end' member variables may be null if no code called the
scopedProfileIn()/scopedProfileOut() methods on this profiler instance.
This can occur, for instance, when generating the parser limit report
for wikitext that did not include expensive parser functions.

In PHP 7.4, attemping to use a null value as an array generates
a PHP Notice.[1] This patch adds a check to SectionProfiler::getFunctionStats
to verify that the 'start' value is an array before attempting to
access its keys.

---
[1] https://github.com/php/php-src/blob/php-7.4.0RC1/UPGRADING#L25

Bug: T233012
Change-Id: I2d35bfddfcc4c194aa71265e40387f2f2914e3a5

2 years agoservices: Do not use deprecated ReflectionType::__toString() in tests
Máté Szabó [Mon, 16 Sep 2019 19:14:07 +0000 (21:14 +0200)]
services: Do not use deprecated ReflectionType::__toString() in tests

The \MediaWikiServicesTest::provideGetService() PHPUnit data provider
method uses the ReflectionType::__toString() method to obtain the
return type of service instantiator callables as a string.

In PHP 7.4, calling this method generates an E_DEPRECATED notice.
The solution is to use ReflectionType::getName() instead, available
since PHP 7.1.[1]

This patch updates the method to use ReflectionType::getName()
if it is available, and fall back to ReflectionType::__toString()
otherwise.

---
[1] https://github.com/php/php-src/blob/php-7.4.0RC1/UPGRADING#L395

Bug: T233012
Change-Id: I69b97f75795e6c4e005bf1a23fb798f7e52da2fd

2 years agoMerge "Update old URLs in DefaultSettings related to Squid caching"
jenkins-bot [Mon, 16 Sep 2019 18:34:31 +0000 (18:34 +0000)]
Merge "Update old URLs in DefaultSettings related to Squid caching"

2 years agowdio-mediawiki: extract bot() function
Lucas Werkmeister [Mon, 16 Sep 2019 14:36:13 +0000 (16:36 +0200)]
wdio-mediawiki: extract bot() function

This functionality was previously copy+pasted for most other methods,
and is also useful externally, to make API requests that are not covered
by other methods in Api.js.

createAccount() needs a different type of token, so for now we leave it
alone. (Perhaps the token type could become a parameter of bot() later?)

Change-Id: Ica24213a1f0d651bfc3fbffe24b63251a4841658

2 years agoMake WatchedItemQueryService depend on PermissionManager
Petr Pchelko [Fri, 13 Sep 2019 20:39:50 +0000 (13:39 -0700)]
Make WatchedItemQueryService depend on PermissionManager

Bug: T220191
Change-Id: I714d2b33b83dab230a8168765d5523cb14971371

2 years agoChinese Conversion Table Update 2019-3
Chiefwei [Mon, 16 Sep 2019 14:30:52 +0000 (22:30 +0800)]
Chinese Conversion Table Update 2019-3

Update the Chinese conversion table routinely to fix bugs reported from https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .

It is only data changes and only works for Chinese WikiProjects.

Change-Id: Iaed40e230bd7be0656af3b24837e870743c84700

2 years agoNote in `Createacct-reason` that the reason provided is publicly visible
DannyS712 [Sun, 21 Jul 2019 22:51:25 +0000 (22:51 +0000)]
Note in `Createacct-reason` that the reason provided is publicly visible

Bug: T211732
Change-Id: Idb3a354dd7b2425bcde1f85382481f7af5ca3080

2 years agoMerge "objectcache: remove references to recently removed methods"
jenkins-bot [Mon, 16 Sep 2019 09:15:37 +0000 (09:15 +0000)]
Merge "objectcache: remove references to recently removed methods"

2 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 16 Sep 2019 07:08:56 +0000 (09:08 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic665f6f2f3f9ee34f2447d74e4c7c890b5ad0710

2 years agoobjectcache: remove references to recently removed methods
Aaron Schulz [Sun, 15 Sep 2019 20:52:07 +0000 (13:52 -0700)]
objectcache: remove references to recently removed methods

Follow-up to 9d5e3f56d55c81e

Change-Id: Idca42b5ca405c31953a516aa3f96cf64cc0e0a12

2 years agoMerge "resourceloader: Add Doxygen group and improve overall docs"
jenkins-bot [Sun, 15 Sep 2019 19:58:46 +0000 (19:58 +0000)]
Merge "resourceloader: Add Doxygen group and improve overall docs"

2 years agoMerge "OutputPage: Add visibility to various methods & do some micro-optimizations"
jenkins-bot [Sun, 15 Sep 2019 16:41:21 +0000 (16:41 +0000)]
Merge "OutputPage: Add visibility to various methods & do some micro-optimizations"

2 years agoMerge "Update docblocks for methods potentially returning null"
jenkins-bot [Sun, 15 Sep 2019 16:27:34 +0000 (16:27 +0000)]
Merge "Update docblocks for methods potentially returning null"

2 years agoOutputPage: Add visibility to various methods & do some micro-optimizations
Derick Alangi [Sat, 14 Sep 2019 10:26:31 +0000 (11:26 +0100)]
OutputPage: Add visibility to various methods & do some micro-optimizations

Methods that visibility was added to are; `addMeta()`, `addLink()`,
`setCanonicalUrl()`, `addScript()`, `getHeadItemsArray()`, `addParserOutput()`,
`getCacheVaryCookies()` and `haveCacheVaryCookies()`. Last but not lease, did
a few micro-optimizations to `addMeta()` and `addLink()`.

Change-Id: I94d037a5edc7131627724fd1d864000128077b0c

2 years agoUpdate docblocks for methods potentially returning null
Daimona Eaytoy [Sun, 15 Sep 2019 13:22:08 +0000 (15:22 +0200)]
Update docblocks for methods potentially returning null

These were discovered by setting `null_casts_as_any_type` to true in
phan, and filtering by `PhanTypeMismatchReturnNullable`. Of course there
are others, some of which are false positives, but we cannot suppress
them now (or the UnusedSuppressionPlugin will complain).

Change-Id: Ia8443e575c22f47a6d8c63038f4e7ac36815fc27

2 years agoRemove getMainWANInstance and getMainStashInstance functions
Zoranzoki21 [Sun, 15 Sep 2019 12:55:47 +0000 (14:55 +0200)]
Remove getMainWANInstance and getMainStashInstance functions
from ObjectCache as they were deprecated in 1.28

Change-Id: I133470a1c69c836f38b1ae5fecc05e50b70f4457

2 years agoMerge "actions: Rename Doxygen group from "Action done on pages" to "Actions""
jenkins-bot [Sun, 15 Sep 2019 10:19:23 +0000 (10:19 +0000)]
Merge "actions: Rename Doxygen group from "Action done on pages" to "Actions""

2 years agoMerge "phan: Disable enable_class_alias_support"
jenkins-bot [Sun, 15 Sep 2019 08:51:29 +0000 (08:51 +0000)]
Merge "phan: Disable enable_class_alias_support"

2 years agophan: Disable enable_class_alias_support
Umherirrender [Thu, 12 Sep 2019 19:40:57 +0000 (21:40 +0200)]
phan: Disable enable_class_alias_support

It is enabled for b/c in extensions, but not needed in core

Change-Id: I51dca12be9c77049f77563d9bf0edd07928c2300

2 years agoMerge "Revision: Inject Logger instead of LoggerSpi"
jenkins-bot [Sun, 15 Sep 2019 06:59:15 +0000 (06:59 +0000)]
Merge "Revision: Inject Logger instead of LoggerSpi"

2 years agoMerge "Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'"
jenkins-bot [Sat, 14 Sep 2019 23:54:48 +0000 (23:54 +0000)]
Merge "Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'"

2 years agomediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick
Timo Tijhof [Sat, 14 Sep 2019 01:00:55 +0000 (02:00 +0100)]
mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick

* Remove redundant closures around the two files.

* Export checkboxShiftClick as a regular function.
  This jQuery plugin is not used anywhere in Wikimedia Gerrit,
  nor elsewhere indexed by Codesearch, nor anywhere on-wiki
  in User, Project or MediaWiki namespaces.
  As such, remove the deprecated module alias as well.

Change-Id: I6bc41036829964080abf1ab0bbd306356bb8fe57

2 years agomediawiki.page.ready: Avoid duplicate DOM query on logout click
Timo Tijhof [Sat, 14 Sep 2019 02:19:46 +0000 (03:19 +0100)]
mediawiki.page.ready: Avoid duplicate DOM query on logout click

The result of this DOM selector query is already available
as 'this' given we're in an event handler, use that directly
instead.

Also:
* Use the 'href' property directly instead of using jQuery or attributes.
* Avoid shadow names by naming the error handler param 'err' instead
  of 'e'.

Change-Id: I94a757ca1dd782b1e138a372983b6bfa16081485

2 years agoIntegrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'
Fomafix [Fri, 13 Sep 2019 08:08:20 +0000 (10:08 +0200)]
Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready'

This reduces the number of modules.

Bug: T232688
Change-Id: Id63592d8f674b994adccf5f7f6bbda50d84d0edb

2 years agoUpdate old URLs in DefaultSettings related to Squid caching
Thalia [Sat, 14 Sep 2019 21:30:16 +0000 (22:30 +0100)]
Update old URLs in DefaultSettings related to Squid caching

Change-Id: Ic94fd638a80fcdc74f42c726f2e2e256b8f0c04d

2 years agoMerge "Fix a typo (folow -> follow)"
jenkins-bot [Sat, 14 Sep 2019 21:09:06 +0000 (21:09 +0000)]
Merge "Fix a typo (folow -> follow)"

2 years agoMerge "Log DNS blacklist matches with info level, non-matches with debug level"
jenkins-bot [Sat, 14 Sep 2019 20:16:10 +0000 (20:16 +0000)]
Merge "Log DNS blacklist matches with info level, non-matches with debug level"

2 years agoChangesListSpecialPage: Cache the change tag list and its summary
Roan Kattouw [Sat, 27 Jul 2019 02:25:28 +0000 (19:25 -0700)]
ChangesListSpecialPage: Cache the change tag list and its summary

Even though we don't parse messages in the summary callback, the startup
module still spends 29% of its time building the change tag list
summary. Let's put the whole thing behind a 24-hour cache until we
figure out something better.

Bug: T223260
Change-Id: If145ef21159f3702895e5ecafeedd05d00a79de4

2 years agoMerge "Make doTestLockCalls() faster"
jenkins-bot [Sat, 14 Sep 2019 18:53:15 +0000 (18:53 +0000)]
Merge "Make doTestLockCalls() faster"

2 years agoresourceloader: Add Doxygen group and improve overall docs
Timo Tijhof [Sat, 14 Sep 2019 04:32:54 +0000 (05:32 +0100)]
resourceloader: Add Doxygen group and improve overall docs

* Add license header where missing.
* Add missing `@since` (1.17 for most classes), except
  ResourceLoaderLessVarFileModule since 1.32 (1bc62c548c).

* Remove duplicate file-level description for class-only files,
  merge with the class description instead.

* Remove my own `@author` annotation from one file.

* Mark core's own FileModule subclasses as `@internal`, except
  for the following which we support use of in extensions:
  ResourceLoaderLessVarFileModule,
  ResourceLoaderOOUIIconPackModule, and
  ResourceLoaderWikiModule.

Change-Id: I336af2e4ccdbe2512594e8861b72628d24194e41

2 years agoLog DNS blacklist matches with info level, non-matches with debug level
Martin Urbanec [Tue, 20 Aug 2019 17:29:59 +0000 (19:29 +0200)]
Log DNS blacklist matches with info level, non-matches with debug level

Bug: T230822
Change-Id: I036b38ac322181fdba4e9e6c1ff539f79b5bb79c

2 years agoMerge "Suppress PhanUndeclaredProperty for custom properties and phan bugs"
jenkins-bot [Sat, 14 Sep 2019 15:53:31 +0000 (15:53 +0000)]
Merge "Suppress PhanUndeclaredProperty for custom properties and phan bugs"

2 years agoMerge "Declare dynamic properties"
jenkins-bot [Sat, 14 Sep 2019 15:53:25 +0000 (15:53 +0000)]
Merge "Declare dynamic properties"

2 years agoSuppress PhanUndeclaredProperty for custom properties and phan bugs
Daimona Eaytoy [Sat, 7 Sep 2019 13:06:50 +0000 (15:06 +0200)]
Suppress PhanUndeclaredProperty for custom properties and phan bugs

And remove the issue from the exclusions list.

Bug: T231636
Change-Id: Iee73ddb554e354abe52d13dcfc453f9a15bb8877

2 years agoDeclare dynamic properties
Daimona Eaytoy [Wed, 11 Sep 2019 09:30:12 +0000 (11:30 +0200)]
Declare dynamic properties

This is for classes with a single undeclared property - aside from
BlockManager: I3f51fd3579514b83b567dfe20926df2f0930dc85 removed the
declaration of $permissionManager without actually removing all uses.

Change-Id: Ic2a95f77071312041be6e0633ea9b5325e98de42

2 years agoMerge "Remove dead code from RCCacheEntryFactory"
jenkins-bot [Sat, 14 Sep 2019 13:12:52 +0000 (13:12 +0000)]
Merge "Remove dead code from RCCacheEntryFactory"

2 years agoMerge "Change the Balinese language autonym to "Bali""
jenkins-bot [Sat, 14 Sep 2019 11:53:24 +0000 (11:53 +0000)]
Merge "Change the Balinese language autonym to "Bali""

2 years agoMake doTestLockCalls() faster
Aaron Schulz [Sat, 14 Sep 2019 05:41:10 +0000 (22:41 -0700)]
Make doTestLockCalls() faster

This was mostly doing many runs just to test for random lock errors in
versions of Windows from a few years back. Just do three quick rounds.

Change-Id: I2ec2a8ce66a5c14bfc9338b60f8a57b2de8eaece

2 years agoMerge "Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'"
jenkins-bot [Sat, 14 Sep 2019 03:50:40 +0000 (03:50 +0000)]
Merge "Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'"

2 years agoMerge "Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpda...
jenkins-bot [Sat, 14 Sep 2019 03:29:48 +0000 (03:29 +0000)]
Merge "Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates hooks were deprecated"

2 years agoMerge "API: Add missing `@ingroup API` to a few Api-related classes"
jenkins-bot [Sat, 14 Sep 2019 03:29:10 +0000 (03:29 +0000)]
Merge "API: Add missing `@ingroup API` to a few Api-related classes"

2 years agoMerge "docs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST"
jenkins-bot [Sat, 14 Sep 2019 03:29:02 +0000 (03:29 +0000)]
Merge "docs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST"

2 years agoMerge "docs: Remove aliases that are only used in tests/"
jenkins-bot [Sat, 14 Sep 2019 03:27:56 +0000 (03:27 +0000)]
Merge "docs: Remove aliases that are only used in tests/"

2 years agoMerge "Make PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one...
jenkins-bot [Sat, 14 Sep 2019 02:59:44 +0000 (02:59 +0000)]
Merge "Make PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one batch"

2 years agoStorage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'
Timo Tijhof [Sat, 14 Sep 2019 01:23:36 +0000 (02:23 +0100)]
Storage: Use a more descriptive WAN cache keyclass in 'SqlBlobStore'

In order to make statistics from WANObjectCache more useful,
each kind of key should generally have a unique first make*Key
component. This usually corresponds 1:1 to a call to make*Key,
unless the same key format is duplicated in muliple places.

In this case, change ('BlobStore', 'address', …, …)
to ('SqlBlobStore-blob', …, …).

Bug: T197849
Change-Id: Iba3ae1bf947d6f56c72df2cf3f2160d458d38c66

2 years agoMerge "StreamFile: Deprecate ::parseRange() and ::send404Message() methods"
jenkins-bot [Sat, 14 Sep 2019 01:03:47 +0000 (01:03 +0000)]
Merge "StreamFile: Deprecate ::parseRange() and ::send404Message() methods"

2 years agoMerge "filebackend: rename and simplify header sanitizing methods in SwiftFileBackend"
jenkins-bot [Sat, 14 Sep 2019 00:12:05 +0000 (00:12 +0000)]
Merge "filebackend: rename and simplify header sanitizing methods in SwiftFileBackend"

2 years agoactions: Rename Doxygen group from "Action done on pages" to "Actions"
Timo Tijhof [Fri, 13 Sep 2019 23:32:16 +0000 (00:32 +0100)]
actions: Rename Doxygen group from "Action done on pages" to "Actions"

Bug: T232104
Change-Id: Ia3b8c14bd62ac241824bce216361141adb77cc47

2 years agoAPI: Add missing `@ingroup API` to a few Api-related classes
Timo Tijhof [Fri, 13 Sep 2019 23:07:23 +0000 (00:07 +0100)]
API: Add missing `@ingroup API` to a few Api-related classes

Bug: T232104
Change-Id: Iea6714bc2f77525d6e164df37ca8f453886e3ca8

2 years agodocs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST
Timo Tijhof [Fri, 13 Sep 2019 22:57:35 +0000 (23:57 +0100)]
docs: Disable GENERATE_TESTLIST and GENERATE_BUGLIST

These are to create pages with an overview of `@bug` and `@test`
annotations of which there are none in MediaWiki core in doc block
comments, like `/**`. As far as I know, there is also no practice
or plans to start using these or to use Doxygen as a way to
organise such work (we use Phabricator instead to report things
that are broken and/or should have tests).

Bug: T232104
Change-Id: I1056f22c38b11157ac7b5a23e9838978e8901171

2 years agodocs: Remove aliases that are only used in tests/
Timo Tijhof [Fri, 13 Sep 2019 21:58:48 +0000 (22:58 +0100)]
docs: Remove aliases that are only used in tests/

Follows-up fec6692394, which excluded 'tests/' from indexing,
which means these aliases are no longer needed.

Change-Id: Ice6be877b8f526f26ef9657a335142d07428fa6e

2 years agoMerge "Remove usages of Title::get{Previous,Next}RevisionId"
jenkins-bot [Fri, 13 Sep 2019 22:58:36 +0000 (22:58 +0000)]
Merge "Remove usages of Title::get{Previous,Next}RevisionId"

2 years agoMerge "Remove User::setNewpassword()"
jenkins-bot [Fri, 13 Sep 2019 21:56:41 +0000 (21:56 +0000)]
Merge "Remove User::setNewpassword()"

2 years agoMerge "deleteLogFormatter: explicitly declare parsedParametersDeleteLog"
jenkins-bot [Fri, 13 Sep 2019 21:56:35 +0000 (21:56 +0000)]
Merge "deleteLogFormatter: explicitly declare parsedParametersDeleteLog"

2 years agoMerge "Declare dynamic properties"
jenkins-bot [Fri, 13 Sep 2019 21:49:14 +0000 (21:49 +0000)]
Merge "Declare dynamic properties"

2 years agoMerge "Make CdnCacheUpdate::expand() private and update the sole caller"
jenkins-bot [Fri, 13 Sep 2019 21:25:47 +0000 (21:25 +0000)]
Merge "Make CdnCacheUpdate::expand() private and update the sole caller"

2 years agoMerge "user: Use cached singleton instance variable"
jenkins-bot [Fri, 13 Sep 2019 21:17:49 +0000 (21:17 +0000)]
Merge "user: Use cached singleton instance variable"

2 years agoMerge "docs: Exclude extra markdown files from Doxygen"
jenkins-bot [Fri, 13 Sep 2019 20:47:41 +0000 (20:47 +0000)]
Merge "docs: Exclude extra markdown files from Doxygen"

2 years agoMerge "changes: Fix wrong typehint"
jenkins-bot [Fri, 13 Sep 2019 20:47:34 +0000 (20:47 +0000)]
Merge "changes: Fix wrong typehint"

2 years agoMerge "libs: Declare dynamic properties and improve doc types"
jenkins-bot [Fri, 13 Sep 2019 20:47:28 +0000 (20:47 +0000)]
Merge "libs: Declare dynamic properties and improve doc types"

2 years agoMerge "Expose LinksUpdate recursive flag with a getter"
jenkins-bot [Fri, 13 Sep 2019 20:04:40 +0000 (20:04 +0000)]
Merge "Expose LinksUpdate recursive flag with a getter"

2 years agoMake PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one batch
Aaron Schulz [Wed, 11 Sep 2019 22:15:17 +0000 (15:15 -0700)]
Make PageArchive/WikiPage CDN purges use JobQueueGroup::lazyPush() in one batch

Change-Id: I1fd19ebee1cfe1c94cab3e8fe40824d9723573da

2 years agoBaseTemplate: Hard-deprecate msgWiki()
James D. Forrester [Fri, 13 Sep 2019 17:31:55 +0000 (10:31 -0700)]
BaseTemplate: Hard-deprecate msgWiki()

Change-Id: I547ead0a86a8491cc8a8de81bc6b473fadd04765

2 years agoFollow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates...
James D. Forrester [Fri, 13 Sep 2019 17:59:48 +0000 (10:59 -0700)]
Follow-up 7960d53: Mark when the SecondaryDataUpdates and WikiPageDeletionUpdates hooks were deprecated

Change-Id: Id35cc5e1d21a62d0d6469b80b693bb654215db2a

2 years agoRemove User::setNewpassword()
Reedy [Fri, 13 Sep 2019 18:03:20 +0000 (19:03 +0100)]
Remove User::setNewpassword()

Change-Id: I0a52ac16bc9c62bf344af3f489f4cbe7576fc733

2 years agodeleteLogFormatter: explicitly declare parsedParametersDeleteLog
Daimona Eaytoy [Wed, 11 Sep 2019 09:14:34 +0000 (11:14 +0200)]
deleteLogFormatter: explicitly declare parsedParametersDeleteLog

Instead of having a dynamic property checked via isset().

Change-Id: I64e3a3135b898b65e789aa8307ab9e3ffa0e9f4a

2 years agoDeclare dynamic properties
Daimona Eaytoy [Wed, 11 Sep 2019 09:07:30 +0000 (11:07 +0200)]
Declare dynamic properties

This is for all classes with 2 or more undeclared properties.

Change-Id: I1d80deb31f331bcc277b33f9e9f74857ba825637

2 years agouser: Use cached singleton instance variable
Reedy [Fri, 13 Sep 2019 17:44:11 +0000 (18:44 +0100)]
user: Use cached singleton instance variable

Remove unnecesary qualification (there's a use statement)

Change-Id: I0c39e2086f38275db7912231f6ddbfa090f095d8

2 years agoMerge "Fix a typo (yeild -> yield)"
jenkins-bot [Fri, 13 Sep 2019 17:10:14 +0000 (17:10 +0000)]
Merge "Fix a typo (yeild -> yield)"

2 years agoRemove usages of Title::get{Previous,Next}RevisionId
Petr Pchelko [Tue, 27 Aug 2019 02:45:33 +0000 (19:45 -0700)]
Remove usages of Title::get{Previous,Next}RevisionId

The methods were deprecated since 1.34.

Change-Id: Ib95ac1ba36a8ffd6b71ed67642d8abb2e3538bae

2 years agodocs: Exclude extra markdown files from Doxygen
apaskulin [Tue, 10 Sep 2019 18:58:32 +0000 (18:58 +0000)]
docs: Exclude extra markdown files from Doxygen

Cleans up the Doxygen file list by excluding markdown
files other than the intro, main code of conduct, and
/docs directory.

docs: Add heading to code of conduct

Adds an h1 heading to use as the file listing
in Doxygen instead of the file name.

Change-Id: Id13eec2670aa4b96275f1e688a29c22c3f38a859

2 years agoFix a typo (folow -> follow)
DannyS712 [Fri, 13 Sep 2019 03:32:11 +0000 (03:32 +0000)]
Fix a typo (folow -> follow)

Bug: T201491
Change-Id: I1083f6f0e29b9f3e9c2d0dd2bdb9e1f524327c0a

2 years agoMerge "output: Narrow Title type hint to LinkTarget"
jenkins-bot [Fri, 13 Sep 2019 13:31:24 +0000 (13:31 +0000)]
Merge "output: Narrow Title type hint to LinkTarget"

2 years agoMerge "Reset all logging tables together"
jenkins-bot [Fri, 13 Sep 2019 12:06:20 +0000 (12:06 +0000)]
Merge "Reset all logging tables together"

2 years agoMerge "Improve MediaWikiIntegrationTestCase::resetDB()"
jenkins-bot [Fri, 13 Sep 2019 12:00:51 +0000 (12:00 +0000)]
Merge "Improve MediaWikiIntegrationTestCase::resetDB()"

2 years agoReset all logging tables together
Adam Wight [Thu, 12 Sep 2019 15:19:57 +0000 (17:19 +0200)]
Reset all logging tables together

For example, leftover cruft in `log_search` will cause spurious
associated_rev links between unrelated revisions and log entries.

Bug: T227849
Change-Id: Ie344522229e4142f2c61a267b4d693051b813236

2 years agoImprove MediaWikiIntegrationTestCase::resetDB()
Lucas Werkmeister [Thu, 12 Sep 2019 15:36:01 +0000 (17:36 +0200)]
Improve MediaWikiIntegrationTestCase::resetDB()

Test the intersection of $tablesUsed with each set of tables
separately and only update it afterwards.  Without this fix, overlaps
between the table groups would cause additional groups to be pulled in
unnecessarily.

Change-Id: I1b2a6eb47e061dee8a27fb4779809b4684c05104

2 years agoRemove dead code from RCCacheEntryFactory
Matěj Suchánek [Fri, 13 Sep 2019 09:51:52 +0000 (11:51 +0200)]
Remove dead code from RCCacheEntryFactory

Change-Id: I7832bac1e9c700e4a2a37b765d257ce8a7ace458