lhc/web/wiklou.git
3 years agoBump LocalFile::VERSION to invalidate file page cache
Reedy [Mon, 18 Sep 2017 13:47:28 +0000 (14:47 +0100)]
Bump LocalFile::VERSION to invalidate file page cache

Bug: T175444
Change-Id: Ic0665d5554ed43c48d4fcdef087fbd33b597788c

3 years agoMerge "Split mediawiki.special.preferences into separate file for each function"
jenkins-bot [Mon, 18 Sep 2017 15:18:10 +0000 (15:18 +0000)]
Merge "Split mediawiki.special.preferences into separate file for each function"

3 years agoMerge "Return description fields for unprefixed image cache rows"
jenkins-bot [Mon, 18 Sep 2017 14:59:59 +0000 (14:59 +0000)]
Merge "Return description fields for unprefixed image cache rows"

3 years agoMerge "phpunit.php: omit --quiet in help"
jenkins-bot [Mon, 18 Sep 2017 14:45:31 +0000 (14:45 +0000)]
Merge "phpunit.php: omit --quiet in help"

3 years agoReturn description fields for unprefixed image cache rows
Reedy [Mon, 18 Sep 2017 00:58:18 +0000 (01:58 +0100)]
Return description fields for unprefixed image cache rows

Bug: T175444
Change-Id: I5560187d3850253095b695dc7a3cfc954fba9318

3 years agoMerge "Fix findHooks.php"
jenkins-bot [Mon, 18 Sep 2017 09:17:06 +0000 (09:17 +0000)]
Merge "Fix findHooks.php"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 17 Sep 2017 19:54:28 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I8c413069268400a1a0f6ab9808c713666652271f

3 years agoMerge "Do not run CollationFaTest if 'intl' is not loaded"
jenkins-bot [Sun, 17 Sep 2017 17:05:34 +0000 (17:05 +0000)]
Merge "Do not run CollationFaTest if 'intl' is not loaded"

3 years agoMerge "mediawiki.action.edit.preview: Apply mw.language.bcp47 to lang"
jenkins-bot [Sun, 17 Sep 2017 09:39:16 +0000 (09:39 +0000)]
Merge "mediawiki.action.edit.preview: Apply mw.language.bcp47 to lang"

3 years agoFix findHooks.php
Umherirrender [Sun, 17 Sep 2017 08:54:49 +0000 (10:54 +0200)]
Fix findHooks.php

Add the test entry point, because it contains documented hooks.
Filter out empty args, coming from trailing commas

Removed empty lines from hooks.txt, because a hook must be one block
without newlines between.

Change-Id: I71e0625da96cad03f5e38a000fa61d1d2bdac8ef

3 years agophpunit.php: omit --quiet in help
Gergő Tisza [Sun, 17 Sep 2017 05:03:50 +0000 (05:03 +0000)]
phpunit.php: omit --quiet in help

Bug: T176060
Change-Id: Iee7a0df6ba9fadf92d8e2d9f170cdfc66244d3d5

3 years agoDo not run CollationFaTest if 'intl' is not loaded
Huji Lee [Sat, 16 Sep 2017 20:30:18 +0000 (16:30 -0400)]
Do not run CollationFaTest if 'intl' is not loaded

Bug: T176040
Change-Id: I6b19bf1123d4dca5a1c8e002c0de65bab2138180

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 16 Sep 2017 20:16:12 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I40f96fd439726f95b0dc467cf2f2802f1a3144d7

3 years agoMerge "Fix return in Preprocessor::cacheSetTree"
jenkins-bot [Sat, 16 Sep 2017 20:07:56 +0000 (20:07 +0000)]
Merge "Fix return in Preprocessor::cacheSetTree"

3 years agoMerge "Fix return of Interwiki::invalidateCache"
jenkins-bot [Sat, 16 Sep 2017 20:04:05 +0000 (20:04 +0000)]
Merge "Fix return of Interwiki::invalidateCache"

3 years agoMerge "Fix return in HttpStatus::header"
jenkins-bot [Sat, 16 Sep 2017 20:02:50 +0000 (20:02 +0000)]
Merge "Fix return in HttpStatus::header"

3 years agoMerge "mediawiki.special.preferences: Allow linking to subsections"
jenkins-bot [Sat, 16 Sep 2017 16:27:56 +0000 (16:27 +0000)]
Merge "mediawiki.special.preferences: Allow linking to subsections"

3 years agoMerge "Preferences: Do not set non-breaking space as a label"
jenkins-bot [Sat, 16 Sep 2017 16:27:53 +0000 (16:27 +0000)]
Merge "Preferences: Do not set non-breaking space as a label"

3 years agoMerge "Xml: Fix Xml::fieldset() when $content is not given"
jenkins-bot [Sat, 16 Sep 2017 13:58:37 +0000 (13:58 +0000)]
Merge "Xml: Fix Xml::fieldset() when $content is not given"

3 years agoSplit mediawiki.special.preferences into separate file for each function
Bartosz Dziewoński [Fri, 15 Sep 2017 18:45:24 +0000 (20:45 +0200)]
Split mediawiki.special.preferences into separate file for each function

This JavaScript code does four things:
* Convert a simple form into one with tab navigation
* Convert a simple message box into pretty notifications
* Prevent browser window from being closed with unsaved changes to preferences
* Add some enhancements to the timezone field

I will be making some large changes here for T117781 and having
everything mixed in one file was making that difficult. I avoided
making any cleanup changes to make it easier to review this change.

Change-Id: I5e31a661177002e40708614011c1f7e08ec4f44d

3 years agomediawiki.special.preferences: Allow linking to subsections
Bartosz Dziewoński [Fri, 15 Sep 2017 20:35:46 +0000 (22:35 +0200)]
mediawiki.special.preferences: Allow linking to subsections

The fix for T54469 allowed linking to individual fields, but not to
subsections.

The subsections have an id prefixed with 'mw-prefsection', like the
main sections, so the 'else' case was never triggered and they were
never handled. Fix the 'if' case condition to not match them.

Also, do not rely on the 'prefsection' class, which is (according to
the comment at the top of this file) only "for backwards compatibility
with older skins".

Change-Id: Ie7b4e3afbbe723a4e3b01aac95476b073a7213cd

3 years agoPreferences: Do not set non-breaking space as a label
Bartosz Dziewoński [Fri, 15 Sep 2017 22:58:55 +0000 (00:58 +0200)]
Preferences: Do not set non-breaking space as a label

If there's no label, there's just no label. No need to pretend.

Change-Id: I6b7065a23ba6532641989682d802613e0545f7e8

3 years agoXml: Fix Xml::fieldset() when $content is not given
Bartosz Dziewoński [Fri, 15 Sep 2017 18:06:45 +0000 (20:06 +0200)]
Xml: Fix Xml::fieldset() when $content is not given

A function in the Xml class could generate unbalanced tags. How
ironic. Why do we even have this instead of just the Html class?

Change-Id: Ie119c92aa4936e2f8982163d4b00d08949f49264

3 years agomediawiki.action.edit.preview: Apply mw.language.bcp47 to lang
Fomafix [Sat, 16 Sep 2017 10:31:02 +0000 (12:31 +0200)]
mediawiki.action.edit.preview: Apply mw.language.bcp47 to lang

Apply mw.language.bcp47 to the language codes before using as values
for the HTML attributes lang and hreflang.

Change-Id: I4321d32f3b3a9729650060d59450701710b8c8f2

3 years agoEditPage: Don't use $wgUser
Kunal Mehta [Fri, 15 Sep 2017 21:09:37 +0000 (14:09 -0700)]
EditPage: Don't use $wgUser

Bug: T144366
Change-Id: Ia8b7ae5ec73241478d51c57aca376e5bb50ef874

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 15 Sep 2017 19:59:13 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I584dcdcb53c62280a20242101d8b3bf3248e3e4b

3 years agoMerge "Fix a few minor mistakes in PHPDoc tags"
jenkins-bot [Fri, 15 Sep 2017 19:18:17 +0000 (19:18 +0000)]
Merge "Fix a few minor mistakes in PHPDoc tags"

3 years agoMerge "RCFilters: Only selectively scroll to popup when it's focused"
jenkins-bot [Fri, 15 Sep 2017 13:05:06 +0000 (13:05 +0000)]
Merge "RCFilters: Only selectively scroll to popup when it's focused"

3 years agoMerge "RCFilters: Allow empty saved query"
jenkins-bot [Fri, 15 Sep 2017 13:00:07 +0000 (13:00 +0000)]
Merge "RCFilters: Allow empty saved query"

3 years agoMerge "Fix $wgUpdateRowsPerJob default in docs/deferred.txt"
jenkins-bot [Fri, 15 Sep 2017 10:13:11 +0000 (10:13 +0000)]
Merge "Fix $wgUpdateRowsPerJob default in docs/deferred.txt"

3 years agoMerge "replacing "images" by "files" in listfiles-show-all for consistency"
jenkins-bot [Fri, 15 Sep 2017 09:54:47 +0000 (09:54 +0000)]
Merge "replacing "images" by "files" in listfiles-show-all for consistency"

3 years agoFix $wgUpdateRowsPerJob default in docs/deferred.txt
Thiemo Mättig [Fri, 15 Sep 2017 09:18:22 +0000 (11:18 +0200)]
Fix $wgUpdateRowsPerJob default in docs/deferred.txt

Change-Id: I0fdca6ac9d58286cf5f1ad9f55531e4643fa4fc5

3 years agoFix a few minor mistakes in PHPDoc tags
Thiemo Mättig [Fri, 15 Sep 2017 09:17:17 +0000 (11:17 +0200)]
Fix a few minor mistakes in PHPDoc tags

Change-Id: I2d5f876c9945ba21f8748562230170e3c7ea2ff2

3 years agoRCFilters: Only selectively scroll to popup when it's focused
Moriel Schottlender [Wed, 13 Sep 2017 22:29:36 +0000 (15:29 -0700)]
RCFilters: Only selectively scroll to popup when it's focused

Bug: T175697
Change-Id: Id8f42332c661cf341953eb6af43e49a422181cc8

3 years agoRCFilters: Don't cast days default to an integer
Moriel Schottlender [Thu, 14 Sep 2017 21:11:44 +0000 (14:11 -0700)]
RCFilters: Don't cast days default to an integer

Values can be floats, like 1.5 days, etc. Cast instead to a float.

Bug: T175965
Change-Id: I14ba792f1cd435f89b2e09067b0a0e894a0a2557

3 years agoRCFilters: Allow empty saved query
Moriel Schottlender [Thu, 14 Sep 2017 00:13:26 +0000 (17:13 -0700)]
RCFilters: Allow empty saved query

For this, we also need to check for saved query visibility on the
saved query model initialization, because since the model starts
its life all-empty, if the saved query is also all-empty, it will
not trigger any item updates on the main model.

Bonus: Actually check whether defaults are empty; there was a
typo and problem with the original test.

Bug: T172387
Change-Id: Ibc536b577e4c3abcc04fa229f9978b651b2f9e61

3 years agoMerge "Localisation updates from https://translatewiki.net."
L10n-bot [Thu, 14 Sep 2017 20:04:33 +0000 (20:04 +0000)]
Merge "Localisation updates from https://translatewiki.net."

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 14 Sep 2017 20:04:16 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I64d648923f684e73152ad4ea9fe8267cda9e5d39

3 years agoApiFeedWatchlist: Fix copy-paste error
Brad Jorsch [Thu, 14 Sep 2017 19:53:22 +0000 (15:53 -0400)]
ApiFeedWatchlist: Fix copy-paste error

Change-Id: Ibea5bd881c746d7c27c97fc470ee1e3ac9d4b699

3 years agoMerge "Instruct stashed upload failures to reupload file"
jenkins-bot [Thu, 14 Sep 2017 19:46:49 +0000 (19:46 +0000)]
Merge "Instruct stashed upload failures to reupload file"

3 years agoMerge "Make chunkedUpload match upload behavior"
jenkins-bot [Thu, 14 Sep 2017 19:45:14 +0000 (19:45 +0000)]
Merge "Make chunkedUpload match upload behavior"

3 years agoMerge "RCFilters: Live update: no data returns 204"
jenkins-bot [Thu, 14 Sep 2017 18:11:14 +0000 (18:11 +0000)]
Merge "RCFilters: Live update: no data returns 204"

3 years agoMerge "mediawiki.Title: Remove obsolete Object.create ES3 fallback"
jenkins-bot [Thu, 14 Sep 2017 17:40:08 +0000 (17:40 +0000)]
Merge "mediawiki.Title: Remove obsolete Object.create ES3 fallback"

3 years agomediawiki.Title: Remove obsolete Object.create ES3 fallback
Timo Tijhof [Thu, 14 Sep 2017 17:25:15 +0000 (19:25 +0200)]
mediawiki.Title: Remove obsolete Object.create ES3 fallback

We no longer support non-ES5 browsers.

Change-Id: If1e18dc3111899f3b0a5ae53909624186101a8ba

3 years agoMerge "mw.loader: Remove Deferred overhead from execute() hot code path"
jenkins-bot [Thu, 14 Sep 2017 17:03:01 +0000 (17:03 +0000)]
Merge "mw.loader: Remove Deferred overhead from execute() hot code path"

3 years agoMerge "mw.loader: Add unit test to confirm implicit 'site' dependency for 'user'"
jenkins-bot [Thu, 14 Sep 2017 13:47:47 +0000 (13:47 +0000)]
Merge "mw.loader: Add unit test to confirm implicit 'site' dependency for 'user'"

3 years agoMerge "Fix saved query names cutoff"
jenkins-bot [Thu, 14 Sep 2017 12:47:35 +0000 (12:47 +0000)]
Merge "Fix saved query names cutoff"

3 years agoMerge "De-duplicate HTMLCacheUpdate jobs with a page array of size 1"
jenkins-bot [Thu, 14 Sep 2017 12:36:52 +0000 (12:36 +0000)]
Merge "De-duplicate HTMLCacheUpdate jobs with a page array of size 1"

3 years agomw.loader: Remove Deferred overhead from execute() hot code path
Timo Tijhof [Thu, 14 Sep 2017 09:52:52 +0000 (11:52 +0200)]
mw.loader: Remove Deferred overhead from execute() hot code path

This was introduced by 0ac4f99804c for the concept of globally
implied legacy dependencies.

Commit ba257035b07 then re-purposed this for the site/user module
dependency.

The legacy wait was removed in 0ac6076b4c0, thus leaving only the
site/user code.

This commit now simplifies the code back to how it was before 0ac4f99804c
(but keeping the improved error handling from ba257035b07).

Change-Id: I2eae3b78fbe4f03a7a098d8a6233bdc2b79171b8

3 years agomw.loader: Add unit test to confirm implicit 'site' dependency for 'user'
Timo Tijhof [Thu, 14 Sep 2017 09:48:03 +0000 (11:48 +0200)]
mw.loader: Add unit test to confirm implicit 'site' dependency for 'user'

The underlying logic is in mw.loader#execute and mw.loader#runScript,
but currently untested.

Adding tests in prep for refactoring this code.

Change-Id: I77ffb5f23443e24ca1d86f36ddf434673e9c1538

3 years agoDe-duplicate HTMLCacheUpdate jobs with a page array of size 1
Aaron Schulz [Thu, 14 Sep 2017 09:25:23 +0000 (11:25 +0200)]
De-duplicate HTMLCacheUpdate jobs with a page array of size 1

BacklinkJobUtils consistently uses the "pages" field in leaf
jobs, even when there is only one page per leaf job.

RefreshLinksJob already has this logic for de-duplication.

Change-Id: Ia189bbc9df44f2161cfed4192c23b2ac3cfa65ce

3 years agoFix saved query names cutoff
petarpetkovic [Thu, 14 Sep 2017 08:37:08 +0000 (10:37 +0200)]
Fix saved query names cutoff

Fix saved filters name misalignment and cutoff for
letters that have descenders on RC page.

Bug: T174111
Change-Id: I32e61fad98f38b48e0234467056a939d634eb15c

3 years agoPrefer that enqueueable post-send updates are run immediately
Aaron Schulz [Thu, 14 Sep 2017 08:07:38 +0000 (10:07 +0200)]
Prefer that enqueueable post-send updates are run immediately

If the user is not waiting at this point, so there is not much
reason to enqueue a job over just doing the work now. Running
the update now gives more immediate results however.

This has the effect of  making LinksUpdate run post-send for
forward link updates, since the addUpdate() call in WikiPage uses
the default POSTSEND mode. These updates used to be synchronous
in the past, before proper post-send update support. With post-send
updates, there is not much benefit to using the job queue here.

If post-send updates are not supported, this will continue to
use the job queue.

If a caller needs such updates to enqueue post-send to avoid DB
updates on HTTP GET or if the update is too big to run outside of
JobRunner, it can always just use JobQueueGroup::lazyPush() with
a direct job object or JobSpecification.

Change-Id: Ibc4b1e17538cc8b1fba7d13759e1ebb83abed869

3 years agoMerge "Improve flaky SiteStatsTest"
jenkins-bot [Thu, 14 Sep 2017 02:35:09 +0000 (02:35 +0000)]
Merge "Improve flaky SiteStatsTest"

3 years agoMerge "JobQueueMemory: Actually return values in MappedIterator callback"
jenkins-bot [Thu, 14 Sep 2017 02:33:56 +0000 (02:33 +0000)]
Merge "JobQueueMemory: Actually return values in MappedIterator callback"

3 years agoMerge "Allow users to restrict who can send them direct emails via Special:EmailUser"
jenkins-bot [Thu, 14 Sep 2017 01:02:25 +0000 (01:02 +0000)]
Merge "Allow users to restrict who can send them direct emails via Special:EmailUser"

3 years agoRCFilters: Output namespace class on log actions as well
Moriel Schottlender [Thu, 14 Sep 2017 00:18:11 +0000 (17:18 -0700)]
RCFilters: Output namespace class on log actions as well

Bug: T174732
Change-Id: Icaf7117d9566bb2bb31c69cf86078491d6c217cc

3 years agopopulateIpChanges.php: Insert rows in batches
Reedy [Wed, 13 Sep 2017 22:22:19 +0000 (23:22 +0100)]
populateIpChanges.php: Insert rows in batches

Change-Id: I0233b5a17fc64751514ec6d0701f155a73906873

3 years agoMerge "Center items in 'Save current filter settings'"
jenkins-bot [Wed, 13 Sep 2017 20:57:39 +0000 (20:57 +0000)]
Merge "Center items in 'Save current filter settings'"

3 years agoMerge "RCFilters: make live update part of the beta feature"
jenkins-bot [Wed, 13 Sep 2017 20:49:04 +0000 (20:49 +0000)]
Merge "RCFilters: make live update part of the beta feature"

3 years agoMerge "Fix submit button id on Special:Preferences"
jenkins-bot [Wed, 13 Sep 2017 20:47:16 +0000 (20:47 +0000)]
Merge "Fix submit button id on Special:Preferences"

3 years agoRCFilters: make live update part of the beta feature
Stephane Bisson [Wed, 13 Sep 2017 20:07:54 +0000 (16:07 -0400)]
RCFilters: make live update part of the beta feature

Cleanup wgStructuredChangeFiltersEnableLiveUpdate

Bug: T175766
Change-Id: I03db105bef6c3730221c2d00ce56afb2c78bf57c

3 years agoMerge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Wed, 13 Sep 2017 20:36:48 +0000 (20:36 +0000)]
Merge "Sync up with Parsoid parserTests.txt"

3 years agoSync up with Parsoid parserTests.txt
Subramanya Sastry [Wed, 13 Sep 2017 20:20:40 +0000 (15:20 -0500)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit dcf2706cff795b84fbbfb6cd22749a86655b04f2

Change-Id: I24700184204000465922930dbac2b019259b5a01

3 years agoFix submit button id on Special:Preferences
Bartosz Dziewoński [Wed, 13 Sep 2017 19:58:25 +0000 (21:58 +0200)]
Fix submit button id on Special:Preferences

For reasons beyond human fathoming, the button had the id set
to 'prefsubmit' in PHP code and then changed to 'prefcontrol'
in JS code. This functionality has been carefully preserved
across multiple rewrites of this code since 2004, when it was
added in 30d0ccd0 (rSVN3618). Let's just set the id in PHP.

Change-Id: Ib23bd0e481e73a51ff0a16731f47a2df11b2c1b8

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 13 Sep 2017 20:03:46 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id145914494c1acfac06ec68cef3805341cbdcc88

3 years agoRCFilters: Live update: no data returns 204
Stephane Bisson [Wed, 13 Sep 2017 16:58:16 +0000 (12:58 -0400)]
RCFilters: Live update: no data returns 204

Return status 204 when peek=1 and there is no data

Also refactor _fetchChangesList to allow checking for new changes
and pulling them different handling.

Bug: T173613
Change-Id: I8fe2556156bac3d0cfa4f557ae82a163b6eb4d37

3 years agoMerge "Move call of Sanitizer::decodeCharReferences from Skin to Parser"
jenkins-bot [Wed, 13 Sep 2017 17:54:13 +0000 (17:54 +0000)]
Merge "Move call of Sanitizer::decodeCharReferences from Skin to Parser"

3 years agoMerge "Do not double decode HTML entities for IDs"
jenkins-bot [Wed, 13 Sep 2017 17:50:37 +0000 (17:50 +0000)]
Merge "Do not double decode HTML entities for IDs"

3 years agoMerge "RCFilters: Add an initialization hook"
jenkins-bot [Wed, 13 Sep 2017 17:35:25 +0000 (17:35 +0000)]
Merge "RCFilters: Add an initialization hook"

3 years agoMerge "RCFilters: Actually apply proper classes to grouped pages"
jenkins-bot [Wed, 13 Sep 2017 17:34:49 +0000 (17:34 +0000)]
Merge "RCFilters: Actually apply proper classes to grouped pages"

3 years agoAllow users to restrict who can send them direct emails via Special:EmailUser
David Barratt [Tue, 29 Aug 2017 13:43:35 +0000 (09:43 -0400)]
Allow users to restrict who can send them direct emails via Special:EmailUser

Users can now specify a blacklist of users who are prevented from sending them a direct email.

Bug: T138166
Change-Id: Ifa26153f593b0ca3a9121e1e29961911c616c9e4

3 years agoMerge "mediawiki.htmlform.checker: Add missing dependency on jquery.throttle-debounce"
jenkins-bot [Wed, 13 Sep 2017 17:26:28 +0000 (17:26 +0000)]
Merge "mediawiki.htmlform.checker: Add missing dependency on jquery.throttle-debounce"

3 years agoRCFilters: Actually apply proper classes to grouped pages
Moriel Schottlender [Wed, 13 Sep 2017 00:44:03 +0000 (17:44 -0700)]
RCFilters: Actually apply proper classes to grouped pages

Bug: T174734
Change-Id: Ie0a8f5587103c3caed31d29585db78017ac4ab4c

3 years agomediawiki.htmlform.checker: Add missing dependency on jquery.throttle-debounce
Bartosz Dziewoński [Wed, 13 Sep 2017 16:54:34 +0000 (18:54 +0200)]
mediawiki.htmlform.checker: Add missing dependency on jquery.throttle-debounce

Change-Id: I56345cac3d52f2862d4b3b5df3ba3b6d0ed29c34

3 years agoMerge "WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete...
jenkins-bot [Wed, 13 Sep 2017 16:41:35 +0000 (16:41 +0000)]
Merge "WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hook"

3 years agoMerge "Add CommentStoreComment::newUnsavedComment()"
jenkins-bot [Wed, 13 Sep 2017 15:42:28 +0000 (15:42 +0000)]
Merge "Add CommentStoreComment::newUnsavedComment()"

3 years agoMerge "Replace more problematic uses of "SELECT *""
jenkins-bot [Wed, 13 Sep 2017 14:59:19 +0000 (14:59 +0000)]
Merge "Replace more problematic uses of "SELECT *""

3 years agoWikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hook
Mark A. Hershberger [Mon, 11 Sep 2017 16:21:56 +0000 (12:21 -0400)]
WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hook

In case the hook user has created the 12th param without a default.

Bug: T175596
Change-Id: I63142daaaeea069364dc70b45ee62680ac955f1e

3 years agoCenter items in 'Save current filter settings'
petarpetkovic [Wed, 13 Sep 2017 13:41:17 +0000 (15:41 +0200)]
Center items in 'Save current filter settings'

- Center cancel button (X) in 'Save current filter settings' menu.
- Center head label in 'Save current filter settings' menu.

Bug: T174454
Change-Id: I44ce0b40aa6acf5797f70fda731e5e4bde9f9748

3 years agoMerge "RCFilters: Preference length is in bytes, so use $.byteLength"
jenkins-bot [Wed, 13 Sep 2017 13:38:54 +0000 (13:38 +0000)]
Merge "RCFilters: Preference length is in bytes, so use $.byteLength"

3 years agoMerge "Skin.php: HTML escape message pipe-separator"
jenkins-bot [Wed, 13 Sep 2017 13:16:39 +0000 (13:16 +0000)]
Merge "Skin.php: HTML escape message pipe-separator"

3 years agoReplace more problematic uses of "SELECT *"
Brad Jorsch [Wed, 13 Sep 2017 12:13:02 +0000 (08:13 -0400)]
Replace more problematic uses of "SELECT *"

With the introduction of CommentStore, selects from various table
require certain joins or column aliases for proper operation.

Change-Id: I2ecb6030bf253664c3227d69b5ed2277596a83f0

3 years agoreplacing "images" by "files" in listfiles-show-all for consistency
Envel Le Hir [Wed, 13 Sep 2017 12:45:22 +0000 (14:45 +0200)]
replacing "images" by "files" in listfiles-show-all for consistency

Change-Id: I2adabce83df0b429809f8256f3ae333fd8a36902

3 years agoMove call of Sanitizer::decodeCharReferences from Skin to Parser
Fomafix [Wed, 13 Sep 2017 11:49:02 +0000 (13:49 +0200)]
Move call of Sanitizer::decodeCharReferences from Skin to Parser

Supporting HTML entities in Wikitext is part of the parser not of the
skin.

Change-Id: Ib30ff08f4f4ce585f31211aa24b719783f06456e

3 years agoSkin.php: HTML escape message pipe-separator
Fomafix [Wed, 13 Sep 2017 10:37:36 +0000 (12:37 +0200)]
Skin.php: HTML escape message pipe-separator

This prevents HTML and JavaScript injections.

Change-Id: I6241dadf29e96aa1aa15324a3edc51538214345d

3 years agoMerge "Linker: Accept LinkTargets in makeCommentLink()"
jenkins-bot [Wed, 13 Sep 2017 10:15:54 +0000 (10:15 +0000)]
Merge "Linker: Accept LinkTargets in makeCommentLink()"

3 years agoMerge "Linker: Accept LinkTarget objects in link()"
jenkins-bot [Wed, 13 Sep 2017 10:10:38 +0000 (10:10 +0000)]
Merge "Linker: Accept LinkTarget objects in link()"

3 years agoMerge "Linker: Don't use Title::setFragment()"
jenkins-bot [Wed, 13 Sep 2017 10:07:16 +0000 (10:07 +0000)]
Merge "Linker: Don't use Title::setFragment()"

3 years agoMerge "ImageHistoryPseudoPager: Don't use Title::setFragment()"
jenkins-bot [Wed, 13 Sep 2017 10:03:44 +0000 (10:03 +0000)]
Merge "ImageHistoryPseudoPager: Don't use Title::setFragment()"

3 years agoRCFilters: Preference length is in bytes, so use $.byteLength
Matthew Flaschen [Wed, 13 Sep 2017 02:22:33 +0000 (22:22 -0400)]
RCFilters: Preference length is in bytes, so use $.byteLength

Also, a minor fix to $.byteLength docs

Change-Id: I0f93edb0cb61a057da5ce0876b74cd17179c6587

3 years agoMerge "Fix coverage annotations"
jenkins-bot [Wed, 13 Sep 2017 06:51:53 +0000 (06:51 +0000)]
Merge "Fix coverage annotations"

3 years agoMerge "Use db query builder not raw sql"
jenkins-bot [Wed, 13 Sep 2017 00:03:58 +0000 (00:03 +0000)]
Merge "Use db query builder not raw sql"

3 years agoMerge "Quote $default in PostgresUpdater::setDefault"
jenkins-bot [Tue, 12 Sep 2017 23:46:29 +0000 (23:46 +0000)]
Merge "Quote $default in PostgresUpdater::setDefault"

3 years agoMerge "Remove @covers from private Sanitizer method"
jenkins-bot [Tue, 12 Sep 2017 23:43:51 +0000 (23:43 +0000)]
Merge "Remove @covers from private Sanitizer method"

3 years agoMerge "Chinese Conversion Table Update 2017-4"
jenkins-bot [Tue, 12 Sep 2017 23:38:11 +0000 (23:38 +0000)]
Merge "Chinese Conversion Table Update 2017-4"

3 years agoMerge "Split off remaining helper classes for special pages to separate files"
jenkins-bot [Tue, 12 Sep 2017 23:35:11 +0000 (23:35 +0000)]
Merge "Split off remaining helper classes for special pages to separate files"

3 years agoChinese Conversion Table Update 2017-4
Chiefwei [Thu, 17 Aug 2017 06:10:08 +0000 (14:10 +0800)]
Chinese Conversion Table Update 2017-4

Update the Chinese conversion table routinely to fix bugs reported from https://zh.wikipedia.org/wiki/Wikipedia:%E5%AD%97%E8%AF%8D%E8%BD%AC%E6%8D%A2/%E4%BF%AE%E5%A4%8D%E8%AF%B7%E6%B1%82 .

It is only data changes and only works for Chinese WikiProjects.

Change-Id: Ic66546d3a47e4dd946ae67c636a638ca181b0ca1

3 years agoUse db query builder not raw sql
Reedy [Tue, 12 Sep 2017 22:24:12 +0000 (23:24 +0100)]
Use db query builder not raw sql

Change-Id: I8e26932e28fdda9a52e0486c5d2eb269eb9ecae5
Follows-up: Ice1bdae3d16cf365da14c6df0e8d91d2b914e064

3 years agoMerge "postEdit: Use standard close icon"
jenkins-bot [Tue, 12 Sep 2017 22:14:13 +0000 (22:14 +0000)]
Merge "postEdit: Use standard close icon"