lhc/web/wiklou.git
3 years agoMerge "Improve "selfmove" message's wording"
jenkins-bot [Fri, 22 Sep 2017 21:59:38 +0000 (21:59 +0000)]
Merge "Improve "selfmove" message's wording"

3 years agoImprove "selfmove" message's wording
Egbe Eugene [Thu, 13 Jul 2017 20:40:15 +0000 (21:40 +0100)]
Improve "selfmove" message's wording

The error shown when a page is to be moved (renamed) with the same
title is not immediately obvious to the user, so use simpler
and clearer language.

Bug: T164987
Change-Id: I639c4ae27866234fed9bcc5f2afc4684155418f8

3 years agoSpecialSearch: Fix unintended `margin` when zoom level is above 100%
Volker E [Fri, 22 Sep 2017 20:30:19 +0000 (13:30 -0700)]
SpecialSearch: Fix unintended `margin` when zoom level is above 100%

With zoom level > 100% on Firefox, `#mw-searchoptions` which is a
`fieldset` element adds unintended `margin` with negative `margin-top`
applied. This is a workaround for wrong browser behaviour and
regression of I4bda42c03a5.

Bug: T176499
Change-Id: I329f83e6063460dc11ff45583e335280c9257ef7

3 years agoMerge "Remove duplicate release note for $wgOOUIEditPage removal"
jenkins-bot [Fri, 22 Sep 2017 20:10:10 +0000 (20:10 +0000)]
Merge "Remove duplicate release note for $wgOOUIEditPage removal"

3 years agoMerge "EditPage: Mark getSubmitButtonLabel() as @since 1.30"
jenkins-bot [Fri, 22 Sep 2017 20:06:48 +0000 (20:06 +0000)]
Merge "EditPage: Mark getSubmitButtonLabel() as @since 1.30"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 22 Sep 2017 19:56:06 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If2bdcb141ae02cc0c5324a9a1b10440edf1f6235

3 years agoRemove duplicate release note for $wgOOUIEditPage removal
Kunal Mehta [Fri, 22 Sep 2017 19:52:35 +0000 (12:52 -0700)]
Remove duplicate release note for $wgOOUIEditPage removal

And capitalize Unicode properly.

Follows-up b2441fc57d6e.

Change-Id: I2d68ff1abb0497eae046bd984d2a182066956325

3 years agoEditPage: Mark getSubmitButtonLabel() as @since 1.30
Kunal Mehta [Fri, 22 Sep 2017 19:51:20 +0000 (12:51 -0700)]
EditPage: Mark getSubmitButtonLabel() as @since 1.30

Change-Id: I801e98b9f42636a46cdfa5cf7de4de2b59f9e46d

3 years agoMerge "Remove use of MWException in MapCacheLRU"
jenkins-bot [Fri, 22 Sep 2017 18:27:23 +0000 (18:27 +0000)]
Merge "Remove use of MWException in MapCacheLRU"

3 years agoMerge "RCFilters: Make 'lastRevision' filter include non-rev types"
jenkins-bot [Fri, 22 Sep 2017 17:52:13 +0000 (17:52 +0000)]
Merge "RCFilters: Make 'lastRevision' filter include non-rev types"

3 years agoMerge "RCFilters: Make live update polling configurable"
jenkins-bot [Fri, 22 Sep 2017 17:38:59 +0000 (17:38 +0000)]
Merge "RCFilters: Make live update polling configurable"

3 years agoMerge "RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews"
jenkins-bot [Fri, 22 Sep 2017 17:35:07 +0000 (17:35 +0000)]
Merge "RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews"

3 years agoRCFilters: Make live update polling configurable
Stephane Bisson [Thu, 21 Sep 2017 20:43:23 +0000 (16:43 -0400)]
RCFilters: Make live update polling configurable

Introducing $wgStructuredChangeFiltersLiveUpdatePollingRate
to configure the polling rate for live update.

Allows disabling polling completely by setting it to 0.

Change-Id: I13d3a4bb642c55a16e442f8f8d650c637f13f72c

3 years agoMerge "RCFilters: restore watch/unwatch link"
jenkins-bot [Fri, 22 Sep 2017 17:17:53 +0000 (17:17 +0000)]
Merge "RCFilters: restore watch/unwatch link"

3 years agoMerge "EditPage: Avoid unnecessary calls to Article::getContext()"
jenkins-bot [Fri, 22 Sep 2017 16:21:26 +0000 (16:21 +0000)]
Merge "EditPage: Avoid unnecessary calls to Article::getContext()"

3 years agoRemove use of MWException in MapCacheLRU
Aaron Schulz [Fri, 22 Sep 2017 15:38:46 +0000 (17:38 +0200)]
Remove use of MWException in MapCacheLRU

Change-Id: I830555ffcb1b50bdc54e552daa469e2c5e00611d

3 years agoMerge "RCFilters: Start the toplinks collapsed/expanded by cookie value"
jenkins-bot [Fri, 22 Sep 2017 10:55:34 +0000 (10:55 +0000)]
Merge "RCFilters: Start the toplinks collapsed/expanded by cookie value"

3 years agoRCFilters: restore watch/unwatch link
Stephane Bisson [Fri, 22 Sep 2017 10:35:58 +0000 (06:35 -0400)]
RCFilters: restore watch/unwatch link

Use jQuery event delegation to handle all
present and future watch/unwatch links.

Bug: T176264
Change-Id: If372c480e3e3809485027744b99caa6d4c94f86a

3 years agoEditPage: Avoid unnecessary calls to Article::getContext()
Kunal Mehta [Fri, 22 Sep 2017 09:05:15 +0000 (02:05 -0700)]
EditPage: Avoid unnecessary calls to Article::getContext()

Change-Id: I18a7f3b3eb1a9b18ea6ca20ad43878f4740f4e47

3 years agoAdd release notes for EditPage changes in 1.30
Kunal Mehta [Fri, 22 Sep 2017 09:20:19 +0000 (02:20 -0700)]
Add release notes for EditPage changes in 1.30

Change-Id: I42368cd97a2b25fb5d31c551442a527465157ce8

3 years agoRCFilters: Start the toplinks collapsed/expanded by cookie value
Moriel Schottlender [Thu, 21 Sep 2017 23:15:47 +0000 (16:15 -0700)]
RCFilters: Start the toplinks collapsed/expanded by cookie value

Prevent "jumping" of the content by initializing the top links already
collapsed or expanded depending on the cookie value.

Bug: T176380
Change-Id: I6c494b42ec6f029b60182607faa37feba062b597

3 years agoMerge "mw.loader: Simplify getVersion and getState"
jenkins-bot [Fri, 22 Sep 2017 00:16:32 +0000 (00:16 +0000)]
Merge "mw.loader: Simplify getVersion and getState"

3 years agomw.loader: Simplify getVersion and getState
Timo Tijhof [Thu, 21 Sep 2017 23:10:45 +0000 (00:10 +0100)]
mw.loader: Simplify getVersion and getState

This undefined check no longer makes sense since there are now
defaults for these in register(). There is no supported scenario
in which a module would have a key in the registry but not
have these properties defined, or have them defined with
the undefined value.

Change-Id: I945871861ccf3659c2d7dd021aa87dfd747f22b9

3 years agoresourceloader: Use ES5 Array#filter instead of jQuery.grep
Timo Tijhof [Thu, 21 Sep 2017 22:31:48 +0000 (23:31 +0100)]
resourceloader: Use ES5 Array#filter instead of jQuery.grep

Same or better performance in Chrome Canary and latest WebKit.
Further reduces reliance on jQuery in base module.

Change-Id: I691b73b837178b76cff665cbd52f5e5067672a6e

3 years agoRCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews
Stephane Bisson [Thu, 21 Sep 2017 20:24:38 +0000 (16:24 -0400)]
RCFilters: remove wgStructuredChangeFiltersEnableExperimentalViews

Not used anymore.

Change-Id: I1afe736db76eef6ddae5c602d8e24fddfd807a3a

3 years agoRCFilters: Make 'lastRevision' filter include non-rev types
Stephane Bisson [Thu, 21 Sep 2017 20:17:22 +0000 (16:17 -0400)]
RCFilters: Make 'lastRevision' filter include non-rev types

Make 'lastRevision' filter behave like its predecessor (expanded)
by including the non-rev types (RC_LOG and others added via hook).

Bug: T176328
Change-Id: I2312fd536716f0b07637ed4caf225650a4ffe70c

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 21 Sep 2017 20:05:48 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4587d08701d8d44621e69077ef4a1b1fcce09025

3 years agoMerge "RCFilters: Use findRelativeSelectableItem instead of getRelativeSelectableitem"
jenkins-bot [Thu, 21 Sep 2017 18:21:19 +0000 (18:21 +0000)]
Merge "RCFilters: Use findRelativeSelectableItem instead of getRelativeSelectableitem"

3 years agoMerge "apisandbox.js: Use findFirstSelectableitem instead of getFirstSelectableItem"
jenkins-bot [Thu, 21 Sep 2017 18:14:24 +0000 (18:14 +0000)]
Merge "apisandbox.js: Use findFirstSelectableitem instead of getFirstSelectableItem"

3 years agoMerge "RCFilters: Make the interface not jump around while loading"
jenkins-bot [Thu, 21 Sep 2017 18:03:34 +0000 (18:03 +0000)]
Merge "RCFilters: Make the interface not jump around while loading"

3 years agoMerge "WLFilters: Don't hide .watchlistDetails while loading"
jenkins-bot [Thu, 21 Sep 2017 18:00:33 +0000 (18:00 +0000)]
Merge "WLFilters: Don't hide .watchlistDetails while loading"

3 years agoMerge "Clean up X-Content-Dimensions"
jenkins-bot [Thu, 21 Sep 2017 17:36:57 +0000 (17:36 +0000)]
Merge "Clean up X-Content-Dimensions"

3 years agoClean up X-Content-Dimensions
Gilles Dubuc [Thu, 21 Sep 2017 13:17:10 +0000 (15:17 +0200)]
Clean up X-Content-Dimensions

Bug: T175689
Change-Id: I20d93afd85b4d35c67c60193fa3026cebde71b0e

3 years agoRCFilters: Make the interface not jump around while loading
Roan Kattouw [Thu, 21 Sep 2017 00:11:22 +0000 (17:11 -0700)]
RCFilters: Make the interface not jump around while loading

* Move the "show new changes" widget into the .rcfilters-head container
** It doesn't conceptually belong here, but this way the min-height
   trick can capture it
* Increase the min-height to account for "show new changes" and drift
* Set a different (higher) min-height on the watchlist
* Adjust the loading spinner position to account for "show new changes" having moved
* Don't apply a margin-top to the first table in WatchlistTopSectionWidget,
  only the second one
* Make .watchlistDetails float while loading
** This is because it starts outside rcfilters-head but is then moved into it.
   Floating it makes it not take any space, which makes the min-height math
   a lot easier (and tolerant to taller .watchlistDetails divs like on enwiki)
* Don't remove the margin and padding from the first h4, this causes jumpiness
** This does increase whitespace slightly, if we want to fix that we could
   set a negative margin-bottom on rcfilters-head instead
* Move the margin-left rules making space for the highlights into a mixin,
  and apply it before initialization instead of after

Bug: T176300
Change-Id: I353deab90cd944209d7540559c6b41decad20e7d

3 years agoMerge "EditPage: Stop using globals for configuration in non-static functions"
jenkins-bot [Thu, 21 Sep 2017 16:45:44 +0000 (16:45 +0000)]
Merge "EditPage: Stop using globals for configuration in non-static functions"

3 years agoMerge "EditPage: Deprecate $mArticle and $mTitle for public usage"
jenkins-bot [Thu, 21 Sep 2017 16:45:40 +0000 (16:45 +0000)]
Merge "EditPage: Deprecate $mArticle and $mTitle for public usage"

3 years agoMerge "EditPage: Deprecate public isCssJsSubpage related member variables"
jenkins-bot [Thu, 21 Sep 2017 16:45:37 +0000 (16:45 +0000)]
Merge "EditPage: Deprecate public isCssJsSubpage related member variables"

3 years agoMerge "EditPage: Don't allow clients that mangle unicode to edit"
jenkins-bot [Thu, 21 Sep 2017 16:45:33 +0000 (16:45 +0000)]
Merge "EditPage: Don't allow clients that mangle unicode to edit"

3 years agoMerge "registration: Fix typo in validator"
jenkins-bot [Thu, 21 Sep 2017 13:02:34 +0000 (13:02 +0000)]
Merge "registration: Fix typo in validator"

3 years agoEditPage: Stop using globals for configuration in non-static functions
Kunal Mehta [Thu, 21 Sep 2017 02:53:11 +0000 (19:53 -0700)]
EditPage: Stop using globals for configuration in non-static functions

Bug: T144366
Change-Id: Ie884527b64f86b6a989117a45c6ffa6d1893d2b7

3 years agoEditPage: Deprecate $mArticle and $mTitle for public usage
Kunal Mehta [Thu, 21 Sep 2017 02:02:30 +0000 (19:02 -0700)]
EditPage: Deprecate $mArticle and $mTitle for public usage

Change-Id: I2a931826ea142f2214c5f29944c3c3b18da19bad

3 years agoEditPage: Deprecate public isCssJsSubpage related member variables
Kunal Mehta [Wed, 20 Sep 2017 05:06:43 +0000 (22:06 -0700)]
EditPage: Deprecate public isCssJsSubpage related member variables

Just use the functions directly.

Change-Id: Ie374a5cd4c9255b595ff4a88025738720434a802

3 years agoEditPage: Don't allow clients that mangle unicode to edit
Max Semenik [Mon, 28 Aug 2017 21:14:44 +0000 (14:14 -0700)]
EditPage: Don't allow clients that mangle unicode to edit

Get rid of the hack that turns unicode into hexadecimal codes for
browsers that don't support unicode, and prevent their edits entirely.

And instead of relying on $wgBrowserBlacklist, use a hidden HTML form
field - if the contents are mangled and don't match the original, then
reject the edit.

Bug: T67297
Change-Id: I20c2e396d7dfd6a3b23b94b218f94a847522576b

3 years agoWLFilters: Don't hide .watchlistDetails while loading
Roan Kattouw [Wed, 20 Sep 2017 22:37:19 +0000 (15:37 -0700)]
WLFilters: Don't hide .watchlistDetails while loading

It doesn't actually get replaced, just relocated slightly.
Also, watchlist-details is abused for community tools on some wikis,
including enwiki. (watchlist-summary is the right place for that though.)

Bug: T176300
Change-Id: Ic9605b9910c1953ef2536de4ab1b57ec125f0539

3 years agoMerge "Lazy creation for heavy menu"
jenkins-bot [Wed, 20 Sep 2017 22:06:27 +0000 (22:06 +0000)]
Merge "Lazy creation for heavy menu"

3 years agoMerge "Fix case of SpecialRecentChanges class"
jenkins-bot [Wed, 20 Sep 2017 21:29:47 +0000 (21:29 +0000)]
Merge "Fix case of SpecialRecentChanges class"

3 years agoMerge "Prepare for 1.31 branch"
jenkins-bot [Wed, 20 Sep 2017 21:10:08 +0000 (21:10 +0000)]
Merge "Prepare for 1.31 branch"

3 years agoFix ip_changes insert counting
Max Semenik [Wed, 20 Sep 2017 20:39:49 +0000 (13:39 -0700)]
Fix ip_changes insert counting

Change-Id: I02b457d9dcaadc97eead623e42a5a1ccf8335724

3 years agoMerge "Do not depend on PHP_EOL in HTMLRestrictionsField"
jenkins-bot [Wed, 20 Sep 2017 20:18:19 +0000 (20:18 +0000)]
Merge "Do not depend on PHP_EOL in HTMLRestrictionsField"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 20 Sep 2017 20:14:28 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I1058808c8a06869776b8c23e518ff260be9ab6d6

3 years agoFix case of SpecialRecentChanges class
Umherirrender [Wed, 20 Sep 2017 18:11:09 +0000 (20:11 +0200)]
Fix case of SpecialRecentChanges class

Test fails with $wgAutoloadAttemptLowercase = false

Change-Id: Ib8cd202d36d35a36e7513f81cea4a7f8346661bc

3 years agoDo not depend on PHP_EOL in HTMLRestrictionsField
Umherirrender [Wed, 20 Sep 2017 20:01:34 +0000 (22:01 +0200)]
Do not depend on PHP_EOL in HTMLRestrictionsField

HTMLRestrictionsFieldTest::provideValidate only provide test cases with
\n, which fails on windows machine.
I see no reason to use the system depending constant here

Change-Id: I7caf2c4d06c84cac69e20e03d00a93bcd8e7d405

3 years agoLazy creation for heavy menu
eranroz [Tue, 19 Sep 2017 21:29:33 +0000 (00:29 +0300)]
Lazy creation for heavy menu

Assumptions:
* Generally if we have a model we don't need UI
* UI can be created lazy if it is not shown to user

Bug: T176250
Change-Id: Iba7f889d8610de2eb3056248cd1c664b0cd90940

3 years agoFix warning in DifferenceEngine
Brad Jorsch [Wed, 20 Sep 2017 19:29:54 +0000 (15:29 -0400)]
Fix warning in DifferenceEngine

Make sure that the ar_namespace and ar_text fields are selected from the
database.

Change-Id: Ic2e8f99f43025510c14e0a8ff2b708b378cf7ef3

3 years agoMerge "Set wgUseRCPatrol in ChangesListSpecialPageTest"
jenkins-bot [Wed, 20 Sep 2017 19:36:30 +0000 (19:36 +0000)]
Merge "Set wgUseRCPatrol in ChangesListSpecialPageTest"

3 years agoSet wgUseRCPatrol in ChangesListSpecialPageTest
Umherirrender [Wed, 20 Sep 2017 18:41:59 +0000 (20:41 +0200)]
Set wgUseRCPatrol in ChangesListSpecialPageTest

wgUseRCPatrol = false makes the tests fail

Change-Id: I18965d33171137ff182800512c8c0e8e63de124e

3 years agoMerge "Add classes to HTMLCheckMatrix items to identify forced ones"
jenkins-bot [Wed, 20 Sep 2017 19:13:05 +0000 (19:13 +0000)]
Merge "Add classes to HTMLCheckMatrix items to identify forced ones"

3 years agoMerge "RCFilters: Don't grey out results area when initializing, unless there's a...
jenkins-bot [Wed, 20 Sep 2017 17:30:00 +0000 (17:30 +0000)]
Merge "RCFilters: Don't grey out results area when initializing, unless there's a default saved query"

3 years agoAvoid per-title page_lang DB queries HTMLCacheUpdateJob
Aaron Schulz [Thu, 14 Sep 2017 13:43:53 +0000 (15:43 +0200)]
Avoid per-title page_lang DB queries HTMLCacheUpdateJob

Change-Id: Ie2fa64400f05d90e615bd8ff26225e197605d244

3 years agoMerge "EditPage: Try to avoid using $wgTitle"
jenkins-bot [Wed, 20 Sep 2017 15:59:47 +0000 (15:59 +0000)]
Merge "EditPage: Try to avoid using $wgTitle"

3 years agoMerge "Replace uses of each()"
jenkins-bot [Wed, 20 Sep 2017 15:35:19 +0000 (15:35 +0000)]
Merge "Replace uses of each()"

3 years agoMerge "EditPage: Don't use $wgRequest"
jenkins-bot [Wed, 20 Sep 2017 15:24:31 +0000 (15:24 +0000)]
Merge "EditPage: Don't use $wgRequest"

3 years agoMerge "Improve populateIpChanges.php reporting"
jenkins-bot [Wed, 20 Sep 2017 15:03:41 +0000 (15:03 +0000)]
Merge "Improve populateIpChanges.php reporting"

3 years agoReplace uses of each()
Brad Jorsch [Tue, 19 Sep 2017 19:57:18 +0000 (15:57 -0400)]
Replace uses of each()

It's deprecated in PHP 7.2, may as well replace it now.

I note that, contrary to claims at
https://wiki.php.net/rfc/deprecations_php_7_2#each, none of our uses
were trivially replaceable with foreach.

* wfArrayDiff2_cmp() is processing two arrays by value in parallel.
* MagicWordArray::parseMatch() is doing something funky with the data
  structure returned by preg_match().
* HashRing was using it like "nextKey()", replaced with calls to key()
  and next().
* FormatMetadata and IndexPager were both using it as a shorter way to
  get both key() and current() for the first element in the array. I
  suppose a foreach(){ break; } would do the same, but that's confusing.

Bug: T174354
Change-Id: I36169a04c764fdf1bfd6603395111c6fe0aae5eb

3 years agoMerge "Bump LocalFile::VERSION to invalidate file page cache"
jenkins-bot [Wed, 20 Sep 2017 09:50:06 +0000 (09:50 +0000)]
Merge "Bump LocalFile::VERSION to invalidate file page cache"

3 years agoDetect query timeouts and throw a specific exception
Matthew Flaschen [Mon, 18 Sep 2017 11:38:59 +0000 (07:38 -0400)]
Detect query timeouts and throw a specific exception

Throw DBQueryTimeoutError if a database query error is detected
to be a timeout.

Only DatabaseMysqlBase has been updated here.

This is a subclass of DBQueryError, so existing catch'es will work.

Bug: T175775
Change-Id: I4749dc33ad530d9b22504f02106b1ca49e8eb167

3 years agoregistration: Fix typo in validator
Kunal Mehta [Wed, 20 Sep 2017 06:45:51 +0000 (23:45 -0700)]
registration: Fix typo in validator

Change-Id: Ic4f0eb5f05504922c20213e1d321fa14c979b6f8

3 years agoMerge "Do not run tests that depend on curl if it is not loaded"
jenkins-bot [Wed, 20 Sep 2017 04:49:13 +0000 (04:49 +0000)]
Merge "Do not run tests that depend on curl if it is not loaded"

3 years agoRCFilters: Don't grey out results area when initializing, unless there's a default...
Roan Kattouw [Wed, 20 Sep 2017 00:54:55 +0000 (17:54 -0700)]
RCFilters: Don't grey out results area when initializing, unless there's a default saved query

Check whether there is a default saved query on the server side, and if there is,
add the mw-rcfilters-ui-loading class.

Also centralize the code related to the saved query preferences.

Bug: T173533
Change-Id: I4138fde22bdd8cc55c65846b91184c3ad3057244

3 years agoMerge "EditPage::getCheckboxes: Stop respecting wgUseMediaWikiUIEverywhere"
jenkins-bot [Wed, 20 Sep 2017 04:36:58 +0000 (04:36 +0000)]
Merge "EditPage::getCheckboxes: Stop respecting wgUseMediaWikiUIEverywhere"

3 years agoEditPage: Try to avoid using $wgTitle
Kunal Mehta [Wed, 20 Sep 2017 04:30:21 +0000 (21:30 -0700)]
EditPage: Try to avoid using $wgTitle

The most common code path is from EditAction, so make sure
EditPage::setContextTitle() is called in that case.

Log any uses that fallback to $wgTitle in the GlobalTitleFail log group.

Bug: T144366
Change-Id: Ie6c7dfbaa432239389d210051372427b8fa045b4

3 years agoEditPage: Don't use $wgRequest
Kunal Mehta [Mon, 18 Sep 2017 20:50:46 +0000 (13:50 -0700)]
EditPage: Don't use $wgRequest

Bug: T144366
Change-Id: I392e165a6ba3c913ce6e415dbfcfb3cd51178a4e

3 years agoImprove populateIpChanges.php reporting
Max Semenik [Wed, 20 Sep 2017 03:38:20 +0000 (20:38 -0700)]
Improve populateIpChanges.php reporting

Instead of just the rows we attempted to insert, also count
actually inserted ones.

Change-Id: Ie747cb41873640776281794a90dbe3b6b8e3fa84

3 years agoMerge "RCFilters: Don't remove mw-changeslist-line-prefix in enhanced mode"
jenkins-bot [Wed, 20 Sep 2017 02:49:45 +0000 (02:49 +0000)]
Merge "RCFilters: Don't remove mw-changeslist-line-prefix in enhanced mode"

3 years agoMerge "RCFilters: Redo the way spinners and ready/loading states are managed"
jenkins-bot [Wed, 20 Sep 2017 02:40:17 +0000 (02:40 +0000)]
Merge "RCFilters: Redo the way spinners and ready/loading states are managed"

3 years agoDo not run tests that depend on curl if it is not loaded
Huji Lee [Tue, 19 Sep 2017 03:14:00 +0000 (23:14 -0400)]
Do not run tests that depend on curl if it is not loaded

Bug: T176193
Change-Id: Ia7b9b0196f800eb14463acc2a24df5ac1e48f3ed

3 years agoMerge "Update OOjs UI to v0.23.1"
jenkins-bot [Wed, 20 Sep 2017 01:31:54 +0000 (01:31 +0000)]
Merge "Update OOjs UI to v0.23.1"

3 years agoMerge "Mark various skin/OutputPage hooks as unabortable"
jenkins-bot [Wed, 20 Sep 2017 01:14:34 +0000 (01:14 +0000)]
Merge "Mark various skin/OutputPage hooks as unabortable"

3 years agoUpdate OOjs UI to v0.23.1
Volker E [Wed, 20 Sep 2017 00:58:44 +0000 (17:58 -0700)]
Update OOjs UI to v0.23.1

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.1

Depends-on: If38f5a074d655542c5704a9b17617d299ee17921
Change-Id: Iac39c51049266b302d66658bf1ea6b67c1bb4c8c

3 years agoRCFilters: Redo the way spinners and ready/loading states are managed
Roan Kattouw [Wed, 20 Sep 2017 00:00:24 +0000 (17:00 -0700)]
RCFilters: Redo the way spinners and ready/loading states are managed

The mw-rcfilters-ui-ready class was being set on no fewer than 4 elements,
all with different meanings, and some with no relevant styling at all.
It also did not distinguish between "the UI is initializing" and
"we are loading new results".

Remove mw-rcfilters-ui-ready completely (and remove some code that added
or removed it pointlessly), and create two new CSS classes on the <body>.
mw-rcfilters-ui-initialized is added when the UI has initialized, and
is used to hide the old UI and display a spinner while the UI loads.
mw-rcfilters-ui-loading is added when we start loading new results
and removed when they arrive; it's used to grey out the results
area and add a spinner.

Bonus: make the spinner appear in a different place depending on why
it's being shown: when initializing, it's shown in the place where the
UI will soon appear; when loading, it's shown near the top of the
changes list.

Change-Id: Ib5c8a36654ba44880823fdade8cad52ffa59ed69

3 years agoYet another attempt to fix the populateIpChanges script
MusikAnimal [Tue, 19 Sep 2017 23:51:34 +0000 (19:51 -0400)]
Yet another attempt to fix the populateIpChanges script

It would seem we'd need to update $blockStart if there are no results
for a given block, and more importantly, continue and not break!

Bug: T175962
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b954e064

3 years agoRCFilters: Don't remove mw-changeslist-line-prefix in enhanced mode
Roan Kattouw [Tue, 19 Sep 2017 21:41:26 +0000 (14:41 -0700)]
RCFilters: Don't remove mw-changeslist-line-prefix in enhanced mode

It contains the 'x' buttons to unwatch pages when the relevant
preference is enabled, so we shouldn't remove it.

To make the table still work, we have to add an extra <td>
to the nested rows, and start the highlight one row later.

Bug: T176264
Change-Id: Ie8eb913d55165ad2c548230cd61cd9ee189d9504

3 years agoDon't attempt to copy to ip_changes in PageArchive class.
MusikAnimal [Tue, 19 Sep 2017 22:11:28 +0000 (18:11 -0400)]
Don't attempt to copy to ip_changes in PageArchive class.

This actually happens in Revision::insertOn, so the code is redundant,
but also shouldn't ever execute because it erroneously was checking
for ar_rev_id=0 and not ar_user=0.

This is sometimes causing errors in production, in the rare cases
where ar_rev_id is NULL, and hence (int)ar_rev_id evaluates to 0.

Change-Id: I35a7310f600a9db683d7dc0e730da8ff31e337a2

3 years agoMerge "CSSMin: Mangle whitespace in embedded SVGs"
jenkins-bot [Tue, 19 Sep 2017 21:27:31 +0000 (21:27 +0000)]
Merge "CSSMin: Mangle whitespace in embedded SVGs"

3 years agoMerge "Attempt to fix populateIpChanges maintenance script"
jenkins-bot [Tue, 19 Sep 2017 20:40:28 +0000 (20:40 +0000)]
Merge "Attempt to fix populateIpChanges maintenance script"

3 years agoMerge "ContribsPager: Check if target is an IP range outside foreach loop"
jenkins-bot [Tue, 19 Sep 2017 20:31:15 +0000 (20:31 +0000)]
Merge "ContribsPager: Check if target is an IP range outside foreach loop"

3 years agoAttempt to fix populateIpChanges maintenance script
MusikAnimal [Mon, 18 Sep 2017 20:57:26 +0000 (16:57 -0400)]
Attempt to fix populateIpChanges maintenance script

With the previous edition, some IP revisions failed to copy,
e.g. rev_id 1507693 on enwikivoyage. This change first fixes to go
by mBatchSize, and removes other redundant clauses in the query.

Bug: T175962
Change-Id: Ia5f3e275d8bef120090b4c60e6aec4c204d55d53

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 19 Sep 2017 20:14:03 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I7b3144ed162fda4b58dd1df58e7c0b7310f2a087

3 years agoMark various skin/OutputPage hooks as unabortable
Timo Tijhof [Sat, 19 Aug 2017 00:48:45 +0000 (17:48 -0700)]
Mark various skin/OutputPage hooks as unabortable

Follows-up I94c7ab656bd1a04. An initial pass of marking various
hooks as unabortable.

* BeforePageDisplay (T173411)
* OutputPageParserOutput
* AfterFinalPageOutput
* SkinTemplateNavigation (T107980)
* SkinTemplateNavigation::SpecialPage (T107980)
* SkinTemplateNavigation::Universal
* PersonalUrls

Bug: T173615
Change-Id: I0cb333dd5ff74f7dca725ff210200a0779a9a360

3 years agoMerge "CSSMin: Improve encoding of quotes in embedded SVGs"
jenkins-bot [Tue, 19 Sep 2017 19:01:18 +0000 (19:01 +0000)]
Merge "CSSMin: Improve encoding of quotes in embedded SVGs"

3 years agoCSSMin: Mangle whitespace in embedded SVGs
Roan Kattouw [Thu, 14 Sep 2017 18:32:07 +0000 (11:32 -0700)]
CSSMin: Mangle whitespace in embedded SVGs

Convert newlines and tabs to spaces (which can be unencoded),
and consolidate runs of multiple spaces into a single space.
Also remove any leading and trailing spaces that might result
(most files end in a newline, for example).

Bug: T175318
Change-Id: Ic66c6acb37079cae84dd80ab2d5f2c829cf2df96

3 years agoMerge "Update signature of UserGroupsChanged to match documentation"
jenkins-bot [Tue, 19 Sep 2017 18:51:53 +0000 (18:51 +0000)]
Merge "Update signature of UserGroupsChanged to match documentation"

3 years agoPrepare for 1.31 branch
James D. Forrester [Tue, 19 Sep 2017 18:34:47 +0000 (11:34 -0700)]
Prepare for 1.31 branch

Change-Id: I2a1ce7b7af7ef9991a054332593b1f63a0213469

3 years agoMerge "SpecialRecentchangeslinked: Unconditionally join on the page table"
jenkins-bot [Tue, 19 Sep 2017 18:07:12 +0000 (18:07 +0000)]
Merge "SpecialRecentchangeslinked: Unconditionally join on the page table"

3 years agoCSSMin: Improve encoding of quotes in embedded SVGs
Roan Kattouw [Wed, 13 Sep 2017 19:27:15 +0000 (12:27 -0700)]
CSSMin: Improve encoding of quotes in embedded SVGs

When a URL (data: or otherwise) contains quotes, don't wrap it in
double quotes (") but in single quotes ('). This then allows
us to unencode double quotes (") in the data URI embedding of SVGs.

Bug: T175318
Change-Id: I3e7eab64e1c3e82066014fb594f82d786983ce90

3 years agoDumpFilter is autoloaded. No need to require in maintenance script
Reedy [Sun, 17 Sep 2017 18:59:46 +0000 (19:59 +0100)]
DumpFilter is autoloaded. No need to require in maintenance script

Change-Id: Ib5c5e9a5144eb5454d1e498bf6f18d9e5829a52f

3 years agoUpdate signature of UserGroupsChanged to match documentation
Umherirrender [Sun, 17 Sep 2017 09:09:53 +0000 (11:09 +0200)]
Update signature of UserGroupsChanged to match documentation

UserGroupsChanged is called in Special:UserRights with seven args
The caller in User.php only has five

Change-Id: I221da323c79bb8da0113533d01b429249d15e7de

3 years agoMerge "Remove unused variables from closures"
jenkins-bot [Tue, 19 Sep 2017 17:27:52 +0000 (17:27 +0000)]
Merge "Remove unused variables from closures"

3 years agoSpecialRecentchangeslinked: Unconditionally join on the page table
Roan Kattouw [Tue, 19 Sep 2017 17:22:47 +0000 (10:22 -0700)]
SpecialRecentchangeslinked: Unconditionally join on the page table

As we do on SpecialRecentchanges and SpecialWatchlist already,
because the last revision filter needs it.

Bug: T176228
Change-Id: I65f0f971df24853999ca445f968dd49fb0640066

3 years agoMerge "Fix link prefix/suffixes around Category and Language links (take 2)."
jenkins-bot [Tue, 19 Sep 2017 16:59:58 +0000 (16:59 +0000)]
Merge "Fix link prefix/suffixes around Category and Language links (take 2)."