lhc/web/wiklou.git
4 years agospecials: Avoid the use of global variables in Special:Version
Derick Alangi [Tue, 29 Jan 2019 17:40:58 +0000 (18:40 +0100)]
specials: Avoid the use of global variables in Special:Version

We're moving away from globals to Config this patch attempts to
clean off some globals whose values can be nicely gotten via the
use of Config.

Bug: T72638
Change-Id: I25516873c215b74cdd425d023e877e5cdc3d6149

4 years agoMerge "Reinstate small category refresh logic in LinksDeletionUpdate"
jenkins-bot [Wed, 24 Apr 2019 15:33:54 +0000 (15:33 +0000)]
Merge "Reinstate small category refresh logic in LinksDeletionUpdate"

4 years agoMerge "Remove block notice tracking"
jenkins-bot [Wed, 24 Apr 2019 13:59:44 +0000 (13:59 +0000)]
Merge "Remove block notice tracking"

4 years agoMerge "mediawiki.action.view.metadata: Remove JavaScript part of initial state"
jenkins-bot [Wed, 24 Apr 2019 13:44:34 +0000 (13:44 +0000)]
Merge "mediawiki.action.view.metadata: Remove JavaScript part of initial state"

4 years agoMerge "StubObject: Use 'self' instead of 'StubObject' (or <ClassName>)"
jenkins-bot [Wed, 24 Apr 2019 11:26:19 +0000 (11:26 +0000)]
Merge "StubObject: Use 'self' instead of 'StubObject' (or <ClassName>)"

4 years agoMerge "UsersPager: Use CSS-based parentheses"
jenkins-bot [Wed, 24 Apr 2019 08:45:06 +0000 (08:45 +0000)]
Merge "UsersPager: Use CSS-based parentheses"

4 years agomediawiki.action.view.metadata: Remove JavaScript part of initial state
Fomafix [Wed, 24 Apr 2019 06:16:02 +0000 (08:16 +0200)]
mediawiki.action.view.metadata: Remove JavaScript part of initial state

THe HTML caches have expired. The JavaScript part of initialization of
the state is not necessary anymore.

This change is a follow up to 6400972e.

Change-Id: Ie87f972a73b2cd4a0444056002243ecc0b90fdb9

4 years agoReinstate small category refresh logic in LinksDeletionUpdate
Aaron Schulz [Tue, 23 Apr 2019 23:59:35 +0000 (16:59 -0700)]
Reinstate small category refresh logic in LinksDeletionUpdate

Add new Category::refreshCountsIfSmall() method that will do a non-locking
SELECT with LIMIT before deciding whether to do a full locking SELECT and
refresh. Call this from LinksDeletionUpdate.

Bug: T18036
Change-Id: I9de8311565988453b8e29a7f3d95d758182fcec1

4 years agoMerge "Split ApiErrorFormatter.php to have one class in one file"
jenkins-bot [Wed, 24 Apr 2019 00:05:09 +0000 (00:05 +0000)]
Merge "Split ApiErrorFormatter.php to have one class in one file"

4 years agoMerge "Gallery slideshow: Remove excess margin on controls"
jenkins-bot [Tue, 23 Apr 2019 23:12:08 +0000 (23:12 +0000)]
Merge "Gallery slideshow: Remove excess margin on controls"

4 years agoMerge "Gallery: Refactor CSS as LESS"
jenkins-bot [Tue, 23 Apr 2019 23:12:03 +0000 (23:12 +0000)]
Merge "Gallery: Refactor CSS as LESS"

4 years agoMerge "Gallery slideshow: Improve missing image and error handling"
jenkins-bot [Tue, 23 Apr 2019 23:11:55 +0000 (23:11 +0000)]
Merge "Gallery slideshow: Improve missing image and error handling"

4 years agoRemove block notice tracking
Dayllan Maza [Wed, 17 Apr 2019 19:04:15 +0000 (15:04 -0400)]
Remove block notice tracking

This is a clean up after collecting the necessary data related to
blocks and how often users see the block notices

See: https://phabricator.wikimedia.org/T189724

Bug: T214214
Depends-On: I047587c064e63e8bd4b933351edfec298f7c7956
Depends-On: I532a0cd95009109ba25caa8dd31badd5c1900da7
Change-Id: Icfa74ad6337c0a4f12ae24b43d36c0e3cb302a3b

4 years agoMerge "Gallery slideshow: Support MMV"
jenkins-bot [Tue, 23 Apr 2019 21:41:29 +0000 (21:41 +0000)]
Merge "Gallery slideshow: Support MMV"

4 years agoMerge "Alter two uses of hasOrMadeRecentMasterChanges() for consistency"
jenkins-bot [Tue, 23 Apr 2019 21:31:38 +0000 (21:31 +0000)]
Merge "Alter two uses of hasOrMadeRecentMasterChanges() for consistency"

4 years agoMerge "Hypenate ChronologyProtector HTTP headers"
jenkins-bot [Tue, 23 Apr 2019 21:31:33 +0000 (21:31 +0000)]
Merge "Hypenate ChronologyProtector HTTP headers"

4 years agoMerge "Keep ERROR_* constants in ApiStashEdit for backwards compatibility"
jenkins-bot [Tue, 23 Apr 2019 21:12:40 +0000 (21:12 +0000)]
Merge "Keep ERROR_* constants in ApiStashEdit for backwards compatibility"

4 years agoMerge "Avoid pre-send parse in DerivedPageDataUpdater due to isCountable()"
jenkins-bot [Tue, 23 Apr 2019 20:54:03 +0000 (20:54 +0000)]
Merge "Avoid pre-send parse in DerivedPageDataUpdater due to isCountable()"

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 23 Apr 2019 20:24:03 +0000 (22:24 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I0c876a9635fcabff26a042e73e3796f0eba375ef

4 years agoKeep ERROR_* constants in ApiStashEdit for backwards compatibility
Aaron Schulz [Tue, 23 Apr 2019 19:43:29 +0000 (12:43 -0700)]
Keep ERROR_* constants in ApiStashEdit for backwards compatibility

Follow-up to 285930668495b

Bug: T221689
Change-Id: Ibe275c69d5b47fd36efac4a91b2334970dd02fe8

4 years agoMerge "Remove last references to the long-gone CSS classes .editExternally and .editE...
jenkins-bot [Tue, 23 Apr 2019 19:02:33 +0000 (19:02 +0000)]
Merge "Remove last references to the long-gone CSS classes .editExternally and .editExternallyHelp"

4 years agoHypenate ChronologyProtector HTTP headers
Aaron Schulz [Tue, 23 Apr 2019 18:37:53 +0000 (11:37 -0700)]
Hypenate ChronologyProtector HTTP headers

Follow up to 6b6997dcf9036e372b4

Change-Id: I4c26c16821f3b57996c7d5c7195010c57a603041

4 years agoAlter two uses of hasOrMadeRecentMasterChanges() for consistency
Aaron Schulz [Tue, 19 Mar 2019 03:31:54 +0000 (20:31 -0700)]
Alter two uses of hasOrMadeRecentMasterChanges() for consistency

Rather than have the behavior vary and possibly break code or tests
when small changes happen, make User/NameTableStore more explicit
about when cache key purges happens.

This should reduce problems with certain fragile tests, such as those
that could be affected by 03908112635f when --use-normal tables is not
used. Ideally, any fragility should be ironed out of effected code.

Change-Id: Ibe5d1bb4bece2526bc0da99648f7ba73bdc0ffa5

4 years agoMerge "Accept new "MediaWiki-ChronologyClientId" HTTP header"
jenkins-bot [Tue, 23 Apr 2019 18:21:42 +0000 (18:21 +0000)]
Merge "Accept new "MediaWiki-ChronologyClientId" HTTP header"

4 years agoUsersPager: Use CSS-based parentheses
Roan Kattouw [Fri, 19 Apr 2019 21:44:27 +0000 (14:44 -0700)]
UsersPager: Use CSS-based parentheses

Tell Linker::userToolLinks() and Linker::userToolLinksRedContribs()
to omit parentheses, and load the CSS that fills them in.

Change-Id: Ie979537abed226e945cf1918b3ee240ae78ee24e

4 years agoMerge "GlobalFunctions: Hard deprecate wfGetLBFactory() function"
jenkins-bot [Tue, 23 Apr 2019 17:01:11 +0000 (17:01 +0000)]
Merge "GlobalFunctions: Hard deprecate wfGetLBFactory() function"

4 years agoMerge "Relax SpecialPageFatalTest about deprecation notices"
jenkins-bot [Tue, 23 Apr 2019 16:40:53 +0000 (16:40 +0000)]
Merge "Relax SpecialPageFatalTest about deprecation notices"

4 years agoGlobalFunctions: Hard deprecate wfGetLBFactory() function
Derick Alangi [Tue, 23 Apr 2019 15:42:33 +0000 (16:42 +0100)]
GlobalFunctions: Hard deprecate wfGetLBFactory() function

Usage of this function has almost disappeard from both core and
all mediawiki extensions. Kill this function in MW 1.35.

Depends-On: Id415d70aa0090c01ea04c3156aecd76caa8e83f8
Change-Id: I95f42b1631caf5ae026b9b7a3ced277bf9fa0608

4 years agoCapitalize native name of Western Armenian
jhsoby [Wed, 3 Apr 2019 15:53:57 +0000 (17:53 +0200)]
Capitalize native name of Western Armenian

Language names in Western Armenian start with capital letters.

Bug: T219975
Change-Id: Ic4e1c8ce395324a0e68a2212576fcfbc3b22bb2f

4 years agoGallery slideshow: Remove excess margin on controls
Ed Sanders [Fri, 19 Apr 2019 13:41:12 +0000 (14:41 +0100)]
Gallery slideshow: Remove excess margin on controls

Bug: T196722
Change-Id: I09764802a9b5b3739b53933b9d74edc42ee38986

4 years agoGallery: Refactor CSS as LESS
Ed Sanders [Fri, 19 Apr 2019 13:36:33 +0000 (14:36 +0100)]
Gallery: Refactor CSS as LESS

Change-Id: I42669a3445113cbbe09a58cd7524dea25c03b8a0

4 years agoGallery slideshow: Improve missing image and error handling
Ed Sanders [Fri, 19 Apr 2019 13:08:07 +0000 (14:08 +0100)]
Gallery slideshow: Improve missing image and error handling

Change-Id: I6aae5801178aa66fc40d40b9dec239a34b0ee029

4 years agoMerge "Define index types as strings"
jenkins-bot [Tue, 23 Apr 2019 08:57:59 +0000 (08:57 +0000)]
Merge "Define index types as strings"

4 years agoMerge "Remove references to field rev_text_id"
jenkins-bot [Tue, 23 Apr 2019 03:13:00 +0000 (03:13 +0000)]
Merge "Remove references to field rev_text_id"

4 years agoRemove references to field rev_text_id
Bill Pirkle [Tue, 2 Apr 2019 14:37:55 +0000 (09:37 -0500)]
Remove references to field rev_text_id

Field rev_text_id is being retired as part of MCR Schema Migration.
Remove references to this field from maintenance scripts.

Bug: T198341
Change-Id: I43ab93c44cbd0a2a2479baf848f50348e1e4762b

4 years agoMake the ratio of requests getting Priority Hints configurable
Gilles Dubuc [Wed, 3 Apr 2019 07:06:38 +0000 (09:06 +0200)]
Make the ratio of requests getting Priority Hints configurable

This will allow to create 2 separate populations in
order to verify the effect of the hint.

It's fine if it's not exactly balanced in practice,
what matters is getting a significant amount of
traffic for both scenarios (origin trial is enabled +
an image is given high prio/origin trial is enabled +
no image is given special treatment).

Bug: T216499
Change-Id: I373960b2bed8437c2e97e6d729d43aff6901046c

4 years agoparser: Remove deprecated Parser class attribute $mUniqPrefix
Derick Alangi [Sun, 7 Apr 2019 13:12:40 +0000 (14:12 +0100)]
parser: Remove deprecated Parser class attribute $mUniqPrefix

This variable was deprecated in 1.26 and per a quick search using
Code Search: https://codesearch.wmflabs.org/search/?q=mUniqPrefix&i=nope&files=&repos=
it's no longer used. Hence, removed.

Change-Id: Ic8f939dde3ea511e8e46faf0f1b212d3db2d80cd

4 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 22 Apr 2019 07:01:51 +0000 (09:01 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I5d5889f6c669fe3f8600b398baf88501c95e2a28

4 years agoMerge "Add support for new Japanese era name "Reiwa""
jenkins-bot [Mon, 22 Apr 2019 03:35:58 +0000 (03:35 +0000)]
Merge "Add support for new Japanese era name "Reiwa""

4 years agoSplit ApiErrorFormatter.php to have one class in one file
Zoranzoki21 [Sat, 20 Apr 2019 22:38:11 +0000 (00:38 +0200)]
Split ApiErrorFormatter.php to have one class in one file

Change-Id: I5c6904e32f9bc7fe3aac511c56b03757bfde15a9

4 years agoMerge "registration: Deprecate ExtensionRegistry->load() in favor of ->queue()"
jenkins-bot [Sun, 21 Apr 2019 20:18:36 +0000 (20:18 +0000)]
Merge "registration: Deprecate ExtensionRegistry->load() in favor of ->queue()"

4 years agoMerge "registration: Add release notes for environment abilities"
jenkins-bot [Sun, 21 Apr 2019 20:18:30 +0000 (20:18 +0000)]
Merge "registration: Add release notes for environment abilities"

4 years agoMerge "rdbms,linker: Simplify implode() with empty array"
jenkins-bot [Sun, 21 Apr 2019 15:55:10 +0000 (15:55 +0000)]
Merge "rdbms,linker: Simplify implode() with empty array"

4 years agordbms,linker: Simplify implode() with empty array
Fomafix [Sat, 20 Apr 2019 15:23:50 +0000 (17:23 +0200)]
rdbms,linker: Simplify implode() with empty array

https://php.net/manual/en/function.implode.php#example-6071
  // Empty string when using an empty array:
  var_dump(implode('hello', array())); // string(0) ""

Change-Id: If6349ba914bb522129d482a714a30b889a4c9f11

5 years agoMerge "jquery.suggestions: Correctly place dropdown for inputs with 'position: fixed'"
jenkins-bot [Sun, 21 Apr 2019 01:48:24 +0000 (01:48 +0000)]
Merge "jquery.suggestions: Correctly place dropdown for inputs with 'position: fixed'"

5 years agoRemove last references to the long-gone CSS classes .editExternally and .editExternal...
Jack Phoenix [Sat, 20 Apr 2019 20:46:19 +0000 (23:46 +0300)]
Remove last references to the long-gone CSS classes .editExternally and .editExternallyHelp

External editor/diff stuff was removed from core in 4be62363520d02f9d5bf4929b9abee3521abfb53 (MW 1.22)

The external editor stuff was originally introduced in r7859 (24 March 2005).

r8412 added the class into the new i18n msgs introduced in that revision, 'noimage' and 'uploadnnewversion'.

The .editExternally and .editExternallyHelp classes were lost in r8738/r8739 (29 April 2005).

r48967 (28 March 2009) added the ID "mw-imagepage-edit-external" ID to the ImagePage "edit in an external editor" link, which once used the "editExternally" and "editExternallyHelp" classes.

Change-Id: I8c5676b1f4725908b649be243dc923dd1d48b221

5 years agoMWNamespace: Remove deprecated method ::canTalk() and test suit
Derick Alangi [Sat, 20 Apr 2019 15:24:39 +0000 (16:24 +0100)]
MWNamespace: Remove deprecated method ::canTalk() and test suit

This method was deprecated in .30 hence remove as the usage is actually
zero in extensions and one only in core.

Usage:

https://codesearch.wmflabs.org/search/?q=%3A%3AcanTalk%5C(&i=nope&files=&repos=

Change-Id: Ia18c63f95c969d13c28ffb1afa376ec2df2002a3

5 years agoGallery slideshow: Support MMV
Ed Sanders [Fri, 19 Apr 2019 12:44:42 +0000 (13:44 +0100)]
Gallery slideshow: Support MMV

Create a new $imgLink and $img for each image, set the
'image' class on $imgLink and fire 'wikipage.content' hook.

Bug: T181470
Change-Id: I9b705b0b6b2c1c4e40e1c7c120fe90fe26d259da

5 years agoUser: Remove deprecated ::randomPassword() method
Derick Alangi [Fri, 19 Apr 2019 23:19:35 +0000 (00:19 +0100)]
User: Remove deprecated ::randomPassword() method

Usage:

https://codesearch.wmflabs.org/search/?q=(%3A%3A%7C-%3E)randomPassword%5C(&i=nope&files=&repos=

Only TwitterLogin (an unmaintained) extension still using it and
this patch I2c8d395dd2296a233f4 removes it.

Depends-On: I2c8d395dd2296a233f46abd44b89604c579c3020
Change-Id: I549d536e3c3e1da1c0c9c768640351bddf1d3449

5 years agoAdd support for new Japanese era name "Reiwa"
rxy [Mon, 1 Apr 2019 07:04:40 +0000 (16:04 +0900)]
Add support for new Japanese era name "Reiwa"

Bug: T219728
Change-Id: I28c26291c38e7e6c167011472236fb81a8adf032

5 years agofilerepo: fix return type of FileRepo::streamFileWithStatus()
Aaron Schulz [Sat, 20 Apr 2019 03:13:49 +0000 (20:13 -0700)]
filerepo: fix return type of FileRepo::streamFileWithStatus()

Change-Id: Ibb4610630203e22d921189699f6c51298212d5d3

5 years agoregistration: Add release notes for environment abilities
MGChecker [Sat, 20 Apr 2019 04:00:36 +0000 (06:00 +0200)]
registration: Add release notes for environment abilities

This adds release notes for Iff8512530b08.

Bug: T212472
Change-Id: I7ec3db19e9d028b56f7a7c8529ab7c27e48b8c65

5 years agoAccept new "MediaWiki-ChronologyClientId" HTTP header
Aaron Schulz [Fri, 19 Apr 2019 21:58:34 +0000 (14:58 -0700)]
Accept new "MediaWiki-ChronologyClientId" HTTP header

This is not used when the ID is already in "cpPosIndex".

Also, prefix the "ChronologyProtection" header with "MediaWiki-".
The header is currently usused but might be useful for services
in the future.

Bug: T212550
Change-Id: Ia871e95966d3550bac3dc4b2edb58e18359af7d9

5 years agoRemove FileRepo::streamFile()
Reedy [Sat, 20 Apr 2019 01:32:35 +0000 (02:32 +0100)]
Remove FileRepo::streamFile()

Change-Id: I96ccf5c96fabd1fa70d31eed75af384990e7eb5a

5 years agoStop calling FileRepo->streamFile()
Reedy [Sat, 20 Apr 2019 01:06:50 +0000 (02:06 +0100)]
Stop calling FileRepo->streamFile()

Change-Id: Ifdf379dc7f2501e561dfbc06f9afa7a9089306f2

5 years agoMerge "rcfeed: Replace usage of deprecated CommentStore::getStore()"
jenkins-bot [Sat, 20 Apr 2019 00:58:30 +0000 (00:58 +0000)]
Merge "rcfeed: Replace usage of deprecated CommentStore::getStore()"

5 years agoMerge "editstash: segregate stats by content type for more useful graphing"
jenkins-bot [Sat, 20 Apr 2019 00:44:49 +0000 (00:44 +0000)]
Merge "editstash: segregate stats by content type for more useful graphing"

5 years agoeditstash: segregate stats by content type for more useful graphing
Aaron Schulz [Fri, 19 Apr 2019 21:10:27 +0000 (14:10 -0700)]
editstash: segregate stats by content type for more useful graphing

Change-Id: Ice590a163ab7790993e44995220ca093f90c7c4f

5 years agoMerge "rdbms: add getChronologyProtectorClientId() to ILBFactory"
jenkins-bot [Sat, 20 Apr 2019 00:18:19 +0000 (00:18 +0000)]
Merge "rdbms: add getChronologyProtectorClientId() to ILBFactory"

5 years agoAvoid pre-send parse in DerivedPageDataUpdater due to isCountable()
Aaron Schulz [Sat, 20 Apr 2019 00:05:40 +0000 (17:05 -0700)]
Avoid pre-send parse in DerivedPageDataUpdater due to isCountable()

Bug: T216306
Change-Id: I08087f1019049fb8f31fed0d1e757f4df8733a05

5 years agordbms: add getChronologyProtectorClientId() to ILBFactory
Stanislav Malyshev [Wed, 17 Apr 2019 23:46:18 +0000 (16:46 -0700)]
rdbms: add getChronologyProtectorClientId() to ILBFactory

Returns the client ID used by ChronologyProtector.

Bug: T212550
Change-Id: Ia7d24d6591d6a8696103c560ea4b2c9718fd0ec2

5 years agoMerge "Merge last-seen stash data at more points in SpecialWatchlist"
jenkins-bot [Fri, 19 Apr 2019 23:28:35 +0000 (23:28 +0000)]
Merge "Merge last-seen stash data at more points in SpecialWatchlist"

5 years agoMerge "RCFilters: display timestamp of new changes in refresh link"
jenkins-bot [Fri, 19 Apr 2019 23:24:56 +0000 (23:24 +0000)]
Merge "RCFilters: display timestamp of new changes in refresh link"

5 years agoMerge "Gallery slideshow: Code cleanup"
jenkins-bot [Fri, 19 Apr 2019 23:22:11 +0000 (23:22 +0000)]
Merge "Gallery slideshow: Code cleanup"

5 years agoMerge "Gallery slideshow: Fix height calculation"
jenkins-bot [Fri, 19 Apr 2019 23:13:42 +0000 (23:13 +0000)]
Merge "Gallery slideshow: Fix height calculation"

5 years agoMerge "Linker: Use parentheses by default in userToolLinksRedContribs()"
jenkins-bot [Fri, 19 Apr 2019 22:42:25 +0000 (22:42 +0000)]
Merge "Linker: Use parentheses by default in userToolLinksRedContribs()"

5 years agoLinker: Use parentheses by default in userToolLinksRedContribs()
Roan Kattouw [Fri, 19 Apr 2019 21:49:40 +0000 (14:49 -0700)]
Linker: Use parentheses by default in userToolLinksRedContribs()

This function had been changed to unconditionally disable parentheses,
but none of its callers load the CSS needed to make that work.

Bug: T220767
Change-Id: I566d65e155258d3bd1a1a06bca9aa2b3a2d417ee
Follows-Up: I6eeeaa3b58d37adb7fefb4cc6915022229b3b324

5 years agoTranslate several special pages into Czech
Martin Urbanec [Fri, 19 Apr 2019 18:58:01 +0000 (20:58 +0200)]
Translate several special pages into Czech

Change-Id: I5e1e597af8ec62d536f0b041b568e961b96981c3

5 years agoGallery slideshow: Code cleanup
Ed Sanders [Fri, 19 Apr 2019 12:08:38 +0000 (13:08 +0100)]
Gallery slideshow: Code cleanup

* Use $-prefix jQuery vars
* Use #connect for OOUI events
* Some jQuery cleanups
* Remove unused return valu of setImageSize
* Only resolve one value in loadImage
* Doc fixes

Change-Id: I0ff4252300aa02c228577961a7d1ede3b9628d90

5 years agoGallery slideshow: Fix height calculation
Ed Sanders [Fri, 19 Apr 2019 12:07:37 +0000 (13:07 +0100)]
Gallery slideshow: Fix height calculation

Remove $container check. This check was broken due to
recent changes in skin output (adding mw-parser-output),
and was not necessary, as the computation without it is
based on $imgContainer, which is also bound by a container.

This avoids the height being set to "NaNpx", or the full
height of the page.

Bug: T196723
Change-Id: I9b4fda9c71502bf749271c55a6945d9f4a4f913e

5 years agoRelax SpecialPageFatalTest about deprecation notices
Umherirrender [Fri, 19 Apr 2019 18:18:22 +0000 (20:18 +0200)]
Relax SpecialPageFatalTest about deprecation notices

Deprecation notice from SpecialPageFatalTest is the most merge blocker
since merge of I8fb26380724b6b12bf08458dbff2e00b759d219b
Deprecation can occur at any time and than break many extensions to
merge, even there are still working.
Ignore deprecation as before, but keep the error and notices

Change-Id: Idcbc38b662c569fbe8e778a6b1ab815db332dc08

5 years agoregistration: Deprecate ExtensionRegistry->load() in favor of ->queue()
Derick Alangi [Mon, 15 Apr 2019 15:21:28 +0000 (16:21 +0100)]
registration: Deprecate ExtensionRegistry->load() in favor of ->queue()

Per task description, Legoktm says "should be safe to hard deprecate in
1.34", hence, doing so and skipping soft deprecation stage.

Bug: T220996
Change-Id: I5669a06f466787df24ce89e58baeed204f848e17

5 years agoMerge "Change "e-mail" to "email" in Log-action-filter-newusers-byemail/en"
jenkins-bot [Fri, 19 Apr 2019 17:43:39 +0000 (17:43 +0000)]
Merge "Change "e-mail" to "email" in Log-action-filter-newusers-byemail/en"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 19 Apr 2019 07:25:19 +0000 (09:25 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I03b16a02855278de5c424151cda244bbb2e97b09

5 years agoDefine index types as strings
Stanislav Malyshev [Fri, 19 Apr 2019 06:59:18 +0000 (23:59 -0700)]
Define index types as strings

This will allow to use them easier in JSON config files.

Bug: T142809
Change-Id: I4053a87fe8e53c9b506604db6fad2f98f7dba150

5 years agorcfeed: Replace usage of deprecated CommentStore::getStore()
Derick Alangi [Fri, 19 Apr 2019 05:26:06 +0000 (06:26 +0100)]
rcfeed: Replace usage of deprecated CommentStore::getStore()

Change-Id: Icaa475a86becb7ef95304f5df31d3fdcf93168e9

5 years agoMerge "search: Remove unused deprecated methods replaced by MW Services"
jenkins-bot [Fri, 19 Apr 2019 01:38:22 +0000 (01:38 +0000)]
Merge "search: Remove unused deprecated methods replaced by MW Services"

5 years agoMerge "SearchEngine: Hard deprecate unused static methods deprecated in 1.27"
jenkins-bot [Fri, 19 Apr 2019 01:03:54 +0000 (01:03 +0000)]
Merge "SearchEngine: Hard deprecate unused static methods deprecated in 1.27"

5 years agoMerge "resourceloader: Omit non-existent messages in MessageBlobStore"
jenkins-bot [Fri, 19 Apr 2019 00:47:45 +0000 (00:47 +0000)]
Merge "resourceloader: Omit non-existent messages in MessageBlobStore"

5 years agoresourceloader: Omit non-existent messages in MessageBlobStore
Timo Tijhof [Wed, 17 Apr 2019 21:08:10 +0000 (22:08 +0100)]
resourceloader: Omit non-existent messages in MessageBlobStore

Previously, it was exporting the result of $msg->plain() regardless
of $msg->exists(). This meant that, client-side, via mw.message
the message would always make mw.Message#exists return true, even
if in fact it did not exist.

Bug: T221294
Change-Id: I77122777ddaaa2d43f8385df9292540a8d21b328

5 years agosearch: Remove unused deprecated methods replaced by MW Services
Derick Alangi [Thu, 18 Apr 2019 13:09:02 +0000 (14:09 +0100)]
search: Remove unused deprecated methods replaced by MW Services

The following methods deprecated in .27 and no longer used have
been removed;

- SearchEngine::userNamespaces()
  https://codesearch.wmflabs.org/search/?q=%3A%3AuserNamespaces&i=nope&files=&repos=

- SearchEngine::namespacesAsText()
  https://codesearch.wmflabs.org/search/?q=%3A%3AnamespacesAsText&i=nope&files=&repos=

- SearchEngine::create()
  https://codesearch.wmflabs.org/search/?q=SearchEngine%3A%3Acreate&i=nope&files=&repos=

- SearchEngine::getSearchTypes()
  https://codesearch.wmflabs.org/search/?q=%3A%3AgetSearchTypes&i=nope&files=&repos=

- SearchEngine::getNearMatch()
  https://codesearch.wmflabs.org/search/?q=SearchEngine%3A%3AgetNearMatch%5C(&i=nope&files=&repos=

Also, replace deprecated use of searchableNamespaces() in SearchEngine.

Bug: T220656
Change-Id: I330fbfea158f70b2328da7c850fdb833e39b6c7d

5 years agoSearchEngine: Hard deprecate unused static methods deprecated in 1.27
James D. Forrester [Thu, 18 Apr 2019 22:57:12 +0000 (15:57 -0700)]
SearchEngine: Hard deprecate unused static methods deprecated in 1.27

Change-Id: I96c4454a2f89df0be5de20ca0506c3ce2c75cf7c

5 years agoMerge "Fix the scripts to generate ucfirst overriddes"
jenkins-bot [Thu, 18 Apr 2019 22:08:15 +0000 (22:08 +0000)]
Merge "Fix the scripts to generate ucfirst overriddes"

5 years agoresourceloader: Sync order of startup test cases with actual code
Timo Tijhof [Thu, 18 Apr 2019 21:36:04 +0000 (22:36 +0100)]
resourceloader: Sync order of startup test cases with actual code

* Re-order the blacklist test cases to match the order of the
  regex for easier review.

* Give the variables better names in startup.js.

Change-Id: Id0498329d3e331d1b0babe9b1d79410ca1e4e7dc

5 years agoFix the scripts to generate ucfirst overriddes
Giuseppe Lavagetto [Thu, 18 Apr 2019 10:09:33 +0000 (12:09 +0200)]
Fix the scripts to generate ucfirst overriddes

* Fix a couple mistakes in generateUcfirstOverrides.php
* Skip surrogate codepoints as they can't be converted to json.

Change-Id: I5eddd90f7b348806d502dfbac08c367701d17f25

5 years agoMerge "Add block type filter to Special:BlockList"
jenkins-bot [Thu, 18 Apr 2019 16:20:31 +0000 (16:20 +0000)]
Merge "Add block type filter to Special:BlockList"

5 years agoMerge "rdbms: add missing return value to LoadBalancer::waitForReplication()"
jenkins-bot [Wed, 17 Apr 2019 23:00:41 +0000 (23:00 +0000)]
Merge "rdbms: add missing return value to LoadBalancer::waitForReplication()"

5 years agoMerge "Simplify and unify the {{REVISIONID}} handling code in Parser"
jenkins-bot [Wed, 17 Apr 2019 22:17:10 +0000 (22:17 +0000)]
Merge "Simplify and unify the {{REVISIONID}} handling code in Parser"

5 years agoMerge "Refactor edit stashing into a PageEditStash service"
jenkins-bot [Wed, 17 Apr 2019 22:14:02 +0000 (22:14 +0000)]
Merge "Refactor edit stashing into a PageEditStash service"

5 years agoMerge "resourceloader: Remove unused logic for WikiModule::getDB() as null"
jenkins-bot [Wed, 17 Apr 2019 20:24:27 +0000 (20:24 +0000)]
Merge "resourceloader: Remove unused logic for WikiModule::getDB() as null"

5 years agoMerge "build: Set Fresnel scenario run count to 7"
jenkins-bot [Wed, 17 Apr 2019 20:15:55 +0000 (20:15 +0000)]
Merge "build: Set Fresnel scenario run count to 7"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 17 Apr 2019 19:54:50 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I76304ba54bedaae2d5f38c44bb9a01c250433dca

5 years agoRefactor edit stashing into a PageEditStash service
Aaron Schulz [Sat, 13 Apr 2019 04:38:55 +0000 (21:38 -0700)]
Refactor edit stashing into a PageEditStash service

Additional code cleanup:
* Call setCacheTime() in parseAndStash instead of relying
  on the one in DerivedPageDataUpdater.
* Improve the SPI logging by adding more extra fields.
* Treat requests in CLI/job mode (aside from tests) like
  those from bots with regard to checking the stash.
  This should avoid stats/logging pollution.

Change-Id: I8c6be919e399378e401a60502add0ecec7764d2d

5 years agoresourceloader: Remove unused logic for WikiModule::getDB() as null
Timo Tijhof [Wed, 17 Apr 2019 15:23:43 +0000 (16:23 +0100)]
resourceloader: Remove unused logic for WikiModule::getDB() as null

This was intended at some point for GlobalCssJs but ended up
being implemented differently once we realised that not having
any information about the remote wiki was unacceptable.

The local placeholder that points to metawiki (in case of GlobalCssJs)
must still at the very least be able to query version information
so that it gets a new version hash after changes etc. to ensure
cache rolls over.

This is being removed in preparation for refactoring where
compatibility with this broken model is no longer kept.

Change-Id: I4f1a06ace881daf1a5f202bdba0075460804de57

5 years agoresourceloader: Move remaining module registrations to ServiceWiring
Timo Tijhof [Wed, 17 Apr 2019 14:17:15 +0000 (15:17 +0100)]
resourceloader: Move remaining module registrations to ServiceWiring

Also restore the order of registrations as it was before
last week with 47422fabe2813f. (That is, core modules are registered
before extension modules, in case of conflicts with a warning, the
core one wins).

Bug: T32956
Change-Id: I3a50508178159dfc8e5db1e218a5e6d10e2d4b2a

5 years agoMerge "Use LinkTarget in Linker instead of Title"
jenkins-bot [Wed, 17 Apr 2019 18:16:28 +0000 (18:16 +0000)]
Merge "Use LinkTarget in Linker instead of Title"

5 years agoMerge "Add ability to override mb_strtoupper in Language::ucfirst"
jenkins-bot [Wed, 17 Apr 2019 16:44:47 +0000 (16:44 +0000)]
Merge "Add ability to override mb_strtoupper in Language::ucfirst"

5 years agoAdd ability to override mb_strtoupper in Language::ucfirst
Giuseppe Lavagetto [Tue, 9 Apr 2019 17:02:03 +0000 (19:02 +0200)]
Add ability to override mb_strtoupper in Language::ucfirst

Different PHP versions treat unicode differently, and specifically some
wiki resources become unreachable if mb_strtoupper's behavior has changed.
This patch allows to introduce an override table that allows to smooth
the transition period.

It also provides maintenance scripts to generate such an override table.

Bug: T219279
Change-Id: I0503ff4207fded4648c58c7b50e67c55422a4849

5 years agoStubObject: Use 'self' instead of 'StubObject' (or <ClassName>)
Derick Alangi [Wed, 17 Apr 2019 13:01:17 +0000 (14:01 +0100)]
StubObject: Use 'self' instead of 'StubObject' (or <ClassName>)

'self' is only 4 chars (shorter to type) and reduces risk (if class name
is changed) which is very unlikely to break things. PHP replaces self with
the actual class name. Plus we're already using this in our code base.

Change-Id: Ia565ab2e4258d0ac201b14b712d1bc3bfe4e4d94

5 years agoRemove all $wgParser use from core
Aryeh Gregor [Thu, 11 Apr 2019 13:36:15 +0000 (16:36 +0300)]
Remove all $wgParser use from core

Bug: T160811

Change-Id: I0556c04d33386d0339e02e2bf7a1ee74d97c2abd