lhc/web/wiklou.git
6 years agomw.Feedback: Remove weird unnecessary switch statements
Bartosz Dziewoński [Tue, 19 Dec 2017 18:48:05 +0000 (19:48 +0100)]
mw.Feedback: Remove weird unnecessary switch statements

They made sense prior to 7196fafcdcbe658caf9ffde508717714b9cf4510,
but no longer do since the success and error handling are in different
functions. I probably should have removed them in that commit.

Change-Id: I1167dc1b5a79eadfe607abfc73bd2f0e95194b78

6 years agoMerge "Prevent write operations to database replicas."
jenkins-bot [Tue, 19 Dec 2017 16:44:46 +0000 (16:44 +0000)]
Merge "Prevent write operations to database replicas."

6 years agoPrevent write operations to database replicas.
daniel [Tue, 19 Dec 2017 16:11:08 +0000 (17:11 +0100)]
Prevent write operations to database replicas.

Bug: T183265
Change-Id: I8e17644d1b447416adee18e42cf0122b52a80b22

6 years agoMerge "Trigger name changes"
jenkins-bot [Tue, 19 Dec 2017 15:45:06 +0000 (15:45 +0000)]
Merge "Trigger name changes"

6 years agoTrigger name changes
freakolowsky [Fri, 15 Dec 2017 12:47:27 +0000 (13:47 +0100)]
Trigger name changes

Modifid the names as described in the task/bug.

Additionally found and added two missing permissions in user.sql, and
fixed an unrelated error to make the schema function.

Bug: T182981
Change-Id: Ia213c0e6b6759a950cdee4181d9c5695e3c5da4a

6 years agoMerge "[MCR] Fix SqlBlobStore using DB_REPLICA for writes"
jenkins-bot [Tue, 19 Dec 2017 15:06:02 +0000 (15:06 +0000)]
Merge "[MCR] Fix SqlBlobStore using DB_REPLICA for writes"

6 years ago[MCR] Fix SqlBlobStore using DB_REPLICA for writes
addshore [Tue, 19 Dec 2017 14:58:06 +0000 (14:58 +0000)]
[MCR] Fix SqlBlobStore using DB_REPLICA for writes

Bug: T183242
Bug: T183245
Bug: T183252
Change-Id: Ic0b9910b5de5ce6817d6a4a3e5e32103e2113926

6 years agoMerge "Revert "[MCR] Turn Revision into a proxy to new code.""
jenkins-bot [Tue, 19 Dec 2017 13:10:53 +0000 (13:10 +0000)]
Merge "Revert "[MCR] Turn Revision into a proxy to new code.""

6 years agoMerge "Add HEBREW POINT METEG to the Hebrew special characters"
jenkins-bot [Tue, 19 Dec 2017 12:44:42 +0000 (12:44 +0000)]
Merge "Add HEBREW POINT METEG to the Hebrew special characters"

6 years agoRevert "[MCR] Turn Revision into a proxy to new code."
Daniel Kinzler [Tue, 19 Dec 2017 10:42:34 +0000 (10:42 +0000)]
Revert "[MCR] Turn Revision into a proxy to new code."

This reverts commit 9dcc56b3c9e7a3212d0900ee23808b9402cad952.

With this patch applied, newly created revisions are sometimes not found
just after submitting an edit, until replicas have caught up.

Our best theory is that it somehow interfere with ChronologyProtector,
but we don't have a good idea how.

Also, as legoktm mentioned, the commit message is terrible and needs fixing.

Change-Id: Idf3404f3fa8f8d08a7fb2ab8268726e2c1edecfe

6 years agoMerge "RCLFilters: make target and to/from parameters sticky again"
jenkins-bot [Tue, 19 Dec 2017 12:34:59 +0000 (12:34 +0000)]
Merge "RCLFilters: make target and to/from parameters sticky again"

6 years agoMerge "Require indentation of CASE statements in PHP code"
jenkins-bot [Tue, 19 Dec 2017 12:21:59 +0000 (12:21 +0000)]
Merge "Require indentation of CASE statements in PHP code"

6 years agoRCLFilters: make target and to/from parameters sticky again
Stephane Bisson [Tue, 19 Dec 2017 12:03:26 +0000 (07:03 -0500)]
RCLFilters: make target and to/from parameters sticky again

Regression from Id0bf89ce397ff8a54ce0a30d1ba7d8f9bbdd14a3

Change-Id: Ied7a73b662266eb1ea0c085e5b9c88df0de7e2f6

6 years agoAdd HEBREW POINT METEG to the Hebrew special characters
Amire80 [Tue, 19 Dec 2017 09:52:47 +0000 (11:52 +0200)]
Add HEBREW POINT METEG to the Hebrew special characters

It's very common in the Bible, and in many other books for indicating stress.

Change-Id: I4a564df82398b15ea4ec9c0a67f119c7ef1bdf95

6 years agoRevisionTest: Make @covers tags absolute
Kunal Mehta [Tue, 19 Dec 2017 06:01:02 +0000 (22:01 -0800)]
RevisionTest: Make @covers tags absolute

PHPUnit requires @covers tags to be absolute, they cannot depend
upon `use ...` statements.

Change-Id: I92fadc51cc924477d884536b860272b5a230cd36

6 years agoRevisionTest: Revision::constructFromRowArray is not a function
Kunal Mehta [Tue, 19 Dec 2017 03:24:46 +0000 (19:24 -0800)]
RevisionTest: Revision::constructFromRowArray is not a function

I'm guessing that RevisionStore::newMutableRevisionFromArray() is
what is supposed to be tested here, since Revision::__construct()
calls that if it gets an array.

Change-Id: Ia6c2e7eb667aa746a12ce74aad62e58d2468defd

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 18 Dec 2017 21:07:19 +0000 (22:07 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I7b73fc1564496c5e6988fda30b4fccddea9d0e2a

6 years agoMerge "Fix how "Live updates" behave when user logs out"
jenkins-bot [Mon, 18 Dec 2017 16:06:14 +0000 (16:06 +0000)]
Merge "Fix how "Live updates" behave when user logs out"

6 years agoMerge "RCLFilters: change working of 'to-and-from' selector"
jenkins-bot [Mon, 18 Dec 2017 15:56:17 +0000 (15:56 +0000)]
Merge "RCLFilters: change working of 'to-and-from' selector"

6 years agoMerge "ApiMain: Fix call to Linker::makeHeadline()"
jenkins-bot [Mon, 18 Dec 2017 15:54:28 +0000 (15:54 +0000)]
Merge "ApiMain: Fix call to Linker::makeHeadline()"

6 years agoMerge "Fix heading selecting over-select"
jenkins-bot [Mon, 18 Dec 2017 15:27:05 +0000 (15:27 +0000)]
Merge "Fix heading selecting over-select"

6 years agoApiMain: Fix call to Linker::makeHeadline()
Brad Jorsch [Mon, 18 Dec 2017 14:53:27 +0000 (09:53 -0500)]
ApiMain: Fix call to Linker::makeHeadline()

It's required that the $attribs parameter also contain the closing '>'.

Bug: T183125
Change-Id: Ic3015067a6b1e95e3487a8580e6a9aa8a6c280ed

6 years ago[MCR] Turn Revision into a proxy to new code.
daniel [Thu, 31 Aug 2017 18:41:04 +0000 (20:41 +0200)]
[MCR] Turn Revision into a proxy to new code.

Change-Id: I4f24e7fbb683cb51f3fd8b250732bae9c7541ba2

6 years agoFix heading selecting over-select
golopot [Mon, 18 Dec 2017 07:01:30 +0000 (15:01 +0800)]
Fix heading selecting over-select

In Chrome, multiple clicking selecting a heading cause a bug that the
first character in the next paragrpah is also selected.

Change-Id: Ib52662c39720dcd36ea0b60c9884530895dd9e6a

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 17 Dec 2017 21:01:06 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: If167af95a237f67c19013cd5c1daf9c1cbdad492

6 years agoMerge "Use another pageid in WikiPageDbTestBase::testInsertOn_idSpecified"
jenkins-bot [Sun, 17 Dec 2017 17:46:38 +0000 (17:46 +0000)]
Merge "Use another pageid in WikiPageDbTestBase::testInsertOn_idSpecified"

6 years agoMerge "Fix tooltip accessibility for screen readers"
jenkins-bot [Sat, 16 Dec 2017 14:59:35 +0000 (14:59 +0000)]
Merge "Fix tooltip accessibility for screen readers"

6 years agoFix tooltip accessibility for screen readers
David Sn [Sat, 16 Dec 2017 01:39:35 +0000 (01:39 +0000)]
Fix tooltip accessibility for screen readers

By adding an additional aria-label attribute to the tooltip,
we can ensure that every tooltip will be accessible
for accessibility tools like screen readers.

Works with Echo extension, but I am not sure if there
are extensions who are using the original-title attribute.

Tested with ChromeVox on Chrome 62.0.3202.94.

Bug: T54711
Change-Id: I19500c4e8ccbdcb8288b9c2299a29b3f8a31639d

6 years agoMergeHistory: Duplicate watchers on history merge
Fomafix [Mon, 11 Apr 2016 10:41:39 +0000 (12:41 +0200)]
MergeHistory: Duplicate watchers on history merge

Bug: T132130
Change-Id: Ibb2be4f6f975f8f3c542689530fc120f8a464914

6 years agoUse another pageid in WikiPageDbTestBase::testInsertOn_idSpecified
Umherirrender [Fri, 15 Dec 2017 21:03:07 +0000 (22:03 +0100)]
Use another pageid in WikiPageDbTestBase::testInsertOn_idSpecified

integer bigger than 2147483648 is bad on 32-bit php

1) WikiPageContentHandlerDbTest::testInsertOn_idSpecified
Failed asserting that -816015107 is identical to 3478952189.

> echo intval( 3478952189 );
-816015107

Change-Id: Ia2ab870dfe53bef873def3905ae93ea52d4ab2ad

6 years agoNormalize path in AutoloadGenerator::setExcludePaths
Umherirrender [Fri, 15 Dec 2017 22:00:36 +0000 (23:00 +0100)]
Normalize path in AutoloadGenerator::setExcludePaths

Fix is for windows machine

Change-Id: Iadedeb6a04df439c0e940b8eb62fa46757c571c3

6 years agoMerge "SqlBlobStoreTest: Use utf-8 as name in iconv"
jenkins-bot [Fri, 15 Dec 2017 22:04:23 +0000 (22:04 +0000)]
Merge "SqlBlobStoreTest: Use utf-8 as name in iconv"

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 15 Dec 2017 20:56:35 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I81ca4030d9c7e37c26828049921737fd0395fa52

6 years agoMerge "Fix additional usage of incorrect case"
jenkins-bot [Fri, 15 Dec 2017 19:57:01 +0000 (19:57 +0000)]
Merge "Fix additional usage of incorrect case"

6 years agoSqlBlobStoreTest: Use utf-8 as name in iconv
Umherirrender [Fri, 15 Dec 2017 18:56:48 +0000 (19:56 +0100)]
SqlBlobStoreTest: Use utf-8 as name in iconv

utf8 is an alias that doesn't work with all PHP installations.

Change-Id: I6ce9c5b4ece1a8c263afb1d4895dacd3c790a51a

6 years agoFix typo in ImportHandleUnknownUser hook documentation
Brad Jorsch [Fri, 15 Dec 2017 18:12:09 +0000 (13:12 -0500)]
Fix typo in ImportHandleUnknownUser hook documentation

Change-Id: Ib37facf546e3088cc64373882bb276d2703575b4

6 years agoRCLFilters: change working of 'to-and-from' selector
Stephane Bisson [Fri, 15 Dec 2017 14:00:34 +0000 (09:00 -0500)]
RCLFilters: change working of 'to-and-from' selector

Bug: T172161
Change-Id: I749d7d4ba383daa79685da389d27bde832a508c2

6 years agoFix additional usage of incorrect case
mainframe98 [Fri, 15 Dec 2017 10:58:11 +0000 (11:58 +0100)]
Fix additional usage of incorrect case

Courtesy of the PhpStorm inspection Case mismatch in method call or
class usage.

Bug: T166759
Change-Id: I27c53658b99048fa0dd8f9d6ef1398620386e1cc

6 years agoMerge "RevisionTest: Use utf-8 as name in iconv"
jenkins-bot [Fri, 15 Dec 2017 05:25:11 +0000 (05:25 +0000)]
Merge "RevisionTest: Use utf-8 as name in iconv"

6 years agoRevisionTest: Use utf-8 as name in iconv
Umherirrender [Fri, 8 Dec 2017 13:55:06 +0000 (14:55 +0100)]
RevisionTest: Use utf-8 as name in iconv

utf8 is an alias that doesn't work with all PHP installations.

Change-Id: Ief6e5d8b73c9b4a6614430b699f3399b8137689a

6 years agoMerge "Split limit report out of Parser::parse()"
jenkins-bot [Fri, 15 Dec 2017 05:04:01 +0000 (05:04 +0000)]
Merge "Split limit report out of Parser::parse()"

6 years agoRemove WatchedItem constants and methods deprecated in REL1_27
Reedy [Fri, 8 Dec 2017 03:09:15 +0000 (03:09 +0000)]
Remove WatchedItem constants and methods deprecated in REL1_27

Remove associated tests

Bug: T182381
Change-Id: I0214250a7cb81518074a14e35590370b13d4ba64

6 years agoMerge "ContentHandler: simplify tag tests"
jenkins-bot [Fri, 15 Dec 2017 04:35:21 +0000 (04:35 +0000)]
Merge "ContentHandler: simplify tag tests"

6 years agoContentHandler: simplify tag tests
Framawiki [Tue, 12 Dec 2017 18:21:02 +0000 (19:21 +0100)]
ContentHandler: simplify tag tests

Follows up 62713be990.

Change-Id: Id1f7e6ae470b461e26ef8b7346f715873ccea4c9

6 years agoMerge "Localise some special pages into Korean (ko)"
jenkins-bot [Fri, 15 Dec 2017 04:26:04 +0000 (04:26 +0000)]
Merge "Localise some special pages into Korean (ko)"

6 years agoLocalise some special pages into Korean (ko)
Yongmin Hong [Tue, 12 Dec 2017 11:47:13 +0000 (20:47 +0900)]
Localise some special pages into Korean (ko)

* Synced from MessageEn.php
* Change Special:ListGroupRights so it's less ambigious

Change-Id: I1dfac96825850cdcda135b2e1ce3e19cf71e99e9
Signed-off-by: Yongmin Hong <revi@pobox.com>
6 years agoFix @covers tags to use absolute class names in Storage tests
Kunal Mehta [Fri, 15 Dec 2017 03:20:51 +0000 (19:20 -0800)]
Fix @covers tags to use absolute class names in Storage tests

PHPUnit doesn't support use statements when evaluating @covers tags.

Change-Id: I7f649afd3e417a6b71b2f61c6ff59be5f404be8f

6 years agoMerge "XMPReader: Log filename if available"
jenkins-bot [Fri, 15 Dec 2017 01:33:55 +0000 (01:33 +0000)]
Merge "XMPReader: Log filename if available"

6 years agoMerge "mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards"
jenkins-bot [Fri, 15 Dec 2017 00:26:44 +0000 (00:26 +0000)]
Merge "mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards"

6 years agoOOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988
Bartosz Dziewoński [Thu, 14 Dec 2017 22:56:40 +0000 (23:56 +0100)]
OOjs UI: Backport Iad4a2fd1bd985b4924e5ef1f822e1ea81ce0a988

Bug: T182359
Bug: T182395
Change-Id: I764a96780e418830e5c92ec57c50f549951ff47f

6 years agoMerge "[MCR] Tests for RevisionStore & Related classes"
jenkins-bot [Thu, 14 Dec 2017 22:50:58 +0000 (22:50 +0000)]
Merge "[MCR] Tests for RevisionStore & Related classes"

6 years agoMerge "[MCR] Break Revision into RevisionRecord and RevisionStore"
jenkins-bot [Thu, 14 Dec 2017 22:50:51 +0000 (22:50 +0000)]
Merge "[MCR] Break Revision into RevisionRecord and RevisionStore"

6 years agoMerge "mediawiki.loader: Fix logError() not to print exceptions twice"
jenkins-bot [Thu, 14 Dec 2017 22:31:43 +0000 (22:31 +0000)]
Merge "mediawiki.loader: Fix logError() not to print exceptions twice"

6 years agoMerge "Add dropSequence to postgres"
jenkins-bot [Thu, 14 Dec 2017 21:57:45 +0000 (21:57 +0000)]
Merge "Add dropSequence to postgres"

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 14 Dec 2017 20:59:04 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I0e9482e99525f1fa6fd791f09597abd91485342b

6 years agomediawiki.loader: Fix logError() not to print exceptions twice
Timo Tijhof [Wed, 13 Dec 2017 22:45:45 +0000 (23:45 +0100)]
mediawiki.loader: Fix logError() not to print exceptions twice

Current behaviour results in:

Chrome 65 (initial)
> ▶ [WARN] Error: foo Error: foo
>  at bar
>  at main

Chrome 65 (expanded)
> ▼ [WARN] Error: foo Error: foo
>            at bar
>            at main
>  at logError
>  at main

Safari 11 (initial)
> ▶ [WARN] Error: foo, Error: foo

Safari 11 (expanded)
> ▼ [WARN] Error: foo is undefined
>     * Error: foo is undefined
>         at bar
>         at main

Firefox 57
> [WARN] Error: foo | Error: foo
>                   | Stacktrace:
>                   |   bar
>                   |   main

I don't recall why I did it this way, but it seems redundant.
This commit effectively removes the first "Error: foo"

Change-Id: Idc5dee34ce2b5068e3a2d8800e2b5f6b879525d1

6 years agoAvoid using array_map in ExtensionRegistry and ExtensionProcessor for simple operations
Yifei He [Wed, 13 Dec 2017 09:41:03 +0000 (17:41 +0800)]
Avoid using array_map in ExtensionRegistry and ExtensionProcessor for simple operations

Bug: T182645
Change-Id: Ia98b1d798b1f93ca30686c009d479668616229ae

6 years ago[MCR] Tests for RevisionStore & Related classes
addshore [Wed, 15 Nov 2017 12:02:40 +0000 (12:02 +0000)]
[MCR] Tests for RevisionStore & Related classes

Code introduced in:
I140f43a6fb443b38483f41f268c906b9cea64cf7

Change-Id: Iefad870baf2d16f12e9901b303246c64d6431ca6

6 years agoMerge "Change EnqueueJob docs to discourage obsolete use-cases"
jenkins-bot [Thu, 14 Dec 2017 03:22:29 +0000 (03:22 +0000)]
Merge "Change EnqueueJob docs to discourage obsolete use-cases"

6 years agoChange EnqueueJob docs to discourage obsolete use-cases
Aaron Schulz [Wed, 6 Dec 2017 21:15:22 +0000 (13:15 -0800)]
Change EnqueueJob docs to discourage obsolete use-cases

Bug: T181216
Change-Id: I9332d26ae9a74c3721cff9c497d5356f05efb428

6 years agoFix manual IN queries in checkStorage.php
Pppery [Thu, 14 Dec 2017 01:56:14 +0000 (20:56 -0500)]
Fix manual IN queries in checkStorage.php

Bug: T182689
Change-Id: Ifca7bd6d0385dd470cddc483f4641eeb2832580c

6 years agoMerge "Track which namespaces edit conflicts are resolved in"
jenkins-bot [Thu, 14 Dec 2017 00:47:19 +0000 (00:47 +0000)]
Merge "Track which namespaces edit conflicts are resolved in"

6 years agoMerge "RCFilters: Change findHighlightedItem due to deprecation"
jenkins-bot [Wed, 13 Dec 2017 23:29:37 +0000 (23:29 +0000)]
Merge "RCFilters: Change findHighlightedItem due to deprecation"

6 years agoMerge "Convert includes/Feed.php to Mustache templates"
jenkins-bot [Wed, 13 Dec 2017 23:09:25 +0000 (23:09 +0000)]
Merge "Convert includes/Feed.php to Mustache templates"

6 years agoRCFilters: Change findHighlightedItem due to deprecation
Moriel Schottlender [Wed, 13 Dec 2017 22:58:40 +0000 (14:58 -0800)]
RCFilters: Change findHighlightedItem due to deprecation

SelectWidget's getHighlightedItem was deprecated and switched with
findHighlightedItem, see T76630

Change-Id: I90535c9f72d9a63e8e8d4184cc85aaf77e7b454c

6 years ago[MCR] Break Revision into RevisionRecord and RevisionStore
daniel [Sun, 27 Aug 2017 15:29:18 +0000 (17:29 +0200)]
[MCR] Break Revision into RevisionRecord and RevisionStore

Bug: T174025
Change-Id: I140f43a6fb443b38483f41f268c906b9cea64cf7

6 years agoFix how "Live updates" behave when user logs out
petarpetkovic [Wed, 13 Dec 2017 21:16:16 +0000 (22:16 +0100)]
Fix how "Live updates" behave when user logs out

If user enables "Live updates" on one tab/browser and logs out from
different tab/browser, reload the page.

Bug: T177717
Change-Id: Ifeeb7d50eaec8f733a94a36711f1c4541af1cef9

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 13 Dec 2017 21:58:52 +0000 (22:58 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I10dac54f4429e4fdec8f0e3d32b7f9ed1c16bc22

6 years agoMerge "mediawiki.loader: Avoid jQuery for simple creation and selection"
jenkins-bot [Wed, 13 Dec 2017 21:23:28 +0000 (21:23 +0000)]
Merge "mediawiki.loader: Avoid jQuery for simple creation and selection"

6 years agoMerge "RCLFilters: display target page as a title"
jenkins-bot [Wed, 13 Dec 2017 21:14:28 +0000 (21:14 +0000)]
Merge "RCLFilters: display target page as a title"

6 years agoMerge "Fix autoloading of ExportProgressFilter"
jenkins-bot [Wed, 13 Dec 2017 21:12:15 +0000 (21:12 +0000)]
Merge "Fix autoloading of ExportProgressFilter"

6 years agoFix autoloading of ExportProgressFilter
Albert221 [Wed, 13 Dec 2017 16:59:45 +0000 (17:59 +0100)]
Fix autoloading of ExportProgressFilter

Bug: T177239
Change-Id: Ieb5d5aa78d569af8cd8f8bfa32ce10a33482cb84

6 years agoRCLFilters: display target page as a title
Stephane Bisson [Wed, 6 Dec 2017 21:57:40 +0000 (16:57 -0500)]
RCLFilters: display target page as a title

* Url decode target param
* Pass through mw.Title to convert underscores to spaces

Bug: T182164
Change-Id: Iabb0d8ea2b9f93f943e8493ee0a29d3bee3b3682

6 years agoMerge "resourceloader: Use document.head instead of getElementsByTagName"
jenkins-bot [Wed, 13 Dec 2017 20:28:24 +0000 (20:28 +0000)]
Merge "resourceloader: Use document.head instead of getElementsByTagName"

6 years agoConvert includes/Feed.php to Mustache templates
Pppery [Tue, 12 Dec 2017 00:58:41 +0000 (19:58 -0500)]
Convert includes/Feed.php to Mustache templates

Bug: T182212
Change-Id: Ic198efb6a46ecc2d8b8b49ab594205d69a03efdb

6 years agoMerge "Follow-up Ib933de3a3f: remove unnecessary override from SpecialWatchlist"
jenkins-bot [Wed, 13 Dec 2017 20:12:45 +0000 (20:12 +0000)]
Merge "Follow-up Ib933de3a3f: remove unnecessary override from SpecialWatchlist"

6 years agoFollow-up Ib933de3a3f: remove unnecessary override from SpecialWatchlist
Roan Kattouw [Wed, 13 Dec 2017 19:29:55 +0000 (11:29 -0800)]
Follow-up Ib933de3a3f: remove unnecessary override from SpecialWatchlist

isStructuredFilterUiEnabledByDefault() should no longer be overridden,
overrides should be put in the static checkStructuredFilterUiEnabled()
instead. That function was already added, but the duplicated non-static
function wasn't removed.

It looks to me that ?rcfilters=1 shouldn't have been working on
Watchlist for this reason, but it was working, and I can't figure out
why.

Change-Id: Iaf962b4e0428e262b57dc12ee0ba2cb6f854eb7e

6 years agomediawiki.loader: Avoid jQuery for simple creation and selection
Timo Tijhof [Wed, 13 Dec 2017 19:27:41 +0000 (20:27 +0100)]
mediawiki.loader: Avoid jQuery for simple creation and selection

Use document.createElement and document.head instead.

Change-Id: Ia0f981da34f9f8dbc328e46a44511b2573b4e1b8

6 years agoresourceloader: Use document.head instead of getElementsByTagName
Timo Tijhof [Wed, 13 Dec 2017 19:24:19 +0000 (20:24 +0100)]
resourceloader: Use document.head instead of getElementsByTagName

Supported in all Grade A browsers. Also already being used
by jquery.js (without fallback), which we depend on.

Browser support (per MDN):
- Desktop: Chrome 4+, FF 4+, Edge, IE 9+, Opera 11+, Safari 5+
- Mobile: Android, Edge, FF Mobile 4+, IE Mobile 9+, Opera Mobile,
  Mobile Safari

(Those without numbers, have support since their initial release)

Change-Id: I2e9820de8463518a14a0d679d1f339c3a2f9dc66

6 years agoMerge "RCLFilters: support target page with a subpage"
jenkins-bot [Wed, 13 Dec 2017 18:55:37 +0000 (18:55 +0000)]
Merge "RCLFilters: support target page with a subpage"

6 years agoRCLFilters: support target page with a subpage
Stephane Bisson [Wed, 13 Dec 2017 18:29:43 +0000 (13:29 -0500)]
RCLFilters: support target page with a subpage

Correctly extract the target page when it has a subpage.
Examples (taken from unit tests):
http://host/wiki/Special:RecentChangesLinked/Moai/Sub1
http://host/wiki/Special:RecentChangesLinked/Category:Foo/Bar
http://host/w/index.php?title=Special:RecentChangesLinked/Moai/Sub1

Bug: T182734
Change-Id: Id6909728f461a3cd687185abd304f2fac5dc6000

6 years agoMerge "RCFilters: Fix live update"
jenkins-bot [Wed, 13 Dec 2017 18:28:30 +0000 (18:28 +0000)]
Merge "RCFilters: Fix live update"

6 years agoRCFilters: Fix live update
Stephane Bisson [Wed, 13 Dec 2017 15:10:41 +0000 (10:10 -0500)]
RCFilters: Fix live update

When Id55702ecbe6b96ee57453d4f86f20bd94a401d7c
introduced the MainWrapperWidget, it changed
the order on initialization, which prevents
ChangesListViewModel from getting the initial
value of the 'from' parameter and thus
disables polling for new changes.

This patch ensures ChangesListViewModel is
given the initial form in its constructor
so it can extract what it needs from it
before the page DOM is being transformed.

Bug: T182788
Change-Id: I1b72790194877ff0f200c87e4f40a942f1ccac3b

6 years agoFix getNamespace error
petarpetkovic [Wed, 13 Dec 2017 14:29:25 +0000 (15:29 +0100)]
Fix getNamespace error

In mw.rcfilters.init file, getNamespace method is introduced in Id55702ecbe.
That method is invoked through 'this' context, which can be different
depending on how init method is invoked, which can lead to errors,
causing RCFilters not to render correctly.

Change-Id: Ifd9cb49e547077c622a5a3757361a85d99283f62

6 years agoProvide personal tools getter
petarpetkovic [Mon, 6 Nov 2017 19:03:12 +0000 (20:03 +0100)]
Provide personal tools getter

- Add public function to get user's personal tools.
- Add new level of abstraction to the creation on personal tools list items,
by enabling user to provide list of personal tools.

Change-Id: I549376af6f7380dbadfb5f3f7f7171bbe64cccd7

6 years agoMerge "Add parameter for query/search to fetch augmented data."
jenkins-bot [Wed, 13 Dec 2017 09:35:58 +0000 (09:35 +0000)]
Merge "Add parameter for query/search to fetch augmented data."

6 years agoSync up with Parsoid parserTests.txt
C. Scott Ananian [Tue, 12 Dec 2017 22:52:02 +0000 (17:52 -0500)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit 741fc5dc0f683df8d81bc09843734dad966138bd

Change-Id: I5a40b9410bbf421e22e37063785446db25e7af42

6 years agomw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards
Bartosz Dziewoński [Tue, 12 Dec 2017 22:30:04 +0000 (23:30 +0100)]
mw.rcfilters.ui.MenuSelectWidget: Always open this menu downwards

Bug: T182711
Change-Id: I6da6cbe53026a4407160c056f6cb4bcb47553049

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 12 Dec 2017 21:22:00 +0000 (22:22 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I81cc494f3e476d9699cb7ad3ee978e61b3f5524f

6 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 12 Dec 2017 21:01:23 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ibcdae5b4477c05b7cfd46c49c62160cd845ebc52

6 years agoAdded an optional $maxdepth to CategoryFinder
Valerio Bozzolan [Fri, 3 Nov 2017 01:46:52 +0000 (02:46 +0100)]
Added an optional $maxdepth to CategoryFinder

Bug: T179065
Change-Id: I760bb75aa9f14d55456ea2d604a4c25234826403

6 years agoMerge "Absolutely position legend only on new RCFilters"
jenkins-bot [Tue, 12 Dec 2017 20:13:21 +0000 (20:13 +0000)]
Merge "Absolutely position legend only on new RCFilters"

6 years agoMerge "Allow users to prevent new users from sending them email."
jenkins-bot [Tue, 12 Dec 2017 17:48:47 +0000 (17:48 +0000)]
Merge "Allow users to prevent new users from sending them email."

6 years agoMerge "maintenance: Replace manual IN query with select wrapper"
jenkins-bot [Tue, 12 Dec 2017 14:41:36 +0000 (14:41 +0000)]
Merge "maintenance: Replace manual IN query with select wrapper"

6 years agoMerge "SpecialListgrouprights: Fix "Namespace restrictions" header ID"
jenkins-bot [Tue, 12 Dec 2017 13:17:23 +0000 (13:17 +0000)]
Merge "SpecialListgrouprights: Fix "Namespace restrictions" header ID"

6 years agoMerge "Linker: Use Parser::guessSectionNameFromStrippedText()"
jenkins-bot [Tue, 12 Dec 2017 13:13:07 +0000 (13:13 +0000)]
Merge "Linker: Use Parser::guessSectionNameFromStrippedText()"

6 years agoMerge "Parser: Add guessSectionNameFromStrippedText() and refactor"
jenkins-bot [Tue, 12 Dec 2017 13:10:55 +0000 (13:10 +0000)]
Merge "Parser: Add guessSectionNameFromStrippedText() and refactor"

6 years agoAbsolutely position legend only on new RCFilters
petarpetkovic [Tue, 12 Dec 2017 12:52:39 +0000 (13:52 +0100)]
Absolutely position legend only on new RCFilters

- Don't use absolute positioning on legend when user opts out of
improved version of Recent Changes, or disables "New filters for edit review"
beta feature to opt out of improved version of Watchlist.

Bug: T182363
Change-Id: Ib02372ab7ad97f3f50764ad612e38096f92131ad

6 years agomaintenance: Replace manual IN query with select wrapper
Yifei He [Tue, 12 Dec 2017 11:27:54 +0000 (19:27 +0800)]
maintenance: Replace manual IN query with select wrapper

Bug: T182208
Change-Id: I4c410bc1f7a57efacda4ac71a074a8a8ee2d1d98

6 years agoAllow users to prevent new users from sending them email.
David Barratt [Tue, 14 Nov 2017 21:49:52 +0000 (16:49 -0500)]
Allow users to prevent new users from sending them email.

Users now have the option to prevent Newbie users from sending
them emails.

Bug: T138165
Change-Id: I5d5332e50971fbcd1fa630d6bd03bdf757a9d1f1