lhc/web/wiklou.git
5 years agoRevision: test and fix __construct exceptions
addshore [Wed, 11 Oct 2017 12:40:03 +0000 (13:40 +0100)]
Revision: test and fix __construct exceptions

This adds tests for each exception that can be thrown
in the Revision constructor.
It also fixes where the exception for the content part of a row
not containing a content object is thrown.
Prior to this ->getModel() could be called on the content row
element before the check had actually occoured.

Change-Id: Ia2d2cfdca01871fc6dbb96707d781db33d7d0a40

5 years agoRevisionStorageTest: code style fixes
addshore [Tue, 10 Oct 2017 16:58:13 +0000 (17:58 +0100)]
RevisionStorageTest: code style fixes

Change-Id: I0d8e6e58c74c3ba849f9cb4a3a159a62049604a3

5 years agoRevisionTest: refactor test dataProviders
addshore [Tue, 10 Oct 2017 16:38:31 +0000 (17:38 +0100)]
RevisionTest: refactor test dataProviders

Change-Id: I238d0294de7112a78ef18ffba195c0c175d6d735

5 years agoDeprecate $wgEnableAPI and $wgEnableWriteAPI
Tim Starling [Wed, 11 Oct 2017 23:02:05 +0000 (10:02 +1100)]
Deprecate $wgEnableAPI and $wgEnableWriteAPI

$wgEnableAPI and $wgEnableWriteAPI are now deprecated and will be removed in
a future version. The API is now considered to be stable, secure and
essential.

Bug: T115414
Change-Id: I8c98ce63afd82677ecf662f8159e58be1759bde0

5 years agoMerge "RCFilters: Store invert as a standard filter/parameter"
jenkins-bot [Wed, 11 Oct 2017 20:30:41 +0000 (20:30 +0000)]
Merge "RCFilters: Store invert as a standard filter/parameter"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 11 Oct 2017 20:07:15 +0000 (22:07 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I2cb99cda301b6a76bc6ccb76819e4774d539910c

5 years agoMerge "Make $mText an explicit member variable in TextContent"
jenkins-bot [Wed, 11 Oct 2017 18:13:35 +0000 (18:13 +0000)]
Merge "Make $mText an explicit member variable in TextContent"

5 years agoMerge "RevisionTest code style fixes & file split"
jenkins-bot [Wed, 11 Oct 2017 18:11:16 +0000 (18:11 +0000)]
Merge "RevisionTest code style fixes & file split"

5 years agoMake $mText an explicit member variable in TextContent
addshore [Tue, 10 Oct 2017 16:02:11 +0000 (17:02 +0100)]
Make $mText an explicit member variable in TextContent

Change-Id: I1e1f652e4ef6d02bc76105407cb23975625560cd

5 years agoFix unblocking autoblocks
Amir Sarabadani [Wed, 11 Oct 2017 15:19:05 +0000 (17:19 +0200)]
Fix unblocking autoblocks

Bug: T177952
Change-Id: Ib9c245fe47ed0009a8db8437798574ad4603a8a5

5 years agoRevisionTest code style fixes & file split
addshore [Tue, 10 Oct 2017 15:55:13 +0000 (16:55 +0100)]
RevisionTest code style fixes & file split

Change-Id: I054a6810e29225e4341c518631a6dba9f40a1531

5 years agoMerge "Setting Urdu translations of some magic words and special pages"
jenkins-bot [Wed, 11 Oct 2017 15:45:21 +0000 (15:45 +0000)]
Merge "Setting Urdu translations of some magic words and special pages"

5 years agoSetting Urdu translations of some magic words and special pages
Obaid Raza [Sat, 7 Oct 2017 09:21:49 +0000 (09:21 +0000)]
Setting Urdu translations of some magic words and special pages

Change-Id: I4ac5ac7e13c473adc0026776ef7d63b853a42976

5 years agomw.action.edit.styles: Remove max-width on edit summary field's label too
Bartosz Dziewoński [Wed, 11 Oct 2017 15:00:09 +0000 (17:00 +0200)]
mw.action.edit.styles: Remove max-width on edit summary field's label too

Bug: T162849
Change-Id: I37d483dba63b9694d67a9c99eb70ca892d8d8662

5 years agoMerge "Change Tagged edits help icon"
jenkins-bot [Wed, 11 Oct 2017 13:58:26 +0000 (13:58 +0000)]
Merge "Change Tagged edits help icon"

5 years agoChange Tagged edits help icon
petarpetkovic [Fri, 6 Oct 2017 12:47:46 +0000 (14:47 +0200)]
Change Tagged edits help icon

- Change the link that help icon leads to.
- Reduce the size of help icon.

Bug: T176661
Change-Id: Ifc3b3e9efce00ea601795bd67a2de17c4be3cf6f

5 years agoFix SVG href error message to be more accurate and useful
Matthew Flaschen [Wed, 11 Oct 2017 06:04:08 +0000 (02:04 -0400)]
Fix SVG href error message to be more accurate and useful

Change-Id: I2519e1802a62e4d7c1d666b4325982063ff9b40c

5 years agoMerge "Add test cases for digit grouping (commafy) in Polish"
jenkins-bot [Wed, 11 Oct 2017 01:46:04 +0000 (01:46 +0000)]
Merge "Add test cases for digit grouping (commafy) in Polish"

5 years agoRCFilters: Store invert as a standard filter/parameter
Stephane Bisson [Fri, 6 Oct 2017 18:52:36 +0000 (14:52 -0400)]
RCFilters: Store invert as a standard filter/parameter

Change-Id: Ie623dac923cc2feb30f406c48accdadfd8d80753

5 years agoMerge "Remove outdated code comments in MessagesXx.php files"
jenkins-bot [Tue, 10 Oct 2017 22:27:14 +0000 (22:27 +0000)]
Merge "Remove outdated code comments in MessagesXx.php files"

5 years agoMerge "Ensure only strings are passed to mysql_real_escape_string()"
jenkins-bot [Tue, 10 Oct 2017 21:40:16 +0000 (21:40 +0000)]
Merge "Ensure only strings are passed to mysql_real_escape_string()"

5 years agoAdd test cases for digit grouping (commafy) in Polish
Bartosz Dziewoński [Tue, 10 Oct 2017 20:36:31 +0000 (22:36 +0200)]
Add test cases for digit grouping (commafy) in Polish

According to the typographical convention, a thousands separator
should not be inserted in numbers that are four digits long (between
1000 and 9999), unlike in English where it's usually acceptable.
This logic is currently implemented in LanguagePl::commafy().

Bug: T177846
Change-Id: I6dbd8febcf59000067cdd7d3c11111f2f77f4e66

5 years agoRemove outdated code comments in MessagesXx.php files
Bartosz Dziewoński [Tue, 10 Oct 2017 17:50:19 +0000 (19:50 +0200)]
Remove outdated code comments in MessagesXx.php files

MessagesKk_arab.php:
MessagesKk_cyrl.php:
MessagesKk_latn.php:
MessagesRu.php:
* Translations of a comment warning end-users against editing
  localisation messages in these files. That comment was removed
  from  MessagesEn.php in b38247894422fb34dbddaea23cfc08cd72f48d5b,
  as we no longer store localisation messages here.

MessagesKsh.php
* Warning for translators not to use encodings other than UTF-8.

Change-Id: I1ff2cf035b84dc53c368ad7182f294c7fb8f1a3d

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 10 Oct 2017 20:03:09 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I07c8db3e1ae9bbccac12ab3d1fff365091b84794

5 years agoMerge "Suppress error in MediaWiki\Shell\Command"
jenkins-bot [Tue, 10 Oct 2017 18:52:52 +0000 (18:52 +0000)]
Merge "Suppress error in MediaWiki\Shell\Command"

5 years agoMerge "Define MEDIAWIKI_JOB_RUNNER in runJobs.php"
jenkins-bot [Tue, 10 Oct 2017 16:57:22 +0000 (16:57 +0000)]
Merge "Define MEDIAWIKI_JOB_RUNNER in runJobs.php"

5 years agoMerge "RCFilters UI: In the highlight code, use .data() the way it was meant to be...
jenkins-bot [Tue, 10 Oct 2017 15:32:39 +0000 (15:32 +0000)]
Merge "RCFilters UI: In the highlight code, use .data() the way it was meant to be used"

5 years agoMerge "Special:UserLogin: Remove unnecessarily specificity from selectors"
jenkins-bot [Tue, 10 Oct 2017 07:30:49 +0000 (07:30 +0000)]
Merge "Special:UserLogin: Remove unnecessarily specificity from selectors"

5 years agoMerge "Special:UserLogin: Set easier readable `line-height` on form"
jenkins-bot [Tue, 10 Oct 2017 07:30:35 +0000 (07:30 +0000)]
Merge "Special:UserLogin: Set easier readable `line-height` on form"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 9 Oct 2017 20:03:54 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I088f6eec0c374cb1d4d6cb54ac1468a971b9d53d

5 years agoUnwrap types in function docs from {}
Umherirrender [Mon, 9 Oct 2017 19:31:07 +0000 (21:31 +0200)]
Unwrap types in function docs from {}

{} is used in javascript, not in php

Used @(?:param|return|var|throws) \{[^\}]+\} to find&replace

Change-Id: I2e0c9c64b6528f3899d2809d585b5e4859838007

5 years agoDefine MEDIAWIKI_JOB_RUNNER in runJobs.php
Aaron Schulz [Mon, 9 Oct 2017 17:10:13 +0000 (10:10 -0700)]
Define MEDIAWIKI_JOB_RUNNER in runJobs.php

This is the same value used by the WMF /rpc entrypoint.

Change-Id: I146a36c76ff2136e5fa9b768673987ebd611403c

5 years agoMerge "SearchInputWidget: Actually connect to change event"
jenkins-bot [Mon, 9 Oct 2017 16:55:42 +0000 (16:55 +0000)]
Merge "SearchInputWidget: Actually connect to change event"

5 years agoMerge "SearchInputWidget: Pass through description data"
jenkins-bot [Mon, 9 Oct 2017 16:55:38 +0000 (16:55 +0000)]
Merge "SearchInputWidget: Pass through description data"

5 years agoMerge "Remove setting of SearchInputWidget configs to already-default values"
jenkins-bot [Mon, 9 Oct 2017 16:47:54 +0000 (16:47 +0000)]
Merge "Remove setting of SearchInputWidget configs to already-default values"

5 years agoMerge "Align jQuery.suggestions colors to WikimediaUI palette"
jenkins-bot [Mon, 9 Oct 2017 13:31:43 +0000 (13:31 +0000)]
Merge "Align jQuery.suggestions colors to WikimediaUI palette"

5 years agoSearchInputWidget: Actually connect to change event
Ed Sanders [Mon, 9 Oct 2017 09:12:21 +0000 (10:12 +0100)]
SearchInputWidget: Actually connect to change event

This makes the clear indicator-button work, not sure if it
ever worked in the past.

Change-Id: Ia54add0fa5475c37871d82e7750ea4dedbf9dfe3

5 years agoSearchInputWidget: Pass through description data
Ed Sanders [Mon, 9 Oct 2017 08:54:29 +0000 (09:54 +0100)]
SearchInputWidget: Pass through description data

Also make result-parsing code clearer.

Change-Id: Ibf90ba3fc330f442606f243855721182701f7c02

5 years agoSuppress error in MediaWiki\Shell\Command
Gergő Tisza [Sat, 7 Oct 2017 00:31:06 +0000 (00:31 +0000)]
Suppress error in MediaWiki\Shell\Command

Command uses a certain error message to detect and ignore
EINTR in stream_select, and uses trigger_error to clear
the message from get_last_error (clear_last_error is PHP7 only).
This works rather poorly with a system config that does not catch
or ignore most errors; specifically it breaks database tests
on Vagrant with the warnings_as_errors role on.

Change-Id: I9c8f922bc0a8f5ee6b8e7501b22223cce4f98ecb

5 years agoRemove setting of SearchInputWidget configs to already-default values
Ed Sanders [Sun, 8 Oct 2017 18:55:14 +0000 (19:55 +0100)]
Remove setting of SearchInputWidget configs to already-default values

Change-Id: I2710051386ba826895db9d9c675263847625e17f

5 years agoSpecial:UserLogin: Remove unnecessarily specificity from selectors
Volker E [Sun, 8 Oct 2017 06:10:07 +0000 (23:10 -0700)]
Special:UserLogin: Remove unnecessarily specificity from selectors

Removing unnecessary tag selectors from compounded selectors.

Change-Id: Ib180ac6d5b63af587dd2cdacb66cd3889de086bd

5 years agoSpecial:UserLogin: Set easier readable `line-height` on form
Volker E [Sun, 8 Oct 2017 06:05:23 +0000 (23:05 -0700)]
Special:UserLogin: Set easier readable `line-height` on form

Change-Id: Ie29867a6b0ac0ba1558e1b302ffc6df8bff1dba9

5 years agoSpecial:UserLogin: Align text to WikimediaUI color palette
Volker E [Sun, 8 Oct 2017 05:57:39 +0000 (22:57 -0700)]
Special:UserLogin: Align text to WikimediaUI color palette

Also removing unnecessary CSS `top` property.

Bug: T152025
Change-Id: I8945b7c610691de63eaadc465036833d851d1953

5 years agoEnsure only strings are passed to mysql_real_escape_string()
Alexander Mashin [Sun, 1 Oct 2017 00:46:51 +0000 (00:46 +0000)]
Ensure only strings are passed to mysql_real_escape_string()

Under some conditions (Semantic MediaWiki, Gadgets), an integer is
passed to DatabaseMysqli::mysqlRealEscapeString (). This integer is, in
turn, passed to mysqli::real_escape_string (), which needs a string.

Under HHVM 3.19.1 (at least) this type mismatch causes an exception.

A typecast should prevent it.

I repeated the patch in other DB drivers where I could find a function
that escaped strings for SQL.

Bug: T163646
Change-Id: I1b7820bc064dc79498cf9f17747f745990c526b7

5 years agoMerge "Assert that blocks were inserted successfully in UserTest"
jenkins-bot [Sun, 8 Oct 2017 01:48:21 +0000 (01:48 +0000)]
Merge "Assert that blocks were inserted successfully in UserTest"

5 years agoMerge "SearchInputWidget: Don't show images"
jenkins-bot [Sun, 8 Oct 2017 01:40:01 +0000 (01:40 +0000)]
Merge "SearchInputWidget: Don't show images"

5 years agoMerge "Get rid of $IP in Command"
jenkins-bot [Sun, 8 Oct 2017 01:35:36 +0000 (01:35 +0000)]
Merge "Get rid of $IP in Command"

5 years agoMerge "JSONContent: Align to WikimediaUI color palette"
jenkins-bot [Sat, 7 Oct 2017 20:31:22 +0000 (20:31 +0000)]
Merge "JSONContent: Align to WikimediaUI color palette"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 7 Oct 2017 19:54:08 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I4a05d91ddd309bf50c39fdea3e99dba312633afd

5 years agoJSONContent: Align to WikimediaUI color palette
Volker E [Sat, 7 Oct 2017 19:39:46 +0000 (12:39 -0700)]
JSONContent: Align to WikimediaUI color palette

Aligning JSONContent colors to WikimediaUI palette. There's no
definition for a color like `.mw-json .value` yet, we'll probably
further amend in future.

Bug: T152025
Change-Id: I09ddabf52c8d41ade0eca805f73f2c7bc5ade989

5 years agoAlign jQuery.suggestions colors to WikimediaUI palette
Volker E [Sat, 7 Oct 2017 19:29:15 +0000 (12:29 -0700)]
Align jQuery.suggestions colors to WikimediaUI palette

For code sanity in core and consistency.

Change-Id: I8bcfd0f6d2feebe803a56d69d3423dc4d13714f7

5 years agoFix typo in 'language'
Umherirrender [Sat, 7 Oct 2017 16:53:04 +0000 (18:53 +0200)]
Fix typo in 'language'

Change-Id: I3c4d090640892ae07d3da33dcfe3ace397a40808

5 years agoMerge "HTMLForms: Reduce `padding` on top as heading `line-height provides"
jenkins-bot [Sat, 7 Oct 2017 09:28:35 +0000 (09:28 +0000)]
Merge "HTMLForms: Reduce `padding` on top as heading `line-height provides"

5 years agoMerge "HTMLForm: Mangle excessive whitespace"
jenkins-bot [Sat, 7 Oct 2017 09:28:16 +0000 (09:28 +0000)]
Merge "HTMLForm: Mangle excessive whitespace"

5 years agoHTMLForms: Reduce `padding` on top as heading `line-height provides
Volker E [Sat, 7 Oct 2017 04:53:07 +0000 (21:53 -0700)]
HTMLForms: Reduce `padding` on top as heading `line-height provides

Reducing `padding` on top of `.mw-htmlform-ooui-wrapper`
as heading's `line-height provides similar distance.

Bug: T177668
Change-Id: Ieb4c0d1a08f9b7f3481a64ada1638c98f53bc90a

5 years agoGet rid of $IP in Command
Max Semenik [Sat, 7 Oct 2017 02:50:45 +0000 (19:50 -0700)]
Get rid of $IP in Command

Change-Id: Iccfe1b79963462f9cad80ff327ccd574ee1122c5

5 years agoinstaller: Reuse $db->makeList() rather than reinventing the wheel
Reedy [Sat, 9 Sep 2017 16:28:09 +0000 (17:28 +0100)]
installer: Reuse $db->makeList() rather than reinventing the wheel

Change-Id: Ib1f896e5bed17bc240fe585fd6d5f753995a12e1

5 years agoHTMLForm: Mangle excessive whitespace
Volker E [Fri, 6 Oct 2017 22:34:58 +0000 (15:34 -0700)]
HTMLForm: Mangle excessive whitespace

Addressing excessive whitespace in OOUIfied HTMLForms by
- setting form `line-height` to `1.4` in order to
  override core and
- explicitely setting header label `line-height`
  as well.

Bug: T177668
Depends-on: I6463bb204c0000d89fd12a39c4f3c571be0ffc37
Change-Id: I8f503dd5305aef856c6b842c0fdd95522871dca3

5 years agoMerge "HTMLForm: Rename file to `ooui.styles.less` and use LESS notation"
jenkins-bot [Sat, 7 Oct 2017 00:17:34 +0000 (00:17 +0000)]
Merge "HTMLForm: Rename file to `ooui.styles.less` and use LESS notation"

5 years agoMerge "installer: Add comments to purgeCache()"
jenkins-bot [Fri, 6 Oct 2017 23:46:56 +0000 (23:46 +0000)]
Merge "installer: Add comments to purgeCache()"

5 years agoMerge "docs/uidesign/monospace.html: Add textareas to the demo"
jenkins-bot [Fri, 6 Oct 2017 23:23:52 +0000 (23:23 +0000)]
Merge "docs/uidesign/monospace.html: Add textareas to the demo"

5 years agoMerge "resourceloader: Clarify operator precedence"
jenkins-bot [Fri, 6 Oct 2017 23:21:59 +0000 (23:21 +0000)]
Merge "resourceloader: Clarify operator precedence"

5 years agodocs/uidesign/monospace.html: Add textareas to the demo
Bartosz Dziewoński [Thu, 28 Sep 2017 03:19:20 +0000 (05:19 +0200)]
docs/uidesign/monospace.html: Add textareas to the demo

It seems that textareas have their own font-size set in Chrome (but not
Firefox and other browsers), making them unaffected by this behavior.

Change-Id: I811245ea26b4d90ad252fe8f6d2e096e27cb9073

5 years agoresourceloader: Clarify operator precedence
Bartosz Dziewoński [Fri, 6 Oct 2017 22:38:36 +0000 (00:38 +0200)]
resourceloader: Clarify operator precedence

Change-Id: I478db046a1cc162c6767003ce45c9b56270f3372

5 years agoHTMLForm: Rename file to `ooui.styles.less` and use LESS notation
Volker E [Fri, 6 Oct 2017 22:06:45 +0000 (15:06 -0700)]
HTMLForm: Rename file to `ooui.styles.less` and use LESS notation

Turning ooui.styles into a LESS files and take advantage of LESS
notation. This is in preparation for mangling whitespace of
OOUI Special:Pages forms.

Bug: T177668
Change-Id: Icd955358dbbf50712d8a66a0325aa14c8e7963d2

5 years agoinstaller: Add comments to purgeCache()
Timo Tijhof [Fri, 6 Oct 2017 00:25:50 +0000 (01:25 +0100)]
installer: Add comments to purgeCache()

Change-Id: I791f220b49e3e1c7d6df9ccab7d70ff8a0031ef1

5 years agoSearchInputWidget: Don't show images
James D. Forrester [Fri, 6 Oct 2017 19:58:53 +0000 (12:58 -0700)]
SearchInputWidget: Don't show images

But we should also have a different class name for this, as this isn't
upstream's SearchInputWidget.

Bug: T177659
Change-Id: Ie62e8678e89b2403d769694adb23fe21a047019c

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 6 Oct 2017 20:00:00 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Id60644489cb7332c77becff126ef97b4643f83e2

5 years agoClarify purgeExpiredUserrights maintenance script
Eddie Greiner-Petter [Fri, 6 Oct 2017 19:35:29 +0000 (21:35 +0200)]
Clarify purgeExpiredUserrights maintenance script

This moves an @since tag where it belongs (class-level instead of
file-level comment) and removes a wrong message (purges are run directly
after execute() ended and will have immediate effect).

Follows-up on fdb4557.

Change-Id: I26fdb1c147b9b44690a3dd0f7c836aca85430c5e

5 years agoRCFilters UI: In the highlight code, use .data() the way it was meant to be used
Roan Kattouw [Fri, 6 Oct 2017 02:26:44 +0000 (19:26 -0700)]
RCFilters UI: In the highlight code, use .data() the way it was meant to be used

Use .data( 'highlightedFilters' ) instead of .attr( 'data-highlightedFilters' ),
and make the value an array rather than a string that we have to convert
back and forth every time. We have to use .attr() for data-color because it's
used by CSS, but data-highlightedFilters isn't used by anything else.

Using an array makes the code much simpler. Also add the class
mw-rcfilters-highlighted to every highlighted item, so we can find
them back easily and don't have to use $( '[data-highlightedFilters]' )
(attribute selectors are slow, and this wouldn't work with .data() anyway).

Bonus: use the comma-separator message

Change-Id: I04de7f8fb74d60fb23ef47bf50bacfeb176a55b1

5 years agoMerge "HTMLMultiSelectField: Support sections in OOUI mode"
jenkins-bot [Thu, 5 Oct 2017 23:40:07 +0000 (23:40 +0000)]
Merge "HTMLMultiSelectField: Support sections in OOUI mode"

5 years agoMerge "Add maintenance script: Clean up expired userrights"
jenkins-bot [Thu, 5 Oct 2017 22:46:57 +0000 (22:46 +0000)]
Merge "Add maintenance script: Clean up expired userrights"

5 years agojquery.ui: Fix various jQuery Migrate warnings
Timo Tijhof [Thu, 5 Oct 2017 20:30:20 +0000 (21:30 +0100)]
jquery.ui: Fix various jQuery Migrate warnings

These are the most common three, triggered whenever a jQuery UI
dialog is created.

> JQMIGRATE: jQuery.fn.bind() is deprecated
> JQMIGRATE: jQuery.expr.filters is deprecated; use jQuery.expr.pseudos
> JQMIGRATE: jQuery.fn.andSelf() was removed, use jQuery.fn.addBack()

Bug: T169385
Change-Id: I717f2580e3aae443cb9fc734de8f4b0dd8825b8c

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 5 Oct 2017 20:03:15 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I62a90758714d96ddcd91f8959b2e019aa72cfb9b

5 years agojquery-migrate: Disable console.trace() call by default
Timo Tijhof [Thu, 5 Oct 2017 19:26:50 +0000 (20:26 +0100)]
jquery-migrate: Disable console.trace() call by default

They are slow and spammy, especially given in modern browsers
console.warn() already provides a trace (and one that is collapsed
by default in Chrome, which seems preferred).

Change-Id: I94d3c7bf6deb47c2f3f660dfd2298ee293e7d825

5 years agojquery-migrate: Remove redundant PATCH note for Deferred bug
Timo Tijhof [Thu, 5 Oct 2017 19:23:55 +0000 (20:23 +0100)]
jquery-migrate: Remove redundant PATCH note for Deferred bug

This patch was merged upstream and is no longer a local patch
since 2e2ac756e7224 upgraded us to jQuery Migrate 3.0.1.
I mistakenly kept this comment when re-applying our patches.

Change-Id: Id5fa8c03bc5791971a6406376ca8abf5503268f6

5 years agoAdd maintenance script: Clean up expired userrights
Eddie Greiner-Petter [Wed, 4 Oct 2017 19:55:59 +0000 (21:55 +0200)]
Add maintenance script: Clean up expired userrights

This adds a maintenance script that removes all expired user group
entries from the user_groups table and adds them to the
user_former_groups table.

Bug: T176754
Change-Id: Ie0f4afd3dbecd3af42e89bb99cf03dbe03768d07

5 years agoMerge "Refactor global function wfBCP47 to static function LanguageCode::bcp47"
jenkins-bot [Thu, 5 Oct 2017 17:55:50 +0000 (17:55 +0000)]
Merge "Refactor global function wfBCP47 to static function LanguageCode::bcp47"

5 years agoMerge "Revert "Remove some remaining mentions of unstubbing from core""
jenkins-bot [Thu, 5 Oct 2017 17:47:29 +0000 (17:47 +0000)]
Merge "Revert "Remove some remaining mentions of unstubbing from core""

5 years agoRevert "Remove some remaining mentions of unstubbing from core"
Addshore [Thu, 5 Oct 2017 17:27:08 +0000 (17:27 +0000)]
Revert "Remove some remaining mentions of unstubbing from core"

This reverts commit 0f91e75c20e040f0e688fb05654ba7797afcff76.

Bug: T177478
Change-Id: I1937bd116d22479c38a9a34714c2090e2a4c0d7e

5 years agoMerge "RCFilters: Load default saved query if it exists"
jenkins-bot [Thu, 5 Oct 2017 17:26:00 +0000 (17:26 +0000)]
Merge "RCFilters: Load default saved query if it exists"

5 years agoRCFilters: Load default saved query if it exists
Moriel Schottlender [Fri, 18 Aug 2017 21:30:17 +0000 (14:30 -0700)]
RCFilters: Load default saved query if it exists

Bug: T166908
Change-Id: Ic3931bc0d67b340db11ed100aad836e8d867fa56

5 years agoRevert "Stop stubbing StubUserLang"
Addshore [Thu, 5 Oct 2017 16:51:11 +0000 (16:51 +0000)]
Revert "Stop stubbing StubUserLang"

This reverts commit 7ab57ba290f670847f981d5fc2c79339f1d4844e.

Bug: T177478
Change-Id: I28ac95ebcb64231a12c178165a0cb174e70f4e18

5 years agoMerge "Use Special:PageData as the canonical capitalization"
jenkins-bot [Thu, 5 Oct 2017 15:21:17 +0000 (15:21 +0000)]
Merge "Use Special:PageData as the canonical capitalization"

5 years agoMerge "Fix inability of fetching message object"
jenkins-bot [Thu, 5 Oct 2017 13:57:29 +0000 (13:57 +0000)]
Merge "Fix inability of fetching message object"

5 years agoUse Special:PageData as the canonical capitalization
Lucas Werkmeister [Wed, 4 Oct 2017 15:38:10 +0000 (17:38 +0200)]
Use Special:PageData as the canonical capitalization

We want Special:PageData (uppercase D) to be the proper page title and
Special:Pagedata (lowercase d) to redirect to it, not vice versa.
(Special page names are case insensitive, so it’s not necessary to add
the old name Special:Pagedata as an explicit alias.)

Note: if a localisation cache is configured, it needs to be rebuilt
after this change.

Bug: T177411
Change-Id: I27c47a16326540a74d0850467d430faaa25369df

5 years agoRefactor global function wfBCP47 to static function LanguageCode::bcp47
Fomafix [Thu, 6 Apr 2017 15:17:19 +0000 (17:17 +0200)]
Refactor global function wfBCP47 to static function LanguageCode::bcp47

Deprecate global function wfBCP47.

Change-Id: Ie6bb061b5d6ca67289bb18bc468a87421f38fc94

5 years agoMerge "Allow duplicate articles in parser tests with same content"
jenkins-bot [Thu, 5 Oct 2017 07:06:54 +0000 (07:06 +0000)]
Merge "Allow duplicate articles in parser tests with same content"

5 years agoMerge "CLI: Make sure we don't exit with 0 when an exception is encountered"
jenkins-bot [Thu, 5 Oct 2017 06:27:41 +0000 (06:27 +0000)]
Merge "CLI: Make sure we don't exit with 0 when an exception is encountered"

5 years agoMerge "Hard deprecate wfInitShellLocale()"
jenkins-bot [Wed, 4 Oct 2017 22:37:01 +0000 (22:37 +0000)]
Merge "Hard deprecate wfInitShellLocale()"

5 years agoMerge "Make Database::rollback() also suppress callback errors"
jenkins-bot [Wed, 4 Oct 2017 22:28:31 +0000 (22:28 +0000)]
Merge "Make Database::rollback() also suppress callback errors"

5 years agoMerge "TitleWidget: Perform diacritic-insensitive highlighting"
jenkins-bot [Wed, 4 Oct 2017 22:00:23 +0000 (22:00 +0000)]
Merge "TitleWidget: Perform diacritic-insensitive highlighting"

5 years agoHard deprecate wfInitShellLocale()
Max Semenik [Wed, 4 Oct 2017 21:58:38 +0000 (14:58 -0700)]
Hard deprecate wfInitShellLocale()

Soft deprecated since 1.30, no callers anywhere.

Change-Id: Ifec11eb3c2c25ea9d7e5ecb72c53127536ab6c30

5 years agoMerge "mediawiki.notification: Move offset() computation to next frame"
jenkins-bot [Wed, 4 Oct 2017 21:52:50 +0000 (21:52 +0000)]
Merge "mediawiki.notification: Move offset() computation to next frame"

5 years agoMerge "mediawiki.notification: Refactor $.ready handler and init()"
jenkins-bot [Wed, 4 Oct 2017 21:47:22 +0000 (21:47 +0000)]
Merge "mediawiki.notification: Refactor $.ready handler and init()"

5 years agoMerge "mediawiki.notification: Use css() instead of slow show()/hide()"
jenkins-bot [Wed, 4 Oct 2017 21:44:23 +0000 (21:44 +0000)]
Merge "mediawiki.notification: Use css() instead of slow show()/hide()"

5 years agomediawiki.notification: Move offset() computation to next frame
Timo Tijhof [Wed, 4 Oct 2017 20:30:24 +0000 (21:30 +0100)]
mediawiki.notification: Move offset() computation to next frame

Crrently on all page views in WMF production, the $.ready handler
is inserting the notif $area and subsequently doing a forced
style calculation due to getBoundingClientRect() from offset().

Move this to an animation frame instead and re-order the statements
so that DOM reads go before DOM writes.

Change-Id: I7c6201dc8d4e3227e01b75e853b6e4dc9a734031

5 years agomediawiki.notification: Refactor $.ready handler and init()
Timo Tijhof [Wed, 4 Oct 2017 20:10:57 +0000 (21:10 +0100)]
mediawiki.notification: Refactor $.ready handler and init()

* Merge code from $.ready handler into init().
  This makes it more obvious in which order the code runs, and
  makes it easier to make perf fixes in the next commit.

* Move updateAreaMode() to the start of the init() function.

Change-Id: I088446e17c2dc8ed88742bfeae80352444126e88

5 years agoMerge "Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c"
jenkins-bot [Wed, 4 Oct 2017 21:04:52 +0000 (21:04 +0000)]
Merge "Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c"

5 years agoMerge "RCFilters: Allows specifying default highlights from the server"
jenkins-bot [Wed, 4 Oct 2017 20:58:42 +0000 (20:58 +0000)]
Merge "RCFilters: Allows specifying default highlights from the server"