lhc/web/wiklou.git
3 years agoRemove "probably you" from password reset email information
Reedy [Mon, 12 Mar 2018 14:45:58 +0000 (14:45 +0000)]
Remove "probably you" from password reset email information

Bug: T189492
Change-Id: I6fe5bbe11487642fb0ac95e53d563621de7323f4

3 years agoMerge "Fix typo acceptible --> acceptable"
jenkins-bot [Mon, 12 Mar 2018 12:12:04 +0000 (12:12 +0000)]
Merge "Fix typo acceptible --> acceptable"

3 years agoFix typo acceptible --> acceptable
Jayprakash12345 [Mon, 12 Mar 2018 10:53:20 +0000 (10:53 +0000)]
Fix typo acceptible --> acceptable

Change-Id: I9304d830744238e4733240dd65c285fed61d0416

3 years agoAdd Hijri calendar in Urdu
zoranzoki21 [Sun, 4 Feb 2018 18:20:14 +0000 (19:20 +0100)]
Add Hijri calendar in Urdu

Allows users to select their preferred calendar from Preferences.

Bug: T145266
Change-Id: I7299d0f84f629da781b100c4db6b2a30a7d1bb86

3 years agoMerge "Remove "dash" case in preprocessToObj"
jenkins-bot [Mon, 12 Mar 2018 03:06:30 +0000 (03:06 +0000)]
Merge "Remove "dash" case in preprocessToObj"

3 years agoMerge "Move phpunit @group from file comment to class comment"
jenkins-bot [Mon, 12 Mar 2018 00:53:28 +0000 (00:53 +0000)]
Merge "Move phpunit @group from file comment to class comment"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 11 Mar 2018 20:56:39 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Iea4877827a12d5117578b8d1a6f1fefc53e1cdeb

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 10 Mar 2018 20:54:04 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I556a81048fbf024a585f7f586b91762eea568cb3

3 years agoMove phpunit @group from file comment to class comment
Umherirrender [Fri, 9 Mar 2018 21:56:41 +0000 (22:56 +0100)]
Move phpunit @group from file comment to class comment

Remove @group from non tests

Change-Id: Iae9ee3bc5f539a9b4ded8374006ab2993234450e

3 years agoMerge "Fix typo in word compatibility"
jenkins-bot [Sat, 10 Mar 2018 01:04:31 +0000 (01:04 +0000)]
Merge "Fix typo in word compatibility"

3 years agoCleanup some comments related to DB replication
Aaron Schulz [Fri, 9 Mar 2018 11:32:30 +0000 (03:32 -0800)]
Cleanup some comments related to DB replication

Change-Id: Icaaa5144beaedfebb88530480733a1e916c935fb

3 years agoRemove "dash" case in preprocessToObj
Arlo Breault [Fri, 9 Mar 2018 22:46:53 +0000 (17:46 -0500)]
Remove "dash" case in preprocessToObj

This was introduced in 2877402 and removed in 186a182

Change-Id: Ibfa1ae1597bfc50ae6ea49402c7966ca042f12e5

3 years agoFix typo in word compatibility
Umherirrender [Fri, 9 Mar 2018 22:04:44 +0000 (23:04 +0100)]
Fix typo in word compatibility

Change-Id: Ic6ad14f5e156311cee3021cd427561dfcd68633a

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 9 Mar 2018 21:00:22 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib13656ed8c5c45facc4166963cd4a7f32ade30bf

3 years agoMerge "Add ExternalUserNames::getLocal() to get local part of username"
jenkins-bot [Fri, 9 Mar 2018 20:53:30 +0000 (20:53 +0000)]
Merge "Add ExternalUserNames::getLocal() to get local part of username"

3 years agoMerge "API: Update prefixsearch/opensearch docs"
jenkins-bot [Fri, 9 Mar 2018 20:05:34 +0000 (20:05 +0000)]
Merge "API: Update prefixsearch/opensearch docs"

3 years agoAdd ExternalUserNames::getLocal() to get local part of username
Amir Sarabadani [Fri, 9 Mar 2018 19:32:41 +0000 (20:32 +0100)]
Add ExternalUserNames::getLocal() to get local part of username

Bug: T189320
Change-Id: I99908ced218c45ecbb23f390f065170292f153b4

3 years agoAPI: Update prefixsearch/opensearch docs
Brad Jorsch [Fri, 9 Mar 2018 19:44:17 +0000 (14:44 -0500)]
API: Update prefixsearch/opensearch docs

The psnamespace parameter to action=query&list=prefixsearch is ignored
if pssearch has a valid namespace prefix. This should be documented.

Same for the similar parameters to action=opensearch.

Bug: T189139
Change-Id: I4914e5c915e6f8e5c0d5116f034ca671fe45a3f8

3 years agoRemove useless use
Brad Jorsch [Fri, 9 Mar 2018 19:11:36 +0000 (14:11 -0500)]
Remove useless use

A use declaration for a non-namespaced class in a non-namespaced context
causes a PHP warning.

Bug: T189302
Change-Id: I023e64c8194dd03cc3a1098e2d60c73f99bb02e3

3 years agoRemove deprecated function wfBaseConvert()
Jayprakash12345 [Fri, 9 Mar 2018 13:06:58 +0000 (13:06 +0000)]
Remove deprecated function wfBaseConvert()

Bug: T189300
Change-Id: I5f05beb105dca8e8079e770df562c004a689c2ed

3 years agoMerge "Replace wfGetLBFactory"
jenkins-bot [Fri, 9 Mar 2018 11:33:10 +0000 (11:33 +0000)]
Merge "Replace wfGetLBFactory"

3 years agoMerge "purgeExpiredUserrights: Show number of rows purged"
jenkins-bot [Fri, 9 Mar 2018 10:45:53 +0000 (10:45 +0000)]
Merge "purgeExpiredUserrights: Show number of rows purged"

3 years agoMerge "Fix spelling mistake inside API i18n message"
jenkins-bot [Fri, 9 Mar 2018 10:37:27 +0000 (10:37 +0000)]
Merge "Fix spelling mistake inside API i18n message"

3 years agoFix spelling mistake inside API i18n message
Southparkfan [Thu, 8 Mar 2018 22:13:35 +0000 (22:13 +0000)]
Fix spelling mistake inside API i18n message

Change-Id: Ief2814e2fdd94b68eb6a52261b3aa4f47009bfc6

3 years agoMerge "rdbms: small cleanups to session loss handling"
jenkins-bot [Fri, 9 Mar 2018 00:25:59 +0000 (00:25 +0000)]
Merge "rdbms: small cleanups to session loss handling"

3 years agoMerge "Update OOUI to v0.25.3"
jenkins-bot [Thu, 8 Mar 2018 23:15:23 +0000 (23:15 +0000)]
Merge "Update OOUI to v0.25.3"

3 years agoTypo fix
Brad Jorsch [Thu, 8 Mar 2018 21:46:08 +0000 (16:46 -0500)]
Typo fix

Bug: T189251
Change-Id: I5e7af2629d566181f3280049b6847c0126850ff2

3 years agordbms: small cleanups to session loss handling
Aaron Schulz [Thu, 8 Mar 2018 20:40:07 +0000 (12:40 -0800)]
rdbms: small cleanups to session loss handling

Split the two callback runner calls in handleSessionLoss() into two
separate try/catch loops. Return the first exception, if any.

Also make the $recoverable check for connection loss in Database::query
slightly more readable by checking the positive rather than the negative.

Change-Id: I75935fa69e40450ac3983f0d3451ab3001650b6f

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 8 Mar 2018 21:23:54 +0000 (22:23 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I34c71561c72518697570e7f35bbf3e5ca6ea8e3d

3 years agoMerge "Job::insert: Hard deprecate (soft-deprecated in 1.21!)"
jenkins-bot [Thu, 8 Mar 2018 20:28:42 +0000 (20:28 +0000)]
Merge "Job::insert: Hard deprecate (soft-deprecated in 1.21!)"

3 years agoDrop OpenSearch::getOpenSearchTemplate(), deprecated in 1.25
James D. Forrester [Tue, 6 Mar 2018 17:08:09 +0000 (17:08 +0000)]
Drop OpenSearch::getOpenSearchTemplate(), deprecated in 1.25

Change-Id: Ib76b96cf392b7f9fa38d28173dd2cd170e08a881

3 years agordbms: Restore test for Database::setFlag()
Timo Tijhof [Thu, 8 Mar 2018 04:10:13 +0000 (20:10 -0800)]
rdbms: Restore test for Database::setFlag()

Follows-up b4eb1feed05b5, which inadvertendly replaced the setFlag()
test with the clearFlag() test.

Also move the test to the DatabaseTest.php file given it's only
executing and covering base class.

Change-Id: I2f4ed6c4eeba845eb67013e1ab7d2b2bde863119

3 years agoMerge "Self links should not be marked as legacy css"
jenkins-bot [Wed, 7 Mar 2018 23:54:06 +0000 (23:54 +0000)]
Merge "Self links should not be marked as legacy css"

3 years agoMerge "maintainance: Re-order OOUI script to be clearer, rename"
jenkins-bot [Wed, 7 Mar 2018 23:01:04 +0000 (23:01 +0000)]
Merge "maintainance: Re-order OOUI script to be clearer, rename"

3 years agoMerge "tables.sql: Correct lie about ct_params being unused"
jenkins-bot [Wed, 7 Mar 2018 22:58:26 +0000 (22:58 +0000)]
Merge "tables.sql: Correct lie about ct_params being unused"

3 years agotables.sql: Correct lie about ct_params being unused
Roan Kattouw [Wed, 7 Mar 2018 22:48:26 +0000 (14:48 -0800)]
tables.sql: Correct lie about ct_params being unused

It is used by ContentTranslation to store things like
{"from":"es","to":"en"}

Change-Id: I880ecc74ab46dde2fa00ddb7baea08edeabcf676

3 years agoUpdate wikimedia/remex-html to 1.0.3
Kunal Mehta [Wed, 7 Mar 2018 21:26:27 +0000 (13:26 -0800)]
Update wikimedia/remex-html to 1.0.3

Depends-On: I537768aa34f0bfa8da3aa401d9a7c4b8ba380508
Change-Id: Ifedb963c4ddf941c46bea9527fd8860b273e2d71

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 7 Mar 2018 21:23:54 +0000 (22:23 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ifae4500f5cfbeb69cf8a055b7d0274898ea68fee

3 years agoRemove FakeDatabaseMysqlBase test class
Aaron Schulz [Fri, 2 Mar 2018 05:25:00 +0000 (21:25 -0800)]
Remove FakeDatabaseMysqlBase test class

Improve some flag tests that did not seem to test much

Change-Id: Iecfc877645cc66cb696beb2b314a6d149745a530

3 years agomaintainance: Re-order OOUI script to be clearer, rename
James D. Forrester [Wed, 7 Mar 2018 18:34:28 +0000 (18:34 +0000)]
maintainance: Re-order OOUI script to be clearer, rename

Change-Id: I6fa9b4840a4b01a71aeb618973f4b858fa1a6c9c

3 years agoUpdate OOUI to v0.25.3
Volker E [Wed, 7 Mar 2018 07:13:15 +0000 (23:13 -0800)]
Update OOUI to v0.25.3

Release notes:
 https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.3

Depends-On: I4b847a3e253def12ba1fa15607e1700a4a2c236a
Change-Id: Id10209ea2e36beaac36a0d3509edaa83442290b4

3 years agoMerge "Restore index forcing in ContribsPager"
jenkins-bot [Wed, 7 Mar 2018 17:21:12 +0000 (17:21 +0000)]
Merge "Restore index forcing in ContribsPager"

3 years agoMerge "Introduce IDatabase::buildIntegerCast"
jenkins-bot [Wed, 7 Mar 2018 15:06:05 +0000 (15:06 +0000)]
Merge "Introduce IDatabase::buildIntegerCast"

3 years agoMerge "Introduce IDatabase::buildSubstring"
jenkins-bot [Wed, 7 Mar 2018 15:06:02 +0000 (15:06 +0000)]
Merge "Introduce IDatabase::buildSubstring"

3 years agoArticle.php: Use BCP 47 language code for HTML attribute lang
Fomafix [Wed, 7 Mar 2018 13:16:02 +0000 (14:16 +0100)]
Article.php: Use BCP 47 language code for HTML attribute lang

Change-Id: If2194fbb98cbab284aba74e127cc3953a5714b9b

3 years agoIntroduce IDatabase::buildIntegerCast
addshore [Sun, 4 Mar 2018 13:50:28 +0000 (13:50 +0000)]
Introduce IDatabase::buildIntegerCast

Change-Id: Ib24856d1ebe017ff07ae497972c764b4a3f3c7df

3 years agoIntroduce IDatabase::buildSubstring
addshore [Sun, 4 Mar 2018 13:23:39 +0000 (13:23 +0000)]
Introduce IDatabase::buildSubstring

Change-Id: I96f3e0c4920d52f63175cb6767c149f20a8a8cde

3 years agoMerge "Add support for 'hu-formal'"
jenkins-bot [Wed, 7 Mar 2018 10:55:43 +0000 (10:55 +0000)]
Merge "Add support for 'hu-formal'"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 7 Mar 2018 07:02:09 +0000 (08:02 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I8d388605f385e8be40f22459be2cda7105ce6600

3 years agoMerge "Use `class="free external"` only on unbracketed URLs"
jenkins-bot [Wed, 7 Mar 2018 05:49:24 +0000 (05:49 +0000)]
Merge "Use `class="free external"` only on unbracketed URLs"

3 years agoUse `class="free external"` only on unbracketed URLs
C. Scott Ananian [Wed, 28 Feb 2018 21:11:09 +0000 (16:11 -0500)]
Use `class="free external"` only on unbracketed URLs

The ability for URLs to be marked free even if they use bracketed syntax
but "sorta look free" (aka unbracketed) was added 13 years ago in
2d71cb30802e5cb78a423a1699ad87e23bfe9f4e (r7074).

It seemed like a reasonable idea at the time: make printed output a little
prettier by marking "sorta free" URLs as free.  But this complicates the
semantics of wikitext, and introduces all sorts of strange corner cases,
for example:

  [http://example.com/& http://example.com/&]

isn't marked as free, even though the parser output is:

  <a rel="nofollow" class="external text" href="http://example.com/&amp;">http://example.com/&amp;</a>

This functionality isn't actually needed: if you want the pretty printed
output of an unbracketed URL, then actually use an unbracketed URL.

In recent years we're more concerned with simplifying the semantics of
wikitext and eliminating corner cases, such that the content of our wikis
can be effectively archived.  The "effectively free" URLs are low-hanging
fruit in this quest.

Change-Id: I339e8698786c60c96a37a73443cb9a04362662c4

3 years agoMerge "Allow querying contributions of interwiki usernames"
jenkins-bot [Wed, 7 Mar 2018 04:25:32 +0000 (04:25 +0000)]
Merge "Allow querying contributions of interwiki usernames"

3 years agoSync up with Parsoid parserTests.txt
C. Scott Ananian [Tue, 6 Mar 2018 22:26:16 +0000 (17:26 -0500)]
Sync up with Parsoid parserTests.txt

This now aligns with Parsoid commit 7d2a92f81ebbc0941e8fba2a136f5929406ea5e6

Change-Id: I0b57b1bd3b0802ce08249dd0bf376b931d8c7698

3 years agoMerge "Use RemexHtml as the tidy implementation for parser tests"
jenkins-bot [Tue, 6 Mar 2018 22:27:42 +0000 (22:27 +0000)]
Merge "Use RemexHtml as the tidy implementation for parser tests"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Tue, 6 Mar 2018 20:57:42 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic9ff9f542c9e630bcac1d4037ca3e8faf2dbcb03

3 years agoMerge "Change Recent Changes "Number of edits..." preference message"
jenkins-bot [Tue, 6 Mar 2018 20:02:12 +0000 (20:02 +0000)]
Merge "Change Recent Changes "Number of edits..." preference message"

3 years agoAllow querying contributions of interwiki usernames
Brad Jorsch [Mon, 12 Feb 2018 15:11:40 +0000 (10:11 -0500)]
Allow querying contributions of interwiki usernames

Both for Special:Contributions and ApiQueryUserContributions.

Bug: T187079
Change-Id: I4398e473b90172851e875b3f219f7076dceda66c

3 years agoSelf links should not be marked as legacy css
jdlrobson [Tue, 6 Mar 2018 18:04:12 +0000 (10:04 -0800)]
Self links should not be marked as legacy css

Bug: T181472
Change-Id: Ia19a223a2393d5920ae044c396dc25e80354b3fe

3 years agoRestore index forcing in ContribsPager
Brad Jorsch [Tue, 6 Mar 2018 17:07:55 +0000 (12:07 -0500)]
Restore index forcing in ContribsPager

For now at least this will avoid a filesort for some cases. But it might
start misbehaving again when $wgActorTableSchemaMigrationStage is set to
WRITE_BOTH or WRITE_NEW.

Bug: T189026
Change-Id: Idd987181b17b824fdf1094f5c3b1c689b1792eb0

3 years agoDon't target log_user_text for registered users
Brad Jorsch [Tue, 6 Mar 2018 16:18:45 +0000 (11:18 -0500)]
Don't target log_user_text for registered users

Apparently when log_user_text was added no one bothered to populate it
for existing rows. Sigh, #Technical-Debt.

Bug: T188826
Change-Id: Ice1e6454e439a4abdf9594f6e964478dd484bc20

3 years agoMerge "mediawiki.special.apisandbox: Reorder functions"
jenkins-bot [Tue, 6 Mar 2018 12:47:42 +0000 (12:47 +0000)]
Merge "mediawiki.special.apisandbox: Reorder functions"

3 years agoMerge "Introduce DatabaseLogEntry::newFromId"
jenkins-bot [Tue, 6 Mar 2018 02:53:18 +0000 (02:53 +0000)]
Merge "Introduce DatabaseLogEntry::newFromId"

3 years agoMerge "Add test for WikiPage post-edit stats update"
jenkins-bot [Tue, 6 Mar 2018 01:51:27 +0000 (01:51 +0000)]
Merge "Add test for WikiPage post-edit stats update"

3 years agoMerge "rdbms: cleanup some type checks and documentation"
jenkins-bot [Tue, 6 Mar 2018 01:21:46 +0000 (01:21 +0000)]
Merge "rdbms: cleanup some type checks and documentation"

3 years agoAdd test for WikiPage post-edit stats update
Aaron Schulz [Wed, 28 Feb 2018 02:01:02 +0000 (18:01 -0800)]
Add test for WikiPage post-edit stats update

Bug: T187585
Change-Id: I734b7f42799a9bfe77a1fb1269bb3d48b3852ffd

3 years agoIntroduce DatabaseLogEntry::newFromId
Max Semenik [Sat, 3 Mar 2018 03:56:39 +0000 (19:56 -0800)]
Introduce DatabaseLogEntry::newFromId

It's a helper function for when you need just one log entry.

Change-Id: Ic5e9db0def857d9dcecbd06bf081c8c83712c1ea

3 years agoMerge "resourceloader: Add test for non-empty user module in scripts-only queue"
jenkins-bot [Mon, 5 Mar 2018 23:49:06 +0000 (23:49 +0000)]
Merge "resourceloader: Add test for non-empty user module in scripts-only queue"

3 years agoMerge "Update docs for AllowUserCssPrefs to not mention performance"
jenkins-bot [Mon, 5 Mar 2018 23:42:38 +0000 (23:42 +0000)]
Merge "Update docs for AllowUserCssPrefs to not mention performance"

3 years agoMerge "DifferenceEngine: Use CSS classes instead of inline styles"
jenkins-bot [Mon, 5 Mar 2018 23:41:26 +0000 (23:41 +0000)]
Merge "DifferenceEngine: Use CSS classes instead of inline styles"

3 years agoresourceloader: Add test for non-empty user module in scripts-only queue
Timo Tijhof [Mon, 5 Mar 2018 22:41:29 +0000 (14:41 -0800)]
resourceloader: Add test for non-empty user module in scripts-only queue

The getData() tests did have a test case for a 'user' group module with
isKnownEmpty in the script-only queue, but not yet a non-empty one.

The makeLoad() tests did have both already. Arguably the makeLoad()
tests are higher level and observe its behaviour already (outputting
a script tag means 'loading', outputting nothing means 'ready'),
but adding it to the getData() tests for consistency.

Bug: T188689
Change-Id: I842febf996ba8bb0ea25b5ca3b5ac4503db87376

3 years agoSECURITY: Fix revdel checks in LogPager
Brian Wolff [Fri, 23 Feb 2018 21:52:25 +0000 (21:52 +0000)]
SECURITY: Fix revdel checks in LogPager

Follow-up to ce881e02e8d6 where the check for performer
restrictions and action restrictions was reversed.

Bug: T188145
Change-Id: I85a44f925212929ac87fb7a7e494023258f2d148

3 years agoUpdate docs for AllowUserCssPrefs to not mention performance
Timo Tijhof [Mon, 5 Mar 2018 22:15:44 +0000 (14:15 -0800)]
Update docs for AllowUserCssPrefs to not mention performance

* Before 2011, this was implemented as an inline stylesheet in OutputPage.
* In 2011, this was re-implemented through the 'user.cssprefs' module
  (class: ResourceLoaderUserCSSPrefsModule) embedded in OutputPage.
* Between 2013 and 2016, all user-css preferences have either been
  removed or migrarated to not need this module, eventually resulting
  in the removal of that module in 2c688cfb11ea6c.

More details on T127328, but suffice it to say, it has no significant
performance concerns currently.

Change-Id: Ia89c4f91ecb67e3116989f2ea97c7ca69275a2fb

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 5 Mar 2018 21:04:47 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I6aab8000374adfaa44c7f4ec3490969f58419f06

3 years ago[JobQueueSecondTestQueue] Support read-only mode.
Petr Pchelko [Mon, 5 Mar 2018 19:44:11 +0000 (16:44 -0300)]
[JobQueueSecondTestQueue] Support read-only mode.

In order to switch non-idempotent jobs without losing the
backlog in redis we should support read-only mode in the queue,
where the messages only gets written into the new queue.

Change-Id: I2e9cb2d9cbbd2d657d042b55d4ea0819d21cdd6f

3 years agoMerge "Revert "Log the reason why revision->getContent() returns null""
jenkins-bot [Mon, 5 Mar 2018 18:51:58 +0000 (18:51 +0000)]
Merge "Revert "Log the reason why revision->getContent() returns null""

3 years agoMerge "EditPage: In the list of "templates used", highlight redirect templates"
jenkins-bot [Mon, 5 Mar 2018 18:33:47 +0000 (18:33 +0000)]
Merge "EditPage: In the list of "templates used", highlight redirect templates"

3 years agoEditPage: In the list of "templates used", highlight redirect templates
AdityaJ [Sat, 3 Mar 2018 08:25:17 +0000 (13:55 +0530)]
EditPage: In the list of "templates used", highlight redirect templates

Bug: T188737
Change-Id: I16af53c5048a95fd166f8e79ea26f164c1d3a49d

3 years agoDifferenceEngine: Use CSS classes instead of inline styles
Bartosz Dziewoński [Mon, 5 Mar 2018 18:24:37 +0000 (19:24 +0100)]
DifferenceEngine: Use CSS classes instead of inline styles

Change-Id: Iee0e5e7eb73023a6f57c1f462e71cbb0e771d1f2

3 years agoMerge "StripState testing and cleanup"
jenkins-bot [Mon, 5 Mar 2018 18:04:06 +0000 (18:04 +0000)]
Merge "StripState testing and cleanup"

3 years agoMerge "Limit total expansion size in StripState and improve limit handling"
jenkins-bot [Mon, 5 Mar 2018 18:02:30 +0000 (18:02 +0000)]
Merge "Limit total expansion size in StripState and improve limit handling"

3 years agoRevert "Log the reason why revision->getContent() returns null"
Sbisson [Mon, 5 Mar 2018 15:17:46 +0000 (15:17 +0000)]
Revert "Log the reason why revision->getContent() returns null"

This reverts commit 8eb00f158422e5e2a9198f9d4318a1570b0f47af.

Change-Id: Id14fd26845349f8aca110ac1bad0598770122f25

3 years agoMerge "Fix master/replica race condition when creating null revisions"
jenkins-bot [Mon, 5 Mar 2018 11:59:33 +0000 (11:59 +0000)]
Merge "Fix master/replica race condition when creating null revisions"

3 years agoStripState testing and cleanup
Tim Starling [Wed, 28 Feb 2018 09:42:40 +0000 (20:42 +1100)]
StripState testing and cleanup

* Added StripState unit tests
* Deprecated unmaintained "half-parsed" serialization experiment
* Renamed some variables for brevity and removed unused "prefix"

Change-Id: I838d7ac7f9a2189e13d39c6939dba5d70e74a6b7

3 years agoLimit total expansion size in StripState and improve limit handling
Tim Starling [Wed, 28 Feb 2018 02:11:56 +0000 (13:11 +1100)]
Limit total expansion size in StripState and improve limit handling

* Add a new limit to the parser which limits the size of the output
  generated by StripState. The relevant bug shows exponential blowup in
  output size.
* Remove the $prefix parameter from the StripState constructor. Used by
  no Gerrit-hosted extensions, hard-deprecated since 1.26.
* Convert the existing unstrip recursion depth limit to a normal parser
  limit with limit report row, warning and tracking category. Provide
  the same features in the new limit.
* Add an optional $parser parameter to the StripState constructor so
  that warnings and tracking categories can be added.

Bug: T187833
Change-Id: Ie5f6081177610dc7830de4a0a40705c0c8cb82f1

3 years agomediawiki.special.apisandbox: Reorder functions
Fomafix [Sat, 3 Mar 2018 19:38:14 +0000 (20:38 +0100)]
mediawiki.special.apisandbox: Reorder functions

This avoids forward references and
  /* eslint-disable no-use-before-define */
can removed.

Change-Id: If26a9c275665d20864687cd99d3679b362291fa9

3 years agoApiQueryContributors: Use correct variable
Brad Jorsch [Sun, 4 Mar 2018 04:31:02 +0000 (23:31 -0500)]
ApiQueryContributors: Use correct variable

Bug: T188813
Change-Id: Ibc705d61d57cfe8867d1bde35781515c25b777c1

3 years agordbms: cleanup some type checks and documentation
Aaron Schulz [Fri, 2 Mar 2018 10:11:35 +0000 (02:11 -0800)]
rdbms: cleanup some type checks and documentation

This clears up some IDEA warnings for database classes

Change-Id: Ic6f3812b012c1791986d24723b757daf4e151e45

3 years agoMerge "Drop 'comma' value for wgArticleCountMethod"
jenkins-bot [Sat, 3 Mar 2018 23:06:23 +0000 (23:06 +0000)]
Merge "Drop 'comma' value for wgArticleCountMethod"

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 3 Mar 2018 20:59:53 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I12d8afdf599386fa27fd3f9ff96f77e16ef9a560

3 years agopurgeExpiredUserrights: Show number of rows purged
Eddie Greiner-Petter [Sat, 3 Mar 2018 15:26:39 +0000 (15:26 +0000)]
purgeExpiredUserrights: Show number of rows purged

Show the number of rows purged when running
maintenance/purgeExpiredUserrights.php

Bug: T176754
Change-Id: I091042baef8982c108b17126cde4998fc9a0cd6d

3 years agoFix master/replica race condition when creating null revisions
Roan Kattouw [Sat, 3 Mar 2018 03:54:45 +0000 (19:54 -0800)]
Fix master/replica race condition when creating null revisions

RevisionStore::newFromNullRevision() carefully reads the latest revision
from the master, but then forgets to instruct emulateMainSlot_1_29() to
do the same, so the lookup query for rev_text_id in the text table is
done against a replica.

This is not usually a problem for null revisions, but it is a problem
when editing a page and then immediately moving it: this causes a null
revision to be created based on a freshly created revision, which
doesn't yet exist on the replica.

Bug: T184670
Change-Id: Ied4db5ee770716ff3edb918d2be722934c79d0c7

3 years agoUse RemexHtml as the tidy implementation for parser tests
Kunal Mehta [Fri, 9 Feb 2018 20:10:07 +0000 (12:10 -0800)]
Use RemexHtml as the tidy implementation for parser tests

* RemexHtml is the future of "tidy" in MediaWiki,
  so run our parser tests using it.

* This is a necessary step before we can make it
  the default in MediaWiki (T185753).

* Cleaned up a bunch of tests:
  (a) where html/php+tidy and html/parsoid match up,
      retained a html+tidy section and removed the others.
  (b) where html/php and html/php+tidy match up,
      retained the html/php section and removed the
      html/php+tidy section.

* Annotating tests with explanations where Parsoid & Remex
  output differ. This is usually because of two reasons:
  (a) Parsoid has Tidy-emulation code in some cases (which
      we can consider stripping away separately).
  (b) Parsoid does a bunch of cleanup on the DOM (which was
      probably done to emulate Tidy output, but which could
      probably be retained). Since Parsoid (in some form)
      will be default parser in the future, no reason to try
      to port this cleanup (in broken markup scenarios) into
      Remex.

* Left a bunch of FIXMEs for later followup.

Unrelated cleanup:
* Renamed a few tests since the functionality in Parsoid
  was fixed up. There is no more "implicit <td>" support.
  Those all now lead to fostered content.
* Fixed some clearly broken output in html/parsoid sections
  for some tests.

Co-Authored-by: Kunal Mehta <legoktm@member.fsf.org>
Co-Authored-by: Subramanya Sastry <ssastry@wikimedia.org>
Bug: T188167
Depends-On: I646dbabb3c2ed28c1ea72c5bd8f7f92d03f57c75
Change-Id: Ic7c34d57a300dbd36a37f03fbfe33391b2950b44

3 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 2 Mar 2018 21:01:20 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.

Change-Id: I29741ea3f2e69c74456584857b144f2cdb7465f9

3 years agoMerge "Introduce hasSlot in RevisionRecord and RevisionSlots."
jenkins-bot [Fri, 2 Mar 2018 20:38:59 +0000 (20:38 +0000)]
Merge "Introduce hasSlot in RevisionRecord and RevisionSlots."

3 years ago[MCR] NameTableStore
addshore [Tue, 16 Jan 2018 13:53:22 +0000 (13:53 +0000)]
[MCR] NameTableStore

General purpose cached store for things like:
 - content_models (id,name)
 - slot_roles (id,name)
And in the future possibly namespaces & content_formats
as mentioned at:
https://www.mediawiki.org/wiki/Multi-Content_Revisions/Schema_Migration#Name_tables

Bug: T188518
Change-Id: Ia550ef7fe30af25ac3fee5ac8a89d032544563bf

3 years agoMerge "rdbms: make LoadBalancer::getConnection() ignore CONN_TRX_AUTO when unusable"
jenkins-bot [Fri, 2 Mar 2018 19:26:49 +0000 (19:26 +0000)]
Merge "rdbms: make LoadBalancer::getConnection() ignore CONN_TRX_AUTO when unusable"

3 years agoMerge "rdbms: avoid strange uses of empty()"
jenkins-bot [Fri, 2 Mar 2018 19:13:58 +0000 (19:13 +0000)]
Merge "rdbms: avoid strange uses of empty()"

3 years agoMerge "rdbms: add missing hint check DatabaseMysqlBase::isInsertSelectSafe"
jenkins-bot [Fri, 2 Mar 2018 19:10:28 +0000 (19:10 +0000)]
Merge "rdbms: add missing hint check DatabaseMysqlBase::isInsertSelectSafe"

3 years agoMerge "Ensure abort link parsing on xmlish tag in link title position"
jenkins-bot [Fri, 2 Mar 2018 18:55:37 +0000 (18:55 +0000)]
Merge "Ensure abort link parsing on xmlish tag in link title position"

3 years agordbms: make LoadBalancer::getConnection() ignore CONN_TRX_AUTO when unusable
Aaron Schulz [Wed, 28 Feb 2018 00:00:05 +0000 (16:00 -0800)]
rdbms: make LoadBalancer::getConnection() ignore CONN_TRX_AUTO when unusable

Change-Id: I1fd13171c3cfbe071e8e398d561281188d998767