lhc/web/wiklou.git
5 years agoRemove UtfNormal class
Reedy [Thu, 31 May 2018 23:37:07 +0000 (00:37 +0100)]
Remove UtfNormal class

Change-Id: I1cab16d95ed888b482d23f73577c988700e0bca4

5 years agoHard-deprecate LegacyHookPreAuthenticationProvider class
Gergő Tisza [Wed, 10 Oct 2018 01:21:54 +0000 (18:21 -0700)]
Hard-deprecate LegacyHookPreAuthenticationProvider class

The hooks that used to be called by this class will be removed in
I24d6fa963. The only reason to keep this class around is that
someone might have added it to $wgAuthManagerConfig so removing
it would trigger class lookup failures, so make sure any use
of the class triggers a deprecation warning.

Change-Id: I9755288eda7461ecf3dcd35de2081fbb3eb04ae3

5 years agoMerge "Remove untidy wrapper from ImagePage::makeMetadataTable()"
jenkins-bot [Mon, 22 Oct 2018 17:39:12 +0000 (17:39 +0000)]
Merge "Remove untidy wrapper from ImagePage::makeMetadataTable()"

5 years agoMerge "Fix bad join on ChangeTag subquery"
jenkins-bot [Mon, 22 Oct 2018 17:38:02 +0000 (17:38 +0000)]
Merge "Fix bad join on ChangeTag subquery"

5 years agoMerge "Include BCP 47 codes in $wgDummyLanguageCodes, but deprecate it"
jenkins-bot [Mon, 22 Oct 2018 17:13:50 +0000 (17:13 +0000)]
Merge "Include BCP 47 codes in $wgDummyLanguageCodes, but deprecate it"

5 years agoMerge "Deprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode"
jenkins-bot [Mon, 22 Oct 2018 17:08:50 +0000 (17:08 +0000)]
Merge "Deprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode"

5 years agoMerge "Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy"
jenkins-bot [Mon, 22 Oct 2018 16:47:47 +0000 (16:47 +0000)]
Merge "Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy"

5 years agoRemove untidy wrapper from ImagePage::makeMetadataTable()
C. Scott Ananian [Wed, 17 Oct 2018 14:47:35 +0000 (10:47 -0400)]
Remove untidy wrapper from ImagePage::makeMetadataTable()

Replace a fragile <div> wrapper with the robust
OutputPage::wrapWikiTextAsInterface() wrapper.

Bug: T205624
Change-Id: I0a1ba0da6af97f0233afdd8ba7202abed0998419

5 years agoMerge "Remove Language::truncate(), deprecated in MW 1.31"
jenkins-bot [Mon, 22 Oct 2018 16:33:57 +0000 (16:33 +0000)]
Merge "Remove Language::truncate(), deprecated in MW 1.31"

5 years agoFollow-up T174035: Wrap inline ternary in brackets to make phpcs happy
James D. Forrester [Mon, 22 Oct 2018 16:23:22 +0000 (09:23 -0700)]
Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy

Bug: T203805
Change-Id: I418345870e25fa37df0195ddc74193b54fe6d2a5

5 years agoMerge "Rename WebInstallerOutput::addWikiTextInterface"
jenkins-bot [Mon, 22 Oct 2018 15:48:46 +0000 (15:48 +0000)]
Merge "Rename WebInstallerOutput::addWikiTextInterface"

5 years agoMerge "Fix comment handling on image upload or deletion"
jenkins-bot [Mon, 22 Oct 2018 15:08:42 +0000 (15:08 +0000)]
Merge "Fix comment handling on image upload or deletion"

5 years agoFix bad join on ChangeTag subquery
Amir Sarabadani [Mon, 22 Oct 2018 13:53:29 +0000 (15:53 +0200)]
Fix bad join on ChangeTag subquery

Bug: T207313
Change-Id: Iae6440630a533dfbcee3ccec34a9f231d3d013b5

5 years agoMerge "Replace http://be-x-old. by https://be-tarask."
jenkins-bot [Mon, 22 Oct 2018 10:19:12 +0000 (10:19 +0000)]
Merge "Replace be-x-old. by https://be-tarask."

5 years agoRename WebInstallerOutput::addWikiTextInterface
C. Scott Ananian [Mon, 22 Oct 2018 03:00:14 +0000 (23:00 -0400)]
Rename WebInstallerOutput::addWikiTextInterface

Follow up to I89f3398cffa771afcd5a33cfd11eb8510af3e7f7: this patch
was intended to mirror a new method added to OutputPage in
Ia58910164baaca608cea3b24333b7d13ed773339 but the bikeshed was painted
a slightly different color before the OutputPage patch was merged, and
somehow this patch wasn't changed to match.  The `addWikiTextInterface`
name was never included in a released MW version, so we don't need to
deprecate it, just fix it.

Change-Id: I636cb0ea0f9631c4c5e2bc118f479aec76d2b231

5 years agoMerge "Use OutputPage::wrapWikiTextAsInterface() to add safe <div> wrappers"
jenkins-bot [Mon, 22 Oct 2018 02:00:35 +0000 (02:00 +0000)]
Merge "Use OutputPage::wrapWikiTextAsInterface() to add safe <div> wrappers"

5 years agoDeprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode
C. Scott Ananian [Fri, 19 Oct 2018 15:06:15 +0000 (11:06 -0400)]
Deprecate $wgFixArabicUnicode / $wgFixMalayalamUnicode

These were introduced in MW 1.17 and are always true in production.

They were useful to allow folks to defer title conversion, but it's
been a long time now.  We don't need to make this optional any more.

Change-Id: I65dcfe80dc3e1dfeb4d63924a8928655e012a20c

5 years agoMerge "Use OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()"
jenkins-bot [Mon, 22 Oct 2018 01:49:58 +0000 (01:49 +0000)]
Merge "Use OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 21 Oct 2018 20:11:24 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I12979463cbff3cd1b6ed46ffe3a7839be0c35605

5 years agoMerge "Equalization translations for Serbian"
jenkins-bot [Sun, 21 Oct 2018 19:45:00 +0000 (19:45 +0000)]
Merge "Equalization translations for Serbian"

5 years agoMerge "Bump release notes for RemexHtml upgrade"
jenkins-bot [Sun, 21 Oct 2018 19:11:33 +0000 (19:11 +0000)]
Merge "Bump release notes for RemexHtml upgrade"

5 years agoBump release notes for RemexHtml upgrade
Kunal Mehta [Sun, 21 Oct 2018 18:48:59 +0000 (11:48 -0700)]
Bump release notes for RemexHtml upgrade

Change-Id: I43190e3dc8c74da4e226e173941fb6bdce454a02

5 years agoMerge "Remove mention of $wgHTCPMulticastRouting, not present since MW 1.24"
jenkins-bot [Sun, 21 Oct 2018 18:03:42 +0000 (18:03 +0000)]
Merge "Remove mention of $wgHTCPMulticastRouting, not present since MW 1.24"

5 years agoMerge "Upgrade wikimedia/remex-html to 2.0.1"
jenkins-bot [Sun, 21 Oct 2018 17:59:13 +0000 (17:59 +0000)]
Merge "Upgrade wikimedia/remex-html to 2.0.1"

5 years agoEqualization translations for Serbian
Zoranzoki21 [Sun, 14 Oct 2018 12:35:10 +0000 (14:35 +0200)]
Equalization translations for Serbian

Change-Id: I36a214181d24610fa0224d51223b1789d93be777

5 years agoMerge "Output Done! at end of resetUserEmail.php"
jenkins-bot [Sun, 21 Oct 2018 17:33:26 +0000 (17:33 +0000)]
Merge "Output Done! at end of resetUserEmail.php"

5 years agoSECURITY: Don't allow loading unprotected JS files
Brian Wolff [Thu, 27 Sep 2018 11:42:37 +0000 (11:42 +0000)]
SECURITY: Don't allow loading unprotected JS files

This is meant to protect against malicious people while avoiding
annoying good users as much as possible. We may want to restrict
this further in the future, but that's something that can be discussed
in the normal way.

Bug: T194204
Bug: T113042
Bug: T112937
Change-Id: I27e049bae78b5c0f63b10f454b740cb1dc394813

5 years agoMerge "Add .vscode to .gitignore file"
jenkins-bot [Sun, 21 Oct 2018 15:45:14 +0000 (15:45 +0000)]
Merge "Add .vscode to .gitignore file"

5 years agoAdd .vscode to .gitignore file
Zoranzoki21 [Sun, 21 Oct 2018 13:47:48 +0000 (15:47 +0200)]
Add .vscode to .gitignore file

.vscode is place of configurations for Visual Studio Code.

Change-Id: Ie066b9773af757181f325c090af1af68d4954236

5 years agoinstaller: Don't link to the obsolete "Extension Matrix" page
Zoranzoki21 [Sat, 29 Sep 2018 00:06:23 +0000 (03:06 +0300)]
installer: Don't link to the obsolete "Extension Matrix" page

Bug: T205765
Change-Id: Id1ba965c7c06ce03611ba745421dc982f5393f8c

5 years agoUpgrade wikimedia/remex-html to 2.0.1
Kunal Mehta [Sun, 21 Oct 2018 05:12:14 +0000 (22:12 -0700)]
Upgrade wikimedia/remex-html to 2.0.1

Bug: T207088
Depends-On: Id4bbbdb68678c37ec4aa84d519516199bb800393
Change-Id: Ia5822f5f283f5d935c78402ce71e2d010e9a7a91

5 years agoOutput Done! at end of resetUserEmail.php
Reedy [Sat, 20 Oct 2018 22:48:55 +0000 (23:48 +0100)]
Output Done! at end of resetUserEmail.php

Change-Id: I8e5572f0a60e74eec300031e75b79ee71ffc008d

5 years agoMerge "Don't pass a MailAddress pass the email to mail()"
jenkins-bot [Sat, 20 Oct 2018 20:34:23 +0000 (20:34 +0000)]
Merge "Don't pass a MailAddress pass the email to mail()"

5 years agoMerge "Fix typo in includes/watcheditem/WatchItemStoreInterface.php"
jenkins-bot [Sat, 20 Oct 2018 20:16:15 +0000 (20:16 +0000)]
Merge "Fix typo in includes/watcheditem/WatchItemStoreInterface.php"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 20 Oct 2018 20:00:02 +0000 (22:00 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I508681048d303f4814be18462689688b93443813

5 years agoFix typo in includes/watcheditem/WatchItemStoreInterface.php
Alangi Derick [Fri, 19 Oct 2018 20:21:35 +0000 (21:21 +0100)]
Fix typo in includes/watcheditem/WatchItemStoreInterface.php

Comment didn't quite make sense, fixing the typo by removing "the"
made it a little better and clear.

Change-Id: I33abdb3489ab704d50722a8df6acb402592908b2

5 years agoReplace http://be-x-old. by https://be-tarask.
Fomafix [Sat, 20 Oct 2018 18:49:56 +0000 (20:49 +0200)]
Replace http://be-x-old. by https://be-tarask.

Change-Id: I9a3f20bf3caaf9a0529f66f85953d56b8a34067e

5 years agoDon't pass a MailAddress pass the email to mail()
Reedy [Sat, 20 Oct 2018 12:37:15 +0000 (13:37 +0100)]
Don't pass a MailAddress pass the email to mail()

Bug: T207541
Change-Id: I1516023907e9773cb093010c6b67279f695abb1a

5 years agoInclude IP address in "Login for $1 succeeded" log entry
Kunal Mehta [Sat, 20 Oct 2018 12:35:22 +0000 (05:35 -0700)]
Include IP address in "Login for $1 succeeded" log entry

Bug: T207540
Change-Id: Iab4f2f2ddc8e64ead2f33356d03fa7beed399415

5 years agoMerge "Convert Special:EmailUser to use OOUIHTMLForm"
jenkins-bot [Fri, 19 Oct 2018 23:14:32 +0000 (23:14 +0000)]
Merge "Convert Special:EmailUser to use OOUIHTMLForm"

5 years agoMerge "RCFilters: Fix highlight circles for unseen changes"
jenkins-bot [Fri, 19 Oct 2018 22:58:05 +0000 (22:58 +0000)]
Merge "RCFilters: Fix highlight circles for unseen changes"

5 years agoMerge "Deprecate $wgSquidPurgeUseHostHeader"
jenkins-bot [Fri, 19 Oct 2018 21:44:29 +0000 (21:44 +0000)]
Merge "Deprecate $wgSquidPurgeUseHostHeader"

5 years agoMerge "Deprecate $wgUseESI"
jenkins-bot [Fri, 19 Oct 2018 21:43:27 +0000 (21:43 +0000)]
Merge "Deprecate $wgUseESI"

5 years agoMerge "objectcache: avoid using heavily time-drifted microtime() values in WAN cache"
jenkins-bot [Fri, 19 Oct 2018 20:55:47 +0000 (20:55 +0000)]
Merge "objectcache: avoid using heavily time-drifted microtime() values in WAN cache"

5 years agoMerge "During special page transclusion, save and restore context's WikiPage too"
jenkins-bot [Fri, 19 Oct 2018 20:55:41 +0000 (20:55 +0000)]
Merge "During special page transclusion, save and restore context's WikiPage too"

5 years agoRCFilters: Fix highlight circles for unseen changes
Roan Kattouw [Fri, 19 Oct 2018 20:38:44 +0000 (13:38 -0700)]
RCFilters: Fix highlight circles for unseen changes

These are supposed to be unfilled, but the CSS wasn't being applied
because it didn't have -color in the class name. Put it back into the
&-color block where it belongs.

Bug: T207472
Change-Id: Ic517b9a1a0e8e95015f5b2bd3517c36bff3b20e8
Follows-Up: I76fec57ff237ba02afefcea28916d8348bac9b0e

5 years agoDuring special page transclusion, save and restore context's WikiPage too
Bartosz Dziewoński [Wed, 17 Oct 2018 23:23:27 +0000 (01:23 +0200)]
During special page transclusion, save and restore context's WikiPage too

Setting the Title by calling setTitle clears the WikiPage, and the
next time getWikiPage() is called, it will be lazy-initialized to a
different instance of WikiPage.

This is mostly okay (the behavior has been like this for years and no
one noticed any problems), but it turns out that some extensions
(ConfirmEdit) use custom properties on the WikiPage object to pass
data between different hooks, which are lost when it's re-initialized.

Bug: T207065
Change-Id: I2881895f337bcfb1f86d5fc5a994fa9b0dcc768a

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 19 Oct 2018 20:02:41 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ic7961893e9cd4f67fdfdeb36c00ce414444c3f15

5 years agoRCFilters: Fix completely broken highlight circles
Roan Kattouw [Fri, 19 Oct 2018 19:18:35 +0000 (12:18 -0700)]
RCFilters: Fix completely broken highlight circles

- Correct highlights class name (mw-rcfilters-ui-highlights, not
  mw-rcfilters-ui-changesListWrapperWidget-highlights)
- Remove -circle class suffix that the circles don't actually have
- Go back to using float: right; instead of text-align: right;
  (you can't use text-align for things that aren't inline)
- For seen/unseen watched items, apply circle mixin to the actual
  circles themselves, not their parents

Bug: T207472
Change-Id: Iade1af4299826a4e8a2108425ace9a406f0aa8cb
Follows-Up: I76fec57ff237ba02afefcea28916d8348bac9b0e

5 years agoInclude BCP 47 codes in $wgDummyLanguageCodes, but deprecate it
C. Scott Ananian [Fri, 19 Oct 2018 14:40:38 +0000 (10:40 -0400)]
Include BCP 47 codes in $wgDummyLanguageCodes, but deprecate it

Add BCP 47 codes to $wgDummyLanguageCodes to ensure that
Language::factory() will return a valid MediaWiki-internal code if
given a BCP 47 alias.  We will want to make $wgDummyLanguageCodes a
private property of LanguageCode eventually, but let's start with
removing it from user configuration.

Setting $wgDummyLanguageCodes in LocalSettings.php has been deprecated
since 1.29.  Hard deprecate adding entries to $wgDummyLanguageCodes so
that we can eventually remove manual overrides from user
configuration.

This is a follow-up to 48ab87d0a37da80c2e2ae3a20f645548d2a787f9,
which described the various categories of codes, and
21ead7a98d1a103b77f1e3ba29a85493782d398b, which added the correct
BCP 47 mappings.

Bug: T207433
Change-Id: I9f6dda3360f79ab65f6392f44c98926588d851c8

5 years agoRemove mention of $wgHTCPMulticastRouting, not present since MW 1.24
C. Scott Ananian [Fri, 19 Oct 2018 15:42:26 +0000 (11:42 -0400)]
Remove mention of $wgHTCPMulticastRouting, not present since MW 1.24

Change-Id: I04ba9761e98ac4cf177cd2581f0304206cd4365c

5 years agoDeprecate $wgSquidPurgeUseHostHeader
C. Scott Ananian [Fri, 19 Oct 2018 15:40:17 +0000 (11:40 -0400)]
Deprecate $wgSquidPurgeUseHostHeader

This header supports Squid in forward-proxy mode using HTTP/1.0
HTTP headers.  It is not used in production.

Change-Id: I99646c9c5519bd55b3d4988306e379f89d413bdc

5 years agoDeprecate $wgUseESI
C. Scott Ananian [Fri, 19 Oct 2018 15:36:44 +0000 (11:36 -0400)]
Deprecate $wgUseESI

This was an experimental Squid 3 feature which is now defunct.

Change-Id: I799d87309b0dc77100900b75040fa9b85a35fc9a

5 years agoMerge "Watchlist: Commit after each batch watchlist insertion and removal"
jenkins-bot [Fri, 19 Oct 2018 15:23:20 +0000 (15:23 +0000)]
Merge "Watchlist: Commit after each batch watchlist insertion and removal"

5 years agoMerge "Add docs and minor cleanup in PHPVersionCheck.php"
jenkins-bot [Thu, 18 Oct 2018 22:04:45 +0000 (22:04 +0000)]
Merge "Add docs and minor cleanup in PHPVersionCheck.php"

5 years agoFix comment handling on image upload or deletion
Brad Jorsch [Thu, 18 Oct 2018 21:12:44 +0000 (17:12 -0400)]
Fix comment handling on image upload or deletion

Before Iab5f5215, the call to CommentStore::insertWithTempTable() also
happened to populate image_comment_temp for the later call to
insertSelect() when moving rows from the image table to oldimage or
filearchive. There was nothing in the image table itself that needed
updating.

In that change those calls were changed to CommentStore::insert(), but
it was missed that in that case we do have to update the image table
itself.

Bug: T207419
Change-Id: I26c417c9ab8a9160a7c7ec548ffdfabf17f01980

5 years agoAdd COALESCE for image deletion and imgcomment_description_id
Brad Jorsch [Thu, 18 Oct 2018 20:51:42 +0000 (16:51 -0400)]
Add COALESCE for image deletion and imgcomment_description_id

I have no idea why this suddenly started raising an error rather than it
doing so since February (I0dd7258fe). But this should fix it.

Bug: T207419
Change-Id: Id97e1c7c2655d90928c777bc3377e5ea23f49f6b

5 years agoMerge "Localisation updates from https://translatewiki.net."
jenkins-bot [Thu, 18 Oct 2018 20:41:25 +0000 (20:41 +0000)]
Merge "Localisation updates from https://translatewiki.net."

5 years agoMerge "Add ICU mapping for versions 62 and 63"
jenkins-bot [Thu, 18 Oct 2018 20:15:50 +0000 (20:15 +0000)]
Merge "Add ICU mapping for versions 62 and 63"

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Thu, 18 Oct 2018 20:15:04 +0000 (22:15 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Idb8c9ff1533aa8470455dba149333a6212c509a5

5 years agoMerge "Sort allowed log actions when displaying"
jenkins-bot [Thu, 18 Oct 2018 19:34:20 +0000 (19:34 +0000)]
Merge "Sort allowed log actions when displaying"

5 years agoAdd ICU mapping for versions 62 and 63
Reedy [Thu, 18 Oct 2018 19:03:59 +0000 (20:03 +0100)]
Add ICU mapping for versions 62 and 63

Change-Id: I5e1238e856d4149c30806e6b2cb3619c0c9c1dbf

5 years agoobjectcache: avoid using heavily time-drifted microtime() values in WAN cache
Aaron Schulz [Thu, 18 Oct 2018 18:42:27 +0000 (11:42 -0700)]
objectcache: avoid using heavily time-drifted microtime() values in WAN cache

Change-Id: Ifcb9e4b4a1d5adfdaaa6ea505e34956516b871de

5 years agoWatchlist: Commit after each batch watchlist insertion and removal
Kosta Harlan [Tue, 2 Oct 2018 19:55:53 +0000 (15:55 -0400)]
Watchlist: Commit after each batch watchlist insertion and removal

With this change, adding large numbers (500+) of items to one's Watchlist via
Special:EditWatchlist/raw will no longer trigger DBPerformance warnings
for "max affected rows expectation not met". The same code mechanism is added
for bulk removal of watchlist items.

Bug: T171898
Depends-On: Ia0f496b8bfb2b68217d0f45f892045538494bfdc
Change-Id: I832b1843d1341b05227cdee2549bdcefa21eb300

5 years agoAdd docs and minor cleanup in PHPVersionCheck.php
Alangi Derick [Thu, 18 Oct 2018 17:50:48 +0000 (18:50 +0100)]
Add docs and minor cleanup in PHPVersionCheck.php

- Consistency of the acronym PHP instead of "php".
- Add documentation to $functionsExtensionsMapping.

Change-Id: I06b507128bc3b95605a764cd63f621dbae3b2dc3

5 years agoMerge "Fix jqueryMsg breaking when passed an undefined param"
jenkins-bot [Thu, 18 Oct 2018 17:36:13 +0000 (17:36 +0000)]
Merge "Fix jqueryMsg breaking when passed an undefined param"

5 years agoMerge "Revert "Introduce Special:RedirectExternal""
jenkins-bot [Thu, 18 Oct 2018 17:05:10 +0000 (17:05 +0000)]
Merge "Revert "Introduce Special:RedirectExternal""

5 years agoFix jqueryMsg breaking when passed an undefined param
Jakob Warkotsch [Thu, 18 Oct 2018 16:02:12 +0000 (18:02 +0200)]
Fix jqueryMsg breaking when passed an undefined param

This restores the behavior for undefined params as it was before
I445f9194bb8b2ed35baafbda30d1d0d008b64e2c

Bug: T207397
Change-Id: I751f01a9b3cd8bb87d7d7def98c918a87ddf81cd

5 years agoSort allowed log actions when displaying
Matěj Suchánek [Thu, 2 Aug 2018 10:02:02 +0000 (12:02 +0200)]
Sort allowed log actions when displaying

This makes searching in the dropdown on Special:ApiSandbox simpler
because it keeps actions of the same log type together.

Change-Id: I240f5e19938393d5c15a1f5e7dd27780957231c0

5 years agoRevert "Introduce Special:RedirectExternal"
Kosta Harlan [Thu, 18 Oct 2018 16:15:21 +0000 (16:15 +0000)]
Revert "Introduce Special:RedirectExternal"

This reverts commit b83cf88837d589ae82a41fffb68dd82855aff2e5.

Reason for revert: Security concerns, needs some more nuance.

Change-Id: I5823c3da77accca9839f9632611315223e05351b

5 years agoMerge "ImagePage: Inherit parent's handling for action=render"
jenkins-bot [Thu, 18 Oct 2018 15:34:41 +0000 (15:34 +0000)]
Merge "ImagePage: Inherit parent's handling for action=render"

5 years agoMerge "Reword 'prefixindex-strip' to "Hide the prefix in results""
jenkins-bot [Thu, 18 Oct 2018 08:26:57 +0000 (08:26 +0000)]
Merge "Reword 'prefixindex-strip' to "Hide the prefix in results""

5 years agoImagePage: Inherit parent's handling for action=render
Bartosz Dziewoński [Thu, 18 Oct 2018 03:06:23 +0000 (05:06 +0200)]
ImagePage: Inherit parent's handling for action=render

ImagePage::render() was calling parent::view() instead of
parent::render(), thus skipping Article::render() entirely.
Therefore the logic to disable section edit links (and also,
to add an 'X-Robots-Tag: noindex' header) was not being used.
This fixes T65891 and T21415 for pages in 'File:' namespace.

Bug: T206546
Change-Id: I36ae716c9a363ae29b7a785cc41430301250baba

5 years agoNew hook ApiOptions
Max Semenik [Tue, 24 Jul 2018 22:05:22 +0000 (15:05 -0700)]
New hook ApiOptions

We need it to inform API clients they're changing globally overridden
preferences.

Bug: T198913
Change-Id: I692a1fb42b73d72814f31bfe9bd400c65f59d83c

5 years agoReword 'prefixindex-strip' to "Hide the prefix in results"
Bartosz Dziewoński [Thu, 18 Oct 2018 00:21:05 +0000 (02:21 +0200)]
Reword 'prefixindex-strip' to "Hide the prefix in results"

"Strip" is a very jargony term for removing something.

Translations of this message to the languages I can vaguely understand
all use the equivalents of "hide", "remove", or "display without".
Several translations to small languages I don't understand include the
word "strip" verbatim, which is almost certainly a mistake.

Bug: T76972
Change-Id: I6bf690773bfb2e5c6c35b3101733d1cd3e936e70

5 years agoDatabase: Allow selectFieldValues() to accept SQL fragments
Brad Jorsch [Wed, 17 Oct 2018 15:26:51 +0000 (11:26 -0400)]
Database: Allow selectFieldValues() to accept SQL fragments

The documentation says "This must be a valid SQL fragment", but as
written it breaks if given anything other than a field name. It's easy
enough to fix by adding an alias to the internal select() call.

Bug: T201781
Change-Id: I76428af6d3aadc266254fdb24109a0ac2db3761f

5 years agoMerge "Introduce Special:RedirectExternal"
jenkins-bot [Wed, 17 Oct 2018 22:12:52 +0000 (22:12 +0000)]
Merge "Introduce Special:RedirectExternal"

5 years agoMerge "mw.feedback: Remove a hack with passing message parameters"
jenkins-bot [Wed, 17 Oct 2018 21:54:12 +0000 (21:54 +0000)]
Merge "mw.feedback: Remove a hack with passing message parameters"

5 years agoIntroduce Special:RedirectExternal
Kosta Harlan [Wed, 17 Oct 2018 17:35:57 +0000 (13:35 -0400)]
Introduce Special:RedirectExternal

Special:RedirectExternal is an unlisted special page that accepts a URL as
the first argument, and redirects the user to that page.
Example: Special:RedirectExternal/https://mediawiki.org

At the moment, this is intended to be used by the GrowthExperiments project in
order to track outbound visits to certain external links. But it could be
extended in the future to provide parameters for showing a message to the user
before redirecting, or explicitly requiring a user to click on the link, which
could help improve security when users follow on-wiki links to off-wiki sites.

Bug: T207115
Change-Id: I822af14a84569aab22249e2f16a662a60e60f76a

5 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 17 Oct 2018 21:13:10 +0000 (23:13 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: If357bae8816570dbccf5bbb42b040ad6de159e72

5 years agomw.feedback: Remove a hack with passing message parameters
Bartosz Dziewoński [Wed, 17 Oct 2018 20:33:54 +0000 (22:33 +0200)]
mw.feedback: Remove a hack with passing message parameters

I'm not sure what bug this is trying to work around. It mentions
T49395 but that doesn't look very relevant. Maybe the real problem was
confusion and bugs related to passing "raw params" (T33260#4675605).
Regardless, it's no longer needed now, because this code also works.

Change-Id: I580d46a5e4b7ff58989cb5fd6b7770e781fb5319

5 years agoMerge "jqueryMsg: Don't fall back to simple parser when jQuery params passed"
jenkins-bot [Wed, 17 Oct 2018 20:11:16 +0000 (20:11 +0000)]
Merge "jqueryMsg: Don't fall back to simple parser when jQuery params passed"

5 years agoRemove Language::truncate(), deprecated in MW 1.31
C. Scott Ananian [Wed, 17 Oct 2018 02:34:25 +0000 (22:34 -0400)]
Remove Language::truncate(), deprecated in MW 1.31

Bug: T197492
Change-Id: I7a3f7a33270402f4b16b286f5d6ed65fee920fcc

5 years agoMerge "rdbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries"
jenkins-bot [Wed, 17 Oct 2018 16:40:16 +0000 (16:40 +0000)]
Merge "rdbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries"

5 years agoMerge "Allow getRevisionText to function without the text table."
jenkins-bot [Wed, 17 Oct 2018 15:16:06 +0000 (15:16 +0000)]
Merge "Allow getRevisionText to function without the text table."

5 years agoUse OutputPage::wrapWikiTextAsInterface() to add safe <div> wrappers
C. Scott Ananian [Wed, 17 Oct 2018 14:28:05 +0000 (10:28 -0400)]
Use OutputPage::wrapWikiTextAsInterface() to add safe <div> wrappers

This ensures that broken messages can't break the <div> wrapper and
that the output is tidy.

Bug: T205624
Change-Id: I2511adf593a13528e205a82d9fcdc8a524d0a95f

5 years agoAllow getRevisionText to function without the text table.
daniel [Sun, 30 Sep 2018 21:34:59 +0000 (23:34 +0200)]
Allow getRevisionText to function without the text table.

Without this patch, getRevisionText would fail silently (by
returning false) when the text table no longer gets joined,
due to the switch to the new MCR schema.

Bug: T205808
Change-Id: Iffc25c82a5d2b865c28070c76156d39d390cc675

5 years agoUse OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()
C. Scott Ananian [Tue, 25 Sep 2018 15:02:07 +0000 (11:02 -0400)]
Use OutputPage::addWikiTextAsInterface() instead of untidy addWikiText()

This change ensures that the output is tidy, and is necessary to support
future parsers which will not be able to produce untidy output.

Bug: T198214
Change-Id: I743f4185a03403f8d9b9db010ff1ee4e9342e062

5 years agoMerge "Inject Config into Parser instead of using globals"
jenkins-bot [Wed, 17 Oct 2018 14:34:31 +0000 (14:34 +0000)]
Merge "Inject Config into Parser instead of using globals"

5 years agoMerge "Force type Language for $lang of doEditSectionLink"
jenkins-bot [Wed, 17 Oct 2018 14:34:26 +0000 (14:34 +0000)]
Merge "Force type Language for $lang of doEditSectionLink"

5 years agoMerge "Force type Language for $lang of DifferenceEngine::setTextLanguage"
jenkins-bot [Wed, 17 Oct 2018 14:30:48 +0000 (14:30 +0000)]
Merge "Force type Language for $lang of DifferenceEngine::setTextLanguage"

5 years agordbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries
Aaron Schulz [Wed, 17 Oct 2018 05:36:06 +0000 (22:36 -0700)]
rdbms: do not treat SAVEPOINT and RELEASE SAVEPOINT as write queries

Change-Id: Ib5d15d90260f30d08f3641a7fb36d82d363b012c

5 years agoMerge "Add OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext"
jenkins-bot [Wed, 17 Oct 2018 05:00:54 +0000 (05:00 +0000)]
Merge "Add OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext"

5 years agoForce type Language for $lang of doEditSectionLink
Fomafix [Mon, 23 Jul 2018 19:50:14 +0000 (21:50 +0200)]
Force type Language for $lang of doEditSectionLink

Also make the parameter $tooltip mandatory to ensure that a mandatory
parameter does follow an optional parameter. ParserOutput always fill
all parameters of doEditSectionLink.

The call of wfGetLangObj( $lang ) is not necessary anymore.

This change is a follow-up to Id49201957e716ef8a2ea930b3616ca4fe6e35633.

Change-Id: Ic49d76c7d9357f99b462471696f7e1eb86e70e3d

5 years agoForce type Language for $lang of DifferenceEngine::setTextLanguage
Fomafix [Tue, 19 Jun 2018 19:48:40 +0000 (21:48 +0200)]
Force type Language for $lang of DifferenceEngine::setTextLanguage

Change-Id: I77e7116f81072fa42f580552e7b94323cfe31856

5 years agoAdd OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext
C. Scott Ananian [Thu, 27 Sep 2018 15:04:45 +0000 (11:04 -0400)]
Add OutputPage::wrapWikiTextAsInterface() to safely wrap wikitext

This patch introduces a new method,
OutputPage::wrapWikiTextAsInterface(), which wraps the result of
OutputPage::addWikiTextAsInterface() in a tidy and robust way that
won't break if the wrapped message contains double newlines, extra
</div>, or other nasties.

This replaces a common unsafe pattern:
  $output->addWikiText( '<div class="..."' .... '</div>' );

Bug: T205624
Change-Id: I1040c7cf0ec1f5c4bef7c06d4486f50d85f2dc0f

5 years agoMerge "INSTALL, UPGRADE: Re-wrap to 80 chars and enforce"
jenkins-bot [Wed, 17 Oct 2018 03:17:56 +0000 (03:17 +0000)]
Merge "INSTALL, UPGRADE: Re-wrap to 80 chars and enforce"

5 years agoMerge "RELEASE-NOTES-1.32: Add entries for all changes to DefaultSettings.php"
jenkins-bot [Wed, 17 Oct 2018 02:46:00 +0000 (02:46 +0000)]
Merge "RELEASE-NOTES-1.32: Add entries for all changes to DefaultSettings.php"

5 years agoINSTALL, UPGRADE: Re-wrap to 80 chars and enforce
James D. Forrester [Wed, 13 Jun 2018 19:04:51 +0000 (12:04 -0700)]
INSTALL, UPGRADE: Re-wrap to 80 chars and enforce

Change-Id: Idabcc4db7a0b25448e7ad30641763e2b3e1a3160

5 years agoMerge "Prepare for REL1_32 cut, labelling master as 1.33-alpha"
jenkins-bot [Wed, 17 Oct 2018 01:52:30 +0000 (01:52 +0000)]
Merge "Prepare for REL1_32 cut, labelling master as 1.33-alpha"